John Darrington [Thu, 18 Feb 2016 05:51:07 +0000 (06:51 +0100)]
Fixed bug where an empty chart (one with no data) would crash.
Reported by: Friedrich Beckmann
Fixes bug: #47181
John Darrington [Tue, 16 Feb 2016 11:35:17 +0000 (12:35 +0100)]
Boxplot: Do not attempt to draw whiskers if they are not defined
Friedrich Beckmann [Tue, 16 Feb 2016 09:30:32 +0000 (10:30 +0100)]
histogram - added another upper bin to include cases which have max values
This fixes the problem that cases which have values exactly at the upper
bin limit of the upper bin are not included in the binning. The fix
is based on the idea from John to just add another bin when the bin
limit is just equal to the maximum case value.
Friedrich Beckmann [Tue, 16 Feb 2016 09:16:22 +0000 (10:16 +0100)]
Revert "histogram - fixed missing cases which have the maximum value"
This reverts commit
ca4012bcf0f8790ceb8539b55bbc296d0802d5d7.
Friedrich Beckmann [Mon, 15 Feb 2016 18:40:22 +0000 (19:40 +0100)]
histogram - changed bin range computation
The bin range computation for the histogram showed bin limits at 4.999999
when 5.0 was expected. Added values with value 5.0 were therefore added
to the following bin. With this change the bin limits do not show the
rounding error. At least I could not reproduce the error that showed
up when using the routing from gsl_histogram_set_ranges_uniform.
Friedrich Beckmann [Mon, 15 Feb 2016 18:26:43 +0000 (19:26 +0100)]
histogram - fixed missing cases which have the maximum value
The histogram uses gsl_histogram routines which exclude values from
the last bin when the value is exactly the maximum value, i.e. the upper
value of the last bin. This results in excluded cases in the histogram.
This fixes bug #47139: https://savannah.gnu.org/bugs/?47139
Friedrich Beckmann [Sun, 14 Feb 2016 19:44:15 +0000 (20:44 +0100)]
MacOS build - fixed src/libpspp/automake.c version.c generation
The build on MacOS failed because echo introduces newlines which
produces syntax errors in the generated version.c file. I replaced the
echo with printf.
Fixes bug #47143: http://savannah.gnu.org/bugs/?47143
John Darrington [Tue, 9 Feb 2016 01:52:33 +0000 (02:52 +0100)]
Update fr.po from translationproject.org
John Darrington [Fri, 5 Feb 2016 12:00:35 +0000 (13:00 +0100)]
Correct error in Mann-Whitney test
Fixes bug #47041
John Darrington [Thu, 4 Feb 2016 07:02:27 +0000 (08:02 +0100)]
Fix memory leak in pspp-convert
John Darrington [Wed, 3 Feb 2016 16:43:23 +0000 (17:43 +0100)]
Fix memory leak when writing compressed sav files
John Darrington [Wed, 3 Feb 2016 09:30:13 +0000 (10:30 +0100)]
Fix memory leak pspp-convert
John Darrington [Wed, 3 Feb 2016 08:25:11 +0000 (09:25 +0100)]
Fix memory leak in SYSFILE command
John Darrington [Wed, 3 Feb 2016 07:49:46 +0000 (08:49 +0100)]
Fix memory leak which occured when iconv failed
John Darrington [Wed, 3 Feb 2016 07:07:45 +0000 (08:07 +0100)]
Fix memory leak in render-test.c
John Darrington [Tue, 2 Feb 2016 18:55:22 +0000 (19:55 +0100)]
Remove some g_param_spec_ strings from the translation domain
John Darrington [Tue, 2 Feb 2016 18:48:38 +0000 (19:48 +0100)]
Save File test: Restore permissions after test
This avoids annoyance when debugging.
John Darrington [Mon, 1 Feb 2016 11:18:10 +0000 (12:18 +0100)]
Fix memory leak in barcharts
John Darrington [Mon, 1 Feb 2016 09:54:39 +0000 (10:54 +0100)]
Frequencies: Fix some memory leaks
Ben Pfaff [Sun, 31 Jan 2016 20:28:54 +0000 (12:28 -0800)]
spreadsheet: Avoid sharing a dictionary between spreadsheet and client.
Spreadsheet implementations keep a copy of the dictionary that they build
to simplify reading cases. Until now, they shared that dictionary, in a
modifiable way, with their client. This meant, however, that if the client
modified the dictionary, it could screw up reading further cases from the
spreadsheet.
This commit fixes the problem by forcing clients to make their own copy of
the dictionary if they want to modify it.
Bug #44158.
John Darrington [Sun, 31 Jan 2016 08:53:17 +0000 (09:53 +0100)]
Univariate Dialog: Fix help-page
John Darrington [Sun, 31 Jan 2016 08:39:24 +0000 (09:39 +0100)]
Univariate Dialog: Set margins
John Darrington [Sun, 31 Jan 2016 08:34:20 +0000 (09:34 +0100)]
Set visibility on univariate dialog
John Darrington [Sat, 30 Jan 2016 20:46:07 +0000 (21:46 +0100)]
Correct the use of signals vs. events.
Commit
f8fdc760d4ee04801a2da8af0700b2a87f724ae4 used a button-press-event
where a toggled signal was appropriate. The signal might come from a
number of sources, not necesarily a button event.
John Darrington [Wed, 27 Jan 2016 19:18:20 +0000 (20:18 +0100)]
Use win32 functions for accessing filename
John Darrington [Sat, 30 Jan 2016 17:59:28 +0000 (18:59 +0100)]
Remove commented out code
John Darrington [Sat, 30 Jan 2016 10:45:28 +0000 (11:45 +0100)]
Reimplement the Windows menu.
Fixes bug #45253
John Darrington [Wed, 27 Jan 2016 18:40:16 +0000 (19:40 +0100)]
Remove g_mem_set_vtable
This function is deprecated.
John Darrington [Tue, 19 Jan 2016 07:36:57 +0000 (08:36 +0100)]
GLM: remove warning
John Darrington [Tue, 19 Jan 2016 16:47:04 +0000 (17:47 +0100)]
GLM: Do not print the intercept if the model is unbalanced
I cannot find any reliable explanation of how to calculate this
figure for unbalanced models not what it actually means. So
let's not even bother with it until an expert comes along.
John Darrington [Mon, 18 Jan 2016 12:16:51 +0000 (13:16 +0100)]
Add documentation for GLM
John Darrington [Fri, 22 Jan 2016 10:38:14 +0000 (11:38 +0100)]
PsppireDialogAction (generate_syntax): Change signature.
This function now takes a const parameter
John Darrington [Fri, 22 Jan 2016 10:18:22 +0000 (11:18 +0100)]
Fix compiler warning
John Darrington [Fri, 22 Jan 2016 16:04:15 +0000 (17:04 +0100)]
Smake: ensure that the "all" target is the first
John Darrington [Mon, 18 Jan 2016 09:09:50 +0000 (10:09 +0100)]
Include a dissuader for odd numbered minor releases
John Darrington [Thu, 21 Jan 2016 18:56:07 +0000 (19:56 +0100)]
Append a warning to the window title bar for odd versions.
John Darrington [Thu, 21 Jan 2016 18:32:23 +0000 (19:32 +0100)]
Place a warning on the splash screen for odd numbered releases
John Darrington [Tue, 19 Jan 2016 19:31:27 +0000 (20:31 +0100)]
Recode Dialog: Convert to PsppireDialogAction
John Darrington [Mon, 18 Jan 2016 06:48:32 +0000 (07:48 +0100)]
Help menu now uses "version" instead of "bare version".
John Darrington [Mon, 18 Jan 2016 16:18:02 +0000 (17:18 +0100)]
Convert THANKS file to utf8
Ben Pfaff [Sun, 17 Jan 2016 18:22:22 +0000 (10:22 -0800)]
spv-file-format: Fix typo.
Ben Pfaff [Sun, 17 Jan 2016 18:21:53 +0000 (10:21 -0800)]
spv-file-format: Fix names of pmml, stats, and model members.
Ben Pfaff [Sun, 17 Jan 2016 08:19:53 +0000 (00:19 -0800)]
Add documentation for SPV file format.
John Darrington [Sat, 16 Jan 2016 09:57:36 +0000 (10:57 +0100)]
Set import dialog to fullscreen mode.
Fixed bug #46906
John Darrington [Sat, 16 Jan 2016 09:01:41 +0000 (10:01 +0100)]
Sample Dialog: Ensure that controls stay at self consistent values
John Darrington [Sat, 16 Jan 2016 08:32:30 +0000 (09:32 +0100)]
Populate select dialog's dialog_is_valid function
Closes bug #46901
John Darrington [Fri, 15 Jan 2016 18:35:41 +0000 (19:35 +0100)]
Update appdata.xml
Closes bug #46441
Ben Pfaff [Fri, 15 Jan 2016 15:49:33 +0000 (07:49 -0800)]
measure: Improve wording of error message.
Suggested by Elias Estatistics <estatisticseu@gmail.com>.
Ben Pfaff [Fri, 15 Jan 2016 15:47:45 +0000 (07:47 -0800)]
psppire-button-editable: Don't mark spec parameter text as translatable.
The P_ prefix seems to be used by other GTK+ code, so use it here too.
Reported by Elias Estatistics <estatisticseu@gmail.com>.
Ben Pfaff [Fri, 15 Jan 2016 14:35:00 +0000 (06:35 -0800)]
SAVE TRANSLATE: Improve error message.
Before this commit, "SAVE TRANSLATE OUTFILE='...'" gave a confusing error
message. After this commit, it clearly reports the missing slash before
OUTFILE.
Ben Pfaff [Fri, 15 Jan 2016 14:26:28 +0000 (06:26 -0800)]
LIST: Improve wording of error messages.
Suggested by Elias Estatistics <estatisticseu@gmail.com>.
John Darrington [Wed, 13 Jan 2016 08:31:42 +0000 (09:31 +0100)]
EXAMINE: Extend test for empty dataset and fix bug.
Closes bug #46866
John Darrington [Tue, 12 Jan 2016 11:22:37 +0000 (12:22 +0100)]
ONEWAY: fix crash in contrasts when dataset is empty
John Darrington [Mon, 11 Jan 2016 08:31:18 +0000 (09:31 +0100)]
Fixed some bugs related to empty parentheses
John Darrington [Mon, 11 Jan 2016 08:43:09 +0000 (09:43 +0100)]
Add some tests for empty parens
Ben Pfaff [Thu, 7 Jan 2016 16:44:13 +0000 (08:44 -0800)]
FACTOR: Avoid assertion failures on syntax errors expecting numbers.
Reported by Elias Estatistics.
Ben Pfaff [Wed, 6 Jan 2016 01:53:29 +0000 (17:53 -0800)]
psppire-var-view: Fix constness error.
Ben Pfaff [Wed, 6 Jan 2016 01:52:21 +0000 (17:52 -0800)]
Makefiles: Add $(AM_V_GEN) and $(AM_V_at) to a few more rules.
This makes the abbreviated "make" output more effective.
Ben Pfaff [Wed, 6 Jan 2016 01:47:35 +0000 (17:47 -0800)]
APPLY DICTIONARY: Fix segmentation fault when setting value labels.
Reported by Frans Houweling.
Ben Pfaff [Wed, 6 Jan 2016 01:45:37 +0000 (17:45 -0800)]
segment: Fix buffer overrun error in segmenter_detect_command_name__().
Found by valgrind.
John Darrington [Tue, 5 Jan 2016 07:19:12 +0000 (08:19 +0100)]
Scatter plot dialog: Correct order of variables in syntax generator
John Darrington [Tue, 5 Jan 2016 07:01:38 +0000 (08:01 +0100)]
.ui files: Bump version of required Gtk to 3.4.2
This is the same version currently required in configure.ac
John Darrington [Mon, 4 Jan 2016 19:43:35 +0000 (20:43 +0100)]
Logistic Regression Dialog: Add missing property
John Darrington [Mon, 4 Jan 2016 19:30:45 +0000 (20:30 +0100)]
Fix bad syntax generation introduced by previous commit.
Commit
cdfb21de2cbbf921b4e1fe0662439da1c460eabc replaced syntax_gen_pspp
with g_string_append_printf which was wrong, because the latter is
sensitive to the user's locale, which is not desired for syntax generation.
John Darrington [Mon, 4 Jan 2016 18:32:34 +0000 (19:32 +0100)]
Logistical Regression Dialog: Automatically mark appropriate variables as categorical
In the syntax generator ordinal, nominal or string variables are now marked as /CATEGORICAL
Closes bug #46749
John Darrington [Mon, 4 Jan 2016 16:15:42 +0000 (17:15 +0100)]
Logistic Regression Dialog: Reimplement syntax generator using GString
John Darrington [Mon, 4 Jan 2016 13:05:14 +0000 (14:05 +0100)]
"margin-left" -> "margin-start" && "margin-right" -> "margin-end"
These are the preferred property names on recent Gtk releases.
Ben Pfaff [Mon, 4 Jan 2016 04:12:29 +0000 (20:12 -0800)]
REGRESSION: Correctly handle data in temporary file for SAVE subcommand.
The format of the data in the temporary file used by the SAVE subcommand is
basically unrelated to the format of the data in the active file, but the
code that created and wrote cases to it created them as clones of cases
in the active file. This is simply incorrect behavior and causes nasty
failures when the active file has an inconvenient number of variables or
contains long string variables.
This commit fixes the problem by correctly creating the cases for the
temporary file using that file's own caseproto.
In addition, the assignment of caseproto indexes to variables in the
temporary file was broken for /SAVE=PRED, because it would skip index 0.
This commit also fixes that problem.
Bug #44877.
Reported by Scott.
John Darrington [Sun, 3 Jan 2016 10:00:50 +0000 (11:00 +0100)]
Syntax menu definition: Rename "menuitem7" to "edit-menu"
Ben Pfaff [Sun, 3 Jan 2016 18:28:04 +0000 (10:28 -0800)]
GET DATA /TYPE=TXT: Remove obsolete IMPORTCASES subcommand.
For compatibility.
Reported by Charles Johnson.
John Darrington [Wed, 30 Dec 2015 08:53:20 +0000 (09:53 +0100)]
Rename Dataset dialog: Add spacing and help button
Ben Pfaff [Sun, 3 Jan 2016 06:28:12 +0000 (22:28 -0800)]
REGRESSION: Warn when REGRESSION with SAVE runs with a filter configured.
Reported by elias tsolis.
Bug #46727.
Ben Pfaff [Sun, 3 Jan 2016 06:05:00 +0000 (22:05 -0800)]
val-labs-dialog: Improve keyboard interface.
Before, hitting Enter in the value label dialog did nothing. With this
commit, Enter in the value entry moves to the label entry, and Enter in
the label entry adds or changes the value label and jumps back to the
value entry.
Requested by dr soumalya ray.
Ben Pfaff [Sun, 3 Jan 2016 05:34:13 +0000 (21:34 -0800)]
QUICK CLUSTER: Correct typo in documentation of PRINT subcommand.
The PRINT subcommand has a setting CLUSTER (not CLUSTERS).
Reported by Andy King.
Fix from Alan Mead.
Ben Pfaff [Sun, 3 Jan 2016 04:44:22 +0000 (20:44 -0800)]
sys-file-reader: Disallow system and scratch long variable names too.
Before this commit, the system file reader disallowed system and
scratch short variable names (e.g. names beginning with $ or #)
but not as long variable names. This fixes the problem.
Bug #46783.
Ben Pfaff [Sun, 3 Jan 2016 04:42:41 +0000 (20:42 -0800)]
RANK: Issue syntax error in case where it was omitted before.
Bug #46783.
Ben Pfaff [Sun, 3 Jan 2016 04:19:32 +0000 (20:19 -0800)]
LIST: Allow a subset of the CASES settings to be specified.
The LIST documentation said that any subset of the FROM, TO, and BY
settings could be used on the CASES subcommand, but until now the command
as implemented required all of them to be present. This commit fixes
the implementation.
Also updates the documentation to reflect the current implementation.
Ben Pfaff [Sun, 3 Jan 2016 04:18:29 +0000 (20:18 -0800)]
psppire-dialog-action: Fix compilation error.
John Darrington [Thu, 31 Dec 2015 13:59:49 +0000 (14:59 +0100)]
Select Cases Dialog: Convert to PsppireDialogAction
John Darrington [Wed, 30 Dec 2015 07:38:40 +0000 (08:38 +0100)]
Select Cases Dialog: minor refactor.
Encapsulate pointers to widgets in the dialog structure instead of retreiving
them from the GtkBuilder on each usage.
John Darrington [Tue, 29 Dec 2015 17:02:24 +0000 (18:02 +0100)]
Rearange widget registration into a table.
I think this will make things easier with Gtk3
John Darrington [Tue, 29 Dec 2015 14:17:21 +0000 (15:17 +0100)]
Split File Dialog: Convert to PsppireDialogAction
John Darrington [Tue, 29 Dec 2015 12:17:13 +0000 (13:17 +0100)]
Add an appropriate help page for the Variable Info dialog box
John Darrington [Tue, 29 Dec 2015 11:33:02 +0000 (12:33 +0100)]
examples/physiology.sav: Add a DOCUMENT comment to explain that the file contains "deliberate" data entry errors.
Occasionally this is the subject of bug reports.
John Darrington [Tue, 29 Dec 2015 11:31:46 +0000 (12:31 +0100)]
Comments dialog: convert to PsppireDialogAction
John Darrington [Tue, 29 Dec 2015 10:00:01 +0000 (11:00 +0100)]
Weight cases dialog: Convert from add hoc to PsppireDialogAction
John Darrington [Mon, 28 Dec 2015 11:26:43 +0000 (12:26 +0100)]
PsppireKeypad: Correct the attachment of buttons to the grid.
This buglet appears to have crept in during the GtkTable -> GtkGrid transition.
John Darrington [Sun, 27 Dec 2015 09:10:49 +0000 (10:10 +0100)]
Change some instances of GtkAction to PsppireDialogAction
John Darrington [Sat, 26 Dec 2015 10:15:15 +0000 (11:15 +0100)]
Rewrite Import Dialog.
This is a major rewrite of the text/spreadsheet import assistant.
Hopefully there are less bugs and it will be easier to maintain.
John Darrington [Tue, 22 Dec 2015 23:10:24 +0000 (00:10 +0100)]
Whitespace changes only
John Darrington [Tue, 22 Dec 2015 23:08:01 +0000 (00:08 +0100)]
Remove deprecated widgets
John Darrington [Tue, 22 Dec 2015 19:26:09 +0000 (20:26 +0100)]
Remove stray quotation marks and angle brackets
John Darrington [Mon, 21 Dec 2015 09:58:51 +0000 (10:58 +0100)]
Improved the autoconf test for xmllint
John Darrington [Thu, 17 Dec 2015 06:16:58 +0000 (07:16 +0100)]
Remove string stat_version
This string contained a timestamp indicating when ./configure had
been run. This makes for reproducibility issues and possibly
privacy issues too.
John Darrington [Wed, 16 Dec 2015 07:32:56 +0000 (08:32 +0100)]
Autorecode Dialog: Convert from add hoc to PsppireDialogAction
Friedrich Beckmann [Tue, 15 Dec 2015 23:35:11 +0000 (00:35 +0100)]
GRAPH scatterplot - fixed missing BY variable rendering
scatterplot with GRAPH /SCATTERPLOT x WITH y BY z did not use the by z
grouping of the cases. This patch fixes this.
John Darrington [Tue, 15 Dec 2015 17:08:05 +0000 (18:08 +0100)]
PsppSheetViewColumn: Replace some deprecated functions
John Darrington [Tue, 15 Dec 2015 11:31:06 +0000 (12:31 +0100)]
PsppSheetViewColumn: Replace GtkAlignment with a GtkBin
GtkAlignment is deprecated
John Darrington [Tue, 15 Dec 2015 06:43:21 +0000 (07:43 +0100)]
PsppSheetViewColumn: Remove GtkArrow
This widget is deprecated and we don't use this feature anyway.
John Darrington [Tue, 15 Dec 2015 19:34:35 +0000 (20:34 +0100)]
Recode Dialog: Remove deprecated widgets