Ben Pfaff [Wed, 22 Nov 2006 04:24:02 +0000 (04:24 +0000)]
Rewrite formatted data input routines to conform to SPSS data formats
as closely as possible
Ben Pfaff [Sun, 19 Nov 2006 03:44:10 +0000 (03:44 +0000)]
Fix grammar in comment.
Ben Pfaff [Sat, 18 Nov 2006 03:32:54 +0000 (03:32 +0000)]
Replace several similar lines by one line inside DO REPEAT.
John Darrington [Thu, 16 Nov 2006 12:47:22 +0000 (12:47 +0000)]
Apply patch #5561. Connect debugger on error.
John Darrington [Tue, 14 Nov 2006 12:29:25 +0000 (12:29 +0000)]
Fixed bug which crept in with the recent lexer changes.
Added regression test to check for this bug.
John Darrington [Tue, 14 Nov 2006 11:47:17 +0000 (11:47 +0000)]
Plugged some small memory leaks
John Darrington [Sat, 11 Nov 2006 23:10:00 +0000 (23:10 +0000)]
Encapsulated lexer and updated calling functions accordingly.
Ben Pfaff [Sat, 11 Nov 2006 19:43:33 +0000 (19:43 +0000)]
Fix buffer overflow reported by John Darrington.
Ben Pfaff [Sat, 11 Nov 2006 19:30:59 +0000 (19:30 +0000)]
Implement SKIP keyword on DATA LIST. Fixes bug #17099.
John Darrington [Tue, 7 Nov 2006 12:59:59 +0000 (12:59 +0000)]
Committed patch #5524, which allows the message destination to be
set on the command line.
Ben Pfaff [Sun, 5 Nov 2006 05:20:52 +0000 (05:20 +0000)]
Rewrite and improve formatted output routines.
Add lots of regression tests.
Revise documentation.
Thanks to John Darrington for review--see patch #5522.
John Darrington [Sun, 5 Nov 2006 00:35:43 +0000 (00:35 +0000)]
Added casefilter structure to assist with missing values. Changed T-TEST
and ONEWAY commands to use it.
Ben Pfaff [Sat, 4 Nov 2006 23:49:35 +0000 (23:49 +0000)]
* msg-ui.c (handle_msg): Only write message to terminal if
get_error_routing_to_terminal() returns true.
Ben Pfaff [Sat, 4 Nov 2006 19:49:45 +0000 (19:49 +0000)]
Implement SET ERRORS, SHOW ERRORS.
John Darrington [Fri, 3 Nov 2006 09:54:15 +0000 (09:54 +0000)]
Updated the docs and the parser for EXAMINE to make it clearer which options
are currently supported and which are not.
Ben Pfaff [Fri, 3 Nov 2006 04:53:51 +0000 (04:53 +0000)]
Completely rewrite src/data/format.[ch], to achieve better
abstraction. Rewrite all references to formats in other files.
See patch #5511.
Ben Pfaff [Thu, 2 Nov 2006 04:51:41 +0000 (04:51 +0000)]
* sys-file-info.c: (cmd_display) Use compare_var_ptr_names to
compare "struct variable **"s, not compare_var_names. Fixes bug
#17423.
Ben Pfaff [Wed, 1 Nov 2006 03:36:09 +0000 (03:36 +0000)]
Remove num_to_string() function, because it is not used anywhere.
Ben Pfaff [Wed, 1 Nov 2006 03:33:01 +0000 (03:33 +0000)]
Tue Oct 31 19:29:05 2006 Ben Pfaff <blp@gnu.org>
* configure.ac: Drop tests for strchr, strrchr because now we
assume a C89 compliant library. (Gnulib makes this assumption so
we might as well too.)
Ben Pfaff [Wed, 1 Nov 2006 03:25:36 +0000 (03:25 +0000)]
Add missing "#include <config.h>".
Ben Pfaff [Wed, 1 Nov 2006 02:22:35 +0000 (02:22 +0000)]
Tue Oct 31 18:21:48 2006 Ben Pfaff <blp@gnu.org>
* print-space.c (print_space_trns_proc): Let dfm_put_record add
the new-line character, to match dfm_put_record change below.
Ben Pfaff [Wed, 1 Nov 2006 02:12:25 +0000 (02:12 +0000)]
Fix error messages and comment.
Ben Pfaff [Sun, 29 Oct 2006 22:09:41 +0000 (22:09 +0000)]
Sun Oct 29 14:08:53 2006 Ben Pfaff <blp@gnu.org>
* Smake (GNULIB_MODULES): Remove `restrict' from modules, because
recent gnulib doesn't have such a module.
Ben Pfaff [Sun, 29 Oct 2006 22:04:09 +0000 (22:04 +0000)]
Reduce verbosity of ll-test, llx-test output.
John Darrington [Sun, 29 Oct 2006 11:16:07 +0000 (11:16 +0000)]
More constness
John Darrington [Sun, 29 Oct 2006 09:51:35 +0000 (09:51 +0000)]
Made array.h const correct, and dealt with the consequences.
Ben Pfaff [Sun, 29 Oct 2006 00:01:52 +0000 (00:01 +0000)]
Change some aspects of the PRINT, PRINT EJECT, and WRITE
transformations to more closely match SPSS behavior:
- PRINT puts spaces between variables, unless a format is specified
explicitly.
- WRITE doesn't put space between variables.
- PRINT to an external file prefixes each line with a space.
- PRINT EJECT to an external file indicates a formfeed by a "1" in the
first column.
- WRITE writes out spaces for system-missing values, not a period.
- When no output is specified, an empty record is output.
Also, update documentation and tests to match this behavior.
John Darrington [Sat, 28 Oct 2006 08:31:22 +0000 (08:31 +0000)]
Eliminated global variable getl_buf
Ben Pfaff [Sat, 28 Oct 2006 04:01:54 +0000 (04:01 +0000)]
Add routines for integer byte order conversions, floating point format
and byte order conversions, and ASCII<->EBCDIC conversion. Also add
an extensive floating point format conversion test.
The ASCII<->EBCDIC conversion used by SPSS does not correspond exactly
to any found in GNU libiconv, hence the need for a separate library.
These routines are a small part of a larger change set that I'm
breaking up for gradual submission. Thus, they aren't used by much
yet.
John Darrington [Thu, 26 Oct 2006 06:29:10 +0000 (06:29 +0000)]
Damn! Forgot to change casenum_t in *.q
John Darrington [Thu, 26 Oct 2006 06:16:36 +0000 (06:16 +0000)]
Eliminated global variable current_dataset.
The dataset is now owned by main, and passed around by pointer.
John Darrington [Wed, 25 Oct 2006 22:28:13 +0000 (22:28 +0000)]
Yet more constness
John Darrington [Sun, 22 Oct 2006 11:07:52 +0000 (11:07 +0000)]
More constness/namespace policing
Jason Stover [Fri, 20 Oct 2006 19:33:52 +0000 (19:33 +0000)]
removed useless code
John Darrington [Fri, 20 Oct 2006 11:32:56 +0000 (11:32 +0000)]
Constness and global namespace patrol.
John Darrington [Fri, 20 Oct 2006 03:00:25 +0000 (03:00 +0000)]
Added some more UNIMPL entries.
John Darrington [Thu, 19 Oct 2006 15:04:52 +0000 (15:04 +0000)]
Encapsulated the static data of procedure.[ch] into a single object, to be
passed into its functions. Dealt with the consequences.
Ben Pfaff [Mon, 16 Oct 2006 02:39:32 +0000 (02:39 +0000)]
* command.c: (do_parse_command) Issue an error for unimplemented
commands, instead of silently ignoring them. Reported by John
Darrington.
John Darrington [Sun, 15 Oct 2006 01:51:02 +0000 (01:51 +0000)]
Added a pooled version of hsh_create
Ben Pfaff [Sat, 14 Oct 2006 23:57:54 +0000 (23:57 +0000)]
* casefile.c (casereader_read_xfer): Always initialize the case,
even on an error condition.
Ben Pfaff [Sat, 14 Oct 2006 23:55:18 +0000 (23:55 +0000)]
Fix memory leak in rank_sorted_casefile().
Ben Pfaff [Sat, 14 Oct 2006 23:23:17 +0000 (23:23 +0000)]
Fix memory leak in test_casereader_clone().
John Darrington [Sat, 14 Oct 2006 00:25:20 +0000 (00:25 +0000)]
Changed a lot of ints to bools.
Ben Pfaff [Sun, 8 Oct 2006 16:54:46 +0000 (16:54 +0000)]
DISPLAY FILE LABEL is no longer undocumented.
John Darrington [Sun, 8 Oct 2006 01:49:15 +0000 (01:49 +0000)]
Memory leak patrol.
John Darrington [Sat, 7 Oct 2006 03:10:14 +0000 (03:10 +0000)]
Implemented the RANK command.
John Darrington [Wed, 27 Sep 2006 10:21:35 +0000 (10:21 +0000)]
Fixed warnings generated by gcc 4.1.2
Fixed bug in N OF CASES command which these warnings exposed.
Added a test for this bug (how many years had it gone unreported?)
John Darrington [Mon, 25 Sep 2006 09:35:15 +0000 (09:35 +0000)]
Added casereader_clone function.
Introduced casenum_t type to enumerate and count cases.
John Darrington [Sat, 23 Sep 2006 00:15:58 +0000 (00:15 +0000)]
Changed int to bool in dict_get_weight and sort_active_file_in_place
Ben Pfaff [Thu, 21 Sep 2006 14:01:09 +0000 (14:01 +0000)]
* variable.c: (width_to_bytes) Rephrase code for clarify.
Ben Pfaff [Thu, 14 Sep 2006 04:52:27 +0000 (04:52 +0000)]
Fix "size" in flt64 info record description: it's always 8, not 4.
Ben Pfaff [Tue, 22 Aug 2006 04:19:04 +0000 (04:19 +0000)]
Actually, the startup syntax file *is* implemented.
Ben Pfaff [Mon, 14 Aug 2006 01:06:59 +0000 (01:06 +0000)]
Error message needs a period at end of sentence.
Ben Pfaff [Sat, 5 Aug 2006 15:28:12 +0000 (15:28 +0000)]
Fix bug #17329 in REREAD parsing, reported by John Darrington.
Ben Pfaff [Mon, 31 Jul 2006 22:50:01 +0000 (22:50 +0000)]
New PURE_FUNCTION, CONST_FUNCTION macros.
Ben Pfaff [Mon, 31 Jul 2006 17:32:55 +0000 (17:32 +0000)]
Allow a comma between specifications on PRINT.
John Darrington [Sun, 30 Jul 2006 12:27:59 +0000 (12:27 +0000)]
Re-enabled automatic insertion of cases in data sheet.
John Darrington [Sat, 29 Jul 2006 09:37:18 +0000 (09:37 +0000)]
Made the variable sheet automatically add variables when clickes in a blank
row.
John Darrington [Sat, 29 Jul 2006 08:49:59 +0000 (08:49 +0000)]
Fixed bug where psppire tried to save a file even after Cancel had been clicked.
John Darrington [Sat, 29 Jul 2006 05:57:26 +0000 (05:57 +0000)]
Re-enabled saving of the current file.
John Darrington [Sun, 23 Jul 2006 10:32:50 +0000 (10:32 +0000)]
Fixed bug where gui would crash when columns were resized.
Ben Pfaff [Tue, 18 Jul 2006 04:57:01 +0000 (04:57 +0000)]
Patch #5244.
This patch cleans up DATA LIST and PRINT in preparation for
re-implementing REPEATING DATA (bug #12859). It reduces the code
duplication between DATA LIST and PRINT a great deal, actually
reducing the total code in PSPP by a couple hundred lines. The result
should be more maintainable as well as easier to read.
Ben Pfaff [Tue, 18 Jul 2006 01:24:15 +0000 (01:24 +0000)]
* Smake: Add --doc-base=gl/doc to gnulib-tool invocation, which is
required by recent gnulib.
John Darrington [Mon, 17 Jul 2006 10:45:42 +0000 (10:45 +0000)]
Patch #5209
Made casefile.c into an abstract base class, and moved the implementation to
fastfile.c.
Added a second implementation: flexifile.c which supports random access.
Currently, it's a very naive implementation.
Updated the gui to use flexifile.
Jason Stover [Sun, 16 Jul 2006 12:49:13 +0000 (12:49 +0000)]
center the data before computing the coefficients; remove variance member of innovations estimate
Jason Stover [Sun, 16 Jul 2006 12:19:23 +0000 (12:19 +0000)]
fixed and tested computation of coefficients
Ben Pfaff [Sat, 15 Jul 2006 22:39:18 +0000 (22:39 +0000)]
Improve comment.
Jason Stover [Sat, 15 Jul 2006 20:25:01 +0000 (20:25 +0000)]
made matrix argument const in coefficient initialization
Jason Stover [Sat, 15 Jul 2006 20:24:17 +0000 (20:24 +0000)]
fixed computation of sample covariance
John Darrington [Sat, 15 Jul 2006 04:53:43 +0000 (04:53 +0000)]
Added insert-variables.png to dists
John Darrington [Sat, 15 Jul 2006 04:38:57 +0000 (04:38 +0000)]
Applied patch file #10344.
Deleted src/ui/gui/psppire-case-array.*
make distcheck now passes.
Closes bug #16173
John Darrington [Sat, 15 Jul 2006 03:30:36 +0000 (03:30 +0000)]
Actually commit the icons
John Darrington [Sat, 15 Jul 2006 03:29:03 +0000 (03:29 +0000)]
Added toolbar icons. Hopefully somebody will contribute some better ones.
Jason Stover [Sat, 15 Jul 2006 01:55:55 +0000 (01:55 +0000)]
fixed intialization of coefficients
Jason Stover [Fri, 14 Jul 2006 19:17:50 +0000 (19:17 +0000)]
moved knowledge of pspp_linreg_cache out of pspp_coeff_init
Ben Pfaff [Fri, 14 Jul 2006 02:28:29 +0000 (02:28 +0000)]
Fixes for bugs/warts found in debug mode compile (bug #17092).
Thanks to Jason for reporting this bug and John for insight.
Jason Stover [Thu, 13 Jul 2006 20:44:44 +0000 (20:44 +0000)]
use struct design_matrix
Ben Pfaff [Thu, 13 Jul 2006 03:58:44 +0000 (03:58 +0000)]
(outp_drivers): [DEBUGGING] Delete unused declaration.
Ben Pfaff [Thu, 13 Jul 2006 03:57:34 +0000 (03:57 +0000)]
Add missing include.
Ben Pfaff [Wed, 12 Jul 2006 20:41:29 +0000 (20:41 +0000)]
Add check_PROGRAMS and define to empty.
Ben Pfaff [Wed, 12 Jul 2006 20:41:29 +0000 (20:41 +0000)]
Add check_PROGRAMS and define to empty.
Ben Pfaff [Wed, 12 Jul 2006 17:09:19 +0000 (17:09 +0000)]
Put ll-test, llx-test in check_PROGRAMS instead of noinst_PROGRAMS.
Ben Pfaff [Wed, 12 Jul 2006 14:05:34 +0000 (14:05 +0000)]
Fix variable name description.
Thanks to Oliver Bock for correction.
John Darrington [Mon, 10 Jul 2006 09:28:14 +0000 (09:28 +0000)]
Minor cleanup and spot fixes.
Ben Pfaff [Sat, 8 Jul 2006 03:05:51 +0000 (03:05 +0000)]
Apply patch #5225, assertions.
Ben Pfaff [Fri, 7 Jul 2006 02:10:08 +0000 (02:10 +0000)]
Fix link error noted by Jason Stover.
Jason Stover [Thu, 6 Jul 2006 23:58:05 +0000 (23:58 +0000)]
subscript fixes
Ben Pfaff [Thu, 6 Jul 2006 05:16:07 +0000 (05:16 +0000)]
Add expressions/randist/compare.pl to EXTRA_DIST.
Jason Stover [Wed, 5 Jul 2006 23:54:36 +0000 (23:54 +0000)]
added new initialization function
Jason Stover [Wed, 5 Jul 2006 18:06:35 +0000 (18:06 +0000)]
moved to src/math for wider availability
Ben Pfaff [Wed, 5 Jul 2006 05:14:30 +0000 (05:14 +0000)]
Fix bug #11612, "q2c documentation does not agree with code".
Thanks to John Darrington for review.
Ben Pfaff [Wed, 5 Jul 2006 02:52:35 +0000 (02:52 +0000)]
Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support ALL)
and additional underlying system file issues.
Reviewed by John Darrington
John Darrington [Tue, 4 Jul 2006 04:39:04 +0000 (04:39 +0000)]
Encapsulated msg_location inside msg_emit
Ben Pfaff [Tue, 4 Jul 2006 04:17:50 +0000 (04:17 +0000)]
Modify the random distributions test to verify to 2 more decimal
places of accuracy, but to allow +/- 1 units in the last (tested)
place. This allows the test to pass on machines or with compilers
whose calculated values are off by epsilon from the expected results.
Because of the way the test is constructed, this was quite common and
often caused gratuitous test failures.
This is patch #5215, tested by Jason Stover and John Darrington.
John Darrington [Tue, 4 Jul 2006 01:24:59 +0000 (01:24 +0000)]
Trivial change to make psppire properly deal with --version and --help
Jason Stover [Mon, 3 Jul 2006 19:41:20 +0000 (19:41 +0000)]
subscript fixes; added free functions
Ben Pfaff [Mon, 3 Jul 2006 17:39:07 +0000 (17:39 +0000)]
Make the destination for charts configurable in the HTML driver.
Fixes bug #15723, "HTML driver creates .png files insecurely".
Thanks to John Darrington for review.
John Darrington [Mon, 3 Jul 2006 01:38:24 +0000 (01:38 +0000)]
Fixed problem deallocating iconv structs.
Jason Stover [Sun, 2 Jul 2006 23:13:23 +0000 (23:13 +0000)]
fixed subscript in sum; added new functions; fixed allocation of theta
Ben Pfaff [Sun, 2 Jul 2006 06:19:24 +0000 (06:19 +0000)]
Fix comment.