John Darrington [Sat, 18 Feb 2012 13:36:23 +0000 (14:36 +0100)]
Remove erroneous case_unrefs. Found by valgrind
John Darrington [Sat, 18 Feb 2012 11:18:23 +0000 (12:18 +0100)]
Use if(0) instead of #if 0
The Gnu Coding Standards recommend run time conditionals instead of preprocessor
conditionals. I think this makes sense too, since #if 0'd code becomes obsolete
without anyone noticing.
John Darrington [Sat, 18 Feb 2012 11:12:46 +0000 (12:12 +0100)]
categoricals.c: Fix memory access problems on empty interactions.
Make sure the categoricals behave correctly when passed
an interaction which contains no variables (ie, no catagories).
John Darrington [Thu, 16 Feb 2012 19:00:58 +0000 (20:00 +0100)]
fix warnings
John Darrington [Thu, 16 Feb 2012 17:18:12 +0000 (18:18 +0100)]
MEANS: Correct position of double vertical rule
John Darrington [Thu, 16 Feb 2012 14:05:07 +0000 (15:05 +0100)]
Means: Report totals as well as catagories
John Darrington [Wed, 15 Feb 2012 10:08:58 +0000 (11:08 +0100)]
Psppire: Allow syntax files to be provided as an argument
John Darrington [Tue, 14 Feb 2012 10:13:15 +0000 (11:13 +0100)]
Reliability Test: Do not allow splits greater than the number of variables.
It's not meaningful to have a split point which is greater than the number
of variables (and not useful when they are equal). And the system was
exhaughsting its memory when such a test was run. This change therefore
disallows such a combination and updates the behaviour of the GUI accordingly.
John Darrington [Mon, 13 Feb 2012 20:04:11 +0000 (21:04 +0100)]
Add missing translation markup
John Darrington [Mon, 13 Feb 2012 18:16:37 +0000 (19:16 +0100)]
Use ButtonBox Mask nick field for it's correct purpose.
It seems that the GFlagsValue nick field was mistakenly being used as if
it was a translatable label. Not only was this wrong, but it also created
unnecessary work for translators. This change provides descriptions of the
flags and removes them from the translatable strings.
John Darrington [Mon, 13 Feb 2012 17:35:53 +0000 (18:35 +0100)]
Mark separator names for translation
John Darrington [Sun, 12 Feb 2012 10:25:31 +0000 (11:25 +0100)]
Added a dialog box for the MEANS command
Ben Pfaff [Sat, 11 Feb 2012 18:22:17 +0000 (10:22 -0800)]
examples: Change extensions from .stat to .sps.
.sps makes a lot more sense.
Reported-by: Harry Thijssen <pspp@sjpaes.nl>
Ben Pfaff [Sat, 11 Feb 2012 18:16:25 +0000 (10:16 -0800)]
tests: Improve test for supported encodings.
I misunderstood the purpose for the config.charset script. I had a
notion that it was supposed to print all of the character sets that
are supported by the operating system. It doesn't (it prints
character set names that need translation for the operating system).
This change switches to using the same code that will be used at
PSPP runtime to determine whether an encoding is supported, for
determining during the tests whether an encoding is supported.
This should cause fewer tests to be skipped on Mac OS.
Reported-by: Jeremy Lavergne <jeremy@lavergne.gotdns.org>
Ben Pfaff [Sat, 11 Feb 2012 18:09:28 +0000 (10:09 -0800)]
perl-module: use $(MAKE) directly in rules that call make.
The GNU make manual says that $(MAKE) must appear directly in a rule
rather than through recursive expansion to work properly. (This
change fixes a GNU make warning about an unavailable jobserver.)
John Darrington [Fri, 10 Feb 2012 12:40:06 +0000 (13:40 +0100)]
Fixed bug #35494 - Levene test crash on no valid values.
John Darrington [Thu, 9 Feb 2012 20:35:53 +0000 (21:35 +0100)]
Corrected typo in documentation
Ben Pfaff [Thu, 9 Feb 2012 06:30:38 +0000 (22:30 -0800)]
po: Update Slovenian translation from translationproject.org.
Ben Pfaff [Wed, 8 Feb 2012 06:58:09 +0000 (22:58 -0800)]
GET: Add an ENCODING subcommand.
For example, this allows a Swedish EBCDIC file that doesn't contain
any indication of its codepage to be read with "ENCODING='IBM278'".
Ben Pfaff [Wed, 8 Feb 2012 06:20:28 +0000 (22:20 -0800)]
sys-file: Support EBCDIC magic number in system files.
This makes PSPP able to read the 1980s EBCDIC-encoded system file
provided by Chris Muller <chris.muller@mullermedia.com>.
Ben Pfaff [Wed, 8 Feb 2012 06:08:41 +0000 (22:08 -0800)]
sys-file: Recode string fields in file header also.
Chris Muller <chris.muller@mullermedia.com> provided an example
EBCDIC-encoded mainframe system file from the 1980s. This commit
goes one step toward being able to read and write these files in
PSPP, by recoding most of the string fields in the file header.
Ben Pfaff [Wed, 8 Feb 2012 05:18:08 +0000 (21:18 -0800)]
dictionary: Truncate file label in dictionary encoding, not UTF-8.
The limiting factor is bytes in the on-disk format and so there's
no point in truncating in terms of the in-memory format.
Ben Pfaff [Tue, 7 Feb 2012 06:23:44 +0000 (22:23 -0800)]
por-file-writer: Avoid infinite loop with value labels.
Bug report and fix by Kent Nassen <knassen@umich.edu>.
Ben Pfaff [Tue, 7 Feb 2012 06:13:01 +0000 (22:13 -0800)]
gui: Fix warnings due to missing GObject type conversions.
Ben Pfaff [Tue, 7 Feb 2012 06:11:19 +0000 (22:11 -0800)]
jonckheere-terpstra: Declare variables at beginning of block.
John Darrington [Sun, 5 Feb 2012 17:41:53 +0000 (18:41 +0100)]
NPAR /J-T correct significance calculation when test statistic is greater than zero
Ben Pfaff [Sun, 5 Feb 2012 19:20:55 +0000 (11:20 -0800)]
gui: Fix grammar in user message in psppire-data-window.c
Reported-by: Harry Thijssen <pspp@sjpaes.nl>
John Darrington [Sun, 5 Feb 2012 16:32:17 +0000 (17:32 +0100)]
npar.c: Added some missing initialisers.
Also reorder the initialisers to the same order as their declarations
John Darrington [Sun, 5 Feb 2012 16:15:02 +0000 (17:15 +0100)]
Added an implementation of the Jonckheere-Terpstra test
Ben Pfaff [Sun, 5 Feb 2012 03:31:25 +0000 (19:31 -0800)]
Add Slovenian translation from translationproject.org.
This translation is by Matej Urbančič <matej.urban@gmail.com> and
the Slovenian translation team.
Ben Pfaff [Sun, 5 Feb 2012 03:26:22 +0000 (19:26 -0800)]
po: Update Dutch translation from translationproject.org.
Ben Pfaff [Sun, 5 Feb 2012 03:26:04 +0000 (19:26 -0800)]
po: Update German translation from translationproject.org.
John Darrington [Sat, 4 Feb 2012 12:46:31 +0000 (13:46 +0100)]
Logo rework.
From work contributed by bojo42: Reworked the transparent part of the logo.
Also "harmonised" the fonts used in the logo and the splash screen.
John Darrington [Sat, 4 Feb 2012 07:44:05 +0000 (08:44 +0100)]
New abstract base class: PsppireWindowBase
Created a new abstract base class for windows/dialogs and moved the
psppire_conf manipulation to there. Should fix problems reported by bojo42
where the window geometry wasn't always correctly saved.
Ben Pfaff [Sat, 4 Feb 2012 03:11:32 +0000 (19:11 -0800)]
Increment version to 0.7.9 to send to Translation Project.
John Darrington [Thu, 2 Feb 2012 20:46:39 +0000 (21:46 +0100)]
Error with g_critical instead of g_assert on invalid variable types.
John Darrington [Tue, 31 Jan 2012 21:37:49 +0000 (22:37 +0100)]
Rewrite documentation for the RECODE command.
Reviewed-by: Ben Pfaff
John Darrington [Tue, 31 Jan 2012 20:19:41 +0000 (21:19 +0100)]
Converted Sort dialog to a PsppireDialogAction object
Ben Pfaff [Tue, 31 Jan 2012 06:01:39 +0000 (22:01 -0800)]
po: Update German translation from translation-project.org.
John Darrington [Mon, 30 Jan 2012 20:40:33 +0000 (21:40 +0100)]
Converted reliability dialog to a PsppireDialogAction object
John Darrington [Sun, 29 Jan 2012 13:17:33 +0000 (14:17 +0100)]
Removed erroneous duplicated line
John Darrington [Sun, 29 Jan 2012 13:16:42 +0000 (14:16 +0100)]
Converted roc-dialog to a PsppireDialogAction object
John Darrington [Sun, 29 Jan 2012 10:57:50 +0000 (11:57 +0100)]
Convert kmeans dialog to a PsppireDialogAction
John Darrington [Sun, 29 Jan 2012 09:30:44 +0000 (10:30 +0100)]
Converted the correlations dialog to a PsppireDialogAction object
Ben Pfaff [Fri, 27 Jan 2012 06:06:02 +0000 (22:06 -0800)]
Move PSPP shared libraries from $(libdir) to $(libdir)/pspp.
The PSPP shared libraries do not have a stable ABI and so they
should not go in a public system library directory. This moves
them to a private library subdirectory.
Ben Pfaff [Fri, 27 Jan 2012 05:27:36 +0000 (21:27 -0800)]
Name the src/libpspp convenience library consistently.
src/libpspp.la and src/libpspp/libpspp.la have the same name,
although they are in different directories. This seems unduly
confusing. This commit renames the latter to liblibpspp.la, which
is at least different from libpspp.la and is also consistent with
the naming of the other libtool convenience libraries as
lib<directory>.la.
John Darrington [Thu, 26 Jan 2012 21:39:33 +0000 (22:39 +0100)]
Don't crash on Games-Howell test when there are small numbers of cases per category.
Fixes bug #34978
Ben Pfaff [Thu, 26 Jan 2012 05:17:19 +0000 (21:17 -0800)]
gui: Fix warnings.
This fixes warnings introduced in commit
53508ccb5785 (New abstract
class PsppireDialogAction).
Ben Pfaff [Thu, 26 Jan 2012 04:55:02 +0000 (20:55 -0800)]
perl-module: Fix bad arguments in call to settings_init().
Found by clang.
Reported-by: Jeremy Lavergne <jeremy@lavergne.gotdns.org>
Ben Pfaff [Thu, 26 Jan 2012 04:53:48 +0000 (20:53 -0800)]
perl-module: Add missing "#include"s to PSPP.xs.
Found by clang.
Reported-by: Jeremy Lavergne <jeremy@lavergne.gotdns.org>
Ben Pfaff [Thu, 26 Jan 2012 04:52:10 +0000 (20:52 -0800)]
perl-module: Add "!= NULL" to assignment used as condition.
Suppresses a "clang" warning.
Reported-by: Jeremy Lavergne <jeremy@lavergne.gotdns.org>
Ben Pfaff [Thu, 26 Jan 2012 04:47:13 +0000 (20:47 -0800)]
pspp-dump-sav: Fix sizeof on "array" that is actually a pointer.
Found by clang.
Reported-by: Jeremy Lavergne <jeremy@lavergne.gotdns.org>
John Darrington [Wed, 25 Jan 2012 20:02:18 +0000 (21:02 +0100)]
New abstract class PsppireDialogAction
Added a new object PsppireDialogAction which abstracts the behaviour of
dialog boxes.
Converted the Descriptived Dialog and the Variable Info Dialog to use this
new abstraction.
Reviewed-by: Ben Pfaff
Ben Pfaff [Wed, 25 Jan 2012 18:32:24 +0000 (10:32 -0800)]
Makefiles: Define dist_man_MANS before trying to add to it.
Fixes Automake complaint:
utilities/automake.mk:2: dist_man_MANS must be set with `=' before using `+='
Reported-by: John Darrington <john@darrington.wattle.id.au>
Ben Pfaff [Wed, 25 Jan 2012 16:29:17 +0000 (08:29 -0800)]
pspp-dump-sav: Mark manpage to be distributed.
Ben Pfaff [Wed, 25 Jan 2012 06:26:22 +0000 (22:26 -0800)]
RANK: Avoid putting declaration after statement.
Ben Pfaff [Wed, 25 Jan 2012 06:09:18 +0000 (22:09 -0800)]
pspp-dump-sav: Add manpage.
Ben Pfaff [Tue, 24 Jan 2012 05:28:53 +0000 (21:28 -0800)]
gui: Use $(INSTALL_DATA), not $(INSTALL), to install data files.
Plain $(INSTALL) always adds the executable bit to the installed
files, which has the wrong effect for data files.
Found by lintian.
John Darrington [Mon, 23 Jan 2012 18:47:01 +0000 (19:47 +0100)]
Moved rank.q to rank.c
John Darrington [Sun, 22 Jan 2012 19:37:46 +0000 (20:37 +0100)]
Reimplemented the logo as a svg image and converted to a 64x64 bit icon
Ben Pfaff [Sat, 21 Jan 2012 17:37:26 +0000 (09:37 -0800)]
README: Update.
Suggested-by: John Darrington <john@darrington.wattle.id.au>
John Darrington [Wed, 18 Jan 2012 19:32:57 +0000 (20:32 +0100)]
Added documentation for the MEANS command
John Darrington [Mon, 16 Jan 2012 19:06:43 +0000 (20:06 +0100)]
Improve behaviour of resizing the value chooser widget
John Darrington [Mon, 16 Jan 2012 13:23:35 +0000 (14:23 +0100)]
MEANS: Added further tests for missing value behaviour
John Darrington [Mon, 16 Jan 2012 09:47:18 +0000 (10:47 +0100)]
MEANS: Implemented /MISSING=TABLE subcommand
John Darrington [Mon, 16 Jan 2012 08:49:50 +0000 (09:49 +0100)]
MEANS: implemented the /CELLS={ALL,NONE,DEFAULT} options and added a test
Ben Pfaff [Sun, 15 Jan 2012 17:53:42 +0000 (09:53 -0800)]
Add German translation from translationproject.org.
This translation is by Matthias Keil <matthias.keil@uni-jena.de> and
the German translation team.
John Darrington [Sun, 15 Jan 2012 14:26:11 +0000 (15:26 +0100)]
Remove stray include directive
John Darrington [Sat, 14 Jan 2012 17:45:10 +0000 (18:45 +0100)]
Corrected various misspellings in the documentation
John Darrington [Sat, 14 Jan 2012 12:40:35 +0000 (13:40 +0100)]
MEANS: remove arguments to callbacks which were always unused
John Darrington [Sat, 14 Jan 2012 12:21:55 +0000 (13:21 +0100)]
Fix warnings
John Darrington [Sat, 14 Jan 2012 12:01:12 +0000 (13:01 +0100)]
MEANS: This command is IMO now stable enough to be used. Adding to command.def
Also added some tests.
John Darrington [Sat, 14 Jan 2012 11:54:51 +0000 (12:54 +0100)]
Categoricals cleanup: New structure 'payload' which reduces the
number of arguments to categoricals_create
John Darrington [Thu, 12 Jan 2012 20:21:54 +0000 (21:21 +0100)]
Avoid deprecated Perl syntax.
Apparently new perl versions don't like qw(x y z) without outer parentheses. See
http://search.cpan.org/~flora/perl-5.14.2/pod/perl5140delta.pod#Use_of_qw%28...%29_as_parentheses
This change adds these parentheses.
Reported-by: bojo42 <bojo42@gmail.com>
John Darrington [Wed, 11 Jan 2012 21:04:14 +0000 (22:04 +0100)]
Use idle callback to write to the local config directory
When the users config directory is on a filesystem with high latency,
moving a dialog box resulted in many writes and thus an unacceptable
delay. This change fixes that by consolidating the writes into a
low priority idle callback.
Ben Pfaff [Wed, 11 Jan 2012 04:52:11 +0000 (20:52 -0800)]
Fix PSPP link on OpenSUSE and possibly Ubuntu 11.10.
Reported-by: friedrich nietzsche <f_nietsje@hotmail.com>
at http://comments.gmane.org/gmane.comp.statistics.pspp.devel/4850
Reported-by: Luis Cebamanos <luiceur@gmail.com>
at http://comments.gmane.org/gmane.comp.statistics.pspp.devel/4869
Reported-by: Mindaugus <embar@super.lt>
Tested-by: Mindaugus <embar@super.lt>
Ben Pfaff [Sat, 7 Jan 2012 21:14:02 +0000 (13:14 -0800)]
cairo: Only apply options to table items, to avoid crash.
Most of the members of struct xr_rendering, including the 'xr'
member, are used only for table items. In chart items, these
members are zeroed. But xr_rendering_apply_options() attempted to
use the 'xr' member even for chart items, which caused a crash.
This reverts and replaces the provisional fix already applied by
John Darrington in commit
ee7b576822f (Avoid crash rendering charts
in the gui interface.), which also fixed the crash but added extra
unnecessary work.
Reported-by: Nick Macdonald <nick@nickmacdonald.net>
John Darrington [Thu, 5 Jan 2012 20:01:20 +0000 (21:01 +0100)]
online_help: use g_spawn_async instead of g_spawn_command_line_async
This change avoids potential problems caused by metacharacters in the
constructed command arguments.
Suggested by Ben Pfaff.
John Darrington [Thu, 5 Jan 2012 19:11:54 +0000 (20:11 +0100)]
Avoid crash rendering charts in the gui interface.
Reported-by: Nick Macdonald <nick@nickmacdonald.net>
Provisionally Reviewed-by: Ben Pfaff <blp@gnu.org>
John Darrington [Thu, 5 Jan 2012 14:39:23 +0000 (15:39 +0100)]
Fix memory leaks parsing string expressions
John Darrington [Thu, 5 Jan 2012 09:55:29 +0000 (10:55 +0100)]
Fix memory leaks
John Darrington [Thu, 5 Jan 2012 06:47:58 +0000 (07:47 +0100)]
lex_get_text_buffer_read: Avoid potential buffer overflow.
John Darrington [Tue, 3 Jan 2012 19:49:33 +0000 (20:49 +0100)]
Add files to manifest, inadvertantly omitted from previous commit.
John Darrington [Tue, 3 Jan 2012 19:41:35 +0000 (20:41 +0100)]
New file: builder-wrapper.h and builder-wrapper.c
Move the functions wrapping GtkBuilder out of helper.c
and into their own file.
John Darrington [Thu, 22 Dec 2011 19:57:23 +0000 (20:57 +0100)]
Set the output driver parameters dynamically from the output window style.
This change allows the output driver options to be changed after the driver
has been created. This is necessary in the GUI to follow the style changes
(eg from theme engines etc)
Ben Pfaff [Wed, 21 Dec 2011 03:12:19 +0000 (19:12 -0800)]
psppire-dialog: Add missing prototype for psppire_dialog_help() to header.
John Darrington [Sun, 18 Dec 2011 17:44:35 +0000 (18:44 +0100)]
doc/automake.mk: Added eacute to the list of docbook entities which need to be mutated
John Darrington [Sun, 18 Dec 2011 07:40:13 +0000 (08:40 +0100)]
Correct packing properties of sort cases dialog.
John Darrington [Sat, 17 Dec 2011 21:14:11 +0000 (22:14 +0100)]
Escape # character in call to g_spawn_command_line_async
It seems that this character was being treated as a comment start.
John Darrington [Sat, 17 Dec 2011 17:00:47 +0000 (18:00 +0100)]
Added a callback to the dialog help buttons, and a handler to call
the manual when clicked.
John Darrington [Sat, 17 Dec 2011 11:38:29 +0000 (12:38 +0100)]
Fix errors in the Texinfo source discovered by makeinfo 4.13.90
John Darrington [Sat, 17 Dec 2011 07:31:03 +0000 (08:31 +0100)]
Output Viewer: Try to adapt to changes in style
Set the fg and bg of viewer's container and its children to the
text and base of the output window upon style change. This means that
the output viewer will respond to changes in style once even after the
program has been started.
We still need some way to set the foreground colours of the cairo output
after the driver has been created, but that doesn't seem to be currently
possible.
Ben Pfaff [Tue, 13 Dec 2011 05:35:01 +0000 (21:35 -0800)]
gui: Make Enter work in the Goto Case dialog.
Without this change, Enter does nothing in the dialog that Edit|Goto Case
brings up. With this change, Enter activates the Goto button.
John Darrington [Sun, 11 Dec 2011 18:48:07 +0000 (19:48 +0100)]
Output viewer: use the widget's style to set the colors of the
output driver.
John Darrington [Sun, 11 Dec 2011 13:09:33 +0000 (14:09 +0100)]
Cairo output driver: Added options to set the foreground and background
colours.
John Darrington [Sun, 11 Dec 2011 11:39:42 +0000 (12:39 +0100)]
Remove xr_draw_chart from cairo.h and make static
The function xr_draw_chart is used only in cairo.c, so it seems there
is little point in having it public.
John Darrington [Sat, 10 Dec 2011 13:25:46 +0000 (14:25 +0100)]
Added basic framework for the MEANS command.
Not much here yet. Just the parser and framework
for the output.
John Darrington [Fri, 9 Dec 2011 10:24:56 +0000 (11:24 +0100)]
Added a function to clone an interaction.
John Darrington [Wed, 7 Dec 2011 18:38:30 +0000 (19:38 +0100)]
Value Labels Dialog: Fix packing properties
Ben Pfaff [Sun, 4 Dec 2011 18:44:07 +0000 (10:44 -0800)]
gui: Fix behavior of print preview in psppire-output-window.
Print preview only showed one page because the GtkPrintOperation emits
"paginate" again even after it returns TRUE once and our "paginate"
implementation was not prepared for that.
Also fixes a memory leak in paginate(): the driver used for pagination was
not being freed.
Reported-by: John Darrington <john@darrington.wattle.id.au>