Ben Pfaff [Mon, 15 Nov 2010 05:42:34 +0000 (21:42 -0800)]
tests: Only attempt to run PostgreSQL tests if the server is installed.
PSQL_SUPPORT only indicates that PSPP was compiled against the PostgreSQL
client library, but the test also requires the PostgreSQL server and
utilities to be installed, so skip the test if they are not.
Ben Pfaff [Fri, 5 Nov 2010 04:04:05 +0000 (21:04 -0700)]
csv: Better support separators other than comma or tab.
Before this commit, although any separator could be specified for cvs
output, the set of characters that triggered quoting was fixed, and only
really suitable for comma and tab separators. This commit fixes the
problem, making sure that whenever the specified separator appears in a
field, that field will be quoted.
Problem noticed during a discussion with Björn Manke <bjoernmanke@gmx.net>
on pspp-users.
Ben Pfaff [Tue, 2 Nov 2010 13:39:05 +0000 (06:39 -0700)]
Improve failure output of tests that use wc.
Commit 37c5ded73 "Make tests which use wc more robust." made these tests
tolerate slightly different output formats, but at the same time, if the
tests fail we don't find out why. This commit should retain the fix but
also provide more feedback in the log on failure.
Ben Pfaff [Sat, 30 Oct 2010 03:12:00 +0000 (20:12 -0700)]
cairo: Fix rendering of wide titles for GUI rendering.
The width of the title was not being taken into account in calculating the
size of a table_item in the code path used by the GUI, so titles wider
than their tables were truncated at the width of the table. This commit
fixes the problem.
Ben Pfaff [Wed, 27 Oct 2010 04:58:14 +0000 (21:58 -0700)]
psppire-output-window: Insert a half-line of space between output items.
Before, the lack of table titles put some vertical space into the output
window. Now that table titles are shown, there's no white space left, so
this commit reintroduces some by putting half a line of vertical white
space between output items.
Ben Pfaff [Wed, 27 Oct 2010 04:53:53 +0000 (21:53 -0700)]
cairo: Always save output item in xr_rendering_create().
Currently xr_rendering_create() only saves the output item passed in if it
is a chart. However an upcoming commit will have a need for table output
items too, so this commit always saves them.
When adjacent rows or columns contain only spanned cells and no rules give
the rows or columns a natural minimum height or width, this triggers a
special case in distribute_spanned_width(). This special case had not been
tested and (therefore) was broken. This commit fixes the problem and adds
test cases to prevent it from recurring.
When the current token is an identifier that takes the abstract syntax
of a format specifier, but its "name" part is not a valid format name,
parse_format_specifier() returned false but still consumed the token.
This is a potential issue for callers that want to report an error that
mentions the identifier, e.g. parse_primary(), although the current lexer
tends to retain the same identifier when the new token is not an
identifier.
John Darrington [Sun, 17 Oct 2010 14:50:47 +0000 (16:50 +0200)]
Fix test failures on T-TEST command.
The t-test command is documented to ignore cases
which are not in a valid group.
The new levene function does not have any awareness
of the group criteria. Therefore we must remove any
values which are not in a valid group.
Ben Pfaff [Sat, 16 Oct 2010 20:49:37 +0000 (13:49 -0700)]
doc: Always build ni.texi, tut.texi in source directory.
When the source and build directories are different, ni.texi and tut.texi
were being built in the build directory. This meant that, since
$(builddir)/doc is not in the TeX search path, but $(builddir) is (because
it is the working directory when TeX is invoked), the @include commands
that include ni.texi and tut.texi had to specify doc/ explicitly.
However, doing that broke the case where the source and build directories
were different but ni.texi or tut.texi were in the source directory (which
happens when building from a tarball or, similarly, running "make
distcheck"), because $(top_srcdir) is not in the TeX search path (only
$(top_srcdir)/doc is).
The easiest solution appears to be to always make sure that ni.texi and
tut.texi are in the source directory. Then they are always in the TeX
search path (as long as we drop the doc/ prefix) and everything should
work out OK.
Reported by Michel Boaventura <michel@michelboaventura.com>.
projects / pspp-builds.git / log