Use strict and all warnings. Simplify parsing. Add "@c End:" line to

output to suppress Emacs warning.  From bug #19335.  Reviewed by John
Darrington.

diff --git a/doc/ChangeLog b/doc/ChangeLog
index e63532274979e380c81483eb1d94c16e8d682dbd..80eec83aaa7ee8dc14bbad94eeb763b5e0f90705 100644 (file)
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -1,3 +1,9 @@
+2007-07-17  Ben Pfaff  <blp@gnu.org>
+
+       * get-commands.pl: Use strict and all warnings.  Simplify
+       parsing.  Add "@c End:" line to output to suppress Emacs warning.
+       From bug #19335.  Reviewed by John Darrington.
+
 2007-06-05  Ben Pfaff  <blp@gnu.org>
 
        * Removed next, prev, up node names from @node lines, to make

diff --git a/doc/get-commands.pl b/doc/get-commands.pl
index 7b6b2b581db9d2e2e3e7596f8ae7e6e68871c7ad..68a53b940d11c073adf750e54a08f797aeaa20dc 100755 (executable)
--- a/doc/get-commands.pl
+++ b/doc/get-commands.pl
@@ -1,32 +1,25 @@
 #!/usr/bin/perl
 # Creates Texinfo documentation from the source 
 
-$file = $ARGV[0]; 
+use strict;
+use warnings 'all';
+
+my ($file) = $ARGV[0]; 
 open(INFO, $file) || die "Cannot open \"$file\"\n" ;   
 print "\@c Generated from $file by get-commands.pl\n";
 print "\@c Do not modify!\n\n";
 
 print "\@table \@asis\n";
-while ($line = <INFO>)
+while (<INFO>)
 {
-    if ( $line =~ /^UNIMPL_CMD/ ) 
-    {
-       @fields = split(/,/,$line); 
-       $_ = $fields[0];
-       s/^UNIMPL_CMD//;
-       s/ *\(\"// ;
-       s/\"//;
-       $command = $_;
-       $_=$fields[1];
-       s/^ *\"//;
-       s/\"\)//;
-       chomp;
-       $description = $_;
-       print "\@item $command\n$description\n\n";
-    }
+    my ($command, $description)
+      = /^\s*UNIMPL_CMD\s*\(\s*"([^"]*)"\s*,\s*"([^"]*)"\)\s*$/
+       or next;
+    print "\@item $command\n$description\n\n";
 }
 print "\@end table\n";
 
 print "\@c Local Variables:\n";
 print "\@c buffer-read-only: t\n";
+print "\@c End:\n";
 close(INFO);                   # Close the file