Factor: fix memory leaks relating to PROMAX and update NEWS

diff --git a/NEWS b/NEWS
index fc676cc4b0e14b068f6114f447c70503511f5cbc..5ffa65200efeabe0fa51a2a5bd93ee56d44b2c1b 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,8 @@ Please send PSPP bug reports to bug-gnu-pspp@gnu.org.
  
 Changes since 0.8.4:
 
+ * The FACTOR command can now perform PROMAX rotations.
+
  * SPSS/PC+ system files are now supported on GET and other commands
    that read SPSS system files.  The pspp-convert program can now read
    SPSS/PC+ system files.  Writing the obsolete SPSS/PC+ system file

diff --git a/src/language/stats/factor.c b/src/language/stats/factor.c
index 5d1b242d814ab285c4706a117e805155754b148d..208307d0f11e781b1a5dceaf4fdd7a1c88e8df8a 100644 (file)
--- a/src/language/stats/factor.c
+++ b/src/language/stats/factor.c
@@ -904,6 +904,23 @@ rotate (const struct cmd_factor *cf, const gsl_matrix *unrot,
                              pm1);
 
       gsl_matrix_memcpy (result, pm1);
+
+
+      gsl_matrix_free (QQinv);
+      gsl_matrix_free (C);
+      gsl_matrix_free (Cinv);
+
+      gsl_matrix_free (D);
+      gsl_matrix_free (Q);
+      gsl_matrix_free (L);
+      gsl_matrix_free (P);
+
+      gsl_permutation_free (perm);
+
+      gsl_matrix_free (mm1);
+      gsl_matrix_free (mm2);
+      gsl_matrix_free (mp1);
+      gsl_matrix_free (pm1);
     }