From e17bbcc7e6eef7fc509e9b4a874141c9c18140f8 Mon Sep 17 00:00:00 2001 From: John Darrington Date: Mon, 29 Dec 2014 09:31:48 +0100 Subject: [PATCH] Factor: fix memory leaks relating to PROMAX and update NEWS --- NEWS | 2 ++ src/language/stats/factor.c | 17 +++++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/NEWS b/NEWS index fc676cc4b0..5ffa65200e 100644 --- a/NEWS +++ b/NEWS @@ -6,6 +6,8 @@ Please send PSPP bug reports to bug-gnu-pspp@gnu.org. Changes since 0.8.4: + * The FACTOR command can now perform PROMAX rotations. + * SPSS/PC+ system files are now supported on GET and other commands that read SPSS system files. The pspp-convert program can now read SPSS/PC+ system files. Writing the obsolete SPSS/PC+ system file diff --git a/src/language/stats/factor.c b/src/language/stats/factor.c index 5d1b242d81..208307d0f1 100644 --- a/src/language/stats/factor.c +++ b/src/language/stats/factor.c @@ -904,6 +904,23 @@ rotate (const struct cmd_factor *cf, const gsl_matrix *unrot, pm1); gsl_matrix_memcpy (result, pm1); + + + gsl_matrix_free (QQinv); + gsl_matrix_free (C); + gsl_matrix_free (Cinv); + + gsl_matrix_free (D); + gsl_matrix_free (Q); + gsl_matrix_free (L); + gsl_matrix_free (P); + + gsl_permutation_free (perm); + + gsl_matrix_free (mm1); + gsl_matrix_free (mm2); + gsl_matrix_free (mp1); + gsl_matrix_free (pm1); } -- 2.30.2