Fixed bug #22306

diff --git a/src/language/stats/ChangeLog b/src/language/stats/ChangeLog
index 50478b4e197eb20a9e1db251e4b6bacacbb15bb0..ae4110d1beb9fa2bb7665dd4536988e2f87a1274 100644 (file)
--- a/src/language/stats/ChangeLog
+++ b/src/language/stats/ChangeLog
@@ -1,3 +1,8 @@
+2008-02-14  John Darrington <john@darrington.wattle.id.au>
+
+       * examine.q: Fixed counts of missing variables.  Thanks to 
+       Jason Stover for reporting this problem.
+
 2008-01-02  John Darrington <john@darrington.wattle.id.au>
 
        *  binomial.c chisquare.c examine.q frequencies.q oneway.q regression.q : updated

diff --git a/src/language/stats/examine.q b/src/language/stats/examine.q
index fe762d3306afc8225af12f6d3b034033038cbfdb..4fccd83b6191fc596a283c927551a492f8106580 100644 (file)
--- a/src/language/stats/examine.q
+++ b/src/language/stats/examine.q
@@ -156,7 +156,7 @@ static void output_examine (void);
 
 
 void factor_calc (const struct ccase *c, int case_no,
-                 double weight, int case_missing);
+                 double weight, bool case_missing);
 
 
 /* Represent a factor as a string, so it can be
@@ -639,7 +639,7 @@ void populate_summary (struct tab_table *t, int col, int row,
 /* Perform calculations for the sub factors */
 void
 factor_calc (const struct ccase *c, int case_no, double weight,
-            int case_missing)
+            bool case_missing)
 {
   size_t v;
   struct factor *fctr = factors;
@@ -700,7 +700,7 @@ factor_calc (const struct ccase *c, int case_no, double weight,
          if (case_missing || var_is_value_missing (var, val, exclude_values))
            {
              free (val);
-             continue;
+             val = NULL;
            }
 
          metrics_calc ( & (*foo)->m[v], val, weight, case_no);
@@ -754,7 +754,7 @@ run_examine (struct cmd_examine *cmd, struct casereader *input,
 
   for (; casereader_read (input, &c); case_destroy (&c))
     {
-      int case_missing = 0;
+      bool case_missing = false;
       const double weight = dict_get_case_weight (dict, &c, NULL);
 
       if ( cmd->miss == XMN_LISTWISE )
@@ -768,7 +768,7 @@ run_examine (struct cmd_examine *cmd, struct casereader *input,
                                                  );
 
              if ( var_is_value_missing (var, val, exclude_values))
-               case_missing = 1;
+               case_missing = true;
 
              free (val);
            }
@@ -786,7 +786,7 @@ run_examine (struct cmd_examine *cmd, struct casereader *input,
                || case_missing )
            {
              free (val) ;
-             continue ;
+             val = NULL;
            }
 
          metrics_calc (&totals[v], val, weight, case_no);
@@ -975,7 +975,6 @@ show_summary (const struct variable **dependent_var, int n_dep_var,
 
   tab_title (tbl, _ ("Case Processing Summary"));
 
-
   tab_joint_text (tbl, heading_columns, 0,
                 n_cols -1, 0,
                 TAB_CENTER | TAT_TITLE,
@@ -990,22 +989,21 @@ show_summary (const struct variable **dependent_var, int n_dep_var,
 
   for ( i = 0 ; i < 3 ; ++i )
     {
-      tab_text (tbl, heading_columns + i*2 , 2, TAB_CENTER | TAT_TITLE,
+      tab_text (tbl, heading_columns + i * 2 , 2, TAB_CENTER | TAT_TITLE,
                _ ("N"));
 
-      tab_text (tbl, heading_columns + i*2 + 1, 2, TAB_CENTER | TAT_TITLE,
+      tab_text (tbl, heading_columns + i * 2 + 1, 2, TAB_CENTER | TAT_TITLE,
                _ ("Percent"));
 
       tab_joint_text (tbl, heading_columns + i*2 , 1,
-                    heading_columns + i*2 + 1, 1,
+                    heading_columns + i * 2 + 1, 1,
                     TAB_CENTER | TAT_TITLE,
                     subtitle[i]);
 
       tab_box (tbl, -1, -1,
               TAL_0, TAL_0,
-              heading_columns + i*2, 1,
-              heading_columns + i*2 + 1, 1);
-
+              heading_columns + i * 2, 1,
+              heading_columns + i * 2 + 1, 1);
     }
 
 
@@ -1020,7 +1018,6 @@ show_summary (const struct variable **dependent_var, int n_dep_var,
          tab_text (tbl, 2, heading_rows - 1, TAB_CENTER | TAT_TITLE,
                    var_to_string (fctr->indep_var[1]));
        }
-
     }
 
 
@@ -1030,7 +1027,6 @@ show_summary (const struct variable **dependent_var, int n_dep_var,
       if ( fctr )
        n_factors = hsh_count (fctr->fstats);
 
-
       if ( i > 0 )
        tab_hline (tbl, TAL_1, 0, n_cols -1 , i * n_factors + heading_rows);
 
@@ -1040,13 +1036,10 @@ show_summary (const struct variable **dependent_var, int n_dep_var,
                var_to_string (dependent_var[i])
                );
 
-
       if ( !fctr )
        populate_summary (tbl, heading_columns,
                         (i * n_factors) + heading_rows,
                         &totals[i]);
-
-
       else
        {
          struct factor_statistics **fs = fctr->fs;
@@ -1077,7 +1070,6 @@ show_summary (const struct variable **dependent_var, int n_dep_var,
                  if (fctr->indep_var[1] && count > 0 )
                    tab_hline (tbl, TAL_1, 1, n_cols - 1,
                              (i * n_factors ) + count + heading_rows);
-
                }
 
              prev = (*fs)->id[0];
@@ -1088,20 +1080,20 @@ show_summary (const struct variable **dependent_var, int n_dep_var,
                  ds_init_empty (&vstr);
                  var_append_value_name (fctr->indep_var[1],
                                         (*fs)->id[1], &vstr);
-               tab_text (tbl,
-                         2,
-                         (i * n_factors ) + count +
-                         heading_rows,
-                         TAB_LEFT | TAT_TITLE,
+                 tab_text (tbl,
+                           2,
+                           (i * n_factors ) + count +
+                           heading_rows,
+                           TAB_LEFT | TAT_TITLE,
                            ds_cstr (&vstr)
-                         );
+                           );
                  ds_destroy (&vstr);
-           }
+               }
 
              populate_summary (tbl, heading_columns,
-                              (i * n_factors) + count
-                              + heading_rows,
-                              & (*fs)->m[i]);
+                               (i * n_factors) + count
+                               + heading_rows,
+                               & (*fs)->m[i]);
 
              count++ ;
              fs++;
@@ -1135,11 +1127,7 @@ populate_summary (struct tab_table *t, int col, int row,
     /* This seems a bit pointless !!! */
     tab_text (t, col + 5, row + 0, TAB_RIGHT | TAT_PRINTF, "%2.0f%%",
              100.0 * total / total );
-
-
   }
-
-
 }
 
 

diff --git a/src/math/factor-stats.c b/src/math/factor-stats.c
index 582b83468ca77f2516dc42b248e2dd6a8359fd44..a97d7f09349b7fabe25c49383357f87103205ac7 100644 (file)
--- a/src/math/factor-stats.c
+++ b/src/math/factor-stats.c
@@ -73,11 +73,9 @@ metrics_calc (struct metrics *fs, const union value *val,
 
   moments1_add(fs->moments, x, weight);
 
-
   if ( x < fs->min) fs->min = x;
   if ( x > fs->max) fs->max = x;
 
-
   wv = (struct weighted_value **) hsh_probe (fs->ordered_data,(void *) val );
 
   if ( *wv  )

diff --git a/tests/automake.mk b/tests/automake.mk
index e00fa21dac1a275f7c598b11980f3953800db8f8..8c1bfcfc723100c4e44f88810ab3e42854a675ca 100644 (file)
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -105,6 +105,7 @@ dist_TESTS = \
        tests/bugs/get.sh \
        tests/bugs/examine-1sample.sh \
        tests/bugs/examine-missing.sh \
+       tests/bugs/examine-missing2.sh \
        tests/bugs/freq-nolabels.sh \
        tests/bugs/get-no-file.sh \
        tests/bugs/html-frequency.sh \

diff --git a/tests/bugs/examine-missing2.sh b/tests/bugs/examine-missing2.sh
new file mode 100755 (executable)
index 0000000..ff07349
--- /dev/null
+++ b/tests/bugs/examine-missing2.sh
@@ -0,0 +1,117 @@
+#!/bin/sh
+
+# This program tests for a bug in which examine didn't
+# count missing values.
+
+TEMPDIR=/tmp/pspp-tst-$$
+TESTFILE=$TEMPDIR/`basename $0`.sps
+
+# ensure that top_srcdir and top_builddir  are absolute
+if [ -z "$top_srcdir" ] ; then top_srcdir=. ; fi
+if [ -z "$top_builddir" ] ; then top_builddir=. ; fi
+top_srcdir=`cd $top_srcdir; pwd`
+top_builddir=`cd $top_builddir; pwd`
+
+PSPP=$top_builddir/src/ui/terminal/pspp
+
+STAT_CONFIG_PATH=$top_srcdir/config
+export STAT_CONFIG_PATH
+
+LANG=C
+export LANG
+
+
+cleanup()
+{
+     if [ x"$PSPP_TEST_NO_CLEANUP" != x ] ; then 
+       echo "NOT cleaning $TEMPDIR"
+       return ; 
+     fi
+     rm -rf $TEMPDIR
+}
+
+
+fail()
+{
+    echo $activity
+    echo FAILED
+    cleanup;
+    exit 1;
+}
+
+
+no_result()
+{
+    echo $activity
+    echo NO RESULT;
+    cleanup;
+    exit 2;
+}
+
+pass()
+{
+    cleanup;
+    exit 0;
+}
+
+mkdir -p $TEMPDIR
+
+cd $TEMPDIR
+
+activity="create program"
+cat > $TESTFILE << EOF
+DATA LIST LIST /x * y *.
+BEGIN DATA.
+1   1 
+2   1
+3   1
+4   1
+5   2
+6   2
+.   2
+END DATA
+
+EXAMINE /x by y.
+EOF
+if [ $? -ne 0 ] ; then no_result ; fi
+
+
+activity="run program"
+$SUPERVISOR $PSPP --testing-mode -o raw-ascii $TESTFILE
+if [ $? -ne 0 ] ; then no_result ; fi
+
+activity="compare results"
+perl -pi -e 's/^\s*$//g' $TEMPDIR/pspp.list
+diff -b  $TEMPDIR/pspp.list - <<EOF
+1.1 DATA LIST.  Reading free-form data from INLINE.
++--------+------+
+|Variable|Format|
+#========#======#
+|x       |F8.0  |
+|y       |F8.0  |
++--------+------+
+2.1 EXAMINE.  Case Processing Summary
+#=#=============================#
+# #            Cases            #
+# #---------+---------+---------#
+# #  Valid  | Missing |  Total  #
+# #-+-------+-+-------+-+-------#
+# #N|Percent|N|Percent|N|Percent#
+#=#=#=======#=#=======#=#=======#
+#x#6|    86%|1|    14%|7|   100%#
+#=#=#=======#=#=======#=#=======#
+2.2 EXAMINE.  Case Processing Summary
+#==========#=============================#
+#          #            Cases            #
+#          #---------+---------+---------#
+#          #  Valid  | Missing |  Total  #
+#          #-+-------+-+-------+-+-------#
+#      y   #N|Percent|N|Percent|N|Percent#
+#==========#=#=======#=#=======#=#=======#
+#x     1.00#4|   100%|0|     0%|4|   100%#
+#      2.00#2|    67%|1|    33%|3|   100%#
+#==========#=#=======#=#=======#=#=======#
+EOF
+if [ $? -ne 0 ] ; then fail ; fi
+
+pass;