T-TEST: Also fix the case where the correlation is slightly less than -1.0.

Thanks to John Darrington for pointing out the omission.

diff --git a/src/language/stats/t-test.q b/src/language/stats/t-test.q
index dd40de991bf3e78df07523af2e6564b06ee9f162..ba7e9388a95274560589d30605ce2be3e0720718 100644 (file)
--- a/src/language/stats/t-test.q
+++ b/src/language/stats/t-test.q
@@ -1432,16 +1432,13 @@ pscbox (const struct dictionary *dict)
 
       double df = pairs[i].n -2;
 
-      /* pairs[i].correlation is a correlation, so mathematically it will
-         always be in the range [-1.0, 1.0].  Inaccurate calculations sometimes
-         cause it to be slightly greater than 1.0, however, which makes the
-         sqrt() below to come out as NaN instead of 0.  So force it to be 1.0
-         or less. */
-      double corr = MIN (1.0, pairs[i].correlation);
-
+      /* corr2 will mathematically always be in the range [0, 1.0].  Inaccurate
+         calculations sometimes cause it to be slightly greater than 1.0, so
+         force it into the correct range to avoid NaN from sqrt(). */
+      double corr2 = MIN (1.0, pow2 (pairs[i].correlation));
       double correlation_t =
        pairs[i].correlation * sqrt (df) /
-       sqrt (1 - pow2 (corr));
+       sqrt (1 - corr2);
 
 
       /* row headings */