ascii: Don't print command names in output.
authorBen Pfaff <blp@cs.stanford.edu>
Sat, 23 Apr 2011 05:10:04 +0000 (22:10 -0700)
committerBen Pfaff <blp@cs.stanford.edu>
Sat, 23 Apr 2011 05:16:36 +0000 (22:16 -0700)
This seems to be closer to what users expect.

I think that having the command names in output was being confused
by users with SET PRINTBACK=ON (see e.g. bug #31561) even though I
really just added that so that there are clear titles for the output
that goes with each procedure.  This change should help, I think.

It might make sense to make drivers only print the titles of
procedures that have other output, but this commit doesn't do that.

src/output/ascii.c
tests/language/stats/frequencies.at
tests/output/render.at

index 93e79e2e492499b2e4cc48e11c2e781399c58d04..1c3e6b8238f8f7f0739310ae64bfea6b5778c3bb 100644 (file)
@@ -543,6 +543,7 @@ ascii_submit (struct output_driver *driver,
           a->subtitle = xstrdup (text);
           break;
 
+        case TEXT_ITEM_COMMAND_OPEN:
         case TEXT_ITEM_COMMAND_CLOSE:
           break;
 
index 86cfd6e590ecebe9d2485e768f9c10bc12356057..9eae09e8364e974c447f4be8505abd9190323788 100644 (file)
@@ -130,9 +130,7 @@ frequencies /x /format=notable /statistics=none
 ])
 # Cannot use the CSV driver for this because it does not output charts
 # at all.
-AT_CHECK([pspp frequencies.sps], [0],
-  [DATA LIST
-
+AT_CHECK([pspp frequencies.sps], [0], [dnl
 Reading free-form data from INLINE.
 +--------+------+
 |Variable|Format|
@@ -140,12 +138,6 @@ Reading free-form data from INLINE.
 |x       |F8.0  |
 |w       |F8.0  |
 +--------+------+
-
-BEGIN DATA
-
-WEIGHT
-
-FREQUENCIES
 ])
 AT_CLEANUP
 
index 471aefcf0024c3bf280c51754121a811e2980744..9821348adb62610ed5c77b22f4d20ff50ca04e48 100644 (file)
@@ -1796,12 +1796,6 @@ END DATA.
 LIST.
 ])
 AT_CHECK([pspp list.sps], [0], [dnl
-DATA LIST
-
-BEGIN DATA
-
-LIST
-
 Data List
 x y z
 -----