projects
/
pspp-builds.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
5d276e7
)
Fix memory leak in data_in
author
John Darrington
<john@darrington.wattle.id.au>
Sun, 18 Jul 2010 17:19:53 +0000
(19:19 +0200)
committer
John Darrington
<john@darrington.wattle.id.au>
Sun, 18 Jul 2010 17:19:53 +0000
(19:19 +0200)
src/data/data-in.c
patch
|
blob
|
history
diff --git
a/src/data/data-in.c
b/src/data/data-in.c
index 63e644c186bf565168a7f6e199c4bc707f7ae7cf..c105454ae6654ffda20a4e5bbe4ae5a3eadfa28a 100644
(file)
--- a/
src/data/data-in.c
+++ b/
src/data/data-in.c
@@
-119,6
+119,7
@@
data_in (struct substring input, const char *encoding,
struct data_in i;
struct data_in i;
+ char *s = NULL;
bool ok;
assert ((width != 0) == fmt_is_string (format));
bool ok;
assert ((width != 0) == fmt_is_string (format));
@@
-146,7
+147,7
@@
data_in (struct substring input, const char *encoding,
else
{
const char *dest_encoding;
else
{
const char *dest_encoding;
- char *s = NULL;
+
if ( dict == NULL)
{
assert (0 == (fmt_get_category (format) & (FMT_CAT_BINARY | FMT_CAT_STRING)));
if ( dict == NULL)
{
assert (0 == (fmt_get_category (format) & (FMT_CAT_BINARY | FMT_CAT_STRING)));
@@
-156,15
+157,14
@@
data_in (struct substring input, const char *encoding,
dest_encoding = dict_get_encoding (dict);
s = recode_string (dest_encoding, i.src_enc, ss_data (input), ss_length (input));
dest_encoding = dict_get_encoding (dict);
s = recode_string (dest_encoding, i.src_enc, ss_data (input), ss_length (input));
- ss_alloc_uninit (&i.input, strlen (s));
- memcpy (ss_data (i.input), s, ss_length (input));
- free (s);
+ i.input = ss_cstr (s);
}
ok = handlers[i.format] (&i);
if (!ok)
default_result (&i);
}
ok = handlers[i.format] (&i);
if (!ok)
default_result (&i);
+ free (s);
return ok;
}
return ok;
}