Fix brown-bag error.

[pintos-anon] / src / lib / random.c

diff --git a/src/lib/random.c b/src/lib/random.c
index d4ffa6df216d0b43c56101ea85839020512e4d61..63d798d6bf6394dcb017f096c5980cf4722c4fb9 100644 (file)
--- a/src/lib/random.c
+++ b/src/lib/random.c
@@ -1,12 +1,26 @@
 #include "random.h"
 #include <stdbool.h>
 #include <stdint.h>
+#include "debug.h"
 
-/* RC4-based pseudo-random state. */
-static uint8_t s[256];
-static uint8_t s_i, s_j;
-static bool inited;
+/* RC4-based pseudo-random number generator (PRNG).
 
+   RC4 is a stream cipher.  We're not using it here for its
+   cryptographic properties, but because it is easy to implement
+   and its output is plenty random for non-cryptographic
+   purposes.
+
+   See http://en.wikipedia.org/wiki/RC4_(cipher) for information
+   on RC4.*/
+
+/* RC4 state. */
+static uint8_t s[256];          /* S[]. */
+static uint8_t s_i, s_j;        /* i, j. */
+
+/* Already initialized? */
+static bool inited;     
+
+/* Swaps the bytes pointed to by A and B. */
 static inline void
 swap_byte (uint8_t *a, uint8_t *b) 
 {
@@ -15,6 +29,8 @@ swap_byte (uint8_t *a, uint8_t *b)
   *b = t;
 }
 
+/* Initializes the PRNG with the given SEED.
+   Does nothing if the PRNG has already been initialized. */
 void
 random_init (unsigned seed)
 {
@@ -37,11 +53,13 @@ random_init (unsigned seed)
   inited = true;
 }
 
+/* Writes SIZE random bytes into BUF. */
 void
 random_bytes (void *buf_, size_t size) 
 {
   uint8_t *buf;
 
+  ASSERT (inited);
   for (buf = buf_; size-- > 0; buf++)
     {
       uint8_t s_k;