Applied patch set 6 by Ben, derived from Anthony's megapatch, and minor

[pintos-anon] / src / devices / timer.c

diff --git a/src/devices/timer.c b/src/devices/timer.c
index c8c41d55cf412948eb71a04b52c748f0c554465d..a83a588d6884dc271bca00909148c0348a0b986a 100644 (file)
--- a/src/devices/timer.c
+++ b/src/devices/timer.c
@@ -3,8 +3,9 @@
 #include <inttypes.h>
 #include <round.h>
 #include <stdio.h>
+#include "devices/pit.h"
 #include "threads/interrupt.h"
-#include "threads/io.h"
+#include "threads/synch.h"
 #include "threads/thread.h"
   
 /* See [8254] for hardware details of the 8254 timer chip. */
@@ -17,7 +18,7 @@
 #endif
 
 /* Number of timer ticks since OS booted. */
-static volatile int64_t ticks;
+static int64_t ticks;
 
 /* Number of loops per timer tick.
    Initialized by timer_calibrate(). */
@@ -28,20 +29,12 @@ static bool too_many_loops (unsigned loops);
 static void busy_wait (int64_t loops);
 static void real_time_sleep (int64_t num, int32_t denom);
 
-/* Sets up the 8254 Programmable Interval Timer (PIT) to
-   interrupt PIT_FREQ times per second, and registers the
-   corresponding interrupt. */
+/* Sets up the timer to interrupt TIMER_FREQ times per second,
+   and registers the corresponding interrupt. */
 void
 timer_init (void) 
 {
-  /* 8254 input frequency divided by TIMER_FREQ, rounded to
-     nearest. */
-  uint16_t count = (1193180 + TIMER_FREQ / 2) / TIMER_FREQ;
-
-  outb (0x43, 0x34);    /* CW: counter 0, LSB then MSB, mode 2, binary. */
-  outb (0x40, count & 0xff);
-  outb (0x40, count >> 8);
-
+  pit_configure_channel (0, 2, TIMER_FREQ);
   intr_register_ext (0x20, timer_interrupt, "8254 Timer");
 }
 
@@ -57,8 +50,11 @@ timer_calibrate (void)
   /* Approximate loops_per_tick as the largest power-of-two
      still less than one timer tick. */
   loops_per_tick = 1u << 10;
-  while (!too_many_loops (loops_per_tick << 1))
-    loops_per_tick <<= 1;
+  while (!too_many_loops (loops_per_tick << 1)) 
+    {
+      loops_per_tick <<= 1;
+      ASSERT (loops_per_tick != 0);
+    }
 
   /* Refine the next 8 bits of loops_per_tick. */
   high_bit = loops_per_tick;
@@ -76,6 +72,7 @@ timer_ticks (void)
   enum intr_level old_level = intr_disable ();
   int64_t t = ticks;
   intr_set_level (old_level);
+  barrier ();
   return t;
 }
 
@@ -139,18 +136,17 @@ timer_interrupt (struct intr_frame *args UNUSED)
 static bool
 too_many_loops (unsigned loops) 
 {
-  int64_t start;
-
   /* Wait for a timer tick. */
-  start = ticks;
+  int64_t start = ticks;
   while (ticks == start)
-    continue;
+    barrier ();
 
   /* Run LOOPS loops. */
   start = ticks;
   busy_wait (loops);
 
   /* If the tick count changed, we iterated too long. */
+  barrier ();
   return start != ticks;
 }
 
@@ -165,7 +161,7 @@ static void NO_INLINE
 busy_wait (int64_t loops) 
 {
   while (loops-- > 0)
-    continue;
+    barrier ();
 }
 
 /* Sleep for approximately NUM/DENOM seconds. */