Improve.

[pintos-anon] / grading / threads / run-tests

diff --git a/grading/threads/run-tests b/grading/threads/run-tests
index db788dcb6b77c639779bf0789578533dca3f4d5a..75d4a704b8a05a55d8730288123949302c4f5c15 100755 (executable)
--- a/grading/threads/run-tests
+++ b/grading/threads/run-tests
@@ -40,8 +40,7 @@ sub usage {
          "join-dummy", "join-invalid", "join-no",
          "priority-preempt", "priority-fifo", "priority-donate-one",
          "priority-donate-multiple", "priority-donate-nest",
-         #"mlfqs-on", "mlfqs-off"
-         )
+         "mlfqs-on", "mlfqs-off")
     unless @TESTS > 0;
 
 # Find the directory that contains the grading files.
@@ -423,7 +422,6 @@ sub verify_common {
            $details .= "Translation of backtrace:\n";
            my (@addrs) = $stack_line[0] =~ /Call stack:((?: 0x[0-9a-f]+)+)/;
 
-           print "addrs: '@addrs'\n";
            my ($A2L);
            if (`uname -m`
                =~ /i.86|pentium.*|[pk][56]|nexgen|viac3|6x86|athlon.*/) {
@@ -432,8 +430,10 @@ sub verify_common {
                $A2L = "i386-elf-addr2line";
            }
            open (A2L, "$A2L -fe output/$test/kernel.o @addrs|");
-           while (my $function = <A2L>) {
-               my ($line) = <A2L>;
+           for (;;) {
+               my ($function, $line);
+               last unless defined ($function = <A2L>);
+               $line = <A2L>;
                chomp $function;
                chomp $line;
                $details .= "  $function ($line)\n";