1 2007-07-25 Ben Pfaff <blp@gnu.org>
4 * data-list.c (read_from_data_list_fixed): Handle multi-record
7 2007-07-11 Ben Pfaff <blp@gnu.org>
9 * get.c (map_case): Create destination case instead of leaving it
10 undefined. Fixes bug #20285.
11 Reviewed by John Darrington.
13 2007-06-06 Ben Pfaff <blp@gnu.org>
15 * get.c: Essentially rewrite MATCH FILES to support FIRST and
18 2007-06-06 Ben Pfaff <blp@gnu.org>
20 Adapt case sources, sinks, and clients of procedure code to the
23 * data-list.c: Make DATA LIST into a casereader.
25 * get.c: Change GET, IMPORT, SAVE, EXPORT to use casereaders,
28 * inpt-pgm.c: Use caseinit code. Turn INPUT PROGRAM into a
31 * list.q: Adapt to new procedure code.
33 2007-05-06 Ben Pfaff <blp@gnu.org>
35 Abstract the documents within a dictionary a little better.
36 Thanks to John Darrington for suggestion, initial version, and
39 * get.c (mtf_merge_dictionary): Simplify creating merged document.
41 * sys-file-info.c (display_documents): Use new
42 dict_get_document_line_cnt and dict_get_document_line functions.
44 Thu Feb 1 16:56:02 2007 Ben Pfaff <blp@gnu.org>
46 * file-handle.q (fh_parse): Update to new fh_create_file
49 Sat Dec 16 22:16:18 2006 Ben Pfaff <blp@gnu.org>
51 Make it possible to pull cases from the active file with a
52 function call, instead of requiring indirection through a callback
55 * automake.mk: Removed matrix-data.c.
57 * matrix-data.c: Removed.
59 * data-list.c (data_list_source_read): Conform with new
60 case_source_class interface.
61 (data_list_source_destroy): Ditto.
63 * get.c (case_reader_source_class): Ditto.
64 (case_reader_source_destroy): Ditto.
65 (parse_output_proc): Take advantage of new procedure interface.
66 (output_proc): Removed.
67 (struct mtf_file): Add "struct ccase *" member to allow use of new
69 (cmd_match_files): Take advantage of new procedure interface.
70 (mtf_processing_finish): Removed.
71 (mtf_read_nonactive_records): Renamed mtf_read_records. Now reads
72 from every file, without any exception for the active file.
73 (mtf_compare_BY_values): Simplify for new interface.
74 (mtf_processing): Simplify for new interface.
76 * inpt-pgm.c (is_valid_state): New function.
77 (input_program_source_read): Conform with new case_source_class
79 (input_program_source_destroy): Ditto.
80 (end_case_trns_proc): Now just needs to return TRNS_END_CASE.
82 Sat Dec 9 18:43:34 2006 Ben Pfaff <blp@gnu.org>
84 * list.q (cmd_list): Use new var_create, var_destroy functions.
86 Thu Nov 30 21:51:58 2006 Ben Pfaff <blp@gnu.org>
88 * inpt-pgm.c (cmd_reread): Always return error code upon detecting
89 syntax error. Fixes bug #18419. Thanks to John Darrington for
92 Sun Nov 19 09:17:45 2006 Ben Pfaff <blp@gnu.org>
94 * data-list.c (parse_free): Follow documented (but odd) rule that
95 N format is treated as F format for free-field input.
97 * data-reader.c (read_file_record): Drop new-line character from
98 input text lines. This is symmetrical with the recently changed
99 dfm_put_record semantics.
101 Thu Nov 2 20:56:03 2006 Ben Pfaff <blp@gnu.org>
103 Implement SKIP keyword on DATA LIST. Fixes bug #17099.
105 * data-list.c: (struct data_list_pgm) Add `skip_records' members.
106 (cmd_data_list) Set skip_records based on user input.
107 (data_list_source_read) Skip records requested by user.
109 Tue Oct 31 20:04:06 2006 Ben Pfaff <blp@gnu.org>
111 * placement-parser.c: (PRS_TYPE_T) Now that struct fmt_spec uses
112 an enum fmt_type for its type member, we can't depend on the
113 ability to put negative values into that member as out-of-band
114 values, because enum fmt_type might be an unsigned type. So use
115 values around SCHAR_MAX instead, because we know that SCHAR_MAX
116 will fit into any type, signed or unsigned, and there aren't
117 nearly that many format types.
118 (parse_var_placements) Add for_input parameter to specify whether
119 we're parsing input or output formats. Update all callers.
120 (fixed_parse_columns) Ditto.
121 (fixed_parse_fortran) Ditto.
123 Tue Oct 31 18:21:48 2006 Ben Pfaff <blp@gnu.org>
125 * print-space.c (print_space_trns_proc): Let dfm_put_record add
126 the new-line character, to match dfm_put_record change below.
128 Sat Oct 28 11:57:19 2006 Ben Pfaff <blp@gnu.org>
130 * data-writer.c (struct dfm_writer): Removed `bounce' member, and
131 all references to it.
132 (dfm_put_record) Change semantics so that it adds formatting
133 itself, such as new-line characters, instead of putting that
134 responsibility on the caller. Also, pad binary records with
135 spaces instead of zeros, for compatibility.
137 * print.c (struct prt_out_spec) New member `sysmis_as_spaces'.
138 (struct print_trns) Remove `omit_new_lines' and all references,
139 since dfm_put_record() is taking care of that. Add
141 (internal_cmd_print) Allow an empty set of data to print. Set
143 (parse_specs) Allow an empty set of data to print.
144 (parse_variable_argument) Only add space with PRINT command. Set
146 (print_trns_proc) Indent records if include_prefix is set, for
147 compatibility. Output SYSMIS as spaces if sysmis_as_spaces is
148 set. Put "1" in first column if PRINT EJECT is used with an
149 external output file.
150 (flush_records) Ditto.
152 Sat Oct 28 16:19:57 WST 2006 John Darrington <john@darrington.wattle.id.au>
154 * data-reader.c: Eliminated references to extern variable getl_buf
156 Sat Aug 5 08:25:07 2006 Ben Pfaff <blp@gnu.org>
158 Fix bug #17329 in REREAD parsing, reported by John Darrington.
160 * inpt-pgm.c (cmd_reread): Fix file handle parsing.
162 Mon Jul 31 10:32:31 2006 Ben Pfaff <blp@gnu.org>
164 * print.c (parse_specs): Allow a comma between specifications.
166 Sun Jul 16 19:57:10 2006 Ben Pfaff <blp@gnu.org>
168 * automake.mk: (src_language_data_io_libdata_io_a_SOURCE) Add
169 print-space.c, placement-parser.c, placement-parser.h.
171 * data-list.c: Basically rewrote the whole thing. Broke out a lot
172 of code into placement-parser.c. Code is much cleaner now.
174 * placement-parser.c: New file.
176 * placement-parser.h: New file.
178 * print.c: Basically rewrote the whole thing. Broke out PRINT
179 SPACE into print-space.c. Code is much cleaner now.
181 * print-space.c: New file.
183 Sat Jul 1 17:39:40 2006 Ben Pfaff <blp@gnu.org>
185 Fix bug #11612, "q2c documentation does not agree with code".
187 * list.q: Audit use of q2c "+" prefixes that indicate that a
188 command may appear multiple times.
190 Sat Jul 1 20:44:22 2006 Ben Pfaff <blp@gnu.org>
192 Fix bug #15786: System File Creation crashes if directoy is
195 * get.c (parse_write_command): Check that the any_writer open
198 Tue Jun 27 22:44:28 2006 Ben Pfaff <blp@gnu.org>
200 Fix regression in command name completion reported by John
201 Darrington. Now completion is again state-dependent and occurs
202 only on the first line of a command.
204 * inpt-pgm.c: (cmd_input_program) Reading of first token in
205 command moved into cmd_parse.
207 Fri Jun 9 13:56:00 2006 Ben Pfaff <blp@gnu.org>
209 Reform string library.
211 * matrix-data.c (context): Use dynamic string.
212 (another_token) Deal with changed dfm_get_record() interface.
216 * data-list.c (struct data_list_pgm) Delete delims, delim_cnt
217 members, replacing them by struct string delims. Update all
218 references to use struct string functions.
219 (cut_field) Change interface to avoid needing "end_blank", by
220 getting the data-reader to remember that state for us. Change
221 internals to use substring. Update both callers.
223 * data-reader.c (read_file_record): Use ds_read_stream().
224 (dfm_get_record) Change interface to return substring. Updated
226 (dfm_expand_tabs) Use ds_find_char(). Now maintain position
227 relative to end-of-line. Use ds_swap().
228 (dfm_reread_record) Don't limit position by line length.
229 (dfm_column_start) Make parameter const.
230 (dfm_columns_past_end) New function.
231 (dfm_get_column) New function.
233 Thu May 25 18:26:26 WST 2006 John Darrington <john@darrington.wattle.id.au>
235 * print.c (print_trns_free): Made the code agree with the comment, by
236 not freeing PRT. Has the side effect that the command no longer
237 crashes on invalid syntax.
239 Tue May 9 20:55:46 2006 Ben Pfaff <blp@gnu.org>
241 * get.c (cmd_match_files): Fix memory leak replacing default_dict.
243 Sat May 6 22:25:09 2006 Ben Pfaff <blp@gnu.org>
247 * list.q (write_fallback_headers): (write_fallback_headers)
248 Properly record width of leader and pass it to write_varname().
250 Sat May 6 19:03:13 2006 Ben Pfaff <blp@gnu.org>
252 * get.c: (mtf_merge_dictionary) Fix value label memory leak.
254 Sat May 6 13:51:16 2006 Ben Pfaff <blp@gnu.org>
256 Use a casefile, instead of a case sink, for MATCH FILES output.
257 It's more straightforward, although it has the same effect.
259 * get.c: (struct mtf_proc) Replace `sink' case sink member by
260 `output' casefile member.
261 (cmd_match_files) Work with casefile instead of sink.
262 (mtf_processing) Add case to casefile instead of sink.
264 Sat May 6 10:43:07 2006 Ben Pfaff <blp@gnu.org>
266 Continue reforming procedure execution. In this phase, get rid of
267 the output code for SPLIT FILE groups in procedure.c, which really
268 shouldn't be doing any output. Move it into the individual
269 procedures instead. This also adds some flexibility.
271 * list.q (write_all_headers): Call output_split_file_values().
273 Wed May 3 23:00:17 2006 Ben Pfaff <blp@gnu.org>
275 Continue reforming procedure execution. In this phase, get rid of
276 many global variables, consolidating procedure execution in
277 procedure.c. Encapsulate transformations in new "struct
278 trns_chain". Also, change implementation of N OF CASES, FILTER,
279 and PROCESS IF from special cases to transformations.
281 * data-list.c: (data_list_trns_proc) Return TRNS_END_FILE at end
282 of file. (Why didn't we do this before?)
283 (cmd_match_files) Direct procedure output to null sink.
284 Use discard_variables() instead of indirect version.
286 * inpt-pgm.c: Use transformation chain.
287 (struct input_program_pgm) Add trns_chain member.
288 (cmd_input_program) Initialize trns_chain member and capture
289 transformations with proc_capture_transformations().
290 (input_program_source_read) Use trns_chain_execute().
291 (destroy_input_program) Destroy input chain.
293 Tue May 2 10:39:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
295 * list.q Changed from using fixed length char buffers to struct
296 string so that any length variables can be used.
298 Mon May 1 18:21:19 2006 Ben Pfaff <blp@gnu.org>
300 Further clean up the CMD_* command result codes.
302 * (enum cmd_result_extensions) New. Add CMD_END_INPUT_PROGRAM and
303 CMD_END_CASE result codes.
304 (struct input_program_pgm) Added case_nr, write_case, wc_data
305 members for use by END CASE transformation.
306 (emit_END_CASE) New function.
307 (cmd_input_program) Interpret CMD_END_CASE by outputting an END
308 CASE transformation. If none is output by the input program
309 itself, add one automatically at the end. Change lack of
310 variables from warning to error.
311 (cmd_end_input_program) Return CMD_END_INPUT_PROGRAM instead of
313 (input_program_source_read) No longer any need to special-case END
314 CASE. Handle TRNS_DROP_CASE properly. Initialize new members in
315 inp for use by END CASE transformation.
316 (destroy_input_program) New function.
317 (input_program_source_destroy) Just call destroy_input_program().
318 (cmd_end_case) Just return CMD_END_CASE.
319 (end_case_trns_proc) No longer a stub handled by
320 input_program_source_read(). Actually output the case and
321 increment the case number.
323 Mon May 1 16:06:30 2006 Ben Pfaff <blp@gnu.org>
325 Remove vestiges of REPEATING DATA support.
327 * data-list.c: (struct rpd_num_or_var) Removed.
328 (struct repeating_data_trns) Removed.
329 (cmd_repeating_data) Removed.
330 (find_variable_input_spec) Removed.
331 (parse_num_or_var) Removed.
332 (parse_repeating_data) Removed.
333 (realize_value) Removed.
334 (struct rpd_parse_info) Removed.
335 (rpd_parse_record) Removed.
336 (repeating_data_trns_proc) Removed.
337 (repeating_data_trns_free) Removed.
338 (repeating_data_set_write_case) Removed.
341 * inpt-pgm.c: (input_program_source_read) Don't deal with
344 * data-list.h: Removed.
346 * automake.mk (src_language_data_io_libdata_io_a_SOURCES): Removed
349 Mon May 1 15:58:28 2006 Ben Pfaff <blp@gnu.org>
351 Remove vestiges of FILE TYPE support.
353 * data-list.c: (cmd_data_list) Don't check for FILE TYPE.
354 (cmd_repeating_data) Ditto.
356 * automake.mk (src_language_data_io_libdata_io_a_SOURCES): Remove
357 file-type.c, file-type.h.
359 * file-type.c: Removed.
361 * file-type.h: Removed.
363 Wed Apr 26 13:16:28 2006 Ben Pfaff <blp@gnu.org>
365 Improve the way we handle the various parsing "states". Until now
366 we've hard-coded the state transitions in the command definition
367 file, but that's error-prone and, worse, it's redundant--we can
368 figure out what state we're in anyhow. We can cleanly handle
369 INPUT PROGRAM and FILE TYPE with a nested command-processing loop.
371 * data-list.c: (cmd_data_list) Use in_file_type() or
372 in_input_program() in place of case_source_is_class() or
373 case_source_is_complex().
375 * file-type.c: NB: Not really fixed except minimally to compile,
376 because it doesn't work anyway.
377 (in_file_type) New function.
378 (cmd_record_type) No need to check that we're in FILE TYPE.
379 (cmd_end_file_type) Ditto.
380 (var file_type_source_class) Make static.
382 * get.c: (cmd_match_files) Check vfm_source instead of pgm_state.
384 * inpt-pgm.c: (in_input_program) New function.
385 (cmd_input_program) Rewrite to include nested command processing
387 (cmd_end_input_program) Just return CMD_END_SUBLOOP.
388 (var input_program_source_class) Make static.
389 (cmd_end_case) No need to check that we're in INPUT PROGRAM.
390 (cmd_end_file) Ditto.
392 * automake.mk (src_language_data_io_libdata_io_a_SOURCES): Add
393 file-type.h, inpt-pgm.h.
395 * file-type.h: New file.
397 * inpt-pgm.h: New file.
399 Tue Apr 25 13:11:55 2006 Ben Pfaff <blp@gnu.org>
401 * print.c: Don't special-case MS-DOS line terminators.
402 (macro LINE_END_WIDTH) Removed.
403 (alloc_line) Line ends are 1 byte.
404 (print_trns_proc) Just output \n for line end.
406 Sun Apr 23 22:05:58 2006 Ben Pfaff <blp@gnu.org>
408 Continue reforming error message support. In this phase, get rid
409 of message "titles" and put the message text in `struct error'.
410 Now `struct error' encapsulates a message more properly.
412 * data-list.c: (macro RPD_ERR) Removed.
413 (rpd_msg) New function. Updated all references to tmsg() to call
414 this function instead.
416 Sat Apr 15 19:38:13 2006 Ben Pfaff <blp@gnu.org>
418 Remove last users of struct file_ext so we can get rid of it
421 * data-reader.c: (struct dfm_reader) Change file member from
422 struct file_ext to FILE *. Updated all references.
423 (dfm_close_reader) Close file with fn_close() instead of
424 fn_close_ext(). Also, make a copy of the file name from the file
425 handle before closing it, because we can't extract it after we
427 (dfm_open_reader) Open file with fn_open() instead of
430 * data-writer.c: (struct dfm_writer) Change file member
431 struct file_ext to FILE *. Updated all references.
432 (dfm_close_writer) Close file with fn_close() instead of
433 fn_close_ext(). Also, make a copy of the file name from the file
434 handle before closing it, because we can't extract it after we
436 (dfm_open_writer) Open file with fn_open() instead of
439 Sat Apr 15 18:00:32 2006 Ben Pfaff <blp@gnu.org>
441 * data-list.c: Add prototype to suppress warning for
442 cmd_repeating_data().
444 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
446 * Moved files from src directory