1 2007-04-19 John Darrington <john@darrington.wattle.id.au>
3 * sys-file-reader.c: When reading a system file which has no
4 long name table, automatically create one where the long names
5 are the lower case versions of the short names.
7 2007-04-22 Ben Pfaff <blp@gnu.org>
9 * dictionary.c (dict_set_split_vars): dict_destroy expects that
10 dict_clear will free most data related to the dictionary.
11 dict_clear does a decent job, except that dict_set_split_vars on
12 some systems won't actually free the dict's "split" member.
13 Instead, it'll allocate a 1-byte region. Fix this.
15 * value.c (value_copy): New function.
16 (value_set_missing): Ditto.
18 2007-04-22 John Darrington <john@darrington.wattle.id.au>
20 * Deleted existing category.h and moved cat-routines.h into
21 category.h Encapsulated struct cat_vals better.
23 2007-04-19 John Darrington <john@darrington.wattle.id.au>
25 * sys-file-reader.c: When reading a system file which has no
26 long name table, automatically create one where the long names
27 are the lower case versions of the short names.
29 2007-04-16 John Darrington <john@darrington.wattle.id.au>
31 * sys-file-reader.c: Some versions of Other Software seem to
32 produce system files with string variables' measure set to
33 zero. We'll assume these are supposed to be nominal variables.
35 2007-03-30 Ben Pfaff <blp@gnu.org>
37 * procedure.c: Adapt to new deque data structure.
39 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
40 Ben Pfaff <blp@gnu.org>
42 * file-name.c: Mingw compatibility fixes.
43 (fn_search_path): Use ISSLASH instead of comparing against '/'
45 (fn_dir_name): Use dir_name from gnulib.
46 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
47 (fn_get_identity): Use GetFullPathName instead of canonicalize
48 from gnulib, because the latter does not fully support
49 Windows-style path names. Use this implementation based on the
50 detected presence of Windows instead of the absence of Unix, since
51 the new implementation is Windows-specific.
52 (fn_compare_file_identities): In Windows implementation, compare
53 names case-insensitively.
55 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
57 * make-file.c: Don't include mkstemp.h, because gnulib now causes
58 <stdlib.h> to have the same effect.
60 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
62 * por-file-reader.c: Add missing _() around messages.
64 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
66 * make-file.c: Include "mkstemp.h", without which linking on
69 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
71 Reduce platform dependence.
73 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
74 Everywhere we using this, we really should have just depended on
75 the shell to expand tildes.
76 (fn_search_path): Simplify, given that we don't do tilde expansion
78 (fn_normalize): Removed. Caller changed to use the canonicalize
80 (fn_get_cwd): Removed. Only user was fn_normalize.
81 (fn_is_absolute): Really only test for absolute names.
82 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
84 (fn_readlink): Removed, as it was only used fn_normalize.
85 (fn_exists): Assume the stat function is available; gnulib does.
86 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
88 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
90 * dictionary.c (dict_create_vector_assert): New function.
92 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
94 * file-name.c (fn_normalize): Correct name of function
95 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
96 for pointing this out.
98 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
100 We are using a single member in struct file_handle, the "name"
101 field, for more than one purpose. When it begins with '"', it's a
102 file name; otherwise, it's a token that can be used to identify
103 it. When that assertion fires, it's because we searched for the
104 name case-sensitively as a file name (so that there was no match),
105 and then we try to insert it case-insensitively as a token, which
106 fails because duplicates aren't allowed.
108 Solution: break the two purposes into two separate fields. This
109 fixes the problem and likely makes the code easier to read too.
111 Fixes bug #18922. Thanks to John Darrington for bug report and
114 * file-handle-def.c (struct file_handle): New `id' member.
115 (fh_from_name): Rename fh_from_id. Update all callers.
116 (create_handle): New `id' parameter. Update all callers.
117 (fh_create_file): Ditto.
118 (fh_get_id): New function.
120 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
122 * case.c (case_is_null): Change return type to bool.
124 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
128 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
129 reference counting to share data. This makes it easy for
130 valgrind, etc. to find accesses to cases that have been destroyed
131 but have been kept around by another user's ref-count. This often
132 happens when the data set is small enough to find in memory; if a
133 bigger data set that would overflow to disk were used, then data
134 corruption would occur.
136 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
140 * case.c (case_unshare): Make it check internally whether the
141 ref_cnt is greater than 1, so that the callers don't have to.
142 Update callers not to check.
144 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
146 Before, I was thinking that I might want to get rid of reference
147 counting at some point. Now, I'm pretty sure that it's here to
148 stay. Thus, because we have to store the value_cnt anyway for
149 reference-counted cases, we might as well expose it to users.
151 * case.c (case_get_value_cnt): New function.
152 (case_resize): Drop OLD_CNT argument. Update all callers. Only
153 resize case if its size actually changed.
155 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
156 instead of peeking inside struct case directly.
157 (casefile_append): Ditto.
159 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
161 Get rid of the inlines for the case functions, which made the
162 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
163 the inlines didn't speed up "make check" at all, which is not a
164 perfect benchmark but seems indicative.)
166 * case.c: Remove #ifdef DEBUGGING...#endif around many function
167 definitions. Remove some assertions on nonnull pointers that were
168 redundant with a pointer dereference soon after in the function.
170 (struct case_data): Move definition here from case.h.
174 (case_data_wr): Ditto.
176 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
178 * automake.mk: Add casedeque.h to sources.
180 * casedeque.h: New file.
182 * procedure.c: (struct dataset) Change lag_count, lag_head,
183 lag_queue member into single struct casedeque member. Update all
184 users to use the casedeque instead.
187 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
189 * procedure.c: Simplify lagged cases interface. Updated all
190 clients--well, the only client--to use the simplified interface.
191 (dataset_n_lag) Removed.
192 (dataset_set_n_lag) Removed.
193 (dataset_need_lag) New function.
195 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
197 * dictionary.c procedure.c: More changes to ensure that callbacks occur
198 whenever appropriate, but only when the dataset/dictionary is in a
201 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
203 * dictionary.c dictionary.h : Added callbacks for change of filter and
204 split variables. Refactored some code to ensure that callbacks get
205 invoked when appropriate.
207 * procedure.c (proc_cancel_temporary_transformations): Make sure that
208 replace_dict callback occurs when permanent_dict replaces the current
211 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
213 * dictionary.c dictionary.h : Added callback for when the weight
214 variable of a dictionary changes.
216 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
218 * dictionary.c dictionary.h : Added replace_source and replace_dict
219 callbacks, and functions to deal with them.
221 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
223 Simplify missing value handling.
225 * missing-values.h (enum mv_class): New type.
226 (enum mv_type): Moved definition into missing-values.c and renamed
227 each MV_* to MVT_*, to distinguish them from the exposed mv_class
228 enums. Updated all uses.
229 (struct missing_values): Changed type of `type' from `enum
230 mv_type' to `int' because the definition is no longer exposed.
232 * missing-values.c (mv_is_value_missing): Add new enum mv_class
233 parameter. Update all callers.
234 (mv_is_num_missing): Ditto.
235 (mv_is_str_missing): Ditto.
236 (mv_is_value_user_missing): Removed. Changed callers to use
238 (mv_is_num_user_missing): Removed. Changed callers to use
240 (mv_is_str_user_missing): Removed. Changed callers to use
242 (mv_is_value_system_missing): Removed. Changed callers to use
244 (mv_set_type): Removed. Changed callers to use mv_clear.
245 (mv_clear): New function.
247 * variable.c (var_is_value_missing): Add new enum mv_class
248 parameter. Update all callers.
249 (var_is_num_missing): Ditto.
250 (var_is_str_missing): Ditto.
251 (var_is_value_user_missing): Removed. Changed callers to use
252 var_is_value_missing.
253 (var_is_num_user_missing): Removed. Changed callers to use
255 (var_is_str_user_missing): Removed. Changed callers to use
257 (var_is_value_system_missing): Removed. Changed callers to use
258 var_is_value_missing.
260 * casefilter.c (struct casefilter): Use enum mv_class in place of
262 (casefilter_variable_missing): Adapt to new member.
263 (casefilter_create): Change signature to take enum mv_class,
266 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
268 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
270 * case-sink.c case-sink.h procedure.c procedure.h
271 storage-stream.c: Now uses the factory.
273 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
275 Make it possible to pull cases from the active file with a
276 function call, instead of requiring indirection through a callback
279 * case-source.h (struct case_source_class): Change ->read function
280 to return a single case, instead of calling a callback function
281 for each case. Change ->destroy function to return an error
284 * case-source.c (free_case_source): Pass along the value returned
285 by the case_source ->destroy function.
287 * procedure.c (struct write_case_data): Removed.
288 (struct dataset): Added some members to track procedure state.
289 (procedure): Optimize the trivial case at this level.
290 (internal_procedure): Re-implement in terms of proc_open,
291 proc_read, proc_close.
292 (proc_open) New function.
293 (proc_read) New function.
294 (proc_close) New function.
295 (write_case) Moved into proc_read.
296 (close_active_file) Moved closing of data source into proc_close.
298 * storage-source.c: Rewrote to conform with modified
299 case_source_class interface.
301 * transformations.c (trns_chain_execute): Added argument to allow
302 starting execution from an arbitrary transformation. Updated
305 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
307 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
309 * sys-file-reader.c (read_display_parameters): Don't assume that
310 MEASURE_* and ALIGN_* have the same values found in system files.
312 * sys-file-writer.c (write_variable_display_parameters): Ditto.
314 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
315 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
316 the value of n_MEASURES, which was off by 1 (at least from my
319 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
321 * dictionary.c dictionary.h vardict.h variable.c: Added optional
322 callbacks which are invoked when the dictionary or its
323 variables are changed.
325 * missing-values.c missing-values.h value-labels.c: Tidied up
326 consistency checks, and made some of them return false
327 instead of assert-failing.
329 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
331 * calendar.c (calendar_days_in_month): New function.
333 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
335 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
336 the value label's width.
338 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
340 * sfm-private.h: Move contents into sys-file-writer.c, which is
341 the only remaining user. Removed Borland C++-specific directives.
343 * sys-file-reader.c: Clean up and rewrite entire file. The
344 rewritten version is simpler and better abstracted, and should be
345 easier to maintain and extend. It avoids using structures to read
346 file data, which is prone to padding variations among compilers.
347 It should also handle non-IEEE 754 system files, although I
348 haven't been able to find any. It has been tested against many
349 .sav files obtained from the Web and found to produce the same
350 results as the earlier version of the code, or in some cases
351 improved results. It is more tolerant of format variations found
354 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
355 member, putting an enum integer_format in its place. New member
356 `float_format'. Changed `compressed' member to type bool.
358 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
360 * dictionary.c (dict_delete_consecutive_vars): New function.
362 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
364 * file-name.c (fn_search_path): Remove prefix arg that was unused
365 by any caller. Updated all callers.
367 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
369 * format.c (fmt_dollar_template): Use user's decimal point
370 character. Add assertion.
372 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
374 * format.c (fmt_dollar_template): New function, based on
375 dollar_format_template from var-type-dialog.c.
377 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
379 * data-out.c (output_scientific): Fix bad assumption that "buf" is
382 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
384 Finish converting struct variable to an opaque type. In this
385 phase, we add remaining setter and getter functions, convert the
386 remaining PSPP code to use them, and do a bunch of cleanup. The
387 resulting changes are pervasive but mostly trivial, and only the
388 notable changes are logged.
390 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
393 * case.c (case_data): Renamed case_data_idx.
394 (case_num): Renamed case_num_idx.
395 (case_str): Renamed case_str_idx.
396 (case_data_rw): Renamed case_data_rw_idx.
398 * case.h (case_data): New function with old name and an interface
399 that takes a variable instead of an index, which is easier to
400 use. Updated all callers to use the new interface, or to use the
401 new *_idx function (see above).
404 (case_data_rw): Ditto.
406 * category.c (cat_stored_values_destroy): Changed interface to
407 take a struct cat_vals * instead of a struct variable *.
409 * dictionary.c (dict_clone): Use new vector_clone function.
410 (dict_clear) Use new var_destroy function.
411 (add_var) New function.
412 (dict_create_var) Rewrite in terms of dict_create_var_assert.
413 (dict_create_var_assert) Rewrite in terms of add_var.
414 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
415 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
416 (dict_lookup_var) Use new var_create, var_destroy functions.
417 (dict_contains_var) Rewrite in terms of new vardict functionality.
418 (set_var_dict_index) New function.
419 (set_var_case_index) New function.
420 (reindex_vars) New function.
421 (dict_delete_var) Rewrite in terms of new vardict functionality.
422 (dict_reorder_var) Ditto.
423 (dict_reorder_vars) Ditto.
424 (rename_var) New function.
425 (dict_rename_var) Use rename_var.
426 (dict_rename_vars) Use pool to simplify code. Use rename_var.
427 (dict_get_compacted_idx_to_fv) Rename
428 dict_get_compacted_dict_index_to_case_index, update callers.
429 (dict_create_vector) Use new vector_create function.
430 (dict_clear_vectors) Use new vector_destroy function.
431 (set_var_short_name_suffix) Move here from variable.c, renamed
432 from var_set_short_name_suffix, make static, update caller.
434 * sys-file-private.c: New file.
435 (sfm_width_to_bytes) Moved here from variable.c, renamed from
436 width_to_bytes, update callers.
438 * sys-file-private.h: New file. Later it will supplant
439 sfm-private.h; for now it supplements it.
440 (macro MIN_VERY_LONG_STRING) New macro.
441 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
443 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
444 MAX_LONG_STRING was used before.
446 * sys-file-writer.c: Ditto.
448 * value-labels.c: Change the paradigm here to be that a null
449 pointer is OK for a struct val_labs * in most cases; it just
450 represents an empty set of value labels.
451 (val_labs_copy) A copy of a null set is a null set.
452 (val_labs_count) A null set has 0 labels.
453 (val_labs_replace) Change return type to void. Rewrite for
455 (val_labs_find) A null set does not contain the value.
456 (value_to_string) Moved to variable.c, renamed var_get_value_name,
457 transposed argument order, updated all callers.
460 (value_dup) Moved here from variable.c.
461 (compare_values) Ditto.
464 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
465 (macro MAX_LONG_STRING) Removed, because it was only interesting
466 for system files, not for general code.
467 (macro MAX_VERY_LONG_STRING) Ditto.
468 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
469 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
471 * vardict.h: New file, for an interface between variables and
474 * variable.c: A lot of functions were moved around, for better
476 (struct variable) Move definition here, from variable.h.
477 (var_type_adj) Removed--makes i18n hard.
478 (var_type_noun) Ditto.
479 (var_create) New function.
480 (var_clone) New function.
481 (var_destroy) New function.
482 (var_set_name) Assert that variable is not in a dictionary.
483 (compare_var_names) Rename compare_vars_by_name and fix a couple
484 of callers who thought the args were strings.
485 (hash_var_name) Rename hash_var_by_name.
486 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
487 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
488 (var_is_very_long_string) Removed, because it was only interesting
490 (var_set_missing_values) Allow the argument to be the wrong width,
491 as long as we can resize it. Simplify callers who were doing the
493 (var_get_value_labels) New function.
494 (var_has_value_labels) New function.
495 (var_set_value_labels) New function.
496 (alloc_value_labels) New function.
497 (var_add_value_label) New function.
498 (var_replace_value_label) New function.
499 (var_clear_value_labels) New function.
500 (var_lookup_value_label) New function.
501 (var_get_value_name) Moved here from variable.c, renamed from
502 var_get_value_name, transposed argument order, updated all
504 (var_to_string) Moved here, from variable-label.c.
505 (var_set_leave) New function.
506 (var_get_leave) New function.
507 (var_must_leave) New function.
508 (var_set_short_name_suffix) Moved to dictionary.c, renamed
509 set_var_short_name_suffix.
510 (var_get_dict_index) New function.
511 (var_get_case_index) New function.
512 (var_get_obs_vals) New function.
513 (var_set_obs_vals) New function.
514 (var_has_obs_vals) New function.
515 (var_get_vardict) New function.
516 (var_set_vardict) New function.
517 (var_has_vardict) New function.
518 (var_clear_vardict) New function.
519 (value_dup) Moved to value.c.
520 (compare_values) Ditto.
523 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
524 (enum ALPHA) Rename VAR_STRING, update all users.
526 * vector.c: New file.
527 (struct vector) Moved here, from variable.h.
528 (check_widths) New function.
529 (vector_create) New function.
530 (vector_clone) New function.
531 (vector_destroy) New function.
532 (vector_get_name) New function.
533 (vector_get_var) New function.
534 (vector_get_var_cnt) New function.
535 (compare_vector_ptrs_by_name) New function.
537 * vector.h: New file.
539 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
541 * casefilter.c (casefilter_variable_missing): Avoided comparision of
542 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
545 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
547 * value-labels.c (destroy_atoms): New function.
548 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
550 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
552 Thanks to Jason Stover for pointing out this problem.
554 * data-out.c (output_number): Use gsl_finite from GSL, which is
555 portable, instead of isfinite, which is not.
558 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
560 * variable.c variable.h (value_dup): New function.
562 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
564 Start converting struct variable to an opaque type. In this
565 phase, we add a bunch of setter and getter functions and convert
566 most of the PSPP code to use them. The resulting changes are
567 pervasive but mostly trivial, and only the notable changes are
570 * format.c (fmt_equal): New function.
572 * variable.c (var_type_is_valid): New function.
573 (measure_is_valid) Moved here, from format.c.
574 (alignment_is_valid) Moved here, from format.c.
575 (var_get_name) New function.
576 (var_set_name) New function.
577 (width_to_type) New function.
578 (var_get_type) New function.
579 (var_get_width) New function.
580 (var_set_width) New function.
581 (var_is_numeric) New function.
582 (var_is_alpha) New function.
583 (var_is_short_string) New function.
584 (var_is_long_string) New function.
585 (var_is_very_long_string) New function.
586 (var_get_missing_values) New function.
587 (var_set_missing_values) New function.
588 (var_clear_missing_values) New function.
589 (var_has_missing_values) New function.
590 (var_is_value_missing) New function.
591 (var_is_num_missing) New function.
592 (var_is_str_missing) New function.
593 (var_is_value_user_missing) New function.
594 (var_is_num_user_missing) New function.
595 (var_is_str_user_missing) New function.
596 (var_is_value_system_missing) New function.
597 (var_get_print_format) New function.
598 (var_set_print_format) New function.
599 (var_get_write_format) New function.
600 (var_set_write_format) New function.
601 (var_set_both_formats) New function.
602 (var_get_label) New function.
603 (var_set_label) New function.
604 (var_clear_label) New function.
605 (var_has_label) New function.
606 (var_get_measure) New function.
607 (var_set_measure) New function.
608 (var_get_display_width) New function.
609 (var_set_display_width) New function.
610 (var_get_alignment) New function.
611 (var_set_alignment) New function.
612 (var_get_value_cnt) New function.
613 (var_get_leave) New function.
614 (var_get_short_name) New function.
616 * variable.h: (struct variable) Removed "type" and "nv" members;
617 they are now computed from "width" where needed.
619 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
621 * missing-values.c (mv_resize): Don't write beyond end of the
622 allocated buffer when resizing a long string.
624 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
626 Clean up identifier code: don't require identifier enumerations to
627 be in a particular order; make better use of string library;
628 expose less of the internals.
630 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
631 change interface. Updated all callers.
632 (lex_id_match) Change interface to use struct substring, update
634 (lex_id_match_len) Removed. Update callers to use lex_id_match.
635 (global array keywords[]) Make static, change form. Update all
636 users to use lex_id_name instead.
637 (lex_is_keyword) New function.
638 (lex_id_to_token) Change interface to use struct substring, update
640 (lex_id_name) New function.
642 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
643 lex_is_keyword instead.
644 (T_LAST_KEYWORD) Removed.
645 (T_N_KEYWORDS) Removed.
647 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
649 * format.c: (fmt_date_template) Distinguish characters for which a
650 space is output and any date delimiter is allowed on input, from
651 those for which a space is output and only a space is allowed on
652 input. The former is represented by X, the latter by a space.
653 Also, drop distinction between h and H, changing the former to the
656 * data-in.c: Completely rewrite internals to conform to SPSS input
657 formats as closely as possible.
658 (data_in) Changed external interface by replacing the structure
659 that was used as a single argument by a set of arguments. Updated
661 (data_in_finite_line) Removed. Converted all callers to use plain
663 (data_in_get_integer_format) New function.
664 (data_in_set_integer_format) New function.
665 (data_in_get_float_format) New function.
666 (data_in_set_float_format) New function.
668 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
669 (struct data_in) Removed.
671 * data-out.c: (output_date) Drop each component from the input as
672 it is output, to allow us to drop the distinction between h (a
673 count of hours) and H (the hour of day) template characters.
674 Also, handle new X template character.
675 (output_scientific) Follow more rational rule on when to drop
676 fraction introduced between SPSS 13 and 15. Updated test case to
679 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
681 Fix buffer overflow reported by John Darrington.
683 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
684 realize that DIGITS is a count of nibbles, not of bytes.
686 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
688 * calendar.c (calendar_offset_to_gregorian) Also return the
689 year-of-day. Change callers to new interface.
691 * data-out.c: Completely rewrite internals to conform to SPSS
692 output formats as completely as possible.
693 (data_out) Change interface to put input parameters before output
694 parameters, for consistency with the style I now prefer. Update
696 (data_out_get_integer_format) New public function.
697 (data_out_set_integer_format) New public function.
698 (data_out_get_float_format) New public function.
699 (data_out_set_float_format) New public function.
701 * data-out.h: New file. Move prototype for data_out here, from
704 * format.c: (fmt_step_width) Use equality comparison instead of
705 bitwise and, for clarity.
706 (fmt_is_string) Ditto.
707 (fmt_input_to_output) Fix categories that are translated to F
710 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
712 * casefilter.c casefilter.h (new files), casefile.c casefile.h
713 casefile-private.h: Added casefilter to assist commands with missing
716 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
718 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
720 * settings.c: (route_errors_to_terminal) New variable.
721 (route_errors_to_listing) New variable.
722 (get_error_routing_to_terminal) New function.
723 (set_error_routing_to_terminal) New function.
724 (get_error_routing_to_listing) New function.
725 (set_error_routing_to_listing) New function.
727 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
729 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
731 * format.c: Completely rewrite, to achieve better abstraction.
732 Rewrite all references to formats in other files.
734 * format.def: Rewrite and reorganize.
736 * settings.c: Move everything related to custom currency formats
737 into format.[ch], changing them in form, so as to group related
738 code and definitions better. Changed all references to use the
740 (static var decimal) Removed.
741 (static var grouping) Removed.
742 (static var cc) Removed.
743 (get_decimal) Removed.
744 (set_decimal) Removed.
745 (get_grouping) Removed.
746 (set_grouping) Removed.
750 * settings.h: (macro CC_CNT) Removed.
751 (macro CC_WIDTH) Removed.
752 (struct custom_currency) Removed.
754 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
756 * data-in.c (data_in): Use switch statement instead of table, to
757 avoid dependence on the order of the FMT_* enums.
759 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
761 * data-out.c: (num_to_string) Removed, because it was dead code.
763 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
765 * data-in.c (parse_trailer): Fix error message.
767 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
769 * format.c (fmt_is_binary): New function.
771 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
773 * procedure.c procedure.h: Encapsulated the static data into a single
776 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
778 * casefile.c (casereader_read_xfer): Always initialize the case,
779 even on an error condition.
781 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
783 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
784 entire function useless.
786 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
788 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
789 casereader method casereader_clone.
791 * procedure.c pransformations.h: Introduced new type casenum_t
793 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
795 * variable.c: (width_to_bytes) Rephrase code for clarify.
797 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
799 * format.c: (fmt_type_from_string) New function.
800 (fmt_to_string) Include decimals in output if the format has
801 decimals, even if the format type does not. This way, we can
802 accurately reproduce incorrect formats in user output.
803 (check_common_specifier) Make the check for a bad format type an
804 assertion, so we get bug reports if they show up. Fix message.
805 Check for decimal places with a format type that doesn't allow
807 (check_input_specifier) Remove check for FMT_X, which has been
809 (check_output_specifier) Ditto.
811 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
813 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
814 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
815 (enum fmt_parse_flags) Removed.
817 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
819 * casefile.c casefile.h: Converted to an abstract base class.
820 * casefile-private.h fastfile.c fastfile.h: New files.
821 * automake.mk procedure.c scratch-writer.c storage-stream.c
823 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
825 * procedure.c (internal_procedure): Create sink_case with only as
826 many values as the compacted dictionary.
828 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
830 Remove "debugging" code that caused plenty of false positives and
833 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
835 * case.c: Remove all references to `this' member.
837 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
839 Fix link error noted by Jason Stover.
841 * storage-stream.c: Include <assert.h>.
843 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
845 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
846 ALL) and additional underlying system file issues.
848 Thanks to John Darrington for review.
850 First problem: var_hash points to variables not owned by the
851 sys-file-reader, which the caller may free or modify. Use an
852 array of sfm_vars instead, as done earlier (e.g. CVS version
855 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
856 members and remove all code that references it. Add vars, var_cnt
857 members. Remove fix_specials member, which was unused.
858 (struct sfm_var) Remove name member, which was unused.
859 (sfm_close_reader) Free vars member instead of var_hash.
860 (compare_var_shortnames) Removed.
861 (hash_var_shortname) Removed.
862 (sfm_open_reader) Fill out vars array.
863 (compare_var_index) Removed.
864 (sfm_read_case) Use vars instead of var_hash.
866 Second problem: we're confused about when we actually have very
867 long strings, causing us to choose incorrectly between slow path
868 and fast path in sfm_read_case.
870 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
871 have very long strings, not when we have long variable names,
872 which is an unrelated feature.
874 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
876 * variable.h: Move var_set and variable parsing declarations to
877 new header, src/language/lexer/variable-parser.h. Modified lots
878 of files to include the new header.
880 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
882 * value-labels.c (value_to_string): When there's no value label,
883 format the variable according to its print format, instead of
884 always effectively using A or F format.
886 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
888 * casefile.c (casefile_get_random_reader): Nasty hack to get around
891 * format.c: Removed tortological assertion.
893 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
895 Reform string library.
897 * file-name.c (fn_interp_vars): Change interface to take a
898 substring as input. Updated all users.
900 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
902 * format.c (measure_is_valid): Really return false when m >=
905 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
907 Implement random access to casefiles, for use in GUI.
909 * casefile.c: (struct casereader) Add `random', `file_ofs',
910 `buffer_ofs' members.
911 (casefile_get_random_reader) New function.
912 (read_open_file) Break part into new function
913 seek_and_fill_buffer().
914 (fill_buffer) Update buffer_ofs, file_ofs.
915 (casereader_seek) New function.
917 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
919 * settings.c: Added call to i18n{done, init}.
921 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
923 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
926 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
928 * casefile.c: Convert many uses of `int' to `bool'.
930 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
932 * transformations.c (trns_chain_destroy): Destroy chain's trns
933 member, to fix memory leak.
935 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
937 * storage-stream.c (storage_source_decapsulate): Destroy case
938 source to fix memory leak.
940 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
942 * scratch-reader.c (scratch_reader_read_case): Copy into existing
943 case passed as argument instead of initializing the argument as a
944 case. Fixes memory leak that showed up in
945 tests/command/aggregate.sh with scratch files.
947 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
949 * procedure.c (proc_done): Destroy default_dict, to fix memory
952 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
954 Simplify procedure_with_splits().
956 * procedure.c (struct split_aux_data): Removed case_count member.
957 (procedure_with_splits) Don't initialize case_count.
958 (split_procedure_case_func) Check whether prev_case is null
959 instead of case_count.
960 (split_procedure_end_func) Ditto.
962 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
964 * case.c (case_move): Do nothing if dst and src are the same
966 (case_try_create) Merge two similar cases.
967 (case_copy) Unshare only if data must be actually copied.
969 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
971 * data-in.c data-out.c dictionary.c sys-file-reader.c
972 sys-file-writer.c variable.c variable.h: Reworked very long string
973 support for better encapsulation.
975 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
977 * value-labels.c (val_labs_can_set_width): New function.
978 (val_labs_set_width) Clear labels if increasing width to long
980 (val_labs_destroy) Remove unneeded test for null.
982 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
984 * value-labels.h: Remove unneeded dependency on variable.h.
986 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
988 Get rid of `char *c' member in union value, for cleanliness.
990 * value.h: (union value) Remove `c' member.
992 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
994 Make dictionary compacting functions a little more general.
996 * sys-file-writer.c (sfm_open_writer): Use
997 dict_compacting_would_change().
998 (does_dict_need_translation) Removed.
1000 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1002 Make dictionary compacting functions a little more general.
1004 * dictionary.c (dict_needs_compaction): Rename
1005 dict_compacting_would_shrink(). Update all callers.
1006 (dict_compacting_would_change) New function.
1008 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1010 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1011 inverted return value (!).
1013 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1015 Continue reforming procedure execution.
1017 * procedure.c: Search and replace "vfm" by "proc". Notably:
1018 (static var vfm_source) Rename proc_source. Update all
1020 (static var vfm_sink) Rename proc_sink. Update all references.
1022 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1024 Continue reforming procedure execution. In this phase, remove
1025 PROCESS IF, which was deprecated anyway and can be easily
1026 simulated with TEMPORARY followed by SELECT IF.
1028 * procedure.c: (open_active_file) Don't call
1029 add_process_if_trns().
1030 (discard_variables) Get rid of redundant call to
1031 proc_cancel_all_transformations().
1032 (add_process_if_trns) Removed.
1033 (process_if_trns_proc) Removed.
1034 (process_if_trns_free) Removed.
1036 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1038 Continue reforming procedure execution. In this phase, add
1039 `const' to the case passed to procedure()'s callback.
1041 Updated all users of procedure() as well.
1043 * procedure.c: (struct write_case_data) Add "const" to ccase
1044 parameter for case_func member.
1045 (procedure) Add "const" to ccase parameter for proc_func
1047 (multipass_case_func) Make ccase parameter const.
1048 (internal_procedure) Add "const" to ccase parameter for case_func
1050 (split_procedure_case_func) Make ccase parameter const.
1051 (multipass_split_case_func) Make ccase parameter const.
1053 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1055 Continue reforming procedure execution. In this phase, get rid of
1056 the output code for SPLIT FILE groups in procedure.c, which really
1057 shouldn't be doing any output. Move it into the individual
1058 procedures instead. This also adds some flexibility.
1060 Updated many users of procedure_with_splits() and
1061 multipass_procedure_with_splits() to call
1062 output_split_file_values() and to deal with increased use of
1065 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1066 parameter to begin_func member.
1067 (procedure_with_splits) Add "const struct ccase *" parameter to
1068 begin_func parameter. Make ccase parameter const in proc_func
1070 (split_procedure_case_func) Don't dump split file group. Pass
1072 (dump_splits) Moved to language/dictionary/split-file.c as
1073 output_split_file_values().
1074 (struct multipass_split_aux_data) Add "const struct ccase *"
1075 parameter to split_func member.
1076 (multipass_procedure_with_splits) Add "const struct ccase *"
1077 parameter to split_func parameter.
1078 (multipass_split_case_func) Save new SPLIT FILE case before
1080 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1082 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1084 Continue reforming procedure execution. Change
1085 internal_procedure() so that it calls open_active_file() and
1086 close_active_file(), which isolates most of the actual procedure
1089 * procedure.c: (struct write_case_data) Rename `proc_func' member
1090 to `case_func' and update all references.
1091 (procedure) Rewrite as one-line wrapper around
1092 internal_procedure().
1093 (struct multipass_aux_data) New.
1094 (multipass_callback) Renamed multipass_case_func(). Use struct
1095 multipass_aux_data as auxiliary data.
1096 (multipass_end_func) New function.
1097 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1098 that uses multipass_case_func, multipass_end_func.
1099 (internal_procedure) Add `end_func' argument. Move optimization
1100 of trivial case in here. Move call to open_active_file() and
1101 close_active_file() in here. Now assert that vfm_source is
1103 (procedure_with_splits_callback) Rename
1104 split_procedure_case_func().
1105 (split_procedure_end_func) New function.
1106 (multipass_split_callback) Rename multipass_split_case_func.
1107 (multipass_split_end_func) New function.
1108 (discard_variables) No need to test for nonnull vfm_source.
1110 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1112 Continue reforming procedure execution. Get rid of unused member.
1114 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1116 (write_case) Don't increment cases_analyzed.
1118 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1120 Continue reforming procedure execution. In this phase, move
1121 procedure.c and procedure.h from src to src/data. Update
1122 makefiles and #includes accordingly.
1124 * procedure.c: Moved here from src/.
1126 * procedure.h: Moved here from src/.
1128 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1130 Continue reforming procedure execution. In this phase, get rid of
1131 many global variables, consolidating procedure execution in
1132 procedure.c. Encapsulate transformations in new "struct
1133 trns_chain". Also, change implementation of N OF CASES, FILTER,
1134 and PROCESS IF from special cases to transformations.
1136 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1139 * dictionary.c: (global variable default_dict) Move to
1142 * variable.h: (TRNS_*) Move to transformations.h.
1143 (struct transformation) Move to transformations.c.
1145 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1147 * sys-file-reader.c: Fixed invalid read problems.
1149 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1151 * storage-stream.c: Add missing function comments.
1153 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1155 Continue reforming procedure execution. In this phase, add some
1156 new, needed functionality to storage-stream.
1158 * storage-stream.c: (storage_source_decapsulate) New function.
1160 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1162 * variable.c (width_to_bytes): Declarations must precede
1163 statements for C90 compliance.
1165 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1167 * data-out.c, data-in.c, variable.c, variable.h: New functions
1168 copy_mangle and copy_demangle for reading/writing cases; emulates the
1169 way SPSS deals with strings > 255 bytes.
1171 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1172 subtype 14 needed for strings longer than 255 bytes.
1174 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1175 instead of literal values. Also fixed some constness issues.
1177 * format.h: Constness
1179 * sfm-private.h: Renamed the case_size identifier, since I discovered
1180 that SPSS's respect for this variable is very nominal.
1182 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1184 Change case limit type from int to size_t.
1186 * dictionary.c: (struct dictionary) Change type of case_limit
1188 (dict_get_case_limit) Change return type.
1189 (dict_set_case_limit) Change parameter type.
1191 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1193 * variable.h: (struct variable) Rename `reinit' member as `leave'
1194 and invert sense. Fix up all references.
1196 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1198 Continue reforming procedure execution. In this phase, break
1199 procedure.c into multiple files.
1201 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1203 * case-sink.c: New file.
1205 * case-sink.h: New file.
1207 * case-source.c: New file.
1209 * case-source.h: New file.
1211 * storage-stream.c: New file.
1213 * storage-stream.h: New file.
1215 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1217 * variable.h: (struct variable) Remove `init' member and all
1218 references to it from other files. It was initialized in several
1219 places, but nothing really ever used it for anything worthwhile.
1220 Thanks to Jason Stover for pointing out how confusing this
1223 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1225 Continue reforming error message support. In this phase, get rid
1226 of message "titles" and put the message text in `struct error'.
1227 Now `struct error' encapsulates a message more properly.
1229 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1230 Format message ourselves.
1232 * data-in.c: (vdls_error) Ditto.
1234 * por-file-reader.c: (error) Ditto.
1236 * sys-file-reader.c: (corrupt_msg) Ditto.
1238 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1240 GNU standards require "file name" instead of "filename" in
1241 documentation. It's nice for our code to follow the convention
1244 * casefile.c: (struct casefile) Rename `filename' member to
1245 `file_name'. Updated all references.
1247 * file-name.c: [!unix] (struct file_identity) Rename
1248 normalized_filename member to normalized_file_name. Updated all
1251 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1253 We don't really support anything but Unix-like environments well,
1254 so we might as well de-obfuscate by writing directory and path
1255 separators explicitly.
1257 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1259 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1260 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1262 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1265 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1267 GNU standards require "file name" instead of "filename" in
1268 documentation. It's nice for our code to follow the convention
1271 * filename.c: Rename to file-name.c.
1273 * filename.h: Rename to file-name.h. Update all inclusions.
1274 Update header guards.
1276 * automake.mk: Update file names.
1278 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1280 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1282 (fn_basename) Removed (dead code).
1283 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1284 (fn_special_p) Renamed fn_is_special(), all references updated.
1285 (fn_exists_p) Renamed fn_exists(), all references updated.
1287 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1289 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1290 Also, now it only tilde-expands file names, not paths.
1291 (fn_search_path) Tilde-expand one directory at a time.
1293 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1295 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1296 get rid of non-Unixlike version of the code, which has probably
1298 (fn_prepend_dir) Removed (dead code).
1300 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1301 (macro PATH_SEPARATOR_STRING) New.
1302 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1304 Continue reforming error message support. In this phase, we get
1305 rid of VM() and the other msg() support for "verbosity", replacing
1306 it by a new function verbose_msg().
1308 * filename.c: (fn_search_path) Use verbose_msg() instead of
1311 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1313 * sfm-private.h: Get rid of #defines after #error, which makes no
1316 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1318 Get rid of our own int32 type in favor of the standard int32_t
1321 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1324 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1326 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1328 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1330 Remove ill-considered file routines that are no longer used.
1332 * filename.c: (fn_open_ext) Removed.
1333 (fn_close_ext) Removed.
1335 * filename.h: (struct file_ext) Removed.
1337 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1339 * variable.c (var_is_valid_name): Move declarations before code
1342 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1344 * filename.ch (fn_interp_vars): Fixed small buglet.
1346 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1348 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1349 so as to modify the string inline. Thus makeing it easier to
1350 destroy the results when no longer needed.
1352 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1354 * category.c (cat_stored_values_destroy): Fixed memory leak.
1356 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1358 Add some missing frees. Thanks to John Darrington for reporting
1361 * any-writer.c (any_writer_close): Free writer.
1363 * any-reader.c (any_reader_close): Free reader.
1365 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1367 * por-file-reader.c: (error) Mark as NO_RETURN.
1369 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1371 * settings.c: Changed default value of scompress to true.
1373 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1375 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1377 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1380 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1381 here from pref.h.orig.
1383 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1385 * sys-file-reader.c: Fixed bug reading compressed files.
1387 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1389 * Numerous renames. See src/ChangeLog for details.
1391 * Moved files from src directory