1 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
3 * data-out.c: (num_to_string) Removed, because it was dead code.
5 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
7 * data-in.c (parse_trailer): Fix error message.
9 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
11 * format.c (fmt_is_binary): New function.
13 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
15 * procedure.c procedure.h: Encapsulated the static data into a single
18 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
20 * casefile.c (casereader_read_xfer): Always initialize the case,
21 even on an error condition.
23 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
25 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
26 entire function useless.
28 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
30 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
31 casereader method casereader_clone.
33 * procedure.c pransformations.h: Introduced new type casenum_t
35 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
37 * variable.c: (width_to_bytes) Rephrase code for clarify.
39 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
41 * format.c: (fmt_type_from_string) New function.
42 (fmt_to_string) Include decimals in output if the format has
43 decimals, even if the format type does not. This way, we can
44 accurately reproduce incorrect formats in user output.
45 (check_common_specifier) Make the check for a bad format type an
46 assertion, so we get bug reports if they show up. Fix message.
47 Check for decimal places with a format type that doesn't allow
49 (check_input_specifier) Remove check for FMT_X, which has been
51 (check_output_specifier) Ditto.
53 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
55 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
56 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
57 (enum fmt_parse_flags) Removed.
59 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
61 * casefile.c casefile.h: Converted to an abstract base class.
62 * casefile-private.h fastfile.c fastfile.h: New files.
63 * automake.mk procedure.c scratch-writer.c storage-stream.c
65 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
67 * procedure.c (internal_procedure): Create sink_case with only as
68 many values as the compacted dictionary.
70 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
72 Remove "debugging" code that caused plenty of false positives and
75 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
77 * case.c: Remove all references to `this' member.
79 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
81 Fix link error noted by Jason Stover.
83 * storage-stream.c: Include <assert.h>.
85 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
87 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
88 ALL) and additional underlying system file issues.
90 Thanks to John Darrington for review.
92 First problem: var_hash points to variables not owned by the
93 sys-file-reader, which the caller may free or modify. Use an
94 array of sfm_vars instead, as done earlier (e.g. CVS version
97 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
98 members and remove all code that references it. Add vars, var_cnt
99 members. Remove fix_specials member, which was unused.
100 (struct sfm_var) Remove name member, which was unused.
101 (sfm_close_reader) Free vars member instead of var_hash.
102 (compare_var_shortnames) Removed.
103 (hash_var_shortname) Removed.
104 (sfm_open_reader) Fill out vars array.
105 (compare_var_index) Removed.
106 (sfm_read_case) Use vars instead of var_hash.
108 Second problem: we're confused about when we actually have very
109 long strings, causing us to choose incorrectly between slow path
110 and fast path in sfm_read_case.
112 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
113 have very long strings, not when we have long variable names,
114 which is an unrelated feature.
116 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
118 * variable.h: Move var_set and variable parsing declarations to
119 new header, src/language/lexer/variable-parser.h. Modified lots
120 of files to include the new header.
122 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
124 * value-labels.c (value_to_string): When there's no value label,
125 format the variable according to its print format, instead of
126 always effectively using A or F format.
128 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
130 * casefile.c (casefile_get_random_reader): Nasty hack to get around
133 * format.c: Removed tortological assertion.
135 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
137 Reform string library.
139 * file-name.c (fn_interp_vars): Change interface to take a
140 substring as input. Updated all users.
142 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
144 * format.c (measure_is_valid): Really return false when m >=
147 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
149 Implement random access to casefiles, for use in GUI.
151 * casefile.c: (struct casereader) Add `random', `file_ofs',
152 `buffer_ofs' members.
153 (casefile_get_random_reader) New function.
154 (read_open_file) Break part into new function
155 seek_and_fill_buffer().
156 (fill_buffer) Update buffer_ofs, file_ofs.
157 (casereader_seek) New function.
159 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
161 * settings.c: Added call to i18n{done, init}.
163 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
165 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
168 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
170 * casefile.c: Convert many uses of `int' to `bool'.
172 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
174 * transformations.c (trns_chain_destroy): Destroy chain's trns
175 member, to fix memory leak.
177 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
179 * storage-stream.c (storage_source_decapsulate): Destroy case
180 source to fix memory leak.
182 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
184 * scratch-reader.c (scratch_reader_read_case): Copy into existing
185 case passed as argument instead of initializing the argument as a
186 case. Fixes memory leak that showed up in
187 tests/command/aggregate.sh with scratch files.
189 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
191 * procedure.c (proc_done): Destroy default_dict, to fix memory
194 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
196 Simplify procedure_with_splits().
198 * procedure.c (struct split_aux_data): Removed case_count member.
199 (procedure_with_splits) Don't initialize case_count.
200 (split_procedure_case_func) Check whether prev_case is null
201 instead of case_count.
202 (split_procedure_end_func) Ditto.
204 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
206 * case.c (case_move): Do nothing if dst and src are the same
208 (case_try_create) Merge two similar cases.
209 (case_copy) Unshare only if data must be actually copied.
211 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
213 * data-in.c data-out.c dictionary.c sys-file-reader.c
214 sys-file-writer.c variable.c variable.h: Reworked very long string
215 support for better encapsulation.
217 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
219 * value-labels.c (val_labs_can_set_width): New function.
220 (val_labs_set_width) Clear labels if increasing width to long
222 (val_labs_destroy) Remove unneeded test for null.
224 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
226 * value-labels.h: Remove unneeded dependency on variable.h.
228 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
230 Get rid of `char *c' member in union value, for cleanliness.
232 * value.h: (union value) Remove `c' member.
234 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
236 Make dictionary compacting functions a little more general.
238 * sys-file-writer.c (sfm_open_writer): Use
239 dict_compacting_would_change().
240 (does_dict_need_translation) Removed.
242 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
244 Make dictionary compacting functions a little more general.
246 * dictionary.c (dict_needs_compaction): Rename
247 dict_compacting_would_shrink(). Update all callers.
248 (dict_compacting_would_change) New function.
250 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
252 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
253 inverted return value (!).
255 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
257 Continue reforming procedure execution.
259 * procedure.c: Search and replace "vfm" by "proc". Notably:
260 (static var vfm_source) Rename proc_source. Update all
262 (static var vfm_sink) Rename proc_sink. Update all references.
264 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
266 Continue reforming procedure execution. In this phase, remove
267 PROCESS IF, which was deprecated anyway and can be easily
268 simulated with TEMPORARY followed by SELECT IF.
270 * procedure.c: (open_active_file) Don't call
271 add_process_if_trns().
272 (discard_variables) Get rid of redundant call to
273 proc_cancel_all_transformations().
274 (add_process_if_trns) Removed.
275 (process_if_trns_proc) Removed.
276 (process_if_trns_free) Removed.
278 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
280 Continue reforming procedure execution. In this phase, add
281 `const' to the case passed to procedure()'s callback.
283 Updated all users of procedure() as well.
285 * procedure.c: (struct write_case_data) Add "const" to ccase
286 parameter for case_func member.
287 (procedure) Add "const" to ccase parameter for proc_func
289 (multipass_case_func) Make ccase parameter const.
290 (internal_procedure) Add "const" to ccase parameter for case_func
292 (split_procedure_case_func) Make ccase parameter const.
293 (multipass_split_case_func) Make ccase parameter const.
295 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
297 Continue reforming procedure execution. In this phase, get rid of
298 the output code for SPLIT FILE groups in procedure.c, which really
299 shouldn't be doing any output. Move it into the individual
300 procedures instead. This also adds some flexibility.
302 Updated many users of procedure_with_splits() and
303 multipass_procedure_with_splits() to call
304 output_split_file_values() and to deal with increased use of
307 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
308 parameter to begin_func member.
309 (procedure_with_splits) Add "const struct ccase *" parameter to
310 begin_func parameter. Make ccase parameter const in proc_func
312 (split_procedure_case_func) Don't dump split file group. Pass
314 (dump_splits) Moved to language/dictionary/split-file.c as
315 output_split_file_values().
316 (struct multipass_split_aux_data) Add "const struct ccase *"
317 parameter to split_func member.
318 (multipass_procedure_with_splits) Add "const struct ccase *"
319 parameter to split_func parameter.
320 (multipass_split_case_func) Save new SPLIT FILE case before
322 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
324 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
326 Continue reforming procedure execution. Change
327 internal_procedure() so that it calls open_active_file() and
328 close_active_file(), which isolates most of the actual procedure
331 * procedure.c: (struct write_case_data) Rename `proc_func' member
332 to `case_func' and update all references.
333 (procedure) Rewrite as one-line wrapper around
334 internal_procedure().
335 (struct multipass_aux_data) New.
336 (multipass_callback) Renamed multipass_case_func(). Use struct
337 multipass_aux_data as auxiliary data.
338 (multipass_end_func) New function.
339 (multipass_procedure) Rewrite as wrapper for internal_procedure()
340 that uses multipass_case_func, multipass_end_func.
341 (internal_procedure) Add `end_func' argument. Move optimization
342 of trivial case in here. Move call to open_active_file() and
343 close_active_file() in here. Now assert that vfm_source is
345 (procedure_with_splits_callback) Rename
346 split_procedure_case_func().
347 (split_procedure_end_func) New function.
348 (multipass_split_callback) Rename multipass_split_case_func.
349 (multipass_split_end_func) New function.
350 (discard_variables) No need to test for nonnull vfm_source.
352 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
354 Continue reforming procedure execution. Get rid of unused member.
356 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
358 (write_case) Don't increment cases_analyzed.
360 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
362 Continue reforming procedure execution. In this phase, move
363 procedure.c and procedure.h from src to src/data. Update
364 makefiles and #includes accordingly.
366 * procedure.c: Moved here from src/.
368 * procedure.h: Moved here from src/.
370 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
372 Continue reforming procedure execution. In this phase, get rid of
373 many global variables, consolidating procedure execution in
374 procedure.c. Encapsulate transformations in new "struct
375 trns_chain". Also, change implementation of N OF CASES, FILTER,
376 and PROCESS IF from special cases to transformations.
378 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
381 * dictionary.c: (global variable default_dict) Move to
384 * variable.h: (TRNS_*) Move to transformations.h.
385 (struct transformation) Move to transformations.c.
387 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
389 * sys-file-reader.c: Fixed invalid read problems.
391 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
393 * storage-stream.c: Add missing function comments.
395 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
397 Continue reforming procedure execution. In this phase, add some
398 new, needed functionality to storage-stream.
400 * storage-stream.c: (storage_source_decapsulate) New function.
402 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
404 * variable.c (width_to_bytes): Declarations must precede
405 statements for C90 compliance.
407 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
409 * data-out.c, data-in.c, variable.c, variable.h: New functions
410 copy_mangle and copy_demangle for reading/writing cases; emulates the
411 way SPSS deals with strings > 255 bytes.
413 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
414 subtype 14 needed for strings longer than 255 bytes.
416 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
417 instead of literal values. Also fixed some constness issues.
419 * format.h: Constness
421 * sfm-private.h: Renamed the case_size identifier, since I discovered
422 that SPSS's respect for this variable is very nominal.
424 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
426 Change case limit type from int to size_t.
428 * dictionary.c: (struct dictionary) Change type of case_limit
430 (dict_get_case_limit) Change return type.
431 (dict_set_case_limit) Change parameter type.
433 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
435 * variable.h: (struct variable) Rename `reinit' member as `leave'
436 and invert sense. Fix up all references.
438 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
440 Continue reforming procedure execution. In this phase, break
441 procedure.c into multiple files.
443 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
445 * case-sink.c: New file.
447 * case-sink.h: New file.
449 * case-source.c: New file.
451 * case-source.h: New file.
453 * storage-stream.c: New file.
455 * storage-stream.h: New file.
457 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
459 * variable.h: (struct variable) Remove `init' member and all
460 references to it from other files. It was initialized in several
461 places, but nothing really ever used it for anything worthwhile.
462 Thanks to Jason Stover for pointing out how confusing this
465 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
467 Continue reforming error message support. In this phase, get rid
468 of message "titles" and put the message text in `struct error'.
469 Now `struct error' encapsulates a message more properly.
471 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
472 Format message ourselves.
474 * data-in.c: (vdls_error) Ditto.
476 * por-file-reader.c: (error) Ditto.
478 * sys-file-reader.c: (corrupt_msg) Ditto.
480 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
482 GNU standards require "file name" instead of "filename" in
483 documentation. It's nice for our code to follow the convention
486 * casefile.c: (struct casefile) Rename `filename' member to
487 `file_name'. Updated all references.
489 * file-name.c: [!unix] (struct file_identity) Rename
490 normalized_filename member to normalized_file_name. Updated all
493 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
495 We don't really support anything but Unix-like environments well,
496 so we might as well de-obfuscate by writing directory and path
497 separators explicitly.
499 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
501 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
502 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
504 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
507 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
509 GNU standards require "file name" instead of "filename" in
510 documentation. It's nice for our code to follow the convention
513 * filename.c: Rename to file-name.c.
515 * filename.h: Rename to file-name.h. Update all inclusions.
516 Update header guards.
518 * automake.mk: Update file names.
520 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
522 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
524 (fn_basename) Removed (dead code).
525 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
526 (fn_special_p) Renamed fn_is_special(), all references updated.
527 (fn_exists_p) Renamed fn_exists(), all references updated.
529 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
531 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
532 Also, now it only tilde-expands file names, not paths.
533 (fn_search_path) Tilde-expand one directory at a time.
535 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
537 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
538 get rid of non-Unixlike version of the code, which has probably
540 (fn_prepend_dir) Removed (dead code).
542 * filename.h: (macro DIR_SEPARATOR_STRING) New.
543 (macro PATH_SEPARATOR_STRING) New.
544 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
546 Continue reforming error message support. In this phase, we get
547 rid of VM() and the other msg() support for "verbosity", replacing
548 it by a new function verbose_msg().
550 * filename.c: (fn_search_path) Use verbose_msg() instead of
553 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
555 * sfm-private.h: Get rid of #defines after #error, which makes no
558 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
560 Get rid of our own int32 type in favor of the standard int32_t
563 * sfm-private.h: (int32 macro) Don't define this anymore. Do
566 * sys-file-reader.c: Use int32_t instead of int32 throughout.
568 * sys-file-writer.c: Use int32_t instead of int32 throughout.
570 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
572 Remove ill-considered file routines that are no longer used.
574 * filename.c: (fn_open_ext) Removed.
575 (fn_close_ext) Removed.
577 * filename.h: (struct file_ext) Removed.
579 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
581 * variable.c (var_is_valid_name): Move declarations before code
584 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
586 * filename.ch (fn_interp_vars): Fixed small buglet.
588 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
590 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
591 so as to modify the string inline. Thus makeing it easier to
592 destroy the results when no longer needed.
594 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
596 * category.c (cat_stored_values_destroy): Fixed memory leak.
598 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
600 Add some missing frees. Thanks to John Darrington for reporting
603 * any-writer.c (any_writer_close): Free writer.
605 * any-reader.c (any_reader_close): Free reader.
607 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
609 * por-file-reader.c: (error) Mark as NO_RETURN.
611 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
613 * settings.c: Changed default value of scompress to true.
615 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
617 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
619 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
622 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
623 here from pref.h.orig.
625 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
627 * sys-file-reader.c: Fixed bug reading compressed files.
629 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
631 * Numerous renames. See src/ChangeLog for details.
633 * Moved files from src directory