1 2007-10-01 Ben Pfaff <blp@gnu.org>
3 Fix bug #21192. Thanks to John Darrington for review.
5 * casereader.c (casereader_read): Decrement case_cnt before
6 calling the casereader's "read" member function, so that we
7 interact properly with lazy_casereader.
9 * datasheet.c: Add regression test for above bug fix.
10 (clone_datasheet): New function.
11 (lazy_callback): New function.
12 (check_datasheet_casereader): New function.
13 (check_datasheet): Check datasheet contents are reported correctly
14 through an ordinary casereader and a lazy casereader.
15 (clone_model): Use clone_datasheet.
17 2007-09-24 Ben Pfaff <blp@gnu.org>
19 Patch #6210. Reviewed by John Darrington.
20 * settings.c: Drop "long view", which is not needed any longer.
21 (static var long_view): Removed.
22 (force_long_view): Removed.
23 (get_viewwidth): Removed.
24 (init_viewport): Removed long_view reference.
26 2007-09-19 John Darrington <john@darrington.wattle.id.au>
28 * settings.c settings.h: Changed viewport's length and width to be
29 owned by the user interface which uses the data library. This allows
30 better abstraction, and makes dynamically adjustable dimensions easier.
32 2007-09-18 Ben Pfaff <blp@gnu.org>
34 * procedure.c (proc_extract_active_file_data): New function.
36 * lazy-casereader.h: New file.
38 * lazy-casereader.c: New file.
40 * casereader.c (casereader_dynamic_cast): New function.
42 2007-09-14 Ben Pfaff <blp@gnu.org>
44 * dictionary.c (dict_clone): Copy case indexes from cloned
45 dictionary. Fixes bug #21061. Reviewed by John Darrington.
47 2007-09-13 John Darrington <john@darrington.wattle.id.au>
49 * value.c value.h (create_value): New function.
51 2007-09-12 Ben Pfaff <blp@gnu.org>
53 Make it clear that translator casereader and casewriter translate
54 functions are supposed to destroy their input case.
56 * casereader-translator.c (struct casereader_translator): Change
57 input case parameter of translate member function from const
58 struct ccase * to struct ccase *.
59 (casereader_create_translator): Ditto, for translate parameter.
61 * casewriter-translator.c (struct casewriter_translator): Ditto.
62 (casewriter_create_translator): Ditto.
64 2007-08-27 John Darrington <john@darrington.wattle.id.au>
66 * sys-file-reader.c (read_display_parameters): Force display width
67 to 8, if the sys file says 0 (like SPSS does).
69 2007-08-12 Ben Pfaff <blp@gnu.org>
71 * dictionary.c (dict_dump): New function.
73 2007-08-12 Ben Pfaff <blp@gnu.org>
75 Drop dict_compactor in favor of using the new struct case_map.
77 * dictionary.c (struct copy_map): Removed.
78 (struct dict_compactor): Removed.
79 (dict_make_compactor): Removed.
80 (dict_compactor_compact): Removed.
81 (dict_compactor_destroy): Removed.
83 * procedure.c (struct data_set): Change `compactor' member to be a
85 (proc_open): Use case_map_to_compact_dict instead of
87 (proc_casereader_read): Use case_map_execute instead of
88 dict_compactor_compact.
89 (proc_commit): Use case_map_destroy instead of
90 dict_compactor_destroy.
92 * scratch-writer.c (struct scratch_writer): Change `compactor'
93 member to be a struct case_map *.
94 (scratch_writer_open): Use case_map_to_compact_dict instead of
96 (scratch_writer_casewriter_write): Use case_map_execute instead of
97 dict_compactor_compact.
99 2007-08-12 Ben Pfaff <blp@gnu.org>
101 * automake.mk: Add case-map.c, case-map.h.
103 * case-map.c: New file.
105 * case-map.h: New file.
107 2007-08-12 Ben Pfaff <blp@gnu.org>
109 * dictionary.c (dict_compact_values): Don't delete scratch
110 variables as well as compacting case indexes. Update all callers.
111 (dict_get_compacted_value_cnt): Rename dict_count_values and
112 change interface. Update all callers.
113 (dict_get_compacted_value_cnt): Remove.
114 (dict_compacting_would_shrink): Remove.
115 (dict_compacting_would_change): Remove.
116 (dict_make_compactor): Add new parameter. Update all callers.
118 * procedure.c (proc_casereader_read): Use casewriter_get_value_cnt
119 instead of dict_count_values, changing an O(N) operation into
122 2007-08-12 Ben Pfaff <blp@gnu.org>
124 * casereader.c (casereader_read): Don't require cases read by a
125 casereader to be exactly the expected size: as long as they're big
128 2007-08-12 Ben Pfaff <blp@gnu.org>
130 Make casewriters keep track of the number of `union value's in
131 each case. This is useful for two reasons: casewriter_write can
132 then check that the case being written is large enough, and later
133 recipients of the casewriter can determine the size of the case.
135 * casewriter-translator.c (casewriter_create_translator): Add
138 * casewriter.c (struct casewriter): Add value_cnt member.
139 (casewriter_write): Check that the case passed in is big enough.
140 (casewriter_get_value_cnt): New function.
141 (casewriter_create): Add value_cnt parameter.
143 2007-08-09 Ben Pfaff <blp@gnu.org>
145 Fix bug reported by Jason Stover.
146 * settings.c: Move get_termcap_viewport and in particular the
147 #include for <curses.h> to the end of the file. curses.h
148 redefines bool on some systems (e.g. OpenBSD), which causes
149 disagreement between uses of bool before its inclusion and
151 Tested by Jason Stover.
153 2007-07-29 Ben Pfaff <blp@gnu.org>
155 Provisional fix for bug #18692 and bug #20161. Reviewed by John
158 * file-name.c (fn_open): Only pass "r" or "w" to popen as mode
159 argument (never "rb" or "wb") because SUSv3 says that only those
160 modes are defined, and glibc in fact rejects other modes.
162 Open portable files with fn_open so that they can be read from
163 pipes. Fix missing fh_close call to go along with fh_open.
164 Report an error if the file close reports an error.
165 * por-file-reader.c (close_reader): New function.
166 (por_file_casereader_destroy): Use close_reader.
167 (pfm_open_reader): Open file with fn_open.
169 2007-07-28 Ben Pfaff <blp@gnu.org>
171 Make PSPP able to read all the portable files I could find on the
172 web. Thanks to John Darrington for review. Bug #17620.
173 * por-file-reader.c (struct pfm_reader): New member `line_length'.
174 (error): Print file offset in hexadecimal.
175 (warning): New function.
176 (advance): Treat lines less than 80 bytes long as padded to 80
178 (pfm_open_reader): Call read_documents if we find an "E" record.
179 (convert_format): Convert invalid formats to the default format
180 instead of aborting reading the file.
181 (read_variables): Rename duplicate variable names instead of
182 aborting reading the file.
183 (read_value_label): Allow string variables of different widths to
184 be assigned value labels in the same record. Replace duplicate
185 value labels instead of aborting.
186 (read_documents): New function.
188 * por-file-writer.c (pfm_open_writer): Call write_documents if the
189 dictionary has documents.
190 (write_documents): New function.
192 2007-07-25 Ben Pfaff <blp@gnu.org>
194 Fix bugs related to bug #17213.
196 * settings.c: Use HAVE_LIBNCURSES instead of HAVE_LIBTERMCAP,
197 since the former is what config.h has. Include the needed ncurses
199 (static var echo) Rename to `do_echo' because the original name is
200 the same as an ncurses identifier.
201 (get_termcap_viewport) Use error instead of msg.
203 * file-name.c (fn_interp_vars): Fix interpolation of $VARS.
204 (fn_close): Don't close stdin, stdout, stderr.
206 2007-07-26 John Darrington <john@darrington.wattle.id.au>
208 * procedure.c procedure.h: Added callbacks which get invoked whenever
209 a dataset's transformation chain changes.
211 2007-07-24 Ben Pfaff <blp@gnu.org>
214 * sys-file-writer.c (write_variable_display_parameters): Use new
215 var_default_display_width function to choose display width of
216 segments after the first one in a given variable.
217 * variable.c (var_create): Use var_default_display_width to pick
218 new variable's display width.
219 (var_default_display_width): New function.
220 Reviewed by John Darrington.
222 2007-07-24 Ben Pfaff <blp@gnu.org>
225 * por-file-writer.c (write_variables): Write weight variable.
226 Reviewed by John Darrington.
228 2007-07-23 Ben Pfaff <blp@gnu.org>
230 Improvements to system file reader and writer.
232 First, move all detailed knowledge of very long strings into
233 sys-file-private.[ch], so that this nasty stuff can be isolated.
235 * sys-file-private.c (REAL_VLS_CHUNK): New macro.
236 (EFFECTIVE_VLS_CHUNK): New macro.
237 (min_int): New function.
238 (max_int): New function.
239 (sfm_width_to_bytes): Rewrite.
240 (sfm_width_to_octs): New function.
241 (sfm_segment_alloc_width): New function.
242 (sfm_segment_alloc_bytes): New function.
243 (sfm_segment_used_bytes): New function.
244 (sfm_segment_offset): New function.
245 (sfm_segment_effective_offset): New function.
246 (sfm_dictionary_to_sfm_vars): New function.
248 * sys-file-private.h (MIN_VERY_LONG_STRING): Removed.
249 (EFFECTIVE_LONG_STRING_LENGTH): Removed.
250 (struct sfm_var): New structure.
252 Next, improvements to the system file reader.
254 * sys-file-reader.h (struct sfm_read_info): Changed `case_cnt' to
255 type casenumber. Added `version_major', `version_minor',
258 * sys-file-reader.c (struct sfm_reader): Replaced `flt64_cnt' by
259 `oct_cnt'. Rename `vars', `var_cnt' to `sfm_vars', `sfm_var_cnt'.
260 Change `case_cnt' to type casenumber. Removed `has_vls'.
261 (struct sfm_var): Removed.
262 (sfm_open_reader): Don't warn on wrong case size if the file was
263 written by SPSS 13, which tends to get it wrong. Use
264 sfm_dictionary_to_sfm_vars.
265 (read_header): Always output system file info.
266 (read_variable_record): Simplify code for reading missing values.
267 (read_machine_int32_info): Save version numbers from system file
268 into info struct passed as new argument.
269 (read_long_string_map): Restructured to use new sys-file-private
271 (read_value_labels): Use size_overflow_p.
272 (sys_file_casereader_read): Get rid of distinction between fast
273 and slow paths. Use information provided by sys-file-primate's
274 struct sfm_var to simplify code.
275 (skip_whole_strings): New function.
276 (read_int32): Renamed read_int. Changed return value to int.
278 (read_flt64): Renamed read_float. Changed return value to
279 double. Updated all callers.
280 (int32_to_native): Removed. Changed callers to use
282 (flt64_to_double): Removed. Changed callers to use float_convert.
284 Finally, get rid of int32, flt64 terminology and types in system
285 file writer. The former wasn't very useful since a POSIX "int"
286 can hold the whole range of int32 and we generally didn't have a
287 need for it to be exactly-32-bits, just at-least-32-bits. The
288 latter was inconvenient because we had to assume that it could be
289 different from double and thereby convert special values SYSMIS,
290 HIGHEST, LOWEST to and from it in multiple places. Instead, now
291 we just use "int" and "double" in most places, and do conversions,
292 if necessary, very close to where we do I/O. This change meant
293 that the writer code couldn't represent records in the file as C
294 structs any longer, but that's no great loss. The code actually
295 seems to be more readable without them.
297 Simplify the compression buffering code: only buffer as much as
298 necessary, which is no more than eight 8-byte units at any given
301 * sys-file-writer.c (typedef flt64): Removed.
302 (macro second_lowest_flt64): Removed.
303 (struct sysfile_header): Removed.
304 (struct sysfile_variable): Removed.
305 (struct sfm_writer): Removed `needs_translation', `has_vls',
306 `flt64_cnt'. Changed `compress' to type bool and `case_cnt' to
307 type casenumber. Renamed `vars' to `sfm_vars', `var_cnt' to
308 `sfm_var_cnt'. Replaced `buf', `end', `ptr', `x', `y' for
309 compression buffering by `opcodes', `opcode_cnt', `data',
310 `data_cnt'. Renamed `var_cnt_vls' as `segment_cnt'.
311 (sfm_open_writer): Use sfm_dictionary_to_sfm_vars. Use simple
312 data writer functions instead of structures.
313 (calc_oct_idx): New function.
314 (write_header): Use simple data writer functions instead of
316 (write_format_spec): Renamed write_format. New argument.
317 (write_variable_continuation_records): New function.
318 (write_variable): Use simple data writer functions instead of
319 structures. Use write_variable_continuation_records. Write
320 entire very long string instead of requiring caller to understand
322 (write_value_labels): Use simple data writer functions instead of
324 (write_documents): Ditto.
325 (write_variable_display_parameters): Use sys-file-private
326 functions to simplify. Use simple data writer functions instead
328 (write_vls_length_table): Use simple data writer functions instead
330 (write_longvar_table): Ditto.
331 (write_rec_7_34): Break into new functions
332 write_integer_info_record, write_float_info_record. Use simple
333 data writer functions instead of structures.
334 (buf_write): Removed.
335 (append_string_max): Removed.
336 (ensure_buf_space): Removed.
337 (sys_file_casewriter_write): Get rid of the distinction between
338 fast and slow paths, which didn't seem to be too useful. Use new
339 functions write_case_uncompressed, write_case_compressed.
340 (put_instruction): Removed.
341 (put_element): Removed.
342 (write_compressed_data): Removed.
343 (close_writer): Use flush_compressed. Only write case count to
344 system file if it will fit in the field.
345 (write_case_compressed): New function.
346 (write_case_uncompressed): New function.
347 (flush_compressed): New function.
348 (put_cmp_opcode): New function.
349 (put_cmp_number): New function.
350 (write_int): New function.
351 (convert_double_to_output_format): New function.
352 (write_float): New function.
353 (write_value): New function.
354 (write_string): New function.
355 (write_bytes): New function.
356 (write_zeros): New function.
357 (write_spaces): New function.
359 Reviewed by John Darrington.
361 2007-07-22 Ben Pfaff <blp@gnu.org>
363 Don't try to write very long strings to portable files. The
364 format does not support it.
366 * por-file-writer.c (MAX_POR_WIDTH): New macro.
367 (pfm_open_writer): Limit output width to MAX_POR_WIDTH.
368 (write_format): Add arg to take width to resize format to.
369 (write_value): Limit width of value written to MAX_POR_WIDTH.
370 (write_variables): Limit width of variable and its output formats
372 Reviewed by John Darrington.
374 2007-07-22 Ben Pfaff <blp@gnu.org>
376 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
377 local variable instead of literal 5.
378 Reviewed by John Darrington.
380 2007-07-22 Ben Pfaff <blp@gnu.org>
382 Fix problems with uniqueness of short names in system files with
383 very long string variables. Now a variable may have multiple
386 * automake.mk (src_data_libdata_a_SOURCES): Add new files
387 short-names.c, short-names.h.
389 * dictionary.c (dict_clone): Clone all the short names.
390 (compare_strings): Move into short-names.c.
391 (hash_strings): Ditto.
392 (set_var_short_name_suffix): Ditto.
393 (dict_assign_short_names): Ditto, rename short_names_assign,
394 change to assign all short names.
396 * por-file-writer.c (write_variables): Use short_names_assign
397 instead of dict_assign_short_names.
399 * short-names.c: New file.
401 * short-names.h: New file.
403 * sys-file-private.c (sfm_width_to_segments): New function.
405 * sys-file-reader.c (read_long_var_name_map): Save and restore all
406 the short names, not just the first one.
408 * sys-file-writer.c (cont_var_name): Removed.
409 (sfm_open_writer): Use short_names_assign instead of
410 dict_assign_short_names. Use unique short names assigned by
411 short_names_assign instead of those generated by cont_var_name.
413 * variable.c (struct variable): Remove `short_name' member,
414 replace by `short_names' and `short_name_cnt'.
415 (var_create) Initialize new members.
416 (var_get_short_name_cnt): New function.
417 (var_get_short_name): Now takes an index argument. Changed most
419 (var_set_short_name): Ditto.
420 (var_clear_short_name): Renamed var_clear_short_names, changed to
421 clear all short names.
423 Reviewed by John Darrington.
425 2007-07-22 Ben Pfaff <blp@gnu.org>
427 * variable.c (var_set_width): Use new var_set_width function.
429 * missing-values.c (mv_n_values): Drop assertion, which was not
432 * format.c (fmt_default_for_width): New function.
433 (fmt_resize): New function.
435 Reviewed by John Darrington.
437 2007-07-18 John Darrington <john@darrington.wattle.id.au>
439 * datasheet.c (datasheet_delete_columns): Added assertion to check
440 we're not deleting outside the range of the sheet.
443 * dictionary.c dictionary.h variable.c: Added the ability for string
444 variables to be resized.
446 * vardict.h: Added some prototypes (moved from dictionary.h) as
447 these should only be called by variable.c
450 2007-07-14 John Darrington <john@darrington.wattle.id.au>
452 * sfm-reader.c: Respect case_cnt field in file header.
454 2007-07-01 John Darrington <john@darrington.wattle.id.au>
456 * transformation.c transformation.h (trns_chain_execute): Changed the
457 signature (Patch #6057)
459 2007-06-10 Ben Pfaff <blp@gnu.org>
461 * casereader-filter.c (casereader_filter_destroy): Make sure to
462 write all the remaining excluded cases to the casewriter, if any.
464 * caseinit.c (init_list_destroy): Rewrite.
465 (init_list_clear): Ditto.
467 * casegrouper.c (casegrouper_get_next_group): Always set *reader
468 to null when returning false.
470 2007-06-06 Ben Pfaff <blp@gnu.org>
472 Actually implement the new procedure code and adapt all of its
473 clients to match. Also adapt all of the other case sources and
474 sinks in the tree and their clients to use the
475 casereader/casewriter infrastructure.
477 * automake.mk: Add and remove files.
479 * any-reader.c: Change into a casereader.
480 * por-file-reader.c: Ditto.
481 * scratch-reader.c: Ditto.
482 * sys-file-reader.c: Ditto.
484 * any-writer.c: Change into a casewriter.
485 * por-file-writer.c: Ditto.
486 * scratch-writer.c: Ditto.
487 * sys-file-writer.c: Ditto.
489 * procedure.c: Change to use casereader, casewriter, caseinit, and
490 other new infrastructure.
492 * scratch-handle.c: Adapt to new infrastructure.
494 * case-sink.c: Removed, now dead code.
495 * case-sink.h: Ditto.
496 * case-source.c: Ditto.
497 * case-source.h: Ditto.
498 * casefile-factory.c: Ditto.
499 * casefile-private.h: Ditto.
502 * casefilter.c: Ditto.
503 * casefilter.h: Ditto.
506 * fastfile-factory.c: Ditto.
507 * fastfile-factory.h: Ditto.
508 * storage-stream.c: Ditto.
509 * storage-stream.h: Ditto.
511 2007-06-06 Ben Pfaff <blp@gnu.org>
515 * automake.mk: Add new files.
517 * datasheet.c: New file.
519 * datasheet.h: New file.
521 2007-06-06 Ben Pfaff <blp@gnu.org>
523 Until now, the procedure code has provided a case to the
524 case_source, which has filled in the data values that come from
525 the active file. "Left" data values that don't come from the
526 active file naturally stay the same from case to case, because the
527 procedure code keeps using that same case.
529 One of the compromises that comes with the new procedure code is
530 that the active file allocates and provides its own case, which
531 the procedure code then has to resize to provide room for any
532 other variables that should go in the case and then fill in the
533 values of "left" variables. Then, when we're done with that case,
534 we have to save the values of "left" variables to copy into the
535 next case read from the active file.
537 The caseinit code helps with this.
539 * automake.mk: Add new files.
541 * caseinit.c: New file.
543 * caseinit.h: New file.
545 2007-06-06 Ben Pfaff <blp@gnu.org>
547 * value.h (value_cnt_from_width): New function.
549 * variable.c (var_get_value_cnt): Use new function.
551 2007-06-06 Ben Pfaff <blp@gnu.org>
553 Add casegrouper, to allow cases read from a given casereader to be
554 broken into groups, each of which has its own casereader.
555 Generally cases are grouped based on having equal values for some
558 * automake.mk: Add new files.
560 * casegrouper.c: New file.
562 * casegrouper.h: New file.
564 2007-06-06 Ben Pfaff <blp@gnu.org>
566 Add interface to lexicographical ordering of cases.
568 * automake.mk: Add new files.
570 * case-ordering.c: New file.
572 * case-ordering.h: New file.
574 2007-06-06 Ben Pfaff <blp@gnu.org>
576 Add casereaders and casewriters, the basis of the new data processing
577 implementation. A casereader is a uniform interface to reading cases
578 from a data source; a casewriter is a uniform interface to writing
579 cases to a data sink.
581 * automake.mk: Add new files.
583 * casereader-filter.c: New file.
585 * casereader-provider.h: New file.
587 * casereader-translator.c: New file.
589 * casereader.c: New file.
591 * casereader.h: New file.
593 * casewriter-provider.h: New file.
595 * casewriter-translator.c: New file.
597 * casewriter.c: New file.
599 * casewriter.h: New file.
601 2007-06-06 Ben Pfaff <blp@gnu.org>
603 "casewindow" data structure that extends the deque (from libpspp)
604 of cases with the ability to dump cases to disk if we get too many
607 * automake.mk: Add new files.
609 * casewindow.c: New file.
611 * casewindow.h: New file.
613 2007-06-06 Ben Pfaff <blp@gnu.org>
615 sparse_cases data structure that augments a sparse_array of cases
616 with the ability to dump cases to disk if we get too many cases in
619 * automake.mk: Add new files.
621 * sparse-cases.c: New file.
623 * sparse-cases.h: New file.
625 2007-06-06 Ben Pfaff <blp@gnu.org>
627 Adds a low-level on-disk case array data structure.
629 * automake.mk: Add new files.
631 * case-tmpfile.c: New file.
633 * case-tmpfile.h: New file.
635 2007-06-06 Ben Pfaff <blp@gnu.org>
637 In a couple of places we calculate the maximum number of cases to
638 keep in memory based on the user-defined workspace. Enable
639 centralizing the calculation through a new function.
641 * settings.c (get_workspace_cases): New function.
643 2007-06-06 Ben Pfaff <blp@gnu.org>
645 The casenumber type is defined in transformations.h, but case.h is
646 a more sensible place. Move it.
648 * case.h (CASENUMBER_MAX): New macro.
649 (typedef casenumber): Move here, from transformations.h.
651 2007-06-03 Ben Pfaff <blp@gnu.org>
653 Slightly generalize case_to_values and case_from_values functions.
655 * case.c (case_to_values): Rename case_copy_out, change interface.
656 (case_from_values): Rename case_copy_in, change interface.
658 * fastfile.c (fastfilereader_get_next_case): Update caller.
659 (write_case_to_disk): Ditto.
661 2007-06-02 Ben Pfaff <blp@gnu.org>
663 Clean up after a forgotten part of patch #5829.
665 * casedeque.h: Remove unused file.
667 * automake.mk: Remove casedeque.h from sources.
669 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
671 * category.c: Removed redundant #include
673 2007-05-06 Ben Pfaff <blp@gnu.org>
675 Abstract the documents within a dictionary a little better.
676 Thanks to John Darrington for suggestion, initial version, and
679 * dictionary.c (struct dictionary): Change `documents' member from
680 char * to struct string.
681 (dict_clear): Destroy struct string.
682 (dict_get_documents): Convert struct string to char *.
683 (dict_set_documents): Set struct string. Pad to 80-character
685 (dict_clear_documents): New function.
686 (dict_add_document_line): New function.
687 (dict_get_document_line_cnt): New function.
688 (dict_get_document_line): New function.
690 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
692 * sys-file-reader.c (read_documents): Use new document functions.
694 2007-04-19 John Darrington <john@darrington.wattle.id.au>
696 * sys-file-reader.c: When reading a system file which has no
697 long name table, automatically create one where the long names
698 are the lower case versions of the short names.
700 2007-04-22 Ben Pfaff <blp@gnu.org>
702 * dictionary.c (dict_set_split_vars): dict_destroy expects that
703 dict_clear will free most data related to the dictionary.
704 dict_clear does a decent job, except that dict_set_split_vars on
705 some systems won't actually free the dict's "split" member.
706 Instead, it'll allocate a 1-byte region. Fix this.
708 * value.c (value_copy): New function.
709 (value_set_missing): Ditto.
711 2007-04-22 John Darrington <john@darrington.wattle.id.au>
713 * Deleted existing category.h and moved cat-routines.h into
714 category.h Encapsulated struct cat_vals better.
716 2007-04-19 John Darrington <john@darrington.wattle.id.au>
718 * sys-file-reader.c: When reading a system file which has no
719 long name table, automatically create one where the long names
720 are the lower case versions of the short names.
722 2007-04-16 John Darrington <john@darrington.wattle.id.au>
724 * sys-file-reader.c: Some versions of Other Software seem to
725 produce system files with string variables' measure set to
726 zero. We'll assume these are supposed to be nominal variables.
728 2007-03-30 Ben Pfaff <blp@gnu.org>
730 * procedure.c: Adapt to new deque data structure.
732 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
733 Ben Pfaff <blp@gnu.org>
735 * file-name.c: Mingw compatibility fixes.
736 (fn_search_path): Use ISSLASH instead of comparing against '/'
738 (fn_dir_name): Use dir_name from gnulib.
739 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
740 (fn_get_identity): Use GetFullPathName instead of canonicalize
741 from gnulib, because the latter does not fully support
742 Windows-style path names. Use this implementation based on the
743 detected presence of Windows instead of the absence of Unix, since
744 the new implementation is Windows-specific.
745 (fn_compare_file_identities): In Windows implementation, compare
746 names case-insensitively.
748 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
750 * make-file.c: Don't include mkstemp.h, because gnulib now causes
751 <stdlib.h> to have the same effect.
753 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
755 * por-file-reader.c: Add missing _() around messages.
757 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
759 * make-file.c: Include "mkstemp.h", without which linking on
762 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
764 Reduce platform dependence.
766 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
767 Everywhere we using this, we really should have just depended on
768 the shell to expand tildes.
769 (fn_search_path): Simplify, given that we don't do tilde expansion
771 (fn_normalize): Removed. Caller changed to use the canonicalize
773 (fn_get_cwd): Removed. Only user was fn_normalize.
774 (fn_is_absolute): Really only test for absolute names.
775 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
777 (fn_readlink): Removed, as it was only used fn_normalize.
778 (fn_exists): Assume the stat function is available; gnulib does.
779 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
781 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
783 * dictionary.c (dict_create_vector_assert): New function.
785 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
787 * file-name.c (fn_normalize): Correct name of function
788 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
789 for pointing this out.
791 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
793 We are using a single member in struct file_handle, the "name"
794 field, for more than one purpose. When it begins with '"', it's a
795 file name; otherwise, it's a token that can be used to identify
796 it. When that assertion fires, it's because we searched for the
797 name case-sensitively as a file name (so that there was no match),
798 and then we try to insert it case-insensitively as a token, which
799 fails because duplicates aren't allowed.
801 Solution: break the two purposes into two separate fields. This
802 fixes the problem and likely makes the code easier to read too.
804 Fixes bug #18922. Thanks to John Darrington for bug report and
807 * file-handle-def.c (struct file_handle): New `id' member.
808 (fh_from_name): Rename fh_from_id. Update all callers.
809 (create_handle): New `id' parameter. Update all callers.
810 (fh_create_file): Ditto.
811 (fh_get_id): New function.
813 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
815 * case.c (case_is_null): Change return type to bool.
817 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
821 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
822 reference counting to share data. This makes it easy for
823 valgrind, etc. to find accesses to cases that have been destroyed
824 but have been kept around by another user's ref-count. This often
825 happens when the data set is small enough to find in memory; if a
826 bigger data set that would overflow to disk were used, then data
827 corruption would occur.
829 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
833 * case.c (case_unshare): Make it check internally whether the
834 ref_cnt is greater than 1, so that the callers don't have to.
835 Update callers not to check.
837 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
839 Before, I was thinking that I might want to get rid of reference
840 counting at some point. Now, I'm pretty sure that it's here to
841 stay. Thus, because we have to store the value_cnt anyway for
842 reference-counted cases, we might as well expose it to users.
844 * case.c (case_get_value_cnt): New function.
845 (case_resize): Drop OLD_CNT argument. Update all callers. Only
846 resize case if its size actually changed.
848 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
849 instead of peeking inside struct case directly.
850 (casefile_append): Ditto.
852 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
854 Get rid of the inlines for the case functions, which made the
855 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
856 the inlines didn't speed up "make check" at all, which is not a
857 perfect benchmark but seems indicative.)
859 * case.c: Remove #ifdef DEBUGGING...#endif around many function
860 definitions. Remove some assertions on nonnull pointers that were
861 redundant with a pointer dereference soon after in the function.
863 (struct case_data): Move definition here from case.h.
867 (case_data_wr): Ditto.
869 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
871 * automake.mk: Add casedeque.h to sources.
873 * casedeque.h: New file.
875 * procedure.c: (struct dataset) Change lag_count, lag_head,
876 lag_queue member into single struct casedeque member. Update all
877 users to use the casedeque instead.
880 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
882 * procedure.c: Simplify lagged cases interface. Updated all
883 clients--well, the only client--to use the simplified interface.
884 (dataset_n_lag) Removed.
885 (dataset_set_n_lag) Removed.
886 (dataset_need_lag) New function.
888 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
890 * dictionary.c procedure.c: More changes to ensure that callbacks occur
891 whenever appropriate, but only when the dataset/dictionary is in a
894 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
896 * dictionary.c dictionary.h : Added callbacks for change of filter and
897 split variables. Refactored some code to ensure that callbacks get
898 invoked when appropriate.
900 * procedure.c (proc_cancel_temporary_transformations): Make sure that
901 replace_dict callback occurs when permanent_dict replaces the current
904 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
906 * dictionary.c dictionary.h : Added callback for when the weight
907 variable of a dictionary changes.
909 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
911 * dictionary.c dictionary.h : Added replace_source and replace_dict
912 callbacks, and functions to deal with them.
914 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
916 Simplify missing value handling.
918 * missing-values.h (enum mv_class): New type.
919 (enum mv_type): Moved definition into missing-values.c and renamed
920 each MV_* to MVT_*, to distinguish them from the exposed mv_class
921 enums. Updated all uses.
922 (struct missing_values): Changed type of `type' from `enum
923 mv_type' to `int' because the definition is no longer exposed.
925 * missing-values.c (mv_is_value_missing): Add new enum mv_class
926 parameter. Update all callers.
927 (mv_is_num_missing): Ditto.
928 (mv_is_str_missing): Ditto.
929 (mv_is_value_user_missing): Removed. Changed callers to use
931 (mv_is_num_user_missing): Removed. Changed callers to use
933 (mv_is_str_user_missing): Removed. Changed callers to use
935 (mv_is_value_system_missing): Removed. Changed callers to use
937 (mv_set_type): Removed. Changed callers to use mv_clear.
938 (mv_clear): New function.
940 * variable.c (var_is_value_missing): Add new enum mv_class
941 parameter. Update all callers.
942 (var_is_num_missing): Ditto.
943 (var_is_str_missing): Ditto.
944 (var_is_value_user_missing): Removed. Changed callers to use
945 var_is_value_missing.
946 (var_is_num_user_missing): Removed. Changed callers to use
948 (var_is_str_user_missing): Removed. Changed callers to use
950 (var_is_value_system_missing): Removed. Changed callers to use
951 var_is_value_missing.
953 * casefilter.c (struct casefilter): Use enum mv_class in place of
955 (casefilter_variable_missing): Adapt to new member.
956 (casefilter_create): Change signature to take enum mv_class,
959 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
961 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
963 * case-sink.c case-sink.h procedure.c procedure.h
964 storage-stream.c: Now uses the factory.
966 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
968 Make it possible to pull cases from the active file with a
969 function call, instead of requiring indirection through a callback
972 * case-source.h (struct case_source_class): Change ->read function
973 to return a single case, instead of calling a callback function
974 for each case. Change ->destroy function to return an error
977 * case-source.c (free_case_source): Pass along the value returned
978 by the case_source ->destroy function.
980 * procedure.c (struct write_case_data): Removed.
981 (struct dataset): Added some members to track procedure state.
982 (procedure): Optimize the trivial case at this level.
983 (internal_procedure): Re-implement in terms of proc_open,
984 proc_read, proc_close.
985 (proc_open) New function.
986 (proc_read) New function.
987 (proc_close) New function.
988 (write_case) Moved into proc_read.
989 (close_active_file) Moved closing of data source into proc_close.
991 * storage-source.c: Rewrote to conform with modified
992 case_source_class interface.
994 * transformations.c (trns_chain_execute): Added argument to allow
995 starting execution from an arbitrary transformation. Updated
998 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
1000 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
1002 * sys-file-reader.c (read_display_parameters): Don't assume that
1003 MEASURE_* and ALIGN_* have the same values found in system files.
1005 * sys-file-writer.c (write_variable_display_parameters): Ditto.
1007 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
1008 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
1009 the value of n_MEASURES, which was off by 1 (at least from my
1012 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1014 * dictionary.c dictionary.h vardict.h variable.c: Added optional
1015 callbacks which are invoked when the dictionary or its
1016 variables are changed.
1018 * missing-values.c missing-values.h value-labels.c: Tidied up
1019 consistency checks, and made some of them return false
1020 instead of assert-failing.
1022 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
1024 * calendar.c (calendar_days_in_month): New function.
1026 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
1028 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
1029 the value label's width.
1031 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
1033 * sfm-private.h: Move contents into sys-file-writer.c, which is
1034 the only remaining user. Removed Borland C++-specific directives.
1036 * sys-file-reader.c: Clean up and rewrite entire file. The
1037 rewritten version is simpler and better abstracted, and should be
1038 easier to maintain and extend. It avoids using structures to read
1039 file data, which is prone to padding variations among compilers.
1040 It should also handle non-IEEE 754 system files, although I
1041 haven't been able to find any. It has been tested against many
1042 .sav files obtained from the Web and found to produce the same
1043 results as the earlier version of the code, or in some cases
1044 improved results. It is more tolerant of format variations found
1047 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
1048 member, putting an enum integer_format in its place. New member
1049 `float_format'. Changed `compressed' member to type bool.
1051 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
1053 * dictionary.c (dict_delete_consecutive_vars): New function.
1055 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
1057 * file-name.c (fn_search_path): Remove prefix arg that was unused
1058 by any caller. Updated all callers.
1060 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
1062 * format.c (fmt_dollar_template): Use user's decimal point
1063 character. Add assertion.
1065 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
1067 * format.c (fmt_dollar_template): New function, based on
1068 dollar_format_template from var-type-dialog.c.
1070 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
1072 * data-out.c (output_scientific): Fix bad assumption that "buf" is
1075 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
1077 Finish converting struct variable to an opaque type. In this
1078 phase, we add remaining setter and getter functions, convert the
1079 remaining PSPP code to use them, and do a bunch of cleanup. The
1080 resulting changes are pervasive but mostly trivial, and only the
1081 notable changes are logged.
1083 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
1086 * case.c (case_data): Renamed case_data_idx.
1087 (case_num): Renamed case_num_idx.
1088 (case_str): Renamed case_str_idx.
1089 (case_data_rw): Renamed case_data_rw_idx.
1091 * case.h (case_data): New function with old name and an interface
1092 that takes a variable instead of an index, which is easier to
1093 use. Updated all callers to use the new interface, or to use the
1094 new *_idx function (see above).
1097 (case_data_rw): Ditto.
1099 * category.c (cat_stored_values_destroy): Changed interface to
1100 take a struct cat_vals * instead of a struct variable *.
1102 * dictionary.c (dict_clone): Use new vector_clone function.
1103 (dict_clear) Use new var_destroy function.
1104 (add_var) New function.
1105 (dict_create_var) Rewrite in terms of dict_create_var_assert.
1106 (dict_create_var_assert) Rewrite in terms of add_var.
1107 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
1108 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
1109 (dict_lookup_var) Use new var_create, var_destroy functions.
1110 (dict_contains_var) Rewrite in terms of new vardict functionality.
1111 (set_var_dict_index) New function.
1112 (set_var_case_index) New function.
1113 (reindex_vars) New function.
1114 (dict_delete_var) Rewrite in terms of new vardict functionality.
1115 (dict_reorder_var) Ditto.
1116 (dict_reorder_vars) Ditto.
1117 (rename_var) New function.
1118 (dict_rename_var) Use rename_var.
1119 (dict_rename_vars) Use pool to simplify code. Use rename_var.
1120 (dict_get_compacted_idx_to_fv) Rename
1121 dict_get_compacted_dict_index_to_case_index, update callers.
1122 (dict_create_vector) Use new vector_create function.
1123 (dict_clear_vectors) Use new vector_destroy function.
1124 (set_var_short_name_suffix) Move here from variable.c, renamed
1125 from var_set_short_name_suffix, make static, update caller.
1127 * sys-file-private.c: New file.
1128 (sfm_width_to_bytes) Moved here from variable.c, renamed from
1129 width_to_bytes, update callers.
1131 * sys-file-private.h: New file. Later it will supplant
1132 sfm-private.h; for now it supplements it.
1133 (macro MIN_VERY_LONG_STRING) New macro.
1134 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
1136 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
1137 MAX_LONG_STRING was used before.
1139 * sys-file-writer.c: Ditto.
1141 * value-labels.c: Change the paradigm here to be that a null
1142 pointer is OK for a struct val_labs * in most cases; it just
1143 represents an empty set of value labels.
1144 (val_labs_copy) A copy of a null set is a null set.
1145 (val_labs_count) A null set has 0 labels.
1146 (val_labs_replace) Change return type to void. Rewrite for
1148 (val_labs_find) A null set does not contain the value.
1149 (value_to_string) Moved to variable.c, renamed var_get_value_name,
1150 transposed argument order, updated all callers.
1152 * value.c: New file.
1153 (value_dup) Moved here from variable.c.
1154 (compare_values) Ditto.
1157 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
1158 (macro MAX_LONG_STRING) Removed, because it was only interesting
1159 for system files, not for general code.
1160 (macro MAX_VERY_LONG_STRING) Ditto.
1161 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
1162 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
1164 * vardict.h: New file, for an interface between variables and
1167 * variable.c: A lot of functions were moved around, for better
1169 (struct variable) Move definition here, from variable.h.
1170 (var_type_adj) Removed--makes i18n hard.
1171 (var_type_noun) Ditto.
1172 (var_create) New function.
1173 (var_clone) New function.
1174 (var_destroy) New function.
1175 (var_set_name) Assert that variable is not in a dictionary.
1176 (compare_var_names) Rename compare_vars_by_name and fix a couple
1177 of callers who thought the args were strings.
1178 (hash_var_name) Rename hash_var_by_name.
1179 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
1180 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
1181 (var_is_very_long_string) Removed, because it was only interesting
1182 to system file code.
1183 (var_set_missing_values) Allow the argument to be the wrong width,
1184 as long as we can resize it. Simplify callers who were doing the
1185 resizing themselves.
1186 (var_get_value_labels) New function.
1187 (var_has_value_labels) New function.
1188 (var_set_value_labels) New function.
1189 (alloc_value_labels) New function.
1190 (var_add_value_label) New function.
1191 (var_replace_value_label) New function.
1192 (var_clear_value_labels) New function.
1193 (var_lookup_value_label) New function.
1194 (var_get_value_name) Moved here from variable.c, renamed from
1195 var_get_value_name, transposed argument order, updated all
1197 (var_to_string) Moved here, from variable-label.c.
1198 (var_set_leave) New function.
1199 (var_get_leave) New function.
1200 (var_must_leave) New function.
1201 (var_set_short_name_suffix) Moved to dictionary.c, renamed
1202 set_var_short_name_suffix.
1203 (var_get_dict_index) New function.
1204 (var_get_case_index) New function.
1205 (var_get_obs_vals) New function.
1206 (var_set_obs_vals) New function.
1207 (var_has_obs_vals) New function.
1208 (var_get_vardict) New function.
1209 (var_set_vardict) New function.
1210 (var_has_vardict) New function.
1211 (var_clear_vardict) New function.
1212 (value_dup) Moved to value.c.
1213 (compare_values) Ditto.
1216 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
1217 (enum ALPHA) Rename VAR_STRING, update all users.
1219 * vector.c: New file.
1220 (struct vector) Moved here, from variable.h.
1221 (check_widths) New function.
1222 (vector_create) New function.
1223 (vector_clone) New function.
1224 (vector_destroy) New function.
1225 (vector_get_name) New function.
1226 (vector_get_var) New function.
1227 (vector_get_var_cnt) New function.
1228 (compare_vector_ptrs_by_name) New function.
1230 * vector.h: New file.
1232 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1234 * casefilter.c (casefilter_variable_missing): Avoided comparision of
1235 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
1238 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
1240 * value-labels.c (destroy_atoms): New function.
1241 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
1243 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
1245 Thanks to Jason Stover for pointing out this problem.
1247 * data-out.c (output_number): Use gsl_finite from GSL, which is
1248 portable, instead of isfinite, which is not.
1251 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
1253 * variable.c variable.h (value_dup): New function.
1255 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
1257 Start converting struct variable to an opaque type. In this
1258 phase, we add a bunch of setter and getter functions and convert
1259 most of the PSPP code to use them. The resulting changes are
1260 pervasive but mostly trivial, and only the notable changes are
1263 * format.c (fmt_equal): New function.
1265 * variable.c (var_type_is_valid): New function.
1266 (measure_is_valid) Moved here, from format.c.
1267 (alignment_is_valid) Moved here, from format.c.
1268 (var_get_name) New function.
1269 (var_set_name) New function.
1270 (width_to_type) New function.
1271 (var_get_type) New function.
1272 (var_get_width) New function.
1273 (var_set_width) New function.
1274 (var_is_numeric) New function.
1275 (var_is_alpha) New function.
1276 (var_is_short_string) New function.
1277 (var_is_long_string) New function.
1278 (var_is_very_long_string) New function.
1279 (var_get_missing_values) New function.
1280 (var_set_missing_values) New function.
1281 (var_clear_missing_values) New function.
1282 (var_has_missing_values) New function.
1283 (var_is_value_missing) New function.
1284 (var_is_num_missing) New function.
1285 (var_is_str_missing) New function.
1286 (var_is_value_user_missing) New function.
1287 (var_is_num_user_missing) New function.
1288 (var_is_str_user_missing) New function.
1289 (var_is_value_system_missing) New function.
1290 (var_get_print_format) New function.
1291 (var_set_print_format) New function.
1292 (var_get_write_format) New function.
1293 (var_set_write_format) New function.
1294 (var_set_both_formats) New function.
1295 (var_get_label) New function.
1296 (var_set_label) New function.
1297 (var_clear_label) New function.
1298 (var_has_label) New function.
1299 (var_get_measure) New function.
1300 (var_set_measure) New function.
1301 (var_get_display_width) New function.
1302 (var_set_display_width) New function.
1303 (var_get_alignment) New function.
1304 (var_set_alignment) New function.
1305 (var_get_value_cnt) New function.
1306 (var_get_leave) New function.
1307 (var_get_short_name) New function.
1309 * variable.h: (struct variable) Removed "type" and "nv" members;
1310 they are now computed from "width" where needed.
1312 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
1314 * missing-values.c (mv_resize): Don't write beyond end of the
1315 allocated buffer when resizing a long string.
1317 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
1319 Clean up identifier code: don't require identifier enumerations to
1320 be in a particular order; make better use of string library;
1321 expose less of the internals.
1323 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
1324 change interface. Updated all callers.
1325 (lex_id_match) Change interface to use struct substring, update
1327 (lex_id_match_len) Removed. Update callers to use lex_id_match.
1328 (global array keywords[]) Make static, change form. Update all
1329 users to use lex_id_name instead.
1330 (lex_is_keyword) New function.
1331 (lex_id_to_token) Change interface to use struct substring, update
1333 (lex_id_name) New function.
1335 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
1336 lex_is_keyword instead.
1337 (T_LAST_KEYWORD) Removed.
1338 (T_N_KEYWORDS) Removed.
1340 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
1342 * format.c: (fmt_date_template) Distinguish characters for which a
1343 space is output and any date delimiter is allowed on input, from
1344 those for which a space is output and only a space is allowed on
1345 input. The former is represented by X, the latter by a space.
1346 Also, drop distinction between h and H, changing the former to the
1349 * data-in.c: Completely rewrite internals to conform to SPSS input
1350 formats as closely as possible.
1351 (data_in) Changed external interface by replacing the structure
1352 that was used as a single argument by a set of arguments. Updated
1354 (data_in_finite_line) Removed. Converted all callers to use plain
1356 (data_in_get_integer_format) New function.
1357 (data_in_set_integer_format) New function.
1358 (data_in_get_float_format) New function.
1359 (data_in_set_float_format) New function.
1361 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
1362 (struct data_in) Removed.
1364 * data-out.c: (output_date) Drop each component from the input as
1365 it is output, to allow us to drop the distinction between h (a
1366 count of hours) and H (the hour of day) template characters.
1367 Also, handle new X template character.
1368 (output_scientific) Follow more rational rule on when to drop
1369 fraction introduced between SPSS 13 and 15. Updated test case to
1372 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
1374 Fix buffer overflow reported by John Darrington.
1376 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
1377 realize that DIGITS is a count of nibbles, not of bytes.
1379 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1381 * calendar.c (calendar_offset_to_gregorian) Also return the
1382 year-of-day. Change callers to new interface.
1384 * data-out.c: Completely rewrite internals to conform to SPSS
1385 output formats as completely as possible.
1386 (data_out) Change interface to put input parameters before output
1387 parameters, for consistency with the style I now prefer. Update
1389 (data_out_get_integer_format) New public function.
1390 (data_out_set_integer_format) New public function.
1391 (data_out_get_float_format) New public function.
1392 (data_out_set_float_format) New public function.
1394 * data-out.h: New file. Move prototype for data_out here, from
1397 * format.c: (fmt_step_width) Use equality comparison instead of
1398 bitwise and, for clarity.
1399 (fmt_is_string) Ditto.
1400 (fmt_input_to_output) Fix categories that are translated to F
1403 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1405 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1406 casefile-private.h: Added casefilter to assist commands with missing
1409 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1411 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1413 * settings.c: (route_errors_to_terminal) New variable.
1414 (route_errors_to_listing) New variable.
1415 (get_error_routing_to_terminal) New function.
1416 (set_error_routing_to_terminal) New function.
1417 (get_error_routing_to_listing) New function.
1418 (set_error_routing_to_listing) New function.
1420 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1422 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1424 * format.c: Completely rewrite, to achieve better abstraction.
1425 Rewrite all references to formats in other files.
1427 * format.def: Rewrite and reorganize.
1429 * settings.c: Move everything related to custom currency formats
1430 into format.[ch], changing them in form, so as to group related
1431 code and definitions better. Changed all references to use the
1433 (static var decimal) Removed.
1434 (static var grouping) Removed.
1435 (static var cc) Removed.
1436 (get_decimal) Removed.
1437 (set_decimal) Removed.
1438 (get_grouping) Removed.
1439 (set_grouping) Removed.
1443 * settings.h: (macro CC_CNT) Removed.
1444 (macro CC_WIDTH) Removed.
1445 (struct custom_currency) Removed.
1447 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1449 * data-in.c (data_in): Use switch statement instead of table, to
1450 avoid dependence on the order of the FMT_* enums.
1452 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1454 * data-out.c: (num_to_string) Removed, because it was dead code.
1456 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1458 * data-in.c (parse_trailer): Fix error message.
1460 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1462 * format.c (fmt_is_binary): New function.
1464 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1466 * procedure.c procedure.h: Encapsulated the static data into a single
1469 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1471 * casefile.c (casereader_read_xfer): Always initialize the case,
1472 even on an error condition.
1474 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1476 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1477 entire function useless.
1479 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1481 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1482 casereader method casereader_clone.
1484 * procedure.c pransformations.h: Introduced new type casenum_t
1486 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1488 * variable.c: (width_to_bytes) Rephrase code for clarify.
1490 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1492 * format.c: (fmt_type_from_string) New function.
1493 (fmt_to_string) Include decimals in output if the format has
1494 decimals, even if the format type does not. This way, we can
1495 accurately reproduce incorrect formats in user output.
1496 (check_common_specifier) Make the check for a bad format type an
1497 assertion, so we get bug reports if they show up. Fix message.
1498 Check for decimal places with a format type that doesn't allow
1500 (check_input_specifier) Remove check for FMT_X, which has been
1502 (check_output_specifier) Ditto.
1504 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1506 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1507 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1508 (enum fmt_parse_flags) Removed.
1510 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1512 * casefile.c casefile.h: Converted to an abstract base class.
1513 * casefile-private.h fastfile.c fastfile.h: New files.
1514 * automake.mk procedure.c scratch-writer.c storage-stream.c
1516 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1518 * procedure.c (internal_procedure): Create sink_case with only as
1519 many values as the compacted dictionary.
1521 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1523 Remove "debugging" code that caused plenty of false positives and
1526 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1528 * case.c: Remove all references to `this' member.
1530 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1532 Fix link error noted by Jason Stover.
1534 * storage-stream.c: Include <assert.h>.
1536 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1538 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1539 ALL) and additional underlying system file issues.
1541 Thanks to John Darrington for review.
1543 First problem: var_hash points to variables not owned by the
1544 sys-file-reader, which the caller may free or modify. Use an
1545 array of sfm_vars instead, as done earlier (e.g. CVS version
1548 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1549 members and remove all code that references it. Add vars, var_cnt
1550 members. Remove fix_specials member, which was unused.
1551 (struct sfm_var) Remove name member, which was unused.
1552 (sfm_close_reader) Free vars member instead of var_hash.
1553 (compare_var_shortnames) Removed.
1554 (hash_var_shortname) Removed.
1555 (sfm_open_reader) Fill out vars array.
1556 (compare_var_index) Removed.
1557 (sfm_read_case) Use vars instead of var_hash.
1559 Second problem: we're confused about when we actually have very
1560 long strings, causing us to choose incorrectly between slow path
1561 and fast path in sfm_read_case.
1563 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1564 have very long strings, not when we have long variable names,
1565 which is an unrelated feature.
1567 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1569 * variable.h: Move var_set and variable parsing declarations to
1570 new header, src/language/lexer/variable-parser.h. Modified lots
1571 of files to include the new header.
1573 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1575 * value-labels.c (value_to_string): When there's no value label,
1576 format the variable according to its print format, instead of
1577 always effectively using A or F format.
1579 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1581 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1584 * format.c: Removed tortological assertion.
1586 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1588 Reform string library.
1590 * file-name.c (fn_interp_vars): Change interface to take a
1591 substring as input. Updated all users.
1593 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1595 * format.c (measure_is_valid): Really return false when m >=
1598 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1600 Implement random access to casefiles, for use in GUI.
1602 * casefile.c: (struct casereader) Add `random', `file_ofs',
1603 `buffer_ofs' members.
1604 (casefile_get_random_reader) New function.
1605 (read_open_file) Break part into new function
1606 seek_and_fill_buffer().
1607 (fill_buffer) Update buffer_ofs, file_ofs.
1608 (casereader_seek) New function.
1610 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1612 * settings.c: Added call to i18n{done, init}.
1614 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1616 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1619 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1621 * casefile.c: Convert many uses of `int' to `bool'.
1623 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1625 * transformations.c (trns_chain_destroy): Destroy chain's trns
1626 member, to fix memory leak.
1628 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1630 * storage-stream.c (storage_source_decapsulate): Destroy case
1631 source to fix memory leak.
1633 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1635 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1636 case passed as argument instead of initializing the argument as a
1637 case. Fixes memory leak that showed up in
1638 tests/command/aggregate.sh with scratch files.
1640 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1642 * procedure.c (proc_done): Destroy default_dict, to fix memory
1645 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1647 Simplify procedure_with_splits().
1649 * procedure.c (struct split_aux_data): Removed case_count member.
1650 (procedure_with_splits) Don't initialize case_count.
1651 (split_procedure_case_func) Check whether prev_case is null
1652 instead of case_count.
1653 (split_procedure_end_func) Ditto.
1655 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1657 * case.c (case_move): Do nothing if dst and src are the same
1659 (case_try_create) Merge two similar cases.
1660 (case_copy) Unshare only if data must be actually copied.
1662 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1664 * data-in.c data-out.c dictionary.c sys-file-reader.c
1665 sys-file-writer.c variable.c variable.h: Reworked very long string
1666 support for better encapsulation.
1668 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1670 * value-labels.c (val_labs_can_set_width): New function.
1671 (val_labs_set_width) Clear labels if increasing width to long
1673 (val_labs_destroy) Remove unneeded test for null.
1675 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1677 * value-labels.h: Remove unneeded dependency on variable.h.
1679 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1681 Get rid of `char *c' member in union value, for cleanliness.
1683 * value.h: (union value) Remove `c' member.
1685 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1687 Make dictionary compacting functions a little more general.
1689 * sys-file-writer.c (sfm_open_writer): Use
1690 dict_compacting_would_change().
1691 (does_dict_need_translation) Removed.
1693 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1695 Make dictionary compacting functions a little more general.
1697 * dictionary.c (dict_needs_compaction): Rename
1698 dict_compacting_would_shrink(). Update all callers.
1699 (dict_compacting_would_change) New function.
1701 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1703 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1704 inverted return value (!).
1706 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1708 Continue reforming procedure execution.
1710 * procedure.c: Search and replace "vfm" by "proc". Notably:
1711 (static var vfm_source) Rename proc_source. Update all
1713 (static var vfm_sink) Rename proc_sink. Update all references.
1715 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1717 Continue reforming procedure execution. In this phase, remove
1718 PROCESS IF, which was deprecated anyway and can be easily
1719 simulated with TEMPORARY followed by SELECT IF.
1721 * procedure.c: (open_active_file) Don't call
1722 add_process_if_trns().
1723 (discard_variables) Get rid of redundant call to
1724 proc_cancel_all_transformations().
1725 (add_process_if_trns) Removed.
1726 (process_if_trns_proc) Removed.
1727 (process_if_trns_free) Removed.
1729 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1731 Continue reforming procedure execution. In this phase, add
1732 `const' to the case passed to procedure()'s callback.
1734 Updated all users of procedure() as well.
1736 * procedure.c: (struct write_case_data) Add "const" to ccase
1737 parameter for case_func member.
1738 (procedure) Add "const" to ccase parameter for proc_func
1740 (multipass_case_func) Make ccase parameter const.
1741 (internal_procedure) Add "const" to ccase parameter for case_func
1743 (split_procedure_case_func) Make ccase parameter const.
1744 (multipass_split_case_func) Make ccase parameter const.
1746 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1748 Continue reforming procedure execution. In this phase, get rid of
1749 the output code for SPLIT FILE groups in procedure.c, which really
1750 shouldn't be doing any output. Move it into the individual
1751 procedures instead. This also adds some flexibility.
1753 Updated many users of procedure_with_splits() and
1754 multipass_procedure_with_splits() to call
1755 output_split_file_values() and to deal with increased use of
1758 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1759 parameter to begin_func member.
1760 (procedure_with_splits) Add "const struct ccase *" parameter to
1761 begin_func parameter. Make ccase parameter const in proc_func
1763 (split_procedure_case_func) Don't dump split file group. Pass
1765 (dump_splits) Moved to language/dictionary/split-file.c as
1766 output_split_file_values().
1767 (struct multipass_split_aux_data) Add "const struct ccase *"
1768 parameter to split_func member.
1769 (multipass_procedure_with_splits) Add "const struct ccase *"
1770 parameter to split_func parameter.
1771 (multipass_split_case_func) Save new SPLIT FILE case before
1773 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1775 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1777 Continue reforming procedure execution. Change
1778 internal_procedure() so that it calls open_active_file() and
1779 close_active_file(), which isolates most of the actual procedure
1782 * procedure.c: (struct write_case_data) Rename `proc_func' member
1783 to `case_func' and update all references.
1784 (procedure) Rewrite as one-line wrapper around
1785 internal_procedure().
1786 (struct multipass_aux_data) New.
1787 (multipass_callback) Renamed multipass_case_func(). Use struct
1788 multipass_aux_data as auxiliary data.
1789 (multipass_end_func) New function.
1790 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1791 that uses multipass_case_func, multipass_end_func.
1792 (internal_procedure) Add `end_func' argument. Move optimization
1793 of trivial case in here. Move call to open_active_file() and
1794 close_active_file() in here. Now assert that vfm_source is
1796 (procedure_with_splits_callback) Rename
1797 split_procedure_case_func().
1798 (split_procedure_end_func) New function.
1799 (multipass_split_callback) Rename multipass_split_case_func.
1800 (multipass_split_end_func) New function.
1801 (discard_variables) No need to test for nonnull vfm_source.
1803 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1805 Continue reforming procedure execution. Get rid of unused member.
1807 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1809 (write_case) Don't increment cases_analyzed.
1811 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1813 Continue reforming procedure execution. In this phase, move
1814 procedure.c and procedure.h from src to src/data. Update
1815 makefiles and #includes accordingly.
1817 * procedure.c: Moved here from src/.
1819 * procedure.h: Moved here from src/.
1821 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1823 Continue reforming procedure execution. In this phase, get rid of
1824 many global variables, consolidating procedure execution in
1825 procedure.c. Encapsulate transformations in new "struct
1826 trns_chain". Also, change implementation of N OF CASES, FILTER,
1827 and PROCESS IF from special cases to transformations.
1829 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1832 * dictionary.c: (global variable default_dict) Move to
1835 * variable.h: (TRNS_*) Move to transformations.h.
1836 (struct transformation) Move to transformations.c.
1838 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1840 * sys-file-reader.c: Fixed invalid read problems.
1842 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1844 * storage-stream.c: Add missing function comments.
1846 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1848 Continue reforming procedure execution. In this phase, add some
1849 new, needed functionality to storage-stream.
1851 * storage-stream.c: (storage_source_decapsulate) New function.
1853 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1855 * variable.c (width_to_bytes): Declarations must precede
1856 statements for C90 compliance.
1858 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1860 * data-out.c, data-in.c, variable.c, variable.h: New functions
1861 copy_mangle and copy_demangle for reading/writing cases; emulates the
1862 way SPSS deals with strings > 255 bytes.
1864 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1865 subtype 14 needed for strings longer than 255 bytes.
1867 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1868 instead of literal values. Also fixed some constness issues.
1870 * format.h: Constness
1872 * sfm-private.h: Renamed the case_size identifier, since I discovered
1873 that SPSS's respect for this variable is very nominal.
1875 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1877 Change case limit type from int to size_t.
1879 * dictionary.c: (struct dictionary) Change type of case_limit
1881 (dict_get_case_limit) Change return type.
1882 (dict_set_case_limit) Change parameter type.
1884 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1886 * variable.h: (struct variable) Rename `reinit' member as `leave'
1887 and invert sense. Fix up all references.
1889 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1891 Continue reforming procedure execution. In this phase, break
1892 procedure.c into multiple files.
1894 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1896 * case-sink.c: New file.
1898 * case-sink.h: New file.
1900 * case-source.c: New file.
1902 * case-source.h: New file.
1904 * storage-stream.c: New file.
1906 * storage-stream.h: New file.
1908 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1910 * variable.h: (struct variable) Remove `init' member and all
1911 references to it from other files. It was initialized in several
1912 places, but nothing really ever used it for anything worthwhile.
1913 Thanks to Jason Stover for pointing out how confusing this
1916 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1918 Continue reforming error message support. In this phase, get rid
1919 of message "titles" and put the message text in `struct error'.
1920 Now `struct error' encapsulates a message more properly.
1922 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1923 Format message ourselves.
1925 * data-in.c: (vdls_error) Ditto.
1927 * por-file-reader.c: (error) Ditto.
1929 * sys-file-reader.c: (corrupt_msg) Ditto.
1931 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1933 GNU standards require "file name" instead of "filename" in
1934 documentation. It's nice for our code to follow the convention
1937 * casefile.c: (struct casefile) Rename `filename' member to
1938 `file_name'. Updated all references.
1940 * file-name.c: [!unix] (struct file_identity) Rename
1941 normalized_filename member to normalized_file_name. Updated all
1944 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1946 We don't really support anything but Unix-like environments well,
1947 so we might as well de-obfuscate by writing directory and path
1948 separators explicitly.
1950 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1952 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1953 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1955 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1958 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1960 GNU standards require "file name" instead of "filename" in
1961 documentation. It's nice for our code to follow the convention
1964 * filename.c: Rename to file-name.c.
1966 * filename.h: Rename to file-name.h. Update all inclusions.
1967 Update header guards.
1969 * automake.mk: Update file names.
1971 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1973 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1975 (fn_basename) Removed (dead code).
1976 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1977 (fn_special_p) Renamed fn_is_special(), all references updated.
1978 (fn_exists_p) Renamed fn_exists(), all references updated.
1980 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1982 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1983 Also, now it only tilde-expands file names, not paths.
1984 (fn_search_path) Tilde-expand one directory at a time.
1986 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1988 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1989 get rid of non-Unixlike version of the code, which has probably
1991 (fn_prepend_dir) Removed (dead code).
1993 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1994 (macro PATH_SEPARATOR_STRING) New.
1995 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1997 Continue reforming error message support. In this phase, we get
1998 rid of VM() and the other msg() support for "verbosity", replacing
1999 it by a new function verbose_msg().
2001 * filename.c: (fn_search_path) Use verbose_msg() instead of
2004 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
2006 * sfm-private.h: Get rid of #defines after #error, which makes no
2009 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
2011 Get rid of our own int32 type in favor of the standard int32_t
2014 * sfm-private.h: (int32 macro) Don't define this anymore. Do
2017 * sys-file-reader.c: Use int32_t instead of int32 throughout.
2019 * sys-file-writer.c: Use int32_t instead of int32 throughout.
2021 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
2023 Remove ill-considered file routines that are no longer used.
2025 * filename.c: (fn_open_ext) Removed.
2026 (fn_close_ext) Removed.
2028 * filename.h: (struct file_ext) Removed.
2030 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
2032 * variable.c (var_is_valid_name): Move declarations before code
2035 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
2037 * filename.ch (fn_interp_vars): Fixed small buglet.
2039 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
2041 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
2042 so as to modify the string inline. Thus makeing it easier to
2043 destroy the results when no longer needed.
2045 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
2047 * category.c (cat_stored_values_destroy): Fixed memory leak.
2049 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
2051 Add some missing frees. Thanks to John Darrington for reporting
2054 * any-writer.c (any_writer_close): Free writer.
2056 * any-reader.c (any_reader_close): Free reader.
2058 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
2060 * por-file-reader.c: (error) Mark as NO_RETURN.
2062 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
2064 * settings.c: Changed default value of scompress to true.
2066 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
2068 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
2070 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
2073 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
2074 here from pref.h.orig.
2076 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
2078 * sys-file-reader.c: Fixed bug reading compressed files.
2080 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
2082 * Numerous renames. See src/ChangeLog for details.
2084 * Moved files from src directory