1 2007-07-22 Ben Pfaff <blp@gnu.org>
3 Don't try to write very long strings to portable files. The
4 format does not support it.
6 * por-file-writer.c (MAX_POR_WIDTH): New macro.
7 (pfm_open_writer): Limit output width to MAX_POR_WIDTH.
8 (write_format): Add arg to take width to resize format to.
9 (write_value): Limit width of value written to MAX_POR_WIDTH.
10 (write_variables): Limit width of variable and its output formats
13 2007-07-22 Ben Pfaff <blp@gnu.org>
15 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
16 local variable instead of literal 5.
18 2007-07-22 Ben Pfaff <blp@gnu.org>
20 Fix problems with uniqueness of short names in system files with
21 very long string variables. Now a variable may have multiple
24 * automake.mk (src_data_libdata_a_SOURCES): Add new files
25 short-names.c, short-names.h.
27 * dictionary.c (dict_clone): Clone all the short names.
28 (compare_strings): Move into short-names.c.
29 (hash_strings): Ditto.
30 (set_var_short_name_suffix): Ditto.
31 (dict_assign_short_names): Ditto, rename short_names_assign,
32 change to assign all short names.
34 * por-file-writer.c (write_variables): Use short_names_assign
35 instead of dict_assign_short_names.
37 * short-names.c: New file.
39 * short-names.h: New file.
41 * sys-file-private.c (sfm_width_to_segments): New function.
43 * sys-file-reader.c (read_long_var_name_map): Save and restore all
44 the short names, not just the first one.
46 * sys-file-writer.c (cont_var_name): Removed.
47 (sfm_open_writer): Use short_names_assign instead of
48 dict_assign_short_names. Use unique short names assigned by
49 short_names_assign instead of those generated by cont_var_name.
51 * variable.c (struct variable): Remove `short_name' member,
52 replace by `short_names' and `short_name_cnt'.
53 (var_create) Initialize new members.
54 (var_get_short_name_cnt): New function.
55 (var_get_short_name): Now takes an index argument. Changed most
57 (var_set_short_name): Ditto.
58 (var_clear_short_name): Renamed var_clear_short_names, changed to
59 clear all short names.
61 2007-07-22 Ben Pfaff <blp@gnu.org>
63 * variable.c (var_set_width): Use new var_set_width function.
65 * missing-values.c (mv_n_values): Drop assertion, which was not
68 * format.c (fmt_default_for_width): New function.
69 (fmt_resize): New function.
71 2007-07-18 John Darrington <john@darrington.wattle.id.au>
73 * datasheet.c (datasheet_delete_columns): Added assertion to check
74 we're not deleting outside the range of the sheet.
77 * dictionary.c dictionary.h variable.c: Added the ability for string
78 variables to be resized.
80 * vardict.h: Added some prototypes (moved from dictionary.h) as
81 these should only be called by variable.c
84 2007-07-14 John Darrington <john@darrington.wattle.id.au>
86 * sfm-reader.c: Respect case_cnt field in file header.
88 2007-07-01 John Darrington <john@darrington.wattle.id.au>
90 * transformation.c transformation.h (trns_chain_execute): Changed the
91 signature (Patch #6057)
93 2007-06-10 Ben Pfaff <blp@gnu.org>
95 * casereader-filter.c (casereader_filter_destroy): Make sure to
96 write all the remaining excluded cases to the casewriter, if any.
98 * caseinit.c (init_list_destroy): Rewrite.
99 (init_list_clear): Ditto.
101 * casegrouper.c (casegrouper_get_next_group): Always set *reader
102 to null when returning false.
104 2007-06-06 Ben Pfaff <blp@gnu.org>
106 Actually implement the new procedure code and adapt all of its
107 clients to match. Also adapt all of the other case sources and
108 sinks in the tree and their clients to use the
109 casereader/casewriter infrastructure.
111 * automake.mk: Add and remove files.
113 * any-reader.c: Change into a casereader.
114 * por-file-reader.c: Ditto.
115 * scratch-reader.c: Ditto.
116 * sys-file-reader.c: Ditto.
118 * any-writer.c: Change into a casewriter.
119 * por-file-writer.c: Ditto.
120 * scratch-writer.c: Ditto.
121 * sys-file-writer.c: Ditto.
123 * procedure.c: Change to use casereader, casewriter, caseinit, and
124 other new infrastructure.
126 * scratch-handle.c: Adapt to new infrastructure.
128 * case-sink.c: Removed, now dead code.
129 * case-sink.h: Ditto.
130 * case-source.c: Ditto.
131 * case-source.h: Ditto.
132 * casefile-factory.c: Ditto.
133 * casefile-private.h: Ditto.
136 * casefilter.c: Ditto.
137 * casefilter.h: Ditto.
140 * fastfile-factory.c: Ditto.
141 * fastfile-factory.h: Ditto.
142 * storage-stream.c: Ditto.
143 * storage-stream.h: Ditto.
145 2007-06-06 Ben Pfaff <blp@gnu.org>
149 * automake.mk: Add new files.
151 * datasheet.c: New file.
153 * datasheet.h: New file.
155 2007-06-06 Ben Pfaff <blp@gnu.org>
157 Until now, the procedure code has provided a case to the
158 case_source, which has filled in the data values that come from
159 the active file. "Left" data values that don't come from the
160 active file naturally stay the same from case to case, because the
161 procedure code keeps using that same case.
163 One of the compromises that comes with the new procedure code is
164 that the active file allocates and provides its own case, which
165 the procedure code then has to resize to provide room for any
166 other variables that should go in the case and then fill in the
167 values of "left" variables. Then, when we're done with that case,
168 we have to save the values of "left" variables to copy into the
169 next case read from the active file.
171 The caseinit code helps with this.
173 * automake.mk: Add new files.
175 * caseinit.c: New file.
177 * caseinit.h: New file.
179 2007-06-06 Ben Pfaff <blp@gnu.org>
181 * value.h (value_cnt_from_width): New function.
183 * variable.c (var_get_value_cnt): Use new function.
185 2007-06-06 Ben Pfaff <blp@gnu.org>
187 Add casegrouper, to allow cases read from a given casereader to be
188 broken into groups, each of which has its own casereader.
189 Generally cases are grouped based on having equal values for some
192 * automake.mk: Add new files.
194 * casegrouper.c: New file.
196 * casegrouper.h: New file.
198 2007-06-06 Ben Pfaff <blp@gnu.org>
200 Add interface to lexicographical ordering of cases.
202 * automake.mk: Add new files.
204 * case-ordering.c: New file.
206 * case-ordering.h: New file.
208 2007-06-06 Ben Pfaff <blp@gnu.org>
210 Add casereaders and casewriters, the basis of the new data processing
211 implementation. A casereader is a uniform interface to reading cases
212 from a data source; a casewriter is a uniform interface to writing
213 cases to a data sink.
215 * automake.mk: Add new files.
217 * casereader-filter.c: New file.
219 * casereader-provider.h: New file.
221 * casereader-translator.c: New file.
223 * casereader.c: New file.
225 * casereader.h: New file.
227 * casewriter-provider.h: New file.
229 * casewriter-translator.c: New file.
231 * casewriter.c: New file.
233 * casewriter.h: New file.
235 2007-06-06 Ben Pfaff <blp@gnu.org>
237 "casewindow" data structure that extends the deque (from libpspp)
238 of cases with the ability to dump cases to disk if we get too many
241 * automake.mk: Add new files.
243 * casewindow.c: New file.
245 * casewindow.h: New file.
247 2007-06-06 Ben Pfaff <blp@gnu.org>
249 sparse_cases data structure that augments a sparse_array of cases
250 with the ability to dump cases to disk if we get too many cases in
253 * automake.mk: Add new files.
255 * sparse-cases.c: New file.
257 * sparse-cases.h: New file.
259 2007-06-06 Ben Pfaff <blp@gnu.org>
261 Adds a low-level on-disk case array data structure.
263 * automake.mk: Add new files.
265 * case-tmpfile.c: New file.
267 * case-tmpfile.h: New file.
269 2007-06-06 Ben Pfaff <blp@gnu.org>
271 In a couple of places we calculate the maximum number of cases to
272 keep in memory based on the user-defined workspace. Enable
273 centralizing the calculation through a new function.
275 * settings.c (get_workspace_cases): New function.
277 2007-06-06 Ben Pfaff <blp@gnu.org>
279 The casenumber type is defined in transformations.h, but case.h is
280 a more sensible place. Move it.
282 * case.h (CASENUMBER_MAX): New macro.
283 (typedef casenumber): Move here, from transformations.h.
285 2007-06-03 Ben Pfaff <blp@gnu.org>
287 Slightly generalize case_to_values and case_from_values functions.
289 * case.c (case_to_values): Rename case_copy_out, change interface.
290 (case_from_values): Rename case_copy_in, change interface.
292 * fastfile.c (fastfilereader_get_next_case): Update caller.
293 (write_case_to_disk): Ditto.
295 2007-06-02 Ben Pfaff <blp@gnu.org>
297 Clean up after a forgotten part of patch #5829.
299 * casedeque.h: Remove unused file.
301 * automake.mk: Remove casedeque.h from sources.
303 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
305 * category.c: Removed redundant #include
307 2007-05-06 Ben Pfaff <blp@gnu.org>
309 Abstract the documents within a dictionary a little better.
310 Thanks to John Darrington for suggestion, initial version, and
313 * dictionary.c (struct dictionary): Change `documents' member from
314 char * to struct string.
315 (dict_clear): Destroy struct string.
316 (dict_get_documents): Convert struct string to char *.
317 (dict_set_documents): Set struct string. Pad to 80-character
319 (dict_clear_documents): New function.
320 (dict_add_document_line): New function.
321 (dict_get_document_line_cnt): New function.
322 (dict_get_document_line): New function.
324 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
326 * sys-file-reader.c (read_documents): Use new document functions.
328 2007-04-19 John Darrington <john@darrington.wattle.id.au>
330 * sys-file-reader.c: When reading a system file which has no
331 long name table, automatically create one where the long names
332 are the lower case versions of the short names.
334 2007-04-22 Ben Pfaff <blp@gnu.org>
336 * dictionary.c (dict_set_split_vars): dict_destroy expects that
337 dict_clear will free most data related to the dictionary.
338 dict_clear does a decent job, except that dict_set_split_vars on
339 some systems won't actually free the dict's "split" member.
340 Instead, it'll allocate a 1-byte region. Fix this.
342 * value.c (value_copy): New function.
343 (value_set_missing): Ditto.
345 2007-04-22 John Darrington <john@darrington.wattle.id.au>
347 * Deleted existing category.h and moved cat-routines.h into
348 category.h Encapsulated struct cat_vals better.
350 2007-04-19 John Darrington <john@darrington.wattle.id.au>
352 * sys-file-reader.c: When reading a system file which has no
353 long name table, automatically create one where the long names
354 are the lower case versions of the short names.
356 2007-04-16 John Darrington <john@darrington.wattle.id.au>
358 * sys-file-reader.c: Some versions of Other Software seem to
359 produce system files with string variables' measure set to
360 zero. We'll assume these are supposed to be nominal variables.
362 2007-03-30 Ben Pfaff <blp@gnu.org>
364 * procedure.c: Adapt to new deque data structure.
366 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
367 Ben Pfaff <blp@gnu.org>
369 * file-name.c: Mingw compatibility fixes.
370 (fn_search_path): Use ISSLASH instead of comparing against '/'
372 (fn_dir_name): Use dir_name from gnulib.
373 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
374 (fn_get_identity): Use GetFullPathName instead of canonicalize
375 from gnulib, because the latter does not fully support
376 Windows-style path names. Use this implementation based on the
377 detected presence of Windows instead of the absence of Unix, since
378 the new implementation is Windows-specific.
379 (fn_compare_file_identities): In Windows implementation, compare
380 names case-insensitively.
382 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
384 * make-file.c: Don't include mkstemp.h, because gnulib now causes
385 <stdlib.h> to have the same effect.
387 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
389 * por-file-reader.c: Add missing _() around messages.
391 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
393 * make-file.c: Include "mkstemp.h", without which linking on
396 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
398 Reduce platform dependence.
400 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
401 Everywhere we using this, we really should have just depended on
402 the shell to expand tildes.
403 (fn_search_path): Simplify, given that we don't do tilde expansion
405 (fn_normalize): Removed. Caller changed to use the canonicalize
407 (fn_get_cwd): Removed. Only user was fn_normalize.
408 (fn_is_absolute): Really only test for absolute names.
409 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
411 (fn_readlink): Removed, as it was only used fn_normalize.
412 (fn_exists): Assume the stat function is available; gnulib does.
413 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
415 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
417 * dictionary.c (dict_create_vector_assert): New function.
419 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
421 * file-name.c (fn_normalize): Correct name of function
422 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
423 for pointing this out.
425 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
427 We are using a single member in struct file_handle, the "name"
428 field, for more than one purpose. When it begins with '"', it's a
429 file name; otherwise, it's a token that can be used to identify
430 it. When that assertion fires, it's because we searched for the
431 name case-sensitively as a file name (so that there was no match),
432 and then we try to insert it case-insensitively as a token, which
433 fails because duplicates aren't allowed.
435 Solution: break the two purposes into two separate fields. This
436 fixes the problem and likely makes the code easier to read too.
438 Fixes bug #18922. Thanks to John Darrington for bug report and
441 * file-handle-def.c (struct file_handle): New `id' member.
442 (fh_from_name): Rename fh_from_id. Update all callers.
443 (create_handle): New `id' parameter. Update all callers.
444 (fh_create_file): Ditto.
445 (fh_get_id): New function.
447 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
449 * case.c (case_is_null): Change return type to bool.
451 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
455 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
456 reference counting to share data. This makes it easy for
457 valgrind, etc. to find accesses to cases that have been destroyed
458 but have been kept around by another user's ref-count. This often
459 happens when the data set is small enough to find in memory; if a
460 bigger data set that would overflow to disk were used, then data
461 corruption would occur.
463 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
467 * case.c (case_unshare): Make it check internally whether the
468 ref_cnt is greater than 1, so that the callers don't have to.
469 Update callers not to check.
471 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
473 Before, I was thinking that I might want to get rid of reference
474 counting at some point. Now, I'm pretty sure that it's here to
475 stay. Thus, because we have to store the value_cnt anyway for
476 reference-counted cases, we might as well expose it to users.
478 * case.c (case_get_value_cnt): New function.
479 (case_resize): Drop OLD_CNT argument. Update all callers. Only
480 resize case if its size actually changed.
482 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
483 instead of peeking inside struct case directly.
484 (casefile_append): Ditto.
486 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
488 Get rid of the inlines for the case functions, which made the
489 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
490 the inlines didn't speed up "make check" at all, which is not a
491 perfect benchmark but seems indicative.)
493 * case.c: Remove #ifdef DEBUGGING...#endif around many function
494 definitions. Remove some assertions on nonnull pointers that were
495 redundant with a pointer dereference soon after in the function.
497 (struct case_data): Move definition here from case.h.
501 (case_data_wr): Ditto.
503 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
505 * automake.mk: Add casedeque.h to sources.
507 * casedeque.h: New file.
509 * procedure.c: (struct dataset) Change lag_count, lag_head,
510 lag_queue member into single struct casedeque member. Update all
511 users to use the casedeque instead.
514 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
516 * procedure.c: Simplify lagged cases interface. Updated all
517 clients--well, the only client--to use the simplified interface.
518 (dataset_n_lag) Removed.
519 (dataset_set_n_lag) Removed.
520 (dataset_need_lag) New function.
522 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
524 * dictionary.c procedure.c: More changes to ensure that callbacks occur
525 whenever appropriate, but only when the dataset/dictionary is in a
528 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
530 * dictionary.c dictionary.h : Added callbacks for change of filter and
531 split variables. Refactored some code to ensure that callbacks get
532 invoked when appropriate.
534 * procedure.c (proc_cancel_temporary_transformations): Make sure that
535 replace_dict callback occurs when permanent_dict replaces the current
538 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
540 * dictionary.c dictionary.h : Added callback for when the weight
541 variable of a dictionary changes.
543 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
545 * dictionary.c dictionary.h : Added replace_source and replace_dict
546 callbacks, and functions to deal with them.
548 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
550 Simplify missing value handling.
552 * missing-values.h (enum mv_class): New type.
553 (enum mv_type): Moved definition into missing-values.c and renamed
554 each MV_* to MVT_*, to distinguish them from the exposed mv_class
555 enums. Updated all uses.
556 (struct missing_values): Changed type of `type' from `enum
557 mv_type' to `int' because the definition is no longer exposed.
559 * missing-values.c (mv_is_value_missing): Add new enum mv_class
560 parameter. Update all callers.
561 (mv_is_num_missing): Ditto.
562 (mv_is_str_missing): Ditto.
563 (mv_is_value_user_missing): Removed. Changed callers to use
565 (mv_is_num_user_missing): Removed. Changed callers to use
567 (mv_is_str_user_missing): Removed. Changed callers to use
569 (mv_is_value_system_missing): Removed. Changed callers to use
571 (mv_set_type): Removed. Changed callers to use mv_clear.
572 (mv_clear): New function.
574 * variable.c (var_is_value_missing): Add new enum mv_class
575 parameter. Update all callers.
576 (var_is_num_missing): Ditto.
577 (var_is_str_missing): Ditto.
578 (var_is_value_user_missing): Removed. Changed callers to use
579 var_is_value_missing.
580 (var_is_num_user_missing): Removed. Changed callers to use
582 (var_is_str_user_missing): Removed. Changed callers to use
584 (var_is_value_system_missing): Removed. Changed callers to use
585 var_is_value_missing.
587 * casefilter.c (struct casefilter): Use enum mv_class in place of
589 (casefilter_variable_missing): Adapt to new member.
590 (casefilter_create): Change signature to take enum mv_class,
593 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
595 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
597 * case-sink.c case-sink.h procedure.c procedure.h
598 storage-stream.c: Now uses the factory.
600 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
602 Make it possible to pull cases from the active file with a
603 function call, instead of requiring indirection through a callback
606 * case-source.h (struct case_source_class): Change ->read function
607 to return a single case, instead of calling a callback function
608 for each case. Change ->destroy function to return an error
611 * case-source.c (free_case_source): Pass along the value returned
612 by the case_source ->destroy function.
614 * procedure.c (struct write_case_data): Removed.
615 (struct dataset): Added some members to track procedure state.
616 (procedure): Optimize the trivial case at this level.
617 (internal_procedure): Re-implement in terms of proc_open,
618 proc_read, proc_close.
619 (proc_open) New function.
620 (proc_read) New function.
621 (proc_close) New function.
622 (write_case) Moved into proc_read.
623 (close_active_file) Moved closing of data source into proc_close.
625 * storage-source.c: Rewrote to conform with modified
626 case_source_class interface.
628 * transformations.c (trns_chain_execute): Added argument to allow
629 starting execution from an arbitrary transformation. Updated
632 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
634 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
636 * sys-file-reader.c (read_display_parameters): Don't assume that
637 MEASURE_* and ALIGN_* have the same values found in system files.
639 * sys-file-writer.c (write_variable_display_parameters): Ditto.
641 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
642 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
643 the value of n_MEASURES, which was off by 1 (at least from my
646 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
648 * dictionary.c dictionary.h vardict.h variable.c: Added optional
649 callbacks which are invoked when the dictionary or its
650 variables are changed.
652 * missing-values.c missing-values.h value-labels.c: Tidied up
653 consistency checks, and made some of them return false
654 instead of assert-failing.
656 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
658 * calendar.c (calendar_days_in_month): New function.
660 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
662 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
663 the value label's width.
665 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
667 * sfm-private.h: Move contents into sys-file-writer.c, which is
668 the only remaining user. Removed Borland C++-specific directives.
670 * sys-file-reader.c: Clean up and rewrite entire file. The
671 rewritten version is simpler and better abstracted, and should be
672 easier to maintain and extend. It avoids using structures to read
673 file data, which is prone to padding variations among compilers.
674 It should also handle non-IEEE 754 system files, although I
675 haven't been able to find any. It has been tested against many
676 .sav files obtained from the Web and found to produce the same
677 results as the earlier version of the code, or in some cases
678 improved results. It is more tolerant of format variations found
681 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
682 member, putting an enum integer_format in its place. New member
683 `float_format'. Changed `compressed' member to type bool.
685 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
687 * dictionary.c (dict_delete_consecutive_vars): New function.
689 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
691 * file-name.c (fn_search_path): Remove prefix arg that was unused
692 by any caller. Updated all callers.
694 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
696 * format.c (fmt_dollar_template): Use user's decimal point
697 character. Add assertion.
699 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
701 * format.c (fmt_dollar_template): New function, based on
702 dollar_format_template from var-type-dialog.c.
704 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
706 * data-out.c (output_scientific): Fix bad assumption that "buf" is
709 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
711 Finish converting struct variable to an opaque type. In this
712 phase, we add remaining setter and getter functions, convert the
713 remaining PSPP code to use them, and do a bunch of cleanup. The
714 resulting changes are pervasive but mostly trivial, and only the
715 notable changes are logged.
717 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
720 * case.c (case_data): Renamed case_data_idx.
721 (case_num): Renamed case_num_idx.
722 (case_str): Renamed case_str_idx.
723 (case_data_rw): Renamed case_data_rw_idx.
725 * case.h (case_data): New function with old name and an interface
726 that takes a variable instead of an index, which is easier to
727 use. Updated all callers to use the new interface, or to use the
728 new *_idx function (see above).
731 (case_data_rw): Ditto.
733 * category.c (cat_stored_values_destroy): Changed interface to
734 take a struct cat_vals * instead of a struct variable *.
736 * dictionary.c (dict_clone): Use new vector_clone function.
737 (dict_clear) Use new var_destroy function.
738 (add_var) New function.
739 (dict_create_var) Rewrite in terms of dict_create_var_assert.
740 (dict_create_var_assert) Rewrite in terms of add_var.
741 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
742 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
743 (dict_lookup_var) Use new var_create, var_destroy functions.
744 (dict_contains_var) Rewrite in terms of new vardict functionality.
745 (set_var_dict_index) New function.
746 (set_var_case_index) New function.
747 (reindex_vars) New function.
748 (dict_delete_var) Rewrite in terms of new vardict functionality.
749 (dict_reorder_var) Ditto.
750 (dict_reorder_vars) Ditto.
751 (rename_var) New function.
752 (dict_rename_var) Use rename_var.
753 (dict_rename_vars) Use pool to simplify code. Use rename_var.
754 (dict_get_compacted_idx_to_fv) Rename
755 dict_get_compacted_dict_index_to_case_index, update callers.
756 (dict_create_vector) Use new vector_create function.
757 (dict_clear_vectors) Use new vector_destroy function.
758 (set_var_short_name_suffix) Move here from variable.c, renamed
759 from var_set_short_name_suffix, make static, update caller.
761 * sys-file-private.c: New file.
762 (sfm_width_to_bytes) Moved here from variable.c, renamed from
763 width_to_bytes, update callers.
765 * sys-file-private.h: New file. Later it will supplant
766 sfm-private.h; for now it supplements it.
767 (macro MIN_VERY_LONG_STRING) New macro.
768 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
770 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
771 MAX_LONG_STRING was used before.
773 * sys-file-writer.c: Ditto.
775 * value-labels.c: Change the paradigm here to be that a null
776 pointer is OK for a struct val_labs * in most cases; it just
777 represents an empty set of value labels.
778 (val_labs_copy) A copy of a null set is a null set.
779 (val_labs_count) A null set has 0 labels.
780 (val_labs_replace) Change return type to void. Rewrite for
782 (val_labs_find) A null set does not contain the value.
783 (value_to_string) Moved to variable.c, renamed var_get_value_name,
784 transposed argument order, updated all callers.
787 (value_dup) Moved here from variable.c.
788 (compare_values) Ditto.
791 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
792 (macro MAX_LONG_STRING) Removed, because it was only interesting
793 for system files, not for general code.
794 (macro MAX_VERY_LONG_STRING) Ditto.
795 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
796 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
798 * vardict.h: New file, for an interface between variables and
801 * variable.c: A lot of functions were moved around, for better
803 (struct variable) Move definition here, from variable.h.
804 (var_type_adj) Removed--makes i18n hard.
805 (var_type_noun) Ditto.
806 (var_create) New function.
807 (var_clone) New function.
808 (var_destroy) New function.
809 (var_set_name) Assert that variable is not in a dictionary.
810 (compare_var_names) Rename compare_vars_by_name and fix a couple
811 of callers who thought the args were strings.
812 (hash_var_name) Rename hash_var_by_name.
813 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
814 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
815 (var_is_very_long_string) Removed, because it was only interesting
817 (var_set_missing_values) Allow the argument to be the wrong width,
818 as long as we can resize it. Simplify callers who were doing the
820 (var_get_value_labels) New function.
821 (var_has_value_labels) New function.
822 (var_set_value_labels) New function.
823 (alloc_value_labels) New function.
824 (var_add_value_label) New function.
825 (var_replace_value_label) New function.
826 (var_clear_value_labels) New function.
827 (var_lookup_value_label) New function.
828 (var_get_value_name) Moved here from variable.c, renamed from
829 var_get_value_name, transposed argument order, updated all
831 (var_to_string) Moved here, from variable-label.c.
832 (var_set_leave) New function.
833 (var_get_leave) New function.
834 (var_must_leave) New function.
835 (var_set_short_name_suffix) Moved to dictionary.c, renamed
836 set_var_short_name_suffix.
837 (var_get_dict_index) New function.
838 (var_get_case_index) New function.
839 (var_get_obs_vals) New function.
840 (var_set_obs_vals) New function.
841 (var_has_obs_vals) New function.
842 (var_get_vardict) New function.
843 (var_set_vardict) New function.
844 (var_has_vardict) New function.
845 (var_clear_vardict) New function.
846 (value_dup) Moved to value.c.
847 (compare_values) Ditto.
850 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
851 (enum ALPHA) Rename VAR_STRING, update all users.
853 * vector.c: New file.
854 (struct vector) Moved here, from variable.h.
855 (check_widths) New function.
856 (vector_create) New function.
857 (vector_clone) New function.
858 (vector_destroy) New function.
859 (vector_get_name) New function.
860 (vector_get_var) New function.
861 (vector_get_var_cnt) New function.
862 (compare_vector_ptrs_by_name) New function.
864 * vector.h: New file.
866 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
868 * casefilter.c (casefilter_variable_missing): Avoided comparision of
869 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
872 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
874 * value-labels.c (destroy_atoms): New function.
875 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
877 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
879 Thanks to Jason Stover for pointing out this problem.
881 * data-out.c (output_number): Use gsl_finite from GSL, which is
882 portable, instead of isfinite, which is not.
885 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
887 * variable.c variable.h (value_dup): New function.
889 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
891 Start converting struct variable to an opaque type. In this
892 phase, we add a bunch of setter and getter functions and convert
893 most of the PSPP code to use them. The resulting changes are
894 pervasive but mostly trivial, and only the notable changes are
897 * format.c (fmt_equal): New function.
899 * variable.c (var_type_is_valid): New function.
900 (measure_is_valid) Moved here, from format.c.
901 (alignment_is_valid) Moved here, from format.c.
902 (var_get_name) New function.
903 (var_set_name) New function.
904 (width_to_type) New function.
905 (var_get_type) New function.
906 (var_get_width) New function.
907 (var_set_width) New function.
908 (var_is_numeric) New function.
909 (var_is_alpha) New function.
910 (var_is_short_string) New function.
911 (var_is_long_string) New function.
912 (var_is_very_long_string) New function.
913 (var_get_missing_values) New function.
914 (var_set_missing_values) New function.
915 (var_clear_missing_values) New function.
916 (var_has_missing_values) New function.
917 (var_is_value_missing) New function.
918 (var_is_num_missing) New function.
919 (var_is_str_missing) New function.
920 (var_is_value_user_missing) New function.
921 (var_is_num_user_missing) New function.
922 (var_is_str_user_missing) New function.
923 (var_is_value_system_missing) New function.
924 (var_get_print_format) New function.
925 (var_set_print_format) New function.
926 (var_get_write_format) New function.
927 (var_set_write_format) New function.
928 (var_set_both_formats) New function.
929 (var_get_label) New function.
930 (var_set_label) New function.
931 (var_clear_label) New function.
932 (var_has_label) New function.
933 (var_get_measure) New function.
934 (var_set_measure) New function.
935 (var_get_display_width) New function.
936 (var_set_display_width) New function.
937 (var_get_alignment) New function.
938 (var_set_alignment) New function.
939 (var_get_value_cnt) New function.
940 (var_get_leave) New function.
941 (var_get_short_name) New function.
943 * variable.h: (struct variable) Removed "type" and "nv" members;
944 they are now computed from "width" where needed.
946 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
948 * missing-values.c (mv_resize): Don't write beyond end of the
949 allocated buffer when resizing a long string.
951 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
953 Clean up identifier code: don't require identifier enumerations to
954 be in a particular order; make better use of string library;
955 expose less of the internals.
957 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
958 change interface. Updated all callers.
959 (lex_id_match) Change interface to use struct substring, update
961 (lex_id_match_len) Removed. Update callers to use lex_id_match.
962 (global array keywords[]) Make static, change form. Update all
963 users to use lex_id_name instead.
964 (lex_is_keyword) New function.
965 (lex_id_to_token) Change interface to use struct substring, update
967 (lex_id_name) New function.
969 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
970 lex_is_keyword instead.
971 (T_LAST_KEYWORD) Removed.
972 (T_N_KEYWORDS) Removed.
974 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
976 * format.c: (fmt_date_template) Distinguish characters for which a
977 space is output and any date delimiter is allowed on input, from
978 those for which a space is output and only a space is allowed on
979 input. The former is represented by X, the latter by a space.
980 Also, drop distinction between h and H, changing the former to the
983 * data-in.c: Completely rewrite internals to conform to SPSS input
984 formats as closely as possible.
985 (data_in) Changed external interface by replacing the structure
986 that was used as a single argument by a set of arguments. Updated
988 (data_in_finite_line) Removed. Converted all callers to use plain
990 (data_in_get_integer_format) New function.
991 (data_in_set_integer_format) New function.
992 (data_in_get_float_format) New function.
993 (data_in_set_float_format) New function.
995 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
996 (struct data_in) Removed.
998 * data-out.c: (output_date) Drop each component from the input as
999 it is output, to allow us to drop the distinction between h (a
1000 count of hours) and H (the hour of day) template characters.
1001 Also, handle new X template character.
1002 (output_scientific) Follow more rational rule on when to drop
1003 fraction introduced between SPSS 13 and 15. Updated test case to
1006 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
1008 Fix buffer overflow reported by John Darrington.
1010 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
1011 realize that DIGITS is a count of nibbles, not of bytes.
1013 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1015 * calendar.c (calendar_offset_to_gregorian) Also return the
1016 year-of-day. Change callers to new interface.
1018 * data-out.c: Completely rewrite internals to conform to SPSS
1019 output formats as completely as possible.
1020 (data_out) Change interface to put input parameters before output
1021 parameters, for consistency with the style I now prefer. Update
1023 (data_out_get_integer_format) New public function.
1024 (data_out_set_integer_format) New public function.
1025 (data_out_get_float_format) New public function.
1026 (data_out_set_float_format) New public function.
1028 * data-out.h: New file. Move prototype for data_out here, from
1031 * format.c: (fmt_step_width) Use equality comparison instead of
1032 bitwise and, for clarity.
1033 (fmt_is_string) Ditto.
1034 (fmt_input_to_output) Fix categories that are translated to F
1037 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1039 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1040 casefile-private.h: Added casefilter to assist commands with missing
1043 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1045 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1047 * settings.c: (route_errors_to_terminal) New variable.
1048 (route_errors_to_listing) New variable.
1049 (get_error_routing_to_terminal) New function.
1050 (set_error_routing_to_terminal) New function.
1051 (get_error_routing_to_listing) New function.
1052 (set_error_routing_to_listing) New function.
1054 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1056 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1058 * format.c: Completely rewrite, to achieve better abstraction.
1059 Rewrite all references to formats in other files.
1061 * format.def: Rewrite and reorganize.
1063 * settings.c: Move everything related to custom currency formats
1064 into format.[ch], changing them in form, so as to group related
1065 code and definitions better. Changed all references to use the
1067 (static var decimal) Removed.
1068 (static var grouping) Removed.
1069 (static var cc) Removed.
1070 (get_decimal) Removed.
1071 (set_decimal) Removed.
1072 (get_grouping) Removed.
1073 (set_grouping) Removed.
1077 * settings.h: (macro CC_CNT) Removed.
1078 (macro CC_WIDTH) Removed.
1079 (struct custom_currency) Removed.
1081 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1083 * data-in.c (data_in): Use switch statement instead of table, to
1084 avoid dependence on the order of the FMT_* enums.
1086 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1088 * data-out.c: (num_to_string) Removed, because it was dead code.
1090 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1092 * data-in.c (parse_trailer): Fix error message.
1094 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1096 * format.c (fmt_is_binary): New function.
1098 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1100 * procedure.c procedure.h: Encapsulated the static data into a single
1103 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1105 * casefile.c (casereader_read_xfer): Always initialize the case,
1106 even on an error condition.
1108 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1110 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1111 entire function useless.
1113 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1115 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1116 casereader method casereader_clone.
1118 * procedure.c pransformations.h: Introduced new type casenum_t
1120 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1122 * variable.c: (width_to_bytes) Rephrase code for clarify.
1124 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1126 * format.c: (fmt_type_from_string) New function.
1127 (fmt_to_string) Include decimals in output if the format has
1128 decimals, even if the format type does not. This way, we can
1129 accurately reproduce incorrect formats in user output.
1130 (check_common_specifier) Make the check for a bad format type an
1131 assertion, so we get bug reports if they show up. Fix message.
1132 Check for decimal places with a format type that doesn't allow
1134 (check_input_specifier) Remove check for FMT_X, which has been
1136 (check_output_specifier) Ditto.
1138 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1140 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1141 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1142 (enum fmt_parse_flags) Removed.
1144 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1146 * casefile.c casefile.h: Converted to an abstract base class.
1147 * casefile-private.h fastfile.c fastfile.h: New files.
1148 * automake.mk procedure.c scratch-writer.c storage-stream.c
1150 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1152 * procedure.c (internal_procedure): Create sink_case with only as
1153 many values as the compacted dictionary.
1155 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1157 Remove "debugging" code that caused plenty of false positives and
1160 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1162 * case.c: Remove all references to `this' member.
1164 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1166 Fix link error noted by Jason Stover.
1168 * storage-stream.c: Include <assert.h>.
1170 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1172 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1173 ALL) and additional underlying system file issues.
1175 Thanks to John Darrington for review.
1177 First problem: var_hash points to variables not owned by the
1178 sys-file-reader, which the caller may free or modify. Use an
1179 array of sfm_vars instead, as done earlier (e.g. CVS version
1182 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1183 members and remove all code that references it. Add vars, var_cnt
1184 members. Remove fix_specials member, which was unused.
1185 (struct sfm_var) Remove name member, which was unused.
1186 (sfm_close_reader) Free vars member instead of var_hash.
1187 (compare_var_shortnames) Removed.
1188 (hash_var_shortname) Removed.
1189 (sfm_open_reader) Fill out vars array.
1190 (compare_var_index) Removed.
1191 (sfm_read_case) Use vars instead of var_hash.
1193 Second problem: we're confused about when we actually have very
1194 long strings, causing us to choose incorrectly between slow path
1195 and fast path in sfm_read_case.
1197 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1198 have very long strings, not when we have long variable names,
1199 which is an unrelated feature.
1201 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1203 * variable.h: Move var_set and variable parsing declarations to
1204 new header, src/language/lexer/variable-parser.h. Modified lots
1205 of files to include the new header.
1207 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1209 * value-labels.c (value_to_string): When there's no value label,
1210 format the variable according to its print format, instead of
1211 always effectively using A or F format.
1213 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1215 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1218 * format.c: Removed tortological assertion.
1220 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1222 Reform string library.
1224 * file-name.c (fn_interp_vars): Change interface to take a
1225 substring as input. Updated all users.
1227 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1229 * format.c (measure_is_valid): Really return false when m >=
1232 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1234 Implement random access to casefiles, for use in GUI.
1236 * casefile.c: (struct casereader) Add `random', `file_ofs',
1237 `buffer_ofs' members.
1238 (casefile_get_random_reader) New function.
1239 (read_open_file) Break part into new function
1240 seek_and_fill_buffer().
1241 (fill_buffer) Update buffer_ofs, file_ofs.
1242 (casereader_seek) New function.
1244 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1246 * settings.c: Added call to i18n{done, init}.
1248 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1250 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1253 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1255 * casefile.c: Convert many uses of `int' to `bool'.
1257 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1259 * transformations.c (trns_chain_destroy): Destroy chain's trns
1260 member, to fix memory leak.
1262 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1264 * storage-stream.c (storage_source_decapsulate): Destroy case
1265 source to fix memory leak.
1267 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1269 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1270 case passed as argument instead of initializing the argument as a
1271 case. Fixes memory leak that showed up in
1272 tests/command/aggregate.sh with scratch files.
1274 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1276 * procedure.c (proc_done): Destroy default_dict, to fix memory
1279 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1281 Simplify procedure_with_splits().
1283 * procedure.c (struct split_aux_data): Removed case_count member.
1284 (procedure_with_splits) Don't initialize case_count.
1285 (split_procedure_case_func) Check whether prev_case is null
1286 instead of case_count.
1287 (split_procedure_end_func) Ditto.
1289 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1291 * case.c (case_move): Do nothing if dst and src are the same
1293 (case_try_create) Merge two similar cases.
1294 (case_copy) Unshare only if data must be actually copied.
1296 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1298 * data-in.c data-out.c dictionary.c sys-file-reader.c
1299 sys-file-writer.c variable.c variable.h: Reworked very long string
1300 support for better encapsulation.
1302 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1304 * value-labels.c (val_labs_can_set_width): New function.
1305 (val_labs_set_width) Clear labels if increasing width to long
1307 (val_labs_destroy) Remove unneeded test for null.
1309 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1311 * value-labels.h: Remove unneeded dependency on variable.h.
1313 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1315 Get rid of `char *c' member in union value, for cleanliness.
1317 * value.h: (union value) Remove `c' member.
1319 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1321 Make dictionary compacting functions a little more general.
1323 * sys-file-writer.c (sfm_open_writer): Use
1324 dict_compacting_would_change().
1325 (does_dict_need_translation) Removed.
1327 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1329 Make dictionary compacting functions a little more general.
1331 * dictionary.c (dict_needs_compaction): Rename
1332 dict_compacting_would_shrink(). Update all callers.
1333 (dict_compacting_would_change) New function.
1335 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1337 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1338 inverted return value (!).
1340 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1342 Continue reforming procedure execution.
1344 * procedure.c: Search and replace "vfm" by "proc". Notably:
1345 (static var vfm_source) Rename proc_source. Update all
1347 (static var vfm_sink) Rename proc_sink. Update all references.
1349 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1351 Continue reforming procedure execution. In this phase, remove
1352 PROCESS IF, which was deprecated anyway and can be easily
1353 simulated with TEMPORARY followed by SELECT IF.
1355 * procedure.c: (open_active_file) Don't call
1356 add_process_if_trns().
1357 (discard_variables) Get rid of redundant call to
1358 proc_cancel_all_transformations().
1359 (add_process_if_trns) Removed.
1360 (process_if_trns_proc) Removed.
1361 (process_if_trns_free) Removed.
1363 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1365 Continue reforming procedure execution. In this phase, add
1366 `const' to the case passed to procedure()'s callback.
1368 Updated all users of procedure() as well.
1370 * procedure.c: (struct write_case_data) Add "const" to ccase
1371 parameter for case_func member.
1372 (procedure) Add "const" to ccase parameter for proc_func
1374 (multipass_case_func) Make ccase parameter const.
1375 (internal_procedure) Add "const" to ccase parameter for case_func
1377 (split_procedure_case_func) Make ccase parameter const.
1378 (multipass_split_case_func) Make ccase parameter const.
1380 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1382 Continue reforming procedure execution. In this phase, get rid of
1383 the output code for SPLIT FILE groups in procedure.c, which really
1384 shouldn't be doing any output. Move it into the individual
1385 procedures instead. This also adds some flexibility.
1387 Updated many users of procedure_with_splits() and
1388 multipass_procedure_with_splits() to call
1389 output_split_file_values() and to deal with increased use of
1392 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1393 parameter to begin_func member.
1394 (procedure_with_splits) Add "const struct ccase *" parameter to
1395 begin_func parameter. Make ccase parameter const in proc_func
1397 (split_procedure_case_func) Don't dump split file group. Pass
1399 (dump_splits) Moved to language/dictionary/split-file.c as
1400 output_split_file_values().
1401 (struct multipass_split_aux_data) Add "const struct ccase *"
1402 parameter to split_func member.
1403 (multipass_procedure_with_splits) Add "const struct ccase *"
1404 parameter to split_func parameter.
1405 (multipass_split_case_func) Save new SPLIT FILE case before
1407 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1409 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1411 Continue reforming procedure execution. Change
1412 internal_procedure() so that it calls open_active_file() and
1413 close_active_file(), which isolates most of the actual procedure
1416 * procedure.c: (struct write_case_data) Rename `proc_func' member
1417 to `case_func' and update all references.
1418 (procedure) Rewrite as one-line wrapper around
1419 internal_procedure().
1420 (struct multipass_aux_data) New.
1421 (multipass_callback) Renamed multipass_case_func(). Use struct
1422 multipass_aux_data as auxiliary data.
1423 (multipass_end_func) New function.
1424 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1425 that uses multipass_case_func, multipass_end_func.
1426 (internal_procedure) Add `end_func' argument. Move optimization
1427 of trivial case in here. Move call to open_active_file() and
1428 close_active_file() in here. Now assert that vfm_source is
1430 (procedure_with_splits_callback) Rename
1431 split_procedure_case_func().
1432 (split_procedure_end_func) New function.
1433 (multipass_split_callback) Rename multipass_split_case_func.
1434 (multipass_split_end_func) New function.
1435 (discard_variables) No need to test for nonnull vfm_source.
1437 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1439 Continue reforming procedure execution. Get rid of unused member.
1441 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1443 (write_case) Don't increment cases_analyzed.
1445 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1447 Continue reforming procedure execution. In this phase, move
1448 procedure.c and procedure.h from src to src/data. Update
1449 makefiles and #includes accordingly.
1451 * procedure.c: Moved here from src/.
1453 * procedure.h: Moved here from src/.
1455 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1457 Continue reforming procedure execution. In this phase, get rid of
1458 many global variables, consolidating procedure execution in
1459 procedure.c. Encapsulate transformations in new "struct
1460 trns_chain". Also, change implementation of N OF CASES, FILTER,
1461 and PROCESS IF from special cases to transformations.
1463 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1466 * dictionary.c: (global variable default_dict) Move to
1469 * variable.h: (TRNS_*) Move to transformations.h.
1470 (struct transformation) Move to transformations.c.
1472 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1474 * sys-file-reader.c: Fixed invalid read problems.
1476 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1478 * storage-stream.c: Add missing function comments.
1480 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1482 Continue reforming procedure execution. In this phase, add some
1483 new, needed functionality to storage-stream.
1485 * storage-stream.c: (storage_source_decapsulate) New function.
1487 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1489 * variable.c (width_to_bytes): Declarations must precede
1490 statements for C90 compliance.
1492 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1494 * data-out.c, data-in.c, variable.c, variable.h: New functions
1495 copy_mangle and copy_demangle for reading/writing cases; emulates the
1496 way SPSS deals with strings > 255 bytes.
1498 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1499 subtype 14 needed for strings longer than 255 bytes.
1501 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1502 instead of literal values. Also fixed some constness issues.
1504 * format.h: Constness
1506 * sfm-private.h: Renamed the case_size identifier, since I discovered
1507 that SPSS's respect for this variable is very nominal.
1509 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1511 Change case limit type from int to size_t.
1513 * dictionary.c: (struct dictionary) Change type of case_limit
1515 (dict_get_case_limit) Change return type.
1516 (dict_set_case_limit) Change parameter type.
1518 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1520 * variable.h: (struct variable) Rename `reinit' member as `leave'
1521 and invert sense. Fix up all references.
1523 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1525 Continue reforming procedure execution. In this phase, break
1526 procedure.c into multiple files.
1528 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1530 * case-sink.c: New file.
1532 * case-sink.h: New file.
1534 * case-source.c: New file.
1536 * case-source.h: New file.
1538 * storage-stream.c: New file.
1540 * storage-stream.h: New file.
1542 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1544 * variable.h: (struct variable) Remove `init' member and all
1545 references to it from other files. It was initialized in several
1546 places, but nothing really ever used it for anything worthwhile.
1547 Thanks to Jason Stover for pointing out how confusing this
1550 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1552 Continue reforming error message support. In this phase, get rid
1553 of message "titles" and put the message text in `struct error'.
1554 Now `struct error' encapsulates a message more properly.
1556 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1557 Format message ourselves.
1559 * data-in.c: (vdls_error) Ditto.
1561 * por-file-reader.c: (error) Ditto.
1563 * sys-file-reader.c: (corrupt_msg) Ditto.
1565 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1567 GNU standards require "file name" instead of "filename" in
1568 documentation. It's nice for our code to follow the convention
1571 * casefile.c: (struct casefile) Rename `filename' member to
1572 `file_name'. Updated all references.
1574 * file-name.c: [!unix] (struct file_identity) Rename
1575 normalized_filename member to normalized_file_name. Updated all
1578 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1580 We don't really support anything but Unix-like environments well,
1581 so we might as well de-obfuscate by writing directory and path
1582 separators explicitly.
1584 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1586 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1587 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1589 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1592 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1594 GNU standards require "file name" instead of "filename" in
1595 documentation. It's nice for our code to follow the convention
1598 * filename.c: Rename to file-name.c.
1600 * filename.h: Rename to file-name.h. Update all inclusions.
1601 Update header guards.
1603 * automake.mk: Update file names.
1605 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1607 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1609 (fn_basename) Removed (dead code).
1610 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1611 (fn_special_p) Renamed fn_is_special(), all references updated.
1612 (fn_exists_p) Renamed fn_exists(), all references updated.
1614 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1616 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1617 Also, now it only tilde-expands file names, not paths.
1618 (fn_search_path) Tilde-expand one directory at a time.
1620 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1622 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1623 get rid of non-Unixlike version of the code, which has probably
1625 (fn_prepend_dir) Removed (dead code).
1627 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1628 (macro PATH_SEPARATOR_STRING) New.
1629 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1631 Continue reforming error message support. In this phase, we get
1632 rid of VM() and the other msg() support for "verbosity", replacing
1633 it by a new function verbose_msg().
1635 * filename.c: (fn_search_path) Use verbose_msg() instead of
1638 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1640 * sfm-private.h: Get rid of #defines after #error, which makes no
1643 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1645 Get rid of our own int32 type in favor of the standard int32_t
1648 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1651 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1653 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1655 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1657 Remove ill-considered file routines that are no longer used.
1659 * filename.c: (fn_open_ext) Removed.
1660 (fn_close_ext) Removed.
1662 * filename.h: (struct file_ext) Removed.
1664 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1666 * variable.c (var_is_valid_name): Move declarations before code
1669 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1671 * filename.ch (fn_interp_vars): Fixed small buglet.
1673 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1675 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1676 so as to modify the string inline. Thus makeing it easier to
1677 destroy the results when no longer needed.
1679 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1681 * category.c (cat_stored_values_destroy): Fixed memory leak.
1683 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1685 Add some missing frees. Thanks to John Darrington for reporting
1688 * any-writer.c (any_writer_close): Free writer.
1690 * any-reader.c (any_reader_close): Free reader.
1692 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1694 * por-file-reader.c: (error) Mark as NO_RETURN.
1696 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1698 * settings.c: Changed default value of scompress to true.
1700 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1702 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1704 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1707 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1708 here from pref.h.orig.
1710 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1712 * sys-file-reader.c: Fixed bug reading compressed files.
1714 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1716 * Numerous renames. See src/ChangeLog for details.
1718 * Moved files from src directory