1 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
3 * dictionary.c dictionary.h : Added callbacks for change of filter and
4 split variables. Refactored some code to ensure that callbacks get
5 invoked when appropriate.
7 * procedure.c (proc_cancel_temporary_transformations): Make sure that
8 replace_dict callback occurs when permanent_dict replaces the current
11 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
13 * dictionary.c dictionary.h : Added callback for when the weight
14 variable of a dictionary changes.
16 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
18 * dictionary.c dictionary.h : Added replace_source and replace_dict
19 callbacks, and functions to deal with them.
21 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
23 Simplify missing value handling.
25 * missing-values.h (enum mv_class): New type.
26 (enum mv_type): Moved definition into missing-values.c and renamed
27 each MV_* to MVT_*, to distinguish them from the exposed mv_class
28 enums. Updated all uses.
29 (struct missing_values): Changed type of `type' from `enum
30 mv_type' to `int' because the definition is no longer exposed.
32 * missing-values.c (mv_is_value_missing): Add new enum mv_class
33 parameter. Update all callers.
34 (mv_is_num_missing): Ditto.
35 (mv_is_str_missing): Ditto.
36 (mv_is_value_user_missing): Removed. Changed callers to use
38 (mv_is_num_user_missing): Removed. Changed callers to use
40 (mv_is_str_user_missing): Removed. Changed callers to use
42 (mv_is_value_system_missing): Removed. Changed callers to use
44 (mv_set_type): Removed. Changed callers to use mv_clear.
45 (mv_clear): New function.
47 * variable.c (var_is_value_missing): Add new enum mv_class
48 parameter. Update all callers.
49 (var_is_num_missing): Ditto.
50 (var_is_str_missing): Ditto.
51 (var_is_value_user_missing): Removed. Changed callers to use
53 (var_is_num_user_missing): Removed. Changed callers to use
55 (var_is_str_user_missing): Removed. Changed callers to use
57 (var_is_value_system_missing): Removed. Changed callers to use
60 * casefilter.c (struct casefilter): Use enum mv_class in place of
62 (casefilter_variable_missing): Adapt to new member.
63 (casefilter_create): Change signature to take enum mv_class,
66 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
68 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
70 * case-sink.c case-sink.h procedure.c procedure.h
71 storage-stream.c: Now uses the factory.
73 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
75 Make it possible to pull cases from the active file with a
76 function call, instead of requiring indirection through a callback
79 * case-source.h (struct case_source_class): Change ->read function
80 to return a single case, instead of calling a callback function
81 for each case. Change ->destroy function to return an error
84 * case-source.c (free_case_source): Pass along the value returned
85 by the case_source ->destroy function.
87 * procedure.c (struct write_case_data): Removed.
88 (struct dataset): Added some members to track procedure state.
89 (procedure): Optimize the trivial case at this level.
90 (internal_procedure): Re-implement in terms of proc_open,
91 proc_read, proc_close.
92 (proc_open) New function.
93 (proc_read) New function.
94 (proc_close) New function.
95 (write_case) Moved into proc_read.
96 (close_active_file) Moved closing of data source into proc_close.
98 * storage-source.c: Rewrote to conform with modified
99 case_source_class interface.
101 * transformations.c (trns_chain_execute): Added argument to allow
102 starting execution from an arbitrary transformation. Updated
105 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
107 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
109 * sys-file-reader.c (read_display_parameters): Don't assume that
110 MEASURE_* and ALIGN_* have the same values found in system files.
112 * sys-file-writer.c (write_variable_display_parameters): Ditto.
114 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
115 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
116 the value of n_MEASURES, which was off by 1 (at least from my
119 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
121 * dictionary.c dictionary.h vardict.h variable.c: Added optional
122 callbacks which are invoked when the dictionary or its
123 variables are changed.
125 * missing-values.c missing-values.h value-labels.c: Tidied up
126 consistency checks, and made some of them return false
127 instead of assert-failing.
129 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
131 * calendar.c (calendar_days_in_month): New function.
133 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
135 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
136 the value label's width.
138 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
140 * sfm-private.h: Move contents into sys-file-writer.c, which is
141 the only remaining user. Removed Borland C++-specific directives.
143 * sys-file-reader.c: Clean up and rewrite entire file. The
144 rewritten version is simpler and better abstracted, and should be
145 easier to maintain and extend. It avoids using structures to read
146 file data, which is prone to padding variations among compilers.
147 It should also handle non-IEEE 754 system files, although I
148 haven't been able to find any. It has been tested against many
149 .sav files obtained from the Web and found to produce the same
150 results as the earlier version of the code, or in some cases
151 improved results. It is more tolerant of format variations found
154 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
155 member, putting an enum integer_format in its place. New member
156 `float_format'. Changed `compressed' member to type bool.
158 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
160 * dictionary.c (dict_delete_consecutive_vars): New function.
162 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
164 * file-name.c (fn_search_path): Remove prefix arg that was unused
165 by any caller. Updated all callers.
167 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
169 * format.c (fmt_dollar_template): Use user's decimal point
170 character. Add assertion.
172 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
174 * format.c (fmt_dollar_template): New function, based on
175 dollar_format_template from var-type-dialog.c.
177 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
179 * data-out.c (output_scientific): Fix bad assumption that "buf" is
182 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
184 Finish converting struct variable to an opaque type. In this
185 phase, we add remaining setter and getter functions, convert the
186 remaining PSPP code to use them, and do a bunch of cleanup. The
187 resulting changes are pervasive but mostly trivial, and only the
188 notable changes are logged.
190 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
193 * case.c (case_data): Renamed case_data_idx.
194 (case_num): Renamed case_num_idx.
195 (case_str): Renamed case_str_idx.
196 (case_data_rw): Renamed case_data_rw_idx.
198 * case.h (case_data): New function with old name and an interface
199 that takes a variable instead of an index, which is easier to
200 use. Updated all callers to use the new interface, or to use the
201 new *_idx function (see above).
204 (case_data_rw): Ditto.
206 * category.c (cat_stored_values_destroy): Changed interface to
207 take a struct cat_vals * instead of a struct variable *.
209 * dictionary.c (dict_clone): Use new vector_clone function.
210 (dict_clear) Use new var_destroy function.
211 (add_var) New function.
212 (dict_create_var) Rewrite in terms of dict_create_var_assert.
213 (dict_create_var_assert) Rewrite in terms of add_var.
214 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
215 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
216 (dict_lookup_var) Use new var_create, var_destroy functions.
217 (dict_contains_var) Rewrite in terms of new vardict functionality.
218 (set_var_dict_index) New function.
219 (set_var_case_index) New function.
220 (reindex_vars) New function.
221 (dict_delete_var) Rewrite in terms of new vardict functionality.
222 (dict_reorder_var) Ditto.
223 (dict_reorder_vars) Ditto.
224 (rename_var) New function.
225 (dict_rename_var) Use rename_var.
226 (dict_rename_vars) Use pool to simplify code. Use rename_var.
227 (dict_get_compacted_idx_to_fv) Rename
228 dict_get_compacted_dict_index_to_case_index, update callers.
229 (dict_create_vector) Use new vector_create function.
230 (dict_clear_vectors) Use new vector_destroy function.
231 (set_var_short_name_suffix) Move here from variable.c, renamed
232 from var_set_short_name_suffix, make static, update caller.
234 * sys-file-private.c: New file.
235 (sfm_width_to_bytes) Moved here from variable.c, renamed from
236 width_to_bytes, update callers.
238 * sys-file-private.h: New file. Later it will supplant
239 sfm-private.h; for now it supplements it.
240 (macro MIN_VERY_LONG_STRING) New macro.
241 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
243 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
244 MAX_LONG_STRING was used before.
246 * sys-file-writer.c: Ditto.
248 * value-labels.c: Change the paradigm here to be that a null
249 pointer is OK for a struct val_labs * in most cases; it just
250 represents an empty set of value labels.
251 (val_labs_copy) A copy of a null set is a null set.
252 (val_labs_count) A null set has 0 labels.
253 (val_labs_replace) Change return type to void. Rewrite for
255 (val_labs_find) A null set does not contain the value.
256 (value_to_string) Moved to variable.c, renamed var_get_value_name,
257 transposed argument order, updated all callers.
260 (value_dup) Moved here from variable.c.
261 (compare_values) Ditto.
264 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
265 (macro MAX_LONG_STRING) Removed, because it was only interesting
266 for system files, not for general code.
267 (macro MAX_VERY_LONG_STRING) Ditto.
268 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
269 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
271 * vardict.h: New file, for an interface between variables and
274 * variable.c: A lot of functions were moved around, for better
276 (struct variable) Move definition here, from variable.h.
277 (var_type_adj) Removed--makes i18n hard.
278 (var_type_noun) Ditto.
279 (var_create) New function.
280 (var_clone) New function.
281 (var_destroy) New function.
282 (var_set_name) Assert that variable is not in a dictionary.
283 (compare_var_names) Rename compare_vars_by_name and fix a couple
284 of callers who thought the args were strings.
285 (hash_var_name) Rename hash_var_by_name.
286 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
287 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
288 (var_is_very_long_string) Removed, because it was only interesting
290 (var_set_missing_values) Allow the argument to be the wrong width,
291 as long as we can resize it. Simplify callers who were doing the
293 (var_get_value_labels) New function.
294 (var_has_value_labels) New function.
295 (var_set_value_labels) New function.
296 (alloc_value_labels) New function.
297 (var_add_value_label) New function.
298 (var_replace_value_label) New function.
299 (var_clear_value_labels) New function.
300 (var_lookup_value_label) New function.
301 (var_get_value_name) Moved here from variable.c, renamed from
302 var_get_value_name, transposed argument order, updated all
304 (var_to_string) Moved here, from variable-label.c.
305 (var_set_leave) New function.
306 (var_get_leave) New function.
307 (var_must_leave) New function.
308 (var_set_short_name_suffix) Moved to dictionary.c, renamed
309 set_var_short_name_suffix.
310 (var_get_dict_index) New function.
311 (var_get_case_index) New function.
312 (var_get_obs_vals) New function.
313 (var_set_obs_vals) New function.
314 (var_has_obs_vals) New function.
315 (var_get_vardict) New function.
316 (var_set_vardict) New function.
317 (var_has_vardict) New function.
318 (var_clear_vardict) New function.
319 (value_dup) Moved to value.c.
320 (compare_values) Ditto.
323 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
324 (enum ALPHA) Rename VAR_STRING, update all users.
326 * vector.c: New file.
327 (struct vector) Moved here, from variable.h.
328 (check_widths) New function.
329 (vector_create) New function.
330 (vector_clone) New function.
331 (vector_destroy) New function.
332 (vector_get_name) New function.
333 (vector_get_var) New function.
334 (vector_get_var_cnt) New function.
335 (compare_vector_ptrs_by_name) New function.
337 * vector.h: New file.
339 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
341 * casefilter.c (casefilter_variable_missing): Avoided comparision of
342 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
345 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
347 * value-labels.c (destroy_atoms): New function.
348 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
350 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
352 Thanks to Jason Stover for pointing out this problem.
354 * data-out.c (output_number): Use gsl_finite from GSL, which is
355 portable, instead of isfinite, which is not.
358 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
360 * variable.c variable.h (value_dup): New function.
362 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
364 Start converting struct variable to an opaque type. In this
365 phase, we add a bunch of setter and getter functions and convert
366 most of the PSPP code to use them. The resulting changes are
367 pervasive but mostly trivial, and only the notable changes are
370 * format.c (fmt_equal): New function.
372 * variable.c (var_type_is_valid): New function.
373 (measure_is_valid) Moved here, from format.c.
374 (alignment_is_valid) Moved here, from format.c.
375 (var_get_name) New function.
376 (var_set_name) New function.
377 (width_to_type) New function.
378 (var_get_type) New function.
379 (var_get_width) New function.
380 (var_set_width) New function.
381 (var_is_numeric) New function.
382 (var_is_alpha) New function.
383 (var_is_short_string) New function.
384 (var_is_long_string) New function.
385 (var_is_very_long_string) New function.
386 (var_get_missing_values) New function.
387 (var_set_missing_values) New function.
388 (var_clear_missing_values) New function.
389 (var_has_missing_values) New function.
390 (var_is_value_missing) New function.
391 (var_is_num_missing) New function.
392 (var_is_str_missing) New function.
393 (var_is_value_user_missing) New function.
394 (var_is_num_user_missing) New function.
395 (var_is_str_user_missing) New function.
396 (var_is_value_system_missing) New function.
397 (var_get_print_format) New function.
398 (var_set_print_format) New function.
399 (var_get_write_format) New function.
400 (var_set_write_format) New function.
401 (var_set_both_formats) New function.
402 (var_get_label) New function.
403 (var_set_label) New function.
404 (var_clear_label) New function.
405 (var_has_label) New function.
406 (var_get_measure) New function.
407 (var_set_measure) New function.
408 (var_get_display_width) New function.
409 (var_set_display_width) New function.
410 (var_get_alignment) New function.
411 (var_set_alignment) New function.
412 (var_get_value_cnt) New function.
413 (var_get_leave) New function.
414 (var_get_short_name) New function.
416 * variable.h: (struct variable) Removed "type" and "nv" members;
417 they are now computed from "width" where needed.
419 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
421 * missing-values.c (mv_resize): Don't write beyond end of the
422 allocated buffer when resizing a long string.
424 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
426 Clean up identifier code: don't require identifier enumerations to
427 be in a particular order; make better use of string library;
428 expose less of the internals.
430 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
431 change interface. Updated all callers.
432 (lex_id_match) Change interface to use struct substring, update
434 (lex_id_match_len) Removed. Update callers to use lex_id_match.
435 (global array keywords[]) Make static, change form. Update all
436 users to use lex_id_name instead.
437 (lex_is_keyword) New function.
438 (lex_id_to_token) Change interface to use struct substring, update
440 (lex_id_name) New function.
442 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
443 lex_is_keyword instead.
444 (T_LAST_KEYWORD) Removed.
445 (T_N_KEYWORDS) Removed.
447 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
449 * format.c: (fmt_date_template) Distinguish characters for which a
450 space is output and any date delimiter is allowed on input, from
451 those for which a space is output and only a space is allowed on
452 input. The former is represented by X, the latter by a space.
453 Also, drop distinction between h and H, changing the former to the
456 * data-in.c: Completely rewrite internals to conform to SPSS input
457 formats as closely as possible.
458 (data_in) Changed external interface by replacing the structure
459 that was used as a single argument by a set of arguments. Updated
461 (data_in_finite_line) Removed. Converted all callers to use plain
463 (data_in_get_integer_format) New function.
464 (data_in_set_integer_format) New function.
465 (data_in_get_float_format) New function.
466 (data_in_set_float_format) New function.
468 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
469 (struct data_in) Removed.
471 * data-out.c: (output_date) Drop each component from the input as
472 it is output, to allow us to drop the distinction between h (a
473 count of hours) and H (the hour of day) template characters.
474 Also, handle new X template character.
475 (output_scientific) Follow more rational rule on when to drop
476 fraction introduced between SPSS 13 and 15. Updated test case to
479 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
481 Fix buffer overflow reported by John Darrington.
483 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
484 realize that DIGITS is a count of nibbles, not of bytes.
486 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
488 * calendar.c (calendar_offset_to_gregorian) Also return the
489 year-of-day. Change callers to new interface.
491 * data-out.c: Completely rewrite internals to conform to SPSS
492 output formats as completely as possible.
493 (data_out) Change interface to put input parameters before output
494 parameters, for consistency with the style I now prefer. Update
496 (data_out_get_integer_format) New public function.
497 (data_out_set_integer_format) New public function.
498 (data_out_get_float_format) New public function.
499 (data_out_set_float_format) New public function.
501 * data-out.h: New file. Move prototype for data_out here, from
504 * format.c: (fmt_step_width) Use equality comparison instead of
505 bitwise and, for clarity.
506 (fmt_is_string) Ditto.
507 (fmt_input_to_output) Fix categories that are translated to F
510 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
512 * casefilter.c casefilter.h (new files), casefile.c casefile.h
513 casefile-private.h: Added casefilter to assist commands with missing
516 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
518 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
520 * settings.c: (route_errors_to_terminal) New variable.
521 (route_errors_to_listing) New variable.
522 (get_error_routing_to_terminal) New function.
523 (set_error_routing_to_terminal) New function.
524 (get_error_routing_to_listing) New function.
525 (set_error_routing_to_listing) New function.
527 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
529 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
531 * format.c: Completely rewrite, to achieve better abstraction.
532 Rewrite all references to formats in other files.
534 * format.def: Rewrite and reorganize.
536 * settings.c: Move everything related to custom currency formats
537 into format.[ch], changing them in form, so as to group related
538 code and definitions better. Changed all references to use the
540 (static var decimal) Removed.
541 (static var grouping) Removed.
542 (static var cc) Removed.
543 (get_decimal) Removed.
544 (set_decimal) Removed.
545 (get_grouping) Removed.
546 (set_grouping) Removed.
550 * settings.h: (macro CC_CNT) Removed.
551 (macro CC_WIDTH) Removed.
552 (struct custom_currency) Removed.
554 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
556 * data-in.c (data_in): Use switch statement instead of table, to
557 avoid dependence on the order of the FMT_* enums.
559 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
561 * data-out.c: (num_to_string) Removed, because it was dead code.
563 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
565 * data-in.c (parse_trailer): Fix error message.
567 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
569 * format.c (fmt_is_binary): New function.
571 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
573 * procedure.c procedure.h: Encapsulated the static data into a single
576 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
578 * casefile.c (casereader_read_xfer): Always initialize the case,
579 even on an error condition.
581 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
583 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
584 entire function useless.
586 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
588 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
589 casereader method casereader_clone.
591 * procedure.c pransformations.h: Introduced new type casenum_t
593 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
595 * variable.c: (width_to_bytes) Rephrase code for clarify.
597 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
599 * format.c: (fmt_type_from_string) New function.
600 (fmt_to_string) Include decimals in output if the format has
601 decimals, even if the format type does not. This way, we can
602 accurately reproduce incorrect formats in user output.
603 (check_common_specifier) Make the check for a bad format type an
604 assertion, so we get bug reports if they show up. Fix message.
605 Check for decimal places with a format type that doesn't allow
607 (check_input_specifier) Remove check for FMT_X, which has been
609 (check_output_specifier) Ditto.
611 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
613 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
614 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
615 (enum fmt_parse_flags) Removed.
617 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
619 * casefile.c casefile.h: Converted to an abstract base class.
620 * casefile-private.h fastfile.c fastfile.h: New files.
621 * automake.mk procedure.c scratch-writer.c storage-stream.c
623 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
625 * procedure.c (internal_procedure): Create sink_case with only as
626 many values as the compacted dictionary.
628 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
630 Remove "debugging" code that caused plenty of false positives and
633 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
635 * case.c: Remove all references to `this' member.
637 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
639 Fix link error noted by Jason Stover.
641 * storage-stream.c: Include <assert.h>.
643 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
645 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
646 ALL) and additional underlying system file issues.
648 Thanks to John Darrington for review.
650 First problem: var_hash points to variables not owned by the
651 sys-file-reader, which the caller may free or modify. Use an
652 array of sfm_vars instead, as done earlier (e.g. CVS version
655 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
656 members and remove all code that references it. Add vars, var_cnt
657 members. Remove fix_specials member, which was unused.
658 (struct sfm_var) Remove name member, which was unused.
659 (sfm_close_reader) Free vars member instead of var_hash.
660 (compare_var_shortnames) Removed.
661 (hash_var_shortname) Removed.
662 (sfm_open_reader) Fill out vars array.
663 (compare_var_index) Removed.
664 (sfm_read_case) Use vars instead of var_hash.
666 Second problem: we're confused about when we actually have very
667 long strings, causing us to choose incorrectly between slow path
668 and fast path in sfm_read_case.
670 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
671 have very long strings, not when we have long variable names,
672 which is an unrelated feature.
674 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
676 * variable.h: Move var_set and variable parsing declarations to
677 new header, src/language/lexer/variable-parser.h. Modified lots
678 of files to include the new header.
680 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
682 * value-labels.c (value_to_string): When there's no value label,
683 format the variable according to its print format, instead of
684 always effectively using A or F format.
686 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
688 * casefile.c (casefile_get_random_reader): Nasty hack to get around
691 * format.c: Removed tortological assertion.
693 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
695 Reform string library.
697 * file-name.c (fn_interp_vars): Change interface to take a
698 substring as input. Updated all users.
700 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
702 * format.c (measure_is_valid): Really return false when m >=
705 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
707 Implement random access to casefiles, for use in GUI.
709 * casefile.c: (struct casereader) Add `random', `file_ofs',
710 `buffer_ofs' members.
711 (casefile_get_random_reader) New function.
712 (read_open_file) Break part into new function
713 seek_and_fill_buffer().
714 (fill_buffer) Update buffer_ofs, file_ofs.
715 (casereader_seek) New function.
717 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
719 * settings.c: Added call to i18n{done, init}.
721 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
723 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
726 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
728 * casefile.c: Convert many uses of `int' to `bool'.
730 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
732 * transformations.c (trns_chain_destroy): Destroy chain's trns
733 member, to fix memory leak.
735 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
737 * storage-stream.c (storage_source_decapsulate): Destroy case
738 source to fix memory leak.
740 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
742 * scratch-reader.c (scratch_reader_read_case): Copy into existing
743 case passed as argument instead of initializing the argument as a
744 case. Fixes memory leak that showed up in
745 tests/command/aggregate.sh with scratch files.
747 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
749 * procedure.c (proc_done): Destroy default_dict, to fix memory
752 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
754 Simplify procedure_with_splits().
756 * procedure.c (struct split_aux_data): Removed case_count member.
757 (procedure_with_splits) Don't initialize case_count.
758 (split_procedure_case_func) Check whether prev_case is null
759 instead of case_count.
760 (split_procedure_end_func) Ditto.
762 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
764 * case.c (case_move): Do nothing if dst and src are the same
766 (case_try_create) Merge two similar cases.
767 (case_copy) Unshare only if data must be actually copied.
769 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
771 * data-in.c data-out.c dictionary.c sys-file-reader.c
772 sys-file-writer.c variable.c variable.h: Reworked very long string
773 support for better encapsulation.
775 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
777 * value-labels.c (val_labs_can_set_width): New function.
778 (val_labs_set_width) Clear labels if increasing width to long
780 (val_labs_destroy) Remove unneeded test for null.
782 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
784 * value-labels.h: Remove unneeded dependency on variable.h.
786 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
788 Get rid of `char *c' member in union value, for cleanliness.
790 * value.h: (union value) Remove `c' member.
792 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
794 Make dictionary compacting functions a little more general.
796 * sys-file-writer.c (sfm_open_writer): Use
797 dict_compacting_would_change().
798 (does_dict_need_translation) Removed.
800 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
802 Make dictionary compacting functions a little more general.
804 * dictionary.c (dict_needs_compaction): Rename
805 dict_compacting_would_shrink(). Update all callers.
806 (dict_compacting_would_change) New function.
808 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
810 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
811 inverted return value (!).
813 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
815 Continue reforming procedure execution.
817 * procedure.c: Search and replace "vfm" by "proc". Notably:
818 (static var vfm_source) Rename proc_source. Update all
820 (static var vfm_sink) Rename proc_sink. Update all references.
822 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
824 Continue reforming procedure execution. In this phase, remove
825 PROCESS IF, which was deprecated anyway and can be easily
826 simulated with TEMPORARY followed by SELECT IF.
828 * procedure.c: (open_active_file) Don't call
829 add_process_if_trns().
830 (discard_variables) Get rid of redundant call to
831 proc_cancel_all_transformations().
832 (add_process_if_trns) Removed.
833 (process_if_trns_proc) Removed.
834 (process_if_trns_free) Removed.
836 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
838 Continue reforming procedure execution. In this phase, add
839 `const' to the case passed to procedure()'s callback.
841 Updated all users of procedure() as well.
843 * procedure.c: (struct write_case_data) Add "const" to ccase
844 parameter for case_func member.
845 (procedure) Add "const" to ccase parameter for proc_func
847 (multipass_case_func) Make ccase parameter const.
848 (internal_procedure) Add "const" to ccase parameter for case_func
850 (split_procedure_case_func) Make ccase parameter const.
851 (multipass_split_case_func) Make ccase parameter const.
853 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
855 Continue reforming procedure execution. In this phase, get rid of
856 the output code for SPLIT FILE groups in procedure.c, which really
857 shouldn't be doing any output. Move it into the individual
858 procedures instead. This also adds some flexibility.
860 Updated many users of procedure_with_splits() and
861 multipass_procedure_with_splits() to call
862 output_split_file_values() and to deal with increased use of
865 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
866 parameter to begin_func member.
867 (procedure_with_splits) Add "const struct ccase *" parameter to
868 begin_func parameter. Make ccase parameter const in proc_func
870 (split_procedure_case_func) Don't dump split file group. Pass
872 (dump_splits) Moved to language/dictionary/split-file.c as
873 output_split_file_values().
874 (struct multipass_split_aux_data) Add "const struct ccase *"
875 parameter to split_func member.
876 (multipass_procedure_with_splits) Add "const struct ccase *"
877 parameter to split_func parameter.
878 (multipass_split_case_func) Save new SPLIT FILE case before
880 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
882 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
884 Continue reforming procedure execution. Change
885 internal_procedure() so that it calls open_active_file() and
886 close_active_file(), which isolates most of the actual procedure
889 * procedure.c: (struct write_case_data) Rename `proc_func' member
890 to `case_func' and update all references.
891 (procedure) Rewrite as one-line wrapper around
892 internal_procedure().
893 (struct multipass_aux_data) New.
894 (multipass_callback) Renamed multipass_case_func(). Use struct
895 multipass_aux_data as auxiliary data.
896 (multipass_end_func) New function.
897 (multipass_procedure) Rewrite as wrapper for internal_procedure()
898 that uses multipass_case_func, multipass_end_func.
899 (internal_procedure) Add `end_func' argument. Move optimization
900 of trivial case in here. Move call to open_active_file() and
901 close_active_file() in here. Now assert that vfm_source is
903 (procedure_with_splits_callback) Rename
904 split_procedure_case_func().
905 (split_procedure_end_func) New function.
906 (multipass_split_callback) Rename multipass_split_case_func.
907 (multipass_split_end_func) New function.
908 (discard_variables) No need to test for nonnull vfm_source.
910 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
912 Continue reforming procedure execution. Get rid of unused member.
914 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
916 (write_case) Don't increment cases_analyzed.
918 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
920 Continue reforming procedure execution. In this phase, move
921 procedure.c and procedure.h from src to src/data. Update
922 makefiles and #includes accordingly.
924 * procedure.c: Moved here from src/.
926 * procedure.h: Moved here from src/.
928 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
930 Continue reforming procedure execution. In this phase, get rid of
931 many global variables, consolidating procedure execution in
932 procedure.c. Encapsulate transformations in new "struct
933 trns_chain". Also, change implementation of N OF CASES, FILTER,
934 and PROCESS IF from special cases to transformations.
936 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
939 * dictionary.c: (global variable default_dict) Move to
942 * variable.h: (TRNS_*) Move to transformations.h.
943 (struct transformation) Move to transformations.c.
945 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
947 * sys-file-reader.c: Fixed invalid read problems.
949 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
951 * storage-stream.c: Add missing function comments.
953 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
955 Continue reforming procedure execution. In this phase, add some
956 new, needed functionality to storage-stream.
958 * storage-stream.c: (storage_source_decapsulate) New function.
960 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
962 * variable.c (width_to_bytes): Declarations must precede
963 statements for C90 compliance.
965 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
967 * data-out.c, data-in.c, variable.c, variable.h: New functions
968 copy_mangle and copy_demangle for reading/writing cases; emulates the
969 way SPSS deals with strings > 255 bytes.
971 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
972 subtype 14 needed for strings longer than 255 bytes.
974 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
975 instead of literal values. Also fixed some constness issues.
977 * format.h: Constness
979 * sfm-private.h: Renamed the case_size identifier, since I discovered
980 that SPSS's respect for this variable is very nominal.
982 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
984 Change case limit type from int to size_t.
986 * dictionary.c: (struct dictionary) Change type of case_limit
988 (dict_get_case_limit) Change return type.
989 (dict_set_case_limit) Change parameter type.
991 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
993 * variable.h: (struct variable) Rename `reinit' member as `leave'
994 and invert sense. Fix up all references.
996 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
998 Continue reforming procedure execution. In this phase, break
999 procedure.c into multiple files.
1001 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1003 * case-sink.c: New file.
1005 * case-sink.h: New file.
1007 * case-source.c: New file.
1009 * case-source.h: New file.
1011 * storage-stream.c: New file.
1013 * storage-stream.h: New file.
1015 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1017 * variable.h: (struct variable) Remove `init' member and all
1018 references to it from other files. It was initialized in several
1019 places, but nothing really ever used it for anything worthwhile.
1020 Thanks to Jason Stover for pointing out how confusing this
1023 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1025 Continue reforming error message support. In this phase, get rid
1026 of message "titles" and put the message text in `struct error'.
1027 Now `struct error' encapsulates a message more properly.
1029 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1030 Format message ourselves.
1032 * data-in.c: (vdls_error) Ditto.
1034 * por-file-reader.c: (error) Ditto.
1036 * sys-file-reader.c: (corrupt_msg) Ditto.
1038 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1040 GNU standards require "file name" instead of "filename" in
1041 documentation. It's nice for our code to follow the convention
1044 * casefile.c: (struct casefile) Rename `filename' member to
1045 `file_name'. Updated all references.
1047 * file-name.c: [!unix] (struct file_identity) Rename
1048 normalized_filename member to normalized_file_name. Updated all
1051 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1053 We don't really support anything but Unix-like environments well,
1054 so we might as well de-obfuscate by writing directory and path
1055 separators explicitly.
1057 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1059 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1060 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1062 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1065 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1067 GNU standards require "file name" instead of "filename" in
1068 documentation. It's nice for our code to follow the convention
1071 * filename.c: Rename to file-name.c.
1073 * filename.h: Rename to file-name.h. Update all inclusions.
1074 Update header guards.
1076 * automake.mk: Update file names.
1078 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1080 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1082 (fn_basename) Removed (dead code).
1083 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1084 (fn_special_p) Renamed fn_is_special(), all references updated.
1085 (fn_exists_p) Renamed fn_exists(), all references updated.
1087 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1089 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1090 Also, now it only tilde-expands file names, not paths.
1091 (fn_search_path) Tilde-expand one directory at a time.
1093 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1095 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1096 get rid of non-Unixlike version of the code, which has probably
1098 (fn_prepend_dir) Removed (dead code).
1100 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1101 (macro PATH_SEPARATOR_STRING) New.
1102 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1104 Continue reforming error message support. In this phase, we get
1105 rid of VM() and the other msg() support for "verbosity", replacing
1106 it by a new function verbose_msg().
1108 * filename.c: (fn_search_path) Use verbose_msg() instead of
1111 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1113 * sfm-private.h: Get rid of #defines after #error, which makes no
1116 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1118 Get rid of our own int32 type in favor of the standard int32_t
1121 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1124 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1126 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1128 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1130 Remove ill-considered file routines that are no longer used.
1132 * filename.c: (fn_open_ext) Removed.
1133 (fn_close_ext) Removed.
1135 * filename.h: (struct file_ext) Removed.
1137 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1139 * variable.c (var_is_valid_name): Move declarations before code
1142 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1144 * filename.ch (fn_interp_vars): Fixed small buglet.
1146 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1148 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1149 so as to modify the string inline. Thus makeing it easier to
1150 destroy the results when no longer needed.
1152 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1154 * category.c (cat_stored_values_destroy): Fixed memory leak.
1156 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1158 Add some missing frees. Thanks to John Darrington for reporting
1161 * any-writer.c (any_writer_close): Free writer.
1163 * any-reader.c (any_reader_close): Free reader.
1165 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1167 * por-file-reader.c: (error) Mark as NO_RETURN.
1169 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1171 * settings.c: Changed default value of scompress to true.
1173 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1175 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1177 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1180 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1181 here from pref.h.orig.
1183 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1185 * sys-file-reader.c: Fixed bug reading compressed files.
1187 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1189 * Numerous renames. See src/ChangeLog for details.
1191 * Moved files from src directory