1 2007-07-14 John Darrington <john@darrington.wattle.id.au>
3 * sfm-reader.c: Respect case_cnt field in file header.
5 2007-07-01 John Darrington <john@darrington.wattle.id.au>
7 * transformation.c transformation.h (trns_chain_execute): Changed the
8 signature (Patch #6057)
10 2007-06-10 Ben Pfaff <blp@gnu.org>
12 * casereader-filter.c (casereader_filter_destroy): Make sure to
13 write all the remaining excluded cases to the casewriter, if any.
15 * caseinit.c (init_list_destroy): Rewrite.
16 (init_list_clear): Ditto.
18 * casegrouper.c (casegrouper_get_next_group): Always set *reader
19 to null when returning false.
21 2007-06-06 Ben Pfaff <blp@gnu.org>
23 Actually implement the new procedure code and adapt all of its
24 clients to match. Also adapt all of the other case sources and
25 sinks in the tree and their clients to use the
26 casereader/casewriter infrastructure.
28 * automake.mk: Add and remove files.
30 * any-reader.c: Change into a casereader.
31 * por-file-reader.c: Ditto.
32 * scratch-reader.c: Ditto.
33 * sys-file-reader.c: Ditto.
35 * any-writer.c: Change into a casewriter.
36 * por-file-writer.c: Ditto.
37 * scratch-writer.c: Ditto.
38 * sys-file-writer.c: Ditto.
40 * procedure.c: Change to use casereader, casewriter, caseinit, and
41 other new infrastructure.
43 * scratch-handle.c: Adapt to new infrastructure.
45 * case-sink.c: Removed, now dead code.
47 * case-source.c: Ditto.
48 * case-source.h: Ditto.
49 * casefile-factory.c: Ditto.
50 * casefile-private.h: Ditto.
53 * casefilter.c: Ditto.
54 * casefilter.h: Ditto.
57 * fastfile-factory.c: Ditto.
58 * fastfile-factory.h: Ditto.
59 * storage-stream.c: Ditto.
60 * storage-stream.h: Ditto.
62 2007-06-06 Ben Pfaff <blp@gnu.org>
66 * automake.mk: Add new files.
68 * datasheet.c: New file.
70 * datasheet.h: New file.
72 2007-06-06 Ben Pfaff <blp@gnu.org>
74 Until now, the procedure code has provided a case to the
75 case_source, which has filled in the data values that come from
76 the active file. "Left" data values that don't come from the
77 active file naturally stay the same from case to case, because the
78 procedure code keeps using that same case.
80 One of the compromises that comes with the new procedure code is
81 that the active file allocates and provides its own case, which
82 the procedure code then has to resize to provide room for any
83 other variables that should go in the case and then fill in the
84 values of "left" variables. Then, when we're done with that case,
85 we have to save the values of "left" variables to copy into the
86 next case read from the active file.
88 The caseinit code helps with this.
90 * automake.mk: Add new files.
92 * caseinit.c: New file.
94 * caseinit.h: New file.
96 2007-06-06 Ben Pfaff <blp@gnu.org>
98 * value.h (value_cnt_from_width): New function.
100 * variable.c (var_get_value_cnt): Use new function.
102 2007-06-06 Ben Pfaff <blp@gnu.org>
104 Add casegrouper, to allow cases read from a given casereader to be
105 broken into groups, each of which has its own casereader.
106 Generally cases are grouped based on having equal values for some
109 * automake.mk: Add new files.
111 * casegrouper.c: New file.
113 * casegrouper.h: New file.
115 2007-06-06 Ben Pfaff <blp@gnu.org>
117 Add interface to lexicographical ordering of cases.
119 * automake.mk: Add new files.
121 * case-ordering.c: New file.
123 * case-ordering.h: New file.
125 2007-06-06 Ben Pfaff <blp@gnu.org>
127 Add casereaders and casewriters, the basis of the new data processing
128 implementation. A casereader is a uniform interface to reading cases
129 from a data source; a casewriter is a uniform interface to writing
130 cases to a data sink.
132 * automake.mk: Add new files.
134 * casereader-filter.c: New file.
136 * casereader-provider.h: New file.
138 * casereader-translator.c: New file.
140 * casereader.c: New file.
142 * casereader.h: New file.
144 * casewriter-provider.h: New file.
146 * casewriter-translator.c: New file.
148 * casewriter.c: New file.
150 * casewriter.h: New file.
152 2007-06-06 Ben Pfaff <blp@gnu.org>
154 "casewindow" data structure that extends the deque (from libpspp)
155 of cases with the ability to dump cases to disk if we get too many
158 * automake.mk: Add new files.
160 * casewindow.c: New file.
162 * casewindow.h: New file.
164 2007-06-06 Ben Pfaff <blp@gnu.org>
166 sparse_cases data structure that augments a sparse_array of cases
167 with the ability to dump cases to disk if we get too many cases in
170 * automake.mk: Add new files.
172 * sparse-cases.c: New file.
174 * sparse-cases.h: New file.
176 2007-06-06 Ben Pfaff <blp@gnu.org>
178 Adds a low-level on-disk case array data structure.
180 * automake.mk: Add new files.
182 * case-tmpfile.c: New file.
184 * case-tmpfile.h: New file.
186 2007-06-06 Ben Pfaff <blp@gnu.org>
188 In a couple of places we calculate the maximum number of cases to
189 keep in memory based on the user-defined workspace. Enable
190 centralizing the calculation through a new function.
192 * settings.c (get_workspace_cases): New function.
194 2007-06-06 Ben Pfaff <blp@gnu.org>
196 The casenumber type is defined in transformations.h, but case.h is
197 a more sensible place. Move it.
199 * case.h (CASENUMBER_MAX): New macro.
200 (typedef casenumber): Move here, from transformations.h.
202 2007-06-03 Ben Pfaff <blp@gnu.org>
204 Slightly generalize case_to_values and case_from_values functions.
206 * case.c (case_to_values): Rename case_copy_out, change interface.
207 (case_from_values): Rename case_copy_in, change interface.
209 * fastfile.c (fastfilereader_get_next_case): Update caller.
210 (write_case_to_disk): Ditto.
212 2007-06-02 Ben Pfaff <blp@gnu.org>
214 Clean up after a forgotten part of patch #5829.
216 * casedeque.h: Remove unused file.
218 * automake.mk: Remove casedeque.h from sources.
220 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
222 * category.c: Removed redundant #include
224 2007-05-06 Ben Pfaff <blp@gnu.org>
226 Abstract the documents within a dictionary a little better.
227 Thanks to John Darrington for suggestion, initial version, and
230 * dictionary.c (struct dictionary): Change `documents' member from
231 char * to struct string.
232 (dict_clear): Destroy struct string.
233 (dict_get_documents): Convert struct string to char *.
234 (dict_set_documents): Set struct string. Pad to 80-character
236 (dict_clear_documents): New function.
237 (dict_add_document_line): New function.
238 (dict_get_document_line_cnt): New function.
239 (dict_get_document_line): New function.
241 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
243 * sys-file-reader.c (read_documents): Use new document functions.
245 2007-04-19 John Darrington <john@darrington.wattle.id.au>
247 * sys-file-reader.c: When reading a system file which has no
248 long name table, automatically create one where the long names
249 are the lower case versions of the short names.
251 2007-04-22 Ben Pfaff <blp@gnu.org>
253 * dictionary.c (dict_set_split_vars): dict_destroy expects that
254 dict_clear will free most data related to the dictionary.
255 dict_clear does a decent job, except that dict_set_split_vars on
256 some systems won't actually free the dict's "split" member.
257 Instead, it'll allocate a 1-byte region. Fix this.
259 * value.c (value_copy): New function.
260 (value_set_missing): Ditto.
262 2007-04-22 John Darrington <john@darrington.wattle.id.au>
264 * Deleted existing category.h and moved cat-routines.h into
265 category.h Encapsulated struct cat_vals better.
267 2007-04-19 John Darrington <john@darrington.wattle.id.au>
269 * sys-file-reader.c: When reading a system file which has no
270 long name table, automatically create one where the long names
271 are the lower case versions of the short names.
273 2007-04-16 John Darrington <john@darrington.wattle.id.au>
275 * sys-file-reader.c: Some versions of Other Software seem to
276 produce system files with string variables' measure set to
277 zero. We'll assume these are supposed to be nominal variables.
279 2007-03-30 Ben Pfaff <blp@gnu.org>
281 * procedure.c: Adapt to new deque data structure.
283 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
284 Ben Pfaff <blp@gnu.org>
286 * file-name.c: Mingw compatibility fixes.
287 (fn_search_path): Use ISSLASH instead of comparing against '/'
289 (fn_dir_name): Use dir_name from gnulib.
290 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
291 (fn_get_identity): Use GetFullPathName instead of canonicalize
292 from gnulib, because the latter does not fully support
293 Windows-style path names. Use this implementation based on the
294 detected presence of Windows instead of the absence of Unix, since
295 the new implementation is Windows-specific.
296 (fn_compare_file_identities): In Windows implementation, compare
297 names case-insensitively.
299 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
301 * make-file.c: Don't include mkstemp.h, because gnulib now causes
302 <stdlib.h> to have the same effect.
304 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
306 * por-file-reader.c: Add missing _() around messages.
308 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
310 * make-file.c: Include "mkstemp.h", without which linking on
313 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
315 Reduce platform dependence.
317 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
318 Everywhere we using this, we really should have just depended on
319 the shell to expand tildes.
320 (fn_search_path): Simplify, given that we don't do tilde expansion
322 (fn_normalize): Removed. Caller changed to use the canonicalize
324 (fn_get_cwd): Removed. Only user was fn_normalize.
325 (fn_is_absolute): Really only test for absolute names.
326 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
328 (fn_readlink): Removed, as it was only used fn_normalize.
329 (fn_exists): Assume the stat function is available; gnulib does.
330 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
332 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
334 * dictionary.c (dict_create_vector_assert): New function.
336 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
338 * file-name.c (fn_normalize): Correct name of function
339 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
340 for pointing this out.
342 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
344 We are using a single member in struct file_handle, the "name"
345 field, for more than one purpose. When it begins with '"', it's a
346 file name; otherwise, it's a token that can be used to identify
347 it. When that assertion fires, it's because we searched for the
348 name case-sensitively as a file name (so that there was no match),
349 and then we try to insert it case-insensitively as a token, which
350 fails because duplicates aren't allowed.
352 Solution: break the two purposes into two separate fields. This
353 fixes the problem and likely makes the code easier to read too.
355 Fixes bug #18922. Thanks to John Darrington for bug report and
358 * file-handle-def.c (struct file_handle): New `id' member.
359 (fh_from_name): Rename fh_from_id. Update all callers.
360 (create_handle): New `id' parameter. Update all callers.
361 (fh_create_file): Ditto.
362 (fh_get_id): New function.
364 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
366 * case.c (case_is_null): Change return type to bool.
368 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
372 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
373 reference counting to share data. This makes it easy for
374 valgrind, etc. to find accesses to cases that have been destroyed
375 but have been kept around by another user's ref-count. This often
376 happens when the data set is small enough to find in memory; if a
377 bigger data set that would overflow to disk were used, then data
378 corruption would occur.
380 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
384 * case.c (case_unshare): Make it check internally whether the
385 ref_cnt is greater than 1, so that the callers don't have to.
386 Update callers not to check.
388 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
390 Before, I was thinking that I might want to get rid of reference
391 counting at some point. Now, I'm pretty sure that it's here to
392 stay. Thus, because we have to store the value_cnt anyway for
393 reference-counted cases, we might as well expose it to users.
395 * case.c (case_get_value_cnt): New function.
396 (case_resize): Drop OLD_CNT argument. Update all callers. Only
397 resize case if its size actually changed.
399 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
400 instead of peeking inside struct case directly.
401 (casefile_append): Ditto.
403 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
405 Get rid of the inlines for the case functions, which made the
406 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
407 the inlines didn't speed up "make check" at all, which is not a
408 perfect benchmark but seems indicative.)
410 * case.c: Remove #ifdef DEBUGGING...#endif around many function
411 definitions. Remove some assertions on nonnull pointers that were
412 redundant with a pointer dereference soon after in the function.
414 (struct case_data): Move definition here from case.h.
418 (case_data_wr): Ditto.
420 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
422 * automake.mk: Add casedeque.h to sources.
424 * casedeque.h: New file.
426 * procedure.c: (struct dataset) Change lag_count, lag_head,
427 lag_queue member into single struct casedeque member. Update all
428 users to use the casedeque instead.
431 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
433 * procedure.c: Simplify lagged cases interface. Updated all
434 clients--well, the only client--to use the simplified interface.
435 (dataset_n_lag) Removed.
436 (dataset_set_n_lag) Removed.
437 (dataset_need_lag) New function.
439 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
441 * dictionary.c procedure.c: More changes to ensure that callbacks occur
442 whenever appropriate, but only when the dataset/dictionary is in a
445 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
447 * dictionary.c dictionary.h : Added callbacks for change of filter and
448 split variables. Refactored some code to ensure that callbacks get
449 invoked when appropriate.
451 * procedure.c (proc_cancel_temporary_transformations): Make sure that
452 replace_dict callback occurs when permanent_dict replaces the current
455 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
457 * dictionary.c dictionary.h : Added callback for when the weight
458 variable of a dictionary changes.
460 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
462 * dictionary.c dictionary.h : Added replace_source and replace_dict
463 callbacks, and functions to deal with them.
465 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
467 Simplify missing value handling.
469 * missing-values.h (enum mv_class): New type.
470 (enum mv_type): Moved definition into missing-values.c and renamed
471 each MV_* to MVT_*, to distinguish them from the exposed mv_class
472 enums. Updated all uses.
473 (struct missing_values): Changed type of `type' from `enum
474 mv_type' to `int' because the definition is no longer exposed.
476 * missing-values.c (mv_is_value_missing): Add new enum mv_class
477 parameter. Update all callers.
478 (mv_is_num_missing): Ditto.
479 (mv_is_str_missing): Ditto.
480 (mv_is_value_user_missing): Removed. Changed callers to use
482 (mv_is_num_user_missing): Removed. Changed callers to use
484 (mv_is_str_user_missing): Removed. Changed callers to use
486 (mv_is_value_system_missing): Removed. Changed callers to use
488 (mv_set_type): Removed. Changed callers to use mv_clear.
489 (mv_clear): New function.
491 * variable.c (var_is_value_missing): Add new enum mv_class
492 parameter. Update all callers.
493 (var_is_num_missing): Ditto.
494 (var_is_str_missing): Ditto.
495 (var_is_value_user_missing): Removed. Changed callers to use
496 var_is_value_missing.
497 (var_is_num_user_missing): Removed. Changed callers to use
499 (var_is_str_user_missing): Removed. Changed callers to use
501 (var_is_value_system_missing): Removed. Changed callers to use
502 var_is_value_missing.
504 * casefilter.c (struct casefilter): Use enum mv_class in place of
506 (casefilter_variable_missing): Adapt to new member.
507 (casefilter_create): Change signature to take enum mv_class,
510 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
512 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
514 * case-sink.c case-sink.h procedure.c procedure.h
515 storage-stream.c: Now uses the factory.
517 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
519 Make it possible to pull cases from the active file with a
520 function call, instead of requiring indirection through a callback
523 * case-source.h (struct case_source_class): Change ->read function
524 to return a single case, instead of calling a callback function
525 for each case. Change ->destroy function to return an error
528 * case-source.c (free_case_source): Pass along the value returned
529 by the case_source ->destroy function.
531 * procedure.c (struct write_case_data): Removed.
532 (struct dataset): Added some members to track procedure state.
533 (procedure): Optimize the trivial case at this level.
534 (internal_procedure): Re-implement in terms of proc_open,
535 proc_read, proc_close.
536 (proc_open) New function.
537 (proc_read) New function.
538 (proc_close) New function.
539 (write_case) Moved into proc_read.
540 (close_active_file) Moved closing of data source into proc_close.
542 * storage-source.c: Rewrote to conform with modified
543 case_source_class interface.
545 * transformations.c (trns_chain_execute): Added argument to allow
546 starting execution from an arbitrary transformation. Updated
549 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
551 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
553 * sys-file-reader.c (read_display_parameters): Don't assume that
554 MEASURE_* and ALIGN_* have the same values found in system files.
556 * sys-file-writer.c (write_variable_display_parameters): Ditto.
558 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
559 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
560 the value of n_MEASURES, which was off by 1 (at least from my
563 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
565 * dictionary.c dictionary.h vardict.h variable.c: Added optional
566 callbacks which are invoked when the dictionary or its
567 variables are changed.
569 * missing-values.c missing-values.h value-labels.c: Tidied up
570 consistency checks, and made some of them return false
571 instead of assert-failing.
573 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
575 * calendar.c (calendar_days_in_month): New function.
577 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
579 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
580 the value label's width.
582 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
584 * sfm-private.h: Move contents into sys-file-writer.c, which is
585 the only remaining user. Removed Borland C++-specific directives.
587 * sys-file-reader.c: Clean up and rewrite entire file. The
588 rewritten version is simpler and better abstracted, and should be
589 easier to maintain and extend. It avoids using structures to read
590 file data, which is prone to padding variations among compilers.
591 It should also handle non-IEEE 754 system files, although I
592 haven't been able to find any. It has been tested against many
593 .sav files obtained from the Web and found to produce the same
594 results as the earlier version of the code, or in some cases
595 improved results. It is more tolerant of format variations found
598 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
599 member, putting an enum integer_format in its place. New member
600 `float_format'. Changed `compressed' member to type bool.
602 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
604 * dictionary.c (dict_delete_consecutive_vars): New function.
606 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
608 * file-name.c (fn_search_path): Remove prefix arg that was unused
609 by any caller. Updated all callers.
611 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
613 * format.c (fmt_dollar_template): Use user's decimal point
614 character. Add assertion.
616 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
618 * format.c (fmt_dollar_template): New function, based on
619 dollar_format_template from var-type-dialog.c.
621 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
623 * data-out.c (output_scientific): Fix bad assumption that "buf" is
626 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
628 Finish converting struct variable to an opaque type. In this
629 phase, we add remaining setter and getter functions, convert the
630 remaining PSPP code to use them, and do a bunch of cleanup. The
631 resulting changes are pervasive but mostly trivial, and only the
632 notable changes are logged.
634 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
637 * case.c (case_data): Renamed case_data_idx.
638 (case_num): Renamed case_num_idx.
639 (case_str): Renamed case_str_idx.
640 (case_data_rw): Renamed case_data_rw_idx.
642 * case.h (case_data): New function with old name and an interface
643 that takes a variable instead of an index, which is easier to
644 use. Updated all callers to use the new interface, or to use the
645 new *_idx function (see above).
648 (case_data_rw): Ditto.
650 * category.c (cat_stored_values_destroy): Changed interface to
651 take a struct cat_vals * instead of a struct variable *.
653 * dictionary.c (dict_clone): Use new vector_clone function.
654 (dict_clear) Use new var_destroy function.
655 (add_var) New function.
656 (dict_create_var) Rewrite in terms of dict_create_var_assert.
657 (dict_create_var_assert) Rewrite in terms of add_var.
658 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
659 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
660 (dict_lookup_var) Use new var_create, var_destroy functions.
661 (dict_contains_var) Rewrite in terms of new vardict functionality.
662 (set_var_dict_index) New function.
663 (set_var_case_index) New function.
664 (reindex_vars) New function.
665 (dict_delete_var) Rewrite in terms of new vardict functionality.
666 (dict_reorder_var) Ditto.
667 (dict_reorder_vars) Ditto.
668 (rename_var) New function.
669 (dict_rename_var) Use rename_var.
670 (dict_rename_vars) Use pool to simplify code. Use rename_var.
671 (dict_get_compacted_idx_to_fv) Rename
672 dict_get_compacted_dict_index_to_case_index, update callers.
673 (dict_create_vector) Use new vector_create function.
674 (dict_clear_vectors) Use new vector_destroy function.
675 (set_var_short_name_suffix) Move here from variable.c, renamed
676 from var_set_short_name_suffix, make static, update caller.
678 * sys-file-private.c: New file.
679 (sfm_width_to_bytes) Moved here from variable.c, renamed from
680 width_to_bytes, update callers.
682 * sys-file-private.h: New file. Later it will supplant
683 sfm-private.h; for now it supplements it.
684 (macro MIN_VERY_LONG_STRING) New macro.
685 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
687 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
688 MAX_LONG_STRING was used before.
690 * sys-file-writer.c: Ditto.
692 * value-labels.c: Change the paradigm here to be that a null
693 pointer is OK for a struct val_labs * in most cases; it just
694 represents an empty set of value labels.
695 (val_labs_copy) A copy of a null set is a null set.
696 (val_labs_count) A null set has 0 labels.
697 (val_labs_replace) Change return type to void. Rewrite for
699 (val_labs_find) A null set does not contain the value.
700 (value_to_string) Moved to variable.c, renamed var_get_value_name,
701 transposed argument order, updated all callers.
704 (value_dup) Moved here from variable.c.
705 (compare_values) Ditto.
708 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
709 (macro MAX_LONG_STRING) Removed, because it was only interesting
710 for system files, not for general code.
711 (macro MAX_VERY_LONG_STRING) Ditto.
712 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
713 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
715 * vardict.h: New file, for an interface between variables and
718 * variable.c: A lot of functions were moved around, for better
720 (struct variable) Move definition here, from variable.h.
721 (var_type_adj) Removed--makes i18n hard.
722 (var_type_noun) Ditto.
723 (var_create) New function.
724 (var_clone) New function.
725 (var_destroy) New function.
726 (var_set_name) Assert that variable is not in a dictionary.
727 (compare_var_names) Rename compare_vars_by_name and fix a couple
728 of callers who thought the args were strings.
729 (hash_var_name) Rename hash_var_by_name.
730 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
731 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
732 (var_is_very_long_string) Removed, because it was only interesting
734 (var_set_missing_values) Allow the argument to be the wrong width,
735 as long as we can resize it. Simplify callers who were doing the
737 (var_get_value_labels) New function.
738 (var_has_value_labels) New function.
739 (var_set_value_labels) New function.
740 (alloc_value_labels) New function.
741 (var_add_value_label) New function.
742 (var_replace_value_label) New function.
743 (var_clear_value_labels) New function.
744 (var_lookup_value_label) New function.
745 (var_get_value_name) Moved here from variable.c, renamed from
746 var_get_value_name, transposed argument order, updated all
748 (var_to_string) Moved here, from variable-label.c.
749 (var_set_leave) New function.
750 (var_get_leave) New function.
751 (var_must_leave) New function.
752 (var_set_short_name_suffix) Moved to dictionary.c, renamed
753 set_var_short_name_suffix.
754 (var_get_dict_index) New function.
755 (var_get_case_index) New function.
756 (var_get_obs_vals) New function.
757 (var_set_obs_vals) New function.
758 (var_has_obs_vals) New function.
759 (var_get_vardict) New function.
760 (var_set_vardict) New function.
761 (var_has_vardict) New function.
762 (var_clear_vardict) New function.
763 (value_dup) Moved to value.c.
764 (compare_values) Ditto.
767 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
768 (enum ALPHA) Rename VAR_STRING, update all users.
770 * vector.c: New file.
771 (struct vector) Moved here, from variable.h.
772 (check_widths) New function.
773 (vector_create) New function.
774 (vector_clone) New function.
775 (vector_destroy) New function.
776 (vector_get_name) New function.
777 (vector_get_var) New function.
778 (vector_get_var_cnt) New function.
779 (compare_vector_ptrs_by_name) New function.
781 * vector.h: New file.
783 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
785 * casefilter.c (casefilter_variable_missing): Avoided comparision of
786 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
789 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
791 * value-labels.c (destroy_atoms): New function.
792 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
794 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
796 Thanks to Jason Stover for pointing out this problem.
798 * data-out.c (output_number): Use gsl_finite from GSL, which is
799 portable, instead of isfinite, which is not.
802 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
804 * variable.c variable.h (value_dup): New function.
806 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
808 Start converting struct variable to an opaque type. In this
809 phase, we add a bunch of setter and getter functions and convert
810 most of the PSPP code to use them. The resulting changes are
811 pervasive but mostly trivial, and only the notable changes are
814 * format.c (fmt_equal): New function.
816 * variable.c (var_type_is_valid): New function.
817 (measure_is_valid) Moved here, from format.c.
818 (alignment_is_valid) Moved here, from format.c.
819 (var_get_name) New function.
820 (var_set_name) New function.
821 (width_to_type) New function.
822 (var_get_type) New function.
823 (var_get_width) New function.
824 (var_set_width) New function.
825 (var_is_numeric) New function.
826 (var_is_alpha) New function.
827 (var_is_short_string) New function.
828 (var_is_long_string) New function.
829 (var_is_very_long_string) New function.
830 (var_get_missing_values) New function.
831 (var_set_missing_values) New function.
832 (var_clear_missing_values) New function.
833 (var_has_missing_values) New function.
834 (var_is_value_missing) New function.
835 (var_is_num_missing) New function.
836 (var_is_str_missing) New function.
837 (var_is_value_user_missing) New function.
838 (var_is_num_user_missing) New function.
839 (var_is_str_user_missing) New function.
840 (var_is_value_system_missing) New function.
841 (var_get_print_format) New function.
842 (var_set_print_format) New function.
843 (var_get_write_format) New function.
844 (var_set_write_format) New function.
845 (var_set_both_formats) New function.
846 (var_get_label) New function.
847 (var_set_label) New function.
848 (var_clear_label) New function.
849 (var_has_label) New function.
850 (var_get_measure) New function.
851 (var_set_measure) New function.
852 (var_get_display_width) New function.
853 (var_set_display_width) New function.
854 (var_get_alignment) New function.
855 (var_set_alignment) New function.
856 (var_get_value_cnt) New function.
857 (var_get_leave) New function.
858 (var_get_short_name) New function.
860 * variable.h: (struct variable) Removed "type" and "nv" members;
861 they are now computed from "width" where needed.
863 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
865 * missing-values.c (mv_resize): Don't write beyond end of the
866 allocated buffer when resizing a long string.
868 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
870 Clean up identifier code: don't require identifier enumerations to
871 be in a particular order; make better use of string library;
872 expose less of the internals.
874 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
875 change interface. Updated all callers.
876 (lex_id_match) Change interface to use struct substring, update
878 (lex_id_match_len) Removed. Update callers to use lex_id_match.
879 (global array keywords[]) Make static, change form. Update all
880 users to use lex_id_name instead.
881 (lex_is_keyword) New function.
882 (lex_id_to_token) Change interface to use struct substring, update
884 (lex_id_name) New function.
886 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
887 lex_is_keyword instead.
888 (T_LAST_KEYWORD) Removed.
889 (T_N_KEYWORDS) Removed.
891 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
893 * format.c: (fmt_date_template) Distinguish characters for which a
894 space is output and any date delimiter is allowed on input, from
895 those for which a space is output and only a space is allowed on
896 input. The former is represented by X, the latter by a space.
897 Also, drop distinction between h and H, changing the former to the
900 * data-in.c: Completely rewrite internals to conform to SPSS input
901 formats as closely as possible.
902 (data_in) Changed external interface by replacing the structure
903 that was used as a single argument by a set of arguments. Updated
905 (data_in_finite_line) Removed. Converted all callers to use plain
907 (data_in_get_integer_format) New function.
908 (data_in_set_integer_format) New function.
909 (data_in_get_float_format) New function.
910 (data_in_set_float_format) New function.
912 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
913 (struct data_in) Removed.
915 * data-out.c: (output_date) Drop each component from the input as
916 it is output, to allow us to drop the distinction between h (a
917 count of hours) and H (the hour of day) template characters.
918 Also, handle new X template character.
919 (output_scientific) Follow more rational rule on when to drop
920 fraction introduced between SPSS 13 and 15. Updated test case to
923 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
925 Fix buffer overflow reported by John Darrington.
927 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
928 realize that DIGITS is a count of nibbles, not of bytes.
930 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
932 * calendar.c (calendar_offset_to_gregorian) Also return the
933 year-of-day. Change callers to new interface.
935 * data-out.c: Completely rewrite internals to conform to SPSS
936 output formats as completely as possible.
937 (data_out) Change interface to put input parameters before output
938 parameters, for consistency with the style I now prefer. Update
940 (data_out_get_integer_format) New public function.
941 (data_out_set_integer_format) New public function.
942 (data_out_get_float_format) New public function.
943 (data_out_set_float_format) New public function.
945 * data-out.h: New file. Move prototype for data_out here, from
948 * format.c: (fmt_step_width) Use equality comparison instead of
949 bitwise and, for clarity.
950 (fmt_is_string) Ditto.
951 (fmt_input_to_output) Fix categories that are translated to F
954 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
956 * casefilter.c casefilter.h (new files), casefile.c casefile.h
957 casefile-private.h: Added casefilter to assist commands with missing
960 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
962 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
964 * settings.c: (route_errors_to_terminal) New variable.
965 (route_errors_to_listing) New variable.
966 (get_error_routing_to_terminal) New function.
967 (set_error_routing_to_terminal) New function.
968 (get_error_routing_to_listing) New function.
969 (set_error_routing_to_listing) New function.
971 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
973 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
975 * format.c: Completely rewrite, to achieve better abstraction.
976 Rewrite all references to formats in other files.
978 * format.def: Rewrite and reorganize.
980 * settings.c: Move everything related to custom currency formats
981 into format.[ch], changing them in form, so as to group related
982 code and definitions better. Changed all references to use the
984 (static var decimal) Removed.
985 (static var grouping) Removed.
986 (static var cc) Removed.
987 (get_decimal) Removed.
988 (set_decimal) Removed.
989 (get_grouping) Removed.
990 (set_grouping) Removed.
994 * settings.h: (macro CC_CNT) Removed.
995 (macro CC_WIDTH) Removed.
996 (struct custom_currency) Removed.
998 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1000 * data-in.c (data_in): Use switch statement instead of table, to
1001 avoid dependence on the order of the FMT_* enums.
1003 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1005 * data-out.c: (num_to_string) Removed, because it was dead code.
1007 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1009 * data-in.c (parse_trailer): Fix error message.
1011 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1013 * format.c (fmt_is_binary): New function.
1015 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1017 * procedure.c procedure.h: Encapsulated the static data into a single
1020 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1022 * casefile.c (casereader_read_xfer): Always initialize the case,
1023 even on an error condition.
1025 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1027 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1028 entire function useless.
1030 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1032 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1033 casereader method casereader_clone.
1035 * procedure.c pransformations.h: Introduced new type casenum_t
1037 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1039 * variable.c: (width_to_bytes) Rephrase code for clarify.
1041 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1043 * format.c: (fmt_type_from_string) New function.
1044 (fmt_to_string) Include decimals in output if the format has
1045 decimals, even if the format type does not. This way, we can
1046 accurately reproduce incorrect formats in user output.
1047 (check_common_specifier) Make the check for a bad format type an
1048 assertion, so we get bug reports if they show up. Fix message.
1049 Check for decimal places with a format type that doesn't allow
1051 (check_input_specifier) Remove check for FMT_X, which has been
1053 (check_output_specifier) Ditto.
1055 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1057 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1058 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1059 (enum fmt_parse_flags) Removed.
1061 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1063 * casefile.c casefile.h: Converted to an abstract base class.
1064 * casefile-private.h fastfile.c fastfile.h: New files.
1065 * automake.mk procedure.c scratch-writer.c storage-stream.c
1067 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1069 * procedure.c (internal_procedure): Create sink_case with only as
1070 many values as the compacted dictionary.
1072 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1074 Remove "debugging" code that caused plenty of false positives and
1077 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1079 * case.c: Remove all references to `this' member.
1081 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1083 Fix link error noted by Jason Stover.
1085 * storage-stream.c: Include <assert.h>.
1087 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1089 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1090 ALL) and additional underlying system file issues.
1092 Thanks to John Darrington for review.
1094 First problem: var_hash points to variables not owned by the
1095 sys-file-reader, which the caller may free or modify. Use an
1096 array of sfm_vars instead, as done earlier (e.g. CVS version
1099 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1100 members and remove all code that references it. Add vars, var_cnt
1101 members. Remove fix_specials member, which was unused.
1102 (struct sfm_var) Remove name member, which was unused.
1103 (sfm_close_reader) Free vars member instead of var_hash.
1104 (compare_var_shortnames) Removed.
1105 (hash_var_shortname) Removed.
1106 (sfm_open_reader) Fill out vars array.
1107 (compare_var_index) Removed.
1108 (sfm_read_case) Use vars instead of var_hash.
1110 Second problem: we're confused about when we actually have very
1111 long strings, causing us to choose incorrectly between slow path
1112 and fast path in sfm_read_case.
1114 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1115 have very long strings, not when we have long variable names,
1116 which is an unrelated feature.
1118 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1120 * variable.h: Move var_set and variable parsing declarations to
1121 new header, src/language/lexer/variable-parser.h. Modified lots
1122 of files to include the new header.
1124 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1126 * value-labels.c (value_to_string): When there's no value label,
1127 format the variable according to its print format, instead of
1128 always effectively using A or F format.
1130 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1132 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1135 * format.c: Removed tortological assertion.
1137 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1139 Reform string library.
1141 * file-name.c (fn_interp_vars): Change interface to take a
1142 substring as input. Updated all users.
1144 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1146 * format.c (measure_is_valid): Really return false when m >=
1149 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1151 Implement random access to casefiles, for use in GUI.
1153 * casefile.c: (struct casereader) Add `random', `file_ofs',
1154 `buffer_ofs' members.
1155 (casefile_get_random_reader) New function.
1156 (read_open_file) Break part into new function
1157 seek_and_fill_buffer().
1158 (fill_buffer) Update buffer_ofs, file_ofs.
1159 (casereader_seek) New function.
1161 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1163 * settings.c: Added call to i18n{done, init}.
1165 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1167 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1170 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1172 * casefile.c: Convert many uses of `int' to `bool'.
1174 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1176 * transformations.c (trns_chain_destroy): Destroy chain's trns
1177 member, to fix memory leak.
1179 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1181 * storage-stream.c (storage_source_decapsulate): Destroy case
1182 source to fix memory leak.
1184 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1186 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1187 case passed as argument instead of initializing the argument as a
1188 case. Fixes memory leak that showed up in
1189 tests/command/aggregate.sh with scratch files.
1191 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1193 * procedure.c (proc_done): Destroy default_dict, to fix memory
1196 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1198 Simplify procedure_with_splits().
1200 * procedure.c (struct split_aux_data): Removed case_count member.
1201 (procedure_with_splits) Don't initialize case_count.
1202 (split_procedure_case_func) Check whether prev_case is null
1203 instead of case_count.
1204 (split_procedure_end_func) Ditto.
1206 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1208 * case.c (case_move): Do nothing if dst and src are the same
1210 (case_try_create) Merge two similar cases.
1211 (case_copy) Unshare only if data must be actually copied.
1213 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1215 * data-in.c data-out.c dictionary.c sys-file-reader.c
1216 sys-file-writer.c variable.c variable.h: Reworked very long string
1217 support for better encapsulation.
1219 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1221 * value-labels.c (val_labs_can_set_width): New function.
1222 (val_labs_set_width) Clear labels if increasing width to long
1224 (val_labs_destroy) Remove unneeded test for null.
1226 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1228 * value-labels.h: Remove unneeded dependency on variable.h.
1230 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1232 Get rid of `char *c' member in union value, for cleanliness.
1234 * value.h: (union value) Remove `c' member.
1236 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1238 Make dictionary compacting functions a little more general.
1240 * sys-file-writer.c (sfm_open_writer): Use
1241 dict_compacting_would_change().
1242 (does_dict_need_translation) Removed.
1244 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1246 Make dictionary compacting functions a little more general.
1248 * dictionary.c (dict_needs_compaction): Rename
1249 dict_compacting_would_shrink(). Update all callers.
1250 (dict_compacting_would_change) New function.
1252 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1254 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1255 inverted return value (!).
1257 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1259 Continue reforming procedure execution.
1261 * procedure.c: Search and replace "vfm" by "proc". Notably:
1262 (static var vfm_source) Rename proc_source. Update all
1264 (static var vfm_sink) Rename proc_sink. Update all references.
1266 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1268 Continue reforming procedure execution. In this phase, remove
1269 PROCESS IF, which was deprecated anyway and can be easily
1270 simulated with TEMPORARY followed by SELECT IF.
1272 * procedure.c: (open_active_file) Don't call
1273 add_process_if_trns().
1274 (discard_variables) Get rid of redundant call to
1275 proc_cancel_all_transformations().
1276 (add_process_if_trns) Removed.
1277 (process_if_trns_proc) Removed.
1278 (process_if_trns_free) Removed.
1280 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1282 Continue reforming procedure execution. In this phase, add
1283 `const' to the case passed to procedure()'s callback.
1285 Updated all users of procedure() as well.
1287 * procedure.c: (struct write_case_data) Add "const" to ccase
1288 parameter for case_func member.
1289 (procedure) Add "const" to ccase parameter for proc_func
1291 (multipass_case_func) Make ccase parameter const.
1292 (internal_procedure) Add "const" to ccase parameter for case_func
1294 (split_procedure_case_func) Make ccase parameter const.
1295 (multipass_split_case_func) Make ccase parameter const.
1297 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1299 Continue reforming procedure execution. In this phase, get rid of
1300 the output code for SPLIT FILE groups in procedure.c, which really
1301 shouldn't be doing any output. Move it into the individual
1302 procedures instead. This also adds some flexibility.
1304 Updated many users of procedure_with_splits() and
1305 multipass_procedure_with_splits() to call
1306 output_split_file_values() and to deal with increased use of
1309 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1310 parameter to begin_func member.
1311 (procedure_with_splits) Add "const struct ccase *" parameter to
1312 begin_func parameter. Make ccase parameter const in proc_func
1314 (split_procedure_case_func) Don't dump split file group. Pass
1316 (dump_splits) Moved to language/dictionary/split-file.c as
1317 output_split_file_values().
1318 (struct multipass_split_aux_data) Add "const struct ccase *"
1319 parameter to split_func member.
1320 (multipass_procedure_with_splits) Add "const struct ccase *"
1321 parameter to split_func parameter.
1322 (multipass_split_case_func) Save new SPLIT FILE case before
1324 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1326 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1328 Continue reforming procedure execution. Change
1329 internal_procedure() so that it calls open_active_file() and
1330 close_active_file(), which isolates most of the actual procedure
1333 * procedure.c: (struct write_case_data) Rename `proc_func' member
1334 to `case_func' and update all references.
1335 (procedure) Rewrite as one-line wrapper around
1336 internal_procedure().
1337 (struct multipass_aux_data) New.
1338 (multipass_callback) Renamed multipass_case_func(). Use struct
1339 multipass_aux_data as auxiliary data.
1340 (multipass_end_func) New function.
1341 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1342 that uses multipass_case_func, multipass_end_func.
1343 (internal_procedure) Add `end_func' argument. Move optimization
1344 of trivial case in here. Move call to open_active_file() and
1345 close_active_file() in here. Now assert that vfm_source is
1347 (procedure_with_splits_callback) Rename
1348 split_procedure_case_func().
1349 (split_procedure_end_func) New function.
1350 (multipass_split_callback) Rename multipass_split_case_func.
1351 (multipass_split_end_func) New function.
1352 (discard_variables) No need to test for nonnull vfm_source.
1354 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1356 Continue reforming procedure execution. Get rid of unused member.
1358 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1360 (write_case) Don't increment cases_analyzed.
1362 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1364 Continue reforming procedure execution. In this phase, move
1365 procedure.c and procedure.h from src to src/data. Update
1366 makefiles and #includes accordingly.
1368 * procedure.c: Moved here from src/.
1370 * procedure.h: Moved here from src/.
1372 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1374 Continue reforming procedure execution. In this phase, get rid of
1375 many global variables, consolidating procedure execution in
1376 procedure.c. Encapsulate transformations in new "struct
1377 trns_chain". Also, change implementation of N OF CASES, FILTER,
1378 and PROCESS IF from special cases to transformations.
1380 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1383 * dictionary.c: (global variable default_dict) Move to
1386 * variable.h: (TRNS_*) Move to transformations.h.
1387 (struct transformation) Move to transformations.c.
1389 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1391 * sys-file-reader.c: Fixed invalid read problems.
1393 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1395 * storage-stream.c: Add missing function comments.
1397 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1399 Continue reforming procedure execution. In this phase, add some
1400 new, needed functionality to storage-stream.
1402 * storage-stream.c: (storage_source_decapsulate) New function.
1404 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1406 * variable.c (width_to_bytes): Declarations must precede
1407 statements for C90 compliance.
1409 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1411 * data-out.c, data-in.c, variable.c, variable.h: New functions
1412 copy_mangle and copy_demangle for reading/writing cases; emulates the
1413 way SPSS deals with strings > 255 bytes.
1415 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1416 subtype 14 needed for strings longer than 255 bytes.
1418 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1419 instead of literal values. Also fixed some constness issues.
1421 * format.h: Constness
1423 * sfm-private.h: Renamed the case_size identifier, since I discovered
1424 that SPSS's respect for this variable is very nominal.
1426 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1428 Change case limit type from int to size_t.
1430 * dictionary.c: (struct dictionary) Change type of case_limit
1432 (dict_get_case_limit) Change return type.
1433 (dict_set_case_limit) Change parameter type.
1435 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1437 * variable.h: (struct variable) Rename `reinit' member as `leave'
1438 and invert sense. Fix up all references.
1440 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1442 Continue reforming procedure execution. In this phase, break
1443 procedure.c into multiple files.
1445 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1447 * case-sink.c: New file.
1449 * case-sink.h: New file.
1451 * case-source.c: New file.
1453 * case-source.h: New file.
1455 * storage-stream.c: New file.
1457 * storage-stream.h: New file.
1459 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1461 * variable.h: (struct variable) Remove `init' member and all
1462 references to it from other files. It was initialized in several
1463 places, but nothing really ever used it for anything worthwhile.
1464 Thanks to Jason Stover for pointing out how confusing this
1467 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1469 Continue reforming error message support. In this phase, get rid
1470 of message "titles" and put the message text in `struct error'.
1471 Now `struct error' encapsulates a message more properly.
1473 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1474 Format message ourselves.
1476 * data-in.c: (vdls_error) Ditto.
1478 * por-file-reader.c: (error) Ditto.
1480 * sys-file-reader.c: (corrupt_msg) Ditto.
1482 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1484 GNU standards require "file name" instead of "filename" in
1485 documentation. It's nice for our code to follow the convention
1488 * casefile.c: (struct casefile) Rename `filename' member to
1489 `file_name'. Updated all references.
1491 * file-name.c: [!unix] (struct file_identity) Rename
1492 normalized_filename member to normalized_file_name. Updated all
1495 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1497 We don't really support anything but Unix-like environments well,
1498 so we might as well de-obfuscate by writing directory and path
1499 separators explicitly.
1501 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1503 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1504 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1506 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1509 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1511 GNU standards require "file name" instead of "filename" in
1512 documentation. It's nice for our code to follow the convention
1515 * filename.c: Rename to file-name.c.
1517 * filename.h: Rename to file-name.h. Update all inclusions.
1518 Update header guards.
1520 * automake.mk: Update file names.
1522 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1524 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1526 (fn_basename) Removed (dead code).
1527 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1528 (fn_special_p) Renamed fn_is_special(), all references updated.
1529 (fn_exists_p) Renamed fn_exists(), all references updated.
1531 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1533 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1534 Also, now it only tilde-expands file names, not paths.
1535 (fn_search_path) Tilde-expand one directory at a time.
1537 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1539 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1540 get rid of non-Unixlike version of the code, which has probably
1542 (fn_prepend_dir) Removed (dead code).
1544 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1545 (macro PATH_SEPARATOR_STRING) New.
1546 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1548 Continue reforming error message support. In this phase, we get
1549 rid of VM() and the other msg() support for "verbosity", replacing
1550 it by a new function verbose_msg().
1552 * filename.c: (fn_search_path) Use verbose_msg() instead of
1555 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1557 * sfm-private.h: Get rid of #defines after #error, which makes no
1560 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1562 Get rid of our own int32 type in favor of the standard int32_t
1565 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1568 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1570 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1572 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1574 Remove ill-considered file routines that are no longer used.
1576 * filename.c: (fn_open_ext) Removed.
1577 (fn_close_ext) Removed.
1579 * filename.h: (struct file_ext) Removed.
1581 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1583 * variable.c (var_is_valid_name): Move declarations before code
1586 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1588 * filename.ch (fn_interp_vars): Fixed small buglet.
1590 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1592 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1593 so as to modify the string inline. Thus makeing it easier to
1594 destroy the results when no longer needed.
1596 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1598 * category.c (cat_stored_values_destroy): Fixed memory leak.
1600 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1602 Add some missing frees. Thanks to John Darrington for reporting
1605 * any-writer.c (any_writer_close): Free writer.
1607 * any-reader.c (any_reader_close): Free reader.
1609 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1611 * por-file-reader.c: (error) Mark as NO_RETURN.
1613 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1615 * settings.c: Changed default value of scompress to true.
1617 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1619 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1621 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1624 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1625 here from pref.h.orig.
1627 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1629 * sys-file-reader.c: Fixed bug reading compressed files.
1631 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1633 * Numerous renames. See src/ChangeLog for details.
1635 * Moved files from src directory
projects / pspp-builds.git / blob