1 Mon Apr 24 14:11:33 2006 Ben Pfaff <blp@gnu.org>
3 * message.c: Use exit.h from gnulib instead of checking for and
4 defining EXIT_SUCCESS and EXIT_FAILURE by hand.
6 Sun Apr 23 22:00:23 2006 Ben Pfaff <blp@gnu.org>
8 Continue reforming error message support. In this phase, get rid
9 of message "titles" and put the message text in `struct error'.
10 Now `struct error' encapsulates a message more properly.
12 * message.c: (tmsg) Removed.
13 (msg) Use err_msg() instead of err_vmsg(). Format message
15 (err_vmsg) Renamed err_msg(). Changed interface, dropping message
16 and va_list args which are now in the error struct.
18 Sun Apr 23 20:35:28 2006 Ben Pfaff <blp@gnu.org>
20 Continue reforming error message support.
22 * message.c: Use linebreak module from gnulib instead of home-brew
24 (puts_stdout) Rewrote.
25 (dump_message) Rewrote. Changed interface and updated all callers.
26 (compulsory_break) Removed.
27 (char_is_break) Removed.
28 (break_before) Removed.
29 (break_after) Removed.
30 (macro BREAK_LONG_WORD) Removed.
32 Sun Apr 16 20:41:10 2006 Ben Pfaff <blp@gnu.org>
34 Continue reforming error message support. In this phase, we
35 divide the classification of messages along "category" and
38 * message.c: (err_vmsg) Rewrite to deal with categories and
39 severities in a straightforward manner instead of mixing them into
41 [0] (puts_stderr) Removed (dead code).
42 (msg) Changed first argument from `int' to `enum msg_class'.
45 Sun Apr 16 18:53:12 2006 Ben Pfaff <blp@gnu.org>
47 GNU standards require "file name" instead of "filename" in
48 documentation. It's nice for our code to follow the convention
51 Basically did search and replace in the whole source tree. Major
52 changes in function names or struct member names have their own
55 Sun Apr 16 15:58:56 2006 Ben Pfaff <blp@gnu.org>
57 Continue reforming error message support. In this phase, we get
58 rid of VM() and the other msg() support for "verbosity", replacing
59 it by a new function verbose_msg().
61 * message.c: (verbose_msg) New function.
62 (err_vmsg) Remove support for verbosity levels.
64 Sun Apr 16 11:46:51 2006 Ben Pfaff <blp@gnu.org>
66 Start reforming error message support. In this phase, we get rid
67 of "installation errors" and change all uses of msg() in the
68 output drivers to uses of error() or error_at_line().
70 * message.c: (err_vmsg) Get rid of IE, IS support.
72 Sat Mar 11 14:17:47 WST 2006 John Darrington <john@darrington.wattle.id.au>
74 * automake.mk: Changed the pattern specific AM_CPPFLAGS to two target
75 specific ones. Eventually there will be none at all.
77 * automake.mk: Moved the pspp binary to ui/terminal
79 Sat Mar 4 12:59:08 2006 Ben Pfaff <blp@gnu.org>
81 * In many source files, #include "compiler.h" to get GCC attribute
84 Sat Mar 4 12:28:09 2006 Ben Pfaff <blp@gnu.org>
86 * In many source files, replace INT_DIGITS by
87 INT_STRLEN_BOUND(int) and include intprops.h.
91 * Replaced '_' with '-' in most filenames.
93 * Renamed files as follows:
94 vfm.[ch] to procedure.[ch]
95 error.[ch] to message.[ch]
96 getl.[ch] to line-buffer.[ch]
97 mkfile.[ch] to make-file.[ch]
98 pfm-write.h to por-file-writer.h
99 pfm-write.c to por-file-writer.c
100 sfmP.h to sfm-private.h
101 lex-def.c to identifier.c
102 lex-def.h to identifier.h
103 sfm-read.c to sys-file-reader.c
104 sfm-read.h to sys-file-reader.h
105 sfm-write.h to sys-file-writer.h
106 sfm-write.c to sys-file-writer.c
107 chart.[ch] to chart-geometry.[ch]
110 vars-atr.c to variable.c
111 ctl-stack.c to control-stack.c
112 ctl-stack.h to control-stack.h
113 dfm-read.c to data-reader.c
114 dfm-write.c to data-writer.c
115 dfm-write.h to data-writer.h
116 dfm-read.h to data-reader.h
117 apply-dict.c to apply-dictionary.c
118 mis-val.c to missing-values.c
119 sysfile-info.c to sys-file-info.c
120 modify-vars.c to modifiy-variables.c
121 rename-vars.c to rename-variables.c
122 val-labs.c to value-labels.c
123 var-display.c to variable-display.c
124 var-labs.c to variable-label.c
125 format-prs.c to format-parser.c
126 range-prs.c to range-parser.c
127 range-prs.h to range-parser.h
128 subclist.c to subcommand-list.c
129 subclist.h to subcommand-list.h
130 vars-prs.c to variable-parser.c
131 descript.c to descriptives.c
132 sort-prs.c to sort-criteria.c/sort-cases.c
133 sort-prs.h to sort-criteria.h
134 sel-if.c to select-if.c
135 algorithm.c to array.c
136 algorithm.h to array.h
137 bitvector.h to bit-vector.h
142 readln.c to read-line.c
143 readln.h to read-line.h
144 cmdline.c to command-line.c
145 cmdline.h to command-line.h
148 Sat Feb 11 22:35:20 2006 Ben Pfaff <blp@gnu.org>
150 General clean-ups and minor bug fixes.
152 * filename.h: Move DIR_SEPARATOR, PATH_SEPARATOR here from
155 * lex-def.h: (macro CHAR_IS_ID1) Removed. All references changed
157 (macro CHAR_IS_IDN) Removed. All references changed to
160 * lex-def.c: (lex_is_id1) New function.
161 (lex_is_idn) New function.
162 (lex_skip_identifier) New function.
163 (lex_id_match_len) Return bool instead of int.
164 (lex_id_match) Ditto.
166 * command.c: (parse_command_name) Convert parsed words to
167 uppercase to make error messages easier to read.
168 (cmd_host) Fix return value.
170 * dfm-read.c: (read_inline_record) Use tokens to check for BEGIN
171 DATA, not specialized lexical analysis.
173 * print.c: (print_space_trns_proc) Count of lines should be `int',
174 otherwise we might never finish.
175 (print_space_trns_free) Close writer.
177 * lexer.c: (enum string_type) New enum.
178 (lex_get) Remove essentially unused local variable `cp'.
179 Use enum string_type values. Use parse_id().
180 (parse_id) New function.
181 (lex_look_ahead) Recognize octal strings too.
182 (strip_comments) New function.
183 (lex_get_line) Rewrite.
184 (lex_preprocess_line) Removed.
185 (convert_numeric_string_to_char_string) Use enum string_type.
186 (parse_string) Ditto.
188 * autorecode.c: (recode) Clone correct number of bytes based on
191 Sat Feb 11 22:34:38 2006 Ben Pfaff <blp@gnu.org>
193 Reduce dependencies on getl, and of getl.
195 * data-in.c: (vdls_error) Don't output different message depending
196 on whether we're interactive.
198 * getl.h: (struct getl_line_list) Removed.
199 (struct getl_script) Removed.
200 (GETL_PRPT_*) Removed.
201 (GETL_MODE_*) Removed.
202 (GETL_PROMPT_FIRST, GETL_PROMPT_LATER, GETL_PROMPT_DATA,
203 GETL_PROMPT_CNT) New enums.
205 * settings.c: (static var prompt) Removed.
206 (static var cprompt) Removed.
207 (static var dprompt) Removed.
208 (settings_done) Don't initialize prompt, cprompt, dprompt.
209 (get_prompt) Removed.
210 (set_prompt) Removed.
211 (get_dprompt) Removed.
212 (set_dprompt) Removed.
213 (get_cprompt) Removed.
214 (set_cprompt) Removed.
216 * pfm-read.c: (corrupt_msg) Don't show filename and line number,
217 to get rid of getl_location().
219 * sfm-read.c: (corrupt_msg) Ditto.
221 * getl.c: (struct getl_source) New.
222 (static var cur_source) New.
223 (static var last_source) New.
224 (static var DO_REPEAT_level) Removed.
225 (global var getl_head) Removed.
226 (global var getl_tail) Removed.
227 (getl_initialize) Call init_prompts().
228 (getl_add_file) Removed.
229 (getl_include) Removed.
230 (getl_add_DO_REPEAT_file) Removed.
231 (getl_handle_line_buffer) Removed.
232 (getl_close_file) Removed.
233 (getl_close_all) Removed.
234 (getl_is_separate) Removed.
235 (getl_set_separate) Removed.
236 (getl_reading_script) Removed.
237 (append_source) New function.
238 (include_source) New function.
239 (create_source) New function.
240 (create_syntax_file_source) New function.
241 (create_filter_source) New function.
242 (create_function_source) New function.
243 (create_interactive_source) New function.
244 (getl_append_syntax_file) New function.
245 (getl_include_syntax_file) New function.
246 (getl_include_filter) New function.
247 (getl_include_function) New function.
248 (getl_append_interactive) New function.
249 (getl_abort_noninteractive) New function.
250 (getl_is_interactive) New function.
251 (close_source) New function.
252 (getl_location) Use new `cur_source' var.
253 (getl_uninitialize) Use close_source(). Call uninit_prompts().
254 (read_syntax_file) New function.
255 (read_line_from_source) New function.
256 (do_read_line) New function.
257 (getl_read_line) Rewrite.
258 (static var prompts) New.
259 (static var current_style) New.
260 (init_prompts) New function.
261 (uninit_prompts) New function.
262 (getl_get_prompt) New function.
263 (getl_set_prompt) New function.
264 (getl_set_prompt_style) New function.
265 (get_prompt) New function.
267 * command.c: Merge the EXIT (aka Q, aka QUIT) and FINISH commands,
268 and make EXIT undocumented. EXIT was a PSPP extension that never
269 really entirely made sense.
271 (cmd_finish) Return CMD_EOF unconditionally.
272 (cmd_clear_transformations) Drop requirement of interactivity.
274 * command.def: Merge the EXIT (aka Q, aka QUIT) and FINISH
277 * repeat.c: Major changes to match getl revision.
278 (struct line_list) New struct.
279 (enum repeat_entry_type) New.
280 (struct repeat_entry) Made `type' an enum repeat_entry_type.
281 (struct repeat_block) New.
282 (static var repeat_tab) Removed.
283 (static var count) Removed.
284 (static var line_buf_head) Removed.
285 (static var line_buf_tail) Removed.
286 (cmd_do_repeat) Rewritten.
288 (append_record) Removed.
289 (recognize_keyword) New function.
290 (internal_cmd_do_repeat) Removed.
291 (parse_specification) New function.
292 (skip_indentor) New function.
293 (recognize_do_repeat) New function.
294 (recognize_end_repeat) New function.
295 (parse_lines) New function.
296 (create_vars) New function.
297 (parse_ids) Use enum repeat_entry_type.
298 (parse_strings) Ditto.
299 (find_DO_REPEAT_substitution) Renamed find_substitution(),
301 (perform_DO_REPEAT_substitutions) Renamed do_repeat_filter(),
303 (do_repeat_read) New function.
304 (do_repeat_close) New function.
306 * data-list.c: Don't need to keep track of eof from getl anymore,
307 because getl can tell us now.
308 (struct data_list_pgm) Removed `eof' member.
309 (cmd_data_list) Don't assign to `eof'.
310 (get_data_list_read_func) Renamed read_from_data_list(), changed
312 (read_from_data_list_fixed) Changed interface.
313 (read_from_data_list_free) Changed interface.
314 (read_from_data_list_list) Changed interface.
315 (data_list_trns_proc) Rewrote based on dfm_eof() and
317 (data_list_source_read) Check for dfm reader errors.
319 * dfm-read.c: (enum dfm_reader_flags) Removed DFM_EOF in favor of
320 new `eof_cnt' member in struct dfm_reader.
321 (struct dfm_reader) New `eof_cnt' member.
322 (dfm_close_reader) Check `eof_cnt', not DFM_EOF.
323 (dfm_open_reader) Initialize `eof_cnt'.
324 (read_inline_record) Set prompt style with
325 getl_set_prompt_style().
326 (read_record) Rewrite.
327 (cmd_begin_data) Set prompt style with getl_set_prompt_style().
329 * include.c: (cmd_include) Use getl_include_syntax_file().
331 * set.q: (cmd_set) Use getl_set_prompt().
333 * html.c: (postopen) Remove "source-file" expansion variable, to
334 avoid use of getl_location().
336 * postscript.c: (postopen) Remove "source-file" expansion
337 variable, to avoid use of getl_location().
339 * cmdline.c: (parse_command_line) Drop -c command line option,
340 because it wasn't very useful. -i command line option now calls
341 getl_append_interactive(). Use new getl function interfaces.
342 Drop support for clearing dictionary between syntax files and thus
343 the "+" command line syntax.
344 (static var pre_syntax_message) Remove description of now-gone -c
345 option. Remove "+" command line syntax.
347 * main.c: (main) Only call handle_error() if the return value is
349 (execute_command) Use getl_set_prompt_style(). Drop support for
350 clearing dictionary between syntax files.
351 (handle_error) Handle CMD_CASCADING_FAILURE. Don't call err_break().
353 * readln.c: Drop lots of #ifdefs. Now that the Autoconf tests are
354 pickier, we can just use HAVE_READLINE.
355 (static var welcomed) Move into welcome().
356 (welcome) Make `welcomed' a local static var. Check for and read
358 (global var getl_mode) Removed.
359 (global var getl_interactive) Removed.
360 (global var getl_prompt) Removed.
361 (getl_read_line) removed.
362 (readln_read) New function.
363 (read_console) Removed.
366 Sat Feb 11 22:16:21 2006 Ben Pfaff <blp@gnu.org>
368 Try to reduce some of the nastier dependencies on the error
369 module, and at the same time make PSPP nicer to deal with, by
370 getting rid of fatal errors. All the existing calls to msg (FE,
371 ...) or err_cond_fail() or err_failure() have been replaced by
372 propagating an error upward to the command-dispatch layer.
373 Unfortunately this propagation took a fair bit of extra mechanism,
374 because now a lot of functions can fail that couldn't before.
376 New command return value CMD_CASCADING_FAILURE which indicates to
377 the command processor that syntax file processing should be
378 abandoned. Many commands were modified to return
379 CMD_CASCADING_FAILURE. When this modification was trivial it
380 isn't mentioned in detail below.
382 Transformation procedures (trns_proc_func) and free functions
383 (trns_free_func) now have a `bool' return type, which is normally
384 true, but false when an I/O or other serious error occurs. All
385 transformation functions were modified to have this return type.
386 When this modification was trivial it isn't mentioned in detail
389 * pspp-error.h: (FE) Removed this error class.
391 * error.c: (err_failure) Removed.
392 (err_cond_fail) Removed.
393 (err_break) Removed (it was unused).
394 (err_check_count) Don't cause a fatal error--instead, stop reading
396 (err_vmsg) Don't have FE anymore, so no need to call terminate().
398 * any-reader.c: (any_reader_error) New function.
400 * any-writer.c: (any_writer_write) Propagate
401 scratch_writer_write_case()'s new return value.
402 (any_writer_error) New function.
403 (any_writer_close) Propagate underlying function's new return
406 * casefile.c: Add an "error state" to a casefile. A casefile that
407 encounters an I/O error enters the error state, and afterward
408 reading and writing cases fails.
409 (struct casefile) Add `ok' member.
410 (casefile_create) Set `ok' to true.
411 (casefile_destroy) Use io_error().
412 (casefile_error) New function.
413 (casefile_sleep) Now returns bool to indicate success.
414 (casefile_append) Ditto.
415 (casefile_append_xfer) Ditto.
416 (casefile_to_disk) Ditto.
417 (write_case_to_disk) Don't do anything in error state.
418 (flush_buffer) Don't do anything in error state. Use io_error().
419 (reader_open_file) Ditto.
421 (casereader_read) Don't do anything in error state. Handle
423 (casereader_read_xfer_assert) Removed, because now an I/O error
424 can occur even if the caller knows a case exists.
425 (io_error) New function.
427 * mkfile.c: (make_temp_file) Make failure non-fatal.
428 (make_unique_file_stream) Ditto.
430 * pfm-read.c: Add an error state.
431 (struct pfm_reader) Add `ok' member to indicate error state.
432 (error) Set `ok' to false.
433 (pfm_open_reader) Set `ok' to true. Make failure non-fatal.
434 (pfm_read_case) Don't do anything in error state.
435 (pfm_read_error) New function.
437 * pfm-write.c: Postpone most error checking in favor of checking
439 (pfm_open_writer) Make failure non-fatal. Check for write error
440 after writing header.
441 (buf_write) Don't do anything if error has occurred. Postpone
442 error checking. Change return type to void.
443 (write_float) Postpone error checking. Change return type to
446 (write_string) Ditto.
447 (write_header) Ditto.
448 (write_version_data) Ditto.
449 (write_format) Ditto.
451 (write_variables) Ditto.
452 (write_value_labels) Ditto.
453 (pfm_write_case) Don't do anything if error has occurred.
454 (pfm_write_error) New function.
455 (pfm_close_writer) Change return type to bool. Return false if an
458 * scratch-reader.c: (scratch_reader_error) New function.
460 * scratch-writer.c: (scratch_writer_write_case) Change return type
461 to bool. Propagate casefile error return.
462 (scratch_writer_error) New function.
463 (scratch_writer_close) Change return type to bool. Propagate
464 casefile error return.
466 * sfm-read.c: Add an error state.
467 (struct sfm_reader) Add `ok' member.
468 (sfm_open_reader) Initialize `ok'. Make errors non-fatal.
469 (buf_read) Set `ok' to false on error.
470 (buffer_input) Do nothing in error state. Set `ok' to false on
472 (read_compressed_data) Set `ok' false on error.
473 (sfm_read_case) Return false in error state.
474 (fread_ok) Set `ok' false on error.
475 (sfm_read_error) New function.
477 * sfm-write.c: Postpone most error checking in favor of checking
479 (sfm_open_writer) Make failure non-fatal. Check for write error
480 after writing header.
481 (write_header) Postpone error checking. Change return type to
483 (write_variable) Ditto.
484 (write_value_labels) Ditto.
485 (write_documents) Ditto.
486 (write_variable_display_parameters) Ditto.
487 (write_longvar_table) Ditto.
488 (write_rec_7_34) Ditto.
490 (ensure_buf_space) Ditto.
491 (sfm_write_case) Do nothing if write error has occurred.
492 (sfm_write_error) New function.
493 (pfm_close_writer) Change return type to bool. Return false if an
496 * var.h: Introduced a new return value for trns_proc_func that
497 means "a serious error has occurred, so abort the procedure
498 entirely". Because the hard-coded values of -1, -2, etc. were
499 becoming even a worse idea now, also introduced some macros for
500 them: TRNS_CONTINUE, TRNS_DROP_CASE, TRNS_ERROR, TRNS_NEXT_CASE,
501 TRNS_END_FILE. Also replaced all references to the hard-coded
502 values by uses of the macros.
504 * command.h: New command return value CMD_CASCADING_FAILURE which
505 indicates to the command processor that syntax file processing
508 * dfm-read.c: (dfm_open_reader) Make failure non-fatal.
509 (dfm_reader_error) New function.
510 (read_inline_record) Make unexpected end of file nonfatal.
511 (read_file_record) Make read error nonfatal.
512 (dfm_eof) Make second unexpected end of file nonfatal.
513 (cmd_begin_data) Make errors nonfatal.
515 * dfm-write.c: (dfm_open_writer) Make failure non-fatal.
516 (dfm_write_error) New function.
517 (dfm_put_record) Do nothing in error state. Now return error
519 (dfm_close_reader) Now return `bool' indicating error state.
521 * file-type.c: (file_type_source_read) Now return `bool'
522 indicating error state.
524 * get.c: (case_reader_source_read) Now return `bool' indicating
526 (case_writer_destroy) Ditto.
527 (case_writer_write_case) Ditto.
528 (struct mtf_proc) New member `ok' indicating error state.
529 (cmd_match_files) Initialize and deal with `ok'.
530 (mtf_processing_finish) Now return `bool' indicating I/O error.
531 (mtf_free_file) Renamed mtf_close_file(). Now return `bool'
532 indicating I/O error.
533 (mtf_free) Now return `bool' indicating I/O error.
534 (mtf_delete_file_in_place) Ditto.
535 (mtf_read_nonactive_records) Ditto.
536 (mtf_processing) Ditto.
538 * inpt-pgm.c: (input_program_source_read) Now return `bool'
539 indicating I/O error. Handle new TRNS_ERROR transformation return
542 * matrix-data.c: Introduce error state.
543 (cmd_matrix_data) Check error return values.
544 (read_matrices_without_rowtype) Now return `bool' indicating I/O
546 (matrix_data_read_without_rowtype) Ditto.
547 (dump_cell_content) Ditto.
548 (nr_output_data) Ditto.
549 (read_matrices_with_rowtype) Ditto.
550 (matrix_data_read_with_rowtype) Ditto.
551 (wr_output_data) Ditto.
553 * lexer.c: (lex_init) Make unexpected eof non-fatal.
555 (lex_look_ahead) Ditto.
556 (unexpected_eof) Removed.
557 (convert_numeric_string_to_char_string) Make unexpected eof
559 (parse_string) Ditto.
561 * flip.c: Make I/O errors non-fatal.
562 (struct flip_pgm) Add `pool', `output_buf' members.
563 (cmd_flip) Create and use pool. Propagate errors.
564 (destroy_flip_pgm) Rewrite, using pool.
565 (struct flip_sink_info) Removed.
566 (flip_sink_create) Use pool. Make errors non-fatal.
567 (flip_sink_write) Make errors non-fatal.
568 (flip_file) Make errors non-fatal. Make `bool' return type to
570 (flip_sink_destroy) Remove.
571 (static var flip_sink_class) Use NULL as destroy func, not
574 * sort.c: Make I/O errors non-fatal. Propagate errors.
575 (sort_active_file_in_place) Propagate errors.
576 (sort_active_file_to_casefile) Ditto.
577 (do_internal_sort) Ditto.
578 (do_external_sort) Ditto.
580 (destroy_initial_run_state) Propagate errors via new `bool' return
582 (merge) Propagate errors.
585 * output.c: [GLOBAL_DEBUGGING] Remove reentrancy detection,
586 because it used msg (FE, ...) and wasn't very useful.
588 * main.c: (handle_error) Handle CMD_CASCADING_FAILURE.
590 * vfm.c: (struct write_case_data) Change `proc_func' return type
592 (procedure) Add `bool' return type to indicate I/O error.
594 (internal_procedure) Ditto.
596 (execute_transformations) If a transformation returns TRNS_ERROR,
598 (close_active_file) Add `bool' return type to indicate I/O error.
600 (cancel_transformations) Add `bool' return type to indicate I/O
601 error. Propagate errors.
602 (struct split_aux_data) Change `proc_func' return type to bool.
603 (procedure_with_splits) Change `proc_func' return type to bool.
604 Add `bool' return type to indicate I/O error.
605 (multipass_procedure_with_splits) Change `split_func' return type
606 to bool. Add `bool' return type to indicate I/O error.
607 (multipass_split_callback) Add `bool' return type to indicate I/O
608 error. Propagate errors.
610 * vfm.h: (struct case_source_class) Change `read' return type from
611 void to bool to allow reporting I/O errors. Updated all
612 implementations to do so.
613 (struct case_sink_class) Change `write' return type from void to
614 bool to allow reporting I/O errors. Updated all implementations
617 Sun Feb 12 18:12:56 2006 Ben Pfaff <blp@gnu.org>
619 * pool.c: Useful new functions.
620 (pool_tmpfile) New function.
621 (pool_attach_file) New function.
622 (pool_detach_file) New function.
623 (pool_fopen) Reimplement in terms of pool_attach_file().
624 (pool_fclose) Reimplement in terms of pool_detach_file(). Fix
627 * str.c: Useful new functions.
628 (ds_swap) New function.
629 (ds_rtrim_spaces) New function.
630 (ds_chomp) New function.
631 (ds_is_empty) New function.
632 (ds_first) New function.
633 (ds_last) New function.
635 Sat Feb 11 21:51:21 2006 Ben Pfaff <blp@gnu.org>
637 Get rid of finished, start_interactive globals.
639 * command.c: (cmd_exit) Instead of setting `finished', return
643 * command.h: New enum CMD_EOF.
645 * main.c: (global var finished) Removed.
646 (global var start_interactive) Removed.
647 (main) Execute commands until CMD_EOF is the return value.
648 If parse_command_line() returns false, don't execute any commands
651 * cmdline.c: (parse_command_line) If the command line indicates we
652 shouldn't execute syntax files, return false instead of
654 (usage) Don't terminate.
656 Sat Feb 11 21:48:31 2006 Ben Pfaff <blp@gnu.org>
658 Get rid of cur_proc global. Replace by functions in err and tab
659 modules, which were the users.
661 * error.c: (static var command_name) New static var.
662 (err_vmsg) Use command_name.
663 (err_set_command_name) New function.
665 * tab.c: (static var command_name) New static var.
666 (tabi_title) Use command_name.
667 (tab_set_command_name) New function.
669 * command.c: (global var cur_proc) Removed.
670 (cmd_parse) Call err_set_command_name(), tab_set_command_name()
671 around executing command to set and clear command name.
673 Sat Feb 11 21:44:50 2006 Ben Pfaff <blp@gnu.org>
675 Get rid of glob.c, glob.h.
677 * Makefile.am: (pspp_SOURCES) Remove glob.c, glob.h.
679 * dictionary.c: Move default_dict definition here.
682 (global var FILTER_before_TEMPORARY) Variable removed. All
683 references deleted. The info in this var was redundant with
684 temp_dict, so they were changed to use temp_dict where needed.
688 * start-date.c: New file. Moved get_start_date() here.
690 * start-date.h: New file.
692 Fri Feb 3 20:34:52 2006 Ben Pfaff <blp@gnu.org>
694 * font.h: (struct font_set) Removed, because unused.
696 Sat Jan 28 17:45:36 2006 Ben Pfaff <blp@gnu.org>
698 Cleaner (faster?) way to compact cases.
700 * dictionary.c: (dict_compact_case) Removed.
701 (dict_needs_compaction) New function.
702 (struct copy_map) New structure.
703 (struct dict_compactor) New structure.
704 (dict_make_compactor) New function.
705 (dict_compactor_compact) New function.
706 (dict_compactor_destroy) New function.
708 Sat Jan 28 17:24:22 2006 Ben Pfaff <blp@gnu.org>
712 * data-list.c: Make data_list_source_class static.
713 (dump_fixed_table) Use fh_get_name() to describe source of data.
714 (dump_free_table) Ditto.
715 (cmd_repeating_data) Eliminate special cases for inline file.
717 * dictionary.c: (dict_contains_var) Change return value from int to
719 (dict_rename_vars) Ditto.
720 (dict_create_vector) Ditto.
722 Sat Jan 28 17:20:50 2006 Ben Pfaff <blp@gnu.org>
724 Add scratch file handles.
726 Now a file handle can refer to a disk file, to an in-memory
727 structure, or to the "inline" file, instead of just to a disk
728 file. The introduction of new categories means that special cases
729 for the inline file in a few places could be eliminated, but it
730 also means that code that assumed that a handle refers to a file
731 has to check for that.
733 Also, now file handles can be freed, so code now must be sure not
734 to access a handle after closing it (with fh_close()).
736 * Makefile.am: Add any-reader.c, any-reader.h, any-writer.c,
737 any-writer.h, scratch-handle.c, scratch-handle.h,
738 scratch-reader.c, scratch-reader.h, scratch-writer.c,
739 scratch-writer.h to pspp_SOURCES.
741 * any-reader.c: New file.
743 * any-reader.h: New file.
745 * any-writer.c: New file.
747 * any-writer.h: New file.
749 * scratch-handle.c: New file.
751 * scratch-handle.h: New file.
753 * scratch-reader.c: New file.
755 * scratch-reader.h: New file.
757 * scratch-writer.c: New file.
759 * scratch-writer.h: New file.
761 * aggregate.c: Use an any_writer instead of an sfm_writer, to add
764 * apply-dict.c: Use an any_reader instead of an sfm_reader, to add
767 * command.def: Add CLOSE FILE HANDLE command.
769 * dfm-reader.c: Now fewer special cases for inline file.
770 (static var inline_open_cnt) Removed.
771 (static var inline_file) Removed.
772 (dfm_close_reader) Eliminate a special case for inline file.
773 Reorganize to avoid access-after-free.
774 (dfm_open_reader) Eliminate a special case for inline file.
775 (read_inline_record) Use bool instead of int. No need to
776 increment line number.
777 (read_file_record) Use bool instead of int.
778 (read_record) Check whether file handle is inline file, instead of
781 (dfm_expand_tabs) Ditto.
784 (cmd_begin_data) Fix inaccurate check for whether the inline file
785 is in use--now we can tell by checking whether the inline file's
786 open count is positive.
788 * file-handle-def.c: (struct file_handle) Reorder members. Add
789 `deleted' member. Add `referent' member. Add `sh' member.
790 (static var default_handle) New variable.
791 (static var inline_file) New variable.
792 (fh_init) Initialize inline file.
793 (free_handle) New function.
795 (fh_from_name) Don't return deleted handles.
796 (fh_from_filename) Ditto.
798 (create_handle) New function.
799 (fh_create_file) New function.
800 (fh_create_scratch) New function.
801 (fh_inline_file) New function.
803 (fh_open) Now requires a referent type mask and verifies it. All
805 (fh_close) If open_cnt goes to 0 on a deleted handle, free it.
806 (fh_is_open) New function.
807 (fh_get_referent) New function.
808 (fh_get_filename) Limit to handles that refer to files.
810 (fh_get_record_width) Limit to handles that refer to files or the
812 (fh_get_tab_width) Ditto.
813 (fh_get_scratch_handle) New function.
814 (fh_set_scratch_handle) New function.
815 (fh_get_default_handle) New function.
816 (fh_set_default_handle) New function.
818 * file-handle.h: (enum fh_referent) New type.
819 (enum fh_mode) Rename MODE_TEXT to FH_MODE_TEXT, MODE_BINARY to
820 FH_MODE_BINARY, and update all usages.
822 * file-handle.q: Add "scratch" as a possible mode.
823 (cmd_file_handle) Mention CLOSE FILE HANDLE in error message.
824 Use lex_end_of_command(), lex_sbc_missing(). Support creating
826 (cmd_close_file_handle) New function.
827 (referent_name) New function.
828 (fh_parse) Now takes a referent type mask to specify handles that
829 can be accepted. Updated all references.
831 * filename.c: (fn_extension) New function.
833 * get.c: Use any_reader and any_writer and thereby merge code that
834 has been duplicated for each kind of file. Also, we had something
835 here called `any_writer' before, so its name had to be changed to
837 (enum operation) Removed, because unused.
838 (struct get_pgm) Removed.
839 (get_pgm_free) Removed.
840 (get_source_destroy) Removed.
841 (get_source_read) Removed.
842 (global var get_source_class) Removed.
843 (static var case_reader_source_class) Removed.
844 (enum reader_command) New enum.
845 (struct case_reader_pgm) New struct.
846 (parse_read_command) New function.
847 (case_reader_pgm_free) New function.
848 (case_reader_source_destroy) New function.
849 (case_Reader_source_Read) New function.
850 (cmd_get) Rewrote as a call to parse_read_command().
852 (struct any_writer) Rename to case_writer. Drop `writer_type',
853 `writer' members in favor of an `any_writer' member named
855 (any_writer_destroy) Rename case_writer_destroy. Use
857 (parse_write_command) Allow scratch files. Use any_writer.
858 (any_writer_write_case) Rename case_writer_write_case(). Use
860 ` (struct mtf_file) Use any_reader.
861 (cmd_match_files) Allow scratch files. Use any_reader.
862 (mtf_free_file) Use any_reader_close().
863 (mtf_read_nonactive_records) Use any_reader_read().
864 (mtf_processing) Use any_reader_read().
865 (struct import_pgm) Removed.
866 (import_pgm_free) Removed.
867 (import_source_destroy) Removed.
868 (import_source_read) Removed.
869 (global var import_source_class) Removed.
871 * glob.c: (global var default_handle) Removed. Replaced all
872 references by fh_get_default_handle() or fh_set_default_handle().
874 * pfm-read.c: (static var portable_to_local) Moved from inside
875 read_header() to top level.
876 (pfm_detect) New function.
878 * pfm-write.c: (pfm_write_case) Make case argument const.
879 Reorganize to avoid access-after-free.
881 * print.c: (dump_table) Use fh_get_name() to describe source of
884 * sfm-read.c: (sfm_close_reader) Reorganize to avoid
886 (sfm_detect) New function.
888 * str.c: (str_lowercase) New function.
890 * vfm.c: Use new compaction interface.
891 (static var compaction_necessary) Removed.
892 (static var compactor) New variable.
893 (open_active_file) Initialize compactor.
894 (write_case) Use compactor.
895 (close_active_file) Free compactor.
897 Wed Jan 11 19:28:39 2006 Ben Pfaff <blp@gnu.org>
899 Clean up file handle code in preparation to add scratch file
902 * file-handle-def.c: Lots of formatting cleanup. Added function
904 (struct file_handle) Renamed `length' member
905 to `record_width'. All references updated.
906 (fh_init) New function. Moved here from file-handle.q.
907 (fh_done) New function. Moved here from file-handle.q and
909 (get_handle_with_name) Renamed fh_from_name().
910 (get_handle_for_filename) Renamed fh_from_filename().
911 (create_file_handle) Renamed fh_create(). Changed to take a
912 `struct fh_properties' instead of discrete values. Updated all
914 (create_file_handle_with_defaults) Removed. Updated all
915 references to use fh_create() with fh_default_properties().
916 (fh_default_properties) New function.
917 (destroy_file_handle) Removed. The code is now in fh_done().
918 (handle_get_name) Renamed fh_get_name().
919 (handle_get_filename) Renamed fh_get_filename().
920 (handle_get_record_width) Renamed fh_get_record_width().
921 (handle_get_tab_width) Renamed fh_get_tab_width().
923 * file-handle-def.h: Formatting, comment fixes.
924 (enum file_handle_mode) Renamed struct fh_mode.
925 (struct fh_properties) New structure.
926 (fh_init) Move prototype here from file-handle.h.
930 * file-handle.q: (static var handle_list) Removed.
931 (fh_parse) Don't add handle to handle_list, because
932 file-handle-def.c has its own list.
933 (fh_init) Moved to file-handle-def.c.
936 Sun Jan 9 01:09 Jason Stover <jason@sakla.net>
938 * regression.q: (run_regression) Moved coefficient initialization
939 to the linreg library. Altered other functions accordingly.
941 Sat Jan 7 13:30:54 WST 2006 John Darrington <john@darrington.wattle.id.au>
943 * command.c data-in.c main.c: Fixed bug which crept in when
944 separating getl from readline.
946 * vars-atr.c value-labels.h: Fixed constness of val_labs_count.
948 Fri Dec 23 20:59:01 WST 2005 John Darrington <john@darrington.wattle.id.au>
950 * getl.c error.c: Separated file_loc functionality from error.c
952 Mon Dec 19 14:01:56 WST 2005 John Darrington <john@darrington.wattle.id.au>
954 * format.c: Additional error checking.
955 * getl.[ch]: Separated into getl.c and readln.c
956 * settings.[ch]: Made CC_CNT public
958 Fri Dec 16 09:11:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
960 * examine.q: Fixed buglet when cleaning up at end of procedure.
962 Tue Dec 13 22:34:42 2005 Ben Pfaff <blp@gnu.org>
964 Move global initialization and cleanup code into main.c.
965 Remove vestigial log infrastructure.
966 Minor related cleanups.
968 * command.c: (shell) When execl() fails, use _exit(), not
971 * error.c: (err_hcf) Move into main.c, rename terminate(). All
973 (err_done) New function with just the error.c-specific code for
974 err_hcf(). Called by terminate().
976 * glob.c: Removed all Borland C, DJGPP cruft.
977 (init_glob) Merged into main().
978 (done_glob) Merged into terminate().
980 (get_start_date) New function. All users of curdate updated to call
981 this function instead.
983 * lexer.c: (lex_init) Moved initialization of tokstr here, from
985 (lex_done) Moved destruction of tokstr here, from done_glob().
987 * main.c: (global var pgmname) Removed. Changed all references to
988 program_name, which is defined by gnulib.
989 (global var curdate) Removed.
990 (main) Moved init_glob() code here. Merged parse_script() in
992 (parse_script) Removed.
993 (terminate) Moved err_hcf() here from error.c and renamed
994 terminate(). Merged done_glob() code in here. Call err_done().
996 (i18n_init) New function.
997 (fpu_init) New function.
999 * output.c: (outp_init) Make void.
1000 (init_default_drivers) New function.
1001 (outp_read_devices) If no drivers are initialized successfully,
1002 call init_default_drivers() to initialize a default driver.
1003 (outp_done) Make void.
1004 (static var prog) Make const.
1005 (parse_options) Make parameter const.
1006 (colon_tokenize) Make return value const.
1007 (configure_driver) Change prototype to take a broken-down driver
1008 configuration instead of a line of text.
1009 (configure_driver_line) New function that does what
1010 configure_driver() did before.
1012 * q2c.c: (global var pgmname) Rename program_name.
1014 * settings.c: (settings_init) Renamed from init_settings().
1015 (settings_done) Renamed from done_settings().
1017 * vfm.c: (global var last_vfm_invocation) Make static.
1018 (vfm_last_invocation) New function. All references to
1019 last_vfm_invocation update to call this.
1020 (procedure) Call update_last_vfm_invocation().
1021 (internal_procedure) Ditto.
1022 (update_last_vfm_invocation) New function.
1024 Sat Dec 10 23:30:19 2005 Ben Pfaff <blp@gnu.org>
1026 Separate random numbers from other settings because of GSL
1029 * Makefile.am: Add random.c, random.h to sources.
1031 * glob.c: (init_glob) Call random_init().
1032 (done_glob) Call random_done().
1034 * settings.c: (static var rng) Move to random.c.
1035 (done_settings) Move freeing of RNG to random_done().
1036 (get_rng) Move to random.c
1039 * random.c: New file.
1041 * random.h: New file.
1043 Sat Dec 10 18:13:36 2005 Ben Pfaff <blp@gnu.org>
1045 Separate settings and the SET command, for modularity.
1047 * Makefile.am: Add settings.c to sources.
1049 * glob.c: (global variable test_mode) Removed.
1051 * set.q: Remove all the set_* variables. Remove a lot of obsolete
1052 SPSS/PC+ settings. Remove the aux_*() routines. Moved the
1053 get_*() functions into settings.c. Rewrite the settings code and
1054 functions to call the new set_*() functions. Rewrite custom
1055 currency parsing. Write new by-hand cmd_show().
1057 * esttings.c: New file. Moved the get_*() functions here from
1058 set.q. Created new set_*() functions to correspond with them.
1059 Regularized the names and types of some functions and updated
1060 their callers. Added static, file-scope variables to support the
1063 * q2c.c: Remove "aux" support, which was only needed by set.q.
1065 Sun Nov 27 06:43:46 WST 2005 John Darrington <john@darington.wattle.id.au>
1067 * data-out.c format.h: Added return value to data_out function.
1069 * value-labels.c: Fixed bug in val_labs_remove.
1071 Sat Nov 5 18:37:26 2005 Ben Pfaff <blp@gnu.org>
1073 * Makefile.am: Remove devind.c, devind.h from list of source
1076 * devind.c: Removed.
1078 * devind.h: Removed.
1080 * list.q: Removed "support" for devind.
1082 * output.c: Don't add devind class.
1084 Sat Nov 5 18:21:00 2005 Ben Pfaff <blp@gnu.org>
1086 * var.h: (struct variable) Make `init', `reinit' bool values.
1089 Fri Nov 4 19:43:01 2005 Ben Pfaff <blp@gnu.org>
1091 * recode.c: Rewrote whole file, as clean-up.
1093 Fri Nov 4 19:37:50 2005 Ben Pfaff <blp@gnu.org>
1095 * pool.c: Don't make alignment exception for x86.
1096 (pool_alloc) Return null for 0-size blocks.
1097 (pool_alloc_unaligned) New function.
1098 (pool_strndup) Removed. Changed callers to use pool_clone_unaligned().
1099 (pool_clone_unaligned) New function.
1100 (pool_strdup) Use pool_clone_unaligned().
1102 * var.h: (enum var_type) Give the NUMERIC, ALPHA enum this name.
1103 (struct variable) Use `enum var_type' for `type'.
1105 * vars-atr.c: (var_type_adj) New function.
1106 (var_type_noun) New function.
1108 * vars-prs: (parse_mixed_vars) Fix freeing code.
1109 (parse_mixed_vars_pool) New function.
1111 Wed Nov 2 21:24:48 2005 Ben Pfaff <blp@gnu.org>
1113 * file-handle-def.c: Needed another #include, to avoid missing
1116 * file-handle.q: (cmd_file_handle) Declarations must precede
1117 statements. Free parse data on success as well as on failure, to
1120 * get.c: (parse_write_command) Destroy dict on success, to avoid
1123 * data-list.c: (cmd_repeating_data) Fix usage of saw_occurs,
1124 saw_length, saw_continued, saw_id, which were boolean but
1125 incorrectly treated as bitmaps as result of a previous
1126 half-finished cleanup.
1128 * weight.c: (struct weight_trns) Unused, so removed.
1130 * Makefile.am: Add range-prs.h to sources.
1132 Wed Nov 2 21:24:15 2005 Ben Pfaff <blp@gnu.org>
1134 DO IF, LOOP cleanup.
1136 * Makefile.am: Add ctl-stack.c, ctl-stack.h to source files.
1137 Reformat source file list to list one file per file, so that
1138 patches for future changes will be easier to read.
1140 * ctl-stack.c, ctl-stack.h: New files.
1142 * do-if.c: Rewrote whole file.
1144 * do-ifP.h: Removed.
1146 * loop.c: Rewrote whole file.
1148 * glob.c: (global var ctl_stack) Move into ctl-stack.c.
1150 * temporary.c: (cmd_temporary) Use ctl_stack_is_empty().
1152 * vfm.c: (open_active_file) Use ctl_stack_clear().
1154 Wed Nov 2 21:18:13 2005 Ben Pfaff <blp@gnu.org>
1158 * pool.c: (pool_create_at_offset) New function.
1159 (pool_add_subpool) New function.
1161 * pool.h: (pool_create_container) New macro.
1163 * expressions/parse.c: (expr_parse_pool) New function.
1165 * autorecode.c: (recode) Use pool_create_container().
1167 * count.c: (cmd_count) Ditto.
1169 Wed Nov 2 19:59:32 2005 Ben Pfaff <blp@gnu.org>
1171 Clean up transformations, by getting rid of `struct trns_header',
1172 replacing it by `struct transformation' that has a void *
1173 `private' member. Updated all uses of transformations to match,
1174 which was a lot of code. Only major related changes listed below.
1176 * compute.c: (cmd_if) Use get_proc_func().
1177 (cmd_compute) Use get_proc_func().
1178 (get_proc_func) New function.
1180 * glob.c: (global var m_trns) Change type to size_t.
1181 (global var n_trns) Ditto.
1182 (global var f_trns) Ditto.
1183 (global var t_trns) Change type to struct transformation *.
1185 * var.h: (struct trns_header) Removed.
1186 (struct transformation) New.
1187 (typedef trns_proc_func) Takes a void * instead of a struct
1189 (typedef trns_free_func) Ditto.
1191 * vfm.c: (execute_transformations) Takes an array of
1192 transformations instead of trns_headers.
1193 (add_transformation) Change prototype from (trns_header *) to
1194 (trns_proc_func *, trns_free_func *, void *).
1195 (next_transformation) New function.
1197 Sat Oct 29 16:25:36 2005 Ben Pfaff <blp@gnu.org>
1199 * count.c: Major cleanups. Rename practically everything.
1200 Rewrite much of the code. Use pools for memory management. Use
1201 the new parse_num_range().
1203 * mis-val.c: (cmd_missing_values) Use the new parse_num_range().
1204 (parse_number) Removed.
1206 * missing-values.c: (mv_add_num_range) Don't add out-of-order
1207 ranges, e.g. where low > high.
1209 * pool.c: (pool_2nrealloc) New function.
1211 * range-prs.c: New file.
1212 (parse_num_range) New function.
1213 (parse_number) New function.
1215 Fri Oct 28 22:47:48 2005 Ben Pfaff <blp@gnu.org>
1217 Fix up potential overflows in size calculations by replacing
1218 instances of pool_alloc(p, x * sizeof *y) by pool_malloc(p, x,
1219 sizeof *y) everywhere I could find them. Similarly by
1220 pool_malloc(), pool_realloc().
1221 (Order is important: pool_alloc(p, sizeof *y, x) will divide by 0
1224 * pool.c: (pool_nalloc) New function.
1225 (pool_nmalloc) New function.
1226 (pool_nrealloc) New function.
1228 Thu Oct 27 11:16:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1230 Separated the definition of a file handle object from the stuff
1231 pertaining to the FILE HANDLE command.
1233 * file-handle-def.[ch]: New files.
1235 * dfm-read.c file-handle.h file-handle.q
1237 Tue Oct 25 21:56:23 2005 Ben Pfaff <blp@gnu.org>
1239 Fix up potential overflows in size calculations by replacing
1240 instances of xmalloc(x * sizeof *y) by xnmalloc(x, sizeof *y)
1241 everywhere I could find them. Similarly by xrealloc(), malloc().
1242 (Order is important: xnmalloc(sizeof *y, x) will divide by 0 if x
1245 * alloc.c: (nmalloc) New function.
1246 (out_of_memory) Removed. Replaced references by xalloc_die().
1248 * sort.c: (allocate_cases) Fix segfault if memory allocation
1251 * subclist.c: (subc_list_double_create) Use xnmalloc() instead of
1253 (subc_list_double_push) Use xnrealloc() instead of realloc().
1255 Wed Oct 26 08:43:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1257 Dictionary abstraction part #2
1259 * algorithm.c format.c str.c sysfile-info.c val.h var.h vars-atr.c:
1260 Removed unnecessary #include directives
1262 Mon Oct 24 21:35:08 2005 Ben Pfaff <blp@gnu.org>
1264 * groff-font.c (font_msg): Use err_vmsg() instead of incorrectly
1265 trying to pass a va_list to tmsg(). Thanks to Jason Stover for
1268 Mon Oct 24 21:24:15 2005 Ben Pfaff <blp@gnu.org>
1270 Work to get rid of GCC 4.0 warnings, part 2.
1272 In many files, change `unsigned char' to `char'. This often
1273 requires adding casts to <ctype.h> functions.
1275 * data-in.c: (parse_A) Use buf_copy_rpad().
1277 * str.c: (str_copy_buf_trunc) New function.
1279 * value-labels.c: (value_to_string) Fix mistaken use of strncpy(),
1282 Mon Oct 24 13:42:32 WST 2005 John Darrington <john@darrington.wattle.id.au>
1284 Moved some definitions to make it easier to abstract a dictionary
1285 from the rest of PSPP.
1287 * format-prs.c lex-def.[ch]: New files.
1289 * Makefile.am lexer.[ch] dictionary.c vars-atr.c vfm.c algorithm.c
1290 format.c: Moved some functions between modules.
1292 Sun Oct 23 19:28:08 2005 Ben Pfaff <blp@gnu.org>
1294 Work to get rid of GCC 4.0 warnings, part 1.
1296 In many files, change count parameters to parse_variables(),
1297 etc. from `int' to `size_t'. Also change related variables and
1298 struct members. Also change messages as needed (e.g. %d to %u
1299 with cast to unsigned). Also change arithmetic as necessary
1300 (e.g. n >= m - 1 to n + 1 >= m).
1302 * crosstabs.q: (crs_custom_tables) Check for size_t overflow in
1305 * q2c.c: (dump_declarations) Generate code for size_t instead of
1308 Thu Oct 20 18:18:40 2005 Ben Pfaff <blp@gnu.org>
1310 * output.c: (outp_read_devices) Fix message.
1312 Sat Sep 17 11:13:13 2005 Ben Pfaff <blp@gnu.org>
1314 * matrix-data.c: (cmd_matrix_data) Change type of variable whose
1315 address is passed to dict_get_vars() from size_t to int to match
1316 John's change below.
1318 * modify-vars.c: (validate_var_modification) Ditto.
1320 Mon Sep 12 19:26:06 WST 2005 John Darrington <john@darrington.wattle.id.au>
1322 * dictionary.[ch] Changed cnt from size_t* to int* since that's
1323 what it's called as, and on x86_64 machines they're different sizes.
1325 * str.c: (ds_vprintf) Copied va_list args so they can be re-used
1327 Sun Aug 21 00:12:24 2005 Ben Pfaff <blp@gnu.org>
1329 * lexer.c: (lex_sbc_only_once) New function.
1330 (lex_sbc_missing) New function.
1332 Sun Aug 21 00:00:47 2005 Ben Pfaff <blp@gnu.org>
1334 * case.h: (case_str) Make it return `unsigned char'.
1336 Sat Aug 20 23:56:14 2005 Ben Pfaff <blp@gnu.org>
1338 Revamp SAVE, XSAVE, EXPORT. Add (or at least parse) all the
1339 subcommands that we didn't support. Fix bug 13911. Fix bug
1340 reported by Adam Pierson (COMPRESSED and other subcommands didn't
1341 work on SAVE). Refactor all related code.
1343 * command.def: Add XEXPORT command.
1345 * dictionary.c: (dict_delete_scratch_vars) New function.
1347 * get.c: (cmd_get) Fix parsing.
1348 (struct save_trns) Removed.
1349 (cmd_save_internal) Removed.
1351 (do_write_case) Removed.
1352 (save_write_case_func) Removed.
1353 (save_trns_proc) Removed.
1354 (save_trns_free) Removed.
1355 (trim_dictionary) Removed.
1356 (struct export_proc) Removed.
1357 (cmd_export) Rewrote.
1358 (export_write_case_func) Removed.
1359 (export_proc_free) Removed.
1360 (enum writer_type) New enum.
1361 (enum command_type) New enum.
1362 (struct any_writer) New struct.
1363 (any_writer_destroy) New function.
1364 (parse_write_command) New function.
1365 (any_writer_write_case) New function.
1366 (parse_output_proc) New function.
1367 (output_proc) New function.
1369 (cmd_xsave) Rewrote.
1370 (struct output_trns) New struct.
1371 (parse_output_trns) New function.
1372 (output_trns_proc) New function.
1373 (output_trns_free) New function.
1374 (cmd_xsave) Rewrote.
1375 (cmd_xexport) New function.
1376 (parse_dict_trim) New function.
1377 (struct mtf_proc) Change `by_cnt' member type to `int'.
1378 (cmd_import) Rewrote.
1380 * pfm-write.c: (struct pfm_writer) Add `digits' member.
1381 (pfm_writer_default_options) New function.
1382 (pfm_open_writer) Add `opts' argument and handle options.
1383 (write_float) Write only as many digits as `digits' member says.
1384 (format_trig_double) Limit base-10 precision to LDBL_DIG.
1386 * pfm-write.h: (enum pfm_type) Moved here from pfm-read.h.
1387 (struct pfm_write_options) New struct.
1389 * sfm-write.c: (sfm_writer_default_options) New function.
1390 (sfm_open_writer) Remove `compress', `omit_long_names' args. Add
1391 `opts' argument. Implement options.
1393 * sfm-write.h: (struct sfm_write_options) New struct.
1395 * expressions/helpers.c: (copy_string) Make `old' arg `unsigned
1396 char *' instead of `char *'.
1398 Sat Aug 6 21:29:15 2005 Ben Pfaff <blp@gnu.org>
1400 * factor_stats.c: Needed <config.h> included earlier.
1402 * percentiles.c: Needed to include <config.h>.
1404 * val.h: Don't include "config.h".
1406 Sat Aug 6 21:26:27 2005 Ben Pfaff <blp@gnu.org>
1408 Clean up treatment of missing values by moving all the code into
1409 one place. All references to the missing value function were
1410 updated, but only major changes are detailed below.
1412 * Makefile.am: Add missing-values.c, missing-values.h to sources.
1414 * apply-dict.c: (cmd_apply_dictionary) Use mv_resize().
1416 * dictionary.c: (dict_create_var) Initialize `miss' member with
1418 (dict_clone_var) Copy `miss' member with mv_copy().
1420 * get.c: (mtf_merge_dictionary) Use mv_copy().
1422 * missing-values.c: New file.
1424 * missing-values.h: New file.
1426 * mis-val.c: Rewrite. New version implements updated semantics.
1428 * pfm-read.c: (read_variables) Rewrite missing value handling.
1430 * pfm-write.c: (write_variables) Rewrite missing value handling.
1432 * sfm-read.c: (read_variables) Rewrite missing value handling.
1434 * sfm-write.c: (write_variable) Rewrite missing value handling.
1436 * sfmP.h: Include "magic.h" to get definition of
1437 second_lowest_value.
1439 * sysfile-info.c: (describe_variable) Rewrite missing value
1442 * val.h: Include "magic.h" to get definition of
1443 second_lowest_value.
1445 * var.h: Include "missing-values.h". Drop MISSING_* enums.
1446 (struct variable) Remove `miss_type', `missing'. Add `miss'.
1448 * vars-atr.c: (is_num_user_missing) Removed--use
1449 mv_is_num_user_missing().
1450 (is_str_user_missing) Removed--use mv_is_str_user_missing().
1451 (is_system_missing) Removed--use mv_is_value_system_missing().
1452 (is_missing) Removed--use mv_is_value_missing().
1453 (is_user_missing) Removed--use mv_is_value_user_missing().
1455 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
1457 Adopt use of gnulib for portability.
1459 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
1462 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
1463 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
1466 * In many source files, added an explicit inclusion of gettext.h
1467 and definition of _ macro. These are no longer in pref.h because
1468 it interfered with definitions in a few gnulib source files.
1470 * In many source files, changed #include "bool.h" to #include
1471 <stdbool.h>, which is provided by gnulib.
1473 * alloc.c: Removed functions defined in gnulib:
1478 (out_of_memory) Redefined as wrapper for xalloc_die().
1480 * alloc.h: Replace prototypes by #include "xalloc.h".
1482 * casefile.c: Use full_read() and full_write() from gnulib instead
1483 of our home-grown versions.
1484 (full_read) Removed.
1485 (full_write) Removed.
1487 * getline.c: Renamed getl.c.
1489 * getline.h: Renamed getl.h, updated all references.
1491 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
1494 * glob.c: Just #include <time.h> instead of the crazy rigmarole
1496 (init_glob) Call set_program_name() to initial gnulib progname
1499 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
1501 * permissions.c: Use "stat-macros.h" from gnulib.
1503 * postscript.c: Just #include <time.h> instead of the crazy
1504 rigmarole here before.
1506 * q2c.c: (main) Make generated code #include "gettext.h".
1508 * str.h: Get rid of most explicit declarations of standard
1509 functions, in favor of including gnulib header files.
1511 * expressions/evaluate.c: Ditto.
1513 * expressions/operations.h.pl: Make generated code #include
1514 <stdbool.h>, not "bool.h".
1516 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
1518 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
1521 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
1523 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
1524 null pointer to printf for %.*s.
1526 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
1528 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
1531 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
1533 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
1535 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
1537 * postscript.c: (postopen) Cast `char' to `unsigned char' before
1538 passing to isspace().
1540 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
1542 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
1544 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
1546 * histogram.c: Include <config.h>.
1548 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
1550 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
1552 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
1554 * format.c: (check_common_specifier) Fix msg() bug found by
1556 (check_output_specifier) Ditto.
1558 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
1560 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
1563 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
1565 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
1566 avoid "unused variable" warning.
1568 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
1570 * command.c: (find_word) Cast `char' to `unsigned char' before
1571 passing to isspace().
1573 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
1575 * case.c: (case_compare) Implement as delegating to
1576 case_compare_2dict().
1578 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
1580 * algorithm.c: Inclusion of <alloca.h> is unneeded.
1582 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
1584 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
1585 -ansi changes the behavior of header files significantly. It
1586 causes __STRICT_ANSI__ to be defined, and some headers interpret
1587 that as cause to e.g. not use `long long' or __attribute__. The
1588 former example is bad when off_t is supposed to be `long long',
1589 and the latter prevents -Wformat from working.
1591 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
1593 Get rid of dependency on libgmp by writing our own routine for
1594 floating-point base conversion.
1596 * pfm-write.c: (write_float) Rewrote.
1597 (write_int) Rewrote.
1598 (pow30_nonnegative) New function.
1599 (pow30) New function.
1600 (trig_to_char) New function.
1601 (format_trig_digits) New function.
1602 (recurse_format_trig_int) New function.
1603 (format_trig_int) New function.
1604 (should_round_up) New function.
1605 (try_round_up) New function.
1606 (format_trig_double) New function.
1608 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
1610 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
1613 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
1615 * pfm-read.c: (read_version_data) Read and ignore author field.
1617 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
1619 * get.c: (mtf_processing) Don't assume that
1620 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
1621 returns a negative, zero, or positive result. Fixes MATCH FILES
1622 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
1624 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
1626 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
1627 preprocessor test for sys/types.h was accidentally inverted. This
1630 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
1632 * get.c: (cmd_match_files) Fix memory leak on `by' and on
1635 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
1638 * vfm.c: (close_active_file) Remove unnecessary test.
1640 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
1642 Fix NDEBUG compile errors.
1644 * hash.h: Needed explicit #include <assert.h>.
1646 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
1649 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
1651 Implement embedding for PostScript driver. Fixes bug 12970.
1653 * ascii.c: Fix compiler warnings.
1657 * chart.h: Add `file' member.
1659 * output.h: (struct outp_class) initialise_chart, finalise_chart
1660 should take outp_driver *, not outp_class *. Update all
1663 * plot-chart.c: (chart_create) Fix segfault when there are no
1664 output drivers at all.
1665 (chart_submit) Call d->class->finalise_chart.
1667 * postscript.c: (ps_open_page) Set cp_y to 0.
1668 (ps_submit) New function.
1669 (ps_chart_initialise) Implement.
1670 (ps_chart_finalise) Implement.
1671 (static var postscript_class) Add ps_submit.
1672 (static var epsf_class) Add ps_submit.
1675 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
1677 Did some more work on bug 12859 and then realized that a *good*
1678 solution would require some fundamental restructuring. For now,
1679 I'm marking REPEATING DATA unimplemented, and then we can revisit
1682 * command.def: Make REPEATING DATA unimplemented.
1684 * data-list.c: (cmd_repeating_data) Assume inline file is 80
1686 (realize_value) Revert previous changes; no longer needed.
1687 Updated all callers.
1689 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
1690 file_loc, to avoid bad references later.
1694 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
1696 Make some code tolerant of reentry. Should not be needed if other
1697 code is correct but it is good to be generally tolerant.
1699 * error.c: (err_hcf) Set file_loc to null after free().
1701 * output.c: (outp_done) Similar changes.
1703 * str.c: (ds_destroy) Ditto.
1705 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
1707 Continue work on bug 12859, plus some code cleanup.
1709 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
1710 boolean variables. Don't try to compute starts_end, cont_end for
1711 inline file. Calculate length only after parsing variable
1712 specifications. Add proper transformation to list.
1713 (realize_value) If the rpd_num_or_var has no value, return new
1714 DEFAULT_MEMBER argument (for use with inline file).
1715 (repeating_data_trns_proc) Pass default values.
1717 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
1718 open, and only if we actually started reading data.
1720 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
1724 * output.c: (outp_read_devices) Fix message.
1726 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1728 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
1729 of the sort algorithm from the parser for the SORT command.
1731 * rank.q: Added the parser for the RANK command.
1733 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
1737 * sort.c: (sort_parse_criteria) Only set *saw_direction if
1738 saw_direction is non-null. Thanks to John Darrington for
1741 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
1743 * get.c: (mtf_processing) Handle case of a lookup table as the
1744 active file. Thanks to John Darrington for reporting this bug.
1746 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1748 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
1749 POSIX calloc function.
1751 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
1752 reflect new signature.
1754 * sfm-read.c: Now much more robust in the face of badly formed
1757 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
1759 *sfm-read.c: Fixed some bugs regarding long string continuation
1760 records, which the previous fix uncovered.
1762 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
1764 * sfm-read.c, sfmP.h: Allow reading of system files when the
1765 case_size value in the header is -1. Also changed some Errors to
1766 Warnings when reading system files.
1768 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
1770 * data-list.c: (data_list_trns_free) Don't free the argument
1771 because cancel_transformations() will do that itself.
1772 (data_list_source_destroy) Destroy the argument to
1773 data_list_trns_free(), because it no longer does so itself.
1775 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
1777 * data-out.c: (format_and_round) Don't output leading `-' if value
1780 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
1784 * som.c: (output_encodings) If some cell in the table won't fit
1785 with the horizontal or vertical headers, cancel those headers.
1787 * som.h: (struct som_table_class) Add fits_width, fits_length,
1788 set_headers members.
1790 * tab.c: (tabi_fits_width) New function.
1791 (tabi_fits_length) New function.
1792 (tabi_set_headers) New function.
1793 (global var tab_table_class) Add the new functions as appropriate
1796 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
1798 Fix rest of bug 13054.
1800 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
1801 DATETIME, TIME system/portable file values.
1803 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
1805 * data-list.c: (parse_free) Use make_input_format().
1807 * data-out.c: (num_to_string) Use make_output_format().
1809 * dictionary.c: (dict_create_var) Ditto.
1811 * format.c: (global var f8_2) New var.
1812 (make_input_format) New function.
1813 (make_output_format) New function.
1815 * get.c: (cmd_match_files) Use make_output_format().
1817 * list.q: (cmd_list) Ditto.
1819 * matrix-data.c: Ditto.
1821 * sfm-read.c: (parse_format_spec) Check output specifier
1824 * tab.c: (tab_float) Use make_output_format().
1826 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
1828 Fix more of bug 13054.
1830 * format.def: FMT_A should allow 255-character output. FMT_AHEX
1831 should allow 510-character input and output.
1833 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
1834 (convert_E) Handle non-finite values.
1836 (format_and_round) New function.
1837 (convert_infinite) New function used by try_F() and convert_E().
1839 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
1841 Regularize string and buffer function names so that they make some
1844 * str.c: (mm_reverse) Rename buf_reverse(). Update all
1846 (mm_find_reverse) Rename buf_find_reverse(). Update all
1848 (mm_case_compare) Rename buf_compare_case(). Update all
1850 (st_compare_pad) Rename buf_compare_rpad(). Update all
1852 (str_compare_rpad) New function.
1853 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
1855 (buf_copy_str_lpad) New function.
1856 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
1858 (st_pad_copy) Rename str_copy_rpad(). Update all references.
1859 (st_trim_copy) Rename str_copy_trunc(). Update all references.
1860 (st_uppercase) Renamed str_uppercase(). Update all references.
1862 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1864 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
1867 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
1869 * data-in.c: (data_in) Add assertion to check input specifier.
1871 * data-out.c: (data_out) Add assertion to check output specifier.
1873 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
1875 Start to fix bug 13054.
1877 * format.c: (check_input_specifier) Improve error message.
1878 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
1879 valid decimal places.
1880 (check_output_specifier) Ditto (but different criteria).
1881 (convert_fmt_ItoO) Assert valid input and output specifiers.
1882 Also, if input specifier has *any* decimal places, make the output
1883 specifier 1 place wider.
1885 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
1887 * sysfile-info.c: Fixed bug [# 13024 ]
1889 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
1891 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
1892 actually implement it.
1894 * command.c: (FILE_TYPE_okay) Always return 1.
1896 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
1898 * file-type.c: Add prototypes to get rid of warnings.
1900 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
1902 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
1903 more ISO/IEC 9899:1990 conformance issues.
1905 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
1907 Fix bug 12948. See also new test in
1908 tests/bugs/match-file-scratch.sh.
1910 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
1911 that deletes scratch variables that someone else might be using,
1912 and because we can't reassign our sources' value indexes.
1913 Instead, simply don't copy scratch variables into the master
1916 * dictionary.c: (dict_compact_values) Delete variables from the
1917 dictionary passed in, not from default_dict (!).
1919 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
1921 Improve hash.c comments, error-checking.
1923 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
1924 (hsh_create) size == 0 should *not* return NULL! Set
1926 (hsh_clear) Set hash_ordered.
1927 (locate_matching_entry) Check hash_ordered.
1928 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
1929 (hsh_data) Set hash_ordered. Add const-ness to return value and
1933 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1935 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
1937 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1939 * copyleft.c: Updated copyright date.
1941 * Makefile.am: Removed erroneous explicit "-lplot"
1943 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
1945 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
1947 * command.c command.def: Added description string for unimplemented commands.
1949 * oneway.q: Sorted the hash tables before shipping out the results. Closes
1952 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
1956 * data-list.c: (parse_fixed) Use lex_end_of_command().
1958 (cmd_repeating_data) Set cont_end.num in right situations.
1959 (parse_repeating_data) Remove redundant test.
1961 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
1963 Partial fix for bug 12859.
1965 * data-list.c: (cmd_data_list) Add transformation properly in
1966 vfm_source == NULL case.
1968 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
1970 * lexer.c: (lex_error) Improve error messages.
1972 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
1974 * get.c: (cmd_match_files) Check token type before trying to match
1975 tokid. Fixes bug 12923.
1977 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
1979 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
1982 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
1984 * expressions/generate.pl: (get_token) Make use of /g
1985 backward-compatible with Perl 5.6.1.
1987 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
1989 * var-display.c: (cmd_variable_alignment) Fix memory leak.
1990 (cmd_variable_level) Ditto.
1992 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
1994 Hash table had buggy deletion function. The fix required changing
1995 other functions to do probing in the required order.
1997 * hash.c: (locate_matching_entry) Rewrite and change interface.
1998 (hsh_rehash) Rewrite to use locate_matching_entry().
2001 (hsh_delete) Ditto. Also, fix stupid bugs.
2003 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
2005 * dictionary.c: (dict_clone) Properly copy vectors.
2007 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
2009 New implementation of long variable names. Each variable has a
2010 "normal" name, which may be up to 64 bytes long and which is used
2011 for all normal operations. Variables may have a "short" name,
2012 which is limited to 8 bytes and used only for system and portable
2013 file input and output.
2015 Make tokid case-preserving. Update most uses of tokid to treat it
2018 Update many commands to deal with long variable names.
2020 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
2022 * command.c: (cmd_parse) Ditto.
2023 (match_strings) Use toupper() before comparing characters.
2024 (conflicting_3char_prefixes) Use mm_case_compare() instead of
2026 (cmd_match_words) Ditto.
2028 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
2031 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
2032 Use st_trim_copy() instead of strcpy().
2034 * data-in.c: (parse_enum) Use mm_case_compare() instead of
2037 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
2039 (parse_free) Use st_trim_copy() instead of strcpy().
2041 * descript.c: (struct dsc_var) Change z_name[] to fit long var
2043 (try_name) Use strcasecmp() instead of strcmp().
2044 (generate_z_varname) Use st_trim_copy() instead of strcpy().
2045 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
2048 * dictionary.c: (struct dictionary) Removed `long_name_tab'
2050 (compare_long_names) Removed.
2051 (hash_long_name) Removed.
2052 (dict_create) Don't initialize `long_name_tab' member.
2053 (dict_clone) Copy short names into new dictionary.
2054 (dict_clear) Don't clear `long_name_tab' member.
2055 (dict_get_varname_block) Removed.
2056 (dict_add_longvar_entry) Removed.
2058 (dict_destroy) Don't destroy `long_name_tab' member.
2059 (dict_create_var_from_short) Removed.
2060 (dict_create_var_x) Removed.
2061 (dict_create_var) Get rid of longname handling.
2063 (dict_clone_var) Get rid of longname parameter and longname
2065 (dict_lookup_var) Get rid of longname handling.
2066 (dict_reorder_var) New function.
2067 (dict_rename_var) Clear short name.
2068 (dict_rename_vars) Get rid of longname handling. Clear short
2070 (dict_create_vector) Support long vector names.
2071 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
2072 (quasi_base27) Removed.
2073 (make_short_name) Removed.
2074 (compare_strings) New function.
2075 (hash_string) New function.
2076 (dict_assign_short_names) New function.
2078 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
2080 (get_handle_for_filename) Support long handle names.
2082 * file-type.c: (struct col_spec) Make `name' fit long var names.
2083 (cmd_file_type) Use strcasecmp() instead of strcmp().
2085 * flip.c: (make_new_var) Rewrite.
2086 (flip_sink_write) Use st_trim_copy() instead of strncpy().
2088 * format.c: (parse_format_specifier_name) Use mm_case_compare()
2089 instead of memcmp().
2091 * get.c: (cmd_save_internal) Rephrase.
2092 (rename_variables) Drop test for identical variable name.
2093 (struct mtf_proc) Change `first', `last' to fit long var name.
2095 * hash.c: (hsh_hash_case_string) New function for case-insensitive
2098 * lexer.c: (restore_token) Use st_trim_copy() instead of
2100 (lex_get) Don't uppercase string when copying into tokid.
2101 (lex_put_back_id) Use st_trim_copy() instead of
2104 * list.q: (determine_layout) Consider length of variable names in
2105 choosing vertical layout.
2107 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
2109 (string_to_content_type) Ditto.
2111 * modify-vars.c: (compare_variables_given_ordering) Ditto.
2112 (struct var_renaming) Change `new_name' to fit long var name.
2113 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
2116 * pfm-read.c: (read_variables) Disallow system variables in system
2118 (write_variables) Call dict_assign_short_names() and use
2119 short_name[] members.
2121 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
2124 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
2125 map. Reorder variables into same order as long variable map.
2126 (read_variables) Set short name.
2128 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
2129 (write_variable) Use st_bare_pad_copy().
2130 (write_longvar_table) Rewrite.
2132 * str.c: (mm_case_compare) New function.
2134 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
2135 instead of strcmp().
2137 * t-test.q: (tts_custom_groups) Remove redundant test.
2138 (tts_custom_pairs) Ditto.
2140 * var.h: (struct variable) Change `name' to fit long var names.
2141 Remove `longname'. Add `short_name' member. Reorder some
2143 (struct name_table_entry) Removed.
2144 (struct vector) Change `name' to fit long vector names.
2146 * vars-atr.c: (var_is_valid_name) Allow long var names.
2147 (compare_var_names) Use strcasecmp() instead of strcmp().
2148 (compare_var_ptr_names) Ditto.
2149 (hash_var_name) Use hsh_hash_case_string().
2150 (hash_var_ptr_name) Ditto.
2151 (var_set_short_name) New function.
2152 (var_clear_short_name) New function.
2153 (var_set_short_name_suffix) New function.
2155 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
2156 Use strcasecmp() instead of strcmp().
2157 (struct array_var_set) Removed `longname_tab'.
2158 (array_var_set_lookup_var_idx) Drop longname_tab support.
2159 (array_var_set_destroy) Don't destroy `longname_tab'.
2160 (var_set_create_from_array) Don't create `longname_tab'.
2162 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
2165 * expressions/parse.c: (word_matches) Use mm_case_compare()
2166 instead of memcmp().
2167 (compare_strings) New function.
2168 (lookup_function) Use compare_strings() instead of strcmp().
2170 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
2172 * algorithm.c: (move_element) New function.
2174 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
2176 * aggregate.c: (parse_aggregate_functions) Always initialize
2179 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
2181 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
2183 * dictionary.c: (dict_clone) Ditto.
2184 (dict_clone_var_assert) New function.
2186 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
2188 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
2190 * error.c: Added a string for the compiler version to the
2191 request_bug_report_and_abort function.
2193 * groff_font.c, font.c: Removed manpage(1) style references from
2194 comments, because RMS frowns upon them.
2196 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
2198 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
2200 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
2202 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
2203 Fixed bug [#12858] .
2205 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
2207 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
2208 which should be LONG_NAME_LEN
2210 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
2212 * command.def echo.c: Added the ECHO command.
2214 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
2216 Finish fixing MATCH FILES (bug 11677).
2218 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
2219 keep_variables(), rename_variables().
2220 (drop_variables) New function.
2221 (keep_variables) New function.
2222 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
2223 (cmd_match_files) Deal with in_var. Use drop_variables(),
2224 keep_variables(). When IN is specified, require BY. Set master
2225 variables after master dictionary is complete. Add IN variables
2226 after master dictionary is complete.
2227 (mtf_free_file) Free `in_name'.
2228 (mtf_delete_file_in_place) Set in_var value to 0.
2229 (mtf_read_nonactive_records) Rephrase.
2230 (mtf_processing) Support IN. Rephrase. Fix bugs.
2231 (mtf_merge_dictionary) Don't set master variables; we do that
2233 (get_master) Don't insist that there's a master variable.
2235 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
2237 Kluge to make some variable renaming sort of work.
2240 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
2242 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
2244 Add functions for comparing sets of variables between cases.
2247 * case.c: (case_compare) New function.
2248 (case_compare_2dict) New function.
2250 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
2252 (cmd_aggregate) Nullify break_case. Don't call
2253 initialize_aggregate_info().
2254 (agr_destroy) Destroy break_case.
2255 (aggregate_single_case) Rewrite. Use case_compare().
2256 (dump_aggregate_info) Copy from break_case into output.
2257 (initialize_aggregate_info) Copy break_case from input.
2259 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
2261 * vfm.c: (equal_splits) Use case_compare().
2263 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
2265 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
2267 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
2269 Start work on fixing MATCH FILES.
2271 * get.c: (enum operation) Remove OP_MATCH.
2272 (trim_dictionary) Change return value to bool. Don't support
2274 (struct mtf_file) Remove `first', `last' members.
2275 (struct mtf_proc) Add `first', `last' members. Change mtf_case
2276 from `struct ccase *' to `struct ccase'. Remove `by' member.
2277 (cmd_match_files) Essentially rewrite.
2278 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
2279 (mtf_read_nonactive_records) mtf_ parameter is not unused.
2280 (mtf_processing) Ditto. Also rephrase some code.
2281 (mtf_merge_dictionary) Rewrite for easy comprehension.
2283 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
2285 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
2288 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
2290 Thu Apr 14 2005 John Darrington
2292 * var-display.c: New file.
2294 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
2295 display_width, measure and alignment parameters to variables.
2297 * aggregate.c command.def compute.c count.c data-list.c descript.c
2298 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
2299 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
2300 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
2301 vars-prs.c vector.c :
2302 - Replaced literal constants representing maximum variable name
2303 length with macro definitions.
2304 - Added support for long variable names.
2305 - Changed lexer such that it no longer makes tokens upper
2306 case, but relies upon case insensitive behaviour of commands.
2308 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
2310 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
2311 fails, don't dereference the resulting null pointer (bug 12427).
2312 Also, fix double free error.
2314 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
2316 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
2317 (accumulate_aggregate_info) Set int1 to 1 for SUM.
2318 (dump_aggregate_info) Only make SUM non-missing if there was at
2321 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
2323 * aggregate.c: (dump_aggregate_info) Properly test whether the
2324 destination variable is numeric, when making the result
2325 system-missing for columnwise missing values.
2327 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
2329 * misc.h: Remove GCC specializations.
2331 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
2333 Make sort stable (bug 12313).
2335 * sort.c: Don't need to include some headers anymore.
2336 (static var min_buffers) New variable.
2337 (static var max_buffers) New variable.
2338 (static var allow_internal_sort) New variable.
2339 (cmd_sort_cases) Add test mode.
2340 (sort_execute) Rephrase.
2341 (do_internal_sort) Don't try internal sorting if
2342 allow_internal_sort is set.
2343 (struct external_sort) Renamed `initial_runs' to `runs' and
2344 updated all references.
2345 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
2346 (macro MIN_BUFFER_SIZE_BYTES) Removed.
2347 (macro MIN_BUFFER_SIZE_RECS) Removed.
2348 (compare_initial_runs) Removed.
2349 (struct record_run) Add member `idx'.
2350 (write_initial_runs) Pass increasing values to process_case() as
2352 (process_case) Add `idx' parameter and use it to initialize new
2354 (allocate_cases) Limit allocated buffers to max_buffers.
2355 (compare_record_run) Use new `idx' member for last resort
2356 comparison, for stability.
2357 (end_run) Call casefile_sleep() on irs->casefile, to prevent
2358 running out of file descriptors.
2359 (struct merge_state) Removed.
2360 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
2361 unless we have fewer runs left. Always merge consecutive runs,
2362 for stability. Return the final run.
2364 (choose_merge) New function.
2365 (merge_once) Rewritten.
2367 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
2369 * cmdline.c: (static var testing_mode) Move into
2370 parse_command_line().
2372 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
2374 * algorithm.c: (remove_range) New function.
2375 (remove_element) New function.
2377 * dictionary.c: (dict_delete_var) Use remove_element().
2379 * flip.c: (cmd_flip) Ditto.
2381 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
2383 * file-handle.q: (struct file_handle) `open_mode' should not be
2386 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
2388 First phase of making SORT CASES stable (bug 12313).
2390 * sort.c: (struct indexed_case) New structure.
2391 (do_internal_sort) Rewrite to make internal sorting stable.
2392 (compare_case_dblptrs) Removed.
2393 (compare_indexed_cases) New function.
2395 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
2399 * casefile.c: (casereader_read_xfer_assert) New function.
2401 * dictionary.c: (dict_compact_case) New function.
2403 * flip.c: (struct flip_pgm) New member idx_to_fv.
2404 (cmd_flip) Initialize idx_to_fv member.
2405 (destroy_flip_pgm) Free idx_to_fv member.
2406 (flip_sink_write) Use struct flip_pgm member instead of case_sink
2408 (flip_sink_write) Ditto.
2410 * vfm.c: (write_case) Use dict_compact_case() instead of
2412 (compact_case) Removed.
2413 (storage_source_create) Removed `dict' parameter. All references
2416 * vfm.h: (struct case_source) Removed `value_cnt' member. All
2418 (struct case_sink) Removed `dict', `idx_to_fv' members. All
2421 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
2423 More AGGREGATE fixes.
2425 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
2426 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
2428 (initialize_aggregate_info) Fix initialization for MIN, MAX for
2431 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
2433 Start work on testing and debugging AGGREGATE.
2435 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
2436 of a bit-map. Require proper subcommand ordering. Make OUTFILE
2437 subcommand mandatory.
2438 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
2439 functions' arguments are in the correct order and swap them if
2441 (accumulate_aggregate_info) Make SUM include weights. Add various
2443 (dump_aggregate_info) Add various string functions.
2444 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
2446 * sort.c: (sort_parse_criteria) Add parameter for returning
2447 whether any directions were specified. All callers updated.
2449 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
2451 * t-test.q: Fixed erroneous logic in compare_group_binary.
2453 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
2455 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
2456 keywords (bug 11628).
2458 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
2460 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
2461 called *before* close_active_file().
2463 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
2465 * file-handle.q: (struct file_handle) Change open_mode from
2466 character pointer to 3-char array, for safety. Updated all
2469 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
2471 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
2474 * pfm-read.c: (read_header) Improve error message for many cases
2475 in which the input is not actually a portable file.
2477 * file-handle.q: (fh_open) When we give an error message, actually
2480 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
2482 * format.c: (check_common_specifier) New function for checks
2483 common to check_input_specifier() and check_output_specifier().
2484 (check_input_specifier) Use check_common_specifier().
2485 (check_output_specifier) Use check_common_specifier().
2486 (check_string_specifier) Removed.
2487 (check_specifier_type) New function.
2488 (check_specifier_width) New function.
2489 (get_format_var_width) Fix bug.
2491 * formats.c: (internal_cmd_formats) Only accept numeric variables.
2493 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
2494 update all references. Make case-insensitive.
2496 * pfm-read.c: Essentially rewrite the whole file. Now much
2499 * print.c: (check_string_width) New function.
2500 (fixed_parse_compatible) Use check_string_width(),
2501 check_specifier_type().
2502 (dump_fmt_list) Ditto.
2504 * str.c: (st_trim_copy) New function.
2505 (st_uppercase) New function.
2507 * vars-atr.c: (var_is_valid_name) New function.
2509 * expressions/parse.c: (type_coercion_core) Use
2510 check_specifier_type().
2512 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
2514 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
2516 * expressions/parse.c: (no_match) Ditto.
2518 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
2520 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
2522 * expressions/helpers.c: (struct func_params) Removed.
2523 (generalized_idf) Removed.
2526 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
2528 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
2529 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
2530 Implement SIG.F, which I had overlooked previously.
2532 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
2534 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
2535 available only in testing mode.
2537 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
2539 * data-in.c: Use `bool' throughout, where relevant.
2541 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
2543 DATA LIST with free-field formats should not have implied decimal
2544 places (bug 12035). Also clean up data-in.c a bit.
2546 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
2548 * data-in.c: (apply_implied_decimals) New function.
2549 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
2550 set. Also, get rid of gotos.
2551 (parse_Z) Use apply_implied_decimals() if the field doesn't
2552 contain a decimal point.
2553 (parse_N) Use apply_implied_decimals().
2559 (parse_enum) New function.
2560 (macro CHAR_IS_ROMAN) Removed.
2561 (macro ROMAN_VALUE) Removed.
2562 (parse_month) Use parse_enum().
2563 (parse_weekday) Use parse_enum().
2564 (parse_DATETIME) Use long for weekday.
2566 * data-list.c: (read_from_data_list_fixed) Use
2567 DI_IMPLIED_DECIMALS.
2569 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
2571 When the lexer sees something like `-5' in the input, it has to
2572 decide whether it's a negative numeric constant token or a '-'
2573 token followed by a positive numeric constant token. It always
2574 decides on the former, and then the parser can call
2575 lex_negative_to_dash() if it wants the latter. However, this
2576 doesn't work for the case of `-0', because negative zero is
2577 (portably) indistinguishable from positive zero. So now we divide
2578 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
2579 distinction clear. This requires a little bit of extra effort,
2580 because there were several references to T_NUM in the code base.
2582 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
2583 positive and negative numeric constants.
2584 (lex_double_p) Renamed lex_is_number(). Changed return type to
2585 bool. Updated all relevant references to T_NUM to instead use
2587 (lex_double) Renamed lex_number(). All references updated.
2588 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
2589 bool. All references updated.
2590 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
2591 (lex_negative_to_dash) Ditto.
2594 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
2596 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
2598 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
2600 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
2602 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
2603 values as system-missing.
2605 * expressions/parse.c: (parse_vector_element) Fix order of
2606 arguments in call to expr_allocate_binary().
2608 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
2610 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
2613 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
2614 failure, as indicated by function comment.
2615 (parse_binary_operators) Always return NULL on type_coercion()
2616 failure. Should have been doing this anyway, but bug in
2617 type_coercion_core() filtered through.
2618 (parse_add) Fix typo in user message.
2619 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
2621 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
2623 * expressions/operations.def: Add VALUE function.
2625 * expressions/parse.c: (parse_function) Need an unary composite
2626 node for variables in A TO B, not a variable node. Use
2627 allocate_unary_variable().
2628 (parse_primary) Use allocate_unary_variable().
2629 (allocate_unary_variable) New function.
2631 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
2633 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
2634 but fixed the real problem that was preventing the build from a
2635 separate directory. I liked it my way better ;-)
2637 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
2639 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
2640 John Darrington <john@darrington.wattle.id.au> for reporting this
2643 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
2645 * expressions/Makefile.am expressions/evaluate.h.pl
2646 expressions/evaluate.inc.pl expressions/operations.h.pl
2647 expressions/optimize.inc.pl expressions/parse.inc.p:
2649 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
2652 Fixed everything so that it can be built from an arbitrary
2655 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
2657 * Makefile.am : Fixed up CLEANFILES target.
2659 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
2661 * str.h: Changed `struct len_string' to `struct fixed_string', a
2662 more accurate name. Updated all references.
2664 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
2666 Redo calendar support. Should now be bug-for-bug compatible.
2668 * calendar.c: New file.
2670 * calendar.h: New file.
2672 * data-in.c: Use new calendar functions.
2673 (parse_sign) Change sense of return value.
2674 (calendar_error) New function.
2675 (ymd_to_ofs) New function.
2676 (ymd_to_date) New function.
2677 (parse_DATE) Use new function.
2678 (parse_ADATE) Ditto.
2679 (parse_EDATE) Ditto.
2680 (parse_SDATE) Ditto.
2681 (parse_JDATE) Ditto.
2686 (parse_DTIME) Ditto.
2687 (parse_DATETIME) Ditto.
2689 * data-out.c: (convert_date) Use new calendar functions.
2691 * error.c: (err_vmsg) Changed interface to be more sensible.
2692 Updated all callers.
2693 (dump_message) Don't double new-lines (why did we do this
2696 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
2698 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
2699 (macro FLT64_MAX) Moved here from pref.h.orig.
2701 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
2703 * set.q: Support SET EPOCH.
2704 (static var set_epoch) New var.
2705 (aux_stc_custom_epoch) New function.
2706 (stc_custom_epoch) New function.
2707 (get_epoch) New function.
2708 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
2710 * format.c: Make it possible just to check whether a specifier is
2711 valid without emitting an error message.
2712 (parse_format_specifier_name) Change interface, update all
2714 (check_input_specifier) Ditto.
2715 (check_output_specifier) Ditto.
2716 (parse_format_specifier) Ditto.
2718 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
2720 * command.def: Add DEBUG POOL.
2722 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
2724 (pool_clear) Properly account for size of pool gizmo.
2725 (pool_realloc) Ditto.
2726 (pool_clone) New function.
2728 * pool.h: Mark our allocation functions MALLOC_LIKE.
2730 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
2732 * Makefile.am: Move many definitions into new top-level
2733 Make.build. Add expressions to SUBDIRS. Add calendar.c,
2734 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
2737 * case.c: (case_resize) New function.
2738 (case_swap) New function.
2740 * casefile.c: Include mkfile.h.
2742 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
2744 * sfm-read.c: Fixed a buglet which caused a crash when trying
2745 to read a non-existent file.
2747 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
2751 * aggregate.c: (parse_aggregate_functions) Code cleanup.
2752 Important part: get rid of spurious copying of function->format to
2753 destvar->print and destvar->write.
2755 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
2757 Fix bug 11916, which was confusing a variable's `index' member
2758 with the variable's position in a var_set. Although these are
2759 usually the same, they are not for array `var_set's.
2761 Took advantage of this bug as an opportunity to clean up and
2762 rewrite parse_var_set_vars().
2764 * vars-prs.c: (parse_vs_variable_idx) New function.
2765 (parse_vs_variable) Reimplement in terms of
2766 parse_vs_variable_idx().
2767 (parse_var_idx_class) New function.
2768 (add_variable) New function.
2769 (add_variables) New function.
2770 (parse_var_set_vars) Rewritten.
2771 (struct var_set) Change `lookup_var' member that returns a
2772 variable into `lookup_var_idx' member that returns an int.
2773 Updated the var set implementations in obvious corresponding ways.
2774 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
2776 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
2778 Use our global variable compare & hash functions and give them
2779 better names. Add similar functions for dealing with double
2780 pointers to variables.
2782 * vars-atr.c: (compare_variables) Renamed compare_var_names().
2783 (hash_variable) Renamed hash_var_name().
2784 (compare_var_ptr_names) New function.
2785 (hash_var_ptr_name) New function.
2787 * t-test.q: (cmd_t_test) Use global compare_var_names(),
2789 (compare_var_name) Removed.
2790 (hash_var_name) Removed.
2792 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
2796 * dictionary.c: (compare_variable_dblptrs) Rename
2797 compare_var_ptrs() and fix it to properly dereference the double
2800 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
2802 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
2803 declare subcommands as mandatory. Closed bug #11843
2805 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
2807 * getline.c command.[ch] command.def: Added (very rudimentary)
2808 support for line completion when in interactive mode. Partially
2809 addresses bug #11693
2811 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
2813 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
2814 problems revealed by valgrind.
2817 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
2819 * set.q: Affixed a fix to the previous fix such that we'll be OK now
2820 whether or not PAGER is set.
2822 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
2824 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
2825 "invalid free" errors. Hopefully fixes bug #11722
2827 * compute.c expr-prs.c: Check that lvalues are populated before
2828 attempting to destroy them. Closes bug #11676
2830 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
2832 * aggregate.c: Initialised the complete agr_proc structure.
2836 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
2838 * print.c: (print_trns_free) Close the dfm writer if there is one,
2839 fixing a memory leak.
2841 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
2843 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
2847 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
2849 * linked-list.[ch] Added
2851 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
2852 set.q: Yet more memory leaks
2854 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
2856 * t-test.q examine.q : More memory leaks fixed.
2858 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
2860 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
2863 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
2865 * ascii.c cartesian.c casefile.c chart.h devind.c
2866 examine.q frequencies.q
2867 html.c output.h piechart.c plot-chart.c plot-hist.c
2869 Integrated the chart rendering into the output stream
2870 (currently only works for html).
2872 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
2873 dummy-chart.c for compiling without charts.
2875 * mkfile.[ch] Created.
2877 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
2878 Added type element so we can tell if it's a chart or a table.
2880 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
2881 API of charts to be more like that of tables.
2883 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
2885 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
2886 main.c. Removed the handler for SIGQUIT.
2888 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
2890 * casefile.c: Added a signal handler to delete temp files on
2893 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
2895 * command.def Added a lot more unimplemented commands.
2897 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
2899 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
2901 * sort.c: (compare_initial_runs) Needed additional level of
2903 (merge_once) Fix plenty of stupid mistakes.
2905 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
2907 * casefile.c: (casefile_sleep) Need to flush_buffer() after
2908 calling casefile_to_disk() or we will lose the last block in the
2909 file if the casefile started out as disk-based.
2910 (casefile_get_reader) Initialize reader->destructive to 0.
2911 (cmd_debug_casefile) Add new test pattern.
2912 (test_casefile) Define new test pattern to make sure
2913 casefile_sleep() works properly.
2915 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
2917 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
2918 plot-hist.c plot-chart.c (Added) Reorganised these files in an
2919 attempt to seperate the creation and processing of charts from their
2922 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
2925 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
2927 * main.c Added a signal handler for SIGFPE
2929 * sort.c Somewhat more robust fix to the previous entry.
2931 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
2933 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
2934 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
2935 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
2938 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
2940 * case.h Fixed bug # 11307
2942 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
2944 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
2947 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
2949 * pfm-read.c: (read_variables) Remove direct manipulation of
2950 v->aux, which is no longer needed. Fixes bug 11483.
2952 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
2954 * data-list.c Fixed a bug in parsing delimiters.
2956 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
2959 * percentiles.c Properly handled calculation of Tukey hinges where
2960 the number of data is small.
2962 * oneway.q Used the generic value_to_string function for independent
2963 variable instead of trying to do it ourselves.
2965 * box-whisker.c Fixed a buglet which caused a crash if the number of
2969 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2971 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
2973 * percentiles.c Fixed some bugs when calculating percentiles when
2974 there's a small number of cases.
2976 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
2978 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
2980 * examine.q factor_stats.[ch] Added calculation of percentiles
2982 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2984 * t-test.q Fixed bug #11227 Made t-test work when the independent
2987 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2989 * factor_stats.c Fixed calculation of trimmed mean under various
2992 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2994 * histogram.c chart.[ch] factor_stats.c frequencies.q
2996 Added code to calculate sensible histogram ranges and limits.
2998 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
3000 * chart.h Updated to reflect many API changes.
3002 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
3003 cartesian.c and into chart.c
3005 * factorstats.[ch] Added the histogram calculations
3007 * casefile.c Removed an unused variable.
3009 * frequencies.q examine.q histogram.c Reworked the API for
3012 * piechart.c Revised the API for piecharts.
3014 * var.h Moved the definitions of freq_tab and freq out of var.h
3015 and into frequencies.q where they belong.
3017 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
3019 * flip.c: (flip_file) Check for off_t separately from fseeko(),
3020 using AC_TYPE_OFF_T.
3022 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
3024 * flip.c: (flip_file) If fseeko() is not available, use long int
3025 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
3026 reporting the problem.
3028 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
3030 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
3031 conflict with stdio.
3033 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
3035 * var-labs.c (var_to_string) Now returns null if the variable is null
3037 * value-labels.c (value_to_string) Made it return null if either the
3038 value or the variable is null.
3040 * hash.c (hsh_clear) Fixed a buglet.
3042 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
3043 with the wrong model.
3045 * casefile.[ch] Added a function to return the casereader.case_idx
3048 * examine.q Implemented the extreme values results.
3050 John Darrington <john@darrington.wattle.id.au>
3052 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
3053 output.[ch] getline.c
3055 Plugged some memory leaks
3057 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
3059 Adopt GSL random number generators, paving the way for providing
3060 the complete suite of random number generators on expressions.
3062 * Makefile.am: Remove random.c, random.h.
3064 * random.c: Removed.
3066 * random.h: Removed.
3068 * algorithm.c: (algo_default_random) Use GSL functions.
3070 * casefile.c: (test_casefile) Use GSL RNG functions.
3072 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
3075 * sample.c: (cmd_sample) Use GSL RNG functions.
3076 (sample_trns_proc) Ditto.
3078 * set.q: (static var set_seed) Removed.
3079 (static var seed_flag) Removed.
3080 (static var rng) New variable.
3081 (aux_stc_custom_seed) No seed value anymore, don't print anything.
3082 (stc_custom_seed) Use new seed functions.
3083 (seed_is_set) Removed.
3084 (get_rng) New function that composes the entire external
3086 (set_rng) New function.
3087 (random_seed) New function.
3089 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
3091 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
3092 John Darrington <john@darrington.wattle.id.au> for reporting this
3095 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
3097 * permissions.c command.def Added the PERMISSIONS command
3099 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
3101 * q2c.c: (dump_header) Don't try to emit #includes at very top of
3102 output file because that will precede #include <config.h>, which
3104 (main) Add needed headers to /* (header) */ code.
3106 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
3108 Instead of making system or portable file readers responsible for
3109 dropping and reordering variables, make them read full cases and
3110 let the caller take care of any changes.
3112 * get.c: New "case map" structure to handle this. Use for GET,
3113 IMPORT, MATCH FILES. Essentially rewrite the whole file.
3115 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
3116 changed appropriately.
3118 * sfm-read.c: (sfm_read_case) Ditto.
3120 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
3122 Decided that case_serialize() and case_unserialize() were too
3123 abstract. Also we need a couple more functions to avoid excessive
3124 copying for data in/out fast paths.
3126 * case.c: (case_serial_size) Removed.
3127 (case_serialize) Rename case_to_values() and make its argument
3128 explicitly an array of union values.
3129 (case_unserialize) Rename case_from_values() and make its argument
3130 explicitly an array of union values.
3131 (case_data_all) New function.
3132 (case_data_all_rw) New function.
3134 * casefile.c: (struct casefile) Change buffer from array of
3135 unsigned char to array of union value for better accuracy.
3136 Redefine buffer_used and buffer_size in terms of values, not
3137 bytes. Remove case_size because it is now redundant with
3138 value_cnt. Fix up all references to these members.
3140 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
3142 * barchart.c: (struct subcat) Make `label' member const to silence
3143 GCC warning with -Wwrite-strings.
3145 * cartesian.c: (struct dataset) Ditto.
3147 * case.c: Don't re-define NDEBUG if already defined.
3148 Add lots of comments.
3150 * str.c: Fix includes.
3152 * crosstabs.q: Fix includes.
3154 * examine.q: Fix includes. Fix GCC warning about unused
3157 * frequencies.q: (stat macro) Removed and replaced where used by
3160 * list.q: Fix includes.
3162 * oneway.q: Fix includes.
3164 * piechart.c: Fix includes. Only define M_PI if not already
3167 * sfm-read.c: (bswap) New function.
3168 (bswap_int32) Write in terms of bswap.
3169 (bswap_flt64) Ditto.
3171 * str.c: (ds_data) Add external definition here, needed because
3172 str.h has only an `extern inline' version.
3174 * value-labels.c: Fix includes.
3176 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
3178 Instead of providing a system or portable file writer with a raw
3179 case in the format needed for output, provide it with a regular
3180 case. The writer takes care of any needed translation.
3182 * aggregate.c: Adopt new scheme for AGGREGATE.
3183 (struct agr_proc) sfm_agr_case member removed.
3184 (write_case_to_sfm) Removed because the new interface is easier to
3187 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
3189 * pfm-write.c: Implement new scheme.
3191 * sfm-write.c: Ditto.
3193 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
3195 Instead of treating `struct file_handle' as a class to subclass
3196 into data files, system files, and portable files, instead use it
3197 as a helper that coordinates access. Now it is opaque, too.
3199 This means that most references to a struct file_handle are now
3200 changed into references to one of struct dfm_reader, struct
3201 dfm_writer, struct sfm_reader, struct sfm_writer, struct
3202 pfm_reader, or struct pfm_writer, according to what's being read
3205 Most related changes are only worth summarizing briefly.
3207 * dictionary.c: (dict_clear) Destroy aux data in deleted
3209 (dict_clear_aux) New function.
3210 (dict_create_var) Initialize aux, aux_dtor.
3211 (dict_delete_var) Destroy aux data in deleted variable.
3213 * file-handle.h: (struct fh_ext_class) Removed.
3214 (struct file_handle) Removed.
3215 (fh_init_files) Removed.
3217 * file-handle.q: Changed references to a handle's `private' member
3218 to direct references.
3219 (struct private_file_handle) Renamed file_handle.
3220 Add next, open_cnt, type, open_mode, aux members.
3221 (struct file_handle_list) Removed.
3222 (extern var inline_file) Removed.
3223 (static var file_handles) Changed from file_handle_list * to
3225 (create_file_handle) Initialize new members.
3226 (fh_close_handle) Removed.
3227 (mode_name) New function.
3228 (fh_open) New function.
3229 (fh_close) New function.
3230 (fh_parse_file_handle) Renamed fh_parse().
3232 * glob.c: (init_glob) Remove fh_init_files() call.
3234 * aggregate.c: use sfm_writer.
3235 (create_sysfile) Removed because the new interface is simpler.
3237 * apply-dict.c: Use sfm_reader.
3239 * data-list.c: Use dfm_reader.
3241 * file-type.c: Use dfm_reader.
3243 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
3245 * inpt-pgm.c: Use dfm_reader.
3247 * print.c: Use dfm_writer.
3249 * sysfile-info: Use sfm_reader.
3251 * dfm-read.c: Adopt new file handle infrastructure.
3253 * dfm-write.c: Ditto.
3255 * pfm-read.c: Ditto.
3257 * pfm-write.c: Ditto.
3259 * sfm-read.c: Ditto.
3261 * sfm-write.c: Ditto.
3263 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
3265 Break dictionary functions into separate header file.
3267 * dictionary.h: New file.
3269 * var.h: Moved dict_*() functions to dictionary.h.
3271 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
3273 Get rid of procedure-specific union in struct variable, using
3274 instead a void * pointer and a destructor function.
3276 Most related changes are only worth brief summaries.
3278 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
3279 old p.crs member in struct variable.
3281 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
3282 of old p.frq member in struct variable.
3284 * histogram.c: (draw_histogram) Takes new freq_tab arg because
3285 it's no longer possible to grab this from var->p.frq.
3287 * piechart.c: (draw_piechart) Ditto.
3289 * group.c: (group_proc_get) New function.
3291 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
3298 * main.c: (execute_command) Clear aux data in default_dict after
3299 each command. (It's debatable whether this should be done.)
3301 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
3302 member in struct variable.
3304 * means.q: Get rid of integer mode, which is not included in
3305 recent SPSS and was the only code that wanted per-variable private
3308 * var.h: (struct crosstab_proc) Removed.
3309 (struct frequencies_proc) Removed.
3310 (struct list_proc) Removed.
3311 (struct get_proc) Removed.
3312 (struct means_proc) Removed.
3313 (struct matrix_data_proc) Removed.
3314 (struct match_files_proc) Removed.
3315 (lots of enums) Removed.
3316 (struct variable) Removed members `p', `get'. Add member
3319 * vars-atr.c: (var_attach_aux) New function.
3320 (var_detach_aux) New function.
3321 (var_clear_aux) New function.
3322 (var_dtor_free) New function.
3323 (discard_variables) Use NULL instead of inline_file.
3325 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
3327 * value-labs.c Fixed the implmentation of value_to_string, so
3328 that it properly handles alpha values.
3330 * oneway.q Changed instances where labels were being probed manually,
3331 to use the canonical {var,value}_to_string functions
3333 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
3335 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
3336 plots. Changed the API of the cartesian plot to be a much lower level
3339 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
3341 * examine.q Added some of the parametric calculations
3343 * factor_stats.[ch] Created
3345 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
3347 * examine.q Changed the definition of factors to be a composite, and
3348 dealt with the consequences.
3350 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
3352 * examine.q Fixed problem where examine wasn't dealing properly with
3355 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
3357 * oneway.q Fixed problem where oneway wasn't dealing properly with
3360 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
3362 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
3363 command which had settings didn't get the appropriate code
3366 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
3367 to convert variables/values to strings.
3369 * examine.q Added framework for the EXAMINE command.
3371 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
3373 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
3374 subcommand types. Changed frequencies.q to use it rather then the
3375 custom parser. Dealt with the consequences. Added a test for NTILES
3376 subcommand of frequencies.
3378 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
3380 * oneway.q Fixed up the behaviour when given missing values
3382 * levene.c oneway.q Fixed a buglet with the levene statistic and
3383 incorporated the levene test into the oneway command.
3385 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
3386 global scope, since they're only relevant to T-TEST
3388 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
3390 * group.c group.h group_proc.h levene.c oneway.q t-test.q
3392 Made the t-test more consistent
3393 with the way it handles groups. That is, it now uses a hash instead
3394 of an array of 2. Also, made the levene.c file independent of the
3395 implementation of the t-test. So now levene should be fine for both
3398 * Added an oneway.q file for one way anova
3400 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
3402 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
3405 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
3409 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
3410 (data_list_trns_free) Free dls->delims.
3412 * t-test.q: (tts_custom_pairs) Free vars.
3413 (ssbox_one_sample_init) Fix tab_vline() argument.
3414 (ssbox_independent_samples_init) Ditto.
3415 (trbox_paired_init) Ditto.
3416 (trbox_one_sample_init) Ditto.
3418 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
3420 Generalize casefiles to the extent that we can use them for
3421 sorting and other kinds of data transformations. Change cases to
3422 be copy-on-write to improve memory efficiency in common cases.
3423 Every access to a member of a `struct ccase' was changed to be a
3424 call to a case_*() function, especially case_data(), case_num(),
3425 case_str(), or case_data_rw(). Many instances of a local variable
3426 named "case_num" were changed to "case_idx" as a consequence.
3427 Many `struct ccase *' were changed to actual `struct ccase'
3428 because of copying semantics of cases. In several places there
3429 was a choice between updating debug code to work with the new ADTs
3430 or just deleting it because it was useless; I chose to delete it.
3432 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
3438 * aggregate.c: (struct agr_proc) Change type of `sort' to
3439 sort_criteria *. Add `break_vars', `break_var_cnt' members.
3440 Rename `vars' to `agr_vars', all references updated. Change
3441 `agr_case' to type `struct ccase'.
3442 (cmd_aggregate) Deal with new members. Use case_create(),
3443 sort_active_file_in_place(), sort_active_file_to_casefile().
3444 (agr_destroy) Deal with new members.
3445 (aggregate_single_case) Ditto.
3446 (dump_aggregate_info) Ditto.
3447 (initialize_aggregate_info) Ditto.
3448 (agr_to_active_file) Ditto.
3449 (presorted_agr_to_sysfile) Ditto.
3450 (sort_agr_to_sysfile) Removed.
3452 * alloc.c: (out_of_memory) Make non-static.
3454 * alloc.h: Prototype out_of_memory().
3456 * casefile.c: Switched from a linked list in-memory representation
3457 to a two-level array-style representation. The linked list was
3458 appropriate when we could stick a header onto cases, but that's no
3459 longer the case. Also, the two-level array will allow for random
3460 in-memory access in case that's ever wanted. Also added the
3461 concept of a `destructive casereader', one that destroys cases in
3462 the underlying casefile as they are read out.
3463 (macro CASES_PER_BLOCK) New macro.
3464 (struct casefile) New members `value_cnt', `case_list_size',
3465 `case_acct_size', `being_destroyed', `cases'. Removed `head',
3467 (struct casereader) Removed `cur'. Added `destructive', `c'.
3468 (global var casefiles) Made static.
3469 (static var case_bytes) New var.
3470 (casefile_create) Takes a value count, not a case size in bytes,
3471 to conform to the case interface. All callers updated. Deal with
3472 new and removed members.
3473 (casefile_destroy) Deal with new and removed members.
3474 (casefile_sleep) New function.
3475 (casefile_get_case_size) Removed.
3476 (casefile_get_value_cnt) New function.
3477 (casefile_append) Rewritten to deal with new and removed members.
3478 (casefile_append_xfer) New function.
3479 (write_case_to_disk) Use case_serialize().
3480 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
3481 Couldn't figure out why.
3482 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
3483 deal with new and removed members.
3485 (merge_sort) Removed.
3486 (casefile_sort) Removed.
3487 (casefile_get_reader) Deal with new and removed members.
3488 (casefile_get_destructive_reader) New function.
3489 (reader_open_file) Make code more readable. Create case for
3491 (casereader_get_casefile) New function.
3492 (casereader_read) Deal with new and removed members. Now returns
3493 a copy of the case, so that the caller is responsible for
3494 destroying the returned case.
3495 (casereader_read_xfer) New function.
3496 (casereader_destroy) Destroy reader's case.
3497 (test_casefile) Second arg is now a value count, all callers
3498 updated. Now tests destructive readers too.
3499 (get_random_case) Deal with new case ADT.
3500 (write_random_case) Ditto.
3501 (read_and_verify_random_case) Ditto.
3503 * crosstabs.q: Remove debug code.
3505 * descript.q: (calc_descriptives) Deal with new case, casefile
3508 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
3510 * do-if.c: Remove unneeded header inclusion.
3512 * expr-prs.c: Remove debug code.
3514 * exprP.h: Remove debug code.
3516 * flip.c: (flip_file) Use fseeko() if available.
3518 * formats.c: Remove debug code.
3520 * get.c: Remove debug code.
3521 (struct mtf_file) Change `input' from `union value *' to `struct
3522 ccase', all references updated.
3524 * levene.c: (levene) Deal with new case, casefile ADTs.
3526 * list.q: Remove debug code.
3528 * loop.c: Remove debug code.
3530 * matrix-data.c: Remove debug code.
3532 * means.q: Remove debug code.
3534 * mis-val.c: Remove debug code.
3536 * pfm-read.c: Remove debug code.
3537 (pfm_read_code) Change second arg from `union value *' to `struct
3538 ccase *', all references updated.
3540 * recode.c: (string_to_long) Make first arg const.
3541 (convert_to_double) Ditto.
3543 * repeat.c: Remove debug code.
3545 * sample.c: Remove debug code.
3547 * sfm-read.c: Remove debug code.
3548 (sfm_read_case) Change second arg from `union value *' to `struct
3551 * sort.c: Redone in terms of casefiles.
3552 (enum sort_direction) Moved here from sort.h.
3553 (struct sort_criterion) New structure.
3554 (struct sort_criteria) New structure.
3555 (cmd_sort_cases) Rewritten.
3556 (prepare_to_sort_active_file) New function.
3557 (sort_active_file_in_place) New function.
3558 (sort_active_file_to_casefile) New function.
3559 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
3560 changed, all callers updated.
3561 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
3562 rewritten & interface changed, all callers updated.
3563 (sort_cases) Renamed sort_execute(), rewritten & interface
3564 changed, all callers updated.
3565 (struct internal_sort) Removed.
3566 (do_internal_sort) Rewritten, interface changed.
3567 (destroy_internal_sort) Removed.
3568 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
3569 (struct initial_run) Removed; an initial run is now just a
3571 (compare_initial_runs) Rewritten.
3572 (struct external_sort) Changed almost completely.
3573 (do_external_sort) Rewritten, interface changed.
3574 (destroy_external_sort) Rewritten.
3575 [HAVE_MKDTEMP] (make_temp_dir) Removed.
3576 [!HAVE_MKDTEMP] (do_mkdir) Removed.
3577 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
3578 (init_external_sort) Removed.
3579 (simulate_error) Removed.
3580 (rmdir_temp_dir) Removed.
3581 (get_temp_file_name) Removed.
3582 (open_temp_file) Removed.
3583 (close_temp_file) Removed.
3584 (remove_temp_file) Removed.
3585 (write_temp_file) Removed.
3586 (read_temp_file) Removed.
3587 (struct record_run) Change `record' from `struct case_lit *' to
3589 (struct initial_run_state) Remove `idx_to_fv', `free_list',
3590 `file_idx', `output_file'. Add `run', casefile'. Change
3591 `last_output' from `struct case_list *' to `struct ccase'.
3592 (write_initial_runs) Change interface, rewrite.
3593 (sort_sink_write) Renamed process_case(), changed interfaced,
3595 (destroy_initial_run_state) Rewritten.
3596 (allocate_cases) Rewritten.
3597 (compare_record) Interface changed, rewritten.
3598 (start_run) Rewritten.
3599 (end_run) Rewritten.
3600 (output_record) Rewritten.
3601 (grab_case) Removed.
3602 (release_case) Removed.
3603 (struct merge_case) Change `cases' from double pointer to single
3605 (merge) Deal with new case and casefile ADTs.
3606 (struct run) Removed.
3607 (merge_once) Rewritten, interface changed.
3608 (fill_run_buffer) Removed.
3609 (sort_sink_make_source) Removed.
3610 (sort_sink_class) Removed.
3611 (struct sort_source_aux) Removed.
3612 (sort_source_read_helper) Removed.
3613 (sort_source_read) Removed.
3614 (read_sort_output) Removed.
3615 (read_internal_sort_output) Removed.
3616 (read_external_sort_output) Removed.
3617 (sort_source_destroy) Removed.
3618 (sort_source_class) Removed.
3620 * sort.h: (struct sort_cases_pgm) Removed.
3621 (enum sort_direction) Moved to sort.c.
3623 * t-test.q: (calculate) Deal with new case, casefile ADTs.
3625 * tab.c: Remove debug code.
3627 * var-labs.c: Remove debug code.
3629 * var.h: (struct ccase) Removed.
3630 (struct case_list) Removed.
3632 * vars-atr.c: (discard_variables) Use free_case_source().
3634 * vars-prs.c: (parse_vs_variable) Make arg const.
3635 (parse_dict_variable) Ditto.
3636 (parse_variables) Make struct dictionary * arg const.
3637 (parse_var_set_vars) Make struct var_set * arg const.
3638 (struct var_set) Add const to some of the function pointers' args.
3639 (var_set_get_cnt) Make arg const.
3640 (var_set_get_var) Make first arg const.
3641 (var_set_lookup_var) Make first arg const.
3642 (dict_var_set_get_cnt) Make arg const.
3643 (dict_var_set_get_var) Make first arg const.
3644 (dict_var_set_lookup_var) Make first arg const.
3645 (var_set_create_from_dict) Make arg const. Add cast to aux
3647 (struct array_var_set) Add const to var member.
3648 (array_var_set_get_cnt) Make arg const.
3649 (array_var_set_get_var) Make first arg const.
3650 (array_var_set_lookup_var) Make first arg const.
3651 (var_set_create_from_array) Make first arg const. Insert cast.
3653 * vfm.c: (struct write_case_data) Change trns_case, sink_case
3654 members from `struct ccase *' to `struct ccase'.
3655 (static var lag_queue) Change from double to single pointer.
3656 (procedure) Optimize trivial case.
3657 (internal_procedure) Deal with changed case, case_source ADTs.
3658 (create_trns_case) Changed interface, rewrote.
3659 (open_active_interface) Initialize modified lag queue.
3660 (write_case) Deal with changed case ADT.
3661 (lag_case) Deal with modified lag queue.
3662 (close_active_file) Destroy modified lag queue.
3663 Deal with changed case_source, case_sink ADTs.
3664 (destroy_storage_stream_info) Make null arg into no-op.
3665 (storage_sink_make_source) Set aux in created source.
3666 (storage_source_read) Deal with changed case, casefile ADTs.
3667 (storage_source_create) New function.
3668 (lagged_case) Rewrite.
3669 (free_case_source) New function.
3670 (free_case_sink) Rewrite.
3671 (struct split_aux_data) Changed prev_case from `struct ccase *' to
3673 (procedure_with_splits) Deal with changed prev_case.
3674 (procedure_with_splits_callback) Ditto.
3675 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
3677 (multipass_procedure_with_splits) Deal with changed prev_case.
3678 (multipass_split_callback) Ditto.
3681 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
3683 The workspace idea didn't work out.
3685 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
3687 * workspace.c: Removed.
3689 * workspace.h: Removed.
3691 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
3693 Fully implement arbitrary delimiters on DATA LIST, extending the
3694 half implementation that was already there.
3696 * data-list.c: (struct data_list_pgm) Remove `delim', add
3697 `delims', `delim_cnt'.
3698 (cmd_data_list) Initialize new members. Parse delimiters and
3699 clean up code a bit.
3700 (cut_field) Extract fields with arbitrary delimiters. Also, fix
3701 handling of leading commas.
3702 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
3704 (read_from_data_list_free) Adapt to new DFM interfaces.
3705 (read_from_data_list_list) Ditto.
3706 (repeating_data_trns_proc) Ditto.
3708 * dfm.c: Split up reader and writer into separate code, because
3709 they do different things. Use struct string instead of explicit
3710 allocation code, for clarity.
3711 (enum dfm_reader_flags) New enum.
3712 (struct dfm_fhuser_ext) Removed.
3713 (struct dfm_reader_ext) New.
3714 (get_reader) New function, used by just about all the reader
3716 (dfm_close) Removed.
3717 (close_reader) New function.
3718 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
3719 (dfm_open_for_writing) Ditto.
3720 (macro force_line_buffer_expansion) Removed.
3721 (count_tabs) Removed.
3722 (tabs_to_spaces) Removed.
3723 (read_record) Deal with new dfm_reader_ext. Use struct string
3724 functions. Don't convert tabs to spaces.
3725 (dfm_eof) New function.
3726 (dfm_get_record) Changed interface, rewrote.
3727 (dfm_expand_tabs) New function.
3728 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
3729 dfm_reader_ext, rewritten.
3730 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
3731 dfm_reader_ext, rewritten.
3732 (dfm_set_record) Removed in favor of dfm_forward_columns().
3733 (dfm_forward_columns) New function.
3734 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
3735 dfm_reader_ext, rewritten.
3736 (static var dfm_r_class) Use close_reader for the destructor.
3737 (struct dfm_writer_ext) New.
3738 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
3739 bounce buffer now instead of local allocation.
3740 (close_writer) New function.
3741 (static var dfm_writer_ext) Use close_writer for destructor.
3742 (cmd_begin_data) Adapt to new dfm_reader_ext.
3744 * file-handle.q: Add support for per-file tab width.
3745 (struct private_file_handle) Add tab_width member.
3746 (q2c specifications) Add tabwidth subcommand.
3747 (cmd_file_handle) Put parsed tab width into private_file_handle.
3748 (create_file_handle) Set default tab width.
3749 (handle_get_tab_width) New function.
3751 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
3753 * inpt-pgm.c: (reread_trns_proc) Ditto.
3755 * matrix-data.c: (context) Ditto.
3756 (another_token) Ditto.
3760 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
3762 * casefile.c: (casefile_destroy) Fix memory leak by freeing
3764 (casereader_destroy) Don't close file descriptor -1.
3766 * recode.c: (cmd_recode) Fix memory leak.
3768 * set.q: (q2c specifications) Fix typo in user message.
3770 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
3771 undefined behavior for overlapping arguments.
3773 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
3775 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
3776 don't call it when we're running under valgrind.
3777 (call_posix_fadvise) New function.
3778 (casefile_to_disk) Use call_posix_fadvise().
3779 (reader_open_file) Ditto.
3781 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
3783 Update our string ADTs, struct string and struct len_string. Get
3784 rid of pool support, which was largely unused. Rename lots of
3785 functions to have more obvious or consistent names.
3787 * ascii.c: Get rid of ascii_pool. It was only used for string
3789 (ascii_open_global) Don't create ascii_pool.
3790 (ascii_close_driver) Don't destroy ascii_pool.
3791 (ascii_postopen_driver) Don't use pool.
3792 (ascii_close_driver) Destroy strings manually.
3794 * str.c: (ds_create) Remove pool argument, all references updated.
3796 (ds_replace) Remove pool support, make more efficient when we
3797 don't need to reallocate.
3798 (ds_destroy) Remove pool support.
3799 (ds_rpad) New function.
3800 (ds_size) Renamed ds_capacity(), all references updated.
3801 (ds_value) Renamed ds_c_str(), all references updated.
3802 (ds_concat) Renamed ds_puts(), all references updated.
3803 (ds_concat_buffer) Renamed ds_concat(), all references updated.
3804 (ds_putchar) Renamed ds_putc(), all references updated.
3805 (ds_getline) Renamed ds_gets(), all references updated.
3806 (ls_create) Remove pool argument, all references updated.
3807 (ls_create_buffer) Ditto.
3808 (ls_destroy) Removed pool support.
3809 (ls_value) Renamed ls_c_str(), all references updated.
3811 * str.h: (ls_length) [__GNUC__] Add inline version.
3812 (ls_c_str) [__GNUC__] Add inline version.
3813 (ls_end) [__GNUC__] Add inline version.
3814 (struct string) Remove pool member. Rename `size' to `capacity',
3815 all references updated.
3817 * tab.c: (text_format) Instead of using pool argument to
3818 ls_create_buffer(), call pool_register() on allocated data.
3820 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
3822 We're abusing the current ASCII driver by telling it to allocate a
3823 9999-line, 9999-character page in the tests. This causes some
3824 systems to curl up and die because it allocates 20 MB of
3825 contiguous RAM. This change alleviates at least part of the
3826 problem. It is mostly a stop-gap until the new output system is
3829 * ascii.c: (struct line) New structure.
3830 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
3831 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
3832 (ascii_preopen_driver) Initialize new members, not old ones.
3833 (ascii_close_driver) Destroy new members, not old ones.
3834 (ascii_open_page) Allocate new members, not old ones.
3835 (expand_line) Allocate room in line.
3836 (draw_line) Use new members.
3837 (ascii_line_horz) Ditto.
3838 (ascii_line_vert) Ditto.
3839 (ascii_line_intersection) Ditto.
3841 (output_lines) Ditto.
3842 (ascii_close_page) Ditto.
3844 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
3846 * matrix.c: Dead code. Removed.
3848 * matrix.h: Dead code. Removed.
3850 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
3852 Contrary to what I'd always understood, there is an efficient
3853 algorithm for deletion from a hash table populated via linear
3854 probing. This change implements it.
3856 * hash.c: (hsh_rehash) Probe in increasing order.
3858 (locate_matching_entry) Ditto.
3859 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
3861 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
3863 * moments.c (calc_moments): Adjust calculation of kurtosis to
3864 avoid subtracting huge numbers from huge numbers, on Michael
3867 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
3869 Rework moments routines for improved numerical stability based on
3870 Michael Kiefte's advice. Any bugs or remaining numerical problems
3871 are still mine though.
3873 There is now a struct moments1 for use with one-pass moments. It
3874 uses a provisional means algorithm as an attempt to improve
3875 accuracy of higher moments. The older struct moments now only
3876 handles two-pass moments.
3878 * aggregate.c: Use moments1 instead moments.
3880 * descript.c: Revert previous change, which is no longer needed
3881 due to the moments revision.
3883 * moments.c: (calc_moments) New function for calculating variance,
3885 (moments_pass_one) Only accumulate weights bigger than zero.
3886 (moments_calculate) Allow calculating the mean on pass one, others
3887 require pass two. Implement in terms of calc_moments().
3888 (struct moments1) New structure.
3889 (init_moments1) New function.
3890 (moments1_clear) Ditto.
3891 (moments1_create) Ditto.
3892 (moments1_add) Ditto.
3893 (moments1_calculate) Ditto.
3894 (moments1_destroy) Ditto.
3895 (cmd_debug_moments) Deal with `struct moments' or `struct
3896 moments1' as requested by user.
3898 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
3900 * Makefile.am (pspp_SOURCES): Remove debug.c.
3902 * debug.c: Removed. It was empty anyway.
3904 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
3906 * descript.c (calc_descriptives): Fix assert failure when only
3907 MOMENT_MEAN is needed.
3909 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
3913 fixed problem with parsing in match_statistic() causing
3914 "DESCRIPTIVE STAT=MEAN." to barf.
3916 "MEAN" is now default if "SORT" given without specification.
3918 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
3919 generally less forgiving of syntax errors: better to have it do
3920 nothing and type it in again then to not know what it actually did
3923 z-score transformation now checks score for user-missing values
3924 and checks std_dev for SYSMIS.
3926 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
3928 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
3929 Changed dict_get_case_weight() to accept an additional int * flag
3930 to complain about system-missing, user-missing, zero, or negative
3931 weights and updated existing functions to pass int * to
3932 dict_get_case_weight().
3934 2004-04-05 jmd <jmd@gnu.org>
3936 * main.c: Fixed configuration problems with gsl
3938 * t-test.q: Fixed some problems encountered when compiling under Cygwin
3940 2004-04-03 blp <blp@gnu.org>
3942 * lexer.c, ChangeLog:
3943 Fix infinite loop on comment at end of file, add test.
3945 2004-04-03 jmd <jmd@gnu.org>
3947 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
3948 Fixed the calculation of percentiles and added --syntax and --algorithm options
3950 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
3952 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
3955 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
3957 * frequencies.q: Fixed the calculation of percentiles
3959 * Makefile.am: Added the --ansi flag and dealt with the
3960 consequences. Added some entries to PSPP_sources so that
3961 make distcheck would pass
3963 * cmdline.c: Added the --syntax and --algorithm options
3965 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
3967 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3969 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
3970 use the new multipass_split_... mechanism.
3972 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
3974 * frequencies.q: (calc_stats) Use moments data structure and
3975 calc_seskew(), calc_sekurt() functions.
3977 * set.q main.c settings.h Added support for --syntax and --algorithm
3980 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
3982 * vfm.c: Had to get last call to multipass_split_output() inside
3983 open_active_file()/close_active_file() pairing, so introduce new
3985 (internal_procedure) Move procedure() code here, except for calls
3986 to open_active_file() and close_active_file().
3987 (procedure) Wrap open_active_file() and close_active_file() around
3988 internal_procedure().
3989 (multipass_procedure_with_splits) Wrap open_active_file() and
3990 close_active_file() around internal_procedure().
3992 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
3994 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
3996 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
3998 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
4000 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
4002 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
4004 * algorithm.c: By default turn off some of the more expensive
4006 (expensive_assert) New macro which expands to assert if
4007 EXTRA_CHECKS is defined, to nothing otherwise.
4008 (unique) Use expensive_assert().
4009 (binary_search) Ditto.
4015 * command.c: (conflicting_3char_prefixes) Words that are the same
4016 don't cause conflicts when they are abbreviated to the first three
4019 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
4020 nonterm_node's n earlier.
4021 (generic_str_func) Ditto.
4023 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
4025 Add support for multipass procedures. Rewrite DESCRIPTIVES to
4026 test multipass support, take advantage of new moments
4027 calculation, and to not be such crappy code. Get rid of q2c
4028 processing for DESCRIPTIVES.
4030 * vfm.c: (struct multipass_split_aux_data) New structure.
4031 (multipass_procedure_with_splits) New function.
4032 (multipass_split_callback) New function.
4033 (multipass_split_output) New function.
4034 * descript.q: Removed.
4036 * descript.c: New file.
4038 * var.h: Removed descriptives enums.
4039 (struct descriptives_proc) Removed.
4040 (struct variable) Removed p.dsc.
4042 * Makefile.am: (q_sources_c) Remove descript.c.
4043 (q_sources_q) Removed descript.q.
4045 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
4047 New manager for keeping track of used workspace.
4049 * workspace.c: New file.
4051 * workspace.h: New file.
4053 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
4055 * sort.c: (do_internal_sort) Use workspace_malloc().
4056 (destroy_internal_sort) Use workspace_free().
4058 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
4060 New `struct casefile' for managing sets of cases.
4062 * casefile.c: New file.
4064 * casefile.h: New file.
4066 * command.def: Add DEBUG CASEFILE command.
4068 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
4070 * sort.c: (sort_cases) Move logic for sending storage file to disk
4071 into do_external_sort().
4072 (struct internal_sort) Use an array of ccase pointers instead of a
4074 (do_internal_sort) Rewrite to handle casefiles.
4075 (compare_case_list) Removed.
4076 (compare_cases) New function.
4077 (compare_case_dblptrs) New function.
4078 (read_internal_sort_output) Deal with new struct internal_sort.
4080 * vfm.c: (static var workspace_overflow) Removed.
4081 (struct storage_stream_info) Removed all the members. Added
4082 struct casefile * member.
4083 (storage_sink_open) Use casefile.
4084 (open_storage_file) Removed.
4085 (write_storage_file) Removed.
4086 (storage_to_disk) Removed.
4087 (destroy_storage_stream_info) Use casefile.
4088 (storage_sink_write) Use casefile.
4089 (storage_sink_make_source) Use casefile.
4090 (storage_source_count) Use casefile.
4091 (storage_source_read) Use casefile.
4092 (storage_source_on_disk) Removed.
4093 (storage_source_get_cases) Removed.
4094 (storage_source_set_cases) Removed.
4095 (storage_source_get_casefile) New function.
4097 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
4099 New `struct moments' for calculating moments.
4105 * moments.c: New file.
4107 * moments.h: New file.
4109 * command.def: Add DEBUG MOMENTS command.
4111 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
4114 * aggregate.c: Modify AGGREGATE to use the new moments
4115 calculation, even if not in such a great way.
4116 (struct agr_var) Add `moments' member.
4117 (parse_aggregate_functions) Set `moments' member to null.
4118 (agr_destroy) Destroy `moments' member.
4119 (accumulate_aggregate_info) Use `moments' for standard deviation.
4120 (dump_aggregate_info) Ditto.
4121 (initialize_aggregate_info) Create or clear `moments'.
4123 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
4124 cube(), pow4() that were in stats.h. All references updated.
4126 * crosstabs.q: stats.h had chi-square significance functions. Use
4128 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
4130 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
4131 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
4133 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
4135 * dictionary.c: (dict_compact_values) Compacted values need to
4138 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
4140 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
4141 `/' at start. Check return value of parse_variables() for error
4144 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
4146 Revamp expressions: make the code a little nicer, and fix bugs
4149 * expr-evl.c: (expr_evaluate) Make expression argument const.
4150 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
4151 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
4152 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
4153 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
4154 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
4155 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
4156 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
4157 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
4158 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
4159 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
4160 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
4161 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
4162 Simplify OP_SYSMIS. Remove OP_STR_MIS.
4164 * expr-opt.c: (optimize_expression) Rewrite.
4169 (macro s0l) Removed.
4171 (macro s1l) Removed.
4173 (macro s2l) Removed.
4176 (eq_num_con) New function.
4177 (optimize_tree) New function.
4178 (macro rnc) Removed.
4179 (macro frnc) Removed.
4180 (str_search) Add const to string params.
4181 (str_rsearch) Ditto.
4182 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
4183 str[], str_len[] locals to substitute for most of removed macros.
4184 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
4185 Removed support for missing values because we're never called with
4186 missing values. Use set_number() or set_number_errno() instead of
4187 rnc or frnc. Removed any stuff that caused trouble in testing.
4188 We can re-add it later if it really slows anything. Fix some
4190 (evaluate_tree_with_missing) Not yet supported. To be added later
4192 (repl_num_con) Removed.
4193 (collapse_node) New function.
4194 (force_repl_num_con) Removed.
4195 (set_number) New function.
4196 (set_number_errno) New function.
4197 (repl_str_con) Removed.
4198 (set_string) New function.
4199 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
4201 (dump_node) No special case for OP_AND, OP_OR.
4203 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
4204 (expr_get_type) New function.
4205 (type_check) Rewrite.
4206 (type_coercion) New function.
4207 (struct operator) New structure.
4208 (match_operator New function.
4209 (parse_binary_operators) New function.
4210 (parse_inverting_unary_operator) New function.
4211 (parse_or) Rewritten.
4212 (parse_and) Rewritten.
4213 (parse_not) Rewritten.
4214 (parse_rel) Rewritten.
4215 (parse_add) Rewritten.
4216 (parse_mul) Rewritten.
4217 (parse_neg) Rewritten.
4218 (parse_exp) Rewritten.
4219 (parse_sysvar) Add $TRUE, $FALSE system variables.
4220 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
4221 (parse_primary) Use allocate_var_node(), allocate_num_con(),
4223 (struct function) Remove desc, change `func' prototype.
4224 (unary_func) Remove special cases.
4225 (MISSING_func) Reduce to unary_func() that just returns a boolean.
4226 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
4227 (VALUE_func) Use allocate_var_node().
4228 (nary_num_func) Allow MIN and MAX for strings.
4229 Use allocate_var_node(). Properly clean up.
4231 (generic_str_func) Use local table instead of removed `desc'
4232 member. Mostly rewrite.
4233 (get_num_args) Revise error message.
4234 (parse_function) Return EXPR_ERROR, not 0 on error.
4236 (macro varies) Removed.
4237 (ops[]) Use expr.def.
4238 (free_node) Do nothing if node is null.
4239 (allocate_num_con) New function.
4240 (allocate_str_con) New function.
4241 (allocate_var_node) New function.
4242 (allocate_binary_nonterminal) New function.
4243 (append_nonterminal_arg) Removed.
4244 (static var func_tab[]) Revised.
4245 (expr_debug_print_postfix) Make parameter const.
4246 Use printf() instead of debug_printf().
4248 * expr.def: New file.
4250 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
4251 use named enum instead of unnamed, all references updated. Add
4252 EXPR_ANY, EXPR_NO_OPTIMIZE.
4254 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
4255 instead of defining OP_* directly.
4256 (macro IS_TERMINAL) New macro.
4257 (macro IS_NONTERMINAL) New macro.
4258 (enum OP_NO_FLAGS) New.
4260 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
4262 * error.c: (err_assert_fail) msg variable needs to be non-const.
4264 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
4266 * debug.c: (cmd_debug_evaluate) Rewrite.
4268 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
4270 Fix some CROSSTABS bit rot stupidity.
4272 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
4273 (internal_cmd_crosstabs) Initializes cells[] correctly.
4274 (float_M_suffix) Rename format_cell_entry(), change prototype,
4276 (display_crosstabulation) Fix cell formatting.
4278 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
4280 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
4281 to call lex_discard_line() to do that.
4283 * command.c: (run_command) Call lex_discard_line() after
4286 * lexer.c: (lex_entire_end) Change behavior.
4287 (lex_rest_of_line) Change behavior. Return const char *.
4288 (lex_discard_line) Don't clear getl_buf, don't emit message.
4290 * main.c: (handle_error) Emit message here.
4292 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
4293 instead of lex_entire_line().
4295 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
4297 * title.c: (get_title) Call lex_discard_line() after
4299 (cmd_file_label) Ditto.
4300 (cmd_document) Deal with const char * return value.
4302 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
4304 Removed REMARK command.
4306 * command.c: (extract_prefix) Removed.
4307 (output_line) Removed.
4308 (cmd_remark) Removed.
4310 * command.def: Remove REMARK.
4312 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
4314 Added abort() after lots of assert(0) invocations to avoid some
4315 compiler warnings. We really need a NOT_REACHED macro.
4317 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4319 * sort.c: Added missing call to temp_file_close. Changed error
4320 messages to warnings.
4322 * set.q: Improved setting of set_view{length,width} to be more tolerant
4325 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
4327 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
4328 used with incorrect syntax.
4330 * error.c, error.h et al: Overridden definition of assert for a
4333 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
4334 subcommand was given when it ought to have been.
4336 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
4338 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
4342 (tab_joint_text) Ditto.
4344 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
4346 * levene.c: Add #include.
4348 * set.q: (set_viewport) Add `int' argument to make its prototype
4349 correct for signal().
4351 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
4353 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
4356 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
4358 Changed DFM from open-at-first-access to explicit-open. Before,
4359 calling dfm_get_record() or dfm_put_record() would automatically
4360 open the file. Now, you have to call dfm_open_for_reading() or
4361 dfm_open_for_writing() explicitly. This makes it possible to
4362 check permissions, file existence, etc. earlier.
4364 Also made struct file_handle more opaque, and clean up in general.
4366 * data-list.c: (cmd_data_list) Open handle for reading.
4368 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
4370 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
4371 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
4372 (open_inline_file) Removed.
4373 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
4374 it. Deal with line_number in extension record instead of file
4376 (dfm_get_record) Rewrote.
4377 (dfm_put_record) Rewrote.
4378 (dfm_push) Assert file is open and one of ours. Deal with
4379 line_number in extension record instead of file handle.
4380 (dfm_pop) Assert file is open and one of ours. Deal with
4381 line_number in extension record instead of file handle.
4382 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
4385 * file-handle.h: (enum constants RH_RF_*) Removed.
4386 (enum constants FH_MD_*) Removed.
4387 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
4388 `recform', `lrecl', `mode' members. Public references to
4389 `recform' changed to use handle_get_mode(), references to `lrecl'
4390 changed to use handle_get_record_width(). Added `private' member.
4391 (enum file_handle_mode) New.
4393 * file-handle.q: (struct private_file_handle) New structure.
4394 (struct file_handle_list) New structure.
4395 (static var files) New.
4396 (static var file_handles) Removed.
4397 (init_file_handle) Removed.
4398 (create_file_handle) Removed.
4399 (get_handle_with_name) New function.
4400 (get_handle_for_filename) New function.
4401 (cmd_file_handle) Rewritten.
4402 (hash_file_handle) Removed.
4403 (cmp_file_handle) Removed.
4404 (fh_init_files) Rewritten.
4405 (fh_parse_file_handle) Rewritten. Allows identifiers as
4407 (fh_get_handle_by_name) Renamed handle_get_name(), all references
4409 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
4410 references updated. Rewritten.
4411 (fh_record_width) Renamed handle_get_record_width(), all
4412 references updated. Rewritten.
4413 (handle_get_mode) New function.
4415 * file-type.c: (cmd_file_type) Open handle for reading.
4417 * filename.c: [unix] (struct file_identity) New structure.
4418 [unix] (fn_get_identity) New function.
4419 [unix] (fn_free_identity) New function.
4420 [unix] (fn_compare_file_identities) New function.
4421 [!unix] (struct file_identity) New structure.
4422 [!unix] (fn_get_identity) New function.
4423 [!unix] (fn_free_identity) New function.
4424 [!unix] (fn_compare_file_identities) New function.
4426 * lexer.c: (static var put) Renamed put_token, all references
4428 (static var put_tokstr) New.
4429 (static var put_tokval) New.
4430 (lex_init) Initialize put_tokstr().
4431 (restore_token) New function.
4432 (save_token) New function.
4433 (lex_get) Use restore_token().
4434 (lex_put_back) Use save_token().
4435 (lex_put_back_id) New function.
4436 (lex_put_forward) Removed.
4437 (lex_preprocess_line) Set put_token instead of using
4439 (lex_negative_to_dash) Use save_token(), set put_token directly.
4440 (dump_token) Use stderr instead of stdout.
4442 * main.c: (main) Remove call to cmd_init().
4444 * matrix-data.c: (cmd_matrix_data) Open file for reading.
4446 * pfm-read.c: Use handle_get_filename() instead of trying to use
4447 h->fn directly, all over.
4449 * pfm-write.c: Ditto.
4451 * print.c: (internal_cmd_print) Open handle for writing.
4452 (dump_table) Use handle_get_filename().
4453 (print_trns_proc) Use handle_get_mode().
4454 (cmd_print_space) Use fh_parse_file_handle().
4455 Open handle for writing.
4456 [0] (debug_print) Removed.
4458 * sfm-read.c: Use handle_get_filename() instead of trying to use
4459 h->fn directly, all over.
4461 * sfm-write.c: Ditto.
4463 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
4467 * autorecode.c: (arc_free) Free arc->src_values.
4469 * error.c: (msg) Free buf.
4471 * val-labs.c: (do_value_labels) Always free vars.
4473 * vfm.c: (close_active_file) If sink has no make_source then call
4474 its destroy function.
4476 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
4478 Fixed cmd_parse() so that it always skips past a full command
4479 name. A few special commands for which this would be bad get
4480 special treatment. This lets us drop code for skipping past the
4481 end of a command name in most cmd_*() functions. It's not worth
4482 listing all the commands affected.
4484 * command.c: (struct command) Remove `cmd' member, replace by
4485 `name' member, all references updated. Remove `word', `next',
4486 `skip_entire_name' members.
4487 (macro DEFCMD) Deal with revised `struct command'.
4488 (macro UNIMPL) Ditto.
4489 (macro SPCCMD) New macro for commands whose last word shouldn't be
4491 (static array cmd_table[]) Make const, rename `commands', remove
4493 (macro COMMAND_CNT) New macro.
4494 (split_words) Removed.
4496 (FILE_TYPE_okay) Make parameter const.
4497 (cmd_parse) Improve error messages.
4498 (match_strings) New function.
4499 (next_word) New function.
4500 (enum command_match) New enum.
4501 (conflicting_3char_prefixes) New function.
4502 (conflicting_3char_prefix_command) New function.
4503 (cmd_match_words) New function.
4504 (count_matching_commands) New function.
4505 (get_command_name) New function.
4506 (free_words) New function.
4507 (unknown_command_error) New function.
4508 (figure_out_command) Renamed parse_command_name(), rewritten.
4510 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
4511 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
4512 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
4515 * command.h: (macro SPCCMD) New.
4517 * include.c: (cmd_include_at) Removed.
4518 (cmd_include) Allow identifier to be used as filename.
4520 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
4522 * t-test.q: (cmd_t_test) Command name is now parsed for us.
4525 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
4527 Start work on better test framework.
4529 * Makefile.am: (pspp_sources) Add debug.c.
4531 * debug.c: New file.
4533 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
4534 cmd_debug_evaluate().
4536 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
4538 * expr.h: (enum constant PXP_DUMP) Removed.
4540 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
4542 * set.q: Implemented the SHOW command, and synced it to the existing
4545 Added a handler for SIGWINCH so that viewlength and viewwidth follow
4546 changes as the window size is changed.
4548 Added fallback to set viewlength and viewwidth from LINES and COLUMS
4549 environment variables if other methods are not available.
4551 glob.c: Removed a lot of global variables from glob.c and encapsulated
4554 random.c: Tidied up the way the random seed is set.
4556 str.c: Added a ds_vprintf function.
4558 error.c: Extended dump_message so that messages are always broken at
4561 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
4563 * pfm-write.c: (bufwrite) Write out the correct element for string
4564 variables. From Andreas Streichardt <streichardt@globalpark.de>.
4566 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
4568 Get rid of static and global (!) vars in matrix-data.c.
4570 * matrix-data.c: (static var nr_data) Removed.
4571 (static var nr_factor_values) Removed.
4572 (static var max_cell_index) Removed.
4573 (static var split_values) Removed.
4574 (struct nr_aux_data) New structure.
4575 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
4576 place of static vars, pass to create_case_source() and procedure()
4578 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
4579 struct matrix_data_pgm *.
4580 (nr_read_splits) Ditto.
4581 (nr_read_factors) Ditto.
4582 (nr_output_data) Ditto.
4583 (static var wr_content) Removed.
4584 (global var wr_data) Removed.
4585 (global var wr_current) Removed.
4586 (struct wr_aux_data) New structure.
4587 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
4588 place of static vars, pass to create_case_source() and procedure()
4590 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
4591 instead of matrix_data_pgm *.
4592 (wr_read_splits) Ditto.
4593 (wr_output_data) Ditto.
4594 (wr_read_rowtype) Ditto.
4595 (wr_read_factors) Ditto.
4596 (wr_read_indeps) Ditto.
4598 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
4600 Get rid of static vars in autorecode.c.
4602 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
4603 `n_arc' to `spec_cnt'. All references updated.
4604 (static var v_src) Removed.
4605 (static var v_dest) Removed.
4606 (static var h_trns) Removed.
4607 (static var nv_src) Removed.
4608 (static var descend) Removed.
4609 (static var print) Removed.
4610 (enum direction) New enum.
4611 (struct autorecode_pgm) New structure.
4612 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
4613 Move n_dest local var into struct autorecode_pgm for ease of
4614 clean-up. Use arc_free().
4615 (arc_free) New function.
4616 (recode) Modify to take struct autorecode_pgm * parameter instead
4617 of using statics. Let the caller clean up.
4618 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
4619 instead of statics. Rearrange code a little.
4621 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
4623 Get rid of static, global vars in recode.c. Remove debug code.
4625 * recode.c: (static var head) Removed.
4626 (global var v) Removed.
4627 (global var nv) Removed.
4628 (cmd_recode) New local variables head, v, nv. Initialize and free
4629 v. Don't call debug_print().
4630 [DEBUGGING] (dump_dest) Removed.
4631 [DEBUGGING] (debug_print) Removed.
4633 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
4635 Get rid of static vars in expr-opt.c.
4637 * expr-opt.c: (static var e) Removed.
4638 (static var nop) Removed.
4639 (static var mop) Removed.
4640 (static var ndbl) Removed.
4641 (static var mdbl) Removed.
4642 (static var nstr) Removed.
4643 (static var mstr) Removed.
4644 (static var nvars) Removed.
4645 (static var mvars) Removed.
4646 (struct expr_dump_state) New structure.
4647 (dump_expression) Use new struct expr_dump_state instead of static
4648 vars and pass to functions we call.
4649 (dump_node) Use struct expr_dump_state * parameter.
4651 (emit_num_con) Ditto.
4652 (emit_str_con) Ditto.
4655 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
4657 Get rid of static var in COUNT.
4659 * count.c: (static var head) Move into cmd_count().
4660 (cmd_count) [DEBUGGING] Don't call debug_print.
4661 [DEBUGGING] (debug_print) Removed.
4663 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
4665 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
4667 * val-labs.c: (static var v) Removed.
4668 (static var nv) Removed.
4669 [DEBUGGING] (debug_print) Removed.
4670 (verify_val_labs) Add struct variable **, int parameters.
4671 (get_label) Ditto. Improve error messages, streamline.
4672 (erase_labels) New function for erasing value labels, taking over
4673 part of verify_val_labs()'s function.
4676 (cmd_value_labels) No need to call init() or done() anymore.
4677 (cmd_add_value_labels) Ditto.
4678 (do_value_labels) Add vars, var_cnt local variables. Clean up
4679 after them internally. Call erase_labels() if we should. Don't
4682 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
4684 Get rid of static vars in MATCH FILES.
4686 * get.c: (static var mtf_head) Removed.
4687 (static var mtf_tail) Removed.
4688 (static var mtf_by) Removed.
4689 (static var mtf_n_by) Removed.
4690 (static var mtf_master) Removed.
4691 (static var mtf_seq_num) Removed.
4692 (static var mtf_seq_nums) Removed.
4693 (static var mtf_sink) Removed.
4694 (static var mtf_case) Removed.
4695 (struct mtf_proc) New structure.
4696 (cmd_match_files) Use struct mtf_proc instead of static vars.
4697 (mtf_processing_finish) Ditto.
4699 (mtf_delete_file_in_place) Ditto.
4700 (mtf_read_nonactive_records) Ditto.
4701 (mtf_compare_BY_values) Ditto.
4702 (mtf_processing) Ditto.
4703 (mtf_merge_dictionary) Ditto.
4705 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
4707 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
4709 * dictionary.c: (dict_rename_var) Add assertion.
4710 (dict_contains_var) Check by index instead of name.
4712 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
4714 Get rid of compaction_necessary, compaction_nval, compaction_case.
4715 Redo VFM interface. Replace disk_sink and memory_sink by
4716 storage_sink, disk_source and memory_source by storage_source.
4718 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
4722 (struct write_case_data) Remove `begin_func', `end_func',
4723 `func_aux' members. Add `aux', `trns_case', `sink_case',
4724 `cases_written', `cases_analyzed' members.
4725 (global var compaction_necessary) Make static.
4726 (global var compaction_nval) Removed.
4727 (global var compaction_case) Removed.
4728 (static var case_count) Removed.
4729 (struct procedure_aux_data) Removed.
4730 (struct split_aux_data) Removed.
4731 (procedure) Remove begin_func, end_func parameters. Rewrite.
4732 (static var not_canceled) Removed.
4733 (process_active_file) Removed.
4734 (process_active_file_write_case) Removed.
4735 (process_active_file_output_case) Removed.
4736 (prepare_for_writing) Moved into open_active_file().
4737 (arrange_compaction) Ditto.
4739 (open_active_file) Rewrote.
4740 (write_case) New function.
4741 [DEBUGGING] (index_to_varname) Removed.
4742 (execute_transformations) New function.
4743 (exclude_this_case) Renamed filter_case(), changed interface.
4744 (clear_case) Added struct ccase * parameter to interface.
4745 (close_active_file) Added struct write_case_data * parameter,
4747 (disk_sink_create) Removed.
4748 (disk_sink_destroy) Removed.
4749 (disk_sink_make_source) Removed.
4750 (disk_sink_write) Removed.
4751 (disk_source_count) Removed.
4752 (disk_source_destroy) Removed.
4753 (disk_source_read) Removed.
4754 (global var disk_sink_class) Removed.
4755 (global var disk_source_class) Removed.
4756 (global var memory_sink_class) Removed.
4757 (global var memory_source_class) Removed.
4758 (memory_sink_create) Removed.
4759 (memory_sink_destroy) Removed.
4760 (memory_sink_make_source) Removed.
4761 (memory_sink_write) Removed.
4762 (memory_source_count) Removed.
4763 (memory_source_destroy) Removed.
4764 (memory_source_get_cases) Removed.
4765 (memory_source_read) Removed.
4766 (memory_source_set_cases) Removed.
4767 (struct disk_stream_info) Removed.
4768 (struct memory_sink_info) Removed.
4769 (struct memory_source_info) Removed.
4770 (write_active_file_to_disk) Removed.
4771 (destroy_storage_stream_info) New function.
4772 (global var null_sink_class) New var.
4773 (global var storage_sink_class) New var.
4774 (global var storage_source_class) New var.
4775 (open_storage_file) New function.
4776 (storage_sink_destroy) New function.
4777 (storage_sink_make_source) New function.
4778 (storage_sink_open) New function.
4779 (storage_sink_write) New function.
4780 (storage_source_count) New function.
4781 (storage_source_destroy) New function.
4782 (storage_source_get_cases) New function.
4783 (storage_source_on_disk) New function.
4784 (storage_source_read) New function.
4785 (storage_source_set_cases) New function.
4786 (storage_source_to_disk) New function.
4787 (storage_to_disk) New function.
4788 (struct storage_stream_info) New structure.
4789 (write_storage_file) New function.
4790 (procedure_write_case) Removed.
4791 (create_case_source) Add `struct dictionary *' parameter, all
4793 (create_case_sink) Ditto.
4794 (free_case_sink) New function.
4795 (struct split_aux_data) New structure.
4796 (procedure_with_splits) New function implementing what procedure()
4798 (SPLIT_FILE_proc_func) Removed.
4799 (procedure_with_splits_callback) New function.
4800 (equal_splits) New function.
4802 * aggregate.c: Pass around a struct instead of using statics.
4803 (static var outfile) Remove.
4804 (enum type) Give it tag `missing_treatment'.
4805 (static var missing) Remove.
4806 (static var sort) Remove.
4807 (static var agr_first) Remove.
4808 (static var agr_next) Remove.
4809 (static var case_count) Remove.
4810 (static var prev_case) Remove.
4811 (static var buf64_1xx) Remove.
4812 (static var buf_1xx) Remove.
4813 (struct agr_proc) New structure incorporating the above.
4814 (cmd_aggregate) Use new struct. Clean up error handling using
4815 agr_destroy(). Completely rewrite actual implementation of
4817 (create_sysfile) Add struct agr_proc * parameter, modify
4819 (parse_aggregate_functions) Ditto.
4820 (free_aggregate_functions) Ditto. Rename agr_destroy().
4821 (aggregate_single_case) Add struct agr_proc * parameter, modify
4823 (accumulate_aggregate_info) Ditto.
4824 (dump_aggregate_info) Ditto.
4825 (initialize_aggregate_info) Ditto.
4826 (agr_00x_trns_proc) Removed.
4827 (agr_00x_end_func) Removed.
4828 (agr_10x_trns_proc) Removed.
4829 (agr_10x_trns_free) Removed.
4830 (agr_10x_end_func) Removed.
4831 (agr_11x_read) Removed.
4832 (agr_11x_finish) Removed.
4833 [DEBUGGING] (debug_print) Removed.
4834 (write_case_to_sfm) Add struct agr_proc * parameter, modify
4836 (agr_to_active_file) New function.
4837 (presorted_agr_to_sysfile) New function.
4838 (sort_agr_to_sysfile) New function.
4840 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
4842 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
4844 * descript.q: (cmd_descriptives) Ditto.
4846 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
4847 to new procedure() interface.
4849 * command.c: (cmd_execute) Adapt to new procedure() interface.
4851 * dictionary.c: (dict_compact_values) Also delete scratch
4853 (dict_get_compacted_value_cnt) New function.
4854 (dict_get_compacted_idx_to_fv) New function.
4856 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
4857 (cmd_flip) Adapt to new procedure() interface.
4858 (flip_sink_write) Use sink->idx_to_fv.
4860 * frequencies.q: (internal_cmd_frequencies) Use
4861 procedure_with_splits().
4863 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
4864 (static var mtf_sink) New static var.
4865 (static var mtf_case) New static var.
4866 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
4867 we actually implement the matching.
4868 (mtf_delete_file_in_place) Use mtf_case.
4869 (mtf_processing) Use mtf_case and mtf_sink.
4870 (cmd_export) Adapt to new procedure() interface.
4872 * levene.c: (levene) Use procedure_with_splits().
4874 * list.q: (cmd_list) Use procedure_with_splits().
4876 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
4877 procedure() interface.
4878 (read_matrices_with_rowtype) Ditto.
4880 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
4881 TEMPORARY. Adapt to new procedure() interface.
4883 * rename-vars.c: Warn about and cancel TEMPORARY.
4885 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
4886 (sort_cases) Use dict_get_compacted_value_cnt() instead of
4887 compaction_nval. Adapt to new procedure() interface. Use
4888 storage_source_to_disk().
4889 (do_internal_sort) Don't try to dump the cases to memory.
4890 (compare_case_lists) Pass null idx_to_fv.
4891 (struct initial_run_state) Add `idx_to_fv' member. Remove
4893 (write_initial_runs) Don't initialize irs->case_size. Adapt to
4894 new procedure() interface. Reset irs->idx_to_fv after calling
4896 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
4897 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
4899 (destroy_initial_run_state) Don't dereference irs after freeing
4901 (allocate_cases) Don't calculate case_size locally.
4902 (compare_record) Add idx_to_fv parameter.
4903 (compare_record_run) Change parameter from struct sort_cases_pgm *
4904 to struct initial_run_state *. Pass irs->idx_to_fv to
4906 (compare_record_run) Third parameter now a struct
4907 initial_run_state *.
4908 (output_record) No need for out_case anymore. Pass irs, not
4909 struct sort_cases_pgm to pop_heap(). Use case_size from struct
4911 (merge) Use case_size from struct sort_cases_pgm.
4912 (merge_once) Use case_size from struct sort_cases_pgm.
4913 Pass null pointer to compare_record() as idx_to_fv.
4914 (global var sort_sink_class) Make static.
4916 * t-test.q: (cmd_t_test) Use procedure_with_splits().
4918 * temporary.c: Remove debugging crap.
4920 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
4922 * t-test.q, levene.c: Fixed up the handling of MISSING values
4925 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
4927 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
4930 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
4932 Change explicit variable name checks into use of
4933 dict_class_from_id().
4935 * dictionary.c: (dict_create_var) Change explicit variable name
4936 check into use of dict_class_from_id().
4938 * get.c: (trim_dictionary) Ditto.
4940 * sel-if.c: (cmd_filter) Ditto.
4942 * sysfile-info.c: (cmd_display) Ditto.
4944 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
4946 * vfm.c: (arrange_compaction) Ditto.
4948 * weight.c: (cmd_weight) Ditto.
4950 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
4952 * temporary.c: (cmd_temporary) When TEMPORARY was the first
4953 transformation following the input program, if any, for some
4954 reason we special-cased f_trns. That's just wrong. It should
4955 always be set to n_trns.
4957 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
4959 * format.c: (parse_format_specifier_name) Fix brown-bag bug
4960 introduced in last check-in.
4962 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
4964 * format.c: (global array translate_fmt[]) Removed.
4965 (translate_fmt) New function as replacement.
4966 (parse_format_specifier_name) Rewrite.
4968 * pfm-read.c: (convert_format) Use translate_fmt() instead of
4971 * sfm-read.c: (parse_format_spec) Ditto.
4973 * postscript.c: (text) Fix handling of fonts with missing
4976 * sort.c: (struct external_sort) Add temp_name member.
4977 (destroy_external_sort) Free temp_dir, temp_name members.
4978 (init_external_sort) Allocate temp_name.
4979 (get_temp_file_name) Change prototype.
4980 (open_temp_file) Deal with change to get_temp_file_name().
4981 (close_temp_file) Ditto.
4982 (remove_temp_file) Ditto.
4983 (write_temp_file) Ditto.
4984 (read_temp_file) Ditto.
4985 (sort_sink_destroy) Removed.
4986 (sort_sink_class) Change destroy member to null.
4988 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
4990 Eliminate temp_case.
4992 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
4993 anymore. Use agr_11x_finish().
4994 (aggregate_single_case) Make first param const.
4995 (accumulate_aggregate_info) Ditto.
4996 (agr_00x_end_func) Use compaction_case, not temp_case.
4997 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
4999 * data-list.c: (struct data_list_pgm) Add `case_size' member.
5000 (cmd_data_list) Initialize case_size.
5001 (read_from_data_list_fixed) Add struct ccase * param, use instead
5003 (read_from_data_list_free) Ditto.
5004 (read_from_data_list_list) Ditto.
5005 (read_one_case) Rename data_list_trns_proc(), all references
5006 updated. Add argument in calling above functions. Use c
5007 argument instead of temp_case.
5008 (destroy_dls) Rename data_list_trns_free(), all references
5011 * expr-evl.c: (expr_evaluate) Make second parameter const.
5013 * file-type.c: (struct file_type_pgm) Add `case_size' member.
5014 (cmd_end_file_type) Initialize `case_size'.
5015 (file_type_source_read) Add struct ccase * parameter. Use instead
5018 * flip.c: Rewritten.
5020 * get.c: (struct get_pgm) New structure to keep track of
5022 (cmd_get) Initialize case_size.
5024 (get_source) Deal with struct get_pgm.
5025 (get_source_read) Add struct ccase * parameter, use instead of
5027 (import_source_read) Ditto.
5029 * get.c: Use a null pointer instead of temp_case to represent the
5030 "current case" in a struct mtf_file's input member.
5031 (mtf_processing_finish) Pass null to mtf_processing(), not
5033 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
5034 (mtf_compare_BY_values) Add extra arg, use instead of null input
5036 (mtf_processing) Use c parameter instead of temp_case. Pass
5037 compaction_case to process_active_file_output_case().
5039 * glob.c: (global variable temp_case) Removed.
5041 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
5042 (cmd_input_program) Initialize case_size. Set
5043 vfm_source->value_cnt.
5044 (init_case) Add struct ccase * parameter, use instead of
5047 (input_program_source_read) Ditto.
5049 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
5050 (dump_cell_content) Ditto.
5051 (nr_output_data) Ditto.
5052 (read_matrices_without_rowtype) Ditto.
5053 (matrix_data_read_with_rowtype) Ditto.
5054 (wr_read_splits) Ditto.
5055 (wr_output_data) Ditto.
5057 * sort.h: (struct sort_cases_pgm) New member `case_size'.
5059 * sort.c: (sort_cases) Initialize scp->case_size.
5060 (struct external_sort) Remove `case_size' member.
5061 (write_initial_runs) Only call vfm_sink->class_destroy if
5063 (struct sort_source_aux) New structure.
5064 (sort_source_read_helper) New function.
5065 (sort_source_read) Use sort_source_read_helper().
5066 (read_sort_output) Change interface to be more reasonable.
5067 (read_internal_sort_output) Ditto.
5068 (read_external_sort_output) Ditto.
5070 * vars-prs.c: (dict_class_to_name) Pass return value through
5073 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
5074 (procedure) Initialize trns_case.
5075 (procedure) Pass trns_case to vfm_source->class->read().
5077 (process_active_file) Start using struct procedure_aux_data.
5078 (process_active_file_write_case) Pass trns_case to
5079 transformations, lag_case(), clear_case().
5080 (process_active_file_output_case) Add struct ccase * parameter.
5081 (create_trns_case) New function.
5082 (make_temp_case) Removed.
5083 (vector_initialization) Removed.
5084 (close_active_file) Only call make_source if non-null, otherwise
5085 set vfm_source to null pointer. Don't free temp_case.
5086 (disk_source_read) Add struct ccase * parameter, use instead of
5088 (memory_source_read) Ditto.
5089 (lag_case) Add const struct ccase * member.
5090 (procedure_write_case) Use trns_case instead of temp_case.
5091 (clear_case) Add struct ccase * member, use instead of temp_case.
5092 (exclude_this_case) Ditto.
5093 (create_case_source) Add struct dictionary * parameter, use to
5094 initialize source->value_cnt.
5096 * vfm.h: (struct case_source) Add `value_cnt' member.
5097 (struct case_source_class) Add struct ccase * parameter to `read'
5098 member function pointer.
5099 (struct case_sink_class) Make struct ccase * parameter const in
5100 `write' member function pointer.
5102 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
5104 Fix a lot of "possibly uninitialized variable" warnings. Some of
5105 them are even real bugs. A few of them make me wonder how the
5108 * aggregate.c: (parse_aggregate_functions) Initialize `function.
5110 * ascii.c: (output_lines) Add default case to switch.
5112 * crosstabs.q: Remove static variable `expected' and all
5114 (display_crosstabulation) Always calculate expected value.
5116 (output_pivot_table) Initialize `cmp'.
5117 (display_crosstabulation) New variable `last_row', which is
5120 * data-in.c: (parse_numeric) Always initialize sign. How did this
5123 * data-list.c: (repeating_data_trns_proc) Always initialize code.
5124 Always set info.ofs. (How did this work?!)
5126 * expr-opt.c: (optimize_tree) Always initialize `m'.
5127 (evaluate_tree) Always initialize `c'. (How did this work?)
5129 * frequencies.q: (frq_custom_variables) Always initialize min,
5131 (frq_custom_grouped) Always initialize `dl'.
5133 * groff-font.c: (groff_read_font) Always initialize char_set.
5135 * matrix-data.c: (nr_output_data) Initialize `split'.
5136 (wr_read_splits) Remove shadowing split_cnt declaration.
5137 (wr_output_data) Initialize `split'.
5139 * output.c: (tokener) Skip add character on syntax error.
5141 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
5143 * postscript.c: (read_ps_encodings) Use line.string instead of
5145 (write_text) Add default case to switch.
5146 (text) Always initialize multiple variables. Fix bug with
5149 * print.c: (fixed_parse_fortran) Initialize head.
5150 (alloc_line) Add default case to switch.
5152 * recode.c: (parse_dest_spec) Handle case where nothing matches.
5153 (recode_trns_proc) Move variable declaration inward. Add default
5156 * sfm-read.c: (read_header) Initialize skip_amt.
5158 * sysfile-info.c: (display_variables) Always initialize pc.
5160 * vars-prs.c: Initialized `included'.
5162 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
5164 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
5165 Just use signal() instead.
5167 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
5169 Get rid of vfm_sink_info and vfm_source_info.
5171 * aggregate.c: (agr_00x_end_func) Don't increment
5172 sfm_sink_info.ncases.
5174 * sort.c: (do_internal_sort) Get case count from
5175 vfm_source->class->count().
5176 (struct external_sort) Add `case_size' member.
5177 (do_external_sort) Initialize case_size.
5178 (struct initial_run_state) Add `case_size' member.
5179 (write_initial_runs) Initialize case_size.
5180 (sort_sink_write) Use case_size.
5181 (read_external_sort_output) Use case_size. Get case_cnt from
5184 * vfm.c: (struct write_case_data) Add underscores to existing arg
5185 names, all references updated. Renamed `aux' as `func_aux', all
5186 references updated. Added new `aux' member.
5187 (global var vfm_source_info) Removed.
5188 (global var vfm_sink_info) Removed.
5189 (struct procedure_aux_data) New.
5190 (struct split_aux_data) New.
5191 (procedure) Use `aux' fields for procedure_aux_data,
5193 (process_active_file_write_case) Pass case_count + 1 to
5194 transformation procedures, exclude_this_case().
5195 (process_active_file_output_case) Don't increment
5196 vfm_sink_info.ncases.
5197 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
5198 to send data to disk early.
5199 (make_temp_case) Don't use vfm_sink_info.case_size.
5200 (close_active_file) Don't initialize vfm_source_info.
5201 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
5202 (disk_sink_create) Initialize and/or update disk_stream_info.
5203 (disk_sink_write) Ditto.
5204 (disk_sink_destroy) Ditto.
5205 (disk_sink_make_source) Ditto.
5206 (disk_source_read) Ditto.
5207 (disk_source_destroy) Ditto.
5208 (global var disk_source_class) Add disk_source_count().
5209 (disk_source_count) New function.
5210 (struct memory_sink_info) Add `case_cnt', `case_size' members.
5211 (struct memory_source_info) Ditto.
5212 (memory_sink_create) Deal with case_cnt, case_size.
5213 (memory_sink_write) Ditto.
5214 (memory_sink_make_source) Ditto.
5215 (memory_source_read) Ditto.
5216 (memory_source_count) New function.
5217 (memory_source_class) Add memory_source_count().
5218 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
5219 proc_aux->cases_written, and pass it to transformation procedures
5220 and exclude_this_case ().
5221 (exclude_this_case) Add case_num parameter. Pass it to
5223 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
5226 * vfm.h: (struct case_source_class) Add `count' member.
5228 * vfmP.h: (struct stream_info) Removed.
5229 (global variable vfm_source_info) Removed.
5230 (global variable vfm_sink_info) Removed.
5232 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
5234 * var.h: (typedef trns_proc_func) New typedef.
5235 (trns_free_func) New typedef.
5236 (struct trns_header) Change `proc' to type trns_proc_func, `free'
5237 to type trns_free_func. This only changes the actual type of
5238 trns_proc_func, adding a `case_num' parameter. Updated all
5239 implementations to use the typedefs instead.
5241 * compute.c: (compute_num) Pass case_num to expr_evaluate().
5242 (compute_num_vec) Ditto.
5243 (compute_str) Ditto.
5244 (compute_str_vec) Ditto.
5246 * do-if.c: (do_if_trns_proc) Ditto.
5248 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
5251 * inpt-pgm.c: (input_program_source_read) Maintain case count,
5252 pass to transformation functions.
5253 (reread_trns_proc) Pass case_num arg to expr_evaluate().
5255 * loop.c: (loop_1_trns_proc) Ditto.
5256 (loop_2_trns_proc) Ditto.
5257 (loop_3_trns_proc) Ditto.
5259 * print.c: (print_space_trns_proc) Ditto.
5261 * sel-if.c: (select_if_proc) Ditto.
5263 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
5265 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
5266 destroying hash table.
5268 * glob.c: (read_active_file) Variable not referenced, removed.
5269 (cancel_input_pgm) Ditto.
5271 * levene.c: Add #include <stdlib.h> needed to call free().
5273 * aggregate.c: (parse_aggregate_functions) Make `function'
5276 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
5278 Start working to eliminate VFM dependence on static variables.
5280 * command.c: (cmd_parse) Use case_source_is_class().
5282 * data-list.c: Rewrite to eliminate use of static variables.
5284 * dfm.c: (cmd_begin_data) Use case_source_is_class().
5286 * file-handle.q: (fh_handle_name) Make parameter const.
5288 * file-type.c: Rewrite to eliminate use of static variables.
5290 * flip.c: Rewrite to eliminate use of static variables.
5292 * format.c: (get_format_var_width) New function.
5294 * get.c: Eliminate use of static variables.
5296 * inpt-pgm.c: Eliminate use of static variables.
5298 * matrix-data.c: Eliminate use of static variables.
5300 * set.q: (set_max_workspace) New variable.
5301 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
5303 * var.h: (struct case_list) Move here from vfmP.h.
5305 * vars-atr.c: (discard_variables) Handle new vfm_source type.
5307 * vfm.c: (vfm_source) Change type from struct case_stream to
5309 (vfm_sink) Change type from struct case_stream to struct
5311 (static var paging) Rename workspace_overflow, all references
5313 (procedure) Use new class structures.
5314 (process_active_file) Ditto.
5315 (process_active_file_write_case) Ditto.
5316 (prepare_for_writing) Use set_max_workspace. Use new class
5318 (close_active_file) Use new class structures. Free old sink.
5319 (global var disk_source_file) Removed.
5320 (global var disk_sink_file) Removed.
5321 (disk_stream_init) Removed.
5322 (disk_stream_read) Removed.
5323 (disk_stream_write) Removed.
5324 (disk_stream_mode) Removed.
5325 (disk_stream_destroy_source) Removed.
5326 (disk_stream_destroy_sink) Removed.
5327 (global var vfm_disk_stream) Removed.
5328 (disk_sink_create) New function.
5329 (disk_sink_write) New function.
5330 (disk_sink_destroy) New function.
5331 (disk_sink_make_source) New function.
5332 (disk_sink_class) New static var.
5333 (disk_source_read) New function.
5334 (disk_source_destroy) New function.
5335 (global var vfm_source_class) New var.
5336 (global var memory_source_cases) Removed.
5337 (global var memory_sink_cases) Removed.
5338 (global var memory_sink_max_cases) Removed.
5339 (struct memory_sink_info) New struct.
5340 (memory_stream_init) Removed.
5341 (memory_stream_read) Removed.
5342 (memory_stream_write) Removed.
5343 (memory_stream_mode) Removed.
5344 (memory_stream_destroy_source) Removed.
5345 (memory_stream_destroy_sink) Removed.
5346 (global var vfm_memory_stream) Removed.
5347 (page_to_disk) Renamed write_active_file_to_disk().
5348 (memory_sink_create) New function.
5349 (memory_sink_write) New function.
5350 (memory_sink_destroy) New function.
5351 (memory_sink_make_source) New function.
5352 (memory_sink_class) New static var.
5353 (memory_source_read) New function.
5354 (memory_source_destroy) New function.
5355 (memory_source_get_cases) New function.
5356 (memory_source_set_cases) New function.
5357 (global var vfm_source_class) New var.
5358 (procedure_write_case) Use new class structures.
5359 (create_case_source) New function.
5360 (case_source_is_complex) New function.
5361 (case_source_is_class) New function.
5362 (create_case_sink) New function.
5364 * vfm.h: (global variable reinit_sysmis) Not used, removed.
5365 (global variable reinit_blanks) Not used, removed.
5366 (global variable init_zero) Not used, removed.
5367 (global variable init_blanks) Not used, removed.
5368 (struct case_source) New struct.
5369 (struct case_source_class) New struct.
5370 (struct case_sink) New struct.
5371 (struct case_sink_class) New struct.
5372 (struct case_stream) Removed.
5374 * vfmP.h: (struct case_list) Moved to var.h.
5376 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
5378 * algorithm.c: (count_equal) New function.
5379 (count_if) New function.
5380 (unique) Add assertions.
5381 (partition) Add assertions.
5382 (is_partitioned) New function.
5383 (copy_if) Add assertions.
5384 (remove_equal) Add assertions.
5385 (lexicographical_compare) Rename lexicographical_compare_3way.
5386 (sort) Add assertions. Rephrase some code.
5387 (is_sorted) New function.
5389 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
5393 * sort.c: Completely rewrite.
5395 * sort.h: Expose interface via struct sort_cases_pgm, not via
5398 * aggregate.c: (sort) New static var.
5399 (cmd_aggregate) Use sort.
5400 (create_sysfile) Ditto.
5401 (aggregate_single_case) Ditto.
5402 (dump_aggregate_info) Ditto.
5403 (agr_00x_end_func) Ditto.
5404 (debug_print) Ditto.
5406 * var.h: (enum SRT_ASCEND) Removed.
5407 (enum SRT_DESCEND) Removed.
5408 (struct sort_cases_proc) Removed.
5409 (struct variable) Remove p.srt member.
5411 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
5413 Get rid of the old, crappy heap structure and replace it by a new,
5414 shiny, C++ STL-like heap structure.
5416 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
5418 * algorithm.c: (push_heap) New function.
5429 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
5431 Increase warning level.
5433 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
5435 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
5437 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
5439 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
5441 * dictionary.c: (dict_create_var) Fix root cause of bug worked
5442 around by previous change log entry.
5444 * compute.c: (lvalue_finalize) Remove workaround from previous
5447 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
5449 * compute.c: Fixed a bug where the Format was not getting set for
5450 computed variables (thus causing a crash when SAVEing).
5452 * Added a test to stop this bug ever coming back
5454 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
5456 Got rid of approx.h. In general, replaced all references to
5457 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
5460 * Makefile.am: (pspp_SOURCES) Removed approx.h.
5462 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
5463 test for mag < EPSILON.
5465 * misc.h: Add definition of EPSILON.
5467 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
5469 * vfm.c: (procedure) Add check to prevent recursive call.
5471 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
5473 * Moved the declarations relating to values to their own header file
5476 * Added levene.c and levene.h
5478 * vars-atr.c: Changed the signature of compare_values to
5479 take const * arguments.
5481 * t-test.q: Changed the structure of struct t_test_proc
5482 variables now contain their own group statistics information.
5483 Eventually, t_test_proc might get renamed, because it'd be
5484 applicable to other commands too.
5486 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
5488 * data-out.c: Clean up. Changed interface of convert_*() to take
5489 either a `double' or a `const char *' instead of a `const union
5490 value *'. Update all implementations of those interfaces.
5491 (data_out) Use switch statements instead of a table.
5492 (convert_AHEX) Rewrite.
5494 * format.h: Update comment.
5496 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
5498 * q2c.c: (dump_header) Add an Emacs header line to output files
5499 that makes generated .c files read-only by default, to make it
5500 difficult to accidentally change generated files.
5502 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
5504 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
5505 not bogus a->v.c <=> b->v.c pointer compare.
5506 (compare_freq_alpha_a) Ditto.
5507 (compare_freq_numeric_d) Ditto.
5508 (compare_freq_alpha_d) Ditto.
5510 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
5512 Changed data_out() to store string data directly into a `union
5513 value''s s member, not indirectly into c.
5515 * crosstabs.q: (output_pivot_table) Use format_short() instead of
5517 (table_value_missing) Ditto.
5518 (float_M_suffix) Ditto.
5519 (format_short) New function.
5521 * data-in.h: (data_in_finite_line) Remove inline definition.
5523 * data-list.c: (destroy_dls_var_spec) New function.
5524 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
5525 (data_list_source_destroy_source) Avoid cast.
5526 (struct repeating_data_trns) New field `id_value'. Update
5528 (cmd_repeating_data) Initialize id_value. Use new
5529 repeating_data_trns_free() for freeing REPEATING DATA
5531 (rpd_parse_record) Rewrite support for record ID to be less bogus.
5532 (repeating_data_trns_free) New function.
5534 * data-out.c: (data_out) Change return type to `void' by replacing
5535 error returns by writing a message into the output buffer.
5536 (convert_A) Read from v->s instead of v->c.
5537 (convert_AHEX) Ditto.
5539 * expr-evl.c: Update comment.
5540 (expr_evaluate) Add assertion in OP_STRING case.
5542 * format.h: (macro MAX_FORMATTED_LEN) New macro.
5544 * list.q: (list_cases) Update for new data_out() semantics.
5546 * print.c: (print_trns_proc) Ditto.
5548 * tab.c: (tab_value) Ditto.
5549 (tab_float) Avoid stupid cast.
5551 * var.h: Update comments.
5552 (macro MAX_STRING) New macro.
5553 (macro MAX_ELEMS_PER_VALUE) New macro.
5555 * vars-atr.c: (compare_values) New function.
5557 * vfm.c: (dump_splits) Update for new data_out() semantics.
5559 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
5561 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
5563 (struct crosstab) Rename v[] to vars[]. All references updated.
5564 (hash_table_entry) Replace the hash algorithm and fix a bug at the
5565 same time, which caused the hash value to depend only on a single
5566 value, not all of the variables' values.
5568 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
5570 Clean up struct dictionary's value_cnt usage.
5572 * dictionary.c: Add a function comment to each function.
5573 (struct dictionary) Rename value_cnt to next_value_idx, which more
5574 accurately reflects its meaning. All references updated.
5575 (dict_rename_vars) Add assertion.
5576 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
5578 (dict_get_case_size) New function.
5580 * aggregate.c: (create_sysfile) Use dict_get_case_size().
5582 * get.c: (mtf_read_nonactive_records) Ditto.
5584 * sort.c: (allocate_cases) Ditto.
5585 (write_initial_runs) Ditto.
5589 * vfm.c: (prepare_for_writing) Ditto.
5593 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
5595 Make vfm.c slightly less grotesque.
5597 * vfm.c: (filter_var) Removed.
5598 (filter_index) Removed.
5599 (FILTERED macro) Removed.
5600 (exclude_this_case) New function.
5601 (process_active_file_write_case) Use exclude_this_case() instead
5602 of FILTERED and inline tests.
5603 (procedure_write_case) Ditto.
5604 (setup_filter) Removed.
5605 (open_active_file) Don't call setup_filter().
5606 (close_active_file) Call dict_get_filter() instead of checking
5609 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
5611 * var.h: (struct variable) Update comments.
5613 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
5615 New functions dict_create_var_assert(), dict_lookup_var_assert().
5616 Converted several dict_*_var()/assert pairs into a single
5617 dict_*_var_assert().
5619 * dictionary.c: (dict_create_var_assert) New function.
5620 (dict_lookup_var_assert) New function.
5622 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
5624 Got rid of "struct long_vec", envector(), devector(), etc. Added
5625 two members `init', `reinit' to struct variable as a substitute.
5627 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
5633 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
5636 * autorecode.c: (cmd_autorecode) destvars don't need init.
5638 * compute.c: (lvalue_finalize) Set reinit.
5640 * data-list.c: (fixed_parse_compatible) Don't need init usually.
5641 (dump_fmt_list) Ditto.
5644 * descript.q: (run_z_pass) Don't need init for z-scores.
5646 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
5648 (dict_clone_var) Copy `reinit' member, initialize `init' member.
5650 * glob.c: (init_glob) Remove vec_init() calls.
5652 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
5654 * loop.c: (internal_cmd_loop) Don't need to call envector().
5656 * numeric.c: (cmd_numeric) Ditto.
5658 (cmd_leave) Ditto. Set `init', `reinit' members.
5660 * recode.c: (cmd_recode) Don't need to call envector().
5662 * repeat.c: (internal_cmd_do_repeat) Ditto.
5664 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
5665 (force_create_variable) Removed prototype.
5666 (force_dup_variable) Ditto.
5668 * vector.c: (cmd_vector) Don't need to call envector().
5670 * vfm.c: (reinit_sysmis) Removed.
5671 (reinit_blanks) Removed.
5672 (init_zero) Removed.
5673 (init_blanks) Removed.
5674 (process_active_file_write_case) No need to deal with vectors.
5675 Call clear_temp_case().
5676 (vector_initialization) Rewrite to use `init', `reinit'.
5677 (close_active_file) No need to call vec_clear().
5678 (procedure_write_case) Call clear_temp_case().
5679 (clear_temp_case) New function.
5681 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
5683 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
5686 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
5688 Add auxiliary argument to procedure() interface. Associated small
5689 clean-ups of vfm interface.
5691 * Updated every caller of procedure() and process_active_file() to
5692 reflect modified interface. Simple, ordinary changes not listed
5695 * Updated every function that implements struct case_stream's
5696 `read' function to take a write_case_func and a write_case_data.
5697 Also updated every caller of write_case() to instead call them
5698 through these arguments. In some cases this meant that the extra
5699 args had to be threaded through a couple of extra levels. This
5700 wasn't difficult or interesting so the details won't be given.
5702 * data-list.c: (struct repeating_data_trns) Add members
5703 `write_case', `wc_data' as kluge.
5704 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
5706 (repeating_data_set_write_case) New function.
5708 * data-list.h: New file to declare repeating_data_trns_proc() and
5709 repeating_data_set_write_case().
5711 * inpt-pgm.c: (input_program_source_read) Call
5712 repeating_data_set_write_case() for all the REPEATING DATA
5713 transformations, so that they know where to send their cases.
5714 It's a big kluge. Also kluge in END CASE.
5715 (end_case_trns_proc) Never called anymore, but we still need it,
5718 * sort.c: (read_sort_output) Update to match struct case_stream
5721 * vfm.c: (struct write_case_data) New structure.
5722 (proc_func) Removed.
5723 (virt_proc_func) Removed.
5724 (begin_func) Removed.
5725 (virt_begin_func) Removed.
5727 (write_case) Removed.
5728 (procedure) Added an auxiliary parameter to each function pointer
5729 argument's prototype. Added an auxiliary data parameter.
5731 (process_active_file) Ditto.
5732 (process_active_file_write_case) Pass aux data along.
5733 (close_active_file) Ditto.
5734 (procedure_write_case) Ditto.
5735 (SPLIT_FILE_procfunc) Ditto.
5737 * vfm.h: (typedef write_case_data) New.
5738 (typedef write_case_func) New.
5739 (struct case_stream) Add parameters to `read' member prototype.
5741 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
5743 * t-test.q: Added calculations for independent samples. (But no Levene
5746 * Makefile.am: Moved q_sources_c into own variable
5748 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
5750 Miscellaneous cleanups.
5752 * Change unused to UNUSED in many source files to reflect modified
5753 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
5754 __CYGWIN32__, __unix__, and unix not to assume that they're
5755 defined to a nonzero value. Change use of __attribute__ to use
5756 NO_RETURN or PRINTF_FORMAT instead.
5758 * alloc.h: Move definitions for local_alloc(), local_free() here
5759 from ../pref.h.orig and simplify.
5761 * expr-evl.c: Instead of working differently based on PAGED_STACK,
5762 use a pool allocator unconditionally.
5763 (CHECK_STRING_SPACE) Removed.
5764 (ALLOC_STRING_SPACE) Removed.
5765 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
5768 * expr-opt.c: (dump_expression) Allocate string pool.
5770 * expr-prs.c: (expr_free) Free string pool.
5772 * pool.c: (pool_destroy) This pool must be removed from its
5773 parent's list of gizmos, not from its own. Use free_all_gizmos().
5774 (pool_clear) New function.
5775 (free_all_gizmos) New function.
5776 (pool_alloc) Use space in empty block after this one if any.
5777 (pool_release) Only empty out blocks, don't actually free() them.
5779 * print.c: Get rid of PAGED_STACK special case by always
5780 dynamically allocating line buffers.
5781 (struct print_trns) Always include the `line' member.
5782 (internal_cmd_print) Always initialize the `line' member.
5783 (alloc_line) Always allocate memory for `line'.
5784 (print_trns_proc) Always initialize buf from `line' member.
5785 (print_trns_free) Always free `line' memory.
5787 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
5790 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
5792 * flip.c: Fixed crash from FLIP when a numeric variable is
5793 specified on NEWNAMES and a large value is used, and a couple of
5794 other minor bugs besides.
5795 (struct varname) Make name a 9-character fixed-size array
5796 instead of a 1-character variable size array.
5797 (make_new_var) Allow digits in variable names.
5798 (flip_stream_write) Limit numeric values to 8 characters and
5799 format system missing and very large and small values more
5802 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
5804 * command.c: Fixed test on command return status for the correct
5805 value, which had been causing a crash under certain invalid input.
5807 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
5809 * t-test.q: Added calculations for the one sample variant of the T-TEST
5811 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
5813 * tab.c: (render_strip) Fix bug that sometimes caused joined text
5814 in joined cells to be rendered outside box boundaries.
5816 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
5818 * random.c (rng_create): Fixed seeding so that it gets reseeded after
5819 SET seed=xx has been called.
5821 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
5823 * random.c (rng_get_double): Fix always-returning-zero bug in my
5824 preferred way, and at the same time make sure rounding doesn't
5827 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
5829 * html.c: (change_attributes) Dead code, removed.
5830 (escape_string) Eliminate code to call change_attributes() that
5831 never actually called it.
5832 (output_tab_table) Get rid of dependence on tab_hit
5833 and struct tab_joined_cell's hit member, which are abominations.
5835 * tab.c: (tab_output_text) Don't call
5836 d->class->text_set_font_by_name if it's a null pointer.
5837 (macro UNROLL_LOOP) Eliminate.
5838 (macro UNROLL_3_LOOPS) Eliminate.
5839 (tabi_render) Rewrite not to use the above macros.
5841 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
5843 Start working on a new output driver system, one that doesn't suck
5844 so much, by adding a "device-independent" output driver. The idea
5845 is to write out only a single output stream, then use separate
5846 processes to translate them into whatever formats we want. This
5847 is similar to how "groff" works with its various output drivers
5848 (grops, grotty, grodvi, ...).
5850 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
5852 * list.q: (write_all_headers) Stub out devind class.
5854 (determine_layout) Ditto.
5857 * output.c: (outp_init) Add devind class.
5859 * devind.c: New file.
5861 * devind.h: New file.
5863 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
5865 * frequencies.q: (hash_value_alpha) Fixed up the previous change
5866 to use the proper string length.
5868 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5870 * Fixed bug where FREQ would crash on alpha values
5872 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
5874 * Removed bletcherous alloca() workarounds for AIX from top of
5875 many files. AIX can use the alternative alloca() implementation
5878 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
5880 * ascii.c: (ascii_option) Fix implementation of headers option.
5882 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
5884 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
5885 multiple blank lines into one.
5886 (struct ascii_driver_ext) Add squeeze_blank_lines option.
5887 (ascii_preopen_driver) Initialize squeeze_blank_lines.
5888 (static var option_tab) Add squeeze entry.
5889 (ascii_option) Set squeeze_blank_lines.
5890 (output_lines) Implement squeezing blank lines.
5892 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
5894 * Removed redundant code from output.h
5896 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
5898 Dictionary classes: each variable is "ordinary", "system", or
5901 * var.h: (enum dict_class) New enum.
5903 * vars-prs.c: (dict_class_from_id) New function.
5904 (dict_class_to_name) New function.
5906 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
5908 * var.h: (struct freq_tab_set) Removed (not used).
5910 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
5912 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
5914 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
5916 * stats.c: (hypercube) Rename pow4(). All references updated.
5918 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
5920 * rename-vars.c: (cmd_rename_variables) Rewritten.
5921 (compare_name) Removed.
5923 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
5925 var_set feature, and code taking advantage of it.
5927 * crosstabs.q: (static var var_dict) Removed.
5928 (static var variables) New variable.
5929 (static var variables_cnt) New variable.
5930 (cmd_crosstabs) Free variables instead of var_dict.
5931 (internal_cmd_crosstabs) Initialize and use variables,
5932 variables_cnt instead of var_dict.
5933 (free_var_dict) Removed.
5934 (crs_custom_tables) Use var_set instead of a copied dictionary.
5935 (crs_custom_variables) Set up variables, variables_cnt instead of
5937 [DEBUGGING] (debug_print) Ditto.
5939 * means.q: (mns_custom_tables) Use var_set instead of a copied
5942 * vars-prs.c: (parse_vs_variable) New function.
5943 (parse_dict_variable) Rewritten.
5944 (parse_variable) Rewritten.
5945 (parse_variables) Renamed parse_var_set_vars(), rewritten.
5946 (parse_variables) New function in terms of parse_var_set_vars().
5947 Now requires its first argument to be non-null. All references
5948 that passed a null pointer updated to pass default_dict instead.
5949 (macro id_dict) Removed.
5950 (parse_DATA_LIST_vars) Add assertions.
5951 (parse_mixed_vars) Ditto.
5952 (struct var_set) New structure.
5953 (var_set_get_cnt) New function.
5954 (var_set_get_var) New function.
5955 (var_set_lookup_var) New function.
5956 (var_set_destroy) New function.
5957 (dict_var_set_get_cnt) New function.
5958 (dict_var_set_get_var) New function.
5959 (dict_var_set_lookup_var) New function.
5960 (dict_var_set_destroy) New function.
5961 (var_set_create_from_dict) New function.
5962 (struct array_var_set) New structure.
5963 (array_var_set_get_cnt) New function.
5964 (array_var_set_get_var) New function.
5965 (array_var_set_lookup_var) New function.
5966 (array_var_set_destroy) New function.
5967 (var_set_create_from_array) New function.
5969 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
5970 instead of parse_variables(NULL, ...) in output code.
5972 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
5974 Change inp_init from a 2-bit vector to an ordinary array.
5975 Initialize it all in cmd_end_input_program() instead of in
5978 * inpt-pgm.c: (enum value_init_type) New enum.
5979 (global var inp_init) Change to `enum value_init_type *', make
5981 (inp_init_size) Removed.
5982 (inp_nval) Change to `size_t', make static.
5983 (cmd_input_program) Don't initialize inp_init or inp_init_size.
5984 (cmd_end_input_program) Initialize inp_init, inp_nval.
5985 (init_case) Rewrite.
5986 (clear_case) Rewrite.
5988 * inpt-pgm.h: Removed.
5990 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
5992 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
5993 Colin Plumb hash. It is simpler and should better resist
5995 (hsh_hash_string) Ditto.
5997 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
5999 * get.c: (export_write_case_func) Remove debug printing code.
6001 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
6003 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
6005 (save_write_case_func) Use &trns->h instead of cast.
6006 (cmd_export) Use &t->h instead of cast.
6008 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
6010 Moved vectors into the dictionary.
6012 * var.h: (struct vector) Moved here from vector.h. `index' member
6013 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
6016 * vector.h: Removed.
6018 * vector.c: (global var vec) Removed.
6019 (global var nvec) Removed.
6020 (cmd_vector) Rewritten.
6021 (find_vector) Removed.
6023 * dictionary.c: (dict_create_vector) New function.
6024 (dict_get_vector) New function, replaces reading global vec[]
6026 (dict_get_vector_cnt) New function, replaces reading global nvec
6028 (dict_lookup_vector) New function, replaces find_vector().
6029 (dict_clear_vectors) New function.
6031 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
6033 Start to move away from `struct variable' p `union' member to void
6036 * var.h: (struct variable) Add `aux' member.
6038 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
6040 Get rid of struct variable `foo' member.
6042 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
6044 (frq_custom_variables) Ditto.
6045 (frq_custom_grouped) Ditto.
6047 * get.c: (struct save_trns) Change `var' member from `int *' to
6048 `struct variable **'.
6049 (cmd_save_internal) Use aux instead of foo.
6050 (save_trns_proc) Use revised `var' member.
6051 (static var mtf_seq_no) Renamed mtf_seq_num.
6052 (static var mtf_seq_nums) New static var.
6053 (cmd_match_files) Initialize mtf_seq_nums.
6054 (mtf_free) Free mtf_seq_nums.
6055 (mtf_processing) Use mtf_seq_nums instead of foo.
6056 (mtf_merge_dictionary) No need to initialize mv->foo.
6057 (cmd_export) Use aux instead of foo. Use revised `var' member.
6058 (mns_custom_tables) Don't use foo to check for duplicates, that's
6059 what PV_NO_DUPLICATE is for.
6061 * var.h: (struct variable) Remove `foo' member.
6062 (struct frequencies_proc) New member.
6064 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
6066 Clean up COMPUTE and IF.
6068 * compute.c: More or less rewrite the darn thing.
6069 (struct compute_trns) Rename and reorder and add and delete
6071 (cmd_compute) Rewrite.
6072 (compute_num) Make conditional on test expression. Now used for
6073 both COMPUTE and IF.
6074 (compute_num_vec) Ditto.
6075 (compute_str) Ditto.
6076 (compute_str_vec) Ditto.
6079 (if_num_vec) Removed.
6081 (if_str_vec) Removed.
6082 (parse_target_expression) Renamed parse_rvalue_expression(),
6084 (new_trns) Renamed compute_trns_create(), rewritten.
6085 (delete_trns) Removed.
6086 (free_trns) Renamed compute_trns_free(), rewritten.
6087 (struct lvalue) New structure.
6088 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
6089 (lvalue_get_type) New function.
6090 (lvalue_is_vector) New function.
6091 (lvalue_finalize) New function.
6092 (lvalue_destroy) New function.
6094 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
6096 * command.def: Disallow MODIFY VARS in input mode, so that
6097 variables can't get dropped and confuse cmd_end_input_program()'s
6098 attempt to fill inp_init[].
6100 * modify-vars.c: (static var forward_positional_ordering) New
6102 (struct var_modification) Entirely changed.
6103 (rearrange_dict) Interface changed, rewritten.
6104 (cmd_modify_vars) Deal with modified struct var_modification, much
6106 (struct var_renaming) New structure.
6107 (compare_var_renaming_by_new_name) New function.
6108 (validate_var_modification) New function.
6110 * var.h: (struct modify_vars_proc) Removed.
6111 (struct variable) Removed member p.mfv.
6113 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
6115 Make EVALUATE a valid command whether we're debugging or not, so
6116 that `make check' can succeed regardless of whether debugging is
6119 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
6121 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
6123 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
6125 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
6126 statement by a simple if test.
6128 * dfm.c: (dfm_get_record) Add assertion.
6130 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
6132 For each file x.c, move #include "x.h" to the very top of the
6133 include list, to catch x.h failing to include the proper headers.
6135 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
6137 * algorithm.c: (find) New function.
6138 (remove_equal) New function.
6139 (set_difference) New function.
6140 (adjacent_find_equal) New function.
6141 [TEST_UNIQUE] Removed test case.
6142 (copy_if) Find end test.
6144 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
6146 * dictionary.c: (dict_get_case_weight) New convenience function.
6148 * aggregate.c: (accumulate_aggregate_info) Use
6149 dict_get_case_weight().
6151 * frequencies.q: (calc_general) Ditto.
6152 (calc_integer) Ditto.
6155 * t-test.q: (groups_calc) Ditto.
6158 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
6160 * glob.c: (global var default_dict) Change from `struct
6161 dictionary' to `struct dictionary *'. All references changed.
6162 (init_glob) Initialize default_dict with dict_create().
6164 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
6166 struct dictionary now made opaque. All related functions:
6168 * get.c: (rename_variables) Removed.
6169 (dict_delete_run) Removed.
6171 * temporary.c: (copy_variable) Removed.
6172 (new_dictionary) Removed.
6173 (save_dictionary) Removed.
6174 (restore_dictionary) Removed.
6175 (free_dictionary) Removed.
6177 * vars-atr.c: (clear_default_dict) Removed.
6178 (find_variable) Removed.
6179 (find_dict_variable) Removed.
6180 (create_variable) Removed.
6181 (delete_variable) Removed.
6182 (common_init_stuff) Removed.
6183 (init_variable) Removed. Updating of inp_init moved into
6184 cmd_end_input_program().
6185 (replace_variable) Removed.
6186 (rename_variable) Removed.
6187 (clear_variable) Removed.
6188 (dup_variable) Removed.
6190 * vars-prs.c: (is_varname) Removed.
6191 (is_dict_varname) Removed.
6192 (fill_all_vars) Removed.
6194 * vector.c: (find_vector) Removed.
6196 * weight.c: (stop_weighting) Removed.
6198 * dictionary.c: New file.
6199 (dict_create) New, replaces new_dictionary().
6200 (dict_clone) New, replaces save_dictionary() and
6201 restore_dictionary().
6202 (dict_clear) New, replaces clear_default_dict().
6203 (dict_destroy) New, replaces free_dictionary().
6204 (dict_get_var_cnt) New function, replaces references to
6206 (dict_get_var) New function, replaces references to dict->var[i].
6207 (dict_get_vars) New function, replaces fill_all_vars().
6208 (dict_create_var) New, replaces create_variable(). Interface
6209 drops `type' parameter, using a zero `width' to designate numeric.
6210 (dict_clone_var) New, replaces dup_variable().
6211 (dict_rename_var) New, replaces rename_variable().
6212 (dict_lookup_var) New, replaces find_variable(),
6213 find_dict_variable(), is_varname().
6214 (dict_contains_var) New function.
6215 (compare_variable_dblptrs) New function.
6216 (dict_delete_var) New function, replaces clear_variable().
6217 (dict_delete_vars) New function, replaces dict_delete_run().
6218 (dict_reorder_vars) New function.
6219 (dict_rename_vars) New function, replaces rename_variables().
6220 (dict_get_weight) New function, replaces reading dict->weight_var.
6221 (dict_set_weight) New function, replaces writing dict->weight_var
6222 or calling stop_weight(dict).
6223 (dict_get_filter) New function, replaces reading dict->filter_var.
6224 (dict_set_filter) New function, replaces writing dict->filter_var.
6225 (dict_get_case_limit) New function, replaces reading dict->N.
6226 (dict_set_case_limit) New function, replaces writing dict->N.
6227 (dict_get_value_cnt) New function, replaces reading dict->nval.
6228 (dict_compact_values) New function, replaces a loop that was
6229 replicated in several places.
6230 (dict_get_split_vars) New function, replaces reading dict->splits.
6231 (dict_get_split_cnt) New function, replaces reading
6233 (dict_set_split_vars) New function, replaces writing dict->splits.
6234 (dict_get_label) New function, replaces reading dict->label.
6235 (dict_set_label) New function, replaces writing dict->label.
6236 (dict_get_documents) New function, replaces reading
6238 (dict_set_documents) New function, replaces writing
6241 All references to above functions updated.
6243 * aggregate.c: (cmd_aggregate) Copy file label and documents from
6244 old dictionary to new by hand, because dict_create() can't do it
6245 itself. Use dict_set_documents(), dict_set_split_vars().
6247 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
6248 calling dict_destroy().
6250 * data-list.c: (dls_var_spec) Remove `type' member, replace by
6252 (fixed_parse_compatible) Some slightly nontrivial changes for
6254 (dump_fmt_list) Ditto.
6257 * file-type.c: (create_col_var) Ditto.
6259 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
6260 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
6261 (rename_variables) Use dict_rename_vars().
6262 (mtf_merge_dictionary) Use dict_get_documents(),
6263 dict_set_documents(), dict_compact_values().
6265 * pfm-read.c: (read_variables) Deal with changes to weighting.
6267 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
6268 is_varname() in output code.
6270 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
6271 other dictionary functions.
6273 * title.c: (add_document_line) Use dict_get_documents(),
6274 dict_set_documents().
6276 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
6277 reset default_handle by hand. dict_clear() will clear vectors so
6278 there's no need for that by hand.
6280 * vfm.c: (close_active_file) Move call to finish_compaction()
6281 earlier, so that we can do the compaction as a single step using
6282 dict_compact_values(). Use dict_clear_vectors().
6283 (finish_compaction) Use dict_delete_var(), dict_compact_values().
6285 Some functions don't have replacements:
6287 * vars-atr.c: (force_create_variable) Removed. All references
6288 updated to dict_create_var() followed by an assertion.
6289 (force_dup_variable) Removed. All references updated to
6290 dict_clone_var() followed by an assertion.
6292 * weight.c: (update_weighting) Removed. No longer necessary, so
6293 all references removed.
6295 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
6299 * aggregate.c: Eliminate separation of weighted and unweighted
6300 case. It made the code too obscure and I doubt it was actually
6301 faster. Instead, all code uses the "weighted" code, because
6302 that's a generalization of the "unweighted" code.
6305 (parse_aggregate_functions) No need to set FWEIGHT.
6306 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
6307 (dump_aggregate_info) Ditto.
6308 (initialize_aggregate_info) No need for special plain_function
6309 that gets rid of FWEIGHT option.
6311 * aggregate.c: Get rid of approximations.
6312 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
6314 (aggregate_single_case) Don't use approx_ne().
6316 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
6318 * ascii.c (ascii_line_width): Dead code, removed.
6320 * postscript.c (ps_line_width): Ditto.
6322 * q2c.c (xrealloc): Ditto.
6324 * count.c (internal_cmd_count): Ditto.
6326 * means.q (validate_dependent_endpoint): Ditto.
6328 * set.q: (cmd_gset) Ditto.
6330 * weight.c: [0] (weight_trns_proc) Ditto.
6332 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
6334 Make the code -Wmissing-prototypes clean.
6336 * Makefile.am (version.c): Add #include "version.h".
6338 * ascii.c: (ascii_open_global) Make static.
6339 (ascii_close_page) Ditto.
6340 (ascii_font_sizes) Ditto.
6341 (ascii_postopen_driver) Ditto.
6342 (ascii_close_driver) Ditto.
6343 (ascii_option) Ditto.
6344 (ascii_open_page) Ditto.
6345 (ascii_line_horz) Ditto.
6346 (ascii_line_vert) Ditto.
6347 (ascii_line_intersection) Ditto.
6349 (ascii_polyline_begin) Ditto.
6350 (ascii_polyline_point) Ditto.
6351 (ascii_polyline_end) Ditto.
6352 (ascii_text_set_font_by_name) Ditto.
6353 (ascii_text_set_font_by_position) Ditto.
6354 (ascii_text_set_font_by_family) Ditto.
6355 (ascii_text_get_font_name) Ditto.
6356 (ascii_text_get_font_family) Ditto.
6357 (ascii_text_set_size) Ditto.
6358 (ascii_text_get_size) Ditto.
6359 (ascii_text_metrics) Ditto.
6360 (ascii_text_draw) Ditto.
6361 (ascii_close_page) Ditto.
6363 * cmdline.h: New header for parse_command_line(). Used where
6366 * command.c: Move prototypes for cmd_*() functions to command.h.
6368 * command.h: Prototypes for cmd_*() functions moved here from
6371 * crosstabs.q: (gamma_int) Ditto.
6373 * file-handle.h: Add fh_init_files() prototype.
6375 * getline.c: (welcome) Ditto.
6377 * glob.h: New header for init_glob(). Used where appropriate.
6379 * hash.c: (comparison_helper) Ditto.
6381 * html.c: (html_open_global) Ditto.
6382 (html_close_global) Ditto.
6383 (html_preopen_driver) Ditto.
6384 (html_postopen_driver) Ditto.
6385 (html_close_driver) Ditto.
6386 (html_option) Ditto.
6387 (html_open_page) Ditto.
6388 (html_close_page) Ditto.
6389 (html_submit) Ditto.
6391 * inpt-pgm.c: (input_program_source_read) Ditto.
6393 * output.c: (find_defn_value) Ditto.
6394 (destroy_list) Ditto.
6396 * pfm-read.c: (read_int) Ditto.
6398 * postscript.c: (ps_open_global) Ditto.
6399 (ps_close_global) Ditto.
6400 (ps_font_sizes) Ditto.
6401 (ps_preopen_driver) Ditto.
6402 (ps_postopen_driver) Ditto.
6403 (ps_close_driver) Ditto.
6405 (ps_open_page) Ditto.
6406 (ps_close_page) Ditto.
6407 (ps_line_horz) Ditto.
6408 (ps_line_vert) Ditto.
6409 (ps_line_intersection) Ditto.
6411 (ps_polyline_begin) Ditto.
6412 (ps_polyline_point) Ditto.
6413 (ps_polyline_end) Ditto.
6414 (ps_text_set_font_by_name) Ditto.
6415 (ps_text_set_font_by_position) Ditto.
6416 (ps_text_set_font_family) Ditto.
6417 (ps_text_get_font_name) Ditto.
6418 (ps_text_get_font_family) Ditto.
6419 (ps_text_set_size) Ditto.
6420 (ps_text_get_size) Ditto.
6421 (ps_text_metrics) Ditto.
6422 (ps_text_draw) Ditto.
6424 * q2c.c: (finish_up) Ditto.
6433 (find_symbol) Ditto.
6436 (force_string) Ditto.
6438 (match_token) Ditto.
6441 (parse_setting) Ditto.
6442 (parse_specifier) Ditto.
6443 (parse_specifiers) Ditto.
6444 (parse_subcommand) Ditto.
6445 (dump_specifier_vars) Ditto.
6447 (make_identifier) Ditto.
6448 (dump_declarations) Ditto.
6449 (dump_specifier_init) Ditto.
6450 (dump_vars_init) Ditto.
6452 (dump_specifier_parse) Ditto.
6453 (dump_subcommand) Ditto.
6454 (dump_parser) Ditto.
6455 (dump_header) Ditto.
6457 (recognize_directive) Ditto.
6459 * recode.c: (string_to_long) Ditto.
6461 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
6463 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
6466 * sort.c: (sort_stream_read) Ditto.
6467 (sort_stream_mode) Ditto.
6469 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
6471 * algorithm.c (binary_search): Fix comparison.
6473 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
6475 * algorithm.c: (binary_search) Fix assertion.
6477 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
6479 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
6481 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
6483 * sort.c: (compare_case_lists) Rewrite.
6485 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
6487 * quicksort.c: Removed (not used).
6489 * quicksort.h: Removed (not used).
6491 * sort.c: Removed blp_quicksort() prototype.
6493 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
6495 * postscript.c: (int_2_compare) Rewrite.
6496 (compare_line) Rewrite.
6498 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
6500 * matrix-data.c (compare_factors) Use lexicographical_compare()
6502 (compare_doubles) New function.
6504 * algorithm.c: (lexicographical_compare) New algorithm.
6506 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
6508 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
6510 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
6512 * expr-prs.c: (cmp_func) Removed.
6513 (parse_function) Use binary_search() algorithm.
6514 (compare_functions) New function.
6515 (init_func_tab) Use sort() algorithm.
6517 * algorithm.c: (binary_search) New algorithm.
6519 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
6521 * descript.q: (display) Use sort() algorithm instead of qsort().
6522 (compare_func) Removed.
6523 (descriptives_compare_variables) New function.
6525 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
6527 Get rid of AVL trees. Hashes are more appropriate for everything
6530 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
6536 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
6538 Much code can be clarified by using C++ STL-like algorithms. Not
6539 all uses of these algorithms are listed below, only the ones where
6540 the change to an algorithm was the only change of interest.
6542 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
6544 * algorithm.c: New file.
6546 * algorithm.h: New file.
6548 * modify-vars.c: (static var forward) Removed.
6549 (static var positional) Removed.
6550 (compare_variables) Removed.
6551 (struct ordering) New.
6552 (cmd_modify_vars) Use sort() algorithm.
6553 (compare_variables_given_ordering) New function.
6554 (rearrange_dict) Use sort() algorithm.
6556 * sysfile-info.c: (cmd_display) Use sort() algorithm.
6557 (cmp_var_by_name) Removed.
6559 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
6561 Make file handles use a hash table.
6563 * file-handle.q: (files) Change to hash table, make static.
6564 (cmd_file_handle) Use hash table functions.
6565 (fh_get_handle_by_filename) Ditto.
6566 (fh_get_handle_by_name) Ditto.
6567 (hash_file_handle) New function.
6568 (cmp_file_handle) Rewrite.
6569 (fh_init_files) Use hash table functions.
6571 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
6573 Clean up FREQUENCIES.
6575 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
6577 * frequencies.q: Remove a lot of old #if'd out code at the end.
6578 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
6579 or calc_weight(). Initialize percentile_values.
6580 (calc) New function based on calc_weight() from frequencies.g.
6581 (precalc) Use hash functions.
6582 (static var comparison_func) Removed.
6583 (static var comparison_param) Removed.
6584 (comparison_helper) Removed.
6585 (get_freq_comparator) New function.
6586 (not_missing) New function.
6588 (postprocess_freq_tab) Use hash table functions, algorithms,
6589 get_freq_comparator(). Rewrite.
6590 (cleanup_freq_tab) Rephrase.
6591 (add_percentile) Clean up spacing.
6592 (hash_value_numeric) New function.
6593 (hash_value_alpha) New function.
6594 (compare_value_numeric_a) Rewrite.
6595 (compare_value_alpha_a) Rewrite.
6596 (compare_value_numeric_d) Rewrite.
6597 (compare_value_alpha_d) Rewrite.
6598 (compare_freq_numeric_a) Rewrite.
6599 (compare_freq_alpha_a) Rewrite.
6600 (compare_freq_numeric_d) Rewrite.
6601 (compare_freq_alpha_d) Rewrite.
6602 (calc_stats) Clean up mode, percentiles, max.
6603 (dump_statistics) Clean up spacing.
6605 * frequencies.g: Removed.
6607 * var.h: (struct freq_tab) Change `data' to hash table.
6609 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
6611 * file-handle.h: Remove declaration of global variable `files',
6612 which wasn't used anywhere.
6614 * postscript.c: (add_encoding) Remove superfluous cast.
6617 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
6620 * temporary.c: [0] (display_tree) Removed.
6622 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
6624 Implement a new random number generator based on the alleged RC4
6627 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
6630 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
6631 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
6633 (static var V[]) Removed.
6634 (static var Y) Removed.
6635 (static var X2) Removed.
6636 (setup_randomize) Removed.
6638 (rand_uniform) Removed.
6639 (rand_normal) Removed.
6640 (struct rng) New structure.
6641 (rng_create) New function.
6642 (rng_destroy) New function.
6643 (swap_byte) New static function.
6644 (rng_seed) New function.
6645 (rng_get_bytes) New function.
6646 (rng_get_int) New function.
6647 (rng_get_unsigned) New function.
6648 (rng_get_double) New function.
6649 (rng_get_double_normal) New function.
6650 (pspp_rng) New function.
6652 * random.h: Sync up to random.c.
6654 * sample.c: (struct sample_trns) Make `frac' unsigned and a
6655 fraction of UINT_MAX, not 65536.
6656 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
6659 * vfm.c: (open_active_file) No need to call setup_randomize() any
6662 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
6664 Change dictionary name indexes to use hash tables instead of AVL
6667 * crosstabs.q: (free_var_dict) Use hash tables.
6668 (crs_custom_tables) Ditto.
6669 (calc_general) Ditto.
6670 (compare_table_entry) Rewrite.
6671 (enum_var_values) Reorder parameters. All references updated.
6674 * get.c: (rename_variable) Use hash tables.
6675 (mtf_merge_dictionary) Ditto.
6677 * glob.c: (init_glob) Use hash tables.
6678 (cmp_variable) Removed.
6680 * means.q: (mns_custom_tables) Use hash tables.
6682 * modify-vars.c: (rearrange_dict) Use hash tables.
6684 * rename-vars.c: (cmd_rename_variables) Use hash tables.
6686 * sfm-read.c: (read_header) Use hash tables.
6687 (read_variables) Ditto.
6689 * temporary.c: (new_dictionary) Use hash tables.
6690 (save_dictionary) Ditto.
6691 (restore_dictionary) Ditto.
6693 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
6694 hash table `name_tab'.
6696 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
6697 [DEBUGGING] (dump_var_tree) Removed.
6698 (find_variable) Use hash tables.
6699 (find_dict_variable) Ditto.
6700 (common_init_stuff) Ditto.
6701 (rename_variable) Ditto.
6702 (clear_variable) Ditto. Also, remove debug code.
6703 (dup_variable) Use hash tables.
6705 * vars-prs.c: (fill_all_vars) Use hash tables.
6706 (is_dict_varname) Ditto.
6707 (parse_dict_variable) Ditto.
6709 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
6711 Change value labels to use hash tables instead of AVL trees, and
6712 change value labels into an ADT.
6714 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
6716 * value-labels.c: New file.
6718 * value-labels.h: New file.
6720 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
6721 Get rid of a stupid use of goto.
6723 * autorecode.c: (compare_alpha_value) Rewrite.
6724 (hash_alpha_value) Ditto.
6725 (compare_numeric_value) Rewrite.
6726 (hash_numeric_value) Ditto.
6728 * frequencies.q: (dump_full) Use value label ADT.
6730 * pfm-read.c: (read_value_label) Use value label ADT.
6732 * pfm-write.c: (write_value_labels) Use value label ADT.
6734 * sfm-read.c: (read_variables) Use value label ADT.
6735 (read_value_labels) Rewrite.
6737 * sfm-write.c: (write_value_labels) Rewrite.
6739 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
6740 (display_variables) Ditto.
6741 (describe_variable) Ditto.
6743 * t-test.q: (print_t_groups) Use value label ADT.
6745 * temporary.c: (copy_variable) Use value label ADT.
6746 (free_dictionary) Ditto.
6748 * val-labs.c: (verify_val_labs) Use value label ADT.
6750 (debug_print) Ditto.
6751 (val_lab_cmp) Removed.
6752 (inc_ref_count) Removed.
6753 (copy_value_labels) Removed.
6755 * var.h: (struct value_label) Removed.
6756 (struct variable) Change AVL tree `val_lab' into hash table
6759 * vars-atr.c: (init_variable) Use value label ADT.
6760 (clear_variable) Ditto.
6761 (free_value_label) Removed.
6762 (free_val_lab) Removed.
6763 (get_val_lab) Removed.
6764 (compare_variables) New function.
6765 (hash_variable) New function.
6767 * vfm.c: (dump_splits) Use value label ADT.
6769 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
6771 Add to the hash table interface.
6773 * hash.c: (hsh_hash_bytes) Add assertion.
6774 (hsh_hash_string) Ditto.
6778 (hsh_create) Ditto. Also make minimum `size'.
6779 (hsh_destroy) Rephrase.
6780 (sort_nulls_last) Removed.
6781 (not_null) New function.
6783 (comparison_helper) Ditto.
6784 (hsh_sort) Rewritten.
6785 (hsh_data_copy) New function.
6786 (hsh_sort_copy) Ditto.
6788 (hsh_replace) Ditto.
6789 (hsh_hash_double) Ditto.
6790 (hsh_delete) Fix stupid bug.
6792 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
6793 * added a calculation of the mode to FREQUENCIES
6795 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
6797 * moved (un)defs of DEBUGGING to config.h
6799 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
6801 * groff-font.c: (add_kern) Fix indentation.
6802 (add_kern) Use & instead of % to take power-of-2 modulus.
6803 (font_get_kern_adjust) Likewise.
6805 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
6807 * autorecode.c: (recode) Replace stupid use of memcpy() by
6809 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
6810 (hash_numeric_value) Ditto.
6811 (autorecode_proc_func) pool_strdup() was wrong here because the
6812 source string was not null-terminated. Use new pool_strndup()
6815 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
6816 use of hsh_iterator_init().
6818 * data-in.c: (parse_N) Initialize i->v->f.
6820 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
6823 * groff-font.c: Use power-of-2 hash table sizes, not prime.
6824 (groff_read_font) Don't call hsh_next_prime(). Don't call
6826 (static var hash) Remove `size_p', `max_used' members.
6827 (font_char_name_to_index) Don't call hsh_next_prime(). Use
6828 hsh_hash_string() instead of hashpjw(), & instead of %.
6829 (default_font) Don't call hsh_next_prime().
6831 * pool.c: (pool_strndup) New function.
6832 (pool_strdup) Reimplement in terms of pool_strndup.
6834 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
6836 (hash_ps_encoding) Use hsh_hash_string().
6837 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
6838 (hash_filename2font) Use hsh_hash_string().
6840 * som.c: Add #include <stdlib.h>.
6842 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
6843 (by destroying its pool).
6845 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
6847 Miscellaneous hash table code cleanup:
6849 * hash.h: (struct hsh_table) Moved into hash.c.
6850 (hsh_count) Ditto, and transformed into function.
6851 (hsh_compare_func) New typedef, used for defining otherwise-long
6852 function types here and in hash.c
6853 (hsh_hash_func) Ditto.
6854 (hsh_free_func) Ditto.
6856 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
6857 `table' to `entries'. Removed `mp'. All references updated.
6858 (hsh_clear) Don't shrink entries array; if the hash was this big
6859 once, it probably will be again.
6860 (hsh_rehash) Made static.
6861 (force_hsh_insert) Renamed hsh_force_insert.
6862 (force_hsh_find) Renamed hsh_force_find.
6864 Made hash table sizes powers of 2, because that's fine with any
6865 reasonable hash function and because taking a power-of-2 modulus
6866 is faster than any other:
6868 (hsh_prime_tab) Removed;
6869 (hsh_next_prime) Ditto.
6870 (next_power_of_2) New function.
6871 (hsh_create) Use next_power_of_2.
6872 (hsh_rehash) Use & instead of %.
6874 Cleaned up hsh_sort:
6876 (internal_comparison_fn) Removed.
6877 (sort_nulls_last) New function.
6878 (hsh_sort) Removed second parameter, switched to using the new
6879 quicksort() function from quicksort.h to avoid using nasty need
6880 for static variables with qsort(). All references updated.
6882 Changed the hash functions offered, because there are better hash
6883 functions than the ones we had, and cleaned up the names to boot:
6885 * hash.c: (hashpjw_d) Removed.
6887 (hsh_hash_bytes) New function.
6888 (hsh_hash_string) New function.
6889 (hsh_hash_int) New function.
6891 Improved the hash table iteration interface:
6893 * hash.h: (hsh_iterator_init) Removed.
6894 (struct hsh_iterator) Removed `init' member, change `next' to
6897 * hash.c: (hsh_foreach) Removed. All references updated to use
6898 hsh_first/hsh_next instead.
6899 (hsh_first) New function. Notably, unlike hsh_foreach() it does
6900 not treat a null pointer as an empty hash table.
6901 (hsh_next) New function.
6903 Made deletion possible, though slow:
6905 * hash.c: (locate_matching_entry) New function.
6906 (hsh_find) Use locate_matching_entry().
6907 (hsh_delete) New function also using locate_matching_entry().
6908 (hsh_force_delete) New function.
6910 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
6912 * quicksort.c: New file implementing a sort routine with a
6913 interface better than qsort() because it passes a user-provided
6914 parameter to the sort routine.
6916 * Makefile.am: Add quicksort.c, quicksort.h.
6918 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
6920 * All source files: Get rid of nasty special cases for Checker,
6921 which is pretty obsolete now.
6923 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
6925 * Fixed a bug apparent when using the FREQUENCIES command with the
6926 html driver. The html driver was incorrectly trying to display
6929 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
6931 * Makefile.am: Reorganized. Put locale dir in version.c instead
6932 of passing it to each compile command. Only put local gmp libs in
6933 LD_ADD if not installed on system. Remove `boast' target.
6935 * All source files: struct and union typedefs eliminated.
6936 `sizeof type' replaced by `sizeof object' where practical. Moved
6937 `unused' qualifiers from start to end of declarations for gcc
6938 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
6939 assertions on pointers strictly compliant. Removed _ prefixes on
6940 some function parameter names.
6942 * alloc.c: New source file, containing these external linkage
6943 functions removed from common.c: xmalloc, xcalloc, xrealloc,
6950 * ascii.c: Migrated from arenas to pools.
6951 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
6952 c_string to len_string. All references changed.
6953 (ascii_option) Signature changed to comply to new output.c
6955 (count_fancy_chars) Removed.
6956 (delineate) Removed support for rich text.
6957 (ascii_text_metrics) Ditto.
6959 (output_shorts) Change `box', `off', `on' from c_string to
6960 len_string. Change `remaining' from int to size_t.
6961 (ascii_close_page) Make page numbering less haphazard.
6963 * autorecode.c: Migrate from arenas to pools.
6965 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
6967 * bitvector.h: New file containing these macros from misc.h:
6968 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
6970 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
6971 word[3]. ncmd removed.
6972 (var empty_string) Removed.
6973 (var cmd_table) Declaration updated.
6974 (var cmdtab) Removed.
6975 (cmp_command) Removed.
6976 (split_words) Rewritten to use strtok_r().
6977 (init_cmd_parser) Renamed cmd_init(). Rewritten.
6978 (find_command) Removed.
6979 (FILE_TYPE_okay) Rewritten.
6980 (cmd_parse) Rewritten. Semantics of the return value of command
6981 handlers has changed: they must now return one of the new CMD_*
6982 enumerals, rather than a magic value. This meant that all
6983 commands had to be modified, and they were.
6984 (figure_out_command) New function.
6986 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
6987 #defines for INIT, INPU, etc.
6989 * command.h: New CMD_* enum series.
6990 (cur_proc) Make const char *, not char *.
6991 (cmd_init) Prototype.
6994 * common.c: Removed.
6996 * common.h: Removed.
6998 * correlations.q: New file.
7000 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
7002 (custom_tables) Renamed crs_custom_tables().
7003 (custom_variables) Renamed crs_custom_variables().
7004 (calc_integer) Add in some `const' qualifiers.
7005 (table_value_missing) Change from a_string to len_string.
7006 (float_M_suffix) Change from a_string to len_string.
7008 * data-in.c: Rewritten. All references to
7009 parse_string_as_format() changed to data_in().
7011 * data-in.h: New file.
7013 * data-list.c: Change DLS_* from #define's to enums. Move from
7014 rpd_msg() to tmsg().
7015 (RPD_ERR) New #define.
7016 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
7018 (read_from_data_list_fixed) Change from old
7019 parse_string_as_format() to new data_in().
7020 (read_from_data_list_free) Ditto.
7021 (read_from_data_list_list) Ditto.
7022 (cmd_repeating_data) Modify approach to checking for end of
7025 (rpd_parse_record) Change from old parse_string_as_format() to new
7026 data_in(). Change from old convert_format_to_string() to new
7028 (read_one_set_of_repetitions) Change dfm_push_cust() to
7029 dfm_push(), pop_cust() to dfm_pop().
7031 * data-out.c: Rewritten. All references to
7032 convert_format_to_string() changed to data_out().
7034 * descript.q: Migrate to new q2c.
7035 (cmd_descriptives) Removed.
7036 (internal_cmd_descriptives) Renamed cmd_descriptives ().
7037 (custom_variables) Renamed dsc_custom_variables().
7039 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
7041 (open_file_r) Initialize h->where.line_number. Migrate to new
7043 (open_file_w) Initialize h->where.line_number.
7044 (read_record) Change from ext->ln to h->where.line_number.
7045 Migrate to struct string.
7046 (dfm_put_record) Rephrased.
7047 (dfm_push_cust) Renamed dfm_push(), rewritten.
7048 (dfm_pop) New function.
7050 * error.c: All references updated.
7051 (glob var error_count) Renamed err_err_count.
7052 (glob var warning_count) Renamed err_warning_count.
7053 (glob var error_already_flagged) Renamed err_already_flagged.
7054 (glob var verbosity) Renamed err_verbosity.
7055 (glob var cust_fn) Removed.
7056 (glob var cust_ln) Removed.
7057 (static var file_loc) New.
7058 (static var nfile_loc) New.
7059 (static var mfile_loc) New.
7060 (tmsg) New function.
7061 (push_cust) Removed.
7064 (static var terminating) Removed.
7065 (failure) Renamed err_failure().
7066 (hcf) Renamed err_hcf().
7067 (err_push_file_locator) New function.
7068 (err_pop_file_locator) New function.
7069 (err_location) New function.
7070 (check_error_count) Renamed err_check_count().
7071 (vmsg) Renamed err_vmsg(). Interface changed.
7072 (verbose_msg) Removed.
7073 (err_cond_fail) New function.
7074 (error_break) Renamed err_break().
7076 * error.h: All references updated.
7077 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
7078 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
7080 (struct file_locator) New.
7082 (macro verbose_msg) Removed.
7083 (macro cond_fail) Removed.
7085 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
7087 * expr-prs.c: Reorganized. All references updated.
7088 (exprtypename) Renamed expr_type_name().
7089 (typename) Renamed type_name().
7090 (free_expression) Renamed expr_free().
7091 (parse_expression) Renamed expr_parse(). Uses new type_check()
7093 (init_functab) Renamed init_func_tab().
7094 (type_check) New function.
7095 (parse_or) Rewritten to use new allocate_nonterminal() and
7096 append_nonterminal_arg() functions.
7099 (parse_rel) Ditto. Also simplified logic.
7104 (SYSMIS_func) Ditto.
7105 (VALUE_func) Rephrased.
7106 (CONCAT_func) Fix memory leak by replacing free by free_node on
7108 (generic_str_func) Ditto.
7109 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
7111 (allocate_nonterminal) New function.
7112 (append_nonterminal_arg) New function.
7113 (static func_tab[]) Now at file level.
7115 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
7117 * expr.h: (enum series OP_*) Moved to exprP.h.
7118 (OP_* defines) Ditto.
7119 (struct op_desc) Ditto.
7120 (global ops[]) Ditto.
7121 (struct num_con_node) Ditto.
7122 (struct str_con_node) Ditto.
7123 (struct var_node) Ditto.
7124 (struct lag_node) Ditto.
7125 (struct casenum_node) Ditto.
7126 (struct nonterm_node) Ditto.
7127 (union any_node) Members renamed.
7128 (struct sys_node) Removed.
7129 (struct val_node) Removed.
7130 (operator typedef) Removed.
7131 (typedef exprtype) Removed.
7132 (enum series EX_*) Moved to exprP.h.
7133 (struct expression) Ditto. Also renamed a lot of the members.
7134 (PXP_* defines) Changed to enums.
7135 (free_node prototype) Moved to exprP.h.
7137 * file-handle.h: (struct file_handle) New member `where'.
7139 * file-handle.q: Migrated to new q2c format.
7140 (prepend_current_directory) Removed (dead code).
7141 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
7142 (fh_get_handle_by_filename) Removed dead code.
7143 Set new `where' member.
7145 * file-type.c: (file_type_source_read) References to
7146 parse_string_as_format() changed to data_in().
7147 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
7149 * filename.c: All references updated.
7150 (init_filename) Renamed fn_init().
7151 (expand_line) Removed.
7152 (macro EXPAND_LINE) Removed.
7153 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
7154 of custom functions.
7155 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
7156 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
7157 (normalize_filename) Renamed fn_normalize().
7158 (search_path) Renamed fn_search_path(), rewritten.
7159 (prepend_dir) Renamed fn_prepend_dir().
7160 (blp_getenv) Renamed fn_getenv().
7161 (blp_dirname) Renamed fn_dirname().
7162 (fn_basename) New function, not used.
7163 (absolute_filename_p) Renamed fn_absolute_p().
7164 (is_special_filename) Renamed fn_special_p().
7165 (file_exists) Renamed fn_exists_p().
7166 (readlink_malloc) Renamed fn_readlink().
7167 (getenv_default) Renamed fn_getenv_default().
7168 (open_file) Renamed fn_open().
7169 (close_file) Renamed fn_close().
7170 (open_file_ext) Renamed fn_open_ext().
7171 (close_file_ext) Renamed fn_close_ext().
7173 * font.h: Migrate from arenas to pools.
7175 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
7177 * frequencies.g: Migrate from arenas to pools.
7179 * frequencies.q: Migrate to new q2c version. Migrate from arenas
7182 * getline.c: All references updated.
7183 (global getl_buf) Changed from char * to struct string.
7184 (static getl_include_path) Ditto.
7185 (global getl_buf_len) Removed.
7186 (global getl_buf_size) Removed.
7187 (getl_include_path) Deal with new getl_buf, getl_include_path.
7188 (getl_uninitialize) New function.
7189 (getl_get_current_directory) Rewritten.
7190 (getl_clear_include_path) Rewritten.
7191 (getl_add_include_dir) Rewritten.
7192 (getl_add_file) Assertion fixed.
7193 (getl_add_virtual_file) Change initial value of `remaining_loops'
7195 (welcome) Rewritten.
7196 (handle_line_buffer) Make static. Change logic to make
7197 getl_add_virtual_file() change sensible. Use ds_*() strings.
7198 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
7199 (getl_close_file) Moved.
7200 (getl_location) New function.
7202 * getline.h: All references updated.
7203 (macro curln) Removed.
7204 (macro curfn) Removed.
7205 (macro am_interactive) Renamed getl_am_interactive.
7206 (macro am_reading_script) Renamed getl_reading_script.
7208 * glob.c: (global fmt_parse_ignore_error) Removed.
7209 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
7210 systems that support it (C99). Turn off SET ECHO by default. No
7211 necessary julcal initialization anymore.
7213 * groff-font.c: Migrate from arenas to pools.
7214 (groff_read_font) Use err_push_file_locator().
7215 (groff_read_DESC) Ditto.
7216 (font_msg) Use tmsg().
7218 * hash.c: (hsh_sort) Fix debug code.
7219 [GLOBAL_DEBUGGING] Include stdio.h.
7221 * hash.h: (macro force_hsh_insert) Rephrase.
7223 * heap.c: Rewritten.
7225 * heap.h: Rewritten.
7227 * html.c: (html_option) Change from outp_value to struct string.
7228 (postopen) Change from curfn to getl_location().
7229 (escape_string) Remove rich-text code. Signature changed.
7230 (output_tab_table) Switch from a_string to struct len_string.
7231 Remove rich text support.
7233 * lexer.c: All references updated. Largely rewritten. Major
7234 changes listed below. Removed tagged quote support. Adapted to
7235 struct string tokstr.
7236 (global tokstr) Changed to struct string.
7237 (global tokstr_size) Removed.
7238 (global tokstr_len) Removed.
7240 (global tokint) Removed.
7241 (global toklongstr) Removed.
7242 (C* defines) Removed.
7243 (static tbl[]) Removed.
7244 (static id[]) Removed.
7245 (static une[]) Removed.
7246 (discard_line) Renamed lex_discard_line().
7247 (get_entire_line) Renamed lex_entire_line().
7248 (get_rest_of_line) Renamed lex_rest_of_line().
7249 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
7250 (make_hexit) Removed.
7251 (syntax_error) Renamed lex_error(). Return value removed.
7252 (get_token_representation) Renamed lex_token_representation().
7253 (putback) Renamed lex_put_back().
7254 (putfwd) Renamed lex_put_forward().
7255 (convert_negative_to_dash) Renamed lex_negative_to_dash().
7256 (set_prog) Renamed lex_set_prog().
7257 (init_lex) Renamed lex_init().
7258 (reset_eof) Renamed lex_reset_eof().
7259 (lookahead) Renamed lex_look_ahead().
7260 (check_id) Rewritten.
7261 (yylex) Renamed lex_get(), rewritten.
7262 (lex_end_of_command) New function. Many commands were rephrased
7264 (lex_integer_p) New function. Replaces compare of tokint against
7266 (lex_integer) New function. Replaces tokint.
7267 (match_tok) Renamed lex_match().
7268 (match_id) Renamed lex_match_id().
7269 (match_int) Renamed lex_match_int().
7270 (force_match_id) Renamed lex_force_match_id(), added return value.
7271 (force_match) Renamed lex_force_match(), added return value.
7272 (force_string) Renamed lex_force_string(), added return value.
7273 (force_int) Renamed lex_force_int(), added return value.
7274 (lex_id_match_len) New function.
7275 (id_match) Renamed lex_id_match(), rewritten.
7276 (get_line) Renamed lex_get_line().
7277 (preprocess_line) Renamed lex_preprocess_line().
7278 (tokname) Renamed lex_token_name().
7279 (bin_value_func) Removed.
7280 (oct_value_func) Removed.
7281 (hex_value_func) Removed.
7282 (unexpected_eof) New function.
7283 (convert_numeric_string_to_char_string) New function.
7284 (parse_string) Rewritten, signature changed.
7285 (add_tokstr_char) Removed.
7286 (add_tokstr_unsigned) Removed.
7287 (add_tokstr_string) Removed.
7288 (parse_tagged_quote) Removed.
7289 (skip_comment) Renamed lex_skip_comment().
7291 * lexer.h: All references updated.
7292 (macro is_id1) Renamed CHAR_IS_ID1.
7293 (macro is_idn) Renamed CHAR_IS_IDN.
7294 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
7295 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
7296 (macro get_token) Removed.
7297 (macro id_match) Removed.
7298 (macro force_match_id) Removed.
7299 (macro force_match) Removed.
7300 (macro force_string) Removed.
7301 (macro force_int) Removed.
7302 (macro force_num) Removed.
7303 (macro force_id) Removed.
7305 * lexerP.h: Removed.
7307 * list.q: Migrated to new q2c format.
7308 (write_line) Deal with struct len_string.
7309 (write_varname) Ditto.
7310 (write_fallback_headers) Ditto.
7312 * magic.c: New file, incorporating the following global variables
7313 previously in other files: endian, second_lowest_value. And both
7314 of those are conditional on #define's.
7316 * magic.h: New file, incorporating the following global variable
7317 declarations: endian, second_lowest_value, and the following macro
7318 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
7320 * main.c: Added declarations of pgmname, finished, curdate,
7322 (main) Call new parse_script() function.
7323 (parse_script) New function.
7324 (execute_command) New function.
7325 (dump_token) Removed.
7326 (handle_error) New function.
7328 * matrix.c: New file.
7330 * matrix.h: New file.
7332 * matrix-data.c: Migrated from arenas to pools.
7333 (mget_token) Change from parse_string_as_format() to data_in().
7335 * means.q: Migrate to new q2c.
7336 (custom_tables) Renamed mns_custom_tables().
7337 (custom_crossbreak) Renamed mns_custom_crossbreak().
7338 (custom_variables) Renamed mns_custom_variables().
7340 * mis-val.c: (static var width) Changed from `int' to `size_t'.
7341 (parse_varnames) Prototype.
7342 (parse_numeric) Rephrasings.
7343 (parse_alpha) Adapt to new struct string tokstr.
7345 * misc.c: (intlog10) Rewritten.
7347 (ansi_rand) Renamed real_rand(), moved into random.c.
7348 (ansi_srand) Renamed real_srand(), moved into random.c.
7349 (setup_randomize) Moved to random.c.
7350 (rand_uniform) Ditto.
7351 (rand_normal) Ditto.
7352 (rand_simple) Ditto.
7353 (get_config_line) Removed.
7354 (reverse) Removed (dead code).
7356 * misc.h: (macro SET_BIT) Moved to bitvector.h.
7357 (macro CLEAR_BIT) Ditto.
7358 (macro TEST_BIT) Ditto.
7359 (macro SET_BIT_TO) Ditto.
7360 (macro BIT_INDEX) Ditto.
7362 * output.c: (outp_read_devices) Move to err_push_file_locator()
7363 from push_cust(). Use struct string.
7364 (expand_op_tokstr) Removed.
7365 (static var op_tokstr) Changed to struct string.
7366 (static var op_tokstr_size) Removed.
7367 (tokener) Rephrasings. Use struct string.
7368 (parse_options) Use struct string.
7369 (destroy_driver) Fix assertion.
7370 (outp_get_paper_size) Move to err_push_file_locator().
7371 [0] Removed dead code.
7372 (outp_string_width) Move to len_string.
7374 * output.h: Comment fixes.
7375 (TAG_* enum series) Removed.
7376 (struct outp_value) Removed.
7377 (enum OUTP_T_FANCY) Removed.
7378 (struct outp_text) `s' changed from a_string to len_string.
7379 (struct outp_class) `option' change arg 3 from outp_value to
7382 * pfm-read.c: (corrupt_msg) Rewritten.
7384 * pfm-write.c: (bufwrite) Fix assertion.
7386 * pool.c: New file, reference version.
7388 * pool.h: New file, reference version.
7390 * postscript.c: (ps_font_sizes) Fix assertion.
7391 (ps_option) Change arg 3 from outp_value to struct string.
7392 Adapt to struct string.
7393 (macro output_line) Removed.
7394 (macro add_string) Removed.
7395 (output_encodings) Adapted to struct string. Moved to
7396 err_push_file_locator().
7397 (find_encoding_file) Fix assertion.
7398 (read_ps_encodings) Move to err_push_file_locator().
7399 (postopen) Use getl_location() instead of curfn.
7400 (out_text_plain) Move to len_string.
7401 (text) Ditto. Remove rich text support.
7403 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
7404 (cmd_print_eject) Ditto.
7406 (internal_cmd_print) Now cleans up after itself. Uses
7407 fh_parse_file_handle() now.
7408 (cmd_print_space) Use PXP_NUMERIC to type-check.
7410 * q2c.c: Overhauled. Removed _("") i18n support. All references
7411 updated. All output functions updated to handle structures rather
7412 than local or static variables. Adapt to new PSPP lex_*()
7416 (macro MAX_N_SBC) Removed.
7417 (global bare) Removed.
7418 (enum STRING) Renamed T_STRING.
7419 (enum ID) Renamed T_ID.
7420 (get_buffer) Buffer size increased.
7421 (strlower) Renamed st_lower(), rephrased.
7422 (strupper) Renamed st_upper(), rephrased.
7423 (skip_ws) New function.
7424 (get_line) Don't special-case any types of lines (like those
7425 beginning with ! or $, for instance).
7426 (get_token) Renamed lex_get(). Rephrased.
7427 (static var `prefix') New.
7428 (parse) New function.
7429 (parse_setting) Minor rephrasing.
7430 (dump_specifier_vars) Ditto.
7431 (make_identifier) Put null terminator on identifier, duh.
7432 (dump_vars) Renamed dump_declarations(). Never indent. Never
7433 static. Output changed entirely.
7434 (dump_specifier_init) Rephrase.
7435 (dump_vars_init) No index variable needed. Other modifications.
7436 (dump_parser) Don't parse command name. Do dump functions instead
7437 of just code fragments.
7438 (dump_free) Dump function instead of code fragment.
7439 (recognize_directive) New function.
7440 (main) Use recognize_directive(). Don't rely on magic $ line
7441 beginning: instead, parse comments. Update list of headers.
7443 * random.c: New file, containing the following functions:
7444 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
7445 rand_normal, rand_simple.
7447 * random.h: New file.
7449 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
7450 function. `max_src_width', `max_dst_width' changed to size_t.
7451 (internal_cmd_recode) Removed.
7452 (parse_dest_spec) Merge similar cases.
7453 (parse_src_spec) Add assertion.
7455 * repeat.c: (recognize_keyword) New function.
7456 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
7457 REPEAT. Improve recognition of END REPEAT (use
7458 recognize_keyword()). Move from curfn to getl_location(). Use
7461 (perform_DO_REPEAT_substitutions) Adapt to struct string.
7463 * set.q: Adapt to new q2c.
7464 (cmd_set) Range-check some values better.
7465 (custom_blanks) Renamed stc_custom_blanks().
7466 (custom_length) Renamed stc_custom_length().
7467 (custom_results) Renamed stc_custom_results().
7468 (custom_seed) Renamed stc_custom_seed().
7469 (custom_width) Renamed stc_custom_width().
7470 (custom_format) Renamed stc_custom_format().
7471 (custom_journal) Renamed stc_custom_journal().
7472 (custom_color) Renamed stc_custom_color().
7473 (custom_listing) Renamed stc_custom_listing().
7474 (custom_disk) Renamed stc_custom_disk().
7475 (custom_log) Renamed stc_custom_log().
7476 (custom_rcolor) Renamed stc_custom_rcolor().
7477 (custom_viewlength) Renamed stc_custom_viewlength().
7478 (custom_workdev) Renamed stc_custom_workdev().
7480 * settings.h: Not necessary to include format.h any longer.
7482 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
7483 (corrupt_msg) Rewritten.
7485 * sort.c: Adapt to rewritten heap ADT.
7487 * str.c: (aa_strcpy) Removed.
7488 (ab_strcpy) Removed.
7489 (ac_strcpy) Removed.
7490 (ba_strcpy) Removed.
7491 (bb_strcpy) Removed.
7492 (ca_strcpy) Removed.
7493 (aa_strdup) Removed.
7494 (aa_strdupcpy) Removed.
7495 (ba_strdup) Removed.
7496 (sa_strdup) Removed.
7497 (memrev) Renamed mm_reverse().
7498 (memrmem) Renamed mm_find_reverse().
7499 (cmp_str) Renamed st_compare_pad().
7500 (strmaxcpy) Removed.
7501 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
7502 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
7504 (strpadcpy) Renamed st_pad_copy(), signature changed.
7505 (blpstrset) Removed.
7506 (ds_create) New function.
7507 (ds_init) New function.
7508 (ds_replace) New function.
7509 (ds_destroy) New function.
7510 (ds_clear) New function.
7511 (ds_extend) New function.
7512 (ds_shrink) New function.
7513 (ds_truncate) New function.
7514 (ds_length) New function.
7515 (ds_size) New function.
7516 (ds_value) New function.
7517 (ds_end) New function.
7518 (ds_concat) New function.
7519 (ds_concat_buffer) New function.
7520 (ds_printf) New function.
7521 (ds_putchar) New function.
7522 (ds_getline) New function.
7523 (ds_get_config_line) New function derived from the old
7524 misc.c:get_config_line().
7525 (ls_create) New function.
7526 (ls_create_buffer) New function.
7527 (ls_init) New function.
7528 (ls_shallow_copy) New function.
7529 (ls_destroy) New function.
7530 (ls_null) New function.
7531 (ls_null_p) New function.
7532 (ls_empty_p) New function.
7533 (ls_length) New function.
7534 (ls_value) New function.
7535 (ls_end) New function.
7537 * str.h: Reformatted.
7538 (struct a_string) Removed.
7539 (struct b_string) Removed.
7540 (struct c_string) Removed.
7541 (struct len_string) New.
7542 (struct string) New.
7543 (macro as_streq) Removed.
7544 (macro bs_streq) Removed.
7545 (macro cs_streq) Removed.
7546 (macro sa_streq) Removed.
7547 (macro sb_streq) Removed.
7548 [__GNUC__] (inline function ds_putchar) New function.
7549 [__GNUC__] (inline function ds_length) New function.
7550 [__GNUC__] (inline function ds_value) New function.
7551 [__GNUC__] (inline function ds_end) New function.
7553 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
7554 (display_vectors) Fix missing i18n.
7556 * t-test.q: Migrate to new q2c.
7558 * tab.c: Migrate from arenas to pools.
7559 (tab_create) Use struct len_string.
7560 (tab_realloc) Ditto.
7561 (text_format) Ditto.
7562 (tab_joint_text) Ditto.
7563 (tab_natural_width) Remove rich text support.
7564 (tab_natural_height) Ditto.
7565 (tab_output_text) Handle TAT_FIX.
7566 (tab_raw) Change arg from a_string to len_string.
7567 (tabi_driver) Fix assertion. Use struct len_string.
7568 (render_strip) Use struct len_string. Remove rich text support.
7569 Add `const' qualifiers.
7571 * tab.h: (enum TAB_RICH) Remove.
7572 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
7573 SOM_COL_* updated to read TAB_COL_*.
7574 (struct tab_table) Change arena to pool. Change a_string to
7577 * temporary.c: (restore_dictionary) Rewrite Checker code.
7579 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
7580 LOWEST, HIGHEST) Moved here from common.h.
7581 (typedef any_trns) Removed. All references changed to `struct
7584 * vars-atr.c: (force_create_variable) Fix assertion.
7585 (force_dup_variable) Fix assertion.
7587 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
7589 Using alphanumeric variables in functions under AGGREGATE
7590 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
7591 <BZN-mdksh@t-online.de> for reporting this bug.
7593 * aggregate.c: (parse_aggregate_functions) When setting the
7594 FSTRING bit, also allocate memory for the `string' member of
7596 (free_aggregate_functions) Free iter->string. Don't use the
7597 non-function bits when indexing the array of functions.
7598 [DEBUGGING] (debug_print) Don't use the non-function bits when
7599 indexing the array of functions.
7601 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
7603 Under certain circumstances, the final case would be omitted from
7604 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
7605 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7607 * aggregate.c (agr_00x_end_func): Increment number of cases in
7608 sink before writing case. For streams that keep track of how many
7609 cases there are based on this value, this means that the last case
7610 will be read in on the next stream read.
7612 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
7614 Undefined behavior was invoked by referencing a freed pointer.
7616 * vfm.c (memory_stream_write): Free pointer *after* checking for
7619 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
7621 A wrong record size was displayed when paging the active file to
7624 * vfm.c: (memory_stream_write) Fix off-by-one error.
7626 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
7628 Not having enough temporary space for sorting caused a core dump.
7631 * sort.c: (allocate_cases) Initialize i.
7633 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
7635 Syntax errors in function descriptions on AGGREGATE caused core
7638 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
7639 free_aggregate_functions(), since that function already frees
7642 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
7644 A null pointer was dereferenced, causing a core dump, when
7645 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
7646 but PSPP still doesn't calculate percentiles. Thanks to Regnor
7647 Jernsletten <rjernsle@eunet.no> for reporting this problem.
7649 * arena.c: (arena_malloc) If the arena hasn't been initialized
7650 already, initialize it.
7652 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
7654 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
7655 for compilation with Cygnus Windows B20. Not used by other
7658 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
7660 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
7661 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7663 * sort.c: (compare_case_lists) Reverse sense of comparison if
7664 sorting in descending order.
7665 (compare_record) Ditto.
7667 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
7669 SPLIT FILE with a string variable caused a core dump. Fixed.
7671 * vfm.c: If the variable is a string then make a temporary value
7672 struct pointing to it. The underlying problem is a lot bigger
7673 than this (see TODO) but this is a stopgap for the simple case at
7676 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
7678 Nested INCLUDEs didn't work. Fixed.
7680 * getline.c: (getl_include) Set first_line to NULL in allocated
7683 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
7685 The MATCH FILES procedure set the values of variables not present
7686 to 0. It should have been SYSMIS. This is now fixed.
7688 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
7690 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
7692 The REMARK command was too aggressive about skipping lines. It
7693 didn't like being the last command in a file.
7695 * command.c: (cmd_remark) Call get_entire_line() instead of
7698 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
7700 Comment parsing wasn't consistent with the rest of the code in its
7701 idea of where one command ends and another starts. This meant
7702 that sometimes commands would be mysteriously ignored. Thanks to
7703 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7705 * command.c: (parse_cmd) Hand off comment parsing to new function
7706 skip_comment() in lexer.c.
7707 * lexer.c: (skip_comment) New function.
7709 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
7711 The TABLE subcommand on MATCH FILES worked only erratically at
7712 best. This fixes it. Thanks to Dr. Dirk Melcher
7713 <BZN-mdksh@t-online.de> for reporting this bug.
7715 * get.c: (mtf_compare_BY_values) When comparing string values, a
7716 difference of 1 is still a difference :-)
7717 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
7718 advance TABLE files automatically when matched. Comment fixes.
7720 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
7722 VARIABLE LABELS rejected a slash before the first variable
7723 specification, contradicting the documentation. Thanks to Walter
7724 M. Gray <graywm@northernc.on.ca> for reporting this bug.
7726 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
7727 command specification.
7729 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
7731 Because of an incorrect optimization in memory allocation,
7732 CROSSTABS sometimes segfaulted when asked to output multiple
7733 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
7736 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
7737 are passed to output_pivot_table() for its use.
7738 (output_pivot_table) Instead of assuming the number of columns is
7739 constant, keep track with maxcols. In general mode, use maxcells
7740 to determine whether more matrix cells need to be allocated.
7742 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
7744 CROSSTABS didn't display value labels for column and row
7745 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
7748 * crosstabs.q: (table_value_missing) If the specified value has a
7749 value label for this variable, then show it instead of the raw
7751 (display_dimensions) Delegate display of value_labels to
7752 table_value_missing.
7754 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
7756 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
7757 <BZN-mdksh@t-online.de> for reporting this bug.
7759 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
7760 if the file isn't declared as binary.
7762 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
7764 MATCH FILES corrupted memory and dumped core on some syntax
7767 * get.c: (cmd_match_files) Set file->handle to NULL before
7769 (mtf_free_file) Don't free a null dictionary.
7771 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
7773 MATCH FILES should set numeric values not available to the
7774 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
7775 <BZN-mdksh@t-online.de> for reporting this bug.
7777 * get.c: (mtf_processing) Set unused records to system-missing,
7780 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
7782 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
7783 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
7785 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
7786 in newly created dictionary, and add each copied variable to the
7789 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
7793 * get.c: (trim_dictionary) Free variable list for KEEP after
7796 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
7798 Some systems didn't like the way open_file was coded. Thanks to
7799 Hankin <hankin@rogue.consultco.com> for pointing this out.
7801 * filename.c: (open_file) Don't try to store stdin, stdout,
7802 stderr as part of an array, because that doesn't always work.
7804 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
7806 The SAVE procedure didn't save long string variables properly.
7807 Fixed by this patch. Thanks to Hankin
7808 <hankin@rogue.consultco.com> for this patch.
7810 * sfm-write.c: (write_variable) Fix off-by-one error in writing
7811 out variable pad records.
7813 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
7815 Previously, if PRINT SPACE were given a negative argument, it
7816 would report an error, then spin in an (almost) infinite loop.
7817 This fixes that behavior.
7819 * print.c: (print_space_trns_proc) After reporting a negative
7820 argument, set number of lines to print to 1.
7822 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
7824 SPSS 8.0 outputs some new record types in its system files, and it
7825 allows longer value labels. Accept these system files.
7827 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
7828 11 emitted by SPSS 8.0.
7830 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
7832 The LIST procedure was too conservative in allocating space for
7833 buffers, which caused a bug that only showed up with very long
7834 output variables. Thanks to Hankin <hankin@dunno.com> for this
7837 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
7839 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
7841 Typo meant string format specifiers weren't checked properly. I
7842 think that Hankin <hankin@dunno.com> sent me this report, but I'm
7843 willing to be corrected on this point.
7845 * format.c: (check_string_specifier) Fix obvious typo.
7847 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
7849 Using $CASENUM in an expression didn't work. Here's a fix.
7850 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
7853 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
7855 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
7857 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
7859 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
7860 other behavior, *sigh*. This patch hopefully fixes that. This
7861 time I've actually tested it.
7863 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
7865 * data-list.c: (read_from_data_list_free,
7866 read_from_data_list_list) Call parse_string_as_format() directly
7867 without mucking around with the field width.
7869 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
7871 Occasionally, you may encounter a script that wants to be
7872 interpreted in interactive mode. Make -i emulate this behavior to
7873 allow such scripts to be executed with PSPP.
7875 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
7877 * cmdline.c: (pre_syntax_message[]) Update -i description.
7879 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
7880 when -i is given on the command line) don't treat unindented lines
7881 as starting a new command.
7883 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
7885 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
7886 mostly caused by local initialized aggregates. After egcs is
7887 fixed upstream these can be removed, but for now they're not a big
7890 * ascii.c: (ascii_postopen_driver) Checker chokes on local
7891 initialized arrays. Avoid this.
7893 * sfm-write.c: (sfm_write_dictionary) Don't use a local
7896 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
7898 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
7899 following changes avoid. Currently I compile sources with egcs
7900 1.1.1 and gcc 2.7.2.3 before sending them out.
7902 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
7904 * ascii.c: (option_tab[]) Initialize all struct members.
7906 * avl.h: (avl_traverser_init) New macro.
7908 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
7911 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
7914 * hash.c: Comment fix.
7916 * hash.h: (hsh_iterator_init) New macro.
7918 * html.c: (option_tab[]) Initialize all struct members.
7920 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
7923 * postscript.c: (option_tab[]) Initialize all struct members.
7924 (output_encodings, preclose, dump_lines) Use new
7925 hsh_iterator_init() macro.
7927 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
7930 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
7933 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
7935 * data-in.c: Examined each of the parsing functions to make sure
7936 that they wouldn't dump core if they were passed a string of the
7937 wrong length, since now the DATA LIST FREE/LIST routines don't
7938 check for field width before passing it to the data parser.
7939 (parse_RBHEX, parse_AHEX) Reject odd length input.
7940 (parse_string_as_format) Reject input that's too short or too
7943 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
7944 a field to its entire declared output width then pass it to the
7945 data-in parsing routines. This contradicted the documented
7946 behavior. This is fixed in these changes. Thanks to Mark H. Wood
7947 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
7948 free-format parsing that differed from SPSS.
7949 (cut_field) Commas and spaces are treated identically. Returns
7950 the proper column instead of a fixed 1 value.
7951 (parse_field) Removed.
7952 (read_from_data_list_free, read_from_data_list_list) Call
7953 parse_string_as_format directly instead of parse_field.
7955 * heap.c: (heap_delete) Stylistic fixes.
7957 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
7959 * loop.c: (loop_2_trns_proc) Formatting fix.
7961 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
7963 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
7965 * vfm.c: (macro FILTERED) New.
7966 (static var filter_var) New.
7967 (process_active_file_write_case) Use FILTERED.
7968 (setup_filter) Set filter_var.
7969 (close_active_file) Delete the filter if not
7970 FILTER_before_TEMPORARY.
7971 (procedure_write_case) Use FILTERED.
7973 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
7975 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
7977 * data-in.c: (parse_day_count) Message fix.
7978 (parse_month) Style fix.
7980 * data-list.c: (struct data_list_pgm) New member eof.
7981 (cmd_data_list) Init eof to 0.
7982 (do_reading) Implement the /END subcommand and read-past-eof
7985 * do-if.c: Include stdio.h when debugging.
7986 (cmd_else_if) Make sure the command is .-terminated.
7988 * glob.c: (init_glob) Capitalize the command prompt.
7990 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
7991 (end_file_trns_proc) Debugging message.
7993 * loop.c: (internal_cmd_loop) Make it work when there's no loop
7995 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
7997 * main.c: (dump_token) Make kwtab[] const.
7999 * set.q: Spelling, comment fixes.
8001 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
8004 * vars-prs.c: (fill_all_vars) Style fix.
8006 * vfm.c: (index_to_varname) Return const.
8008 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
8010 * Changes in many source files for partial -ansi -pedantic and
8011 no-debugging compliance: Remove trailing common in enum
8012 declarations; add `unused' attributes; insert some appropriate
8015 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
8017 * command.c: (shell) Make static.
8018 (run_command) Make static.
8020 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
8022 * dfm.c: (cmd_begin_data) I18n fix.
8024 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
8026 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
8028 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
8031 * file-handle.q: Don't prepend the source file directory name to
8032 the data file name. (Ongoing issue.)
8033 (prepend_current_directory) Comment out.
8034 (internal_cmd_file_handle) Don't call prepend_current_directory().
8035 (fh_get_handle_by_filename) Ditto.
8037 * filename.c: Append zero byte to readlink() return value.
8039 * getline.c: (getl_read_line) I18n fix.
8041 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
8043 * misc.h: Don't use gcc features if __STRICT_ANSI__.
8045 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
8048 * postscript.c: (output_encodings) Don't use local_strdup().
8051 * print.c: Don't use gcc features if __STRICT_ANSI__.
8053 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
8055 * recode.c: (parse_src_spec) Fully brace nested if's.
8057 * set.q: (global var set_testing_mode) New var.
8059 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
8061 * ascii.c: Add some more `unused' attributes that only come into
8062 play when NDEBUG is defined.
8063 (ascii_close_page) Set s_len when reallocating s.
8065 * crosstabs.q: (delete_missing) New function.
8066 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
8067 (make_summary_table) Create summary table reallocable.
8069 * postscript.c: Add more `unused' attributes as above.
8071 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
8072 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
8074 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
8077 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
8078 gratuitous space between parameter definition.
8080 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
8081 complaints about running off the end of functions with NDEBUG
8084 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
8086 * Several source files: Removed some PORTME notes when reflection
8087 revealed that ANSI forbids that sort of breakage. Also, added
8088 lots of `unused' qualifiers here and there.
8090 * aggregate.c: (accumulate_aggregate_info) Remove local var
8091 weighting that turned out not to be used.
8093 * avl.c: Update to version 1.1.0. Add unused specifier.
8094 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
8096 (avl_probe) Replace some instances of 1 with +1 where appropriate.
8097 (avl_find) Cast return value to void *.
8098 (avl_delete) q doesn't need to be initialized at the beginning of
8099 the function. Replace some instances of 1 with +1.
8100 (force_avl_delete) Renamed avl_force_delete, all references changed.
8101 (compare_ints) `param' marked unused.
8102 (print_int) `param' marked unused.
8103 (recurse_tree) Replace some instances of 1 with +1.
8105 * avl.h: Update to version 1.1.0. Only declares avl function
8106 types if not already declared.
8107 (AVL_MAX_HEIGHT) Only define if not already defined.
8108 (struct avl_node) New unused member char pad[2].
8109 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
8110 (force_avl_insert) Renamed avl_force_insert.
8111 (force_avl_delete) Renamed avl_force_delete.
8113 * crosstabs.q: (struct table_entry) Put `freq' into a union with
8115 (struct crosstab) Add new member `ofs'.
8116 (glob var int_tab) Removed.
8117 (custom_tables) In integer mode, assign v[i] properly through the
8119 (custom_variables) Now p.crs.max == max + 1.
8120 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
8121 (precalc) Implement integer mode.
8122 (calc_integer) Implement integer mode.
8123 (compare_table_entry) Remove unused local variable `comparing'.
8124 (make_summary_table) Implement integer mode.
8125 (macro ns_rows) Implemented as static variable now.
8126 (several variables) Made static, from global.
8127 (output_pivot_table) Use table_value_missing() for column heads.
8128 Remove several unused local variables. Implement integer mode
8129 table summing. Count up ns_rows.
8130 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
8131 (find_pivot_extent) Moved into find_pivot_extent_general; now just
8132 calls that function or find_pivot_extent_integer.
8133 (find_pivot_extent_integer) New function.
8134 (enum_var_values) Implemented for integer mode.
8135 (table_value_missing) New function.
8136 (display_dimensions) Call table_value_missing() for heads.
8137 (float_M_suffix) New function.
8138 (display_crosstabulation) Call table_value_missing() for row
8139 heads. Handle missing values in /MISSING=REPORT mode.
8140 (calc_fisher) Remove unused var N.
8141 (calc_r) Remove unused var fact.
8143 * data-list.c: (dump_fixed_table) Fix table dimensioning.
8144 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
8146 * data-out.c: (insert_commas) Remove unused var cp.
8147 (convert_CCx) Remove unused vars save_set_decimal,
8150 * descript.q: (dump_z_table) Fix table dimensioning.
8151 (pre_calc) Remove unused var j.
8152 (display) Remove unused vars title, s. Fix table dimensioning.
8154 * expr-evl.c: Comment fixes.
8156 * frequencies.q: (full_dim) New function.
8157 (dump_full) Fix table dimensioning.
8158 (condensed_dim) New function.
8159 (dump_condensed) Fix table dimensioning.
8161 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
8164 * html.c: (html_close_drive) Remove unused var i.
8165 (postopen) Remove unused vars title, curfn_len, cp.
8166 (preclose) Remove unused vars this, x.
8168 * lexer.c: Comment fixes.
8170 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
8172 * means.q: (custom_tables) Remove unused var m_dim.
8174 * mis-val.c: Format fix.
8176 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
8178 * output.c: (outp_get_paper_size) Remove unused var cp.
8180 * pfm-read.c: (read_float) Remove unused var save, unused label
8182 (read_variables) Remove unused vars cp, j.
8183 (read_value_label) Remove unused var j.
8185 * pfm-write.c: (bufwrite) Remove unused var i.
8187 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
8189 (output_encodings) Remove unused vars char_cp, n_output.
8190 (read_ps_encodings) Remove unused var ep.
8191 (postopen) Remove unused var title.
8192 (preclose) Remove unused var fp.
8193 (ps_open_page) Remove unused vars true, false, orientation,
8194 mirror_horz, mirror_vert, width, length.
8195 (ps_text_metrics) Remove unused var x.
8197 * q2c.c: (find_symbol) Remove unused var y.
8198 (parse_setting) Remove unused parameter sbc, all references
8200 (dump_parser) Remove unused var cp.
8201 (dump_free) Remove unused var i.
8203 * set.q: (static vars args, n) Removed.
8204 (internal_cmd_gset) Removed.
8206 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
8207 (read_machine_flt64_info) Removed unused var file_endian.
8208 (read_documents) Removed unused var i.
8209 (read_compressed_data) Removed unused parameter dict, all
8212 * sfm-write.c: (bufwrite) Removed unused var i.
8213 (sfm_write_case) Removed unused var i.
8215 * sort.c: (merge_once) Remove unused var t.
8216 (write_separate) #if 0 out as dead code.
8218 * split-file.c: (cmd_split_file) Remove unused var i.
8220 * sysfile-info.c: (sysfile_info_dim) New function.
8221 (cmd_sysfile_info) Fix table dimensioning.
8222 (variables_dim) New function.
8223 (display_variables) Fix table dimensioning.
8224 (describe_variable) Remove unused var prev_r.
8226 * t-test.q: (z_postcalc) Removed.
8227 (pairs_calc) Remove unused var bad_weight.
8228 (postcalc) Remove unused vars dfn, dfd.
8230 * tab.c: (tab_create) Set t->dim to NULL.
8231 (tab_dim) Make sure t->dim is NULL first.
8232 (tab_natural_width) Remove parameter `clamp'.
8233 (tab_value) Remove duplicate assertion for table.
8234 (tab_raw) New function.
8235 (nowrap_dim) New function.
8236 (wrap_dim) New function.
8237 (tab_output_text) Fix table dimensioning.
8239 * tab.h: (tab_raw) New macro.
8241 * val-labs.c: (get_label) Remove unused var type.
8242 (copy_value_labels) Remove unused var trav.
8244 * var.h: (struct crosstab_proc) Completely changed.
8246 * vars-prs.c: (parse_dict_variable) Remove unused var v.
8248 * vfm.c: (open_active_file) Remove unused vars i, lp.
8250 * weight.c: (weight_trns_proc) #if 0 out as dead code.
8252 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
8254 * Makefile.am: Add apply-dict.c, flip.c.
8256 * apply-dict.c: New file.
8258 * command.c: (struct command) Make cmd[] larger for CLEAR
8259 TRANSFORMATIONS command name.
8260 (parse_cmd) Make sure we're in a valid state before using it as an
8261 index. Discard variables and reset state on invalid transitions.
8262 (cmd_clear_transformations) New function.
8264 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
8265 Add unimplemented PRESERVE, RESTORE.
8267 * file-handle.h: Include stddef.h.
8271 * pfm-read.c: (parse_value) Pad value label values with spaces,
8274 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
8275 (sfm_close) Decrement reference count, make sure it's zero.
8276 (sfm_maybe_close) New function.
8277 (sfm_read_dictionary) Handle reference counts.
8279 * vars-atr.c: (clear_default_dict) New function.
8280 (discard_variables) Use clear_default_dict().
8282 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
8284 * Makefile.am: Add pfm-write.c.
8285 (LDADD) Add the libgmp2 libraries.
8287 * command.def: Define EXPORT.
8289 * get.c: (cmd_export) New function.
8290 (export_write_case_func) New function.
8292 * pfm-read.c: (static spss2ascii[]) Make it const.
8294 * pfm-write.c: New file.
8296 * sfm-write.c: Formatting, comment fixes.
8298 * var.h: Comment fix.
8300 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
8302 * Makefile.am: Add pfm.h, pfm-read.c.
8304 * command.def: IMPORT is now implemented.
8306 * format.c: (glob var translate_fmt[]) New var.
8308 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
8309 (cmd_import) New function.
8310 (import_source_read) New function.
8311 (glob var import_source) New var.
8313 * pfm-read.c: New file.
8317 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
8319 (dump_dictionary) Disabled printing a couple of items.
8321 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
8323 * crosstabs.q: (postcalc) Call make_summary_table().
8324 (make_summary_table) New function.
8325 (insert_summary) New function.
8326 (display_dimensions) Remove some unnecessary arguments, all
8328 (output_pivot_table) Fix lots of problems with the risk table
8330 (submit) Don't display an empty table.
8331 (display_risk) Fix order of arguments to calc_risk().
8333 * glob.c: Always include assert.h and stdlib.h.
8335 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
8338 * tab.c: (tab_create) Cosmetic changes.
8340 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
8342 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
8346 * crosstabs.q: (output_pivot_table) Headers drawing and submission
8347 code simplified, moved into new function submit().
8348 (submit) New function.
8349 (crosstabs_dim) New function.
8350 (display_directional) Substitute variable names for %s where
8352 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
8353 (calc_symmetric) Initialize parameters only if non-NULL.
8354 Calculate Somers' d.
8355 (calc_directional) Calculate Somers' d (or copy it, really).
8358 * output.c: (outp_string_width) New function.
8360 * postscript.c: (postopen) Calculate font widths based on the
8361 width of the zero '0' character, not the width of the space
8362 character. Set paper-width and paper-length based on points, not
8364 (ps_open_page) Fix page setup string for landscape mode.
8366 * som.h: (struct som_dimension) Removed.
8367 (struct som_table_class) height, width members take int * not
8370 * tab.c: Many functions now have added parameter validation.
8371 (tab_height, tab_width) These functions were removed and merged
8372 into a single function tab_resize(), and all references changed.
8373 (tab_dim) Rewritten since the interface changed; reduced from
8374 hundreds of lines to two. All callers were changed. Currently
8375 most of them just use tab_natural_dimensions as their callback and
8376 await detailed translation of functionality.
8377 (tab_natural_width) New function.
8378 (tab_natural_height) New function.
8379 (tab_natural_dimensions) New function. This is a callback
8380 function, not something that you'd want to call directly.
8381 (tab_nat_dim) Removed.
8382 (tabi_table) Allocates t->w and t->h.
8383 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
8384 dimensions callback.
8385 (evaluate_dimensions) Removed.
8386 (sum_columns) Removed.
8388 * tab.h: (enum TAL_1THIN) Removed.
8389 (enum series t_*) Removed.
8390 (struct tab_table) Members trh, trv changed to unsigned char *
8391 from int *. Member dim changed to a function pointer from a
8392 unsigned char *. Member max_stack_height removed. New members
8394 (macros tab_l, tab_r, tab_t, tab_b) New.
8396 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
8398 * ascii.c: (delineate) Assign last_space_nchars before skipping
8399 spaces, to fix right justification.
8401 * crosstabs.q: (static vars risk, direct) New vars.
8402 (static var pearson_r) Removed.
8403 (glob var chisq_fisher) Made static.
8404 (static vars row_tot[], col_tot[]) Don't include grand total
8406 (static var grand_total) Renamed W, all references changed.
8407 (output_pivot_table) Only make `table' if num_cells != 0. Make
8408 risk and directional tables. Deal with grand total no longer part
8409 of col_tot[]. Free rows and cols after we're done with them.
8410 (display_risk) New function.
8411 (display_directional) New function.
8412 (clac_r) Rewritten so that it stores all its results into its
8413 arguments, so it can be used for Spearman's correlation too.
8414 (calc_symmetric) Added a t[] argument, all references changed.
8415 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
8416 Pearson's r, Cohen's kappa.
8417 (calc_risk) New function.
8418 (calc_directional) New function.
8420 * som.c: (som_submit) Improved debugging code.
8422 * stats.c: (hypercube) New function.
8423 (cube) New function.
8425 (normal_sig) Went back to old implementation, which actually
8428 * stats.h: (macros square, cube, hypercube) Removed. The
8429 equivalent functions in stats.c are inlined here; all references
8430 to square changed to sqr.
8432 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
8434 * crosstabs.q: (N_SYMMETRIC) New define.
8435 (postcalc) Disable debug printing.
8436 (static vars chisq_fisher, pearson_r) New.
8437 (output_pivot_table) Add support for symmetric measures. Add
8438 chi-square output of exact sigs.
8439 (display_chisq) Rewritten.
8440 (display_symmetric) New function.
8441 (gamma_int) New function.
8443 (swap) New function.
8444 (calc_fisher) New function.
8445 (calc_chisq) Check boundary conditions better. Calculate Yates,
8446 Fisher, Mantel-Haenszel tests.
8447 (calc_r) New function.
8448 (calc_symmetric) New function.
8450 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
8452 (chisq_sig) Better boundary conditions. Renamed from
8455 * tab.h: (struct tab_table) New member cf.
8457 * tab.c: (tab_create) Set cf.
8458 (tab_width) New function.
8459 (tab_realloc) Handle cf.
8460 (tab_vline) Handle cf.
8461 (tab_hline) Handle cf.
8462 (tab_box) Handle cf.
8463 (tab_value) Handle cf.
8464 (tab_float) Handle cf.
8465 (tab_text) Handle cf.
8466 (tab_joint_text) Handle cf.
8467 (tab_offset) Handle cf.
8468 (tab_next_row) Handle cf.
8469 (evaluate_dimensions) Handle cf.
8470 (render_strip) Handle cf.
8472 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
8474 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
8475 output_pivot_table().
8476 (output_pivot_table) Moved lots of local variables outside and
8477 made them static. Add beginnings of chi-square statistic
8478 support. Now column and row totals aren't in the main matrix.
8479 Always zero out any leftover rows & columns after we're done with
8480 the table entries. Move all output stuff into
8481 display_dimensions(), display_crosstabs(), display_chisq().
8482 (display_dimensions) New function.
8483 (display_crosstabulation) New function.
8484 (display_chisq) New function.
8485 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
8487 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
8488 references, simplify logic.
8490 * postscript.c: Remove scale, translate-x, translate-y,
8491 mirror-horz, mirror-vert, rotate-180 options.
8492 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
8493 All references deleted.
8494 (macro YT) New macro.
8495 (array option_tab[]) Removed options.
8496 (ps_option) Removed options.
8497 (ps_open_page) Write page setup explicitly to output file, without
8498 using now-deleted BP function.
8499 (macro dump_line) Use YT().
8500 (macro dump_thick_line) Use YT().
8501 (draw_headers) Use YT().
8502 (switch_font) Reorder arguments to SF function.
8503 (write_text) Use YT().
8505 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
8508 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
8510 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
8511 null-debugging code.
8512 (tab_realloc) Remove null-debugging code. Initialize new regions
8514 (tab_vline) Support offsets.
8515 (tab_hline) Support offsets.
8516 (tab_box) Support offsets.
8518 (tab_nulls) Removed.
8521 (evaluate_dimensions) Remove null-debugging code. Understand
8522 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
8523 TAB_EMPTY not present.
8525 * tab.h: New cell attribute TAB_EMPTY.
8526 (macros tab_nr, tab_nc, tab_row, tab_col) New.
8528 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
8529 try to read them from system files.
8531 * vfm.c: (dump_splits) Don't call tab_null().
8533 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
8535 * crosstabs.q: (struct crosstab) Added `missing' member.
8536 (custom_tables) Init missing.
8537 (calc_general) Handle missing values.
8538 (calc_chisq) New function.
8539 (output_pivot_table) Start work on chi-square output. Update for
8540 new tab offset support functions. Shorten statistic names.
8542 * Several files: add in more `const's to placate gcc's warnings.
8544 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
8547 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
8548 tab_null, tab_nulls, tab_value, tab_float, tab_text,
8549 tab_joint_text) Add col_ofs and row_ofs support.
8550 (tab_offset) New function.
8551 (tab_next_row) New function.
8552 (tab_row) New function.
8553 (tab_col) New function.
8554 (tabi_table) Add col_ofs and row_ofs support.
8556 * vars-atr.c: (is_system_missing) New function.
8558 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
8560 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
8561 (static var no_cells) Removed.
8562 (static var num_cells) New.
8563 (static var expected) New.
8564 (static var cells[]) New.
8565 (internal_cmd_crosstabs) Deal with new variables.
8566 (postcalc) Removed most of the meat and put it in new function
8567 output_pivot_table().
8568 (output_pivot_table) Calculates and outputs an entire pivot table.
8570 * postscript.c: (postopen) Fix problems with free()ing addresses
8571 not obtained from malloc().
8573 * som.c: (som_submit) Add assertion.
8575 * sysfile-info.c: (describe_variable) Use new tab_nulls()
8578 * tab.c: (static var tab_names[]) New.
8579 (tab_realloc) -1 for nc or nr indicates no change.
8580 (tab_nulls) New function.
8581 (tab_dim) Use tab_names[].
8582 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
8583 (evaluate_dimensions) Don't terminate on uninited cells, just put
8584 an X in them and emit a notice. Use tab_names[].
8586 * tab.h: Move bits into tab.def.
8588 * tab.def: New. Don't try to declare tab_table_class because then
8589 som.h has to be included.
8591 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
8593 * command.def: New file, contains all the command definitions
8594 previously included bodily in command.c.
8596 * format.def: New file, contains all of the format definitions
8597 previously split across format.h, format.c, and sfm-write.c.
8599 * lexer.h: Renamed from tokens.h in order to match corresponding
8602 * lexerP.h: Moved some rarely used functions exported by lexer.c
8605 * Makefile.am: Commemorate renamed files.
8606 (EXTRA_DIST) Add command.def, format.def.
8608 * command.c: [0] (walk_cmdtable_func) Removed.
8610 * crosstabs.q: (postcalc) Made it work and print out matrices
8612 (enum_column_values) Renamed enum_var_values, generalized for any
8615 * format.h: (struct fmt_desc) New member `spss'.
8617 * q2c.c: (main) Generated code includes lexer.h instead of
8620 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
8621 instead of an independent translation table.
8623 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
8625 * Lots of source files: Added const to declarations.
8627 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
8629 * arena.c: (arena_clear) Set prev pointer to null when done.
8631 * ascii.c: (ascii_option) Rename index as indx.
8633 * avl.c: This is now a separate library called libavl.
8634 (xmalloc) Make static.
8635 (avl_probe) Step A7 can use the cache instead of an explicit
8637 (avl_delete) Don't maintain a q pointer because it's always
8638 available in the pointer stack. Comment fix.
8640 * avl.h: This is now a separate library called libavl.
8642 * command.c: (cmd_table[]) Remove spurious trailing "".
8644 * common.h: Only include random() fix if this system needs it.
8646 * crosstabs.q: Include alloca headers.
8647 (n_sorted_tab) New global var.
8648 (postcalc) Mostly rewritten.
8649 (find_pivot_extent) Rewritten.
8650 (enum_column_values) Rewritten.
8652 * data-out.c: (convert_F) Rename inner n as n_spaces.
8654 * error.c: (dump_message) Don't have an outer var i.
8656 * file-handle.q: (static var f) Removed. All references removed.
8657 (internal_cmd_file_handle) Uses a local variable instead of f.
8659 * get.c: (trim_dictionary) Change scope of i, i1, i2.
8660 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
8663 * getline.h: Declare getl_history as extern. Reported by
8664 palme@uni-wuppertal.de (Hubert Palme).
8666 * postscript.c: (postopen) Some large mods for constness.
8668 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
8671 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
8673 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
8674 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
8677 * avl.c, avl.h: New files. These form a clean-room
8678 reimplementation of avllib. Iterative algorithms are used in
8679 place of recursive ones, so there is no resemblance in the code.
8681 * Lots of headers: Don't include other headers by default.
8683 * Lots of source files: Explicitly include all needed headers.
8685 * arena.c: (arena_clear) New function.
8687 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
8688 (static var ar) Removed.
8689 (staitc vars ar_tc, ar_col) New.
8690 (cmd_crosstabs) Destroy the arenas.
8691 (internal_cmd_crosstabs) Create the arenas.
8692 (precalc) Don't need a free function for the hash.
8693 (calc_general) Make sure to zero out the trailer on the key data
8695 (print_table_entries) Updated.
8696 (postcalc) Worked on actually implementing.
8697 (find_pivot_extent) New function.
8698 (compare_value) New function.
8699 (enum_column_values) New function.
8701 * data-in.c: (parse_month) Make local array `static const'.
8703 * data-out.c: (convert_date) Make local array `static const'.
8704 (convert_WKDAY) Same.
8705 (convert_MONTH) Same.
8707 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
8708 been renamed to avl_walk().
8710 * hash.c: Rewritten more efficiently.
8712 * hash.h: Add attribute const to hsh_next_prime declaration.
8714 * lexer.c: (id_match) Make arguments const.
8716 * postscript.c: (ps_postopen_driver) Make default fonts the
8719 * q2c.c: (main) Generated code needs stdlib.h.
8721 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
8722 initialized to 0 now, not to NULL. All other references to
8723 avl_traverser were updated in the same way.
8725 * tokens.h: Macro version of id_match updated to use const
8728 * val-labs.c: (inc_ref_count) New function.
8729 (copy_value_labels) Simply through use of new avl_copy() function.
8731 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
8733 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
8734 (postcalc) Worked on this.
8736 * postscript.c: (OPO_DOUBLE_LINE) New enum.
8737 (struct ps_driver_ext) New line_width_thick member.
8738 (ps_preopen_drive) Init line_width_thick.
8739 (option_tab[]) Add line-* options.
8740 (ps_option) Parse line-* options.
8741 (postopen) Add line_width_thick support. Strip leading spaces on
8742 prologue output lines.
8743 (ps_open_page) Include line_width_thick in output.
8744 (macro dump_thick_line) New.
8745 (dump_fancy_line) Support thick lines as well as double lines.
8747 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
8749 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
8750 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
8752 * Many source files: Rename `options' to `pv_opts' as appropriate.
8754 * command.c: (static var cmd_table[]) Add CROSSTABS command.
8756 * common.c: (xcalloc) New function.
8758 * crosstabs.q: New file. Not finished yet, though.
8760 * data-list.c: Comment fix.
8762 * error.c: Remove some old Checker cruft.
8764 * frequencies.q: (dump_full) Cumulate valid percent instead of
8767 * getline.c: Comment fix.
8769 * hash.c: Comment fixes.
8771 * hash.h: (struct hsh_table) Make hash functions return unsigned
8772 instead of int to avoid problems with taking the modulo of
8773 negative return values. All references changed.
8775 * misc.c: (intlog10) Make its table static const instead of auto.
8777 * sfm-read.c: (read_header) Make `prefix' static const instead of
8780 * var.h: (union value) Add member `hash'.
8781 (struct variable) Rename prv_index as `foo'--all references
8783 (typedef pv_opts) Removed. All references changed.
8785 * vars-prs.c: (parse_variables) Message fixes.
8787 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
8789 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
8790 they are being inserted. Don't check for BY variables of
8791 different types. Discard variables if the active file isn't
8792 included in the merge.
8793 (mtf_processing) Essentially rewritten.
8794 (mtf_merge_dictionary) Check for master/slave variables of
8795 different types/widths.
8797 * vfm.c: (static var not_canceled) New var.
8798 (process_active_file) Don't call vfm_source->read() if
8799 there's no vfm-source. Initialize not_canceled.
8800 (process_active_file_write_case) Honor and update not_canceled.
8801 (prepare_for_writing) Rollback changes from yesterday, they were
8803 (close_active_file) Don't destroy vfm_source unless it exists.
8805 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
8807 * Lots of source files: Added { } around nested if/else constructs
8808 to avoid new gcc 2.8 warnings.
8810 * data-in.c: (parse_Z) Declare `int' type explicitly.
8813 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
8814 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
8815 prev members. Put TABLEs at the end of the chain and FILEs at the
8816 beginning. Don't allow the active file in STATE_INIT. Use proper
8817 `seen' value for the active file. Fill out the by members and
8818 make sure they're of consistent type. Do the actual merge
8820 (mtf_processing_finish) New function.
8821 (var_type_description) New function.
8822 (mtf_free_file) New function.
8823 (mtf_free) Rewritten.
8824 (mtf_delete_file_in_place) New function.
8825 (mtf_read_nonactive_records) New function.
8826 (mtf_compare_BY_values) New function.
8827 (static var mtf_seq_no) New var.
8828 (mtf_processing) New function.
8829 (mtf_merge_dictionary) Assign nval members for the system file
8830 dictionary. Assign fv values for its variables. Point each slave
8831 variable to the corresponding master variable.
8833 * hash.c: Include str.h.
8835 * mis-val.c: (copy_missing_values) src arg is const.
8837 * misc.c: (spacing) Make `max' var explicitly int.
8839 * sfm-read.c: (dump_dictionary) Message reformatting.
8840 (sfm_read_case) Add assertion.
8842 * sort.c: Esthetic fixes.
8844 * var.h: (struct match_files_proc) New struct.
8845 (struct variable) Add private data match_files_proc.
8847 * vars-atr.c: (delete_variable) Implement. Add argument for the
8848 dictionary that owning the variable.
8849 (dup_variable) Add assertion.
8851 * vfm.c: Comment fixes, hopefully the comments are correct now.
8852 (process_active_file) New function.
8853 (process_active_file_write_case) New function.
8854 (process_active_file_output_case) New function.
8855 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
8857 (write_case) Renamed procedure_write_case(). Now write_case is a
8858 pointer to a function. Style fixes.
8860 1998-03-05 Ben Pfaff <blp@gnu.org>
8862 * Makefile.am: (q2c) Link with libmisc.
8863 (version.c) Define default_config_path, include_path,
8866 * ascii.c: (ascii_postopen_driver) When the default newline string
8867 is requested, open file in text mode. Suggested by
8868 palme@uni-wuppertal.de (Hubert Palme).
8869 (static vars line_buf, line_p) Change from char * to unsigned char
8871 (ascii_close_page) char * to unsigned char *.
8873 * cmdline.c: (parse_command_line) Implement -r option by
8874 prepending ~/.pspp/rc to the list of files to process.
8876 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
8877 before pulling in a final line.
8878 (null_func, null_int_func) Removed (dead code).
8880 * descript.q: (display) Calculate width of variable name column
8881 properly. Calculate number of valid cases properly. Reported by
8882 palme@uni-wuppertal.de (Hubert Palme).
8884 * filename.c: (init_filename) Use default_config_path instead of
8885 now obsolete CONFIG_PATH.
8887 * getline.c: (getl_initialize) Use include_path instead of now
8888 obsolete INCLUDE_PATH.
8889 (getl_add_file) New argument `where'. All references changed.
8891 * groff.c: (find_font_file) Use groff_font_path instead of now
8892 obsolete GROFF_FONT_PATH.
8894 * postscript.c: (find_ps_file) Use groff_font_path instead of now
8895 obsolete GROFF_FONT_PATH. Copy through temporary variable to
8896 avoid problems with constness.
8898 * str.h: (macro cs_streq) New macro.
8900 * version.h: (glob var default_config_path, include_path,
8901 groff_font_path) New vars.
8903 1998-02-23 Ben Pfaff <blp@gnu.org>
8905 * Many source files: Change verbose_msg() priority levels and
8908 * aggregate.c: Include debug-print.h.
8910 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
8912 (static var pre_syntax_message) Document --safer/-s and
8915 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
8917 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
8918 because it's not used but it's still copied.
8919 (open_file_r) Remove gratuitous debug message.
8921 * filename.c: (safety_violation) New function.
8922 (open_file) Remove gratuitous debug messages. Don't allow pipe
8923 files if set_safer is set.
8925 * get.c: Turn off debugging.
8927 * getline.c: (getl_add_virtual_file) New function.
8928 (getl_read_line) Add verbose_msg() call for opening new syntax
8930 (getl_perform_delayed_reset) Add a return value describing whether
8931 any action was taken. Call reset_eof().
8933 * getline.h: Comment fix.
8935 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
8936 place of incorrect `continue'. Use strtok_r() instead of
8937 strtok(). Always check strtok_r() return value.
8938 (groff_read_DESC) Use strtok_r() instead of strtok().
8940 * lexer.c: (reset_eof) New function.
8942 * main.c: (parse) Get a token after performing a delayed reset
8943 action; allow empty syntax files.
8945 * postscript.c: (output_encodings) Use strtok_r() instead of
8948 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
8950 * set.q: Comment fixes.
8951 (glob var set_safer) New var.
8952 (internal_cmd_set) Support SAFER.
8954 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
8956 * temporary.c: (free_dictionary) Set d->splits to NULL after
8959 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
8960 variable deleted, not if it *isn't* deleted.
8962 1998-02-16 Ben Pfaff <blp@gnu.org>
8964 * command.c: (array cmd_table[]) Add MATCH FILES.
8966 * common.c: Comment fixes.
8968 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
8969 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
8970 Include alloca.h. Problem reported by palme@uni-wuppertal.de
8973 * expr-opt.c: Include str.h. Problem reported by
8974 palme@uni-wuppertal.de (Hubert Palme).
8976 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
8977 (static var mtf_by) Change from char ** to variable **.
8978 (static var mtf_master) New var.
8979 (mtf_merge_dictionary) New function.
8980 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
8981 var type. Reorder tests properly. Initialize file->dict. Detect
8982 TABLE= without BY=. Read file dictionaries and merge them. Give
8983 subcommand name with IN, LAST, FIRST error messages. Create IN,
8984 LAST, FIRST variables. Comment fixes.
8985 (mtf_free) Don't free default_dict. Free mtf_master.
8987 * getline.c: Define getl_mode. Change getl_buf_size to size_t
8989 (handle_line_buffer) Cast int to size_t in comparison to avoid
8992 * getline.h: Declare getl_mode extern.
8994 * groff-font.c: (groff_read_font) Type-fix calls to getline.
8995 (groff_read_DESC) Make line_size a size_t.
8996 (match_tok) Parenthesize name to avoid macro expansion.
8998 * mis-val.c: (copy_missing_values) New function.
9000 * postscript.c: (postopen) Make buf_size a size_t.
9002 * sfm-read.c: (dump_dictionary) Make global from static. Print
9003 variable info in parts for easier debugging with Checker.
9005 * temporary.c: (copy_variable) Use copy_value_labels().
9006 (new_dictionary) New arg: whether to copy file label, documents.
9008 * val-labs.c: (copy_value_labels) New function.
9010 * var.h: (enums MISSING_*) Add MISSING_COUNT.
9012 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
9014 (dup_variable) Set prv_index, get.fv, get.nv.
9016 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
9018 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
9020 * Many source files: For ANSI-compliance, add empty statement
9021 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
9022 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
9024 * data-in.c: (parse_numeric) Some header files break on
9025 -DBL_MIN_10_EXP because they get a --; add () for safety.
9026 Reported by palme@uni-wuppertal.de (Hubert Palme).
9028 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
9029 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
9030 (dfm_close) Use close_file_ext.
9031 (open_inline_file) Set file.file to NULL, not file.
9032 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
9033 struct and use open_file_ext().
9034 (read_record) Use file.file.
9036 * file-handle.q: (prepend_current_directory) Pass through special
9039 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
9040 (normalize_filename) Pass through special filenames.
9041 (open_file, close_file) Accept pipe| and |pipe syntaxes as
9043 (dirname) Rename blp_dirname() because of name conflict on some
9044 OS. All references changed. Reported by palme@uni-wuppertal.de
9046 (is_special_filename) New function.
9048 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
9049 (trim_dictionary) Conditionalize some of the options on whether
9050 GTSV_OPT_MATCH_FILES is in *options.
9051 (rename_variables) Don't allow variables to be renamed as scratch
9053 (MTF_*) New enum series.
9054 (struct mtf_file) New struct.
9055 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
9057 (cmd_match_files, mtf_free) New functions.
9059 * lexer.c: (match_int) Needed parentheses around name to escape
9060 macro expansion. Reported by Micah Altman
9061 <maltman@www-vdc.fas.harvard.edu>.
9063 * print.c: Needed to include alloca.h. Reported by Micah Altman
9064 <maltman@www-vdc.fas.harvard.edu>.
9066 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
9067 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
9070 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
9071 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
9073 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
9075 * html.c: (struct html_driver_ext) Move into htmlP.h.
9076 (html_preopen_driver) Initialize cp_x, cp_y.
9077 (html_submit) Implement as call to output_tab_table().
9078 (change_attributes) New function.
9079 (escape_string) New function.
9080 (output_tab_table) New function.
9082 * list.q: (write_all_headers) Add code for writing headers for the
9084 (clean_up) Write out the html close-table tag.
9085 (determine_layout) Ignore html driver.
9086 (list_cases) Write html data.
9088 * som.c: (som_submit) Move more of the code into output_table().
9090 * tab.c: (static var hit) Make a global var and rename tab_hit.
9091 (static var tab_table_class) Make a global var.
9093 * htmlP.h: New file.
9095 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
9097 * dump-sysfile.c: Removed.
9099 * html.c: (preclose) Change comment in emitted code.
9101 * matrix-data.c: Debugging off by default. Comment fixes.
9102 (static var container) New var.
9103 (cmd_matrix_data) Create and destroy container. Initialize
9104 is_per_factor[] to 0s. Move code into new function
9105 string_to_content_type(). Require split values to be present in
9106 the data when ROWTYPE_ is explicit. Call specific function, not
9107 general read_matrices().
9108 (string_to_content_type) New function.
9109 (context) Exclude all whitespace, not just spaces.
9110 (mget_token) A dot is a number. Add assertion.
9111 (static var data) Renamed nr_data.
9112 (static var factor_values) Renamed nr_factor_values.
9113 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
9114 only specific case. Close data_file before exit.
9115 (fill_matrix) New function.
9116 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
9117 printing. Style fixes. Message fixes. Move code into
9119 (read_matrices_without_rowtype) Rename
9120 matrix_data_read_without_rowtype(). Fix off-by-one error on
9121 loops. Allocate nr_data[] memory from arena.
9122 (read_matrices_with_rowtype) Removed.
9123 (read_splits) Renamed nr_read_splits(). Style fixes.
9124 (read_factors) Renamed nr_read_factors().
9125 (dump_cell_content) Comment fixes. Arguments changed. Change
9126 debug printing. All references changed.
9127 (output_data) Renamed nr_output_data().
9128 (static var wr_content) New var.
9129 (struct factor_data) New struct.
9130 (static var wr_data) New var.
9131 (static var wr_current) New var.
9132 (matrix_data_source_destroy_source) Removed.
9133 (read_matrices_with_rowtype) New function.
9134 (matrix_data_read_with_rowtype) New function.
9135 (wr_read_splits) New function.
9136 (compare_factors) New function.
9137 (wr_output_data) New function.
9138 (wr_read_rowtype) New function.
9139 (wr_read_factors) New function.
9140 (wr_read_indeps) New function.
9141 (glob var matrix_data_source) Make destroy_source member NULL as
9144 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
9146 * lexer.c: (syntax_error) Give better error message when at end of
9149 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
9150 N_SCALAR to output as plain N.
9151 (mdump_token) Change output format.
9152 (context) Fix message output interaction with spaces in input.
9153 (another_token) New function.
9154 (force_eol) Improved error message.
9155 (static var max_cell_index) New var.
9156 (read_matrices) Init `cells'. factor_values is now per-cell.
9157 Init max_cell_index.
9158 (read_data_lines) Replace `compare' local with new `compare' arg.
9159 Debugging messages changed. Only read factors if per_factor.
9160 Propagate error return from read_factors(), force_eol().
9161 Copy N_SCALAR values across the N vector.
9162 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
9163 check parentheses manually since we now have is_per_factor[].
9164 Call read_data_lines() with new args. Check for end of data after
9165 looping, using another_token().
9166 (read_factors) Arguments changed. Use max_cell_index to determine
9167 whether to read or compare factors. Message fixes.
9168 (dump_cell_content) New function.
9169 (output_data) Completely rewritten because content types were
9170 supported to be nested inside factor values, not vice versa.
9172 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
9174 * lexer.c: (syntax_error) Support formatted varargs messages.
9176 * matrix-data.c: Turn debugging on by default.
9177 (static content_type[]) New array.
9178 (static content_names[]) New array.
9179 (static rowtype_, varname_) New vars.
9180 (static is_per_factor[]) New array.
9181 (static split_values) Moved declaration.
9182 (static n_continuous, first_continuous) New var.
9183 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
9184 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
9185 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
9186 Check for continuous variables.
9187 [DEBUGGING] (debug_print) Remove content_names[].
9188 (mdump_token) New macro.
9189 (mget_token_dump) New function.
9190 (mdump_token) New function.
9191 (context) New function.
9192 (mget_token) Fix messages.
9193 (static var data, split_values, factor_values) New vars.
9194 (read_matrices) Manage split_values, factor_values.
9195 (read_data_lines) New function.
9196 (read_matrices_without_rowtype) Implemented.
9197 (read_splits) Message fixes. Uses `just_read'.
9198 (read_factors) New function.
9199 (output_data) New function.
9200 (matrix_data_source_destroy_source) Close the file handle.
9201 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
9204 * str.c: (strpadcmp) Removed.
9206 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
9208 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
9210 * Lots of source files: Add cast to unsigned character to calls to
9211 tolower() and toupper().
9213 * aggregate.c: Set default_dict.splits to NULL.
9215 * command.c: (static variable tab[]) Add MATRIX DATA.
9217 * data-in.c: Add debugging defines. Formatting fixes.
9219 * expr-opt.c: Formatting fixes.
9221 * lexer.c: (syntax_error) Message fixes.
9223 * matrix-data.c: New enum series.
9224 (static vars fmt, section, diag, explicit_rowtype, signle_split,
9225 split_values, n_factors, factors, cells, pop_n, contents,
9226 n_contents) New vars.
9227 (cmd_matrix_data) Finished implementation.
9228 (compare_variables_by_mxd_vartype) New function.
9229 [DEBUGGING] (debug_print) New function.
9230 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
9231 (read_matrices) New function.
9232 (read_matrices_without_rowtype) New function.
9233 (read_matrices_with_rowtype) New function.
9234 (read_splits) New function.
9235 (mget_token) New function.
9236 (force_eol) New function.
9237 [0] (test_tokenizer) New function.
9238 (matrix_data_source_destroy_source) New function.
9239 (glob var matrix_data_source) New var.
9241 * misc.h: Include ieeefp.h if present.
9243 * split-file.h: (cmd_split_file) Changes corresponding to struct
9246 * str.h: Fix memmem prototype.
9248 * temporary.c: (save_dictionary, restore_dictionary,
9249 free_dictionary) Changes corresponding to struct dictionary
9252 * var.h: (MXD_* enums) New enum series.
9253 (struct matrix_data_proc) New struct.
9254 (struct split) Removed.
9255 (struct dictionary) Changed `splits' member from `split *' to
9257 (macro force_create_variable) New macro. Replaced lots of
9258 create_variable()/assert() calls with calls to this macro.
9260 * vars-atr.c: (discard_variables) Changed assertion.
9261 [GLOBAL_DEBUGGING] (force_create_variable) New function
9262 called by the macro of the same name.
9263 (clear_variable) Changes to delete splits from the dictionary
9264 corresponding to struct dictionary changes.
9266 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
9267 corrupted variable `index' values in the dictionary passed in
9268 every time this function is called.
9270 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
9271 to struct dictionary changes.
9273 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
9275 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
9277 * command.c: New includes.
9278 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
9279 (cmd_erase) New function.
9280 [unix] (shell) New function.
9281 (run_command) New function.
9282 (cmd_host) New function.
9283 (cmd_new_file) New function.
9285 * expr-prs.c: (parse_primary) Message fix.
9287 * inpt-pgm.c: Formatting fix.
9288 (cmd_reread) Implement the FILE subcommand.
9290 * matrix-data.c: New file.
9292 * q2c.c: (dump_header) Change output commenting style.
9294 * weight.c: Comment fix.
9296 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
9298 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
9300 (buf_10x) Renamed buf_1xx, all references changed.
9301 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
9302 cases now implemented).
9303 (create_sysfile) New function.
9304 (agr_11x_func) New function.
9306 * data-in.c: (parse_numeric) Work properly if there's an
9307 explicitly coded decimal point in the data and decimal places are
9308 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
9309 <el@linux.lisse.na>.
9311 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
9312 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
9313 Eberhard W Lisse <el@linux.lisse.na>.
9315 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
9316 strerror.c. Bug reported by Alexandre Oliva
9317 <oliva@dcc.unicamp.br>.
9319 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
9320 (static var separate_case_tab) New var.
9321 (cmd_sort_cases) Cancel temporary transformations here. Free
9322 v_sort before return.
9323 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
9324 we're reading from a sort stream. Don't cancel temporary
9325 transformations. Offload internal sorting to do_internal_sort().
9326 (do_internal_sort) New function. Handles internal sorting even
9327 when SEPARATE is nonzero. Doesn't free v_sort.
9328 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
9330 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
9331 sink if SEPARATE is zero.
9332 (read_output_cases) Renamed read_sort_output(), all references
9333 changed. Now uses separate_case_tab when it exists.
9334 (write_separate) New function.
9336 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
9337 memory_sink_cases. Don't redundantly call
9338 vfm_source->destroy_source().
9339 (memory_stream_mode) After switching over, set memory_sink_cases
9342 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
9344 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
9346 (static var prev_case) New, moved out of aggregate_single_case()
9348 (static var buf64_10x, buf_10x) New.
9349 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
9350 the 000, 001, 100, and 101 cases. Free prev_case.
9351 (parse_aggregate_functions) Disallow scratch variables.
9352 (free_aggregate_functions) Only free agr_dict if non-null. Use
9353 iter->function to determine numeric/string type, not
9355 (aggregate_single_case) Don't manage prev_case. Initialize
9356 aggregate info after dumping it.
9357 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
9358 mean, stddev, weighted stddev definitions.
9359 (dump_aggregate_info) Implemented.
9360 (initialize_aggregate_info) Renamed from
9361 initialize_aggregate_functions(). Initializes dbl[2].
9362 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
9363 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
9365 * cases.c: (alloc_val) Removed.
9367 * get.c: (cmd_save_internal) Initialize new `dict' member.
9369 * sfm-write.c: (sfm_write_dictionary, write_header,
9370 write_variable, write_value_labels, write_documents) Reorganize,
9371 simplify for new parameter structure.
9372 (write_variable) Only one variable * argument now.
9374 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
9375 replaced by new `dict' member.
9377 * temporary.c: (new_dictionary) Initialize n_documents.
9379 * vars-atr.c: (dup_variable) Allocate `value's from dict into
9381 (init_variable, replace_variable) Eliminate usage of alloc_val().
9383 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
9385 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
9386 signal that AGGREGATE is to be used for forming final cases.
9387 (close_active_file) Call end_func before stopping lagging. Cancel
9388 temporary after finishing compaction.
9389 (write_case) Comment fixes. Cleaned up.
9390 (compact_case) Let AGGREGATE handle compaction when `temporary' is
9393 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
9395 * Makefile.am: (BUILT_SOURCES) Add means.c.
9396 (pspp_SOURCES) Add means.c.
9397 (EXTRA_DIST) Add means.q.
9399 * command.c: (array cmd_table[]) Add MEANS.
9401 * common.h: Esthetic fixes. Comment fixes. Test for
9402 MAX_SHORT_STRING greater than 8.
9403 (macros LOWEST, HIGHEST) New.
9405 * data-in.c, data-list.c, recode.c: Comment fixes.
9407 * means.q: New file, base version.
9409 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
9410 with LOWEST, DBL_MAX with HIGHEST.
9412 * q2c.c: (dump_vars) Add an enum to array types giving the number
9413 of values for the enum.
9415 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
9416 Replace second_lowest_value with second_lowest_flt64.
9418 * sfm-write.c: (write_variable, write_rec_7_34) Replace
9419 second_lowest_value with second_lowest_flt64.
9421 * t-test.q: Comment fix.
9423 * temporary.c: (restore_dictionary) Esthetic fix.
9425 * tokens.h: (force_match_id, force_match, force_string, force_int,
9426 force_num, force_id) Replace msg() with syntax_error().
9428 * var.h: (struct means_proc) New.
9429 (struct variable) Add mns member to `p' union.
9431 * vars-prs.c: (parse_variable, parse_dict_variable,
9432 parse_variables, parse_DATA_LIST_vars) Replace msg() with
9435 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
9437 * Makefile.am: (pspp_SOURCES) Add tab.h.
9439 * Most source files: Added a cast to unsigned char in usages of
9440 the ctype is*() functions. Replaced `end of command expected'
9441 calls to msg() with calls to syntax_error().
9443 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
9445 * lexer.c: (hex_val) Removed (was dead code).
9446 (idmatch) Parenthesize function name to avoid macro expansion.
9448 * postscript.c: Comment fixes.
9449 (ps_preopen_driver) Change default font size to 10pt.
9451 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
9453 (parse_format_spec) Change system-file format spec argument type
9454 to int32. Parse the format spec with bitwise operators.
9456 * sfmP.h: (struct sysfile_format) Removed.
9457 (struct sysfile_variable) Changed print, write members from
9458 sysfile_format to int32.
9460 * tokens.h: Esthetic fixes.
9461 [__GNUC__] (macro id_match) New macro to hopefully speed up
9462 identifier matching.
9463 (macros match_id, match_tok, match_int) Implemented in
9464 compiler-independent manner; no longer GNU C only.
9466 * vfm.h: Include time.h.
9468 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
9470 * data-list.c: (dump_fixed_table) Change tab_dim().
9472 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
9474 * error.c: Include command.h.
9476 * frequencies.g: Formatting fixes.
9478 * frequencies.q: Add tab_dim() calls. Make the total cell a
9481 * glob.c: Include command.h.
9483 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
9485 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
9486 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
9487 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
9488 the other elements (is this right?).
9489 (read_variables) Use lowest, highest members.
9490 (parse_format_spec) New arg `vv' for more stringent checking.
9491 (dump_dictionary) Byteswaps nonexplicit data.
9492 (sfm_read_case) Byteswap numeric data.
9494 * som.c: Initialize table_num to 1.
9495 (render_segments) Remember to increment y_index after each table
9498 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
9499 avl_count() on a NULL tree. No title for the second table.
9500 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
9501 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
9502 fix call to display_variables().
9503 (display_variables) Default to 4 columns, not 3. Set up headers.
9504 Column title is Variable, not Name. Fix index column.
9505 Add joint text. Add tab_dim(). Handle value labels properly.
9506 Handle DISPLAY LABELS properly. Draw boxes correctly.
9507 (describe_variable) Value labels don't need titles. Don't clear
9508 nonexistent index column.
9509 (compare_vectors_by_name) New function.
9510 (display_vectors) New function.
9512 * tab.c: (tab_height) Add assertion.
9513 (tab_null) Add debug code.
9514 (evaluate_dimensions) Add debug code.
9516 * var.h: (struct variable) get_proc data is sometimes used
9517 simultaneously with other per-procedure info, therefore it was
9518 removed from the union. All references changed.
9520 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
9522 * ascii.c: (ascii_close_page) Put title on second line of headers
9523 if there is no subtitle.
9525 * command.c: (glob var cur_proc) Move definition here, from
9527 (cmd_remark) Emit blank line before remarks.
9529 * command.h: (glob var cur_proc) Move declaration here, from
9532 * data-list.c: (dump_fixed_table) Fix messages.
9533 (dump_free_table) Call tab_nat_dim().
9535 * descript.q: (dump_z_table) Modify tab_dim() call.
9537 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
9539 (dump_statistics) Don't output header.
9541 * groff-font.c: Minor format fix.
9543 * html.c: Comment fix.
9545 * list.q: (write_varname) Indent after advancing page.
9547 * output.h: Minor reordering.
9549 * postscript.c: Comment fixes. Many places, '\n' was replaced by
9550 a reference to eol[].
9551 (struct ps_driver_ext) New member eol[].
9552 (ps_preopen_driver) Initialize eol[].
9553 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
9554 defaults. Handle headers. Fix test for minimum page length.
9555 (static var option_tab[]) Add `line-ends'.
9556 (ps_option) Handle line-ends to change eol[].
9557 (postopen) Scale prop_em_width and fixed_width properly. Set the
9558 prologue title to outp_title if applicable. Replace the prologue
9559 line ends with eol[]. Call draw_headers() if headers are enabled.
9560 (text_width) New function.
9561 (out_text_plain) New function.
9562 (draw_headers) New function.
9564 * print.c: (dump_table) Call tab_nat_dim().
9566 * som.c: (som_blank_line) Only advance a line if not at the top of
9568 (som_submit) Move several informational table calls here.
9569 Increment subtable_num if SOMF_NO_TITLE not set.
9570 (output_table) Advance a line if SOMF_NO_SPACING not set.
9571 (render_columns, render_segments, render_simple) Handle spacing
9572 between tables. Handle table titles. Remove debug output.
9574 * som.h: (SOMF_*) New enum series.
9575 (struct som_table_class) New member `flags'.
9577 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
9579 (display_variables) Calls tab_nat_dim().
9580 (describe_variable) Remove restriction on number of value labels.
9581 Make value labels separated by thin lines.
9583 * tab.c: (tab_create) Default `flags' to none.
9584 (tab_float) New arg `w'. All references changed.
9585 (tab_nat_dim) New function.
9586 (tab_output_text) No title or spacing.
9587 (tab_flags) New function.
9588 (tabi_flags) New function.
9589 (tabi_title) New function.
9590 (strip_height) Removed.
9591 (tabi_render) Skip title when necessary.
9592 (static var tab_tab_class) Add tabi_flags, tabi_title.
9593 (evaluate_dimensions) Disable display of column, row size.
9594 (sum_columns) Add title height to top header.
9595 (render_strip) Moved within file.
9597 * tab.h: (struct tab_table) New member `flags'.
9599 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
9601 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
9603 * Most source files: Add `const' attribute in all appropriate
9606 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
9607 column to the variables table for use by describe_variable().
9608 (cmd_display) Disable for the present.
9609 (display_documents) Don't wrap documents.
9610 (display_variables) Table has four columns now.
9611 (describe_variable) Table has four columns now. Don't use a
9612 subtable, use joined cells instead.
9614 * tab.c: (tab_create) Don't set `join'.
9615 (tab_realloc) ct array is not made up of a_string's.
9616 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
9617 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
9618 (text_format) New function.
9619 (tab_title) Rewritten, uses text_format().
9620 (tab_text) Rewritten, uses text_format().
9621 (tab_joint_text) New function.
9623 (static var hit) New variable.
9624 (render_strip) New args r1, r2. Implement joined cells that fit
9626 (tabi_render) Increment hit. Pass new args to render_strip().
9627 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
9628 cells. For t_naw and t_nah, ignore joined cells and null cells in
9631 * tab.h: (struct tab_join_rect) Removed.
9632 (struct tab_table) Removed `join'.
9633 (TAB_JOIN_MAIN) Removed.
9634 (struct tab_joined_cell) New struct.
9635 (TAT_NOWRAP) New enum.
9637 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
9639 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
9641 (ascii_postopen_driver) Fix initialization of *_spacing so that
9642 the TAL_0 bit doesn't count.
9644 * data-list.c: (dump_fixed_table) Use natural width for Format
9647 * glob.c: (rerange) Removed.
9648 (get_date) Formatting fixes. Internationalization fix.
9650 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
9653 * postscript.c: (ps_postopen_driver) Replace
9654 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
9656 * som.c: (som_submit) Don't eject page before every table.
9657 (output_table) Fix order of arguments on call to area().
9658 (render_columns) Fix calculation of max_len.
9660 * tab.c: (tabi_cumulate) Minor change to increase elegance.
9661 (render_strip) New function.
9662 (strip_height) New function.
9663 (tabi_render) Rewrite as calls to render_strip().
9665 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
9666 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
9667 with the TAB_* and OUTP_T_* constants.
9669 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
9671 * Makefile.am: Formatting fixes.
9673 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
9676 * data-list.c: (dump_fixed_table) Add tab_dim() call.
9678 * descript.q: (dump_z_table, display) Add tab_dim() calls.
9680 * dump-sysfile.c: (glob var length) Make type off_t.
9681 (usage) Fix arguments.
9684 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
9685 Now right-justification is the default so many references had to
9687 (struct outp_class) Removed line_width, all references changed.
9688 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
9689 (struct outp_driver) Add elements horiz_line_width,
9690 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
9693 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
9695 (postopen) Initialize all the informational members of
9698 * som.c: (som_blank_line) New function, renamed from blank_line(),
9699 all references changed.
9700 (som_submit) Disables drivers whose pages can't be opened.
9701 (render_columns, render_simple, render_segments) Add debug output.
9702 (render_columns) Fix loop range.
9703 (render_simple) Don't try to render the headers, they're taken
9704 care of automatically. Advance cp_y past the table when done.
9705 (render_segments) Fix loop ranges.
9707 * tab.c: Initialize new members of tab_table.
9708 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
9709 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
9710 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
9713 (tab_dim) New function.
9714 (tab_col_width) Removed.
9715 (tab_row_height) Removed.
9716 (tab_output_text) Call tab_dim().
9717 (tabi_driver) Call evaluate_dimensions(), sum_columns().
9718 (tabi_area) Implemented.
9719 (tabi_cumulate) Implemented.
9720 (tabi_render) Partially implemented, but broken.
9721 (var tab_table_class) Made static.
9722 (evaluate_dimensions) New function.
9723 (sum_columns) New function.
9725 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
9726 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
9727 t_scr, t_srr, t_sentinel. Removed: t_nat.
9728 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
9729 max_stack_height, w, h. Removed: ce, re.
9730 (macro blank_line) Removed.
9731 (glob var zero_length) Removed.
9733 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
9735 * Most source files: include some of the new include files broken
9738 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
9741 * aggregate.c: (glob var outfile) Make static.
9743 * command.c: (glob var pgm_state) Move here.
9745 * common.c: (glob vars endian, second_lowest_value, pgmname,
9746 finished, curdate, cur_proc, start_interactive, history_file) Move
9749 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
9751 * file-handle.q: (glob vars files, inline_file) Move here.
9753 * glob.c: Lost lots of glob vars, detailed in individual file
9755 (init_glob) set_printer, set_screen were obsolete, deleted.
9756 set_cprompt has fewer spaces because pspp has fewer letters than
9759 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
9760 (inp_nval) Made static.
9762 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
9763 tokstr_len, toklongstr, tokint) Move here.
9765 * misc.c: Lost several vars and functions.
9767 * set.q: (all the set_* variables) Move here.
9769 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
9770 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
9773 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
9775 * tab.h: (enum series t_*) New enums.
9776 (struct tab_table) Use arena struct tag. New members ce, re.
9778 * tokens.h: Comment fixes.
9780 * var.h: Move lots of enums and variables and functions and
9781 structures to other files. Use and declare a lot more union and
9782 struct tags. Comment fixes.
9784 * vector.c: (glob vars vec, nvec) Move here.
9786 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
9787 init_blanks, last_vfm_invocation) Move here.
9789 * cases.h: New file.
9790 (struct long_vec) Move here.
9791 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
9794 * command.h: New file.
9795 (STATE_* enums) Move here.
9796 (glob var pgm_state) Move here.
9798 * format.c: New file.
9799 (glob var formats) Move here.
9800 (parse_format_specifier_name, fmt_to_string,
9801 check_input_specifier, check_output_specifier,
9802 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
9805 * format.h: New file. Move functions now in format.c here.
9806 (FMT_* enums) Move here.
9807 (struct fmt_desc) Move here.
9808 (FCAT_* enums) Move here.
9809 (struct fmt_spec) Move here.
9810 (glob vars formats, fmt_parse_ignore_error) Move here.
9812 * inpt-pgm.h: New file.
9813 (INP_* enums) Move here, make #defines into enums.
9814 (glob vars inp_init, inp_init_size) Move here.
9817 (glob vars v_sort, nv_sort) Move here.
9818 (sort_cases, read_sort_output) Move here.
9820 * vector.h: New file.
9821 (struct vector) Move here, add struct tag.
9822 (glob vars vec, nvec) Move here.
9823 (find_vector) Move here.
9826 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
9827 reinit_blanks, init_zero, init_blanks) Move here.
9828 (struct case_stream) Move here.
9829 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
9830 vfm_disk_stream, sort_stream, data_list_source,
9831 input_program_source, file_type_source, get_source, n_lag) Move
9833 (procedure, write_case, lagged_case, compact_case, page_to_disk)
9836 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
9838 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
9839 (LDADD) Add libdcdflib.
9841 * ascii.c: Comment and formatting fixes. Almost every external
9842 function had an assert added, checking driver_open and page_open.
9843 (ascii_init_driver) Broken into ascii_preopen_driver,
9844 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
9845 (ascii_open_page) Sets page_open.
9846 (ascii_close_page) Clears page_open.
9848 * html.c: Comment and formatting fixes. Almost every external
9849 function had an assert added, checking driver_open and page_open.
9850 (html_init_driver) Broken into html_preopen_driver,
9851 html_postopen_driver, html_close_driver. Manages driver_open.
9852 (html_open_page) Sets page_open.
9853 (html_close_page) Clears page_open.
9854 (html_submit) Disabled.
9856 * lexer.c: (parse_string) Remove debugging printf.
9858 * list.q: (determine_layout) Open a page if one is not yet open.
9860 * output.c: Comment fixes.
9861 (add_class) Set the class member of the new list element.
9862 (parse_options) Don't handle device type.
9863 (colon_tokenize) New function.
9864 (configure_driver) New four-field format with a field for device
9865 type. Now initialize driver_open, page_open, next, and prev
9866 fields. Use new colon_tokenize() function. Don't do a memory
9867 copy to replace a driver, it doesn't work; instead delete the old
9868 driver and insert a new one.
9869 (destroy_driver) Don't call som_destroy_driver(). Close the page
9870 if it's open. Find the class in the list of classes and decrement
9871 that reference count. Remove the driver from the global driver
9873 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
9874 references changed. Rewritten. Don't return a driver that's not
9876 (outp_eject_page) All references to som_internal_eject_page()
9877 changed to use this. Sets cp_x to 0 as well as cp_y.
9879 * output.h: (OUTP_I_* enums) Removed.
9880 (struct som_submission_form) Removed.
9881 (struct outp_class) init_driver broken into preopen_driver,
9882 postopen_driver, and close_driver. submit changed to take a
9885 * postscript.c: Comment and formatting fixes. Almost every
9886 external function had an assert added, checking driver_open and
9888 (ps_init_driver) Broken into ps_preopen_driver,
9889 ps_postopen_driver, ps_close_driver. Manages driver_open.
9890 (ps_open_page) Sets page_open.
9891 (ps_close_page) Clears page_open.
9893 * som.c: New file, base implementation.
9895 * som.h: (struct som_table) Add struct tag.
9896 (enum SOM_COL_ACROSS) Removed.
9897 (SOM_ROWS, SOM_COLUMNS) New enums.
9898 (struct som_table_class) Add member `cumulate'. Remove `segment';
9899 change `render' arguments.
9900 (struct som_point, struct som_rect) Removed.
9901 (som_submit_table) Fixed typo, should have been som_submit.
9903 * sysfile-info: (describe_variable) Don't try to insert a
9904 subtable; just destroy it for now.
9906 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
9907 references to value labels.
9909 * tab.c: (tab_destroy) New function.
9910 (tab_columns) Change argument.
9911 [0] (tab_submit) Remove dead code.
9912 (tab_title) Allocate string from the table's arena.
9913 (tab_output_text) Only free the buffer if we allocated it.
9914 (tab_submit) New function.
9915 (static vars t, d) New static vars.
9916 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
9917 tabi_headers, tabi_cumulate, tabi_render) New functions.
9918 (glob var tab_table_class) New global var.
9920 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
9921 encapsulate the rectangle. All references changed.
9923 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
9925 * All header files updated to use struct tags in addition to
9926 typedefs for all structures. Don't use word `struct' in struct
9929 * Makefile.am: (pspp_SOURCES) Remove html.c.
9930 (INCLUDES) Replace the lib/* includes with a single lib/ include;
9931 all references updated.
9933 * command.c: (parse_cmd) Remove call to som_check_workspace.
9934 (output_line) Update to new som.
9936 * data-in.c: (parse_numeric) A single dot is not an error; it is
9937 the system-missing value.
9939 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
9942 * data-out.c: Added `const' as appropriate to many prototypes.
9943 (convert_E, convert_F, convert_CCx) Take double argument instead
9944 of value * argument.
9945 (convert_format_to_string) Call changed functions appropriately.
9946 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
9947 make a local copy of the value.
9949 * descript.q: Remove custom_variables() prototype now provided by
9951 (custom_variables) Don't increment sbc_variables, the caller does
9953 (dump_z_table, display) Update to new som.
9955 * error.c: (vmsg) Add const to prototype. Remove code to handle
9956 `too many errors' condition.
9957 (check_error_count) New function.
9958 (msg) Add const to prototype.
9960 * filename.c: (open_file) Rewrite for elegance.
9962 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
9963 (dump_full, dump_condensed, dump_statistics) Update for new som.
9965 * list.q: Don't include somP.h. Change all references to
9966 som_driver_ext to refer to the new members of som_driver. Change
9967 som_internal_eject_page() references to outp_eject_page().
9969 * main.c: (parse) Rewrite for elegance. Add call to
9970 check_error_count().
9972 * output.c: (add_class, outp_list_classes, outp_configure_driver)
9973 Rewrite or revise for new outp_driver_class_list structure.
9974 (outp_iterate_enabled_drivers) Fix comparison between disabled
9975 devices and current device type.
9976 (outp_eject_page) New function.
9978 * output.h: Comment fixes.
9979 (struct outp_driver) New members driver_open, page_open, cp_x,
9980 cp_y, font_height, prop_em_width, fixed_width. Deleted members
9982 (struct outp_driver_class_list) New struct.
9983 (outp_class_list) Changed to type outp_driver_class_list; all
9986 * print.c: (dump_table, print_trns_proc) Updated for new som.
9988 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
9989 prototypes for custom subcommands.
9990 (dump_subcommand) Always include the `else'.
9991 (dump_parser) Fix comments in output code.
9993 * set.q: Reordered functions.
9995 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
9997 * som.h: Rewritten from scratch.
9999 * str.h: Remove dead code.
10001 * tab.c, tab.h: New files, base implementation.
10003 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
10006 * t-test.q: New code from John Williams
10007 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
10008 Many many new static vars and defines.
10009 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
10010 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
10011 (struct value_list) New struct.
10012 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
10013 t_crt, t_sig, print_t_groups) New functions.
10014 (cmd_t_test) Implemented.
10016 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
10019 * vfm.c: (dump_splits) Update to new som.
10021 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
10023 * Makefile.am: (fiasco_SOURCES) Add html.c.
10025 * aggregate.c: Base source.
10027 * ascii.c: (postopen, preclose) Reformat.
10029 * data-out.c, expr-evl.c: Comment fixes.
10031 * filename.c: (open_file) When opening a file for writing, use
10032 line buffering instead of full buffering for better interactive
10033 performance. Suggested by Valerio Aimale
10034 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
10035 names `stdin', `stdout', `stderr'.
10037 * groff-font.c: Comment fixes.
10039 * html.c: New file; base version.
10041 * list.q: (write_all_headers, clean_up, determine_layout,
10042 list_cases) Ignore `special' devices for now. Needs to be fixed
10045 * output.c: (outp_init) Add html driver to list; reverse list
10048 * output.h: (struct outp_class_struct) New members `special',
10049 `submit'; comment fixes. All references changed.
10051 * postscript.c: (ps_init_driver) Make defaults for text_opt,
10052 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
10054 (postopen) Comment fix.
10055 (preclose) Comment fixes, formatting fixes. Change x->file.file
10056 references to more proper f->file.
10058 * som-high.c: (som_submit_table) Special classes use their own
10061 * som.h: Comment fixes.
10063 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
10066 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
10068 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
10070 * aggregate.c: Still working on this.
10072 * command.c: (cmd_table[]) Add AGGREGATE back in.
10073 (split_words) Make '-' a legal word separator as well as ' '.
10075 * main.c: Comment fixes.
10077 * q2c.c: (dump_parser) Don't require the procedure's full name to
10078 be present, in the generated source.
10080 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
10081 multiply specified and let it be default; let MISSING, CRITERIA,
10082 FORMAT be multiply specified.
10083 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
10084 (custom_groups) Fix defaults.
10085 (custom_pairs) Check whether this is a PAIRS subcommand before
10086 attempting to parse. Better garbage collection. Proper storage
10088 [DEBUGGING] (debug_print) New function.
10090 * temporary.c: Comment fixes.
10091 (copy_variable) Don't copy variable name and index.
10092 (save_dictionary) Copy variable name and index by hand.
10094 * vars-atr.c: Comment fixes.
10095 (create_variable) New dictionary argument. All references
10097 (common_init_stuff) New dictionary argument. All references
10099 (init_variable) New dictionary argument. All references changed.
10100 (dup_variable) New function.
10102 * vars-prs.c: (parse_variables) If there are any errors, we always
10103 return 0. Previously, it was possible for some types of errors to
10106 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
10108 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
10111 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
10113 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
10116 * q2c.c: Comment fixes.
10117 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
10119 * t-test.q: (cmd_list) Rename cmd_t_test.
10121 * temporary.c: (new_dictionary) Don't declare as static.
10123 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
10125 * aggregate.c: Changes, still not finished.
10127 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
10129 * q2c.c: Comment fixes. Now its output is internationalized.
10130 (get_token) Fix parsing of escapes within literal strings.
10131 (main) Fix bad #line directives in output.
10133 * t-test.q: Base implementation.
10135 * temporary.c: (new_dictionary) New function.
10136 (restore_dictionary) [__CHECKER__] Change fill character to *
10139 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
10141 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
10143 * aggregate.c: Changes, still not finished.
10145 * descript.q, list.q: Comment fixes.
10147 * q2c.c: Almost completely rewritten.
10149 * t-test.q: New file, not complete.
10151 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
10153 * aggregate.c: Changes, still not finished.
10155 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
10158 * temporary.c: (cancel_temporary) New function.
10160 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
10161 of doing it by hand.
10163 * vfm.c: (close_active_file) After restoring a TEMPORARY
10164 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
10165 cancel_temporary().
10166 (SPLIT_FILE_procfunc) Comment fix.
10168 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
10170 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
10172 * aggregate.c: New file, not finished yet.
10174 * command.c: (cmd_table) Add AGGREGATE.
10176 * common.h: (pgm_state) Move declaration to var.h.
10178 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
10180 (parse_string) Message fix.
10182 * recode.c: Comment fix.
10184 * sfm-read.c: (read_variables) Code esthetic fixes.
10185 (write_header) Default date is `Jan', not `JAN'.
10187 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
10189 * sort.c: (cmd_sort_cases) Farm the work out to new function
10190 parse_sort_variables().
10191 (parse_sort_variables) New function.
10192 (sort_cases) New function. Cancels temporary transformations,
10193 which sorting didn't do previously.
10194 (cmd_sort_cases) Better garbage collection on error. Uses
10195 do_external_sort().
10196 (write_initial_runs, merge_once) Improved code esthetics.
10197 (sort_stream_read) Reduced to one call to read_output_cases().
10198 (read_output_cases) New function.
10200 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
10201 variable labels to 120 characters.
10203 * var.h: Comment fixes.
10204 (glob var pgm_state) From common.h.
10206 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
10208 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
10209 options. Set *names to NULL on error.
10211 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
10213 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
10215 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
10216 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
10218 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
10220 * vfm.c: (page_to_disk) Added missing local variables.
10222 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
10224 * get.c: Comment fix.
10226 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
10227 source is anything other than a disk stream, not just if it's in a
10228 memory stream. Call page_to_disk() before external sort.
10229 (allocate_cases) Message fix.
10231 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
10233 (page_to_disk) New function.
10235 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
10237 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
10239 * common.h: (macro strerror) Remove. From Alexandre Oliva
10240 <oliva@dcc.unicamp.br>.
10242 * get.c: (dict_delete_run) The number of variables to delete is
10243 not necessarily the number of variables that need to be shifted
10245 (trim_dictionary) Don't set *options to 0. Fix bug that caused
10246 too many variables to be deleted.
10248 * postscript.c: Comment fix.
10250 * q2c.c: Include strerror.c. From Alexandre Oliva
10251 <oliva@dcc.unicamp.br>.
10253 * set.q: #undef ON and OFF. From Alexandre Oliva
10254 <oliva@dcc.unicamp.br>.
10256 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
10257 early, otherwise errors cause a bad free().
10259 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
10260 Oliva <oliva@dcc.unicamp.br>.
10262 * temporary.c: (save_dictionary) Don't allocate memory if
10265 * vfm.c: (memory_stream_write) Message fix.
10267 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
10269 * command.c: (static var cmd_table[]) Define REPEATING DATA
10272 * common.h: Added support for broken systems that are missing
10273 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
10275 * Many source files: Replace syntax error messages via msg() with
10276 call to syntax_error().
10278 * data-list.c: (dump_fixed_table) Add support for dumping table
10279 for REPEATING DATA as well as DATA LIST FIXED.
10280 (cmd_repeating_data) Allows and requires `/' between subcommands.
10281 Does proper thing with allowing rpd.starts_end to stay 0. Allows
10282 CONTINUED specifications to be omitted. Forces CONTINUED to be
10283 specified if ID is. Calculates starts_end, cont_end from logical
10284 record length as reported by fhp. Calls dump_fixed_table() if
10285 requested. Fixed length of record copied by memcpy.
10286 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
10288 (realize_value) Returns sensible value for out-of-range variable
10290 (rpd_parse_record) New argument `ofs'. Fixed confusion between
10291 length of occurrences and length of line. Added warning for
10292 fields that exceed the line length. Fixed infinite loop.
10293 (read_one_set_of_repetitions) Numerous minor changes for more
10294 complete SPSS compliance. Message fixes.
10296 * dfm.c: (dfm_close) If the file being closed is the inline file,
10297 read all the remaining data before closing it.
10298 (dfm_get_record) Don't close the file on lossage, as either it
10299 has been closed already or it doesn't belong to us.
10301 * error.c: (puts_stdout) New function.
10302 (vmsg) Use puts_stdout instead of puts.
10304 * file-handle.q: (fh_record_width) New function.
10306 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
10308 (clear_case) Ditto.
10309 (input_program_source_read) Made an old kluge an approved method.
10311 * lexer.c: (syntax_error) New function.
10313 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
10316 * output.c: (oupt_get_paper_size) Message fix.
10318 * q2c.c: Numerous fixes to formatting of generated code made to
10319 conform to GNU coding standards. Uses syntax_error() in generated
10320 code. Other miscellaneous generated message fixes. Added support
10321 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
10322 RAND_MAX, and/or strerror().
10324 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
10326 * data-in.c: Comment fixes.
10328 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
10329 (find_variable_input_spec) New function.
10330 (cmd_repeating_data) Initializes id_spec.
10331 (rpd_parse_record) Implemented.
10332 (read_one_set_of_repetitions) Returns -3 by default in order to
10333 kluge out some potential bugs.
10335 * data-out.c: Comment fixes.
10337 * file-type.c: (internal_cmd_record_type) Message fix.
10339 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
10340 for handling -3 return value.
10342 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
10344 * data-list.c: Comment fixes.
10345 (struct dls_var_spec) Reordered members.
10346 (read_from_data_list_fixed) Restructured.
10347 (struct repeating_data_trns) Reordered members. Renamed `starts'
10348 as `starts_beg', `ends' as `starts_end'.
10349 (cmd_repeating_data) Calculates length of repeated data if
10350 necessary and possible.
10351 (parse_num_or_var) Don't allow string variables.
10352 (realize_value) New function.
10353 (rpd_msg) New function.
10354 (rpd_parse_record) New function. Currently stubbed out.
10355 (read_one_set_of_repetitions) Implemented.
10357 * inpt-pgm.c: (input_program_source_read) Comment fix.
10359 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
10361 * command.c: (cmd_end_repeat_p) Removed.
10362 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
10363 (parse_cmd_name) Removed.
10365 * data-list.c: Comment fixes.
10366 (data_list_pgm) Removed `eof' member.
10367 (static var first) New var.
10368 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
10369 FILE TYPE file inside FILE TYPE structures.
10370 (append_var_spec) Appends to *first, not dls.spec.
10371 (parse_fixed) Message fixes.
10372 (struct rpd_num_or_var) New.
10373 (struct repeating_data_trns) New.
10374 (static var rpd) New.
10375 (cmd_repeating_data) New function.
10376 (parse_num_or_var) New function.
10377 (parse_repeating_data) New function.
10378 (read_one_set_of_repetitions) New function.
10380 * file-type.c: (cmd_file_type) Message fixes. Always
10381 default_handle to FILE TYPE file handle.
10382 (internal_cmd_record_type) Message fixes.
10384 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
10386 * repeat.c: Comment fix. Disable debugging.
10388 * temporary.c: (restore_dictionary) Sets splits to NULL and
10389 n_splits to 0 before destroying the variables because now doing
10390 this tries to remove split variables.
10392 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
10393 destroying the dictionary.
10394 (clear_variable) Removes a variable from splits after destroying
10397 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
10399 * cmdline.c: (set_compat) Removed.
10400 (pick_compat) Removed.
10401 (parse_command_line) Removed -c option.
10402 (pre_syntax_message) Removed -c option.
10403 (usage) Remove compatibility code.
10405 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
10406 (glob var compat) Removed.
10408 * compute.c: (type_check) Fixed messages about type mismatches.
10410 * data-list.c: (cmd_data_list) Removed compatibility code.
10411 (fixed_parse_compatible) Calls convert_negative_to_dash().
10412 Fixed bug where it only set the variable in fx.spec if it created
10413 the variable itself.
10414 (dump_fmt_list) Spelling fix.
10415 (cut_field) Removed compatibility code.
10417 * dfm.c: (cmd_begin_data) Don't require a command terminator on
10418 BEGIN DATA command.
10420 * expr-evl.c: (evaluate_expression) Implement LAG.
10422 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
10423 (parse_neg) Calls convert_negative_to_dash().
10424 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
10427 * expr.h: (struct expression_struct) Removed member max_lag.
10429 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
10430 (internal_cmd_record_type) Removed special handling to produce
10431 negative numbers from dash tokens.
10433 * getline.c: (static var DO_REPEAT_level) New var.
10434 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
10435 (handle_line_buffer) Copies the line into getl_buf; doesn't call
10436 copy_with_DO_REPEAT_substitutions().
10437 (getl_read_line) Maintains value of getl_mode. Calls
10438 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
10440 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
10442 * getline.h: (getl_mode) New glob var.
10444 * glob.c: Comment fixes.
10445 (init_glob) Restructured. Sets set_seed.
10446 (init_compat_dependent) Removed. All references removed.
10447 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
10448 (__htonl, __htons) Removed. (What were these for?)
10450 * lexer.c: (static var tbl) Dash set to class CNUM.
10451 (make_hexit) New function from data-out.c.
10452 (get_token_representation) Rewritten.
10453 (convert_negative_to_dash) New function.
10454 (lex_init_compat_dependent) Removed.
10455 (yylex) A dash is parsed as part of a number if it is followed by
10456 a digit. The ASCII representation of a number is copied to
10457 tokstr. String parsing farmed out to parse_string(). Comment
10459 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
10461 (preprocess_line) Line processing depends on interactive/batch
10462 mode, not on compatibility mode. Removed PC+ compatibility code.
10464 * loop.c: (loop_3_trns_proc) Comment fix.
10466 * main.c: Remove dead code.
10467 (main) Remove call to init_compat_dependent().
10469 * misc.c: (convert_fmt_ItoO) Make E format conversion more
10472 * print.c: (parse_string_argument) Calls
10473 convert_negative_to_dash().
10474 (fixed_parse_compatible) Calls convert_negative_to_dash().
10476 * repeat.c: (RPT_* defines) Removed.
10477 (struct rpt_numeric) Removed.
10478 (struct repeat_entry) New member type, changed `replacement' from
10480 (clean_up) Deallocation adapted to new repeat_entry.
10481 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
10482 usage. Creates vars for `type' of 1.
10483 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
10484 (store_numeric) Rewritten, new interface.
10485 (parse_numbers) Rewritten.
10486 (parse_strings) Rewritten.
10487 (find_DO_REPEAT_substitution) New function.
10488 (perform_DO_REPEAT_substitutions) New function.
10489 (copy_with_DO_REPEAT_substitutions) Removed.
10490 (debug_print) Rewritten.
10492 * set.q: Comment fix.
10493 (custom_results) Removed compatibility code.
10494 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
10495 compatibility code.
10497 * sysfile-info.c: (cmd_display) Removed compatibility code.
10499 * tokens.h: Comment fixes.
10500 (token types enum) Removed `toktype' typedef name for this int
10501 type. Removed SUBST. Restructured.
10503 * vars-atr.c: (discard_variables) Sets n_lag to 0.
10505 * vars-prs.c: Comment fix.
10507 * vfm.c: Comment fixes.
10508 (glob var n_lag) New var.
10509 (static vars lag_count, lag_head, lag_queue) New vars.
10510 (procedure) Removed argument nlag.
10511 (setup_lag) New function.
10512 (close_active_file) Discards lagging state.
10513 (lag_case) New function.
10514 (lagged_case) New function.
10515 (write_case) Lags a case if lagging.
10517 * weight.c: (cmd_weight) Removed compatibility code.
10519 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
10521 * getline.h: (struct getl_script) New members loop_index, macros.
10523 * getline.c: (getl_add_file) Sets first_line field to NULL.
10524 (getl_add_DO_REPEAT_file) New function.
10525 (handle_line_buffer) When the current line's length is negative,
10526 set the filename and line number. Increment line number after
10527 reading line. Pass the line to
10528 copy_with_DO_REPEAT_substitutions() for processing.
10529 (getl_close_file) Free DO REPEAT lines before freeing the
10530 filename, and just set the filename to NULL when doing this,
10531 because otherwise the filename gets freed twice.
10533 * glob.c: (glob var queuing) Removed. All references removed.
10535 * lexer.c: Comment fixes.
10536 (get_token_representation) New function.
10538 * repeat.c: Comment fixes.
10539 (struct repeat_entry) Replaced type and v union members with a
10541 (append_record) New function.
10542 (internal_cmd_do_repeat) Started reforming it for the new
10543 repeat_entry struct. Properly records filename changes in the
10544 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
10545 strncasecmp() result usage. Uses append_record() to simplify.
10546 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
10547 to add in the file.
10549 (copy_with_DO_REPEAT_substitutions) Started coding.
10551 [DEBUGGING] (debug_print_lines) New function.
10553 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
10555 * tokens.h: (macro is_id1, is_idn) New macros.
10557 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
10559 * cmdline.c: (static var pre_syntax_message) Changed `win'
10560 compatibility mode to `wnd'.
10562 * data-list.c: (fixed_parse_spss) Renamed
10563 fixed_parse_compatible().
10565 * glob.c: (init_glob) Excise unused code for
10566 program_invocation_short_name.
10568 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
10571 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
10573 * set.q: `win' compatibility renamed `wnd'.
10575 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
10577 * filename.c: [__WIN32__] Change the included Windows header files
10579 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
10580 second character is absolute.
10581 (dirname) Fix logic error. Don't printf() the results.
10582 (prepend_dir) Don't printf() the results.
10584 * getline.c: (handle_line_buffer) New function.
10585 (getl_read_line) Reads line with handle_line_buffer() when
10587 (getl_close_file) Discard line buffer data.
10589 * getline.h: Comment fixes.
10590 (struct getl_line_list) New struct.
10591 (getl_script_struct) Added line buffer members. These are hooks
10592 for use by DO REPEAT to allow it to insert virtual source code
10595 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
10596 Override Borland C++ stupidity that claims Windows has a console
10597 window size of 0x3.
10599 * repeat.c: This is in the process of being restructured from
10600 using a token-buffering approach to the DO REPEAT facility to
10601 using the more flexible approach of a line-buffering approach in
10602 conjunction with the getline module. Comment fixes.
10603 (struct tok_struct) Removed.
10604 (static vars queue_index, queue_head, queue) Removed.
10605 (static vars line_buf_head, line_buf_tail) New vars.
10606 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
10608 (pull_queue, destroy_queue) Removed.
10609 [DEBUGGING] (debug_print_tokens) Removed.
10611 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
10613 * file-handle.q: (prepend_current_directory) New function.
10614 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
10615 current directory before normalizing filename.
10617 * filename.c: (gnu_getcwd) New function.
10618 (absolute_filename_p) New function.
10619 (search_path) New argument, PREPEND. All references changed to
10620 pass NULL except those explicitly mentioned. Uses
10621 absolute_filename_p(). Prepends PREPEND before trying the
10623 (dirname, prepend_dir) New functions.
10625 * getline.c: (getl_get_current_directory) New function.
10626 (getl_include) Passes getl_get_current_directory() as PREPEND arg
10629 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
10631 * In several source files, the term `script' was replaced with
10632 `syntax file' inside error messages. Usage of the term `script'
10633 in the sense of a syntax file is now deprecated.
10635 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
10638 * dump-sysfile.c: (usage) Update message.
10640 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
10642 * getline.h: (glob var getl_include_path) Declare extern.
10644 * list.q: Define EXTERN as extern before #including somP.h.
10646 * var.h: Remove declaration of `disptype' variable.
10648 * vfm.c: (close_active_file) After switching the data sink to a
10649 data source, set vfm_sink to NULL, because it doesn't exist any
10652 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
10654 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
10655 _matherrl() to ignore all math errors.
10657 * sfm-read.c: (read_value_labels) When reading the labels from
10658 disk, read the little parts separately instead of as a struct;
10659 this avoids alignment problems.
10661 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
10662 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
10663 (write_header) Allocates and initializes elem_type.
10664 (sfm_write_case) Uses elem_type to determine how to handle each
10666 (sfm_close) Frees elem_type.
10668 * sfmP.h: Comment fix.
10669 [__BORLANDC__] Uses #pragma -a to adjust structure member
10672 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
10674 * Makefile.am: (fiasco_SOURCES) Remove display.c.
10676 * common.c: Fix typo.
10678 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
10679 sense of the condition.
10681 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
10682 line-continuation backslash.
10684 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
10686 * frequencies.q: (custom_grouped, add_percentile) Don't use a
10687 non-constant expression as an argument to sizeof.
10689 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
10690 undefine gettext macro because that's a conio function.
10692 * hash.h: (hsh_prime_tab declaration) Remove.
10694 * list.q: (write_fallback_headers) Move `leader' allocation out of
10695 main loop. Change to local_alloc() allocation.
10697 * output.h: Formatting fixes. Put __attribute__ in right place on
10698 function prototypes.
10700 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
10701 incorrect `SECOND_LOWEST_VALUE' references to proper
10702 `second_lowest_value'.
10704 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
10705 value. This way 2 out of 3 of the som files define the vars
10706 extern, the correct way, that actually works under BC++.
10707 (som_set_float) Don't use nonconstant initializers for a struct.
10709 * som-high.c: Add the standard alloca() header.
10710 (replicate_table) Add prototype.
10712 Merged DISPLAY routine.
10713 * sysfile-info.c: (AS_*) New enum series.
10714 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
10716 (cmd_display, display_macros, display_documents,
10717 display_variables) Stolen from defunct display.c.
10718 (describe_variable) New function.
10720 * temporary.c: [0] (display_tree) New debug function.
10721 (copy_variable) Performs shallow copy of value labels instead of
10722 deep copy; i.e., just copys the AVL tree and increments the
10725 * val-labs.c: Comment fixes.
10726 (do_value_labels) Optionally skip leading forward slash.
10727 (get_label) Creates only a single value label instead of many
10728 copies of one, and sets the reference count.
10730 * display.c: Removed.
10732 * dump-sysfile.c: New file, not yet complete.
10734 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
10736 For lots of source files I added more verbose_msg's. These aren't
10737 listed below as they have tested as being benign. In some cases
10738 these replaced debug_printf() calls.
10740 * output.c: (outp_read_devices) Message fix.
10742 * postscript.c: (output_encodings) Message fix. Reports errors on
10744 (postopen) Message fix.
10746 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
10748 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
10750 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
10753 * main.c: Remove <malloc.h> #include.
10755 * mis-val.c: (parse_numeric) Set .f member for each missing[]
10756 instead of trying to just set the missing[] itself, which is a
10757 gcc-specific idiom.
10759 * sfm-read.c: (read_variables) Same.
10761 * str.h: Add memmem() prototype.
10763 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
10765 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
10767 * Makefile.am: (q2c) Don't include any libraries in the link.
10769 * dfm.c: (force_line_buffer_extension) New macro.
10770 (count_tabs) New function.
10771 (tabs_To_spaces) New function.
10772 (read_record) Calls tabs_to_spaces() on the line being processed.
10774 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
10775 have to be compiled twice (once for CC, once for LOCAL_CC).
10777 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
10779 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
10780 (LDADD) Add @INTLLIBS@.
10781 (q2c) Add LIBS, @INTLLIBS@ to link step.
10783 * inpt-pgm.c: Turn off debugging.
10785 * postscript.c: (postopen) Format fix. local_free() blocks
10786 returned by local_alloc(); don't free() them.
10788 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
10790 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
10793 * data-list.c: (read_from_data_list_fixed) Pass proper value for
10794 LEN arg, not simply the full string length.
10796 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
10797 directories before generic temp file directories.
10799 * vfm.c: Disable debugging.
10801 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
10803 * get.c: Comment fix.
10804 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
10806 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
10808 * expr-prs.c: (debug_print_postfix) Conditionally included on
10809 GLOBAL_DEBUGGING. Removed out_header() reference.
10811 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
10813 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
10815 * ascii.c: Removed obsolete ascii_close_page() prototype.
10817 * command.c: (output_line) Comment fix.
10819 * data-in.c: Formatting fix.
10820 (parse_string_as_format) Now the `fc' argument is used only for
10821 the purpose of error messages; it is not an index into the string
10822 passed. All references changed.
10824 * data-list.c: Comment fix.
10825 (cut_field) Comment fix. Now returns the column number of the
10826 position of the field cut out on success.
10827 (parse_field) Added `column' argument. Puts the column numbers in
10829 (read_from_data_list_free, read_from_data_list_list) Record the
10830 column number returned by cut_field(), pass it to parse_field().
10832 * dfm.c: Comment fix.
10834 * do-ifP.h: Comment fix.
10836 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
10837 the SYSMIS function.
10839 * expr.h, exprP.h: Comment fix.
10841 * glob.c: (init_glob) Only calls setlocale() and family if
10844 * hash.h: Comment fix.
10846 * include.c: Comment fix.
10848 * output.c: Comment fix.
10850 * postscript.c: (ps_line_intersection) Simplified assertion.
10852 * repeat.c: Comment fix.
10854 * vars-atr.c: Comment fix.
10856 * vars-prs.c: Comment fix.
10858 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
10859 behavior with usage of postincrement.
10860 (memory_stream_read) Discards cases as it goes.
10862 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
10864 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
10867 * Most source files: Includes debug-print.h, related comment
10870 * cases.c: (alloc_val) Removed complex allocation code. Merely
10871 increments default_dict.nval and returns the former value.
10872 (envector, devector) Removed references to lv member of struct
10875 * common.h: (macro VME) Replaced complex definition with simple
10878 * data-list.c: (cmd_data_list) Sets vfm_source instead of
10879 read_active_file and cancel_input_pgm.
10880 (read_from_data_list, cancel_data_list) Removed.
10881 (data_list_source_read, data_list_source_destroy_source) New
10883 (glob var data_list_source) New var.
10885 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
10886 (cmd_begin_data) Improved criteria for an input program accessing
10887 the inline file. Still not perfect.
10889 * do-if.c: (do_if_trns_proc) Simplified debug output.
10891 * expr-prs.c: Comment fixes.
10892 [DEBUGGING] (debug_print_postfix) Simplified debug output.
10894 * file-handle.q: (fh_close_handle) Simplified debug output.
10896 * file-type.c: Comment fixes.
10897 (cmd_file_type) Sets vfm_source instead of read_active_file and
10899 (cmd_end_file_type) On failure, discards variables in place of
10900 just canceling the input program.
10901 (read_from_file_type) Renamed file_type_source_read.
10902 (cancel_file_type) Renamed file_type_source_destroy_source.
10903 (glob var file_type_source) New var.
10905 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
10906 (cmd_get) Initializes options to GTSV_NONE before passing to
10907 trim_dictionary(). Removed `lv' reference. Sets vfm_source
10908 instead of read_active_file and cancel_input_pgm.
10909 (cmd_save_internal) Initializes options before passing to
10910 trim_dictionary(). Local var `nval' removed.
10911 (dict_delete_run) Comment fixes.
10912 (trim_dictionary) Comment fixes. Disallows scratch variables if
10913 GTSV_OPT_SAVE set in options.
10914 (read_from_get) Renamed get_source_read.
10915 (cancel_get) Renamed get_source_destroy_source.
10916 (glob var get_source) New var.
10918 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
10919 read_active_file and cancel_input_pgm.
10920 (read_from_input_program) Renamed input_program_source_read.
10921 Simplified debug output.
10922 (cancel_input_program) Renamed
10923 input_program_source_destroy_source.
10924 (glob var input_program_source) New var.
10926 * loop.c: (loop_1_trns_proc) Simplified debug output.
10928 * main.c: (dump_token) Made eof output more explicit.
10930 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
10933 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
10934 code for always-memory or always-disk cases. malloc's case-list
10935 based on vfm_source_info.ncases. Explicit support for
10936 memory_stream via memory_source_cases.
10937 (do_external_sort) Sets vfm_source instead of read_active_file and
10939 (allocate_file_handles) The temporary directory permissions are
10940 set to 0700 instead of 0777.
10941 (allocate_cases) Formatting fixes. Simplified debug output.
10942 (output_record) Compacts the case if necessary before writing it
10944 (close_handle, open_handle_w) Simplified debug output.
10945 (write_initial_runs) Destroys vfm_sink, then sets it to
10946 sort_stream. Writes records to memory based on
10947 vfm_sink_info.case_size.
10948 (write_to_sort_cases) Renamed sort_stream_write().
10949 (merge) Simplified error handling. Simplified debug output.
10951 (read_from_external_sort) Renamed sort_stream_read().
10952 Reads records based on vfm_source_info.case_size.
10953 (sort_stream_write) Writes records to memory based on
10954 vfm_sink_info.case_size.
10955 (sort_stream_mode) New function.
10956 (glob var sort_stream) New variable.
10958 * temporary.c: (cmd_temporary) Simplified debug output.
10959 (copy_variable) Removed references to `lv'.
10961 * title.c: (get_title) Simplified debug output.
10963 * var.h: Comment fixes.
10964 (struct get_proc) Removed member `lv'.
10965 (struct variable) Removed member `lv'. Comment fixes.
10966 (glob vars read_active_file, write_active_file, cancel_input_pgm)
10968 (struct case_stream) New.
10970 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
10971 read_active_file references to use vfm_source.
10972 (init_variable, replace_variable) Removed references to `lv'.
10974 * vfm.c: Comment fixes.
10975 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
10977 (static var queue, qh, qt, n_lag) Removed. All references
10979 (glob var compaction_necessary, compaction_nval, compaction_case,
10980 paging) New variables.
10981 (record_case) Removed.
10982 (procedure) Comment fixes. Calls vfm_source->read() instead of
10983 read_active_file().
10985 (prepare_for_writing, arrange_compaction, make_temp_case,
10986 vector_initialization, setup_filter) New function.
10987 (open_active_file) Most of the code moved into the abovementioned
10988 new functions. Now sets temp_dict to &default_dict if there is no
10989 temporary dictionary, for convenience. New debug output.
10990 (close_active_file) Deals with changing the sink to the source.
10991 Calls finish_compaction(). Frees compaction_case. Mostly
10993 (glob vars disk_source_file, disk_sink_file) New vars.
10994 (destroy_active_file, read_from_memory) Removed.
10995 (disk_stream_init, disk_stream_read, disk_stream_write,
10996 disk_stream_mode, disk_stream_destroy_source,
10997 disk_stream_destroy_sink) New functions.
10998 (glob var vfm_disk_stream) New var.
10999 (glob vars memory_source_cases, memory_sink_cases,
11000 memory_sink_iter, memory_sink_max_cases) New vars.
11001 (memory_stream_init, memory_stream_read, memory_stream_write,
11002 memory_stream_mode, memory_stream_destroy_source,
11003 memory_stream_destroy_sink) New functions.
11004 (glob var vfm_memory_stream) New var.
11005 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
11006 named `more_cases'. Simplified debug output. Otherwise mostly
11008 (record_case) Moved into the stream drivers. Removed.
11009 (transform) Removed (was dead code).
11010 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
11011 common case that the splits don't change, we don't need to copy
11012 the case into prev_case again--pointless.
11013 (compact_case) New function.
11014 (finish_compaction) New function.
11016 * vfmP.h: Comment fixes.
11017 (DEV_* enum series) Removed.
11018 (struct storage) Renamed `stream_info'. Removed variant record.
11019 Removed `device' member.
11021 * debug-print.h: New file.
11023 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
11025 * autorecode.c: Turned off debugging.
11027 * data-list.c: (destroy_dls) Closes the associated file handle.
11029 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
11030 parse_variables() options.
11032 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
11034 * display.c: (display_variables) Really fixed null cell bug.
11036 * file-handle.q: (fh_close_handle) Changed debugging message.
11038 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
11039 parse_variables() options.
11041 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
11042 (cmd_list) Fails if no variables specified.
11043 (determine_layout) Writes blank lines manually.
11045 * loop.c: (loop_1_trns_proc) Made debugging code only print
11046 messages if debugging.
11048 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
11049 parse_variables() arguments.
11050 (main) Parses optional parenthesized options to varlist
11051 subcommands into sbc->message.
11053 * sfm-read.c: Format fix.
11055 * var.h: (FV_*) New enum series.
11056 (PV_*) New enum PV_NO_SCRATCH.
11058 * vars-prs.c: (find_var) Removed.
11059 (fill_all_vars) Takes FV_* enum instead of boolean third
11060 argument. Rewritten to deal with scratch as well as system
11062 (parse_variables) Error message on scratch variable if
11065 * vfm.c: (static var virt_begin_func) New var.
11066 (procedure) Sets up virt_begin_func.
11067 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
11068 after dump_splits(). For succeeding groups changes, calls
11069 virt_begin_func() instead of begin_func().
11071 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
11073 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
11076 * dfm.c: Added some debugging messages, disabled by default.
11077 (open_file_r) Fixed error message.
11078 (read_record) On eof on inline_file, instead of calling
11079 fh_close_handle(), simply jump to eof label like a normal file.
11082 * display.c: Thin lines between rows for certain kinds of
11083 listing. Fixed `null cell' bug.
11085 * error.c: (failure) Flush stdout, stderr before failing.
11087 * file-handle.q: (fh_close_handle) Added debugging message.
11089 * frequencies.q: (dump_full) Bottom line extends across entire
11090 table width. Changed title formatting.
11091 (dump_condensed) Changed title formatting.
11092 (dump_statistics) Fixed title formatting.
11094 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
11095 Sets default value of set_format.
11097 * list.q: (cmd_list) Calls blank_line() before determine_layout().
11098 Passes write_all_headers() to procedure() as pre-group func.
11099 (write_all_headers) New function.
11100 (determine_layout) Removed calls to write_header().
11101 Calls blank_line() before and after write_fallback_headers().
11103 * recode.c: (recode_trns_free) Only attempts to free head->map if
11106 * sfm-read.c: (read_variables) Allows `#' at beginning of system
11107 file variable names but gives a warning. Sets `left' based on
11108 first character being/not being `#'. On lossage frees dict->var.
11110 * som-high.c: (som_draw_title) Simplified title formatting.
11112 * vfm.c: (dump_splits) Fixed and changed splits formatting.
11114 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
11116 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
11117 beginning. Frees v_src, v_dest on successful exit. Frees
11118 h_trans[*], h_trans on lossage.
11119 (recode) Frees h_trans[*], h_trans.
11121 * dfm.c: (dfm_close) Formatting change.
11122 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
11123 longer allocates its own in inline_file.
11124 (open_file_r) Passes the local dfm_fhuser_ext to
11125 open_inline_file().
11126 (open_file_w) Message fix.
11127 (read_record) Buffer reallocation strategy changed. Frees
11128 ext->line even in inline_file to prevent leaks.
11129 (dfm_put_record) Fixed bug where `ext' was cached before the file
11130 was opened and thus it would be NULL when the file really was
11132 (cmd_begin_data) Sets up inline_file basics itself, then calls
11133 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
11135 * list.q: (write_line) Formatting fix.
11136 (clean_up) Minor strategy change. Sets proportional font after
11138 (determine_layout) Sets fixed font before writing regular headers,
11139 or after writing fallback headers.
11141 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
11142 and KEEP vars after using them.
11144 * postscript.c: (ps_init_driver) Frees x->family.
11145 (postopen) When loading fonts, free the temporary font name buffer
11147 (ps_text_set_font_by_position) Free temporary font name buffer
11149 (text) Fixed code that calculated `lig' so that `lig' always gets
11150 initialized. Formatting fix.
11152 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
11154 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
11155 cells, not xmalloc(), so that the cells will get destroyed
11158 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
11161 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
11163 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
11166 * dfm.c: Comment fix.
11168 * list.q: Comment fixes. Include somP.h. Removed static vars
11169 table, n_columns, n_rows, part. New struct list_ext. New static
11171 (n_lines_remaining, n_chars_width, write_line) New functions.
11172 (cmd_list, list_cases) Rewritten.
11173 (begin_row, end_row, flush_table) Removed.
11174 (write_header, clean_up, write_varname, write_fallback_headers,
11175 determine_layout) New functions.
11177 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
11179 * output.h: Comment fix.
11181 * postscript.c: Comment fix.
11182 (struct ps_driver_ext) Removed prop_size, fixed_size members;
11183 added font_size. All references changed.
11184 (ps_init_driver) Initializes font_size. Simplified space checking
11186 (static var option_tab[]) Removed prop-size, fixed-size; added
11188 (ps_option) Handles font_size.
11190 * som-high.c: Moved prototypes into somP.h.
11191 (som_init_driver) New function.
11192 (som_submit_table) Moved some code into new function
11194 (build_target) Moved some code into new function
11195 som_internal_eject_page().
11196 (som_eject_page) Uses som_internal_eject_page().
11197 (som_internal_eject_page) New function.
11199 * som-low.c: Moved prototypes into somP.h.
11201 * som.h: Formatting fixes.
11203 * somP.h: (struct som_driver_ext) Removed em_width;
11204 added prop_em_width, fixed_width.
11206 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
11208 * Makefile.am: Added `localedir' definition. Added
11209 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
11211 * ascii.c: (macro draw_line) Fixed capitalization.
11213 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
11214 compute.c, count.c, data-in.c, data-list.c, data-out.c,
11215 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
11216 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
11217 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
11218 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
11219 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
11220 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
11221 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
11222 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
11223 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
11224 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
11225 for internationlization.
11227 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
11229 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
11231 * do-if.c, sort.c, val-labs.c: Comment fixes.
11233 * glob.c: (init_glob) Uncommented, updated i18n support.
11235 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
11236 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
11237 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
11238 the declarations of macros taking arguments a lot nicer.
11240 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
11242 * error.h: Removed CE, CW aliases for SE, SW.
11244 * q2c.c: Removed explicit streq() definition since it's duplicated
11247 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
11248 stats.h, str.h, tokens.h: Made the declarations of macros taking
11249 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
11252 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
11254 * cmdline.c: Comment fixes.
11255 (pick_compat) Changed return type to int. Now, instead of setting
11256 glob var `compat' to the emulation, returns the emulation. All
11257 references changed.
11258 (parse_command_line) Added terminating null to end of
11259 `long_options' array definition.
11260 (pre_syntax_message) Fixes.
11261 (usage) Shows the default emulation in the syntax message by
11262 calling pick_compat().
11264 * getline.c: (getl_add_include_dir) Separates paths with
11265 PATH_DELIMITER, not DIR_SEPARATOR.
11267 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
11268 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
11270 * output.c: (outp_configure_macro) Make earlier definitions for a
11271 particular key override later ones for the same key.
11273 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
11275 * ascii.c: Comment fixes.
11277 * output.c: (outp_get_paper_size)
11278 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
11280 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
11282 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
11283 <errno.h>. GNU libc 2 enforces this!
11285 * command.c: (parse_cmd) Fixed problem with `else' clause being
11286 paired with wrong `if'. Comment fix.
11288 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
11290 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
11291 blp_getline() to getline().
11293 * output.c: (outp_eval_dimension) Changed the fix from last time;
11294 there was no variable `a'.
11296 * q2c.c: (get_line) Fixed boundary condition overrun bug.
11298 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
11300 * output.c: (outp_evaluate_dimension) Fixed handling of negative
11301 numbers having fractional parts. Added case of a fraction without
11302 a whole-number part.
11304 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
11306 * ascii.c: (ascii_text_get_font_position) Removed.
11308 * expr.h, exprP.h: Disabled debugging.
11310 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
11313 * output.h: (struct outp_class_struct) Removed
11314 text_get_font_position method. All references deleted.
11316 * postscript.c: Big change here. Fontmaps were completely
11317 eliminated because of a change in philosophy. Comment fixes.
11318 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
11320 (struct ps_driver_ext) `position', `fontmap', `prop_name',
11321 `fixed_name' members removed. New members `prop_family',
11322 `fixed_family'. `family' member changed to type char *.
11323 (static var ps_fontmaps) Removed.
11325 (ps_init_driver) Removed obsolete references, updated.
11326 Initializes `translate_x', `translate_y', `scale'. Doesn't read
11327 fontmap, of course. Refers to font names through internal_name
11328 rather than subversive means. Frees proper items.
11329 (static var option_tab[]) Removed `fontmap-file' option; renamed
11330 `fixed-font', `prop-font'.
11331 (ps_option) Corresponds to option_tab[].
11332 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
11333 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
11334 hash_family) Removed.
11335 (postopen) Generates font names from family names. Gets
11336 PostScript font name properly. New prologue file comment `!!!'
11338 (ps_open_page) Adds translate_x, translate_y to BP prologue
11339 function; gives SF argument floating-point format.
11340 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
11341 font name. Doesn't change font family.
11342 (ps_text_set_font_by_position) Generates Groff font name from font
11343 family name instead of through table lookup.
11344 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
11345 all references changed. Reduced to simple string assignment.
11346 (ps_get_font_name) Removed.
11347 (ps_get_font_family) Reduced to string return.
11348 (text) Doesn't save `position' since it no longer exists. Ugly
11349 kluge to save font family--fix soon?
11350 (load_font) Removed PostScript name argument.
11352 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
11354 * postscript.c: Comment fix.
11355 (ps_open_page) Puts scale factor in PostScript output.
11357 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
11359 * Makefile.am: Distcleans q2c.
11361 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
11363 * ascii.c: (delineate) Sets text size even if width is zero.
11365 * command.c: Comment fix.
11366 (static var cmd_table[]) Re-enabled EVALUATE command.
11367 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
11368 of comments in script files. Now more liberal on criteria for
11369 performing a state transition--if *anything* happened correctly,
11370 not just if *everything* happened correctly.
11372 * data-out.c: (convert_F) Comment fix. Why in the fsck does
11373 Checker segfault on formatting large numbers and why in the fsck
11374 hadn't I noticed this before?
11376 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
11378 * list.q: (cmd_list) Commented out the actual output routine
11379 because of various problems. Probably will abandon the idea of
11380 using the general `crushed tables' for the LIST procedure.
11382 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
11383 clearing it. Allocates a new var_by_name dictionary before trying
11384 to add members to it.
11386 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
11387 `sib'. Changed type of `node' argument.
11388 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
11389 avl_walk_inorder().
11390 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
11391 [DEBUGGING] Only deletes the variable from var_by_name if that var
11394 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
11396 * Makefile.am: Added include files to SOURCES. Added
11397 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
11398 includes rules for q2c. Added `boast' target.
11400 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
11402 * Makefile.am: Maintainer-clean Makefile.in.
11404 * Makefile.am: Fixed redundant EXTRA_DIST line.
11406 * ascii.c: Comment fixes.
11407 (ascii_line_vert) Fixed overly aggressive range check.
11409 * display.c: Removed dead code.
11411 * list.q: Turn debugging on.
11412 (flush_table) New debug code.
11414 * sfm-read.c: (read_value_labels) malloc's the structure before
11415 trying to assign to its members.
11417 * sfm-write.c: Comment fix.
11419 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
11421 (output_table) No arguments anymore--gets them through `som'
11422 global. New debug code. In crushed tables, now sets `htv' as
11423 well as `hv' to avoid bad confusion later.
11424 (dump_crush_page) New debug code.
11426 * som-low.c: (som_dump_crush_page) New debug code.
11428 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
11430 All source files: Broke long lines into multiple lines.
11432 * ascii.c: (ascii_close_page) Uses host_system var in place of
11433 HOST_SYSTEM constant.
11435 * cmdline.c: (var syntax_message[]) Broke into
11436 pre_syntax_message[] and post_syntax_message[].
11437 (usage) Outputs both parts, separated by driver list.
11439 * error.h: Fixed broken formatting.
11441 * expr-opt.c: (str_search, str_rsearch) New functions.
11443 * misc.c: (blp_getdelim) Removed. All references changed to
11445 (str_search, str_rsearch) Removed.
11446 (memrmem) New function.
11448 * misc.h: (blp_getline) Removed. All reference changed to
11451 * stat.h: New file.
11453 * filename.c: Includes "stat.h", not <sys/stat.h>.
11454 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
11456 * output.c: (outp_list_classes) Changed output formatting.
11458 * sfm-write.c: (write_header) Uses host_system var instead of
11459 HOST_SYSTEM constant.
11460 (write_rec_7_34) Extracts version numbers from the version string.
11463 * sort.c: Includes "stat.h", not <sys/stat.h>.
11465 * str.c: (strcasecmp) Removed.
11467 * title.c: (cmd_document) Uses host_system var instead of
11468 HOST_SYSTEM constant.
11470 * version.c: Generated on-the-fly by the Makefile instead of being
11473 * str.h: Comment fixes. Doesn't substitute for missing memmove or
11475 [!HAVE_STRNCASECMP] Declares strncasecmp().
11477 * version.h: Removed stray character. Comment fixes.
11478 (vars host_system, build_system) New vars.
11480 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
11482 * Most source files: Changed formatting of copyright notice; fixed
11483 FSF address; reformatted to better conform to GNU standards;
11484 comment fixes. Added markups to prevent GNU indent from messing
11485 up my beautiful formatting :-).
11487 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
11488 that GNU indent markups can be passed through without problems.
11490 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
11492 * get.c: Turned off debugging.
11494 * glob.c: (init_glob) Turned on save-file compression by default.
11496 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
11497 compression than was possible in save files.
11499 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
11501 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
11503 * frequencies.q: Removed Fiasco extensions. Updated calculation
11504 algorithms. Polished output format.
11505 (struct frq_info_struct) Removed members `max_degree', `min_n',
11506 all references removed.
11507 (macro frq_extensions) Removed.
11508 (static vars min_n, max_degree) Removed, all references removed.
11509 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
11510 calculate `min_n', `max_degree'.
11511 (postcalc) Passes new arg to dump_statistics().
11512 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
11514 (dump_condensed) Adds variable name title.
11515 (sum_freqs) Removed.
11516 (calc_stats) Updated calculation algorithm.
11517 (dump_statistics) Removed warning for too-few observations.
11518 Changed table formatting. Adds variable name title if passed new
11521 * output.h: Comment fix.
11523 * recode.c, sample.c, sort.c: Disabled debug code.
11525 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
11526 Improved debug code.
11528 * var.h: (enum series frq_*) Removed Fiasco extensions.
11530 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
11532 * command.c: Added PROCESS IF to command table.
11534 * Lots & lots of places, removed checks for NULLs preceding calls
11535 to free_expression(), which itself checks.
11537 * descript.q: Removed Fiasco extensions. Removed optimizations
11538 for non-weighted active files. Implemented some options.
11539 Finished polishing output format. Comment fixes. Merged
11541 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
11542 max_degree, min_n) Removed.
11543 (macro dsc_extensions) Removed.
11544 (struct dsc_info_struct) Removed `min_n' member, all references
11546 (internal_cmd_descriptives) Removed calculation of min_n,
11547 max_degree. Only deals with one `calc' routine instead of two
11549 (precalc) Eliminated redundancy. Updated for changes to
11550 descriptives_proc structure.
11551 (calc) Moved here from `descript.g'. Rewritten to calculate
11552 statistics via `moments about the mean' rather than by summing,
11553 summing squares, summing cubes, and so on.
11554 (postcalc) Rewritten for new-style statistical calculation.
11555 (display) Removed support for displaying variables across rows.
11556 No longer crushes the descriptives table. Removed ancient code.
11557 Added display of N, by variable and listwise.
11559 * descript.g: Removed; merged into `descript.q'.
11561 * expr-evl.c: (evaluate_expression) Now returns a double. For
11562 numeric results, it returns the result as well as storing it in
11563 the passed `value' structure if non-NULL. For string results it
11564 just returns 0.0 and it must be passed non-NULL. Many references
11565 to this function were optimized by use of this change, especially
11566 but not exclusively in `compute.c'.
11568 * frequencies.g: Comment fix.
11570 * glob.c: (glob var process_if_expr) New global var.
11572 * postscript.c: (static var option_tab[]) Corrected entry for
11574 (postopen) Sets x->size to x->prop_size.
11575 (ps_text_set_font_by_name) Sets font size as well as typeface for
11576 PROP and FIXED fonts.
11578 * sel-if.c: (cmd_process_if) New function.
11580 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
11581 (sfm_write_dictionary) Sets `n_cases' to 0.
11582 (sfm_write_case) Increments `n_cases'.
11583 (sfm_close) Attempts to seek the system file back to the header
11584 and write the number of cases in its proper slot.
11586 * som-frnt.c: (som_insert_table) Masks off expansion options since
11587 only SOPT_X_NORM seems to work sensibly.
11589 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
11590 with a `fixed' value of 2.
11592 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
11594 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
11595 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
11597 * var.h: (enum series dsc_*) Removed Fiasco extensions.
11598 (struct descriptives_proc) Removed `miss_noweight'; new members
11599 `X_bar', `M2', `M3', `M4', `min', `max'.
11601 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
11603 * vfm.c: (close_active_file) Cancels PROCESS IF.
11604 (write_case) Doesn't process cases unselected by PROCESS IF.
11606 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
11608 * glob.c: (glob var err) Removed.
11610 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
11611 doesn't have to take into account number of value labels since
11612 they're in a subtable anyway. Also, doesn't display more than 10
11613 value labels since we can't yet break pages in subtables.
11615 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
11617 * som-frnt.c: (som_change_table_size) Simple change for elegance
11618 that shouldn't change behavior.
11619 (som_set_value) Comment fix.
11621 * som-high.c: (som_submit_table) Message fix.
11623 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
11625 * command.c: Added SYSFILE INFO to command table.
11627 * file-handle.q: (fh_handle_filename) New function.
11629 * get.c: (save_trns_proc) Fixed a bug in padding of output data
11632 * main.c: (parse) New return value for command functions, -3.
11634 * misc.h: Comment fix.
11636 * output.h: Comment fixes.
11637 (macro COMPONENTS) Removed.
11639 * postscript.c: (write_text) Modified literal_chars[] so that `('
11640 and ')' are not written to the output in strings as literals.
11642 * sfm-read.c: (sfm_read_dictionary) New argument.
11643 (read_header) New argument. Sets the information structure's
11644 values from the header information.
11645 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
11646 bizarre Checker problem, I guess.
11647 (read_variables) Proper cleanup on lossage.
11649 * sfm.h: (struct sfm_read_info) New struct for use by
11650 sfm_read_dictionary().
11652 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
11653 currently used just for tables that can be dynamically resized and
11654 thus have to be allocated with arena_malloc() instead of
11655 arena_alloc(). All references changed.
11656 (som_change_table_size) New function.
11657 (som_insert_table) Bugfix: now inserts `cell', not `c'!
11659 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
11660 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
11663 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
11665 (draw_intersection) Now takes an argument specifying the table in
11666 question. All references changed.
11667 (draw_table_cell) New function.
11668 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
11669 (som_get_table_size) Many nice new explanatory comments.
11670 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
11672 * som.h: New enum series SOM_CREATE_* for use as create flags with
11673 som_create_table().
11675 * str.h: Moved a comment here from TODO.
11677 * sysfile-info.c: New file. Reference implementation.
11679 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
11681 * command.c: Added RENAME VARIABLES to table of commands.
11683 * data-in.c: (dls_error) Sets `cust_field'.
11684 (parse_N) Message fix.
11685 (parse_day_count) New function.
11686 (to_roman) Never outputs VX as a `short form' of V.
11687 (parse_month) Fixed parsing of Roman numerals.
11688 (parse_trailer) Message fix.
11689 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
11690 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
11691 the date is invalid.
11692 (parse_SDATE) Fixed swapped day, year.
11693 (parse_JDATE) Fixed bug for dates in 1582.
11694 (parse_DTIME) Allows days not between 1 and 31.
11695 (parse_numeric) Makes local copy of f.type for easier usage.
11698 * data-out.c: (convert_F) When outputting as scientific, properly
11699 sets f.type as fp->type.
11700 (insert_commas) Fixed operator precedence problem with setting of
11701 nitems. Changed strcpy to memcpy (no null terminator).
11702 (convert_date) Fixed FMT_JDATE: added 1900 to year.
11703 (convert_CCx) Essentially rewritten, but now it works.
11705 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
11706 feature of Fiasco).
11707 (display_documents) Implemented.
11709 * error.c: (glob var cust_field) New var.
11710 (vmsg) Displays cust_field as part of message classes DE and DW.
11712 * formats.c: (debug_print) Fixed to compile under updated
11715 * get.c: (cmd_get, cmd_save_internal) Close file handle on
11718 * misc.c: (parse_format_specifier) Formatting fix.
11720 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
11721 `n_rename' for clarity.
11722 (cmd_modify_vars) Initializes `forward' and `positional' at
11723 appropriate times. Frees lists of vars to rename on failure.
11724 Comment fix. Frees memory on success.
11725 (rearrange_dict) Simplified `for' loop condition.
11727 * rename-vars.c: New file (reference implementation).
11729 * set.q: (internal_cmd_set) Fixed `emu' test condition.
11731 * sfm-read.c: (read_header) File label is created only if file
11732 label in file is not blank.
11733 (read_variables) Initializes `dict' local variable.
11734 (read_documents) Proper behavior on lossage.
11736 * sfm-write.c: (write_header) Doesn't blank out the file label
11737 (why was this here to begin with?!)
11739 * temporary.c: (save_dictionary) File label is copied only if
11740 non-NULL. Doesn't try to xstrdup() dictionary documents.
11741 Adapted so as to not irritate Checker.
11742 (free_dictionary) Only destroys var_by_name if non-NULL.
11744 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
11745 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
11746 lines to the document, indents the document. Also, it works now.
11747 (add_document_line) New function.
11749 * var.h: (struct dictionary) Reordering.
11751 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
11752 bits if it was allocated to begin with.
11754 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
11756 * command.c: Added MODIFY VARS to list of commands.
11758 * configure.in: Updated custom macros for autoconf 2.12. Removed
11759 mmap reference; fixed termcap library reference.
11761 * display.c: (display_variables) Fixed a few bugs although it's
11762 still not well written.
11764 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
11765 (induce_segfault) Calls chkr_disp_call_chain() instead of
11766 inducing an actual SIGSEGV.
11768 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
11769 str_search() and str_rsearch(). Fixed tests for matches on
11770 OP_INDEX and OP_RINDEX.
11772 * filename.c: (good_getcwd) Removed as the new libc for Checker
11773 doesn't contain this bug, apparently.
11775 * misc.c: (str_search, str_rsearch) Changed order of arguments for
11776 consistency with GNU memmem.
11777 (blp_getdelim) Changed `len' from `int' to `size_t'.
11779 * modify-vars.c: Reference implementation.
11781 * som-frnt.c: (zero_length) New global var.
11782 (som_create_table) Message fix.
11784 * som.h: Added gcc attributions to som_set_text(),
11785 som_output_text() prototypes. blank_line() refers to
11786 zero_length[] instead of a literal null string to suppress gcc
11789 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
11790 (allocate_cases) Decrements x_max so the last element of x[] can
11791 be used by the algorithm.
11793 * var.h: Changed minor details of `variable' declaration.
11794 (struct modify_vars_proc) New struct.
11795 (struct variable) Added field p.mfv.
11797 * vars-atr.c: Comment fix.
11799 * vars-prs.c: (fill_all_vars) More optimal implementation.
11801 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
11802 character, which it shouldn't have to do but printf() seems to
11803 read the null byte even though I supply a maximum length...
11805 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
11807 * command.c: Removed command alias X for QUIT.
11808 (parse_cmd) Fixed comment parsing.
11810 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
11812 (read_record) Fixed references to len, size.
11813 (dfm_get_record) Restructured.
11815 * file-handle.h: (struct file_handle) Field `lrecl' now of type
11818 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
11821 * modify-vars.c: New file. Not complete.
11823 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
11826 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
11827 problems caused by int/size_t differences.
11829 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
11832 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
11833 being compared were of equal length.
11835 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
11837 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
11839 * lexer.c: (get_dotted_rest_of_line) New function.
11841 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
11844 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
11845 type 6 records. Frees the dictionary properly.
11846 (read_header) Initializes the dictionary instead of letting
11847 read_variables() do it. Sets the dictionary file label from the
11849 (read_documents) New function.
11851 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
11852 write type 6 record if appropriate.
11853 (write_header) Writes file label from dictionary.
11854 (write_documents) New function.
11856 * temporary.c: (save_dictionary, restore_dictionary,
11857 free_dictionary) Properly handle new fields in dictionary struct.
11859 * title.c: (get_title) Returns after failure().
11860 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
11861 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
11863 * var.h: (struct dictionary) New fields `label', `n_documents',
11866 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
11868 * command.c: Added FILTER to list of commands.
11870 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
11873 * get.c: (cmd_save_internal) Removed weighting code since it's now
11874 handled by sfm-write.c. Properly commented out debug code.
11876 * glob.c: (glob var weighting) Removed.
11878 * sel-if.c: Comment fixes.
11879 (cmd_filter) New function.
11881 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
11882 (sfm_read_dictionary) Sets weighting variable direct in the
11883 created dictionary now. (Apparently we previously didn't support
11885 (read_header) Sets weight_index field in sfm_fhuser_ext from
11886 header read from disk.
11888 * sfm-write.c: (sfm_write_dictionary) Comment fix.
11889 (write_header) Now sets the weighting in the header from the
11890 passed primary dictionary instead of from the sfm_write_info.
11892 * sfm.h: (struct sfm_write_info) Removed field `weight'.
11894 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
11895 broke on boundary conditions.
11897 * var.h: (struct dictionary) New fields `weight_var',
11898 `weight_index', and `filter_var'.
11899 (glob var weighting) Removed. This is now part of struct
11900 dictionary. All references changed; the less mechanical changes
11901 are described above.
11903 * vars-atr.c: (find_dict_variable) New function.
11905 * vfm.c: (static var filter_index) New variable.
11906 (open_active_file) Initializes filter_index from default_dict.
11907 (write_case) Calls proc_func() only if the filter variable is
11908 nonzero; this implements FILTER behavior.
11910 * weight.c: (static var weight_varname) Removed.
11911 (cmd_weight) Modified default_dict instead of glob vars.
11912 (update_weighting) Changed the signature to modify a dictionary
11913 instead of glob vars. Now returns the weighting variable.
11914 (get_weighting_variable) Removed; its function is absorbed by
11915 update_weighting().
11916 (stop_weighting) Operates on a dictionary now.
11918 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
11920 * sort.c: Removed debugging info from messages.
11921 (do_external_sort) Cleans up after itself by deleting the
11922 temporary directory on failure. (On success it is deleted by the
11924 (allocate_cases) Removed debug code. Added clean up code.
11925 (output_record) Removed debug code.
11926 (merge) Added code to close all the input files that are currently
11927 open. This is a likely location for bugs, because I'm not sure
11928 about boundary conditions. Removed an unnecesary heap_delete().
11929 (merge_once) Removed input file "optimization" that in fact
11930 screwed up the rest of the code. Message and comment fixes.
11932 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
11934 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
11936 * heap.c: (heap_delete) New argument.
11938 * sort.c: Finished implementation of external sort.
11940 * vfm.c: (read_from_disk) Returns after a disk error.
11942 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
11944 * sort.c: (static var state) Removed.
11945 (static vars max_handles, tmp_basename, tmp_extname,
11946 huffman_queue) New variables.
11947 (do_external_sort) Moved most code to new functions.
11948 Creates huffman_queue.
11949 (allocate_file_handles, allocate_cases) New functions.
11950 (static vars run_no, run_length, file_index, case_count) New
11952 (output_record) Returns success. Now really writes to the output
11954 (begin_run, end_run) New functions.
11955 (write_initial_runs) Returns success. Initializes run_no to -1.
11956 Calls begin_run(), end_run() at appropriate times. Outputs debug
11958 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
11960 (merge) New function.
11962 * heap.c, heap.h: New files. Hopefully in near-final form.
11964 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
11966 * glob.c: Added write_active_file to global vars.
11968 * sort.c: Several new miscellaneous static variables.
11969 (cmd_sort_cases) Big comment fix.
11970 (perform_case_2) Renamed `do_external_sort' and completely
11972 (case_2_proc_func) Removed.
11973 (output_record, write_initial_runs, write_to_sort_cases,
11974 compare_record) New functions.
11976 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
11978 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
11980 * sort.c: (perform_case_2) Changed the method for allocation of
11981 lots of memory--now allocates one case at a time in hopes that
11982 more cases can be allocated with heavily fragmented memory.
11984 * var.h: (write_active_file) New global var.
11986 * vfm.c: (procedure, close_active_file, write_case,
11987 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
11988 arguments to procedure() to be NULL. All references to
11989 procedure() that made use of dummy functions were changed to NULL
11991 (open_active_file) If write_active_file is non-NULL, the output
11992 device becomes DEV_PGM (a new enum).
11993 (close_active_file) Sets write_active_file to NULL.
11994 (read_from_memory) Comment fix.
11995 (record_case) Calls write_active_file() when the output device is
11998 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
12000 * sort.c: New file.
12002 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
12003 Fixed checking for duplicate varnames.
12004 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
12006 (autorecode_trns_free) Destroys hash tables for each recoding
12008 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
12010 * command.c: Added SORT CASES to cmd_table.
12011 (null_func, null_int_func) Prototyped.
12013 * descript.g: (calc_weight, calc_noweight) Computes own case
12016 * frequencies.q: (dump_statistics) Fixed problem with
12017 too-few-cases warning message.
12019 * get.c: (cmd_save_internal) Handles weighting properly.
12021 * hash.c: (hsh_dump) Output format changed.
12022 (force_hsh_insert) Actually works now, prototype changed.
12024 * list.q: (static var case_num) New variable.
12025 (cmd_list) Initializes case_num.
12026 (list_cases) Increments case_num.
12028 * var.h: Added definitions for SORT CASES. Comment fixes.
12030 * vfm.c: Some definitions moved to new file vfmP.h. Comment
12031 fixes. `active' renamed vfm_active, `rep' renamed
12032 vfm_replacement, all references changed.
12033 (procedure) The procfunc no longer receives a case number. All
12034 references changed.
12035 (write_case) Subtle reordering.
12036 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
12039 * weight.c: (get_weighting_variable) New function.
12041 * vfmP.h: New file with definitions from vfm.c.
12043 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
12045 * command.c: (FILE_TYPE_okay) Commented out some tests because
12046 they're clumsy and not yet needed.
12048 * var.h: Most *_trns structures moved to their respective source
12049 files. Some were moved into a new file, do-ifP.h. Comment fixes.
12050 (union any_trns) Changed to a typedef for trns_header.
12051 (struct input_program_pgm) Removed.
12053 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
12054 was allocated in the first place.
12056 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
12058 * autorecode.c: New file.
12060 * command.c: Added AUTORECODE to command table; re-enabled SET.
12062 * data-out.c: (convert_F) Handles infinities and NaNs properly.
12064 * error.c: (vmsg) Comment fixes.
12066 * hash.c: Comment fix.
12067 (hashpjw_d) New function.
12068 (hashpjw) Reimplemented as call to more general function
12070 (internal_comparison_fn) Initializes pointers properly.
12071 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
12072 (force_hsh_insert, force_hsh_find) New debugging wrapper
12075 * main.c: (main) Message fix.
12077 * output.c: (outp_read_devices) Message fix.
12079 * set.q: Comment fixes.
12080 (custom_results) Implemented Wnd/X form of subcommand.
12081 (set_routing) New function.
12082 (internal_cmd_set) Implemented ERRORS, MESSAGES.
12084 * settings.h: (SET_ROUTE_*) New enum series.
12085 (set_results) Renamed set_results_file, all references changed.
12086 (set_messages) Removed.
12087 (glob vars set_errors, set_messages, set_results) New vars.
12089 * title.c: (get_title) Remembers to xstrdup() the result of
12090 get_rest_of_line().
12092 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
12094 (union any_trns) New element `arc'.
12096 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
12098 * command.c: (output_line) Removed references to set_screen.
12100 * error.c: (static var terminating) New var.
12101 (hcf) Sets terminating to 1.
12102 (vmsg) If terminating is nonzero, does not attempt to call hcf().
12103 This prevents an infinite loop if an error occurs within hcf().
12105 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
12106 statement circumlocution with `case 42000' trick.
12107 (evaluate_expression) New support for OP_STR_MIS.
12109 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
12110 statement circumlocution with `case 42000' trick.
12111 (dump_node) Handles OP_STR_MIS.
12113 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
12114 variables exceptions.
12115 (parse_function) Message fix.
12116 (ops[]) Added OP_STR_MIS.
12118 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
12120 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
12122 * glob.c: Removed set_scrnfile glob var.
12123 (init_glob) set_errorbreak set to 0 by default.
12125 * groff-font.c: Changed included files.
12126 (groff_read_font) Initializes font_arena local var correctly.
12127 (default_font) New function.
12129 * output.c: Comment fixes.
12130 (glob var disabled_devices) New variable.
12131 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
12133 [GLOBAL_DEBUGGING] (reentrancy) New function.
12134 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
12135 outp_iterate_enabled_drivers) Calls to reentrancy().
12136 (destroy_list) New function.
12137 (outp_done) Moved code to destroy_list().
12138 (parse_options) Parses `listing', `screen', `printer' options
12140 (configure_driver) Sets new `device' member of driver.
12141 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
12143 * output.h: Comment fixes. New enum series OUTP_DEV_*.
12144 (struct outp_driver_struct) New member `device'.
12146 * postscript.c: (find_encoding_file) Doesn't display its own error
12148 (default_encoding) New function.
12149 (switch_font) Calls default_encoding() if no encoding can be
12151 (text) Makes up a character metric if none exists for the desired
12153 (load_font) Properly copies a fallback filename. Calls
12154 default_font() for a font if none at all are known.
12156 * set.q: Comment fixes. Removed OUTPUT subcommand.
12157 (custom_listing) Calls outp_enable_device() to enable/disable
12159 (turn_screen_on) Removed.
12160 (internal_cmd_set) Calls outp_enable_device() to enable/disable
12161 screen, printer devices.
12163 * settings.h: Comment fixes.
12164 (glob vars set_output, set_printer, set_screen, set_scrnfile)
12167 * som-high.c: (som_submit_table, som_eject_page) Use
12168 outp_iterate_enabled_drivers() instead of iterating
12169 outp_driver_list directly.
12171 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
12173 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
12174 (parse_string_as_format) Handles new formats.
12175 (parse_numeric) Now handles DOT and PCT formats.
12177 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
12179 (convert_date) Handle EDATE and SDATE formats.
12180 (convert_CCx) Now if there's not room for the currency characters,
12181 converts it as F format if it's positive instead of giving up
12182 quickly. Also fixed save-and-restore bug with decimal point
12184 (convert_format_to_string) Handles new formats.
12186 * misc.c: (formats[]) Added new formats.
12187 (convert_fmt_ItoO) Supports new formats.
12189 * sfm-read.c: (parse_format_spec) Supports new formats. Better
12190 data checking. New argument, all references changed.
12192 * sfm-write.c: (write_format_spec) Supports new formats.
12194 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
12197 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
12199 * cmdline.c: Comment fixes.
12200 (parse_command_line) Changed return type to void.
12202 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
12204 (parse_numeric) Handles international numbers (comma as decimal
12205 point). Some reformatting.
12207 * data-list.c: (parse_free) Default output format is now
12208 set_format instead of hard-coded F8.2.
12209 (read_from_data_list_list) Emits error message on undefined data
12210 only if set_undefined is nonzero.
12212 * data-out.c: (convert_E) Changes decimal point from period to
12213 comma if appropriate. Restructured. Better comments.
12214 (convert_F) Changes decimal point from period to comma if
12216 (insert_commas) Major bug with handling of negative values fixed.
12217 Also, inserts periods instead of commas if appropriate.
12218 (convert_CCx) New function.
12219 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
12220 (num_to_string) Changed `.' to set_decimal.
12222 * dfm.c: Comment fixes.
12223 (dfm_close) Frees ext->line even in inline_file.
12224 (open_inline_file) New function.
12225 (open_file_r) When opening the inline file: now properly
12226 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
12228 (read_record) Calls fh_close_handle() instead of dfm_close() to
12229 close the inline file. Makes a copy of the line getl_buf to avoid
12230 interlock problems.
12231 (dfm_get_record) Restructured. Now checks the return value of
12233 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
12234 checking for use of inline file. No longer tries to close inline
12237 * error.c: (glob var error_already_flagged) New var.
12238 (vmsg) Message change. Now checks max number of errors/warnings,
12241 * file-handle.q: (fh_handle_name) Now allows closing of
12243 (fh_init_files) Reformatted.
12245 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
12247 * getline.c: (getl_include) Fixed bug that popped up when called
12248 when file queue was empty.
12249 (read_console) Resets error_count, warning_count,
12250 error_already_flagged to zero.
12252 * glob.c: Many changes to update list of variables.
12253 (init_compat_dependent) Now this function is called whenever
12254 `compat' changes. It now sets set_seed only if it hasn't
12255 previously been referenced. It now calls
12256 lex_init_compat_dependent().
12258 * include.c: (cmd_include_at) Frees temporary buffer instead of
12260 (cmd_include) Doesn't make copy of include file name.
12262 * lexer.c: Comment fixes.
12263 (init_lex) Moved some code into new function
12264 lex_init_compat_dependent().
12265 (lex_init_compat_dependent) New function.
12266 (hex_val) Simplified.
12267 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
12269 * main.c: Comment fixes.
12270 (main) Reformatted.
12272 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
12273 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
12274 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
12275 (setup_randomize) Sets set_seed_used.
12277 * set.q: Comment fixes.
12278 (custom_results) Conditionalizes on `compat'.
12279 (custom_log) Calls custom_journal().
12280 (set_ccx) New function.
12281 (cmd_set) Calls init_compat_dependent() when `compat' changes.
12282 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
12283 when set_decimal changes. Range-checks values for MITERATE,
12284 MNEST. Message fixes.
12286 * settings.h: Comment fixes.
12287 (struct set_cust_currency) New struct.
12288 (set_cc[], set_grouping, set_seed_used) New global vars.
12290 * var.h: (FMT_CCA...FMT_CCE) New output formats.
12291 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
12293 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
12295 * glob.c: Revised variables to correspond to settings.h.
12296 (init_glob) Initializes variables from settings.h properly.
12298 * set.q: Began long-overdue major revision to correspond to new
12299 philosophy. Most code changed.
12301 * settings.h: Mostly changed; reorganized, reordered, large new
12304 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
12306 * get.c: (cmd_save_internal) No longer forces compression off.
12308 * sfm-read.c: (read_compressed_data) If eof is reached when
12309 reading a new instruction octet, only signal error if we're in the
12312 * sfm-write.c: (COMPRESSION_BIAS) New #define.
12313 (struct sfm_fhuser_ext) New member `end'.
12314 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
12315 (ensure_buf_space) New function.
12316 (sfm_write_case) Reimplemented in order to support compression.
12317 (sfm_close) Writes out the remaining contents of the compression
12320 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
12322 * command.c: Defined SAVE and XSAVE commands in command table.
12324 * common.h: second_lowest_value is of type flt64, not double.
12326 * file-handle.h: Comment fix.
12328 * get.c: Comment fixes.
12329 (static var `trns') New.
12330 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
12331 cmd_save_internal, cmd_save, cmd_xsave) New functions.
12332 (dict_delete_run) Clears the variables and frees them now.
12333 (trim_dictionary) Sets default for compression.
12334 On KEEP subcommand, frees deleted variables as well as clearing
12335 them. Finally got the sense of the test for deleting all
12337 [DEBUGGING] (dump_dict_variables) Message fix.
12339 * glob.c: (init_glob) set_compression set to 1 by default.
12341 * list.q: Properly #includes config.h.
12343 * misc.h: New macro REM_RND_UP.
12345 * settings.h: Comment fix.
12347 * sfm-read.c: (structs sysfile_header, sysfile_format,
12348 sysfile_variable; inline function bswap_int32) Moved to new file
12350 (corrupt_msg) [__CHECKER__] No longer induces segfault.
12351 (sfm_read_dictionary) Fixed bug caused by failing to initialize
12353 (read_machine_flt64_info) Fixed some problems caused by confusion
12354 between flt64 and double types.
12355 (read_header) Message fix.
12356 (read_variables) Fixed set of cases in which we byte-swap sv.print
12357 and sv.write. Fixed confusion of flt64 and double.
12359 * sfm.h: (struct sfm_write_info) New.
12361 * som-high.c: (som_draw_title) Properly frees `s'.
12363 * temporary.c: (save_dictionary) Comment fix.
12365 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
12366 (struct trns_header) Formatting fix.
12367 (struct save_trns) New.
12369 * vars-atr.c: (discard_variables) Comment fix.
12371 * sfm-write.c: New file, baseline release.
12373 * sfmP.h: New file, baseline release.
12375 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
12377 * cmdline.c: (parse_command_line) `--version' output updated.
12378 (glob var syntax_message[]) Added my e-mail address.
12380 * file-handle.q, lexer.c, vfm.c: Changed many instances of
12381 `illegal' to `invalid'.
12383 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
12384 uncompression buffer.
12385 (sfm_close) Frees decompression buffer.
12386 (sfm_read_dictionary) Initializes decompression buffer.
12387 (buffer_input, read_compressed_data) New functions.
12388 (sfm_read_case) Restructured; now calls read_compressed_data() to
12389 handle compressed system file data.
12391 * var.h: Comment fix.
12393 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
12395 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
12398 * get.c: New comments. New static var `get_file'.
12399 (cmd_get) Now fully implemented. Calls discard_variables();
12400 initializes fv and lv for all variables; new debug code; sets
12401 up the dictionary; sets up the input program.
12402 (read_from_get, cancel_get) New functions.
12404 * sfm-read.c: Comment fixes.
12405 (sfm_close) New static function.
12406 (sfm_read_dictionary) Properly sets up the class of the
12407 file_handle. No longer cares what size the data is in records of
12408 type 7. Also, on failure, properly cleans up the file_handle and
12409 free()s some stuff.
12410 (read_variables) No longer thinks it knows `nval' of the
12411 dictionary. Now sets p.get.fv, etc., instead of speculatively
12413 (read_value_labels) Fixed off-by-one error in indexing of
12415 (sfm_read_case) New function.
12416 (sfm_r_class) New static var.
12418 * var.h: (get_proc) New struct.
12419 (struct variable) New member p.get.
12421 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
12423 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
12424 the manual's meaning.
12425 (rename_variables) New function.
12426 (trim_variables) Doesn't try to parse MAP any more. Removed debug
12427 code. Now properly reorders the dictionary on the KEEP keyword.
12429 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
12430 garbage collection.
12432 * vars-atr.c: (clear_variable) New argument `dictionary *'.
12433 (rename_variable) New function.
12434 (free_val_lab) Reformatted.
12436 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
12438 * var.h: Reindented entire file. Comment fixes.
12439 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
12441 (glob var default_dict) New.
12442 (struct indirect_dictionary) Removed.
12444 * Many other source files were changed to add `default_dict.'
12445 before all references to the dictionary of the active file.
12447 * vars-atr.c: (make_indirect_dictionary) Removed.
12449 * glob.c: Reindented all variable declarations. Updated for
12450 changed var.h. Comment fixes.
12452 * temporary.c: (restore_dictionary, save_dictionary) Simplified
12453 because now we can mainly copy dictionary structs.
12455 * vars-prs.c: (is_dict_varname, parse_dict_variable,
12456 parse_variables) Takes dictionary instead of indirect_dictionary
12458 (parse_variables) Instead of calling make_indirect_dictionary,
12459 just sets DICT to &default_dict if DICT is NULL. Of course, lots
12460 of `*dict.' references had to be changed to `dict->'. Removed
12463 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
12465 * get.c: Added GTSV_OPT_* series of enums.
12466 (trim_dictionary, dict_delete_run) New functions.
12467 [DEBUGGING] (dump_dict_variables) New function.
12468 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
12469 [DEBUGGING] Calls dump_dict_variables() to display results.
12471 * glob.c: (cmp_variable) Now a public function declared in var.h.
12473 * sfm-read.c: Turned off debug code. Comment fixes.
12474 (read_machine_int32_info, read_machine_flt64_info) New functions
12475 to parse type 7 records.
12476 (sfm_read_dictionary) Properly byteswaps several fields now.
12477 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
12478 records. [DEBUGGING] Dumps dictionary.
12479 (read_variables) Sets `index' field of variables created properly.
12480 Constructs avl tree of variables in dictionary. [DEBUGGING] No
12481 longer dumps dictionary.
12482 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
12484 [DEBUGGING] (dump_dictionary) No longer stubbed out.
12486 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
12487 var before destroying any variables just to save a little time.
12489 * var.h: (struct variable) Reordered in order to make name[] the
12490 first member; this makes pointers to `variable' pointers to the
12491 variable name, simplifying avl trees, etc.
12492 (struct indirect_dictionary) New struct.
12494 * vars-atr.c: (find_variable) Rewritten for efficiency.
12495 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
12497 (is_varname) Rewritten for efficiency.
12498 (parse_variables) New argument, which is a `dictionary *'. All
12499 references changed. This function now reads variable names from
12500 the dictionary passed, or from the default dictionary if NULL.
12502 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
12504 * misc.h: Added new macro DIV_RND_UP to perform integer division,
12505 rounding up. Changed many references to ROUND_UP to use this
12508 * sfm-read.c: Includes avl.h.
12509 (corrupt_msg) Induces a segfault under Checker.
12510 (macro assertive_bufread) New. Many references to bufread() now
12512 (sfm_read_dictionary) Split up into several functions. Added code
12513 to read dictionary records following the the type 2 records. Not
12514 quite complete. New variable `var_by_index'.
12515 (read_header, read_variables) New functions extracted from
12516 sfm_read_dictionary().
12517 (read_value_labels) New function.
12518 (bufread) Checks ferror() if fread() doesn't return the expected
12519 value; if ferror() is zero it's just EOF.
12520 (dump_dictionary) Stubbed out.
12522 * BTW: The source code now exceeds 50000 lines!
12524 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
12526 * command.c: Added GET to cmd_table[].
12528 * list.q: Removed reference to alloca headers.
12529 (cmd_list) Gave prototype.
12531 * sfm-read.c: Added DEBUGGING comments.
12532 (sfm_read_dictionary) Checks bias correctly. Sets
12533 dict->var_by_name to NULL. Calculates long_string_count
12534 correctly. realloc's dict->var[] array to minimum size.
12535 [DEBUGGING] Calls dump_dictionary.
12536 [DEBUGGING] (dump_dictionary) New function.
12538 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
12539 (restore_dictionary) If the dictionary contains a non-NULL
12540 var_by_name, uses that instead of generating one.
12541 (free_dictionary) Destroys var_by_name.
12543 * var.h: (struct dictionary) Added field `var_by_name'.
12545 * get.c: New file, not complete.
12547 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
12549 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
12550 (parse_num_or_range) New function.
12551 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
12552 <n> THRU HIGH missing values.
12554 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
12555 __attribute__((const)).
12557 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
12559 * sfm-read.c: Finished reference implementation.
12561 * sfm.h: Includes var.h.
12563 * var.h: Comment fixes.
12564 (struct `variable') Reordered some fields.
12566 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
12567 constants added previously.
12569 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
12571 * common.h: Comment fixes. Added declaration of
12572 `second_lowest_value' as variable or macro. Made `compat_type',
12573 `pgm_state_type' into anonymous enums.
12575 * display.c: Comment fix.
12577 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
12579 [!defined SECOND_LOWEST_VALUE] Added definition for
12580 `second_lowest_value' global var.
12581 (compat, pgm_state global vars) Changed types to `int'.
12582 (init_glob) Initializes `second_lowest_value'.
12584 * sfm-read.c: Continued work, not complete.
12586 * var.h: Added new MISSING_* constants to handle LOWEST and
12589 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
12591 * sfm-read.c: New file, not complete.
12593 * cases.c: (vec_insert) Changed vector expansion algorithm.
12594 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
12595 mucking up the RECODE transformation in particular.
12596 (envector) Harmless change in notation.
12598 dfm is now fairly well tested again.
12599 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
12601 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
12603 * recode.c: Comment fix.
12605 * sfm.h: Interface should be fairly final now, or at least for a
12608 * vfm.c: [DEBUGGING] (index_to_varname) New function.
12609 (open_active_file) [DEBUGGING] Translates ccase indices into
12610 variable names now to make it easier to understand what's really
12613 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
12615 * data-in.c: Comment fix.
12617 * data-list.c: Includes dfm.h.
12618 (do_reading) Uses new function dfm_push_cust().
12620 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
12621 `return 1;' at end.
12623 * file-handle.h: Completely changed. Some parts split off into
12624 new file dfm.h. Implemented in file-handle.q.
12625 (enum FH_*) Removed.
12626 (struct fh_ext_class) New struct.
12627 (struct file_handle) Retained only these fields: name, norm_fn,
12628 fn, recform, lrecl, mode. New fields class, ext.
12629 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
12630 close_handle, handle_name) Added `fh_' prefix to name, all
12631 references changed.
12633 * dfm.h: New file, implemented in dfm.c.
12634 (get_record, put_record, fwd_record, bkwd_record, set_record,
12635 get_cur_col) Functions moved from file-handle.h, now prefixed with
12637 (dfm_push_cust) New function.
12639 * sfm.h: New file. Incomplete.
12641 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
12642 interface. Functions reordered, comments changed. Not well
12643 tested, probably full of bugs.
12644 (struct dfm_fhuser_ext) New struct.
12645 (dfm_close) New function.
12646 (open_file_r) Pickier about finding `BEGIN DATA.' line.
12647 (open_file_w) User messages changed.
12648 (get_record) Comment fixed.
12649 (read_record) Increments ext->ln even for inline_file. Calls
12650 dfm_close() for inline_file when `END DATA.' encountered.
12651 (dfm_get_record) Experimental restructuring.
12652 (dfm_push_cust) New function.
12653 (cmd_begin_data) Detects whether the inline file was fully read by
12654 checking whether it is still open; detects whether it was read at
12655 all by checking whether the line number is greater than zero.
12657 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
12658 interface. Functions reordered, comments changed. Not well
12659 tested, probably full of bugs.
12660 (init_file_handle) Removed initializers for obsolete fields, added
12662 (fh_close_handle) Much simpler, now mainly calls the class
12664 (fh_init_files) Renamed inline file internal filename.
12666 * file-type.c: Includes dfm.h.
12667 (read_from_file_type) Doesn't use dfm internal state anymore.
12669 * inpt-pgm.c, print.c: Include dfm.h.
12671 * recode.c: (internal_cmd_recode) Casts strlen() return value to
12672 int in comparison with other int.
12674 * som-high.c: (build_target) Fixed operator precedence problem in
12675 if statement (& versus ==).
12677 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
12679 * dfm.c: (read_record) Can now read fixed-length records; not
12681 (put_record) Can now write fixed-length records; not tested.
12683 * file-handle.h: FH_* defines changed to enums. New enum series
12685 (struct file_handle) New members recform, lrecl, mode.
12687 * file-handle.q: Parser changed.
12688 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
12689 /LRECL subcommands. These are compatible with Windows.
12690 (init_file_handle) Initializes recform, mode fields.
12692 * q2c.c: (get_line) When outputting `!' comment lines, now
12693 increments the output file line number so that `#line' directives
12695 (make_identifier) New function that converts an arbitrary string
12696 into a valid C identifier.
12697 (dump_vars) Calls make_identifier() in two places in order to
12698 suppress some errors for bad identifiers.
12699 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
12700 for NO. Allows numbers to be prefixed by underscores to make them
12701 acceptable C identifiers but still to be parsed as numbers by the
12704 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
12706 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
12708 * dfm.c: Comment fixes. (get_record) Gives error if file handle
12709 was opened for writing.
12710 (open_file_w) New function.
12711 (read_record) Uses strncasecmp if available. Improved error
12712 messages, comments.
12713 (put_record) New function.
12715 * file-handle.h: Moved function comments into dfm.c and
12716 file-handle.q. Comment fixes. Removed declarations of
12717 tilde_expand() and normalize_filename().
12718 (struct file_handle) Changed `open' from boolean to enumerated
12719 field to allow for three states--closed, open for reading, open
12720 for writing--all references changed.
12722 * file-handle.q: Includes filename.h.
12724 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
12725 references changed.
12726 (alloc_line) Makes allowance for line terminator characters in
12728 (print_trns_proc) Now handles OUTFILE, WRITE differences.
12729 (print_space_trns_proc) Handles OUTFILE differences.
12731 * recode.c, sample.c: Comment fixes.
12733 * var.h: (struct print_trns) Changed boolean field `eject' to
12734 bitmapped field `options'; all references changed. New enums
12735 PRT_* for use with this field.
12737 * exception.h, test-exception.c: Removed.
12739 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
12741 * ascii.c: (delineate) Turned off debug output.
12743 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
12746 * data-in.c: (parse_string_as_format) Sets the entire string value
12747 to spaces, not just the short string part of it. Is this correct
12750 * data-out.c: (convert_date) Fixed DATETIME format problems with
12751 decimal places, removed debug code.
12753 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
12754 middle of parsing BEGIN DATA that would cause the lexer to read
12755 from a wild pointer `prog'; now calls new function
12756 preprocess_line() in lexer.c.
12758 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
12760 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
12761 Now call induce_segfault() to induce the segfault.
12762 (induce_segfault) New function.
12764 * expr-opt.c: Comment fix.
12765 (parse_sysvar) New function.
12766 (parse_primary) Added system variable support--calls
12768 (global var ops) Added OP_CASENUM operator.
12770 * expr.h: Comment fixes.
12771 (OP_* enum) added OP_CASENUM operator.
12772 (struct casenum_node) New struct.
12773 (union any_union_union) New member `cas' of type `casenum_node'.
12775 * glob.c: (global var last_vfm_invocation) New var.
12776 (init_glob) Initializes last_vfm_invocation.
12778 * lexer.c: (lookahead) Fixed reversed condition on if statement.
12780 * getline.c: (get_line) Split into get_line() and preprocess_line().
12781 (preprocess_line) New function.
12783 * var.h: Declares last_vfm_invocation.
12785 * vfm.c: (procedure) Sets last_vfm_invocation.
12787 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
12789 * command.c: (parse_cmd) Fixed bad assertion related to
12792 * data-in.c: (parse_month) Implemented to parse months according
12793 to full interpretation of standard.
12794 (to_roman) New function.
12795 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
12796 (parse_weekday) Bug fix (forgot to skip all the day name).
12798 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
12799 up parsing of multirecord data items. Also fixed user message.
12801 * data-out.c: Comment fix.
12802 (year2, year4, convert_date, convert_time, convert_WKDAY,
12803 convert_MONTH) New functions to support time & date output.
12804 (convert_format_to_string) Calls new time & date output routines.
12806 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
12808 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
12811 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
12813 * misc.c: (global var formats) Fixed declarations of DATETIME,
12816 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
12817 the output_char buffer.
12819 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
12820 memory bug. Fixed user messages.
12822 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
12824 * Removed #pragma argsused from lots of places.
12826 * data-in.c: Implemented zoned decimal and time-date formats.
12827 Untested. This is a huge chunk of code--maybe 1000 lines and 50
12830 * data-out.c: Implemented zoned decimal format.
12832 * expr.h: Moved yrmoda() declaration here from exprP.h.
12834 * misc.c: (global var formats) Minor fixes--added
12835 FCAT_SHIFT_DECIMAL to formats N and Z.
12836 (convert_fmt_ItoO) Added support for format Z.
12838 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
12840 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
12842 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
12843 som_check_workspace() that is activated between commands.
12845 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
12848 * list.q: (begin_row) Changed title expansion style from
12849 SOPT_X_VERT to SOPT_X_SHSP.
12851 * som-frnt.c: Now includes `somP.h'.
12852 (som_push_workspace, som_pop_workspace) New functions that, taken
12853 together, form a solution to the recursive table building problem
12854 mentioned yesterday. Surrounded every table output routine
12855 throughout the program with calls to these functions.
12856 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
12857 (som_create_table) Checks that there's an active workspace.
12858 (som_destroy_all_tables, som_crush) Removed.
12860 * som-high.c: (global var som_preserve_tables) Removed, all
12861 references deleted.
12862 (som_submit_table) Checks that there's an active workspace.
12863 (dump_columnated_table) Doesn't columnate tables that would have
12864 just one row per column.
12865 (dump_crush_page, som_dump_crush_page) Removed debugging code.
12866 (som_dump_crush_page) Moved row number labels from left side of
12867 tables to right side.
12868 (som_get_table_size) Added support for SOPT_X_SHSP.
12870 * som.h: New cell expansion type SOPT_X_SHSP.
12872 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
12874 (global var curtab_arena) Moved from som-frnt.c.
12876 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
12878 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
12879 that causes bad location warnings to be suppressed.
12880 (delineate) Saves current font when calling draw_text(); fixed
12881 handling of NULLs when backing up. Also fixed line-wrapping bug.
12883 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
12884 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
12886 * common.c: Added code to cause assertion failure to dump core
12887 when run under Checker.
12889 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
12890 there are still bugs.
12892 * glob.c: (__eprintf) Removed.
12894 * list.q: Inserted som_preserve_tables kluge that prevents tables
12895 from being thrown away due to recursive table building through
12896 som_output_line being called from a transformation during the LIST
12897 procedure invocation. This is a general problem that must be
12898 solved in a better way since it applies to all procedures in
12900 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
12901 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
12903 * numeric.c: Fixed several errors in the form of msg() calls.
12905 * print.c: Updated for use of som.
12906 (dump_table) Reimplemented.
12907 (print_trns_proc) Calls som_eject_page() instead of eject_page().
12908 Calls som_output_text() instead of outs_line().
12910 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
12912 (som_output_text) Function moved from som-low.c. Interface
12915 * som-high.c: (som_preserve_tables) New global public variable
12917 (som_submit_table) Destroys the tables only if som_preserve_tables
12919 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
12920 one subrow per row. Now labels subrows if there's more than one
12922 (dump_crush_table) Added wishlist comment.
12923 (som_eject_page) New public function declared in som.h.
12925 * som-low.c: (som_dump_crush_page) Draws row labels if there's
12926 more than one subrow per row.
12927 (som_output_text) Moved to som-frnt.c.
12929 * som.h: (SOM_TOPT_PRESERVE) Removed.
12931 * title.c: (get_title) Changed interface.
12932 (cmd_title) Changed `title' to `outp_title'.
12933 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
12935 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
12937 * list.q: (flush_table) Conforms to new partial options in
12938 som_submission_form.
12940 * som-high.c: (paginate_horizontally) Changed form of subrow
12942 (build_target) Omits spacing before table if
12943 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
12944 (dump_crush_page) Changed interface. Only trims bottom rule if
12945 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
12946 (dump_crush_table) Handles partial tables.
12947 (output_row_label) New function.
12948 (som_dump_crush_page) Emits subrow number labels. Draws vertical
12949 rule on the right edge of narrow subrows.
12951 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
12952 constants to a series of SOM_TOPT_PARTIAL_* submission options.
12953 All references updated.
12955 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
12957 * misc.c: Comment fix.
12959 * som-high.c: (examine_table) Treats crushed tables separates for
12960 purpose of determining header size.
12961 (paginate_horizontally) Allots space for line numbers in crushed
12962 tables with lots of subrows per row. Calculates the `maximum page
12963 width', the width of the widest horizontal page.
12964 (build_target) Removed trim argument; all references changed.
12965 Stricter assertions. (dump_crush_page) New function.
12966 (dump_crush_table) Reimplemented.
12968 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
12969 (som_dump_crush_page) Reimplemented, interface changed.
12971 * somP.h: Many many new helper macros for use with crushed tables.
12972 (global var som) Removed `tv', `cum_y' members; all references
12973 removed. New members `mpw', `digit_space'.
12975 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
12977 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
12978 variable, changed to constant 1024.
12979 (arena_ca_strdup) Changed `sizeof(a_string)' to
12980 `sizeof(c_string)'.
12981 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
12982 `(c_string *)' to `(char *)'; this fixed some offset problems.
12984 * filename.c: (readlink_malloc) Changed initial allocation from
12986 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
12989 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
12990 &fm->owner in several places.
12992 * som-high.c: (output_table) Changed interface to rest of world.
12993 (examine_crush_table) Removed. Crushed tables are re-broken now,
12994 in preparation for rewrite.
12996 * som.h: Comment fix.
12998 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
13000 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
13001 itself in the cleanup stage.
13003 * descript.q: (display) At least temporarily, changed the table
13004 format to a crushed table.
13006 * list.q: (begin_row) At least temporarily, added horizontal lines
13009 * som-high.c: (examine_crush_table) Sets som.hh to the width of
13010 the horizontal "headers," that is, to the width of the far left
13011 and far right rules.
13012 (justify_pagination) Sets som.th to the width of the widest row
13013 in the crushed table. Fixed inner loop off-by-one error.
13015 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
13018 * somP.h: Comment fix.
13020 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
13022 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
13023 before closing it; also, opens the constructed filename `s'
13024 instead of f->filename.
13026 * postscript.c: Moved initialization of x->loaded, x->prop,
13027 x->fixed, x->current, also the add_encoding() calls, into
13029 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
13030 sets x->last_font to NULL; sets x->next_combo to zero.
13032 * som-high.c: (crushed_row_height) Moved definition farther up.
13033 (som_submit_table) Doesn't calculate line width, font size until
13034 after calling open_page(), to accomodate changes to PostScript
13036 (vert_headers) Removed; equivalent functionality moved to
13037 examine_table(), examine_crush_table().
13038 (justify_pagination) Replaced with different algorithm.
13039 (dump_crush_table) Bugfix that caused tables to fail to be clipped
13040 at the bottom of the page.
13042 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
13044 * command.c: Added cmd_list back into cmd_table.
13046 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
13047 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
13049 * list.q: (flush_table) Updated to new som_submission_form format.
13051 * som-frnt.c: Comment fix.
13053 * som-high.c: Changed `#endif' to `#undef EXTERN'.
13054 (output_table) Calls som_get_table_size() directly; handles
13056 (examine_crush_table) New function; calls vert_headers().
13057 (examine_table) Moved some code into new function, vert_headers().
13058 (justify_pagination) New function.
13059 (dump_plain_table) Removed `static' from `cy'.
13060 (dump_crush_table) New function.
13062 * som-low.c: (som_dump_crush_page) New function.
13064 * som.h: Comment fixes.
13065 (enum SOM_TOPT_CRUSH) New.
13066 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
13067 Temporarily set to zero to make do with LIST procedure.
13069 * somP.h: Re-ordering.
13071 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
13073 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
13075 * somP.h: New file for use by som-high.c, som-low.c.
13077 * q2c.c: Added definition for VME.
13078 (get_line) Now dumps `!' comment lines to the output file
13081 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
13082 set.q: Changed format of `!' comment lines.
13084 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
13086 * All source files: Added copyright notice.
13088 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
13089 longs in msg() calls.
13091 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
13093 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
13095 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
13097 * output.c: (outp_read_devices) Changed criteria for
13098 distinguishing different types of lines.
13100 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
13102 * cmdline.c: Changed syntax message.
13104 * filename.c: (good_getcwd) Bug fix (?).
13105 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
13107 (search_path) Appends DIR_SEPARATOR to directory name only if it
13108 does not already end with one.
13110 * glob.c: Checks STAT_PAGER envvar before PAGER.
13112 * output.c: Checks environment variables instead of just local
13115 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
13117 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
13118 when the pointer passed to the function was within the arena
13119 itself, so that it couldn't properly be set to NULL _after the
13122 * command.c: Re-enabled DISPLAY.
13124 * display.c: Rewritten to handle tables. Untested.
13126 * filename.c: (search_path) Fixed memory leak.
13128 * frequencies.q: (cmd_frequencies) Frees v_variables.
13129 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
13130 (cleanup_freq_tab) New function to garbage collect.
13131 (dump_full) Elegantized.
13133 * main.c: New comment.
13135 * output.h: New tag for tagged quotes: TAG_NEWLINE.
13137 * postscript.c: Comment fix.
13138 (release_fontmap, free_font_entry) New functions.
13139 (ps_init_driver) Sets free_font_entry() as the freefunc for
13140 hashtable `loaded'. Calls release_fontmap() when destroying a
13141 driver; also frees the output filename; also frees the
13142 ps_driver_ext block.
13143 (free_ps_encoding) Frees the filename as well as the encoding
13145 (output_encodings) Frees the line buffer and pops the msg-filename
13147 (read_fontmap) Frees the fontmap filename and the line buffer.
13148 (postopen, preclose) Misc. garbage collection fixes.
13149 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
13150 to NULL; this fixes some output problems.
13151 (text) Handles TAG_NEWLINE. Untested.
13153 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
13154 (som_set_string) Removed. All references changed to
13156 (som_set_text) Rewritten. New interface. More general.
13158 * som.h: Minor format changes.
13159 (struct som_value_cell) Removed; all references changed to
13161 (enums SOT_*) Changed.
13163 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
13165 * command.c: Re-enabled SPLIT FILE.
13167 * postscript.c: Comment fix.
13169 * som.h: Added `SOT_NONE'.
13171 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
13173 * vfm.c: (dump_splits) Reimplemented.
13175 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
13177 * Compiled the project under gcc 2.7.2, which gave some new
13178 warnings. This led to many additions of casts from unsigned to
13179 int sprinkled throughout the code.
13181 * arena.c: Many uses of `unsigned' changed to `size_t'.
13183 * command.c: Added END FILE, END REPEAT to command table.
13184 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
13185 (find_command, FILE_TYPE_okay) Not commented out anymore.
13186 (parse_cmd) Calls FILE_TYPE_okay again.
13187 (output_line) Added calls to som_output_text() to put the line
13188 in the output files.
13190 * common.c: (macro VME) Format changes.
13191 (xstrdup) Asserts that its argument is not NULL.
13193 * data-list.c: Implemented dump_fixed_table().
13195 * inpt-pgm.c: Formatting changes. Comment changes.
13196 (end_case_proc) Renamed end_case_trns_proc.
13197 (cmd_end_file, end_file_trns_proc) New functions.
13199 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
13201 * misc.h: (local_strdup) New macro corresponding to strdup() but
13202 allocating its data through local_alloc() if possible--that is, if
13205 * postscript.c: Comment changes.
13206 (quote_ps_name, quote_ps_string, output_encodings) New functions.
13207 (output_line, add_string) New macros supporting
13208 output_encodings().
13209 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
13210 substitution vars. Calls output_encodings() when a line
13211 consisting of `!encodings' is encountered.
13212 (preclose) Some code moved into quote_ps_string().
13213 (dump_line) Changed into macro supporting dump_fancy_line().
13214 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
13215 command when appropriate.
13216 (write_text) Fixed `literal_char' array (I think it's fixed, at
13218 (text) Fixed bug when width was zero. Now exits immediately on
13219 zero height_left. Now, when executing `goto restart;', checks
13220 that cp<end, so that we don't read beyond end-of-string. Also,
13221 outputs the correct code to the output file by outputting the code
13222 from the metric instead of the internal metric index.
13224 * repeat.c: (cmd_end_repeat) New function.
13226 * som.c: (var som) `headers' renamed `options' and semantics
13227 changed. All references changed.
13228 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
13229 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
13231 (som_text_table) Removed.
13232 (som_output_text) New function.
13234 * som.h: (struct som_submission_form) Removed `header', `reuse',
13235 replaced with bitmapped field `options'.
13236 (SOM_TOPT_*) New enum set for som_submission_form.options.
13237 (SOT_*) New enum set for som_output_text().
13239 * temporary.c: (copy_variable) When copying the var label, only
13240 calls xstrdup() if it's non-NULL.
13242 * var.h: (enum type `vartype') Removed; all references changed to
13245 * vars-atr.c: (init_variable) Changed local var `nbytes' from
13248 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
13250 * font.h: Comment changes.
13252 * groff-font.c: (groff_read_font) Initializes `name' field to
13253 NULL. Handles `encoding' field.
13255 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
13257 * postscript.c: (struct font_entry) Removed `position' field.
13258 (struct ps_font_combo) New struct.
13259 (struct ps_driver_ext) Removed field `next_position'. New fields
13260 `combos', `next_combo'. `last_font' field changed from
13261 `font_entry *' to `ps_font_combo *'.
13262 (ps_init_driver) Reformatted; handles new fields. When
13263 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
13265 (get_encoding, find_encoding_file) New functions.
13266 (add_encoding) Some code moved out into find_encoding_file().
13267 (postopen) Changed value for ${title}.
13268 (preclose) Sets `loaded' field to NULL after destroying the hash
13270 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
13272 (ps_text_set_font_by_position) Figures out the current family if
13274 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
13275 (switch_font) Implemented.
13276 (write_text) Calls switch_font() more often. Format changes.
13277 #undefs its macros after they're no longer useful.
13278 (text) Changed `continue' at one point to a jump to the top of the
13279 loop because we don't want `separate' reset to 0 at that point.
13280 (load_font) No longer sets `position' in the font_entry created.
13282 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
13284 * font.h: (struct font_desc) New member `encoding', which is not
13285 properly handled yet.
13287 * glob.c: (init_glob) Some new i18n code, which is probably
13290 * output.c: (outp_read_devices, outp_get_paper_size) Changed
13291 `size' local from `int' to `size_t'.
13293 * postscript.c: New driver configuration parameter `auto-encode'.
13294 New enums OPO_AUTO_ENCODE, ODA_COUNT.
13295 (struct font_entry) New member `position'.
13296 (struct ps_driver_ext) Reordered. New hash table member
13297 `encodings'; new members `next_position', `next_encoding',
13298 `last_font'. Members `current', `prop', `fixed' changed from type
13299 `font_desc *' to `font_entry *'; all references changed.
13300 (struct ps_encoding) New struct.
13301 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
13302 free_ps_encoding, add_encoding) New functions.
13303 (ps_init_driver) Added OPO_AUTO_ENCODE to default
13304 x->output_options. Initializes new members of ps_driver_ext.
13305 Changed default value for prologue_fn, encoding_fn. Calls
13306 read_ps_encodings after loading default fonts.
13307 (option_tab[], ps_option) Handle new configuration parameter.
13308 (switch_font) New function.
13309 (struct output_char) `font' member changed from `font_desc *' to
13310 `font_entry *'. New member `separate'.
13311 (read_fontmap) Changed `size' from `int' to `size_t'.
13312 (output_line, put_number) New macros for write_text().
13313 (write_text) Optimizes text output by consolidating multiple
13314 calls to PostScript `show' operator.
13315 (text) Keeps track of when text arguments can't be consolidated by
13316 write_text(), and marks those spots in the output stream.
13317 (load_font) Sets `position' of the allocated font_entry to -1, cuz
13318 the font hasn't been switched to by switch_font(), which is where
13319 the position is important--the PostScript is what cares about the
13322 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
13324 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
13325 call a NULL free_func.
13326 (hsh_rehash) Elegantized.
13327 (hsh_probe) Fix bug that manifested when the table was expanded
13328 and thus had to change location in memory. Good thing
13329 too--otherwise could have been much more subtle.
13330 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
13331 (hsh_foreach) New function for hash table iteration.
13333 * hash.h: (struct hsh_iterator) New.
13335 * lexer.c: (parse_tagged_quote) Font and family name strings in
13336 tags are now null-terminated.
13338 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
13340 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
13341 documented. (Never before tested?)
13343 * output.h: Comment changes.
13345 * postscript.c: New driver options `optimize-text-size',
13346 `optimize-line-size', `max-fonts-simult'. New enum set for
13347 specing cached line types. Comment fixes.
13348 (struct line_form) New struct.
13349 (struct ps_driver_struct) New members `text_opt', `line_opt',
13350 `max_fonts', `lines'.
13351 (ps_init_driver) Initializes new members of ps_driver_struct.
13352 (user option type enum set) New member `nonneg_int_arg'.
13353 (static var option_tab[]) Supports new options.
13354 (ps_option) Handles new options.
13355 (find_ps_file) Made static. No longer calls hsh_dump().
13356 (ps_get_var) Made static.
13357 (preclose) Dumps out proper DSC trailer.
13358 (ps_open_page) Elegantized.
13359 (ps_close_page) Calls dump_lines() if appropriate.
13360 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
13361 wrappers around line().
13362 (int_2_compare, compare_line, dump_line, dump_fancy_line,
13363 dump_lines, hash_line, free_line, line) New functions for support
13365 (write_text, text) Made static.
13366 (text) Added to font support, not finished.
13368 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
13370 * font.h: (struct font_desc) New members ascent, descent.
13372 * groff-font.c: (groff_read_font) Calculates font ascent and
13373 descent from the ascent and descent of the `d' and `p' characters,
13374 respectively, as per a suggestion on comp.fonts.
13376 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
13377 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
13379 (write_text) Handles text right-justification and centering (not
13380 full justification). Still very inefficient. (One output line
13382 (struct output_char) Added fields for font and font size.
13383 (text) Many bugfixes.
13385 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
13387 * cmdline.c: (usage) Calls outp_list_classes().
13389 * font.h: Comment fix.
13391 * groff-font.c: New exported global var `space_index'.
13392 (groff_init) New function to initialize `space_index'.
13393 (hash_kern) Casts result to unsigned.
13394 (font_name_to_index) Renamed font_char_name_to_index. All
13395 references changed. Also, now returns the value of `space_index'
13396 when passed an ASCII space character as an argument. Fixed
13398 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
13399 Handles passed NULL pointers properly.
13401 * lexer.c: (parse_tagged_quote) Comment fix. Better range
13404 * output.c: (outp_list_drivers) Removed. Removed all references.
13406 * output.h: Comment fixes.
13408 * postscript.c: (ps_open_global) Calls groff_init().
13409 (output_char) New structure.
13410 (write_text) New function.
13411 (text) No longer stubbed out! Now the output is correct--with a
13412 few exceptions, one of them being that the page has to be held
13413 upside down into a mirror.
13415 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
13417 * font.h: Comment fix.
13419 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
13420 All callers changed.
13421 (number_to_index) Renamed font_number_to_index, made extern. All
13423 (font_get_kern_adjust, font_get_char_metrics) New functions.
13425 * output.h: New constant OUTP_T_INTERNAL_DRAW.
13427 * postscript.c: Changed default line width back to 1/2 point.
13428 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
13429 in the center of the space allotted for them, not just a fixed
13430 offset from the edge of the space; this fixes some bugs.
13431 (ps_line_intersection) Now supports all command line styles.
13432 (ps_text_get_size) Bug fix in computation of em width.
13433 (text) New function, the meat behind ps_text_metrics and
13434 ps_text_draw. Not complete.
13435 (ps_text_metrics, ps_text_draw) Removed the stub taken from
13436 ascii.c; call text().
13438 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
13440 * arena.c: (arena_free) Assert that the argument is non-NULL.
13442 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
13443 only if old_kern is non-NULL.
13445 * postscript.c: (ps_init_driver) Changed default line width to 1
13447 (postopen) New prologue variables.
13448 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
13449 more of the common line styles properly, but not all.
13450 (ps_text_metrics) Fixed problem with this stubbed out version that
13451 kept it from taking font sizes into account.
13453 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
13455 * arena.c: (arena_malloc) Bug fix.
13456 (arena_dump) [GLOBAL_DEBUGGING] New function.
13458 * ascii.c: Comment fix.
13459 (count_fancy_chars, delineate) Now static functions.
13461 * filename.c: (interp_vars) Bug fixes.
13463 * font.h: Comment fixes.
13465 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
13466 beginning in case we have an error message to display before
13467 initializing the display.
13469 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
13471 (groff_read_font) Bug fixes.
13472 (name_to_index) Increments hash.used. Sets `name' field of hash
13474 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
13476 * hash.c: Return type changed.
13478 * postscript.c: Continued development. Now marks lines on the
13479 paper, but very buggy.
13481 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
13483 * Changed comments in many source files from `/* xxx /* yyy */' to
13484 `/* xxx */ /* yyy */' for cleanliness.
13486 * arena.c: (arena_sd_strdup) New function.
13488 * ascii.c: (struct ascii_driver_ext) New member `file'.
13489 (ascii_init_driver) Fills out member `file' for initing; uses
13490 close_file_ext for closing drivers.
13491 (ascii_option) Changed %.*s back to %s because the a_string's are
13492 always null-terminated.
13493 (postopen, preclose) New functions.
13494 (ascii_open_page) Uses new style of open_file_ext.
13495 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
13496 instead of this->output.
13497 (__assert_fail) Removed.
13499 * cmdline.c: Changed syntax_message[].
13501 * error.c: #include's <readline/history.h> only if the history
13502 library is available, not if just the readline library is
13505 * filename.c: (expand_line) Removed alloca() support.
13506 (interp_vars) No longer tilde-expands argument. Limit on output
13508 (tilde_expand) Now treats argument as path rather than filename.
13509 [!unix] Now is a no-op function.
13510 (search_path) Better verbose message formatting.
13511 (open_file, close_file) Comment fixes.
13512 (close_file) [!unix] Doesn't bother with pipes.
13513 (open_file_ext) Completely rewritten, interface revamped.
13514 (close_file_ext) New function.
13516 * font.h: Comment changes.
13518 * frequencies.q: Removed AIX alloca support since it doesn't use
13521 * hash.c: Comment changes & additions.
13522 (hsh_create) Initializes entire table instead of first M entries.
13523 (hsh_probe) Stupid bug fixed. Now it works.
13524 (hsh_dump) [GLOBAL_DEBUGGING] New function.
13526 * main.c: (parse) Detects EOF properly in token-eating loop.
13527 Should the STOP token have its value changed to 0?
13529 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
13530 (blp_getline) Now it's a macro.
13532 * output.h: (struct outp_driver) Removed members output, filename.
13534 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
13535 drivers in driver table.
13536 (outp_read_devices) Frees buf. Warns if there are no active
13538 (outp_configure_clear) Sets outp_configure_vec to NULL after
13539 deleting its elements.
13540 (configure_driver, destroy_driver) Removed references to output,
13541 filename members of outp_driver.
13542 (outp_evaluate_dimension, internal_get_paper_size,
13543 outp_get_paper_size) New functions.
13545 * postscript.c: Continued development. Now links but doesn't make
13546 any marks on the page. Lotsa bugs I suppose.
13548 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
13550 * str.h: Comment changes.
13552 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
13554 * Removed dependencies on non-nested comments in several files.
13555 Also removed references to (unix || __unix__) in #if's since
13556 prefh.orig makes those two equivalent.
13558 * ascii.c: (ascii_open_global) Creates ascii_arena.
13559 (ascii_close_global) Destroys ascii_arena.
13560 (ascii_init_driver) Doesn't create ascii_arena.
13561 (ascii_copy_driver) Removed.
13562 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
13563 (outp_class ascii_class) Removed ascii_copy_driver reference.
13565 * frequencies.q: Now can display all statistics except median.
13566 Still not finished.
13568 * output.c: Handles outp_class.ref_count so output class
13569 destructors are called properly.
13570 (add_class) Sets ref_count to 0.
13571 (configure_driver) Initializes class if ref_count++ is 0.
13572 (destroy_driver) Destructs class if --ref_count is 0. Frees the
13573 class output file name.
13575 * output.h: (struct outp_class) Removed copy_driver, inited.
13578 * postscript.c: Completely replaced but not finished.
13580 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
13582 * approx.h: #includes <float.h>.
13584 * arena.h, arena.c: Many functions changed to take an arena **
13585 instead of an arena *, for consistency. All callers changed.
13586 (arena_alloc) Now creates a new arena if passed *A that is NULL.
13587 (arena_destroy) Sets *A to NULL.
13589 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
13590 assertion that `width' be positive.
13592 * command.c: Removed #if's from cmd_table.
13593 (walk_cmdtable_func) [0] New function (debug code).
13594 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
13595 (parse_cmd) Doesn't return failure for unimplemented commands.
13597 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
13598 (SYSCODE) New constant macro.
13600 * descript.q: Checks for positive n_variables before performing
13603 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
13604 avl_find instead of &fp as arg 2.
13606 * frequencies.g, frequencies.q: Continued updating; now compiles &
13607 works again, but not complete.
13609 * main.c: Changes to user messages.
13611 * misc.c: (reverse) [0] New function.
13613 * settings.h: Comment removed. #includes "common.h".
13615 * som.c: (som_set_null) New function.
13616 (som_set_value, som_set_string, som_set_text) More detailing
13618 (som_set_float) Implemented function.
13619 (dump_columnated_table) Bug fix regarding page breaks.
13620 (draw_cell) Bug fix regarding text that spilled out of a cell.
13621 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
13623 (get_cell_size) Support SCON_EMPTY cells.
13624 (get_table_size) When calculating rules' widths and heights, mask
13625 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
13627 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
13629 (struct som_submission_form) New member `header'; all users
13632 * val-labs.c: (get_label) User messages changed.
13634 * var.h: Changed FREQUENCIES structures.
13636 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
13639 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
13641 * approx.h: Definition of EPSILON now depends on system's
13642 DBL_EPSILON. Removed GNU C specific code.
13643 (cmpapx) Renamed approx_compare.
13645 * frequencies.g, frequencies.q: Continued updating; still doesn't
13648 * groff-font.c: (name_to_index) Fix bug that kept it from
13651 * hash.c, hash.h: Completed work.
13653 * var.h: Changes to freq_tab, frequencies_proc.
13655 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
13658 * hash.c, hash.h: New files. Not completed.
13659 * Makefile.am: Added hash.c to source file list.
13660 * font.h: (struct font_desc) New member kern_size_p.
13661 * groff-font.c: Uses hash.h.
13662 (hashpjw) Moved to hash.c.
13663 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
13665 (static var hash) New member size_p.
13666 * var.h: Includes hash.h.
13667 (struct freq_tab) Changed AVL_TREE to hash_tab.
13669 * vars-prs.c: Comment, formatting fixes.
13671 * frequencies.g, frequencies.q: Continued updating. Not yet
13674 * formats.c: Bug fix.
13676 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
13678 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
13679 * descript.g: Comment fixes.
13680 * descript.q: Comment fixes. Moved some declarations into var.h.
13681 Made dsc_info a static table. Updated FIXMEs.
13682 (internal_cmd_descriptives) Beautified.
13684 * frequencies.q: Started updating into working order.
13685 * frequencies.g: New file analogous to descript.g.
13686 * var.h: Comment fixes. Added structures for FREQUENCIES.
13688 * som.c: Removed vestiges of crushing and partial table support.
13690 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
13692 * Many more changes to som.c especially, but these will not be
13693 documented as I have resolved to remove them. This patchlevel is
13694 being released solely so that I can fall back to it if I decide
13695 that removing the changes is not a good idea.
13697 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
13699 * som.c: (global var som) New member `cum_y'.
13700 (build_target) Properly handles titles for partial tables.
13701 (dump_partial_beg, dump_partial_mid, dump_partial_end)
13702 Merged into single new function dump_partial(). Fixed problem
13703 with titles on partial tables.
13704 (dump_table) Calls dump_partial() for all parts of partial tables.
13705 (dump_page) Criteria for drawing title changed.
13707 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
13709 * command.c: (cmd_table) Added LIST, WEIGHT.
13711 * command.c: (cmd_remark) No longer frees `s' since it's not
13712 dynamically allocated.
13714 * data-out.c: (convert_f) Now correctly handles the case where
13715 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
13716 number of decimals.
13717 (som_destroy_all_tables) Removed argument. All callers changed.
13718 (som_vline, som_hline) Argument validity checking corrected.
13719 (som_set_value) Implemented half-heartedly.
13720 (replicate_table) Copies tables piece-by-piece when using Checker.
13722 * som.h: New line style SLIN_1THIN, currently equivalent to
13723 SLIN_0. New enum set SOM_SUB_*.
13724 (struct som_submission_form) Removed `seq_no'. Added `type'.
13726 * list.q: Newly working file; uses partial tables.
13728 * som.c: (som_reduce_table) Renamed som_set_table_height().
13729 (som_crush) Removed argument `group'.
13730 (global var som) Removed `nt', `seq_no'. Added `type'.
13731 (som_submit_table) Arguments changed.
13732 (output_table) Removed partial table code.
13733 (build_target) New arg; partial table support added. All callers
13735 (dump_plain_table) Removed partial table code.
13736 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
13737 (dump_table) Supports partial tables.
13738 (dump_page) New argument to allow not drawing top and/or bottom
13739 headers. All callers changed. Supports partial tables.
13741 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
13743 * data-out.c: Changed `#include <approx.h>' to `#include
13745 (convert_F) Comment fix. Now won't print `-.000', etc.
13747 * descript.q: Now Z-scores work, although there appears to
13748 be a bug (which might actually be in data-out.c:convert_F()).
13749 (descriptives_trns_proc, descriptives_trns_free) New functions.
13750 (run_z_pass) Implemented.
13752 * var.h: Comment fixes.
13753 (dsc_z_score, descriptives_trns) New structs.
13754 (descriptives_trns) Added to any_trns as `dsc'.
13756 * error.c, error.h: New error class, IS (Installation Script
13757 error), used in those instances where the error is in the
13758 installation, but there is a script file or installation file that
13759 can be usefully referred to.
13761 * output.c: Change many IE classes to IS classes.
13763 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
13764 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
13765 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
13766 include the corresponding header?
13768 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
13769 Don't bail out if termcap can't be read.
13771 * som.c: (som_destroy_table) Removed.
13772 (som_reduce_table, som_destroy_all_tables) New functions.
13773 (som_crush) New function, not implemented.
13775 * som.h: New table option STAB_CRUSH. Comment fix. New struct
13776 som_submission_form. Function prototypes revised.
13778 Outputting huge tables (1000s of rows) a few rows at a time
13779 is supported, though untested. May even break everything.
13780 Actually, the code doesn't even compile right now.
13781 * som.c: (struct som) New fields htv, nt, seq_no.
13782 (som_submit_table) Multiple arguments changed to a single
13783 pointer to struct submission_form. Only increments subtable_num
13784 if seq_no is zero. Only destroys table if it's not going to
13786 (replicate_table) New function.
13787 (output_table) Comment fix.
13788 (examine_table) Changed inline code to code calling
13789 replicate_table(). Calculates htv. Supports partial tables.
13790 (draw_title) Removed comment.
13791 (build_target) Only allows for title on first part of partial
13793 (dump_plain_table) Only resets table chunk number on first part
13794 of partial tables; FIXME: doesn't work quite right. Supports
13796 (dump_page) Titles only on first part of partial tables.
13798 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
13800 * Thanks to an unreliable IDE hard drive, I have spent the last
13801 day reconstructing my Debian GNU/Linux installation and redoing
13802 the previous day's changes--somehow I managed to save every file
13803 except for output.c and output.h. So the following changes could
13804 really be considered independent of the output.c, output.h changes
13807 * output.h, output.c: Moved the outp_configure_vec global var,
13808 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
13809 outp_configure_vec is now static.
13811 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
13813 * The entire philosophy behind configuration of the output drivers
13814 changed. Now there is a termcap-type configuration where drivers
13815 to be read are determined beforehand, rather than parsing the
13816 entire output init file and storing it in memory & deciding what
13817 to actually use later. Faster & more memory-efficient at the same
13820 * output.c: Comment fix. Removed outp_init_drivers global var.
13821 Removed all references to synonyms. New structure outp_defn. New
13822 global vars outp_macros, outp_configure_vec.
13823 (search_name, delete_name, add_name, check_configure_vec,
13824 expand_name, find_defn_value) New static functions.
13825 (outp_configure_clear, outp_configure_add, outp_configure_macro,
13826 outp_read_devices) New extern functions.
13827 (outp_init) Much functionality moved into outp_read_devices.
13828 (outp_read_devices) Format of output init file changed; name of
13829 file is `devices' rather than `output' to avoid Makefile
13831 (outp_clear) Renamed outp_done.
13832 (outp_list_classes) Bug fix, cleaned up.
13833 (outp_list_drivers) Not implemented anymore.
13834 (outp_configure_driver) Now a static function; simplified; now
13835 interpolates macros; supports new structure.
13836 (outp_enable_driver, match_synonym) Removed; all references
13838 (find_driver) First argument removed.
13840 * output.h: Global var outp_init_drivers removed; new structure
13841 outp_names; new enum set OUTP_S_*; new global var
13842 outp_configure_vec; function prototypes for output.c exports
13845 * main.c: (main) Calls outp_read_devices() after parsing the
13848 * cmdline.c: (parse_command_line) New option -v --verbose;
13849 --version changed to -V. --device option changed syntax to just
13850 take a single device name. Accepts key=value declaration of
13851 output init file macros. Syntax message updated.
13853 * filename.c: (expand_line) New function.
13854 (interp_environ_vars) Renamed interp_vars; no longer uses
13856 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
13857 overridden by real environment vars.
13858 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
13859 * filename.h: interp_environ_vars() renamed interp_vars().
13861 * error.c, error.h: Added extern variable `verbosity', message
13864 * error.c: (vmsg) Support message class MM.
13865 (verbose_msg) New function.
13867 * descript.q: (generate_z_varname) Bug fix in generation of
13869 (dump_z_table) Bug fix in column headers.
13871 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
13872 page from 29 to 15. Don't set a default for ops[OPS_INIT,
13873 OPS_DONE]. Writes the uninit string when the driver is closed.
13874 (ascii_open_page) Write the init string before the first page.
13875 (output_shorts) Form of main loop changed from `while' to `for'.
13876 Bug fix with overstrikes: the character is printed *after* the
13877 backspace. Eliminated a lot of `& 0xff' modifiers.
13878 (advance_to_left_margin) New function.
13879 (return_carriage, output_lines) Handle left margin.
13881 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
13883 * ascii.c: New option `carriage-return-style'.
13885 * ascii.c: (count_fancy_chars) New function.
13886 (delineate, text_metrics) Use new function; bug fixes regarding
13888 (text_draw) Bug fix with rich text.
13889 (output_string, output_shorts) Reordered.
13890 (output_shorts) Now handles boxchars and some overstrike font
13892 (output_char, return_carriage) New functions.
13893 (output_lines) Now handles overstriking and font changes properly;
13894 some code moved to output_shorts.
13896 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
13899 * ascii.c: New member `debug' in ascii_driver_ext.
13900 (ascii_init_driver, delineate) Uses new member.
13902 Now you can set a vertical height on writing text.
13903 * ascii.c: (delineate) Keeps track of vertical position.
13904 (text_draw) No longer considers fully justified text an internal
13907 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
13909 Tables' titles are drawn; they can have variable height.
13910 * som.c: `som' struct has new member, title_height.
13911 (draw_title) New argument. Moved within file. All caller
13913 (build_target) New argument, amount of space needed for first row.
13914 Calculates height of title, takes that into account. All callers
13916 (dump_plain_table, dump_columnated_table) Took calculation of y1,
13918 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
13920 (dump_columnated_table) Organized for readability.
13921 (dump_page) Makes use of som.title_height.
13923 * som.c: Many comment bug fixes.
13925 * descript.q: (try_name, generate_z_name) Bug fix regarding
13926 generation of Z-score variable names.
13927 * var.h: Removed num from descriptives_proc; all referents removed.
13929 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
13931 * ascii.c: (ascii_line_horz, ascii_line_vert,
13932 ascii_line_intersection) Added debugging code.
13934 Added a descriptive line above each table to describe it.
13935 * command.c: (parse_cmd) Calls som_new_series.
13937 * som.c: New static vars table_num, subtable_num. New `som'
13939 (dump_page) New arguments.
13940 (som_submit_table) Handle new variables.
13942 * som.c, som.h: (som_submit_table) New arguments. All callers
13944 (som_new_series) New function.
13945 (build_target) Makes room for extra line.
13946 (draw_title) New function.
13947 (dump_page) Calls draw_title. Bug fix: doesn't always set
13950 Columnation of tables support.
13951 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
13953 * som.c: Deleted references to fr, lr, ri.
13954 (som_columnate) Bux fix: sets group member of table.
13955 (som_add_options) Function removed.
13956 (dump_table) Split into three functions; extensively reworked.
13958 * descript.q: (dump_z_table) Better output table formatting; added
13959 title support to correspond to som.h changes.
13960 (display) Title support.
13962 * output.h: Added OUTP_T_NONE.
13964 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
13966 * descript.q: Improved handling of Z scores; still not perfect.
13968 * output.h, ascii.c: Added hook for getting em width of current
13971 * som.c: Uses new em-width hook. Added debugging code to
13973 (som_columnate) New argument.
13974 (som_add_options) Removed.
13976 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
13978 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
13979 rules as a property of the table instead of as a property of the
13982 * ascii.c: Added `header' to table of options.
13984 * descript.q: Added even shorter statistic names; modified to work
13985 with new som interface.
13987 * misc.c (blp_getdelim): Bug fix.
13989 * version.c: includes 'conf.h'.
13991 ----------------------------------------------------------------------
13994 version-control: never