ONEWAY: Fix incorrect, duplicate "(J) Family" label.

ONEWAY output should contain dimensions labeled "(I) Family" and
"(J) Family", but they incorrectly both had the latter label.  This fixes
the problem.

Thanks to Andreas Hammer for reporting the bug.

Fixes: 5cab4cf3322f ("output: Introduce pivot tables.")

diff --git a/src/language/commands/oneway.c b/src/language/commands/oneway.c
index 2e27697fe9a92e6fa0dc10aa41ba48a841fa03a4..49b06c73d292582c07abc3f9ba8ff8cda817b1be 100644 (file)
--- a/src/language/commands/oneway.c
+++ b/src/language/commands/oneway.c
@@ -1313,7 +1313,7 @@ show_comparisons (const struct oneway_spec *cmd, const struct oneway_workspace *
   j_family->root->show_label = true;
 
   struct pivot_dimension *i_family = pivot_dimension_create (
-    table, PIVOT_AXIS_ROW, N_("(J) Family"));
+    table, PIVOT_AXIS_ROW, N_("(I) Family"));
   i_family->root->show_label = true;
 
   const struct per_var_ws *pvw = &ws->vws[v];

diff --git a/tests/language/commands/oneway.at b/tests/language/commands/oneway.at
index f854dd5f61b22b73dcf41aadbb4f739107c0abdb..3c8f2bf1a90959a728309b16dbd44378402b84de 100644 (file)
--- a/tests/language/commands/oneway.at
+++ b/tests/language/commands/oneway.at
@@ -633,7 +633,7 @@ pigmentation,Between Groups,478.950,3,159.650,12.927,.000
 ,Total,676.550,19,,,
 
 Table: Multiple Comparisons (pigmentation)
-,(J) Family,(J) Family,Mean Difference (I - J),Std. Error,Sig.,95% Confidence Interval,
+,(I) Family,(J) Family,Mean Difference (I - J),Std. Error,Sig.,95% Confidence Interval,
 ,,,,,,Lower Bound,Upper Bound
 LSD,1.000,2.000,-7.400,2.223,.004,-12.112,-2.688
 ,,3.000,-7.800,2.223,.003,-12.512,-3.088
@@ -703,7 +703,7 @@ libido,Between Groups,20.133,2,10.067,5.119,.025
 ,Total,43.733,14,,,
 
 Table: Multiple Comparisons (libido)
-,(J) Family,(J) Family,Mean Difference (I - J),Std. Error,Sig.,95% Confidence Interval,
+,(I) Family,(J) Family,Mean Difference (I - J),Std. Error,Sig.,95% Confidence Interval,
 ,,,,,,Lower Bound,Upper Bound
 Tukey HSD,Placebo,1 Dose,-1.000,.887,.516,-3.366,1.366
 ,,2 Doses,-2.800,.887,.021,-5.166,-.434
@@ -764,7 +764,7 @@ score,Between Groups,54.9500,3,18.3167,7.0449,.003
 ,Total,96.5500,19,,,
 
 Table: Multiple Comparisons (score)
-,(J) Family,(J) Family,Mean Difference (I - J),Std. Error,Sig.,95% Confidence Interval,
+,(I) Family,(J) Family,Mean Difference (I - J),Std. Error,Sig.,95% Confidence Interval,
 ,,,,,,Lower Bound,Upper Bound
 Šidák,1.0000,2.0000,3.0000,1.0198,.056,-.0575,6.0575
 ,,3.0000,-.4000,1.0198,.999,-3.4575,2.6575
@@ -846,7 +846,7 @@ Days of Use,Between Groups,555.275,3,185.092,6.663,.001
 ,Total,1555.375,39,,,
 
 Table: Multiple Comparisons (Days of Use)
-,(J) Family,(J) Family,Mean Difference (I - J),Std. Error,Sig.,95% Confidence Interval,
+,(I) Family,(J) Family,Mean Difference (I - J),Std. Error,Sig.,95% Confidence Interval,
 ,,,,,,Lower Bound,Upper Bound
 Scheffé,one,two,3.800,2.357,.467,-3.112,10.712
 ,,three,10.300,2.357,.001,3.388,17.212