The 'type' parameter was being used to pass in an "enum reader_command" but
it was then later assigned a value of "enum pfm_type". This renames 'type'
to 'command' for clarity and just deletes the assignment of the "enum
pfm_type" value entirely because the value was not used.
Found by Clang.
Reported-by: Jeremy Lavergne <jeremy@lavergne.gotdns.org>
/* Parses a GET or IMPORT command. */
static int
/* Parses a GET or IMPORT command. */
static int
-parse_read_command (struct lexer *lexer, struct dataset *ds, enum reader_command type)
+parse_read_command (struct lexer *lexer, struct dataset *ds,
+ enum reader_command command)
{
struct casereader *reader = NULL;
struct file_handle *fh = NULL;
{
struct casereader *reader = NULL;
struct file_handle *fh = NULL;
if (fh == NULL)
goto error;
}
if (fh == NULL)
goto error;
}
- else if (type == IMPORT_CMD && lex_match_id (lexer, "TYPE"))
+ else if (command == IMPORT_CMD && lex_match_id (lexer, "TYPE"))
{
lex_match (lexer, T_EQUALS);
{
lex_match (lexer, T_EQUALS);
- if (lex_match_id (lexer, "COMM"))
- type = PFM_COMM;
- else if (lex_match_id (lexer, "TAPE"))
- type = PFM_TAPE;
- else
+ if (!lex_match_id (lexer, "COMM")
+ && !lex_match_id (lexer, "TAPE"))
{
lex_error_expecting (lexer, "COMM", "TAPE", NULL_SENTINEL);
goto error;
{
lex_error_expecting (lexer, "COMM", "TAPE", NULL_SENTINEL);
goto error;