From b56f017491ffecdbe19e39aca242ffb13ad17016 Mon Sep 17 00:00:00 2001 From: John Darrington Date: Sun, 21 Mar 2021 22:19:25 +0100 Subject: [PATCH] Fix bug where attempting to rendering an empty bar chart would crash --- src/language/stats/frequencies.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/language/stats/frequencies.c b/src/language/stats/frequencies.c index 736b6ae555..a6ef914b03 100644 --- a/src/language/stats/frequencies.c +++ b/src/language/stats/frequencies.c @@ -1489,10 +1489,13 @@ do_barchart(const struct frq_chart *bar, const struct variable **var, int n_slices; struct freq **slices = pick_cat_counts_ptr (bar, frq_tab, &n_slices); - chart_submit (barchart_create (var, 1, - (bar->y_scale == FRQ_FREQ) ? _("Count") : _("Percent"), - (bar->y_scale == FRQ_PERCENT), - slices, n_slices)); + if (n_slices < 1) + msg (SW, _("Omitting bar chart, which has no values.")); + else + chart_submit (barchart_create (var, 1, + (bar->y_scale == FRQ_FREQ) ? _("Count") : _("Percent"), + (bar->y_scale == FRQ_PERCENT), + slices, n_slices)); free (slices); } -- 2.30.2