pspp
21 months agoHandle multiple postcomputes. ctables12
Ben Pfaff [Fri, 8 Jul 2022 20:20:07 +0000 (13:20 -0700)]
Handle multiple postcomputes.

21 months agoareapct_sum
Ben Pfaff [Thu, 7 Jul 2022 04:49:02 +0000 (21:49 -0700)]
areapct_sum

21 months agoupdate TODO
Ben Pfaff [Tue, 5 Jul 2022 01:37:36 +0000 (18:37 -0700)]
update TODO

21 months ago)CILEVEL
Ben Pfaff [Tue, 5 Jul 2022 01:32:57 +0000 (18:32 -0700)]
)CILEVEL

21 months agounweighted statistics
Ben Pfaff [Tue, 5 Jul 2022 00:31:07 +0000 (17:31 -0700)]
unweighted statistics

21 months agopcompute string ranges
Ben Pfaff [Mon, 4 Jul 2022 20:19:11 +0000 (13:19 -0700)]
pcompute string ranges

21 months agoadd namespace to some names
Ben Pfaff [Mon, 4 Jul 2022 19:56:53 +0000 (12:56 -0700)]
add namespace to some names

21 months agoPPROPERTIES FORMAT
Ben Pfaff [Mon, 4 Jul 2022 19:50:28 +0000 (12:50 -0700)]
PPROPERTIES FORMAT

21 months ago)LABEL[N]. untested, probably doesn't work.
Ben Pfaff [Sun, 3 Jul 2022 18:23:36 +0000 (11:23 -0700)]
)LABEL[N]. untested, probably doesn't work.

21 months ago)TABLE, )DATE, )TIME
Ben Pfaff [Sun, 3 Jul 2022 17:16:54 +0000 (10:16 -0700)]
)TABLE, )DATE, )TIME

21 months agostring ranges
Ben Pfaff [Sun, 3 Jul 2022 16:06:47 +0000 (09:06 -0700)]
string ranges

21 months agostrings and dates work
Ben Pfaff [Sun, 3 Jul 2022 05:44:25 +0000 (22:44 -0700)]
strings and dates work

21 months agoGet rid of vestigial mrset support.
Ben Pfaff [Sun, 3 Jul 2022 03:57:38 +0000 (20:57 -0700)]
Get rid of vestigial mrset support.

21 months agoSMISSING
Ben Pfaff [Sun, 3 Jul 2022 03:26:47 +0000 (20:26 -0700)]
SMISSING

21 months agoCTABLES fixes for totals.
Ben Pfaff [Sun, 3 Jul 2022 00:24:37 +0000 (17:24 -0700)]
CTABLES fixes for totals.

21 months agopivot-table: Make PIVOT_N_AXES a macro instead of an enum.
Ben Pfaff [Sun, 3 Jul 2022 00:23:49 +0000 (17:23 -0700)]
pivot-table: Make PIVOT_N_AXES a macro instead of an enum.

This prevents warnings about "switch" statements without a "case"
for PIVOT_N_AXES.

21 months agofix icon names
Ben Pfaff [Thu, 30 Jun 2022 21:25:57 +0000 (14:25 -0700)]
fix icon names

21 months agomore missing value tests
Ben Pfaff [Thu, 30 Jun 2022 02:19:18 +0000 (19:19 -0700)]
more missing value tests

21 months agoCTABLES missing values start to make some minimal amount of sense
Ben Pfaff [Wed, 29 Jun 2022 05:25:29 +0000 (22:25 -0700)]
CTABLES missing values start to make some minimal amount of sense

21 months agowork on missing value handling
Ben Pfaff [Sat, 25 Jun 2022 04:11:39 +0000 (21:11 -0700)]
work on missing value handling

21 months agoRevert "CTABLES work on distinguishing scale variables in summaries"
Ben Pfaff [Sat, 4 Jun 2022 23:07:48 +0000 (16:07 -0700)]
Revert "CTABLES work on distinguishing scale variables in summaries"

This reverts commit 121e99afcdd0847a75b9a9924145a4e8042f25a5.

21 months agoCTABLES work on distinguishing scale variables in summaries
Ben Pfaff [Sat, 4 Jun 2022 23:07:43 +0000 (16:07 -0700)]
CTABLES work on distinguishing scale variables in summaries

scale variables really are different for summarization

This isn't quite ready, so it's going to be reverted for now.

21 months agoCTABLES comments
Ben Pfaff [Sat, 4 Jun 2022 23:06:20 +0000 (16:06 -0700)]
CTABLES comments

21 months agoCTABLES remove some vestigial multiple response support
Ben Pfaff [Sat, 4 Jun 2022 04:22:43 +0000 (21:22 -0700)]
CTABLES remove some vestigial multiple response support

21 months agoCTABLES weird special formats
Ben Pfaff [Sat, 4 Jun 2022 04:14:42 +0000 (21:14 -0700)]
CTABLES weird special formats

21 months agoCTABLES: implement some simple features
Ben Pfaff [Sat, 4 Jun 2022 03:08:03 +0000 (20:08 -0700)]
CTABLES: implement some simple features

21 months agoVLABELS
Ben Pfaff [Fri, 3 Jun 2022 23:39:59 +0000 (16:39 -0700)]
VLABELS

21 months agodoc first draft is done
Ben Pfaff [Fri, 3 Jun 2022 23:33:01 +0000 (16:33 -0700)]
doc first draft is done

21 months agowork on CTABLES
Ben Pfaff [Mon, 27 Dec 2021 00:01:47 +0000 (16:01 -0800)]
work on CTABLES

21 months agoDESCRIPTIVES: Fix bad error message.
Ben Pfaff [Sat, 25 Jun 2022 03:37:04 +0000 (20:37 -0700)]
DESCRIPTIVES: Fix bad error message.

21 months agoSmake: Fix icon rendering by using correct application ID.
Ben Pfaff [Fri, 24 Jun 2022 23:37:36 +0000 (16:37 -0700)]
Smake: Fix icon rendering by using correct application ID.

PSPP-specific icons were not showing up properly in the GUI because
the compiled-in resources were looking in gnu.pspp whereas the name
is now org.gnu.pspp.  This fixes the problem.

Fixes: a421d8d9f61b ("Change application ID from org.fsf.pspp to org.gnu.pspp.")
21 months agoRelease version 1.6.1.
Ben Pfaff [Fri, 24 Jun 2022 16:40:10 +0000 (09:40 -0700)]
Release version 1.6.1.

21 months agoSmake: Fix dependencies for src/ui/gui/resources.xml.
Ben Pfaff [Fri, 24 Jun 2022 16:34:05 +0000 (09:34 -0700)]
Smake: Fix dependencies for src/ui/gui/resources.xml.

This file is a list of all the icon files, but generating it doesn't use
icon files themselves, so depending on them isn't useful.  On the other
hand, the file does need to be regenerated if the icon list changes, and
that icon list is in Smake itself, so this target does need to depend on
the Makefiles.

21 months agopo: Update Hungarian translation.
Ben Pfaff [Fri, 24 Jun 2022 16:22:05 +0000 (09:22 -0700)]
po: Update Hungarian translation.

Thanks to Meskó Balázs for updating this translation.

21 months agoChange application ID from org.fsf.pspp to org.gnu.pspp.
Ben Pfaff [Sun, 19 Jun 2022 21:01:09 +0000 (14:01 -0700)]
Change application ID from org.fsf.pspp to org.gnu.pspp.

This includes changing the argument of gtk_application_new() from
"gnu.pspp" to "org.gnu.pspp" for consistency.

Suggested by Hubert Figuière at https://github.com/flathub/flathub/pull/3275.

22 months agoperl: remove references to Memory::Usage module for perl module tests
Friedrich Beckmann [Sun, 19 Jun 2022 15:17:48 +0000 (17:17 +0200)]
perl: remove references to Memory::Usage module for perl module tests

The perl memory test was removed with commits

https://git.savannah.gnu.org/cgit/pspp.git/commit/?id=20934a68593edbd52577f1ba0ea93c74eb018af5

and

https://git.savannah.gnu.org/cgit/pspp.git/commit/?id=05297509d237dc99ba7504ccf260e995586bc3b4

This commit removes the remaining references to the perl memory test.
The configure step still asked for optional Memory::Usage perl module
which is not used without the perl memory test.

22 months agogui: make import assistant window a modal window
Friedrich Beckmann [Sun, 19 Jun 2022 14:30:42 +0000 (16:30 +0200)]
gui: make import assistant window a modal window

I changed the import assistant window to a modal window such that
the other windows cannot be changed while the import is ongoing.
There are problems when the main window is closed during the import.

Closing: https://savannah.gnu.org/bugs/?62448

22 months agoImplement SET LEADZERO.
Ben Pfaff [Sat, 18 Jun 2022 23:29:17 +0000 (16:29 -0700)]
Implement SET LEADZERO.

22 months agoconfigure: Increase version number to 1.6.1.
Ben Pfaff [Sat, 18 Jun 2022 23:30:03 +0000 (16:30 -0700)]
configure: Increase version number to 1.6.1.

22 months agopo: Update ca,es,de,nl,uk translations from translationproject.org.
Friedrich Beckmann [Fri, 17 Jun 2022 14:23:32 +0000 (16:23 +0200)]
po: Update ca,es,de,nl,uk translations from translationproject.org.

Many thanks to Francesc Josep Miguel Quesada, Jaap Verhage,
Yuri Chornoivan and the other members of the translation team!

22 months agoperl-module: Remove loading of memory:usage module
Friedrich Beckmann [Fri, 17 Jun 2022 13:49:23 +0000 (15:49 +0200)]
perl-module: Remove loading of memory:usage module

The memory leakage/usage test was removed with commit
https://git.savannah.gnu.org/cgit/pspp.git/commit/?id=20934a68593edbd52577f1ba0ea93c74eb018af5

but the memory module was still loaded. On debian this
memory module requires an additional dependency
libmemory-usage-perl which is not required. As the
memory module is not used inside the test I removed it.

22 months agoUpdate to newest Gnulib.
Ben Pfaff [Fri, 3 Jun 2022 22:12:57 +0000 (15:12 -0700)]
Update to newest Gnulib.

22 months agoline-reader: Avoid undefined behavior in printf utility in test.
Ben Pfaff [Fri, 3 Jun 2022 22:01:19 +0000 (15:01 -0700)]
line-reader: Avoid undefined behavior in printf utility in test.

The test used
    printf '\"'
assuming that it would print just a double-quote, but on at least one
system it printed a backslash followed by a double-quote.  This commit
changes it to
    print '"'
which should be reliable everywhere.

Thanks to Michael Orlitzky <michael@orlitzky.com> for reporting this bug.

22 months agotests: Add test for doubled parentheses.
Ben Pfaff [Wed, 1 Jun 2022 19:09:43 +0000 (12:09 -0700)]
tests: Add test for doubled parentheses.

I can't reproduce the problem reported in a bug report, but it seems
worthwhile to add a test for it anyway.

Bug #62557.

22 months agolexer: New function lex_ofs_representation().
Ben Pfaff [Sun, 13 Feb 2022 19:07:22 +0000 (11:07 -0800)]
lexer: New function lex_ofs_representation().

This interface is more convenient for situations where it's easier to
consume tokens before getting their representations.

22 months agomode: New order statistic.
Ben Pfaff [Sun, 30 Jan 2022 00:56:30 +0000 (16:56 -0800)]
mode: New order statistic.

22 months agomath: Make 'accumulate' a feature of order statistics, not all stats.
Ben Pfaff [Sun, 30 Jan 2022 00:56:18 +0000 (16:56 -0800)]
math: Make 'accumulate' a feature of order statistics, not all stats.

22 months agosubcase: Rename subcase_destroy() to subcase_uninit().
Ben Pfaff [Sat, 29 Jan 2022 20:21:13 +0000 (12:21 -0800)]
subcase: Rename subcase_destroy() to subcase_uninit().

This reflects the convention that "destroy" frees the pointer passed in
while "uninit" only frees the internals.

22 months agomath: Coding style updates in some order-stat implementations.
Ben Pfaff [Sat, 29 Jan 2022 20:01:16 +0000 (12:01 -0800)]
math: Coding style updates in some order-stat implementations.

I generally find structure assignments clearer than individual assignments
to each of their members these days.

22 months agomath: Improve comments.
Ben Pfaff [Sat, 29 Jan 2022 20:00:16 +0000 (12:00 -0800)]
math: Improve comments.

This includes some changes to parameter names and coding style in
order-stats that I think clarify the code and modernize it.

22 months agomath: Avoid unneeded extra allocations for fixed-size data structures.
Ben Pfaff [Sat, 29 Jan 2022 18:52:49 +0000 (10:52 -0800)]
math: Avoid unneeded extra allocations for fixed-size data structures.

This seems generally a bit cleaner to me.

22 months agospv-legacy-decoder: Always give the pivot table a title.
Ben Pfaff [Tue, 18 Jan 2022 03:19:27 +0000 (19:19 -0800)]
spv-legacy-decoder: Always give the pivot table a title.

A pivot table must have a title.  Some parts of PSPP rely on that.  The
legacy SPV decoder didn't ensure this, and one SPV in my corpus didn't have
one, which led to null pointer dereferences, so this commit fixes the
problem.

22 months agooutput-item: Add missing new-line printing tables in output_item_dump().
Ben Pfaff [Tue, 18 Jan 2022 01:39:37 +0000 (17:39 -0800)]
output-item: Add missing new-line printing tables in output_item_dump().

This only affects "pspp-output dump".

22 months agooutput-item: Fix memory leak in output_item_dump().
Ben Pfaff [Sat, 1 Jan 2022 21:31:39 +0000 (13:31 -0800)]
output-item: Fix memory leak in output_item_dump().

22 months agopivot-table: New functions for setting captions, etc.
Ben Pfaff [Sun, 2 Jan 2022 03:27:31 +0000 (19:27 -0800)]
pivot-table: New functions for setting captions, etc.

22 months agopivot-table: Fix pivot_table_dump() null pointer dereference in special case.
Ben Pfaff [Mon, 17 Jan 2022 22:05:09 +0000 (14:05 -0800)]
pivot-table: Fix pivot_table_dump() null pointer dereference in special case.

This function only gets called from "pspp-output dump", so it's not a very
important bug.

22 months agoRelease version 1.6.0.
Ben Pfaff [Wed, 1 Jun 2022 04:34:19 +0000 (21:34 -0700)]
Release version 1.6.0.

22 months agoperl-module: Copy Perl module from srcdir to builddir before distributing.
Ben Pfaff [Mon, 30 May 2022 18:05:45 +0000 (11:05 -0700)]
perl-module: Copy Perl module from srcdir to builddir before distributing.

I ran into an issue where the Perl tests were failing in distcheck, but
not in check.  I changed the sources for the Perl module, but distcheck
still used the old ones.  It turns out that "make dist" uses files from
the builddir, which "make dist" wasn't updating from the srcdir because
that only happened when the Perl module was actually built, which "make
dist" and "make distcheck" don't do.

This commit fixes the problem by ensuring that the Perl module files get
updated in the builddir on "make dist".

22 months agoperl-module: Remove test for memory usage.
Ben Pfaff [Mon, 30 May 2022 17:28:19 +0000 (10:28 -0700)]
perl-module: Remove test for memory usage.

This test only works if you're lucky.  It doesn't work with Address
Sanitizer and it doesn't seem to work with current versions of Perl.
(It might be that there's a real leak, but I don't know how to debug
it in that case.)

22 months agopo: Update translations from translationproject.org.
Ben Pfaff [Mon, 30 May 2022 16:28:39 +0000 (09:28 -0700)]
po: Update translations from translationproject.org.

Many thanks to our translators!

22 months agogui: For text data import, use the same parser for preview as for import.
Ben Pfaff [Sat, 28 May 2022 01:29:20 +0000 (18:29 -0700)]
gui: For text data import, use the same parser for preview as for import.

There were odd discrepancies between the preview code in the GUI for
text data import and the code in GET DATA /TYPE=TXT that implemented the
eventual import.  This commit unifies the two parsers, dropping the one
that was used only for preview.  This should prevent further discrepancies.

Bug #61809.
Thanks to Friedrich Beckmann for reporting this bug.

22 months agodata-parser: Make data parser not require a dictionary.
Ben Pfaff [Sat, 28 May 2022 00:15:02 +0000 (17:15 -0700)]
data-parser: Make data parser not require a dictionary.

An upcoming commit will make the GUI's text import use this code too, in
a context where a dictionary isn't yet available.  The data parser only
uses the dictionary for one specific purpose that isn't relevant for the
GUI, so remove the need for it.

22 months agogui: Make text import assistant accept only one quote character.
Ben Pfaff [Fri, 27 May 2022 22:37:10 +0000 (15:37 -0700)]
gui: Make text import assistant accept only one quote character.

This aligns with what SPSS does.

22 months agogui: Always use the most comma text import settings.
Ben Pfaff [Fri, 27 May 2022 21:38:58 +0000 (14:38 -0700)]
gui: Always use the most comma text import settings.

The heuristic did not perform well in practice according to user reports,
and most files use the defaults.

22 months agogui: Honor quotes in the text data import dialog.
Ben Pfaff [Fri, 27 May 2022 19:55:47 +0000 (12:55 -0700)]
gui: Honor quotes in the text data import dialog.

The text data import dialog's preview of the data to be read
didn't honor the quotes but always treated " and ' and (weirdly)
parentheses as quotes.  This makes it honor the user's settings.

Bug #61809.
Thanks for Friedrich Beckmann for reporting this bug.

22 months agoNew command SHOW SYSTEM to easily print information useful in bug reports.
Ben Pfaff [Sat, 21 May 2022 21:56:49 +0000 (14:56 -0700)]
New command SHOW SYSTEM to easily print information useful in bug reports.

2 years agopo: Update translations from translationproject.org.
Ben Pfaff [Mon, 11 Apr 2022 15:12:25 +0000 (08:12 -0700)]
po: Update translations from translationproject.org.

2 years agopo: Update de translation from translationproject.org
Friedrich Beckmann [Mon, 11 Apr 2022 09:22:53 +0000 (11:22 +0200)]
po: Update de translation from translationproject.org

2 years agoRelease version 1.5.5.
Ben Pfaff [Sun, 10 Apr 2022 23:41:58 +0000 (16:41 -0700)]
Release version 1.5.5.

2 years agopo: Update translations from translationproject.org.
Ben Pfaff [Sun, 10 Apr 2022 23:30:29 +0000 (16:30 -0700)]
po: Update translations from translationproject.org.

2 years agoexpressions: Convert SYSMIS into int as INT_MIN during optimization too.
Ben Pfaff [Sun, 10 Apr 2022 15:47:00 +0000 (08:47 -0700)]
expressions: Convert SYSMIS into int as INT_MIN during optimization too.

In an expression like LPAD('abc', $sysmis), the LPAD function is evaluated
using a C function that takes an 'int' as its second argument.  During
expression evaluation, out-of-range values get converted into SYSMIS by
the NUM_TO_INTEGER operator that gets automatically inserted to ensure
that, and then SYSMIS gets converted into INT_MIN to pass to the C
function.  This worked OK for runtime evaluation, but the optimizer failed
to do the conversion of SYSMIS to INT_MIN, which yielded undefined
behavior.  Some platforms (e.g. GCC on x86) converted SYSMIS (which is
the second-smallest 'double' value) into INT_MIN, so no problem showed up
there, but other platforms yielded INT_MAX, causing unexpected failures.

This commit fixes the problem by explicitly converting SYSMIS into INT_MIN
during optimization.

Thanks to Friedrich Beckmann for reporting and uncovering the problem.
Bug #62267.

2 years agopo: Update translations from translationproject.org.
Ben Pfaff [Thu, 7 Apr 2022 22:58:05 +0000 (15:58 -0700)]
po: Update translations from translationproject.org.

2 years agoorg.fsf.pspp.metainfo: changed links to https / added 1.5.4 release
Friedrich Beckmann [Thu, 7 Apr 2022 18:50:57 +0000 (20:50 +0200)]
org.fsf.pspp.metainfo: changed links to https / added 1.5.4 release

The debian checker mentionend the http links for the version info.
So I changed them to https. And I added the 1.5.4 release.

2 years agopo: Update German translation from translationproject.org.
Friedrich Beckmann [Thu, 7 Apr 2022 12:59:11 +0000 (14:59 +0200)]
po: Update German translation from translationproject.org.

Thanks to the german translation team at translationproject.org

2 years agostart message to translators with TRANSLATORS
Friedrich Beckmann [Wed, 6 Apr 2022 19:29:41 +0000 (21:29 +0200)]
start message to translators with TRANSLATORS

All comments which start with TRANSLATORS are visible for the
translators. The previous message is only visible if the translator
looks into the source code.

2 years agoMATRIX: Correct error message.
Ben Pfaff [Wed, 6 Apr 2022 14:56:38 +0000 (07:56 -0700)]
MATRIX: Correct error message.

Thanks to Friedrich Beckmann for reporting the mistake.

2 years agopo: Update Spanish translation from translationproject.org.
Ben Pfaff [Tue, 5 Apr 2022 15:25:25 +0000 (08:25 -0700)]
po: Update Spanish translation from translationproject.org.

Thanks to Francesc Josep Miguel Quesada for the updates!

2 years agopivot-table: Avoid null dereference in "pspp-output dump" in corner cases.
Ben Pfaff [Tue, 5 Apr 2022 15:15:45 +0000 (08:15 -0700)]
pivot-table: Avoid null dereference in "pspp-output dump" in corner cases.

2 years agoCROSSTABS: Fix computation of adjusted standardized residual.
Ben Pfaff [Tue, 5 Apr 2022 14:49:17 +0000 (07:49 -0700)]
CROSSTABS: Fix computation of adjusted standardized residual.

Bug #60982.

2 years agopsppire-output-view: Export correctly to drivers that don't handle groups.
Ben Pfaff [Tue, 5 Apr 2022 14:31:19 +0000 (07:31 -0700)]
psppire-output-view: Export correctly to drivers that don't handle groups.

Thanks to Elias Tsolis for reporting this bug.
Bug #61549.

2 years agoYuri Chornoivan contributed some typo fixes
Yuri Chornoivan [Fri, 1 Apr 2022 11:40:18 +0000 (14:40 +0300)]
Yuri Chornoivan contributed some typo fixes

Closes: https://savannah.gnu.org/bugs/?62245
Thank you for your contribution!

2 years agopo: Update Ukrainian translation from translationproject.org.
Ben Pfaff [Fri, 1 Apr 2022 16:14:34 +0000 (09:14 -0700)]
po: Update Ukrainian translation from translationproject.org.

Thanks to Yuri Chornoivan for translating.

2 years agoRelease version 1.5.4.
Ben Pfaff [Fri, 1 Apr 2022 02:57:39 +0000 (19:57 -0700)]
Release version 1.5.4.

2 years agosys-file-encoding: Clean up .c file on distclean.
Ben Pfaff [Fri, 1 Apr 2022 02:57:09 +0000 (19:57 -0700)]
sys-file-encoding: Clean up .c file on distclean.

Found by "make distcheck".

2 years agoicons: Fix uninstall.
Ben Pfaff [Fri, 1 Apr 2022 01:52:42 +0000 (18:52 -0700)]
icons: Fix uninstall.

The uninstall target for the icons looked for filenames that began with
"pspp", but the new names for the application icons don't start that way.

Fixes: 25e030629aed ("Rename icon files to match full application ID.")
2 years agobug #62189: Fixed clipped numbers in histogram legend
Friedrich Beckmann [Fri, 18 Mar 2022 23:11:05 +0000 (00:11 +0100)]
bug #62189: Fixed clipped numbers in histogram legend

I modified the legend rendering to avoid the clipping of mean and
standard deviation in the legend of the histogram plot. In addition
I changed the number print format to also show reasonable numbers
for small values.

fixed: https://savannah.gnu.org/bugs/index.php?62198

2 years agoWindows: Native build failed due to missing gnulib dependencies
Friedrich Beckmann [Fri, 18 Mar 2022 15:31:23 +0000 (15:31 +0000)]
Windows: Native build failed due to missing gnulib dependencies

The windows build failed because the gnulib header files were not
build before the compilation of c files for the native build.
The gnulib headers are
listed in the BUILT_SOURCES but that must be the first dependency
before the object files belonging to the executable. This is the
case for the default make target but not for an individual
executable like src/ui/terminal/pspp. I adapted the make file
to use the default make target.
See: https://www.gnu.org/software/automake/manual/html_node/Sources.html

2 years agoWindows build: Adapted icon names to org.fsf.pspp naming
Friedrich Beckmann [Fri, 18 Mar 2022 15:28:03 +0000 (15:28 +0000)]
Windows build: Adapted icon names to org.fsf.pspp naming

Ben changed the icon names to a naming scheme using org.fsf.xxx
The changes were missing in the windows build resulting in a
build failure for the windows target.

2 years agosvg2png: Use rsvg-convert if GIMP is not available.
Ben Pfaff [Mon, 14 Mar 2022 23:47:53 +0000 (16:47 -0700)]
svg2png: Use rsvg-convert if GIMP is not available.

The GNOME flatpak SDK has rsvg-convert, which does just fine, but not GIMP,
and I have no interest in building GIMP as a step in building PSPP.

2 years agoRename pspp.xml to org.fsf.pspp.xml.
Ben Pfaff [Mon, 14 Mar 2022 21:38:48 +0000 (14:38 -0700)]
Rename pspp.xml to org.fsf.pspp.xml.

This reflects the convention expected by flatpak and seems to reflect the
overall expected convention.

2 years agoRename icon files to match full application ID.
Ben Pfaff [Mon, 14 Mar 2022 21:37:37 +0000 (14:37 -0700)]
Rename icon files to match full application ID.

This seems to be the convention.  It makes building a flatpak easier.

2 years agoorg.fsf.pspp.metainfo.xml.in: Fix release dates.
Ben Pfaff [Mon, 14 Mar 2022 20:20:15 +0000 (13:20 -0700)]
org.fsf.pspp.metainfo.xml.in: Fix release dates.

These dates were in YYYY-DD-MM format, but they should be ISO 8601
compliant YYYY-MM-DD format.

2 years agoconfigure: Also support gtksourceview 4.x.
Ben Pfaff [Mon, 14 Mar 2022 18:51:46 +0000 (11:51 -0700)]
configure: Also support gtksourceview 4.x.

This doesn't require any source code changes because 4.x and 3.x are
source compatible for our purposes.

2 years agoMakefile: Fix running "make dist" before "make all".
Ben Pfaff [Sun, 13 Mar 2022 20:33:51 +0000 (13:33 -0700)]
Makefile: Fix running "make dist" before "make all".

Otherwise, there's a race between generating and using config.h, which
causes build failures.  This happens particularly with the PSPP autobuilder.

2 years agoSwitch from recursive to non-recursive use of Gnulib.
Ben Pfaff [Sun, 13 Mar 2022 19:34:36 +0000 (12:34 -0700)]
Switch from recursive to non-recursive use of Gnulib.

This allows for better use of dependencies in Makefiles.  It causes a new
warning from Automake, which I hope to fix through a change to Gnulib
sometime soon.  I'm consulting the other Gnulib maintainers on that:
https://lists.gnu.org/archive/html/bug-gnulib/2022-03/msg00044.html

2 years agoGnulib needs Automake 1.14 or later.
Ben Pfaff [Sun, 13 Mar 2022 19:12:53 +0000 (12:12 -0700)]
Gnulib needs Automake 1.14 or later.

2 years agotests: Update testsuite results to accomodate new Gnulib.
Ben Pfaff [Sun, 13 Mar 2022 18:41:50 +0000 (11:41 -0700)]
tests: Update testsuite results to accomodate new Gnulib.

It seems that libunistring now does line wrapping slightly differently,
perhaps due to Unicode updates.

2 years agoUpdate to newest gnulib.
Ben Pfaff [Sun, 13 Mar 2022 18:32:58 +0000 (11:32 -0700)]
Update to newest gnulib.

This required a dependency on Automake 1.11 or later.  It also required
dropping C2x compatibility warnings because Gnulib now triggers them.  The
Gnulib tempname module requires linking against $(LIB_GETRANDOM), so this
adds that in each case where the build links against libgl.

2 years agospv-light-decoder: Avoid GCC 11.x warning in decode_spvlb_halign().
Ben Pfaff [Sun, 13 Mar 2022 18:30:49 +0000 (11:30 -0700)]
spv-light-decoder: Avoid GCC 11.x warning in decode_spvlb_halign().

It seems to be wrong, but GCC can't tell and it's hard to blame it.

2 years agoexpressions: Fix value of $TIME variable and add a test.
Ben Pfaff [Sun, 13 Mar 2022 17:55:30 +0000 (10:55 -0700)]
expressions: Fix value of $TIME variable and add a test.

Thanks to Frans Houweling for reporting this bug.
Bug #62003.