pspp
20 months agoDocment how CLABELS can affect calculations.
Ben Pfaff [Mon, 15 Aug 2022 04:04:52 +0000 (21:04 -0700)]
Docment how CLABELS can affect calculations.

20 months agotesting progresses
Ben Pfaff [Mon, 15 Aug 2022 01:06:02 +0000 (18:06 -0700)]
testing progresses

20 months agomore summary testing
Ben Pfaff [Mon, 15 Aug 2022 01:03:09 +0000 (18:03 -0700)]
more summary testing

20 months agowokr on ctables tests
Ben Pfaff [Sun, 14 Aug 2022 23:43:03 +0000 (16:43 -0700)]
wokr on ctables tests

20 months agoFREQUENCIES: Use the smallest mode if there are multiple.
Ben Pfaff [Sun, 14 Aug 2022 23:42:56 +0000 (16:42 -0700)]
FREQUENCIES: Use the smallest mode if there are multiple.

This matches the documentation.

20 months agowork on CTABLES scale summary tests
Ben Pfaff [Sun, 14 Aug 2022 23:37:37 +0000 (16:37 -0700)]
work on CTABLES scale summary tests

20 months agoimprove pivot table splits
Ben Pfaff [Sun, 14 Aug 2022 23:23:46 +0000 (16:23 -0700)]
improve pivot table splits

20 months agoimprove FREQUENCIES LAYERED
Ben Pfaff [Sun, 14 Aug 2022 23:23:37 +0000 (16:23 -0700)]
improve FREQUENCIES LAYERED

20 months agoimprove scale summary test
Ben Pfaff [Sun, 14 Aug 2022 22:57:43 +0000 (15:57 -0700)]
improve scale summary test

20 months agopivot-table: fix split file support
Ben Pfaff [Sun, 14 Aug 2022 22:51:41 +0000 (15:51 -0700)]
pivot-table: fix split file support

20 months agorotation works and is tested
Ben Pfaff [Sun, 14 Aug 2022 06:55:02 +0000 (23:55 -0700)]
rotation works and is tested

20 months agorefactoring, I guess
Ben Pfaff [Sun, 14 Aug 2022 06:54:30 +0000 (23:54 -0700)]
refactoring, I guess

20 months agorefacotring 2?
Ben Pfaff [Sun, 14 Aug 2022 06:51:53 +0000 (23:51 -0700)]
refacotring 2?

20 months agorefactoring?
Ben Pfaff [Sun, 14 Aug 2022 06:37:34 +0000 (23:37 -0700)]
refactoring?

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 06:29:44 +0000 (23:29 -0700)]
refactor

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 06:28:17 +0000 (23:28 -0700)]
refactor

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 06:19:59 +0000 (23:19 -0700)]
refactor

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 06:08:33 +0000 (23:08 -0700)]
refactor

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 06:06:59 +0000 (23:06 -0700)]
refactor

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 05:58:35 +0000 (22:58 -0700)]
refactor

20 months agorefactoring
Ben Pfaff [Sun, 14 Aug 2022 05:55:03 +0000 (22:55 -0700)]
refactoring

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 05:52:41 +0000 (22:52 -0700)]
refactor

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 05:49:27 +0000 (22:49 -0700)]
refactor

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 05:46:07 +0000 (22:46 -0700)]
refactor

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 05:45:17 +0000 (22:45 -0700)]
refactor

20 months agorefactor
Ben Pfaff [Sun, 14 Aug 2022 05:44:25 +0000 (22:44 -0700)]
refactor

20 months agoreractor
Ben Pfaff [Sun, 14 Aug 2022 05:41:38 +0000 (22:41 -0700)]
reractor

20 months agorefacotring
Ben Pfaff [Sun, 14 Aug 2022 05:36:53 +0000 (22:36 -0700)]
refacotring

20 months agorefactoring
Ben Pfaff [Sun, 14 Aug 2022 05:34:19 +0000 (22:34 -0700)]
refactoring

20 months agorefactoring
Ben Pfaff [Sun, 14 Aug 2022 05:21:23 +0000 (22:21 -0700)]
refactoring

20 months agorefactoring
Ben Pfaff [Sun, 14 Aug 2022 05:19:55 +0000 (22:19 -0700)]
refactoring

20 months agorafactoring
Ben Pfaff [Sun, 14 Aug 2022 05:17:17 +0000 (22:17 -0700)]
rafactoring

20 months agorefacotring
Ben Pfaff [Sun, 14 Aug 2022 05:09:08 +0000 (22:09 -0700)]
refacotring

20 months agorefactoring
Ben Pfaff [Sun, 14 Aug 2022 04:50:42 +0000 (21:50 -0700)]
refactoring

20 months agorefactoring
Ben Pfaff [Sun, 14 Aug 2022 04:49:56 +0000 (21:49 -0700)]
refactoring

20 months agorefactoring
Ben Pfaff [Sun, 14 Aug 2022 04:48:03 +0000 (21:48 -0700)]
refactoring

20 months agostart making code cleaner
Ben Pfaff [Sun, 14 Aug 2022 00:10:39 +0000 (17:10 -0700)]
start making code cleaner

20 months agoCOLLABELS=LAYER works too
Ben Pfaff [Sun, 14 Aug 2022 00:04:20 +0000 (17:04 -0700)]
COLLABELS=LAYER works too

20 months agoROWLABELS=LAYER works
Ben Pfaff [Sat, 13 Aug 2022 23:53:50 +0000 (16:53 -0700)]
ROWLABELS=LAYER works

20 months agoprogress on ROWLABELS=LAYER
Ben Pfaff [Sat, 13 Aug 2022 23:43:23 +0000 (16:43 -0700)]
progress on ROWLABELS=LAYER

20 months agoCOLLABELS=OPPSITE works now too
Ben Pfaff [Sat, 13 Aug 2022 23:20:28 +0000 (16:20 -0700)]
COLLABELS=OPPSITE works now too

20 months agoROWLABELS=OPPOSITE is correct
Ben Pfaff [Sat, 13 Aug 2022 23:09:29 +0000 (16:09 -0700)]
ROWLABELS=OPPOSITE is correct

20 months agoSUBTABLE works (I'm suspicous about ROW though)
Ben Pfaff [Sat, 13 Aug 2022 22:44:02 +0000 (15:44 -0700)]
SUBTABLE works (I'm suspicous about ROW though)

20 months agoTABLEID, ROWID, COLID, LAYERROWID, LAYERCOLID are OK for ROWLABELS=OPPOSITE
Ben Pfaff [Sat, 13 Aug 2022 22:28:49 +0000 (15:28 -0700)]
TABLEID, ROWID, COLID, LAYERROWID, LAYERCOLID are OK for ROWLABELS=OPPOSITE

20 months agosimplify function specifications in CTABLES
Ben Pfaff [Sat, 13 Aug 2022 20:00:48 +0000 (13:00 -0700)]
simplify function specifications in CTABLES

20 months agoVARIABLE DISPLAY: improve level inference tests
Ben Pfaff [Sat, 13 Aug 2022 04:18:57 +0000 (21:18 -0700)]
VARIABLE DISPLAY: improve level inference tests

20 months agoCTABLES infer variable level
Ben Pfaff [Sat, 13 Aug 2022 04:18:41 +0000 (21:18 -0700)]
CTABLES infer variable level

20 months agoCTABLES split file
Ben Pfaff [Fri, 12 Aug 2022 19:59:02 +0000 (12:59 -0700)]
CTABLES split file

20 months agodates
Ben Pfaff [Fri, 12 Aug 2022 19:44:27 +0000 (12:44 -0700)]
dates

20 months agointersecting pcomputes
Ben Pfaff [Fri, 12 Aug 2022 18:58:33 +0000 (11:58 -0700)]
intersecting pcomputes

20 months agomore pcompute
Ben Pfaff [Fri, 12 Aug 2022 18:10:16 +0000 (11:10 -0700)]
more pcompute

20 months agotest )LABEL[n]
Ben Pfaff [Fri, 12 Aug 2022 17:46:00 +0000 (10:46 -0700)]
test )LABEL[n]

20 months agopivot-table: Allow all pivot_value formatting functions to use defaults.
Ben Pfaff [Fri, 12 Aug 2022 17:15:33 +0000 (10:15 -0700)]
pivot-table: Allow all pivot_value formatting functions to use defaults.

20 months agosplit file test fix
Ben Pfaff [Fri, 12 Aug 2022 16:43:02 +0000 (09:43 -0700)]
split file test fix

20 months agoCTABLES fix DISPLAY=NONE for scale variable names
Ben Pfaff [Wed, 10 Aug 2022 06:30:53 +0000 (23:30 -0700)]
CTABLES fix DISPLAY=NONE for scale variable names

20 months agovlabels tests
Ben Pfaff [Wed, 10 Aug 2022 05:53:36 +0000 (22:53 -0700)]
vlabels tests

20 months agoRevert "work on crash"
Ben Pfaff [Wed, 10 Aug 2022 05:39:18 +0000 (22:39 -0700)]
Revert "work on crash"

This reverts commit 7cd70df07f7e183645853716642810afd4b87bcd.

20 months agowork on crash
Ben Pfaff [Wed, 10 Aug 2022 05:39:10 +0000 (22:39 -0700)]
work on crash

20 months agotest improvement
Ben Pfaff [Wed, 10 Aug 2022 05:37:05 +0000 (22:37 -0700)]
test improvement

21 months agoTest individual-cell summary functions for scale varaibles.
Ben Pfaff [Mon, 8 Aug 2022 05:59:15 +0000 (22:59 -0700)]
Test individual-cell summary functions for scale varaibles.

21 months agorespect value labels in pivot_splits
Ben Pfaff [Mon, 8 Aug 2022 05:33:40 +0000 (22:33 -0700)]
respect value labels in pivot_splits

21 months agoFREQUENCIES and layered split file has tests that work
Ben Pfaff [Mon, 8 Aug 2022 05:26:01 +0000 (22:26 -0700)]
FREQUENCIES and layered split file has tests that work

21 months agoLayered split file for FREQUENCIES works.
Ben Pfaff [Sat, 6 Aug 2022 19:32:01 +0000 (12:32 -0700)]
Layered split file for FREQUENCIES works.

21 months agoCTABLES
Ben Pfaff [Mon, 27 Dec 2021 00:01:47 +0000 (16:01 -0800)]
CTABLES

21 months agodictionary: Limit split file variables to 8, for compatibility.
Ben Pfaff [Sat, 6 Aug 2022 19:31:40 +0000 (12:31 -0700)]
dictionary: Limit split file variables to 8, for compatibility.

21 months agodictionary: Introduce SPLIT_NONE for dictionaries without split variables.
Ben Pfaff [Sat, 6 Aug 2022 17:55:12 +0000 (10:55 -0700)]
dictionary: Introduce SPLIT_NONE for dictionaries without split variables.

21 months agoAutomatically infer variables' measurement level from format and data.
Ben Pfaff [Fri, 29 Jul 2022 21:09:59 +0000 (14:09 -0700)]
Automatically infer variables' measurement level from format and data.

21 months agoUse rsvg-convert instead of GIMP for converting SVG to PNG.
Ben Pfaff [Wed, 3 Aug 2022 23:53:53 +0000 (16:53 -0700)]
Use rsvg-convert instead of GIMP for converting SVG to PNG.

rsvg-convert is much faster and more commonly installed.

21 months agostr: New function ds_put_substring_multiple().
Ben Pfaff [Mon, 1 Aug 2022 04:18:21 +0000 (21:18 -0700)]
str: New function ds_put_substring_multiple().

21 months agolexer: Fix negative 'n0' and 'n1' in lex_source_contains_macro_call().
Ben Pfaff [Mon, 1 Aug 2022 04:16:49 +0000 (21:16 -0700)]
lexer: Fix negative 'n0' and 'n1' in lex_source_contains_macro_call().

21 months agolexer: Support more options in lex_error_expecting_array().
Ben Pfaff [Mon, 1 Aug 2022 04:16:24 +0000 (21:16 -0700)]
lexer: Support more options in lex_error_expecting_array().

21 months agorender: Coding style fix.
Ben Pfaff [Thu, 4 Aug 2022 23:58:53 +0000 (16:58 -0700)]
render: Coding style fix.

21 months agodoc: Improve description of extension subtype 5.
Ben Pfaff [Sat, 6 Aug 2022 19:31:19 +0000 (12:31 -0700)]
doc: Improve description of extension subtype 5.

21 months agopspp-output: Improve usage message.
Ben Pfaff [Thu, 4 Aug 2022 20:58:12 +0000 (13:58 -0700)]
pspp-output: Improve usage message.

21 months agoFREQUENCIES: Fix memory leak with percentiles and split file.
Ben Pfaff [Sat, 6 Aug 2022 17:11:59 +0000 (10:11 -0700)]
FREQUENCIES: Fix memory leak with percentiles and split file.

21 months agoFREQUENCIES: Fix use-after-free error.
Ben Pfaff [Tue, 2 Aug 2022 00:25:49 +0000 (17:25 -0700)]
FREQUENCIES: Fix use-after-free error.

21 months agosyntax-gen: Test the category properly.
Ben Pfaff [Thu, 21 Jul 2022 01:15:34 +0000 (18:15 -0700)]
syntax-gen: Test the category properly.

This code was testing the format type against a collection of format type
categories, which doesn't make any sense.  This commit fixes the problem.

Found by inspection.

21 months agog_memdup2: added src/ui/gui/glibfix.h to the distribution file list
Friedrich Beckmann [Sun, 10 Jul 2022 21:19:55 +0000 (23:19 +0200)]
g_memdup2: added src/ui/gui/glibfix.h to the distribution file list

I forgot to include the new header file for the previous fix in the
list of files for the distribution.

21 months agosupply g_memdup2() for glib before 2.68.
Friedrich Beckmann [Sun, 10 Jul 2022 20:33:24 +0000 (22:33 +0200)]
supply g_memdup2() for glib before 2.68.

The previous commit did not work on debian. I followed the ideas from

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1927

and

https://github.com/mdbtools/gmdb2/commit/62ce520a9c5

So this commit provides g_memdup2 for glib versions which do not
provide g_memdup2.

21 months agoRevert "Add header wrapper for glib to supply g_memdup2() for glib before 2.68."
Friedrich Beckmann [Sun, 10 Jul 2022 19:40:39 +0000 (21:40 +0200)]
Revert "Add header wrapper for glib to supply g_memdup2() for glib before 2.68."

This reverts commit 652517f6e99bca918bf2275003f5d51fe5f2f0c6.

22 months agoAdd header wrapper for glib to supply g_memdup2() for glib before 2.68.
Ben Pfaff [Sat, 9 Jul 2022 15:37:02 +0000 (08:37 -0700)]
Add header wrapper for glib to supply g_memdup2() for glib before 2.68.

Friedrich Beckmann reported that some of our build targets have glib as
old as 2.58.

22 months agoSPLIT FILE: Add LAYERED vs. SEPARATE distinction to the dictionary.
Ben Pfaff [Fri, 8 Jul 2022 22:45:40 +0000 (15:45 -0700)]
SPLIT FILE: Add LAYERED vs. SEPARATE distinction to the dictionary.

22 months agoattributes: New macro ATTRSET_INITIALIZER.
Ben Pfaff [Fri, 8 Jul 2022 22:45:54 +0000 (15:45 -0700)]
attributes: New macro ATTRSET_INITIALIZER.

22 months agogui: Use g_memdup2() instead of deprecated g_memdup().
Ben Pfaff [Fri, 8 Jul 2022 22:44:43 +0000 (15:44 -0700)]
gui: Use g_memdup2() instead of deprecated g_memdup().

22 months agoconfigure: Update autoconf and libtool macro use to fix warnings.
Ben Pfaff [Fri, 8 Jul 2022 22:22:24 +0000 (15:22 -0700)]
configure: Update autoconf and libtool macro use to fix warnings.

22 months agoFix use-after-free errors.
Ben Pfaff [Fri, 8 Jul 2022 17:51:59 +0000 (10:51 -0700)]
Fix use-after-free errors.

Found by GCC 12.1.1.

22 months agoSuppress GCC 12.1.1 warnings.
Ben Pfaff [Fri, 8 Jul 2022 17:51:23 +0000 (10:51 -0700)]
Suppress GCC 12.1.1 warnings.

I don't think these warnings are for real problems, so just suppress them.

I don't understand why the change to datasheet-test.c suppresses a warning,
but it does.

22 months agoRelease version 1.6.2.
Ben Pfaff [Sat, 2 Jul 2022 03:56:07 +0000 (20:56 -0700)]
Release version 1.6.2.

22 months agogui: Fix icon names.
Ben Pfaff [Thu, 30 Jun 2022 21:25:57 +0000 (14:25 -0700)]
gui: Fix icon names.

Using icon-name "org.gnu.pspp" makes the window manager show the PSPP
icon instead of a generic one.

Reported by Friedrich Beckmann.

22 months agotests/atlocal.in - switched from which to command -v
Friedrich Beckmann [Sun, 26 Jun 2022 07:07:18 +0000 (09:07 +0200)]
tests/atlocal.in - switched from which to command -v

Sam James reported a possible future build problem due to the
usage of the "which" command:

https://savannah.gnu.org/bugs/?62675

I replace "which" with "command -v" as proposed. Thanks for your
support.

Closes: 62675
22 months agopspp specific icon not shown in about menu
Friedrich Beckmann [Sat, 25 Jun 2022 19:59:24 +0000 (21:59 +0200)]
pspp specific icon not shown in about menu

The changes of the pspp icon name in

commit 52ba15f3dce

were missing in the help about menu such that the icons were not
shown.

22 months agoDESCRIPTIVES: Fix bad error message.
Ben Pfaff [Sat, 25 Jun 2022 03:37:04 +0000 (20:37 -0700)]
DESCRIPTIVES: Fix bad error message.

22 months agoSmake: Fix icon rendering by using correct application ID.
Ben Pfaff [Fri, 24 Jun 2022 23:37:36 +0000 (16:37 -0700)]
Smake: Fix icon rendering by using correct application ID.

PSPP-specific icons were not showing up properly in the GUI because
the compiled-in resources were looking in gnu.pspp whereas the name
is now org.gnu.pspp.  This fixes the problem.

Fixes: a421d8d9f61b ("Change application ID from org.fsf.pspp to org.gnu.pspp.")
22 months agoRelease version 1.6.1.
Ben Pfaff [Fri, 24 Jun 2022 16:40:10 +0000 (09:40 -0700)]
Release version 1.6.1.

22 months agoSmake: Fix dependencies for src/ui/gui/resources.xml.
Ben Pfaff [Fri, 24 Jun 2022 16:34:05 +0000 (09:34 -0700)]
Smake: Fix dependencies for src/ui/gui/resources.xml.

This file is a list of all the icon files, but generating it doesn't use
icon files themselves, so depending on them isn't useful.  On the other
hand, the file does need to be regenerated if the icon list changes, and
that icon list is in Smake itself, so this target does need to depend on
the Makefiles.

22 months agopo: Update Hungarian translation.
Ben Pfaff [Fri, 24 Jun 2022 16:22:05 +0000 (09:22 -0700)]
po: Update Hungarian translation.

Thanks to Meskó Balázs for updating this translation.

22 months agoChange application ID from org.fsf.pspp to org.gnu.pspp.
Ben Pfaff [Sun, 19 Jun 2022 21:01:09 +0000 (14:01 -0700)]
Change application ID from org.fsf.pspp to org.gnu.pspp.

This includes changing the argument of gtk_application_new() from
"gnu.pspp" to "org.gnu.pspp" for consistency.

Suggested by Hubert Figuière at https://github.com/flathub/flathub/pull/3275.

22 months agoperl: remove references to Memory::Usage module for perl module tests
Friedrich Beckmann [Sun, 19 Jun 2022 15:17:48 +0000 (17:17 +0200)]
perl: remove references to Memory::Usage module for perl module tests

The perl memory test was removed with commits

https://git.savannah.gnu.org/cgit/pspp.git/commit/?id=20934a68593edbd52577f1ba0ea93c74eb018af5

and

https://git.savannah.gnu.org/cgit/pspp.git/commit/?id=05297509d237dc99ba7504ccf260e995586bc3b4

This commit removes the remaining references to the perl memory test.
The configure step still asked for optional Memory::Usage perl module
which is not used without the perl memory test.

22 months agogui: make import assistant window a modal window
Friedrich Beckmann [Sun, 19 Jun 2022 14:30:42 +0000 (16:30 +0200)]
gui: make import assistant window a modal window

I changed the import assistant window to a modal window such that
the other windows cannot be changed while the import is ongoing.
There are problems when the main window is closed during the import.

Closing: https://savannah.gnu.org/bugs/?62448

22 months agoImplement SET LEADZERO.
Ben Pfaff [Sat, 18 Jun 2022 23:29:17 +0000 (16:29 -0700)]
Implement SET LEADZERO.