From: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri, 24 Jun 2022 16:34:05 +0000 (-0700)
Subject: Smake: Fix dependencies for src/ui/gui/resources.xml.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp;a=commitdiff_plain;h=fa3f8d568a5bd4c199fc669f466671b484769285

Smake: Fix dependencies for src/ui/gui/resources.xml.

This file is a list of all the icon files, but generating it doesn't use
icon files themselves, so depending on them isn't useful.  On the other
hand, the file does need to be regenerated if the icon list changes, and
that icon list is in Smake itself, so this target does need to depend on
the Makefiles.
---

diff --git a/Smake b/Smake
index 543ec0e5b0..4a64860104 100644
--- a/Smake
+++ b/Smake
@@ -316,11 +316,11 @@ src/ui/gui/icons/manifest: $(MAKEFILE_LIST)
 	echo >> $@
 
 
-src/ui/gui/resources.xml: $(ICONS)
+src/ui/gui/resources.xml: $(MAKEFILE_LIST)
 	printf '<?xml version="1.0" encoding="UTF-8"?>\n' > $@
 	printf '<gresources>\n' >> $@
 	printf ' <gresource prefix="gnu/pspp">\n' >> $@
-	for x in $^; do \
+	for x in $(ICONS); do \
 	  z=`echo "$$x" | sed -e 's%src/ui/gui/%%'` ; \
 	  printf "  <file>$$z</file>\n" >> $@ ; \
 	done