From: Ben Pfaff <blp@cs.stanford.edu>
Date: Sat, 23 Sep 2017 17:44:01 +0000 (-0700)
Subject: cairo-chart: Make it clear that fabs() of integer values is intended.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp;a=commitdiff_plain;h=dc0e37529d185a9848b0e53d424d40239d195c8c

cairo-chart: Make it clear that fabs() of integer values is intended.

Reported by Clang.
---

diff --git a/src/output/cairo-chart.c b/src/output/cairo-chart.c
index 802aa07bd2..db8eb67ecf 100644
--- a/src/output/cairo-chart.c
+++ b/src/output/cairo-chart.c
@@ -389,8 +389,9 @@ xrchart_write_scale (cairo_t *cr, struct xrchart_geometry *geom,
   geom->axis[orient].max = upper;
   geom->axis[orient].min = lower;
 
-  geom->axis[orient].scale = (fabs (geom->axis[orient].data_max - geom->axis[orient].data_min)
-			      / fabs (geom->axis[orient].max - geom->axis[orient].min));
+  struct xrchart_axis *axis = &geom->axis[orient];
+  geom->axis[orient].scale = (fabs ((double) axis->data_max - axis->data_min)
+			      / fabs (axis->max - axis->min));
 
   if (orient == SCALE_ABSCISSA)
     {