From: John Darrington <john@darrington.wattle.id.au>
Date: Sun, 21 Mar 2021 21:19:25 +0000 (+0100)
Subject: Fix bug where attempting to rendering an empty bar chart would crash
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp;a=commitdiff_plain;h=b56f017491ffecdbe19e39aca242ffb13ad17016

Fix bug where attempting to rendering an empty bar chart would crash
---

diff --git a/src/language/stats/frequencies.c b/src/language/stats/frequencies.c
index 736b6ae555..a6ef914b03 100644
--- a/src/language/stats/frequencies.c
+++ b/src/language/stats/frequencies.c
@@ -1489,10 +1489,13 @@ do_barchart(const struct frq_chart *bar, const struct variable **var,
   int n_slices;
   struct freq **slices = pick_cat_counts_ptr (bar, frq_tab, &n_slices);
 
-  chart_submit (barchart_create (var, 1,
-                                 (bar->y_scale == FRQ_FREQ) ? _("Count") : _("Percent"),
-                                 (bar->y_scale == FRQ_PERCENT),
-                                 slices, n_slices));
+  if (n_slices < 1)
+    msg (SW, _("Omitting bar chart, which has no values."));
+  else
+    chart_submit (barchart_create (var, 1,
+                                   (bar->y_scale == FRQ_FREQ) ? _("Count") : _("Percent"),
+                                   (bar->y_scale == FRQ_PERCENT),
+                                   slices, n_slices));
   free (slices);
 }