From: John Darrington <john@darrington.wattle.id.au>
Date: Sat, 29 Jul 2017 05:30:50 +0000 (+0200)
Subject: Linreg.c: Remove QR decomposition optimisation.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp;a=commitdiff_plain;h=8961943f7492c63ba29cbb61faf698b59aca4ff2

Linreg.c: Remove QR decomposition optimisation.

Fixes bug #51373.
---

diff --git a/src/math/linreg.c b/src/math/linreg.c
index 600262f6fb..b5ccbc5999 100644
--- a/src/math/linreg.c
+++ b/src/math/linreg.c
@@ -432,6 +432,9 @@ linreg_fit (const gsl_matrix *cov, struct linreg *l)
 
   l->sst = gsl_matrix_get (cov, cov->size1 - 1, cov->size2 - 1);
 
+#if 0
+  /*  This QR decomposition path seems to produce the incorrect
+      values.  See https://savannah.gnu.org/bugs/?51373  */
   if ((l->n_obs * l->n_obs > l->n_indeps) && (l->n_obs > REG_LARGE_DATA))
     {
       /*
@@ -440,6 +443,7 @@ linreg_fit (const gsl_matrix *cov, struct linreg *l)
       linreg_fit_qr (cov, l);
     }
   else
+#endif    
     {
       gsl_matrix *params = gsl_matrix_calloc (cov->size1, cov->size2);
       gsl_matrix_memcpy (params, cov);