From: John Darrington Date: Mon, 4 Jan 2016 19:30:45 +0000 (+0100) Subject: Fix bad syntax generation introduced by previous commit. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp;a=commitdiff_plain;h=8855cb5d6ff72efd5bdb05b339cf9fb175991d5e Fix bad syntax generation introduced by previous commit. Commit cdfb21de2cbbf921b4e1fe0662439da1c460eabc replaced syntax_gen_pspp with g_string_append_printf which was wrong, because the latter is sensitive to the user's locale, which is not desired for syntax generation. --- diff --git a/src/ui/gui/psppire-dialog-action-logistic.c b/src/ui/gui/psppire-dialog-action-logistic.c index 0c4dc19cdc..5fb5570315 100644 --- a/src/ui/gui/psppire-dialog-action-logistic.c +++ b/src/ui/gui/psppire-dialog-action-logistic.c @@ -198,12 +198,13 @@ generate_syntax (PsppireDialogAction *a) g_string_append (strx, categoricals->str); g_string_free (categoricals, TRUE); g_slist_free (vars); - - g_string_append (strx, "\n\t/CRITERIA ="); - - g_string_append_printf (strx, " CUT(%g)", rd->cut_point); - g_string_append_printf (strx, " ITERATE(%d)", rd->max_iterations); + struct string opt_str; + ds_init_cstr (&opt_str, "\n\t/CRITERIA ="); + syntax_gen_pspp (&opt_str, " CUT(%g)", rd->cut_point); + syntax_gen_pspp (&opt_str, " ITERATE(%d)", rd->max_iterations); + g_string_append (strx, ds_data (&opt_str)); + ds_destroy (&opt_str); if (rd->conf) {