From: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri, 3 Jun 2022 22:01:19 +0000 (-0700)
Subject: line-reader: Avoid undefined behavior in printf utility in test.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp;a=commitdiff_plain;h=88040421bb6cbf3f225280f1efaf07661ac2e9bf

line-reader: Avoid undefined behavior in printf utility in test.

The test used
    printf '\"'
assuming that it would print just a double-quote, but on at least one
system it printed a backslash followed by a double-quote.  This commit
changes it to
    print '"'
which should be reliable everywhere.

Thanks to Michael Orlitzky <michael@orlitzky.com> for reporting this bug.
---

diff --git a/tests/libpspp/line-reader.at b/tests/libpspp/line-reader.at
index 1f1dd0c6fc..63801bc5fe 100644
--- a/tests/libpspp/line-reader.at
+++ b/tests/libpspp/line-reader.at
@@ -65,9 +65,9 @@ AT_CHECK([i18n-test supports_encodings ISO-8859-1])
 buffer_size=`line-reader-test buffer-size`
 ($PYTHON3 -c "import sys; sys.stdout.write('x' * ($buffer_size - 2))";
  printf '\none line\ntwo lines\nentr\351e\nfour lines\n') > input
-(printf 'encoded in ASCII (auto)\n\"'
+(printf 'encoded in ASCII (auto)\n"'
  $PYTHON3 -c "import sys; sys.stdout.write('x' * ($buffer_size - 2))";
- printf '\"\n"one line"\n"two lines"\nencoded in ISO-8859-1\n"entr\303\251e"\n"four lines"\n') > expout
+ printf '"\n"one line"\n"two lines"\nencoded in ISO-8859-1\n"entr\303\251e"\n"four lines"\n') > expout
 AT_CHECK([line-reader-test read input Auto,ISO-8859-1], [0], [expout])
 AT_CLEANUP