From: John Darrington <john@darrington.wattle.id.au>
Date: Sat, 2 Oct 2021 14:35:42 +0000 (+0200)
Subject: Fix memory leak upon failure to create matrix reader
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp;a=commitdiff_plain;h=6b089ebd8cacb6c57d6eef503c2de45f8b659d52

Fix memory leak upon failure to create matrix reader
---

diff --git a/src/language/data-io/matrix-reader.c b/src/language/data-io/matrix-reader.c
index 589a2989fa..a9dd4f4952 100644
--- a/src/language/data-io/matrix-reader.c
+++ b/src/language/data-io/matrix-reader.c
@@ -353,7 +353,10 @@ cmd_debug_matrix_read (struct lexer *lexer, struct dataset *ds)
         mem_writer_create (dict_get_proto (dataset_dict (ds))));
       struct matrix_reader *mr = matrix_reader_create (dataset_dict (ds), cr);
       if (!mr)
-        return CMD_FAILURE;
+        {
+          casereader_destroy (cr);
+          return CMD_FAILURE;
+        }
       matrix_reader_destroy (mr);
       return CMD_SUCCESS;
     }