From: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri, 7 Nov 2014 03:39:44 +0000 (-0800)
Subject: Factor out and generalize dump_data_value().
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp;a=commitdiff_plain;h=0c1b1350bb909ea138816d266bf66c59c864e95b

Factor out and generalize dump_data_value().
---

diff --git a/dump.c b/dump.c
index 230274f8af..b33b824228 100644
--- a/dump.c
+++ b/dump.c
@@ -592,6 +592,96 @@ dump_data_value_31(void)
     match_byte_assert (0x58);
 }
 
+static void
+dump_data_value(void)
+{
+  match_byte(0);
+  match_byte(0);
+  match_byte(0);
+  match_byte(0);
+  if (match_byte (1))
+    {
+      unsigned int format;
+      double value;
+
+      dump_data_value_31();
+      format = get_u32 ();
+      value = get_double ();
+      printf ("    value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
+    }
+  else if (match_byte (3))
+    {
+      get_string();
+      dump_data_value_31();
+      get_string();
+      printf("string \"%s\"", get_string());
+      match_byte (0);
+    }
+  else if (match_byte (2))
+    {
+      unsigned int format;
+      char *var, *vallab;
+      double value;
+
+      match_byte_assert (0x58);
+      format = get_u32 ();
+      value = get_double ();
+      var = get_string ();
+      vallab = get_string ();
+      printf ("value %g format %d(%d.%d) var \"%s\" vallab \"%s\"",
+              value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
+      if (!match_byte (1) && !match_byte(2))
+        match_byte_assert (3);
+    }
+  else if (match_byte (4))
+    {
+      unsigned int format;
+      char *var, *vallab, *value;
+
+      match_byte_assert (0x58);
+      format = get_u32 ();
+      vallab = get_string ();
+      var = get_string ();
+      if (!match_byte(1) && !match_byte(2))
+        match_byte_assert (3);
+      value = get_string ();
+      printf ("value \"%s\" format %d(%d.%d) var \"%s\" vallab \"%s\"",
+              value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
+    }
+  else if (match_byte (5))
+    {
+      match_byte_assert (0x58);
+      printf ("variable \"%s\"", get_string());
+      get_string();
+      if (!match_byte(1) && !match_byte(2))
+        match_byte_assert(3);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+    }
+  else
+    {
+      dump_data_value_31();
+      char *base = get_string();
+      int x = get_u32();
+      printf ("\"%s\"; %d variables:\n", base, x);
+      for (int i = 0; i < x; i++)
+        {
+          int y = get_u32();
+          if (!y)
+            y = 1;
+          else
+            match_u32_assert(0);
+          for (int j = 0; j <= 0; j++)
+            printf ("    ");
+          printf("variable %d has %d values:\n", i, y);
+          for (int j = 0; j < y; j++)
+            dump_data_value();
+        }
+    }
+}
+
 static void
 dump_data(void)
 {
@@ -615,131 +705,7 @@ dump_data(void)
     {
       printf("%08x, index %d:\n", pos, get_u32());
       match_u32_assert(0);
-      match_byte(0);
-      match_byte(0);
-      match_byte(0);
-      match_byte(0);
-      if (match_byte (1))
-        {
-          unsigned int format;
-          double value;
-
-          dump_data_value_31();
-          format = get_u32 ();
-          value = get_double ();
-          printf ("    value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
-        }
-      else if (match_byte (3))
-        {
-          get_string();
-          dump_data_value_31();
-          get_string();
-          printf("string \"%s\"", get_string());
-          match_byte (0);
-        }
-      else if (match_byte (2))
-        {
-          unsigned int format;
-          char *var, *vallab;
-          double value;
-
-          match_byte_assert (0x58);
-          format = get_u32 ();
-          value = get_double ();
-          var = get_string ();
-          vallab = get_string ();
-          printf ("value %g format %d(%d.%d) var \"%s\" vallab \"%s\"",
-                  value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
-          if (!match_byte (1) && !match_byte(2))
-            match_byte_assert (3);
-        }
-      else if (match_byte (4))
-        {
-          unsigned int format;
-          char *var, *vallab, *value;
-
-          match_byte_assert (0x58);
-          format = get_u32 ();
-          vallab = get_string ();
-          var = get_string ();
-          if (!match_byte(1) && !match_byte(2))
-            match_byte_assert (3);
-          value = get_string ();
-          printf ("value \"%s\" format %d(%d.%d) var \"%s\" vallab \"%s\"",
-                  value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
-        }
-      else if (match_byte (5))
-        {
-          match_byte_assert (0x58);
-          printf ("variable \"%s\"", get_string());
-          get_string();
-          if (!match_byte(1) && !match_byte(2))
-            match_byte_assert(3);
-          match_byte (0);
-          match_byte (0);
-          match_byte (0);
-          match_byte (0);
-        }
-      else
-        {
-          dump_data_value_31();
-          char *base = get_string();
-          int x = get_u32();
-          printf ("\"%s\"; %d variables:\n", base, x);
-          for (int i = 0; i < x; i++)
-            {
-              int y = get_u32();
-              if (!y)
-                y = 1;
-              else
-                match_u32_assert(0);
-              for (int j = 0; j <= 0; j++)
-                printf ("    ");
-              printf("variable %d has %d values:\n", i, y);
-              for (int j = 0; j < y; j++)
-                {
-                  if (match_byte (1))
-                    {
-                      unsigned int format;
-                      double value;
-
-                      dump_data_value_31();
-                      format = get_u32 ();
-                      value = get_double ();
-                      printf ("    value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
-                    }
-                  else if (match_byte(3))
-                    {
-                      char *a = get_string();
-                      match_byte_assert(0x58);
-                      char *b = get_string();
-                      char *c = get_string();
-                      for (int k = 0; k <= 1; k++)
-                        printf ("    ");
-                      printf ("\"%s\", \"%s\", \"%s\"", a, b, c);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                    }
-                  else if (match_byte(5))
-                    {
-                      match_byte_assert (0x58);
-                      printf ("variable \"%s\"", get_string());
-                      get_string();
-                      if (!match_byte(1) && !match_byte(2))
-                        match_byte_assert(3);
-                      match_byte (0);
-                      match_byte (0);
-                      match_byte (0);
-                      match_byte (0);
-                    }
-                  else
-                    dump_value (0);
-                  putchar('\n');
-                }
-            }
-        }
+      dump_data_value();
       putchar('\n');
     }
 }