DELETE VARIABLES: Fix crash with FILTER. 20130521010504/pspp
authorBen Pfaff <blp@cs.stanford.edu>
Tue, 21 May 2013 06:49:54 +0000 (23:49 -0700)
committerBen Pfaff <blp@cs.stanford.edu>
Tue, 21 May 2013 06:49:54 +0000 (23:49 -0700)
commitdb161068bfd5b6685f909f39b2a4701ed4941b03
treede718c160208dbc1d1c52846eb6b2adb4ad8f51d
parent6c15f78893f677ccdd45715640bf79961011d529
DELETE VARIABLES: Fix crash with FILTER.

FILTER has the surprising property that it introduces a temporary
transformation, even if proc_make_temporary_transformations_permanent()
was previously called.  This causes a crash if the procedure implementation
really relies on there being no temporary transformations.

This commit fixes the problem in the procedures I was able to identify as
having it, adds a comment to proc_make_temporary_transformations_permanent()
to make it a little less likely to happen again, and adds a test
specifically to check for regression on DELETE VARIABLES.

Reported by John Darrington.
Bug #38843.
src/data/dataset.c
src/language/data-io/combine-files.c
src/language/dictionary/delete-variables.c
src/language/stats/descriptives.c
src/language/stats/flip.c
src/language/stats/regression.c
tests/automake.mk
tests/language/dictionary/delete-variables.at [new file with mode: 0644]