X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp;a=blobdiff_plain;f=results2html;h=4e3224fca3ba9589f147706469845ed5692612e0;hp=4bf398d35c49b9734d92578e3abdc4a6c71f37d2;hb=9869b64641f5197bd495a5e62cdbb3f985adbeee;hpb=59f020fe17e2c7815d4ebb941aa0240590de2d17

diff --git a/results2html b/results2html
index 4bf398d35c..4e3224fca3 100755
--- a/results2html
+++ b/results2html
@@ -5,6 +5,9 @@ use warnings;
 
 use File::Spec;
 use HTML::Entities;
+use URI::Escape;
+
+my $gitweb_url = 'http://benpfaff.org/cgi-bin/gitweb.cgi?p=pspp;a=blob;f=[FILE];hb=[BRANCH]#l[LINE]';
 
 open (LOG, '<', "LOG");
 open (LOG_HTML, '>', "log.html");
@@ -37,6 +40,8 @@ my (@products);
 my (@steps);
 my ($new_page) = 0;
 my ($result) = "failure";
+my (%dist_files);
+my ($dist_dir);
 my @dirstack;
 while (<LOG>) {
     my $ln = $.;
@@ -59,7 +64,7 @@ while (<LOG>) {
     if ($new_page) {
 	$new_page = 0;
 	$log_class = "step";
-	if (my ($name, $product) = /^Saving(?:([^:]*):)?\s+(.*)$/) {
+	if (my ($name, $product) = /^Saving(?:\s+([^:]*):)?\s+(.*)$/) {
 	    my $href = "$product/index.html";
 	    $href = $product if ! -e $href;
 
@@ -70,6 +75,19 @@ while (<LOG>) {
 	    $p{LN} = $ln;
 	    push (@products, \%p);
 	    push (@{$steps[$#steps]{CHILDREN}}, \%p);
+
+	    if (defined ($name) && $name eq 'source distribution') {
+		open (DIST, '-|', "zcat $product | tar tf -");
+		while (my $line = <DIST>) {
+		    chomp $line;
+		    $line =~ s%^([./])*%%; # Trim leading ./
+		    $dist_files{$line} = 1;
+		    if (!defined ($dist_dir)) {
+			$dist_dir = (split ('/', $line))[0];
+		    }
+		}
+		close (DIST);
+	    }
 	} else {
 	    my (%s);
 	    $s{TITLE} = $_;
@@ -84,19 +102,30 @@ while (<LOG>) {
 	    $d{MESSAGE} = $_;
 	    $d{LN} = $ln;
 
-	    if (@dirstack && (my ($file, $line) = /^([^\s:]+):(\d+):\s/)) {
+	    if (@dirstack && defined ($dist_dir)
+		&& (my ($match, $file, $line) = /^(([^\s:]+):(\d+):)/)) {
 		$file = File::Spec->rel2abs ($file, $dirstack[$#dirstack]);
 		my (@path) = grep ($_ ne '' && $_ ne '.', split ('/', $file));
-		for (my $i = 0; $i < $#path; ) {
-		    if ($path[$i + 1] eq '..') {
-			splice (@path, $i, 2);
+		for (my $i = 1; $i <= $#path; ) {
+		    if ($path[$i] eq '..') {
+			splice (@path, $i - 1, 2);
+			$i-- if $i > 1;
 		    } else {
 			$i++;
 		    }
 		}
 
-		$d{LINE} = $line;
-		$d{FILE} = join ('/', @path);
+		for (my $i = $#path; $i >= 0; $i--) {
+		    if ($path[$i] eq $dist_dir) {
+			my $dist_file = join ('/', @path[$i..$#path]);
+			if (exists ($dist_files{$dist_file})) {
+			    $d{MATCH} = length ($match);
+			    $d{LINE} = $line;
+			    $d{FILE} = $dist_file;
+			}
+			last;
+		    }
+		}
 	    }
 	    push (@{$steps[$#steps]{CHILDREN}}, \%d);
 
@@ -158,12 +187,22 @@ foreach my $s (@steps) {
     foreach my $c (@{$s->{CHILDREN}}) {
 	if (defined ($c->{DIAGNOSTIC})) {
 	    print INDEX "<p class=\"$c->{DIAGNOSTIC}\">";
-	    print INDEX "<a href=\"log.html#$c->{LN}\">";
-	    print INDEX encode_entities ($c->{MESSAGE});
-	    print INDEX "</a>";
-	    if (exists $c->{FILE}) {
-		print INDEX " in $c->{FILE}";
+	    if (defined ($c->{MATCH})) {
+		my $href = $gitweb_url;
+		$href =~ s/\[FILE\]/uri_escape ($c->{FILE})/ge;
+		$href =~ s/\[LINE\]/$c->{LINE}/g;
+		$href =~ s/\[BRANCH\]/uri_escape ($vars{'dist_commit'})/e;
+
+		print INDEX '<a href="', encode_entities ($href), '">';
+		print INDEX encode_entities (substr ($c->{MESSAGE},
+						     0, $c->{MATCH}));
+		print INDEX '</a>';
+		print INDEX encode_entities (substr ($c->{MESSAGE},
+						     $c->{MATCH}));
+	    } else {
+		print INDEX encode_entities ($c->{MESSAGE});
 	    }
+	    print INDEX " ", log_link ($c->{LN});
 	    print INDEX "</p>\n";
 	} else {
 	    print INDEX "<p>&rarr; <a href=\"", encode_entities ($c->{HREF}), "\">";