From: Ben Pfaff <blp@gnu.org>
Date: Wed, 8 Apr 2009 03:48:10 +0000 (-0700)
Subject: Remove redundant test in lex_is_idn().
X-Git-Tag: v0.7.3~175
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp-builds.git;a=commitdiff_plain;h=ef35211c05259417e4f3dd4a7de44e92e4bc54a3

Remove redundant test in lex_is_idn().

Commit 90f346cc0 "Made var_is_valid_name more permissive" made characters
with values above 127 valid in identifiers by allowing them in
lex_is_id1() and lex_is_idn(), but since the latter includes the former
in its test the addition there is redundant and can be eliminated.
---

diff --git a/src/data/identifier.c b/src/data/identifier.c
index 37384b6d..7bd2261e 100644
--- a/src/data/identifier.c
+++ b/src/data/identifier.c
@@ -1,5 +1,5 @@
 /* PSPP - a program for statistical analysis.
-   Copyright (C) 1997-9, 2000, 2005 Free Software Foundation, Inc.
+   Copyright (C) 1997-9, 2000, 2005, 2009 Free Software Foundation, Inc.
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -45,7 +45,7 @@ bool
 lex_is_idn (char c_)
 {
   unsigned char c = c_;
-  return lex_is_id1 (c) || isdigit (c) || c == '.' || c == '_' || c >= 128;
+  return lex_is_id1 (c) || isdigit (c) || c == '.' || c == '_';
 }
 
 /* Returns the length of the longest prefix of STRING that forms