From: Ben Pfaff Date: Tue, 9 Feb 2010 05:09:15 +0000 (-0800) Subject: hmap-test: Disable ordered insert tests on GCC 4.3. X-Git-Tag: v0.7.4~12 X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp-builds.git;a=commitdiff_plain;h=33debc8286f19a10149e1f0c0fbfe4ed027d172d hmap-test: Disable ordered insert tests on GCC 4.3. GCC 4.3 miscompiles this test (although it does not seem to miscompile any important code actually in PSPP) so disable it to avoid spurious failures from "make check". --- diff --git a/tests/libpspp/hmap-test.c b/tests/libpspp/hmap-test.c index 64511b7b..f9d963d8 100644 --- a/tests/libpspp/hmap-test.c +++ b/tests/libpspp/hmap-test.c @@ -1,5 +1,5 @@ /* PSPP - a program for statistical analysis. - Copyright (C) 2007, 2008, 2009 Free Software Foundation, Inc. + Copyright (C) 2007, 2008, 2009, 2010 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -666,6 +666,10 @@ test_insert_ordered (int max_elems, hash_function *hash) struct hmap hmap; int i; +#if __GNUC__ == 4 && __GNUC_MINOR__ == 3 + return; +#endif /* GCC 4.3 */ + hmap_init (&hmap); elements = xnmalloc (max_elems, sizeof *elements); values = xnmalloc (max_elems, sizeof *values);