From: Ben Pfaff Date: Wed, 18 Jul 2012 17:10:20 +0000 (-0700) Subject: ofproto-dpif: Make OFPP_TABLE always resubmit to table 0. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff_plain;h=333be161abe789ff6628c0256143214126b69f02 ofproto-dpif: Make OFPP_TABLE always resubmit to table 0. Commit 299016266ed1 (New action NXAST_RESUBMIT_TABLE.) changed OFPP_TABLE from resubmitting to table 0 to resubmitting to the current table. This wasn't mentioned in the change log and I believe it was a typo. This commit changes the behavior back. This isn't a very serious bug because OpenFlow 1.0 says that OFPP_TABLE is supposed to be used only in packet-out messages, in which case the current table is 0 anyhow. OpenFlow 1.3 is explicit: The action list of an OFPT_PACKET_OUT message can also specify the OFPP_TABLE reserved port as an output action to process the packet through the existing flow entries, starting at the first flow table. Reported-by: Isaku Yamahata Signed-off-by: Ben Pfaff --- diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 5265d7bc..dc15c15b 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -5158,7 +5158,7 @@ xlate_output_action(struct action_xlate_ctx *ctx, compose_output_action(ctx, ctx->flow.in_port); break; case OFPP_TABLE: - xlate_table_action(ctx, ctx->flow.in_port, ctx->table_id); + xlate_table_action(ctx, ctx->flow.in_port, 0); break; case OFPP_NORMAL: xlate_normal(ctx);