From fd38af85a50c623b5f00a1fc61f4dc7debe50fb1 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 26 Sep 2012 09:57:28 -0700 Subject: [PATCH] Deprecate referring to ports by name in ovs-ofctl. This is a necessary step toward supporting full 32-bit OF1.1+ port numbers in a later version of OVS. Signed-off-by: Ben Pfaff Acked-by: Ethan Jackson --- NEWS | 13 +++++++------ lib/ofp-util.c | 6 +++--- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/NEWS b/NEWS index 38e51297..29fd9f37 100644 --- a/NEWS +++ b/NEWS @@ -28,12 +28,13 @@ post-v1.8.0 program was not included in distribution packaging.) - ovsdb-server now enforces the immutability of immutable columns. This was not enforced in earlier versions due to an oversight. - - Stable bond mode is deprecated and will be removed no earlier than - February 2013. Please email dev@openvswitch.org with concerns. - - The autopath action is deprecated and will be removed no earlier than - February 2013. Please email dev@openvswitch.org with concerns. - - The null interface type is deprecated and will be removed no earlier - than February 2013. Please email dev@openvswitch.org with concerns. + - The following features are now deprecated. They will be removed no + earlier than February 2013. Please email dev@openvswitch.org with + concerns. + - Stable bond mode. + - The autopath action. + - Interface type "null". + - Numeric values for reserved ports (see "ovs-ofctl" note above). v1.8.0 - xx xxx xxxx diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 366dcae0..c78199f7 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -3569,9 +3569,9 @@ ofputil_port_from_string(const char *s) ds_init(&s); ofputil_format_port(port32, &s); - VLOG_WARN("port %u is better referred to as %s, for compatibility " - "with future versions of OpenFlow", - port32, ds_cstr(&s)); + VLOG_WARN_ONCE("referring to port %s as %u is deprecated for " + "compatibility with future versions of OpenFlow", + ds_cstr(&s), port32); ds_destroy(&s); return port32; -- 2.30.2