From fba83e40339148ab8515d4ee06f6b173462ad444 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Thu, 13 Nov 2008 10:25:06 -0800 Subject: [PATCH] Never free an skb that has been passed to genlmsg_reply(). genlmsg_reply() always consumes its argument, not just in the success case. --- datapath/datapath.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 07fa92d0..2a8e5a96 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -1176,8 +1176,7 @@ static int dp_genl_query(struct sk_buff *skb, struct genl_info *info) genlmsg_end(ans_skb, data); err = genlmsg_reply(ans_skb, info); - if (!err) - ans_skb = NULL; + ans_skb = NULL; } err: nla_put_failure: -- 2.30.2