From fb344b867b96a6d6b9ec32e277cae6db68f2f236 Mon Sep 17 00:00:00 2001 From: Justin Pettit Date: Mon, 16 Nov 2009 16:36:21 -0800 Subject: [PATCH] ovs-appctl: Fix shadow variable that could cause segfault The variable "socket_name" contains the name of the unix domain socket to be used for communicating with the OVS process. If the target does not begin with a "/", the socket name is determined based on a pidfile. A shadow copy of "socket_name" was kept in the block that looks at the pidfile, which would cause the function-level one to not be set. This removes that shadow copy. --- utilities/ovs-appctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/utilities/ovs-appctl.c b/utilities/ovs-appctl.c index 060e8e28..1302bf2e 100644 --- a/utilities/ovs-appctl.c +++ b/utilities/ovs-appctl.c @@ -170,7 +170,6 @@ connect_to_target(const char *target) if (target[0] != '/') { char *pidfile_name; - char *socket_name; pid_t pid; pidfile_name = xasprintf("%s/%s.pid", ovs_rundir, target); -- 2.30.2