From fac1a01e39ca1cddd2dd5d5d672136e3d78c766b Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 4 Mar 2000 07:57:35 +0000 Subject: [PATCH] Add Bruno's comment justifying use of volatile. --- lib/localcharset.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/localcharset.c b/lib/localcharset.c index 86f43b5889..461320823d 100644 --- a/lib/localcharset.c +++ b/lib/localcharset.c @@ -48,6 +48,12 @@ char *xmalloc (); char *xrealloc (); +/* The following static variable is declared 'volatile' to avoid a + possible multithread problem in the function get_charset_aliases. If we + are running in a threaded environment, and if two threads initialize + 'charset_aliases' simultaneously, both will produce the same value, + and everything will be ok if the two assignments to 'charset_aliases' + are atomic. But I don't know what will happen if the two assignments mix. */ /* Pointer to the contents of the charset.alias file, if it has already been read, else NULL. Its format is: ALIAS_1 '\0' CANONICAL_1 '\0' ... ALIAS_n '\0' CANONICAL_n '\0' '\0' */ -- 2.30.2