From f8ddccd2852c10758854ac18c7d440cca68e3964 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 4 May 2011 10:26:58 -0700 Subject: [PATCH] bond: New function bond_slave_set_netdev(). To be used by an upcoming change. --- lib/bond.c | 39 ++++++++++++++++++++++++++++++--------- lib/bond.h | 1 + 2 files changed, 31 insertions(+), 9 deletions(-) diff --git a/lib/bond.c b/lib/bond.c index ed6ed89b..20831084 100644 --- a/lib/bond.c +++ b/lib/bond.c @@ -330,6 +330,21 @@ bond_reconfigure(struct bond *bond, const struct bond_settings *s) return revalidate; } +static void +bond_slave_set_netdev__(struct bond *bond, struct bond_slave *slave, + struct netdev *netdev) +{ + if (slave->netdev != netdev) { + if (bond->monitor) { + if (slave->netdev) { + netdev_monitor_remove(bond->monitor, slave->netdev); + } + netdev_monitor_add(bond->monitor, netdev); + } + slave->netdev = netdev; + } +} + /* Registers 'slave_' as a slave of 'bond'. The 'slave_' pointer is an * arbitrary client-provided pointer that uniquely identifies a slave within a * bond. If 'slave_' already exists within 'bond' then this function @@ -369,20 +384,26 @@ bond_slave_register(struct bond *bond, void *slave_, uint16_t stb_id, bond->bond_revalidate = true; } - if (slave->netdev != netdev) { - if (bond->monitor) { - if (slave->netdev) { - netdev_monitor_remove(bond->monitor, slave->netdev); - } - netdev_monitor_add(bond->monitor, netdev); - } - slave->netdev = netdev; - } + bond_slave_set_netdev__(bond, slave, netdev); free(slave->name); slave->name = xstrdup(netdev_get_name(netdev)); } +/* Updates the network device to be used with 'slave_' to 'netdev'. + * + * This is useful if the caller closes and re-opens the network device + * registered with bond_slave_register() but doesn't need to change anything + * else. */ +void +bond_slave_set_netdev(struct bond *bond, void *slave_, struct netdev *netdev) +{ + struct bond_slave *slave = bond_slave_lookup(bond, slave_); + if (slave) { + bond_slave_set_netdev__(bond, slave, netdev); + } +} + /* Unregisters 'slave_' from 'bond'. If 'bond' does not contain such a slave * then this function has no effect. * diff --git a/lib/bond.h b/lib/bond.h index b2ab89cd..8736f4cd 100644 --- a/lib/bond.h +++ b/lib/bond.h @@ -75,6 +75,7 @@ void bond_destroy(struct bond *); bool bond_reconfigure(struct bond *, const struct bond_settings *); void bond_slave_register(struct bond *, void *slave_, uint16_t stable_id, struct netdev *); +void bond_slave_set_netdev(struct bond *, void *slave_, struct netdev *); void bond_slave_unregister(struct bond *, const void *slave); void bond_run(struct bond *, struct tag_set *, bool lacp_negotiated); -- 2.30.2