From f5cd6874f1e4efcd1d513a294bf7709933959b97 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Sun, 13 May 2012 16:34:49 -0700 Subject: [PATCH] Avoid writes to variables that are never read back. Found by clang. Signed-off-by: Ben Pfaff --- lib/ofp-print.c | 2 +- utilities/ovs-vsctl.c | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/ofp-print.c b/lib/ofp-print.c index 7479bf22..1757a30c 100644 --- a/lib/ofp-print.c +++ b/lib/ofp-print.c @@ -480,7 +480,7 @@ ofp_print_bit_names(struct ds *string, uint32_t bits, } if (bits) { - if (n++) { + if (n) { ds_put_char(string, ' '); } ds_put_format(string, "0x%"PRIx32, bits); diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index 2fc87f00..d8aeb53d 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -3809,8 +3809,6 @@ do_vsctl(const char *args, struct vsctl_command *commands, size_t n_commands, if (ctx.try_again) { vsctl_context_done(&ctx, NULL); - - status = TXN_TRY_AGAIN; goto try_again; } } -- 2.30.2