From f446d59b369ec2c5df79ee3589c50eb22f949a63 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 10 Feb 2010 11:13:09 -0800 Subject: [PATCH] vswitch: Fix uninitialized variable. The 'ip' variable in this inner "if" statement shadows a variable with the same name in the enclosing block. The variable in the inner block is never initialized. Found by Clang (http://clang-analyzer.llvm.org). --- vswitchd/bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 05ace798..53b20e32 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -1472,7 +1472,7 @@ bridge_reconfigure_controller(const struct ovsrec_open_vswitch *ovs_cfg, local_iface = bridge_get_local_iface(br); if (local_iface && c->local_ip && inet_aton(c->local_ip, &ip)) { struct netdev *netdev = local_iface->netdev; - struct in_addr ip, mask, gateway; + struct in_addr mask, gateway; if (!c->local_netmask || !inet_aton(c->local_netmask, &mask)) { mask.s_addr = 0; -- 2.30.2