From e083132e9d963a85aadc2f7d4f1eafcabc1d05d4 Mon Sep 17 00:00:00 2001 From: John Darrington Date: Sat, 5 Oct 2013 12:30:12 +0200 Subject: [PATCH] MEANS: Fix potential errors in gui syntax generation --- src/ui/gui/psppire-dialog-action-means.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ui/gui/psppire-dialog-action-means.c b/src/ui/gui/psppire-dialog-action-means.c index 64d0f32876..6ebda50551 100644 --- a/src/ui/gui/psppire-dialog-action-means.c +++ b/src/ui/gui/psppire-dialog-action-means.c @@ -51,8 +51,10 @@ generate_syntax (PsppireDialogAction *act) GtkTreeIter iter; PsppireVarView *vv = PSPPIRE_VAR_VIEW (layer->var_view); psppire_var_view_set_current_model (vv, l); - g_string_append (string, "\n\tBY"); - for (ok = psppire_var_view_get_iter_first (vv, &iter); + ok = psppire_var_view_get_iter_first (vv, &iter); + if (ok) + g_string_append (string, "\n\tBY"); + for (; ok; ok = psppire_var_view_get_iter_next (vv, &iter)) { @@ -62,7 +64,7 @@ generate_syntax (PsppireDialogAction *act) } } - g_string_append (string, "."); + g_string_append (string, ".\n"); text = string->str; g_string_free (string, FALSE); -- 2.30.2