From aa0f5d7586efe7044f6ca9e07be3f579ee0d5618 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Wed, 16 Feb 2011 14:15:51 -0700 Subject: [PATCH] maintainer-makefile: make syntax-check a no-op from tarballs * top/maint.mk (no-vc-detected): New rule. (local-checks-available): Use it to avoid hanging if someone tries 'make syntax-check' from a tarball. Also append to any non-syntax checks already defined in cfg.mk. Signed-off-by: Eric Blake --- ChangeLog | 8 ++++++++ top/maint.mk | 9 +++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index ac57458f18..237dffc4c4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2011-02-16 Eric Blake + + maintainer-makefile: make syntax-check a no-op from tarballs + * top/maint.mk (no-vc-detected): New rule. + (local-checks-available): Use it to avoid hanging if someone tries + 'make syntax-check' from a tarball. Also append to any non-syntax + checks already defined in cfg.mk. + 2011-02-16 Paul Eggert longlong: tune, particularly for common case of c99 diff --git a/top/maint.mk b/top/maint.mk index 606d42ed18..ff2fbbb382 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -126,8 +126,13 @@ syntax-check-rules := $(sort $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p' \ $(srcdir)/$(ME) $(_cfg_mk))) .PHONY: $(syntax-check-rules) -local-checks-available = \ - $(syntax-check-rules) +ifeq ($(shell $(VC_LIST) >/dev/null 2>&1; echo $$?),0) +local-checks-available += $(syntax-check-rules) +else +local-checks-available += no-vc-detected +no-vc-detected: + @echo "No version control files detected; skipping syntax check" +endif .PHONY: $(local-checks-available) # Arrange to print the name of each syntax-checking rule just before running it. -- 2.30.2