From a0454ef2df24d238bdfd68553462c82daf6776ae Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 23 Jan 2013 22:55:24 -0800 Subject: [PATCH] RANK: Simplify fraction_name() function. The caller only needs a constant string so we might as well just return one directly rather than through a static buffer. --- src/language/stats/rank.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/language/stats/rank.c b/src/language/stats/rank.c index d9465ac422..20885659e6 100644 --- a/src/language/stats/rank.c +++ b/src/language/stats/rank.c @@ -595,25 +595,14 @@ rank_cmd (struct dataset *ds, const struct rank *cmd); static const char * fraction_name (const struct rank *cmd) { - static char name[10]; switch (cmd->fraction ) { - case FRAC_BLOM: - strcpy (name, "BLOM"); - break; - case FRAC_RANKIT: - strcpy (name, "RANKIT"); - break; - case FRAC_TUKEY: - strcpy (name, "TUKEY"); - break; - case FRAC_VW: - strcpy (name, "VW"); - break; - default: - NOT_REACHED (); + case FRAC_BLOM: return "BLOM"; + case FRAC_RANKIT: return "RANKIT"; + case FRAC_TUKEY: return "TUKEY"; + case FRAC_VW: return "VW"; + default: NOT_REACHED (); } - return name; } /* Create a label on DEST_VAR, describing its derivation from SRC_VAR and F */ -- 2.30.2